Charles Gagnon
34170e7741
Fix Loading component removal ( #13478 )
...
* Fix Loading component removal
* More undefined checks
2020-11-18 15:42:33 -08:00
Lucy Zhang
c898b50b94
Remove resultSet from IDisplayResult metadata ( #13450 )
...
* remove resultSet from IDisplayResult metadata
* remove metadata from IDisplayResult
2020-11-16 17:54:09 -08:00
Justin M
271fe62344
12567 Fixed Notebooks not adding to recent connections ( #13113 )
...
* 12567 Changed tryAddActiveConnection to always add recent connection
* 12567 Reverted change to tryAddActiveConnection. Removed this._params.input from connectionDialogService > createModel
* 12567 Simplified conditional in connectionDialogService
2020-11-16 11:27:09 -08:00
Justin M
c18a54bc1d
12666 Passed azureAccount into onFetchDatabases and set on tempProfile. ( #13239 )
2020-11-16 11:24:22 -08:00
Charles Gagnon
b57bf53b67
Fix ModelView container child layout issues ( #13412 )
2020-11-16 10:59:21 -08:00
Alan Ren
690937443c
enable the outline for active tab header ( #13415 )
2020-11-16 10:21:30 -08:00
Alan Ren
798af5fc2d
uncomment the hideContextMenu ( #13411 )
2020-11-13 16:30:17 -08:00
Charles Gagnon
af55dcfb42
Convert ModelView validate to Promise ( #13390 )
...
* Convert ModelView validate to Promise
* more cleanup
2020-11-13 15:31:22 -08:00
Charles Gagnon
76781d6cf4
Fix ModelView logging error ( #13410 )
2020-11-13 14:40:00 -08:00
Alan Ren
99e3da5b48
Editable dropdown component improvement ( #13389 )
...
* replace Tree with List
* comments
2020-11-13 13:36:54 -08:00
Charles Gagnon
cbe2ba0901
Add some more logging to ModelView components ( #13387 )
...
* Add some more logging to ModelView components
* Remove catch
* remove unused
2020-11-13 10:30:40 -08:00
Aasim Khan
bd4676ac8c
removing separate heading for page number and clubbing it with wizard title ( #13380 )
2020-11-13 00:38:04 -08:00
Charles Gagnon
536628603e
Fix ModelView container validation ordering ( #13386 )
...
* Fix ModelView container validation ordering
* Also validate component after adding
* undo child component validate call
2020-11-12 17:17:27 -08:00
Lucy Zhang
32a6385fef
Notebooks: Save cell connection name in cell metadata ( #13208 )
...
* save connection info in notebook metadata
* update attachTo dropdown based on saved alias
* add setting for saving connection (default=false)
* save/read cell connection name to/from metadata
* get started on toggling multi connection mode
* add activeConnection property to cell model
* add changeContext method for cell
* add comments
* add unit test for reading connection name
* save connection mode in metadata
* clean up code
* address PR comments
2020-11-12 10:44:34 -08:00
Kim Santiago
abdf575885
fix wizard page name and step getting announced when pages are added and removed ( #13362 )
2020-11-12 09:44:33 -08:00
Charles Gagnon
b32e5f8f25
Add debug logging for ModelView ( #13346 )
2020-11-11 10:33:13 -08:00
Alan Ren
3be00b1635
add tabindex and handle keyboard selection ( #13348 )
2020-11-10 23:00:03 -08:00
Lucy Zhang
b397150264
Notebooks: Add smoke test ( #13196 )
...
* add new smoketest
* change repro
* rename methods
* add waitforallresults method
* pr comment
2020-11-10 17:31:17 -08:00
Chris LaFreniere
8c6a966bb9
Re-enable notebook editor unit tests ( #13328 )
...
* wip
* Re-enable notebook editor tests
* PR Feedback
2020-11-10 17:04:30 -08:00
Charles Gagnon
b83da2dfa8
Run initial modelview actions first ( #13317 )
...
* Run initial modelview actions first
* add param
* Comments and typings
* Catch promise error
* fix db projects test
* remove extra calls
2020-11-10 17:00:16 -08:00
Aditya Bist
8bbcfff119
fix agent types ( #13340 )
2020-11-10 13:38:57 -08:00
Alan Ren
e076062d4f
restore focus on escape ( #13285 )
...
* restore focus on escape
* obtain focus on action click
* comment
* comment 2
* simplify the implementation
* remove the toggle action completely
* remove the import
* implement aria requirements
2020-11-10 11:31:53 -08:00
Vasu Bhog
7cd4964f35
Fix for < > (non HTML) tags disappearing in WYSIWYG ( #13267 )
...
* Push the latest update for WYSIWYG bug
* Improvements to nested lists
* OL tests and PR feedback
* Fixed all toolbar options for tags
* Address PR comments
* Ensure style is kept and not escaped
* Add all markdown toolbar action tests
* Style text edge case fix
* Address repeat function and type comment
* add more clarifying test
2020-11-09 20:26:28 -06:00
Aditya Bist
9d766198b5
fix connection and notebook icons not highlighting ( #13314 )
2020-11-09 13:12:34 -08:00
Barbara Valdez
3f76d343a5
Table with no headings gets corrupted when editing ( #13293 )
...
* fix data loss issue when modifying table with no headings
* fix comment
* Add tests and extra empty space to empty header format
2020-11-09 09:42:42 -08:00
Aditya Bist
fa9a38d74a
Update/agent ( #13298 )
...
* Revert "Fix Agent not working (#13126 )"
This reverts commit a0ee8b00fb .
* agent fix and bump
2020-11-09 09:00:03 -08:00
Charles Gagnon
8b73391845
Call ModelView base init after view init ( #13261 )
...
* Call ModelView base init after view init
* baseInit to end
2020-11-07 09:41:49 -08:00
Karl Burtram
5e00dcb78c
Update welcome page icon ( #13296 )
2020-11-06 17:06:29 -08:00
Barbara Valdez
e83d3ba57f
Remove button property setter causing exception ( #13284 )
...
* Fix navigation buttons
* Remove icon set in welcome page
2020-11-06 14:49:14 -08:00
Aasim Khan
054583e0de
Adding aria label to "check all" check box in declarative table. ( #13216 )
...
* added arialable for check all checkboxes and added some missing roles for the table elements
* removed duplicate attribute
* Moved column header aria label logic to a function.
* fixed typos in declarative table
* Changed the aria label text to something that is more intuiive.
* fixed typo in localized string identifier
2020-11-06 10:44:33 -08:00
Chris LaFreniere
e4390db779
WYSIWYG fix list nesting ( #13251 )
...
* Improvements to nested lists
* OL tests and PR feedback
2020-11-05 18:21:33 -08:00
Maddy
6c37ac56b7
fix delete behavior on text cells. ( #13153 )
...
* remove default <p> text and add css instead
* remove the top/bottom padding on preview markdown
2020-11-05 14:19:11 -08:00
Chris LaFreniere
8877d74034
Check for clientSession before property ( #13198 )
2020-11-04 16:28:59 -08:00
Charles Gagnon
fd8f88db4b
Only show resource viewer on insiders and dev ( #13238 )
2020-11-04 14:34:13 -08:00
Charles Gagnon
bfb2c20e0f
Add Azure account initialization logging ( #13235 )
2020-11-04 13:24:09 -08:00
Charles Gagnon
a0ee8b00fb
Fix Agent not working ( #13126 )
...
* Fix Agent display
* more fixes
* cleanup
2020-11-04 09:23:16 -08:00
Charles Gagnon
eeb7da4ace
Fix resource viewer grid resizing ( #13197 )
...
* Fix resource viewer grid resizing
* keep height
2020-11-04 08:34:30 -08:00
Lucy Zhang
7bdb7c328a
add unit test for data conversion ( #13190 )
2020-11-03 15:05:57 -08:00
Chris LaFreniere
7559d8463f
Ensure trusted action is enabled ( #13174 )
2020-11-02 10:48:13 -08:00
Vasu Bhog
351516f08d
Change the way we insert Injected Parameter ( #13171 )
2020-11-02 09:14:37 -08:00
Alan Ren
cb1c8503b0
handle keyboard selection ( #13175 )
2020-10-30 21:17:49 -07:00
Charles Gagnon
d7767c7d91
Resource viewer cleanup ( #13168 )
...
* Resource viewer cleanup
* uneeded
* Only show in insiders
2020-10-30 16:48:50 -07:00
Vladimir Chernov
da6f800f11
table column with iconcss ( #13056 )
2020-10-31 02:23:38 +03:00
Alan Ren
2f571d868b
show folder icon for some tree nodes ( #13161 )
2020-10-30 15:38:23 -07:00
Charles Gagnon
3015845093
Add title property for data grid providers ( #13155 )
2020-10-30 15:37:11 -07:00
Charles Gagnon
341f7aa7ad
Enable script to notebook actions under preview flag ( #13164 )
2020-10-30 15:24:35 -07:00
Lucy Zhang
69527f91b0
Notebooks: Save connection information in metadata ( #13060 )
...
* save connection info in notebook metadata
* update attachTo dropdown based on saved alias
* add setting for saving connection (default=false)
* dont show saved conn if seting off + added test
* show conn dialog if save conn name setting off
* address PR comments and fix unit test
* change connectionName to connection_name
2020-10-30 13:56:33 -07:00
Charles Gagnon
76625012dd
Add Loading Spinner plugin for SlickGrid table ( #13152 )
...
* Add Loading Spinner plugin for SlickGrid table
* better comment
* add aria
* remove
2020-10-30 11:42:22 -07:00
Alan Ren
82d5fe3821
put feature behind preview flag ( #13147 )
...
* put feature behind preview flag
* remove unused import
2020-10-30 10:17:54 -07:00
Amir Omidi
680dc1b5da
Fix #13108 ( #13145 )
2020-10-30 08:19:08 -07:00