Commit Graph

3577 Commits

Author SHA1 Message Date
Cory Rivera
950bb1e53b Fix issues with changing SQL notebook connection while a cell is executing (#19624) 2022-06-03 18:05:32 -07:00
Aasim Khan
b63fd59372 Adding plan properties comparison, fixed dark icons, fixed dropdown text. (#19601)
* Adding prop compare logic

* Fixed using semaphore

* Adding dark icons
Adding dropdown prefix
Adding all visible plans from plan comparison

* Reverting mssql vbump

* Fixing icon name

* executionPlanComparisonPropertiesView

* Fixing icon paths and adding preselect model

* Fixed icon spacing

* Removing styling in formatter

* Adding tooltip to plugs
switching to plugins

* Removing unecessary calls to getSkeletonNodes()

* Renaming variable

* Fixed column value formatting

* Undoing formatter change
2022-06-03 16:31:03 -07:00
Alan Ren
c4cc2e5d68 fix casing (#19619) 2022-06-03 14:42:57 -07:00
Lewis Sanchez
b52386a36a Execution Plan Telemetry for Plan Comparisons (#19610)
* Adds telemetry when plan comparison is invoked

* Small formatting change.

* Adds telemetry to add execution plan button

* Removes unused ExecutionPlanComparisonEditorView constructor parameters

* Small formatting adjustment

* Adds telemetry to ExecutionPlanComparisonEditorView properties

* Code review changes
2022-06-03 13:56:32 -07:00
Christopher Suh
1b9f4cbbae Changed add connection -> new connection (#19596)
* changed add connection -> new connection

* remove xlf file changes

* fix spacing

* fix workspace settings
2022-06-02 14:04:34 -07:00
Kim Santiago
1bbf5a78c1 enable table designer for table script in sql database project (#19237)
* add 'open in designer' to context menu of tables in sql projects

* fix tests

* Address comments

* enable table designer for sql database proj

* update label and issues on init

* vbump sts

* use promisified fs

* pr comments

Co-authored-by: Alan Ren <alanren@microsoft.com>
2022-06-02 13:27:47 -07:00
Charles Gagnon
d3c474162d Fix renderer error string (#19599)
* Fix error string localization

* fix

* fix
2022-06-02 12:42:27 -07:00
Alan Ren
d166d982c4 make sure controls are enabled (#19595) 2022-06-02 10:09:27 -07:00
Barbara Valdez
f06fd7f6f7 Fix split cell not working with attachments (#19587) 2022-06-01 16:23:46 -07:00
Charles Gagnon
071f631c34 Fix null ref in tree (#19589)
* Fix null ref in tree

* Correct type
2022-06-01 12:47:52 -07:00
Charles Gagnon
41a3c8661c Fix GetConnection (#19579) 2022-05-31 21:32:44 -07:00
Alan Ren
11a969f44f workaround for the dashboard resets zooming issue (#19576) 2022-05-31 21:04:23 -07:00
Alan Ren
f41da46ccb remove the tracing (#19573) 2022-05-31 12:56:48 -07:00
Alan Ren
1d276d90e0 adjust the grid's height in table designer (#19550) 2022-05-26 17:54:23 -07:00
Charles Gagnon
45d7a6dd62 Clean up docs for connect and ConnectionResult (#19509)
* Clean up docs for connect and ConnectionResult

* links

* fix build

* fix
2022-05-25 10:38:00 -07:00
Aasim Khan
6282958bd1 scoping css (#19520) 2022-05-25 10:31:29 -07:00
Alan Ren
254f16b31a hide account when using connection string (#19506) 2022-05-24 11:19:34 -07:00
Aasim Khan
8bb6b5fc1a Redoing Execution Plan Comparison Editor (#19375)
* Adding code for execution plan comparison editor

* Handling floating promises and fixing a loc string

* Fixing some polygon stuff

* Fixing azdatagraph null check bug

* Adding progress notification for similar areas

* Removing some floating promises

* Fixing button enabled state
2022-05-23 14:33:18 -07:00
Laurent Nguyen
97a4ecdfbb Add support for CosmosDB - Mongo API (#19386)
* Display cdb nodes to browse azure tree

* Update icons

* Update node label

* Remove console logs

* Fix i18n in cosmosDbMongoTreeDataProvider

* Disable Mongo provider in azure tree for now

* Revert "Disable Mongo provider in azure tree for now"

This reverts commit 8b2d2079f43624596a41b82a71a5e40eef1ad4b1.

* Fix build issues related to merge

* Add COSMOSDB_MONGO in provider extension map

* Define providerId string as constant. Rename constants to follow azurecore/ naming conventions (all caps)
2022-05-19 11:12:53 -07:00
Aasim Khan
e04c1624bc Adding the mirrored parallelism icon (#19391) 2022-05-17 02:01:45 -07:00
Karl Burtram
701f656c55 Fix connection issue with wrong resource endpoint (#19387)
* Fix connection bug accessing PBI resource

* Address CR feedback

* Fix null check
2022-05-16 15:23:23 -07:00
Alan Ren
3b74d7843f show proper message when extension is not installed for a connection provider (#19377)
* show extension not installed error

* extension provider mapping

* fix tests
2022-05-15 13:52:28 -07:00
Alan Ren
b8858f011d support for connect with connection string (#19355)
* wip

* WIP

* radio button

* handle connection string

* fix test

* fix test

* fix test cases

* remember password

* pr comments

* pr comments
2022-05-13 14:48:12 -07:00
Aditya Bist
128767c713 Added clickable more info links to designer validation issues (#19365)
* added clickable more info links to designer validation issues

* fix selection issue

* remove more info if none

* change quote style

* clear the dom node
2022-05-13 13:35:22 -07:00
Aditya Bist
784d8e9e96 Table Designer: Move columns UI (#19154)
* format

* added buttons and initial drag plugin

* initial drag and drop working

* add actions and taskbar

* drag and drop bugfix and other changes

* fix few issues

* more changes

* fix all move and insertion issues

* PRcomments

* fit and finish comments

* remove dead code

* bump sts

* add style for object being dragged

* add plugin to copyright filter

* Add to eslintrc

* fix drag contrast ratio

* generalize logic for cell focus

* demo feedback

* feedback

* add action state

* feedback

* remove unncecessary check

* add move actions to context menu

* change to const

* fix bug with tables and fix drop color

Co-authored-by: chgagnon <chgagnon@microsoft.com>
2022-05-12 10:49:45 -07:00
Nemanja Milovančević
65ef41d53d UI for the Backup/Restore Managed Instance Feature (#19244)
* Rebase from main branch

* Made mssql a module

* remove rpc specific stuff

* Added create sas RPC call

* Backup to url works now

* Moved createSas RPC to the BlobService

* Relocated createSas RPC from sql-dataprotocolclient to the mssql

* After rebase

* Removed duplicate symbol

* Renamed Blob to AzureBlob and relocated CreateSasResponse to mssql extension

* Removed AzureBlobProvider, removed AzureBlobService feature

* renamed blob to azureblob, converted thenable to promise

* Simplify API

* fixes

* docs update, blob to azureblob update

* UI design first commit

* Detected Managed Instance, trying to script backup to url

* azure subscription api added, but ADS crashes

* Created url dialog component and added link account

* Changed backup component UI logic

* Changed b/r UI, added restore from URL, detected MI from restore component

* Removed mocked and added real Azure API, changed RestoreDialog UI

* Added file fetching API

* added create sas RPC call

* Backup to url works now

* Fixed some bugs

* Moved createSas RPC to the BlobService

* Relocated createSas RPC from sql-dataprotocolclient to the mssql

* Rebase createSas changed to the backupRestoreManagedInstance

* PR comments fix

* Enabled backup to url for gov clouds

* Replaced anchor element with Link class

* Fixed pick azure account logic

* Removed duplicates from eslintrc

* Fixed url browser dialog

* Fixed restore UI, disabled url empty url browser dropdowns, fixed backup OK button

* bumped sts version

* bumped sts version

* Fix config

* Fixed URL browser dialog UX

* Backup and restore dialog fix

* Referencing azure resource types directly

* Scoped url browser dialog css classes

* Made the url browser dialog field a local variable

* moved url browser files from fileBrowser to the urlBrowser folder

* Changed deviceType from number to enum

* Added all device type options

* Moved mssql

* Added MI backup button comment

* Removed unhelpful comment

* Revert differential copy only backup mistake

* Renamed azurebrowser to urlBrowserDialog

* Localize create sas button label

* Removed unnecessary spinner

* Use UTC date instead of locale date

* Removed * and added required flag

* Use async instead of nested thens

* Added target database tooltip

* Using deferred promise instead of event emitter

* Added error handling to the url browser dialog

* Registered backup component elements

* Register backup component listeners

* Removed redundant setDefaultBackupPaths call

* Added setBackupPathList docs

* Add return types

* Remove code from comment

* Register restore dialog elements

* Register restore dialog listeners

* Pass engine edition enum instead of boolean

* Capitalize enum values

* DatabaseEngineEdition fix

* Use DeviceType instead of number

* Use deferred pointer

* Add new ModalDialogName

* Use constructor fields

* Register URL browser dialog components

* Remove unnecessary helper function

* nextYear function doc and move

* split registerListeners method

* showDialog returns promise

* Backup device type comment

* Pass aria label through constructor

* Fix backup button

* Remove comment

* Comment unsupported MI backup options

* Remove one liner helper function

* Restore dialog methods return types

* Remove comment

* JS doc format

* Renamed UrlBrowserDialog to BackupRestoreUrlBrowserDialog

* Moved MediaDeviceType, added PhisicalDeviceType

* Reorder and rename physical device type

* remove extra spaces

Co-authored-by: chgagnon <chgagnon@microsoft.com>
2022-05-11 11:01:06 -07:00
Alan Ren
75ab9b6812 fix json cell handling issue (#19310)
* fix json cell handling issue

* pr comment
2022-05-09 16:54:06 -07:00
Aasim Khan
7e57503aa6 Adding ability to expand and columns slickgrid table rows (#19168)
* Adding ability to expand and columns tables

* Bolding icons
Fixing variable names

* Adding helper function
Making css more target

* Adding keyboard navigation and parsing treegrid data

* Adding attributes, data transformations and key events to the treegrid

* Expanded

* changing var name

* FIxing formatter name

* Adding back cell styling

* Removing comments

* Making a new TreeGrid component.
Separating treegrid logic from tableDataView

* Fixing comments

* changing method name

* Modifying only visible row dom attributes

* Removing white space, moving role attribute setter to constructor.

* Fixing some more PR comments

* Adding comments and renaming functions

* Fixing comments

* Fixing comments

* Fixing comments

* Fixing some logic and removing unused attributes from element

* Adding expandable formatter to the first column

* Making the formatter generic

* Reverting formatter code

* Adding doc comments

* Fixing comments

* Removing duplicated code

* Adding comments

* Setting columns only when the table is initialized

* Letting users set expanded state instead of forcing it to false
2022-05-09 15:53:22 -07:00
Lewis Sanchez
5f48e4a28d Adds hot key combination for finding nodes in execution plans. (#19303)
* Adds hot key combination for finding nodes in execution plans.

* Captures cmd + f key combinations for other platforms

* Stops event propagation when targeted hot key sequence is pressed
2022-05-06 14:14:47 -07:00
Aasim Khan
20800a4279 Fixing keyboard navigation in execution plan graph and using selection change events to get selected cells (#19294) 2022-05-06 12:31:00 -07:00
Cory Rivera
5afdf04aba Remove preview restriction for various notebook toolbar features. (#19296) 2022-05-05 19:15:34 -07:00
Cory Rivera
13b722eaf8 Show a notification when trying to run an untitled notebook with parameters. (#19286) 2022-05-04 13:26:26 -07:00
Lucy Zhang
4d8fdf5833 Have screen reader announce when cell execution is complete (#19249)
* add tab index to cell output

* add sr-only element to announce cell exe complete

* use onExecutionComplete event

* remove extra change

* simplify alert message

* add alert for cell execution start
2022-05-04 10:44:24 -07:00
Cory Rivera
8cc66dade3 Fix intellisense for .NET Interactive SQL kernel (#19254) 2022-05-02 13:44:33 -07:00
Charles Gagnon
8d45e40901 Add event to track node expansion errors (#19248) 2022-04-29 11:02:58 -07:00
Aasim Khan
d0aae8e95b Adding ability to style cells in slickgrid (#19195) 2022-04-25 09:09:53 -07:00
Alan Ren
402604ba34 remove the preview feature flag check (#19194) 2022-04-23 20:07:43 -07:00
Cory Rivera
7b58568d26 Convert .NET Interactive notebook's kernel spec to a VS Code compatible kernel when saving. (#19176) 2022-04-22 16:00:13 -07:00
Aasim Khan
7554fbcaa0 Fixing zoomed badges (#19178) 2022-04-22 11:57:18 -07:00
Nemanja Milovančević
1cf905a7b8 Create shared access signature RPC (#18823)
* Rebase from main branch

* Made mssql a module

* remove rpc specific stuff

* Added create sas RPC call

* Backup to url works now

* Moved createSas RPC to the BlobService

* Relocated createSas RPC from sql-dataprotocolclient to the mssql

* After rebase

* Removed duplicate symbol

* Renamed Blob to AzureBlob and relocated CreateSasResponse to mssql extension

* Removed AzureBlobProvider, removed AzureBlobService feature

* renamed blob to azureblob, converted thenable to promise

* Simplify API

* fixes

* docs update, blob to azureblob update

* bumped sts version

* Fix config

Co-authored-by: chgagnon <chgagnon@microsoft.com>
2022-04-21 10:30:46 -07:00
Charles Gagnon
e9fefd2487 Fix typings pipeline + cleanup (#19163) 2022-04-21 10:30:18 -07:00
Chris LaFreniere
6c4bf812cd Notebooks: Preventing "previousSibling of Null" Errors on Cell Selection (#19153)
* Defensive programming

* PR comments
2022-04-20 17:37:38 -07:00
Aditya Bist
909d022562 change style (#19159) 2022-04-20 13:05:53 -07:00
Aditya Bist
449d27a5ae Add confirmation dialog before closing app (#19139)
* added confirmation dialog before closing app

* only one prompt for multiple open table designers
2022-04-19 20:26:22 -07:00
Alan Ren
6395402b80 fix activitybar icon focus style (#19150)
* fix activity bar icon accessibility issue

* use state
2022-04-19 14:26:49 -07:00
Alan Ren
5ec567a4f7 add title for color box (#19121) 2022-04-15 12:56:07 -07:00
Lewis Sanchez
010107aea8 Telemetry for Query Execution Plans (#19039)
* Adds telemetry around how the properties window is opened

* Adds telemetry around accessing execution plan top operations

* Adds key for viewing top operations

* Adds telemetry around using the open query button and context menu item

* Adds telemetry around execution plan zoom in, out, to fit, and custom

* Adds telemetry around searching for nodes in execution plans

* Reduces telemetry additional properties to 1.

* Code review changes

* Removes unnecessary export
2022-04-14 11:41:35 -07:00
Barbara Valdez
7a8681481e fix cell nav (#19082) 2022-04-14 10:49:17 -07:00
Cory Rivera
8bd5ea5c84 Only update hover execution state if cell is not active. (#19073) 2022-04-14 10:19:58 -07:00
Aasim Khan
d7f8b0bfed Fixing parallism icon not showing up (#19085) 2022-04-14 00:19:36 -07:00