Commit Graph
100 Commits
Author SHA1 Message Date
Aasim Khan df481311ed Adding new database inline icon (#24375) 2023-09-13 09:33:00 -07:00
Aasim Khan 2fce9c5b38 Adding sql core dll to esrp code signing and updating sts (#24157) 2023-08-17 21:25:22 +00:00
Aasim Khan 752c33c960 Vbumping vscodetestcover (#24133) 2023-08-15 17:22:30 +00:00
Aasim Khan 7144703273 Commenting out listener threshold to fix extensions having mem leaks registering more listeners. (#24012)
* Commenting out listener threshold

* Adding SQL carbon edit
2023-07-28 13:52:18 -07:00
Aasim Khan 760ccfdef3 Removing unnecessary tree expansions causing errors to popup again (#23932) 2023-07-19 15:42:56 -07:00
Aasim Khan 38312de87b Fixing issue that caused moving connections from one group to other to throw (#23933) 2023-07-19 15:33:26 -07:00
Aasim Khan 99bf9f20e6 Setting right options of command based new connections (#23849) 2023-07-12 23:58:45 -07:00
Aasim Khan 5452c7f3ab Fixing chartjs (#23831) 2023-07-12 22:52:23 -07:00
Aasim Khan 953ea05802 Fixing unsupported providers behavior on Async Server Tree (#23758)
* Throwing error so that connection loading fails.

* Fixing stuff

* Fixing tests
2023-07-11 22:59:00 -07:00
Aasim KhanandCharles Gagnon 8fa62fe519 Adding null checks in disconnecting connections from async tree (#23636)
* Adding null checks in disconnecting connections

* Fixing stuff

* Update src/sql/workbench/contrib/objectExplorer/browser/serverTreeView.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2023-07-11 17:00:18 -07:00
Aasim Khan 28e59f44e2 Adding execution plan component to model view. (#23620) 2023-07-05 13:33:28 -07:00
Aasim Khan 0484cd086c Remove server group colors from connection profile in OE (#23622)
* Remove server group

* remove css
2023-07-04 10:55:19 -07:00
Aasim Khan d98470e34e Adding libssl to build-image to sign extension. (#23606) 2023-07-03 10:44:09 -07:00
Aasim Khan dcef1d98a0 Fixing setting layout in OE (#23536) 2023-06-29 00:09:05 -07:00
Aasim Khan 78ccf9fe0d Replacing contains filter from like filter in OE (#23422) 2023-06-28 22:51:14 -07:00
Aasim Khan 1bbadd8162 Fixing filter layout (#23537) 2023-06-28 22:50:48 -07:00
Aasim Khan e52aa01cf0 Removing preview flag from OE filtering (#23486)
* Removing preview flag from OE filtering

* Fixing double node path bug

* Cleaning header
2023-06-28 10:25:38 -07:00
Aasim Khan b028d12577 Upgrading chartjs to 4.3 and removing ng2-charts from modelview (#23398)
* Upgrading chartjs

* Upgrading charjs in exthost and removing ng2-charts

* Updating lock file

* Fixing paths in workbench for new chartjs

* Removing more any

* Removing more any

* Fixing colors

* Fixing more stuff

* Updating distro hash
2023-06-20 18:03:56 -07:00
Aasim Khan 604c1e7861 Adding aria-labels to checkbox cells in declarative table (#23204) 2023-06-09 15:28:53 -07:00
Aasim Khan 9b94f82b2e Adding status message for connection and connection group deletion. (#23325) 2023-06-06 20:35:10 -07:00
Aasim Khan d759346509 Fixing icon (#23314) 2023-06-05 09:11:36 -07:00
Aasim Khan 30edf8d57b Fixing copy headers (#23280) 2023-05-31 22:25:41 -07:00
Aasim Khan c16fce3ab9 Removing inline actions from context menu in OE (#23281) 2023-05-31 21:33:02 -07:00
Aasim Khan 2717a9b16d Vbumping import extension (#23227) 2023-05-25 17:31:42 -07:00
Aasim Khan a1c5adf4b2 Adding visual label to find node widget (#23197) 2023-05-24 10:21:38 -07:00
Aasim Khan 3bec68b860 Fixing server group styling (#23144)
* Fixing server group styling

* Hiding border when the tree item are selected focused or hovered

* Fixing styles and re-enabling guides

* removing unused import

* Fixing indicator width
2023-05-22 09:53:47 -07:00
Aasim Khan e322641538 Fixing OE nodes error handling. (#23172) 2023-05-19 08:49:13 -07:00
Aasim Khan 63f36594db Fixing group name in edit connection dialog (#23010)
* Fixing group name in edit connection dialog

* Fixing test

* adding back group name

* Keeping old apis the same
2023-05-17 17:22:43 -07:00
Aasim Khan d9220c809c Adding collapse all to OE (#23132) 2023-05-16 09:20:51 -07:00
Aasim Khan 20f409adca Fixing default (#23139) 2023-05-15 21:33:56 -07:00
Aasim Khan 787a66922f Adding filtering to group by schema and switching to using name from displayName in oe filters. (#23123) 2023-05-13 09:25:07 -07:00
Aasim Khan 2beba9ac08 Adding inline actions to OE (#23101) 2023-05-13 09:24:49 -07:00
Aasim Khan 39087ba5ce Fixing OE disconnecting connections when other types of connections are disconnected. (#23080) 2023-05-12 07:28:41 -07:00
Aasim KhanandCharles Gagnon a4077c3d89 Adding telemetry to ads OE filter (#23089)
* Adding telemetry to ads oe filter

* Fixing prop names

* fixing prop name

* Fixing localized strings

* Update src/sql/azdata.proposed.d.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Update src/sql/workbench/contrib/objectExplorer/browser/serverTreeView.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2023-05-11 13:27:34 -07:00
Aasim Khan c7d62e31fb Fixing async tree search highlighting (#23012)
* Fixing tree searching highlight

* Code cleanup

* Fixing server group styling
2023-05-11 10:17:38 -07:00
Aasim Khan 60a280042d Readding filtering back into main (#23064) 2023-05-09 16:32:58 -07:00
Aasim Khan 25bc14fb25 Adding filtering dialog and action to OE (#22937)
* Adding init change

* Adding filter cache in OE

* Adding more filtering changes

* Fixed stuff with dialog

* Fixing filter

* Adding support for connecitons

* Fixed stuff

* filtering

* Fixing  date

* Filters

* Removing is filtering supported

* Removing contracts

* Fixing filters

* Fixing cache

* Adding some accessibility changes

* Reverting some more changes to pull in changes from the main

* Adding comments

* Fixing boolean operators

* Fixing stuff

* Fixing stuff

* Fixing error handling and making dialog generic

* Fixing more stuff

* Making filter a generic dialog

* adding erase icon

* removing floating promises

* Fixing compile issue

* Adding support for choice filter with different and actual value.

* Adding null checks

* Adding durability type fix

* Fixing filtering for providers that do not play well with empty filter properties
2023-05-08 11:00:59 -07:00
Aasim Khan f605a3c644 Fixing node retention after disconnect (#23020) 2023-05-08 10:13:53 -07:00
Aasim Khan 6fa948adbe Fixing delete server group error when we try to focus on root (#23019) 2023-05-08 09:46:40 -07:00
Aasim Khan 3ae97b81f2 Fixing the error showing up in console log (#23018) 2023-05-08 08:29:39 -07:00
Aasim KhanandCharles Gagnon 302855e4a4 Fixing async server tree error handling and removing timeout. (#22955)
* Fixing async server tree issues and removing timeout

* removing empty results for connection errors

* Fixing error message fetching

* Update src/sql/workbench/services/objectExplorer/browser/asyncServerTreeDataSource.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2023-05-04 15:50:37 -07:00
Aasim KhanandCheena Malhotra b86463ee71 Adding filtering to OE Service (#22900)
* Adding filtering to OE Service

* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts

Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>

* Update src/sql/workbench/services/objectExplorer/browser/serverTreeRenderer.ts

Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>

* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts

Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>

* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts

Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>

* Fixing compile errors

* Fixing circular dependency

---------

Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>
2023-04-29 17:22:38 -04:00
Aasim KhanandCharles Gagnon 9c68043137 Adding OE filtering interfaces. (#22738)
* Adding interfaces for tree filtering

* fixing type

* Adding enums in sqlhost

* Fixing comment

* Fixed filters lol

* Fixing some contract definitions

* Removing flag

* Update src/sql/azdata.proposed.d.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Removing filters

* Removing filters2

* Fixing enum

* Fixing interface and enum names

* Fixing interface name

* Update src/sql/azdata.proposed.d.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Removing type from filter

* Adding is null and is not null operators

* Fixing enums

* Update src/sql/azdata.proposed.d.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Update src/sql/azdata.proposed.d.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Update src/sql/azdata.proposed.d.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2023-04-27 13:15:11 -04:00
Aasim Khan fe086dc778 Fixing adding connections on a new ads install (#22760)
* Fixing stuff

* Fixing connection groups as well
2023-04-18 08:39:53 -07:00
Aasim Khan b7d24dcecd Cleaning up some code in Async Server Tree. (#22732) 2023-04-17 23:23:41 -07:00
Aasim Khan 8d9ddebd98 Adding restart ads notification when async server tree is toggled (#22726) 2023-04-14 07:54:28 +01:00
Aasim Khan 577d99e790 Fixing dup connections (#22670) 2023-04-11 14:16:59 -07:00
Aasim Khan 5ae0e3a503 Removed parent override (#22648) 2023-04-06 15:26:50 -07:00
Aasim Khan 958a3f85e5 Enabling async server tree in insiders (#22596) 2023-04-03 17:15:52 -07:00
Aasim Khan 38a3312cb6 Fixing edited connections not working for root in Async Server Tree (#22580)
* Fixing edited connections not working for root

* Fixing comment
2023-04-03 11:58:19 -07:00
Aasim Khan d49ff85afc Fixing connection without saved password not connecting in Async Server Tree (#22535) 2023-03-31 09:19:01 -07:00
Aasim Khan a1acaf2096 Adding caching in OE service (#22539) 2023-03-31 09:18:36 -07:00
Aasim Khan 4ff16885c1 Cleaning update children logic in async server tree (#22550) 2023-03-30 15:17:45 -07:00
Aasim Khan 2a9705c495 Fixing async server tree (#22511)
* Changing look of new OE

* Fixing styling

* Fixing moving of connected profile

* Fixing drag and drop where treenodes delete connection nodes

* Fixing Deleting and disconnecting in AsyncServerTree

* Adding constant for OE timeout

* Updated interfaces

* Removing test compilation errors

* Fixing most events in async server tree

* Fixing connection pane styling

* Fixing find node function

* Fixing some more operations

* Fixing some ops

* All operations done

* Fixed active connections

* Fixed data source

* Adding support for setting parents

* code cleanup

* Fixing icon styling issues

* Fix errors

* Fixing comment

* Fixing spacing

* Adding explanation to OE service.

* Reverting server delegate changes

* Reverting styling

* reverting more styling change

* reverting more styling

* Fixing has children

* Fixing drag and drop to tree nodes

* fixing drag and drop

* reverting timing

* fixing drag and drop

* cleaning some code

* Fixed server and group moving

* spell check

* consolidating some logic

* Fixed whitespace

* fixing moving to root group
2023-03-29 13:59:35 -07:00
Aasim KhanandCharles Gagnon f60bd1335c Adding promises and operation timeouts to fix race conditions and infinite loading in OE (#22475)
* Adding promises and operation timeouts to fix race conditions

* cleaning up logic

* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Fixing promise type

* Reverting back to old error logic

* Making onsessioncreated async

* Removed polling and converted to event based

* removing connection variable out of promise

* Combining promises

* Update src/sql/workbench/services/objectExplorer/browser/treeUpdateUtils.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Fixing error messages and localizing user facing errors

* Fixing error message

* localizing config

* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Fixing comment

---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2023-03-28 18:36:45 -07:00
Aasim Khan 3aee3f006a Fixing icon styling in tree (#22490) 2023-03-28 09:23:15 -07:00
Aasim Khan e80c6f2dcb Fixing async tree styling (#22458) 2023-03-27 13:16:23 -07:00
Aasim Khan f9e72b0d93 Fixing connection group change for connections (#22379) 2023-03-20 15:37:47 -07:00
Aasim Khan f0a5d296bf Fixing new connections not expanding in object explorer. (#22307)
* Fixing new connection node not expanding in OE

* Fixing new connections not expanding and fixing expand request not resolving because of some provider error.

* Fixing test

* Adding a setting for node expansion timeout

* Not saving when loading tree based connections

* Adding some logs

* Removing special casing for mssql provider

* Missing providers

* Adding user toast for node expansion timeout

* Adding notification service to test

* Fixing node type for mssql

* remove polling

* Fixing onNodeStatus

* Fixing stuff

* consolidating functions

* Consolidating resolve logic

* removing extra try catch

* code cleanup

* adding size checks

* Removing commented code

* Ignoring errors from other sessions and nodepaths.
2023-03-14 10:50:46 -07:00
Aasim Khan 9fddefc8fb Fixing execution plan not finding provider (#22238) 2023-03-08 12:55:49 -08:00
Aasim Khan 84c9a03bf9 Fixing icon for group by schema (#22212) 2023-03-08 12:13:49 -08:00
Aasim Khan d3f4f0daa4 Adding light contrast theme (#22028)
* Adding light contrast theme

* fixing oe icons

* Fixing more files

* Converting ep files to support hc light

* Revert "Copy Headers for Selected Columns (#21622)"

This reverts commit f74d6f6d9b.

* Adding more css rules

* Fixing modal

* Fixing azure icons
2023-03-06 17:31:27 -08:00
Aasim Khan 644f5a16ef Fixing URI openings for execution plans (#22139) 2023-03-04 15:14:50 -08:00
Aasim Khan 9033ed5583 Adding group by schema button to OE (#22083) 2023-03-02 11:35:33 -08:00
Aasim Khan 555f8fbb1e Adding null checks to prevent runtime exceptions (#22054) 2023-02-27 23:46:14 -08:00
Aasim Khan 45d41347ba Adding null checks and fixing values in slickgrid checkbox column plugin (#22050)
* Adding null checks to checkbox column

* Setting default value for undefined checkbox
2023-02-27 18:52:16 -08:00
Aasim Khan dbd1c1b5b3 Fixing table being announced for button (#22024)
* Fixing table being announced for button

* Fixing issue in the component

* Reverting other changes
2023-02-27 11:24:58 -08:00
Aasim Khan 4fd6a57afc Adding aria label (#22030) 2023-02-27 10:43:15 -08:00
Aasim Khan c3e0478447 Adding aria role to hyperlink cell in slickgrid (#21998)
* Adding aria role to hyperlink

* Adding default
2023-02-22 10:42:11 -08:00
Aasim Khan 22c3829225 Adding setting for OE expansion timeout (#21985)
* Adding setting for OE expansion timeout

* Cleaning up the names

* Adding minimum timeout value
2023-02-17 23:02:57 -08:00
Aasim Khan e40c8dda25 Removing migration contracts from mssql (#21966)
* Removing migration contracts from sts

* Update sts

* Pushing latest sts
2023-02-17 13:50:53 -08:00
Aasim Khan 48d0aa72cc Replacing select with focus in OE (#21954) 2023-02-15 17:27:36 -08:00
Aasim KhanandCharles Gagnon d6c35836cc Adding group by schema to OE (#21941)
* Adding group by schema and updating schema icon

* Adding item context menu

* Fixing command logic

* Adding telemetry for group by and changing default config

* reverting no child nodes error message

* Code cleanup

* Cleaning up constants

* Removing unused imports

* Update extensions/mssql/src/main.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* converting to sendActionEvent

* sendActionEvent

* Adding telemetryViews and telemetry actions

* Fixing localized string

* registering context

---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2023-02-15 15:18:10 -08:00
Aasim KhanandAkshay Mata 837236be0f Modifying the migration extension to use its own service. (#21781)
* Adding migration service to sql migrations

* enabling auto flush log

* Adding support for env variable

* Adding TDE Migration service

* code cleanup

* updating service downloader

* Removing custom output channel

* remove unnecessary await

* Updated service version to get latest code

* Consolidate TDE into migration service

* Sync to latest main

* Update sql-migration package version

* Fix merge conflict error

* Fixing all merge conflicts

* Fixing stuff

* removing extra whitespace

* Cleaning up

---------

Co-authored-by: Akshay Mata <akma@microsoft.com>
2023-02-12 09:59:09 -08:00
Aasim Khan 95d4f130c6 Replacing select with focus to prevent second create session (#21811) 2023-02-02 15:07:05 -08:00
Aasim Khan ccc8df31c7 Adding prompt for delete connection (#21624)
* Adding prompt for disconnect

* changing to Idialog service

* Code cleanup and fixing comments

* Adding comments and making a test async

* removing then and awaiting for function
2023-01-23 22:56:09 -08:00
Aasim Khan 4971a94244 Fixing nvda (#21625) 2023-01-20 12:51:34 -08:00
Aasim Khan 3b31d1018f Adding better handling for checkbox column based row selection (#21553)
* Adding better handling for checkbox column based row selection

* Replacing any with proper typings
2023-01-18 01:20:26 -08:00
Aasim Khan ed43817da7 Revert "Auto closing issues that needs logs after 7 days of inactivity. (#21390)" (#21403)
This reverts commit 30f4a3554a.
2022-12-12 13:45:46 -08:00
Aasim Khan 30f4a3554a Auto closing issues that needs logs after 7 days of inactivity. (#21390)
* Adding old issue

* Adding needs more info

* Making a different step for every issue label
2022-12-12 12:31:47 -08:00
Aasim Khan 7bc8aa8d1f updating data client protocol in import extension (#21391) 2022-12-09 16:10:29 -08:00
Aasim Khan d0b2dc702f Updating out of scope comment (#21384) 2022-12-08 16:38:40 -08:00
Aasim Khan 1117a72ade Updating decode URI lib (#21349) 2022-12-01 22:13:45 -08:00
Aasim Khan 945a134018 Vbumping electorn (#21336) 2022-11-30 12:19:12 -08:00
Aasim Khan c0a194df4a Adding wizard and dialog footer loading spinner (#21230)
* Adding wizard and dialog loading

* Moving apis to proposed

* fixing namespace

* Only firing event when the value changes

* Only firing when value is changed

* Adding loading complete message to dialog and wizard

* Registering listeners and making a new base interface for loading components

* Fixing api comment

* Renaming prop to loadingCompleted

* old loading icon
2022-11-30 12:18:34 -08:00
Aasim Khan 813fa6b2ef Updating qs lib across ads (#21323) 2022-11-29 11:40:22 -08:00
Aasim Khan c8a80a5270 Adding SQL Carbon edit comment (#21202) 2022-11-10 15:46:05 -08:00
Aasim Khan 298cc4676b Updating id generation logic to avoid substring overlaps (#21181) 2022-11-09 15:40:20 -08:00
Aasim Khan 00b797b4f3 Adding keyboard shortcuts for column resizing in slickgrid (#21100)
* Adding column resize keyboard shortcuts in slickgrid

* Switching to standard keyboard evt

* Adding comment for the functionality

* Cleaning up code and adding more comments

* Using quick input to get column resize width

* Adding check for negative sizes

* Fixing some stuff
2022-11-04 16:15:04 -07:00
Aasim Khan 355c750fce Removed plan tree as default for screen reader mode (#21082) 2022-11-02 15:30:56 -07:00
Aasim Khan 4823a76833 Adding screen reader optimized mode to slickgrid (#21069) 2022-11-02 15:11:16 -07:00
Aasim Khan 998b528680 Fixing schema compare checkbox column functions (#21025)
* Fixing select checkbox event and data state changes

* Only subscribing to event when check all is present

* converting object to map

* logic cleanup
2022-10-28 18:15:48 -07:00
Aasim Khan 968f4c7aa4 Fixing result grid plans not opening execution plan editor. (#21022) 2022-10-28 10:28:54 -07:00
Aasim Khan 512eba5675 Remove preview checks from ep (#21008) 2022-10-27 10:05:16 -07:00
Aasim Khan 1743c7ea13 Fixes: (#21004)
1. Navigation info announcement when user enter graph
2. Allowing users to expand/collapse button
3. Tooltips shown only when enter is pressed
2022-10-26 22:16:36 -07:00
Aasim Khan 4d5e9adbc1 Adding option to sort columns using F3 key in SlickGrid. (#20897) 2022-10-25 08:22:31 -07:00
Aasim Khan 84305c32c0 Adding accessible tooltips and tooltip based alerts (#20912) 2022-10-21 14:28:27 -07:00
Aasim Khan 5942980300 Adding missing stream icons for execution plan (#20896) 2022-10-20 15:24:30 -07:00
Aasim Khan e6b36cec0f Changing tree grid toggle icon color when the cell is selected (#20868)
* Changing toggle color when selected

* Using styles to support chevron coloring

* Adding escape to fix hygiene issues

* Fixing hygiene error
2022-10-20 13:53:28 -07:00
Aasim Khan d5c63f4bfb Fixing aria bug (#20872) 2022-10-19 19:39:46 -07:00