ckaczor/azuredatastudio
Archived
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
9,636 Commits 1 Branch 152 Tags
cb32513f9e3c5765dc8897705e2973041dee3abc
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Chris LaFreniere 6125708b25 Reenabling book trust manager tests (#23594) 
* Reenabling book trust manager tests

* Also fix trustbook test
 2023-07-06 15:47:16 -07:00
Chris LaFreniere 6c596d8495 Skip failing smoke tests (#20331) 2022-08-12 15:18:27 -07:00
Chris LaFreniere 78b5e52bf7 re-enable notebook outputprocessor tests (#20000) 2022-07-12 10:11:35 -07:00
Chris LaFreniere 4f2a430c77 Fix Uncalled Function (#19819) 2022-06-23 17:14:39 -07:00
Chris LaFreniere 1b1117f07d Attempt to Fix Unstable Notebooks Tests (#19806) 
* Add check if currentBook exists

* adding checks for currentBook
 2022-06-23 17:14:15 -07:00
Chris LaFreniere 6c4bf812cd Notebooks: Preventing "previousSibling of Null" Errors on Cell Selection (#19153) 
* Defensive programming

* PR comments
 2022-04-20 17:37:38 -07:00
Chris LaFreniere 6acda40894 Cleanup references to ADS (#19157) 2022-04-20 14:38:20 -07:00
Chris LaFreniere af3d307d40 Restart kernel initial implementation (#18835) 
* Restart kernel initial implementation

* Update notebook extension TestKernel

* PR comments
 2022-03-29 12:56:52 -07:00
Chris LaFreniere 230c0f317f Notebooks: Add telemetry event for mime type renderer not found (#18200) 
* Add event for mime type renderer not found

* Add back missing return statement
 2022-02-03 09:48:06 -08:00
Chris LaFreniere 3cd9a562c8 Remove Extra Split Cell in notebook task bar (#18020) 2022-01-07 12:57:05 -08:00
Chris LaFreniere ce7935e7d2 Notebooks: Add Tooltips for Link/Image Buttons on Markdown Toolbar (#17763) 
* Add title for tooltips

* Tweak tooltips
 2021-11-30 12:40:06 -08:00
Chris LaFreniere d32f25425b Use updated markdown renderer from vscode (#16988) 2021-09-03 10:43:25 -07:00
Chris LaFreniere b27bdb0027 Add tooltip for WYSIWYG callout link (#16967) 2021-09-01 17:24:06 -07:00
Chris LaFreniere 502feba76d Hide suggest widget on cell execution (#16895) 
* Hide suggest widget on cell execution

* Also hide for query editor

* Fix compile issue with tests
 2021-09-01 16:27:08 -07:00
Chris LaFreniere dd4e87ed41 Mark unstable book test as unstable (#16388) 2021-07-21 15:18:36 -07:00
Chris LaFreniere f7a723d98d Notebooks A11Y: Add button role for Placeholder Links (#15851) 
* Add button role

* Add aria-label

* localize aria label
 2021-06-23 16:48:01 -07:00
Chris LaFreniere 06e7d4d489 Let parent control width for text cell preview (#15800) 2021-06-18 12:51:58 -07:00
Chris LaFreniere af96cb92db Handle key_up in callout dialog (#15472) 2021-05-14 11:40:21 -07:00
Chris LaFreniere 624c07947c Notebooks: Fix Table Generation into Pure Markdown When No thead Exists (#15423) 
* works without alignment

* Alignment working

* Add comment

* Remove outdated comment
 2021-05-12 16:28:23 -07:00
Chris LaFreniere 027e8a6f33 Enable run unit tests current file and cleanup launch.json (#15307) 2021-05-03 11:38:43 -07:00
Chris LaFreniere e5a500d1a5 Change to fspath from resource tostring (#15069) 2021-04-09 12:00:55 -07:00
Chris LaFreniere 0d3112ef35 Adding Rendered Notebook Diff Option (#14860) 
* First attempt nb diff preview

* First attempt nb diff preview

* Simplify everything

* Interim scroll one way

* Double scroll

* Add setting

* Add tests

* Add comment

* Fix tests

* first round PR comments

* Ensure scrollable portion has scrollbar in diff

* Fix sqllint errors, register events

* Fix scrolling, readonly
 2021-04-02 14:49:52 -07:00
Chris LaFreniere 69a35b38b2 Callout Dialog Fixes + WYSIWYG Improvements for Insert Link (#14494) 
* wip

* Works in all edit modes

* Default value set

* wip

* preventdefault

* cleanup, add tests

* markup -> markdown

* Ensure selection is persisted for WYSIWYG

* Add simple dialog tests and some PR feedback

* floating promise

* PR comments, formatted markdown refactor

* Change escaping logic + PR comments

* PR feedback
 2021-03-04 12:51:13 -08:00
Chris LaFreniere 8c04266ff4 Notebooks: Persist Chart Data when Re-Executing Cell (#14512) 
* empty chart

* Update chart data appropriately

* Adding tests

* wip, cleanup

* PR feedback
 2021-03-03 22:40:11 -08:00
Chris LaFreniere 6ecacd6faa wip (#14530) 2021-03-03 11:50:44 -08:00
Chris LaFreniere 56dcd4ba50 Only serialize attachments in JSON if exists (#14516) 2021-03-03 09:06:16 -08:00
Chris LaFreniere 9273572d5a Fix cell attachment types (#14485) 2021-03-01 15:06:12 -08:00
Chris LaFreniere 48a63e1f50 Notebooks: Add Support for Cell Attachment Images (#14449) 
* Add to interfaces

* Works E2E

* Consolidate interface

* Add comments, cleanup

* Add some tests

* Cleanup

* interface cleanup

* Add more tests

* Add comments

* Add type for cell attachment

* wip
 2021-02-28 16:40:41 -08:00
Chris LaFreniere dbc655a8f5 Notebooks: Ensure WYSIWYG Mode for Keyboard Shortcuts (#14416) 
* Ensure WYSIWYG Mode for kb shortcuts

* Move logic down to cell model
 2021-02-25 16:57:06 -08:00
Chris LaFreniere 94f7b329d6 Remove CSS Class that doesn't exist (#14401) 2021-02-23 18:28:25 -08:00
Chris LaFreniere f528ffea9b Hide Open in Editor for notebook search (#14356) 
* Hide Open in Editor for notebook search

* Add type to new parameter
 2021-02-19 11:05:02 -08:00
Chris LaFreniere e4c5af2663 Fix notebook views (#14249) 2021-02-10 16:24:12 -08:00
Chris LaFreniere b29c07adb3 Always use \n when passing to Jupyter (#14185) 2021-02-08 09:38:06 -08:00
Chris LaFreniere 0e84dd240b Notebook Cell Conversion Language Fixes (#14120) 
* Cell language override fixes

* PR feedback
 2021-02-01 14:21:24 -08:00
Chris LaFreniere 26bb3ca033 WYSIWYG Improvements to Nested Lists (#14052) 
* indent/outdent working properly

* Add tests

* Latest fixes and tests

* PR comments + comments
 2021-01-27 12:57:23 -08:00
Chris LaFreniere 2d6074706a Have same connection logic for all nb int tests (#13844) 2020-12-17 15:38:41 -08:00
Chris LaFreniere 9aaa78e020 Stop forcing left text align on tables (#13840) 2020-12-17 13:15:40 -08:00
Chris LaFreniere e9964a4dfd Fix duplicate SVG rendering (#13828) 2020-12-16 18:25:05 -08:00
Chris LaFreniere 7b06194199 Remove hardcoded search box height (#13823) 2020-12-16 15:08:06 -08:00
Chris LaFreniere 1f630b9767 Notebook Deep Link to Section (#13795) 
* Notebook deep link to section

* fragment wip
 2020-12-14 17:20:29 -08:00
Chris LaFreniere a5231ec0e5 Notebook Extension: First logging improvements (#13729) 
* First logging improvements

* PR feedback for err output
 2020-12-11 11:21:06 -08:00
Chris LaFreniere 6349f1bd49 Prevent Table from Disappearing due to exception when looking for tHead (#13680) 
* Prevent exception when tHead doesn't exist at node

* Add test for no thead
 2020-12-04 14:42:24 -08:00
Chris LaFreniere d86e1eec10 WYSIWYG Improvements to highlight (#13032) 
* Improvements to highlight

* wip

* Tests pass

* Leverage escaping mechanism

* Tweak highlight logic

* PR comments
 2020-12-02 15:51:40 -08:00
Chris LaFreniere 8d42182db8 Attempt to Colorize Code Cells from Notebook Contents (#13473) 
* Attempt to colorize from saved language info

* Simplify colorization change

* Fixup
 2020-11-19 19:54:09 -08:00
Chris LaFreniere 6b657259a5 Ensure that we close editors before utils tests (#13391) 2020-11-13 11:16:14 -08:00
Chris LaFreniere 8c6a966bb9 Re-enable notebook editor unit tests (#13328) 
* wip

* Re-enable notebook editor tests

* PR Feedback
 2020-11-10 17:04:30 -08:00
Chris LaFreniere e4390db779 WYSIWYG fix list nesting (#13251) 
* Improvements to nested lists

* OL tests and PR feedback
 2020-11-05 18:21:33 -08:00
Chris LaFreniere 8877d74034 Check for clientSession before property (#13198) 2020-11-04 16:28:59 -08:00
Chris LaFreniere 04117b2333 Remove prose from notebooks default package list (#13173) 2020-11-02 10:54:32 -08:00
Chris LaFreniere 7559d8463f Ensure trusted action is enabled (#13174) 2020-11-02 10:48:13 -08:00
Chris LaFreniereandJustin Hutchings dfb40e0159 Notebooks: Ensure Python Environment Variables are Removed Before First Python Command (#13097) 
* Add CodeQL Analysis workflow (#10195)

* Add CodeQL Analysis workflow

* Fix path

* Ensure we delete python env vars correctly

* Move delete to top of method

Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
 2020-10-30 11:06:46 -07:00
Chris LaFreniere 31817c5494 Fix plotly responsiveness (#13119) 2020-10-28 15:40:46 -07:00
Chris LaFreniere ff8e451af9 Further enhancements to spans (#13035) 2020-10-22 13:21:05 -07:00
Chris LaFreniere a427606050 WYSIWYG Span Style Fixes, Refactor, and Tests (#13011) 
* Refactor into own class, add tests

* Add more tests

* Test fixes

* Test fix hopefully

* Tests D vs C drive
 2020-10-21 16:55:41 -07:00
Chris LaFreniere 81122538d2 skip notebook smoke tests for now (#12996) 2020-10-19 18:43:49 -07:00
Chris LaFreniere e61cc474a3 default to relative links in images and links (#12802) 2020-10-08 10:50:34 -07:00
Chris LaFreniere 18f87ab03c Prune notebooks package.json, upgrade node-fetch (#12785) 
* Prune notebooks package.json, upgrade node-fetch

* wip
 2020-10-08 09:48:56 -07:00
Chris LaFreniere 23e2a5dd12 Notebooks: WYSIWYG Add Redo, Fix Shortcuts (#12752) 
* Add redo and out/indent

* Check for active cell before doing shortcut

* PR feedback

* Remove unnecessary parameter
 2020-10-06 21:47:07 -07:00
Chris LaFreniereandchgagnon fe3d1ff48e Change azdata output channel to Azure Data CLI (#12545) 
(cherry picked from commit cdd80c66764bddb2f5ed79045fbd8a0606d1d084)

Co-authored-by: chgagnon <chgagnon@microsoft.com>
 2020-09-21 18:10:47 -07:00
Chris LaFreniere 384f593c80 Fix core and memory request MIAA deploy (#12505) 
* Fix core and memory request MIAA deploy

* Memory request/limit as 2Gi for MIAA
 2020-09-19 13:21:47 -07:00
Chris LaFreniere 82749989e6 Arc good ARC bad (#12499) 2020-09-19 10:09:30 -07:00
Chris LaFreniere 117ecfebd1 Notebooks: Fix Grids Not Rendering when Unsaved Notebook Reloaded (#12483) 
* Clear Output and fix output change

* Fix tests after forced clear + append output
 2020-09-18 18:40:21 -07:00
Chris LaFreniere da8963d1e5 Notebooks: Fast update WYSIWYG support for source update (#12289) 
* Fast update WYSIWYG support for source update

* Do bracket matching over hardcoding line offsets
 2020-09-17 11:52:30 -07:00
Chris LaFreniere be1e0b3c8d Remove MIAA Port Deploy Option (#12388) 2020-09-16 22:56:51 -07:00
Chris LaFreniere ffb81d88fd Watch for on load event (#12309) 2020-09-15 23:27:05 -07:00
Chris LaFreniere 7e76f8cb20 Add newline after caption (#12276) 2020-09-15 21:57:02 -07:00
Chris LaFreniere 233a1aefce Add new deployment options for MIAA (#12325) 2020-09-15 15:59:52 -07:00
Chris LaFreniere e75b3d69f6 Add heasdingStyle atx option (#12286) 2020-09-14 18:31:11 -07:00
Chris LaFreniere 4fee0210f6 Notebooks: Add setting for default text cell edit behavior (#12245) 
* Add setting for default text cell edit behavior

* string updates
 2020-09-11 16:29:09 -07:00
Chris LaFreniere 58d3b969a2 Set items in cell model (#12237) 2020-09-11 13:12:41 -07:00
Chris LaFreniere 0f8fa0ccef Quick tweaks to resource viewer (v1) (#12210) 2020-09-10 21:57:43 -07:00
Chris LaFreniere 02ddfc20f1 Add vcore limit support (#12212) 2020-09-10 21:45:38 -07:00
Chris LaFreniere 1f0cdf82e4 Notebook Text Cell Highlight Improvements (#12197) 
* 1st iteration

* works but multiple highlights

* remove comment

* Works but multiple selects

* wip

* cleanup

* cleanup

* Update TPN

* Add mark.js to remote + web

* PR feedback

* Tweak workbench html files
 2020-09-10 21:40:29 -07:00
Chris LaFreniere 869d071f73 storage class data controller (#12209) 2020-09-10 10:41:12 -07:00
Chris LaFreniere adefa213e2 String update (#12202) 2020-09-09 19:07:40 -07:00
Chris LaFreniere 82132583af Re-enable previously commented out configure python wizard tests (#11945) 
* Re-enable configure python wizard tests

* Remove extra comment
 2020-08-25 11:26:37 -07:00
Chris LaFreniere e90578694b Call onDidInsert Before Layout (#11819) 2020-08-14 19:52:27 -07:00
Chris LaFreniere a34a72795b Notebook Code Cleanup + Utils Test (#11754) 
* Cleanup + Utils Test

* Removing unnecessary util method
 2020-08-14 14:08:56 -07:00
Chris LaFreniere 0c3c714be1 Stop hardcoding python3 (#11464) 2020-07-21 16:38:04 -07:00
Chris LaFreniere 3792a6328f Fix Notebooks Word Wrapping Logic (#11415) 
* make word wrap logic easier

* Stop passing in IConfigurationService
 2020-07-20 13:50:26 -07:00
Chris LaFreniere 171f091c88 Fix no books currently selected error in viewlet (#11269) 
* Fix no books currently selected error

* check sections undefined vs length
 2020-07-09 23:14:46 -07:00
Chris LaFreniere 5f8180ebbf Add Notebook Completion Item Provider Unit Tests (#11222) 
* completion item provider tests

* Add nb completionItemProvider tests
 2020-07-07 12:48:22 -07:00
Chris LaFreniere 2b5ae5e3a8 Update singular vcore string (#11157) 2020-06-30 17:10:46 -07:00
Chris LaFreniere a8a7559229 Add more notebook extension tests (#11143) 
* more tests

* More tests

* More tests

* Add prompt tests
 2020-06-30 11:01:51 -07:00
Chris LaFreniere a32f42d475 Update Arc Extension with New Strings and azdata Version (#11148) 
* Strings and azdata version changes

* change azdata description
 2020-06-30 09:08:01 -07:00
Chris LaFreniere 061d3510b9 Run ADS Commands from Notebooks (#11069) 
* Run commands

* cleanup

* Plumbed through error and message output

* undo unnecessary changes

* Remove change to fix tests

* pr feedback
 2020-06-28 21:17:50 -07:00
Chris LaFreniere 9dc7ca056f Change nb before/after strings (#11121) 2020-06-26 17:36:28 -07:00
Chris LaFreniere 7080e3ec4e Notebooks: Add Some Jupyter Controller Tests (#11053) 
* First jupyter controller tests

* PR comments

* remove unnecessary checks for throw

* fix comment typo
 2020-06-23 23:08:25 -07:00
Chris LaFreniere 98ff618efd Add deprecated tag for standardKernels property (#11038) 
* Remove unnecessary prop from NotebookProvider API

* Add deprecated tag

* make standardKernels required again

* tweak comment
 2020-06-22 21:15:39 -07:00
Chris LaFreniere eaf753f79e Remove unused prompt code (#10996) 2020-06-18 17:23:32 -07:00
Chris LaFreniere 77ba5a36aa Add Jupyter Notebook Manager Tests (#10955) 
* jupyter notebook manager tests

* cover config duplicate integrationTest
 2020-06-17 14:42:35 -07:00
Chris LaFreniere 960aa14027 stop running magics that dont exist (#10894) 2020-06-12 14:25:01 -07:00
Chris LaFreniere 168ef80d8f Fix Notebook Viewlet Highlighting (#10868) 
* Stop double tree data provider registrations

* revert book finding logic, leverage currentBook
 2020-06-10 22:27:16 -07:00
Chris LaFreniere 48ec8e6dd8 Bring back hover state setting on cell model (#10758) 2020-06-05 17:14:36 -07:00
Chris LaFreniere 258310ba81 Change markdown cell to text cell (#10715) 2020-06-04 12:38:30 -07:00
Chris LaFreniere cc3554e987 Only show edit cell action for markdown cells (#10719) 2020-06-04 10:20:47 -07:00
Chris LaFreniere 6d710c7144 Add plumbing and simple notebookService tests (#10349) 2020-05-19 21:36:59 -07:00
Chris LaFreniere 452bd6a0cb Notebook model ready sooner (#10420) 2020-05-15 11:48:11 -07:00
Chris LaFreniere 5e1978e29f Ensure ipynb is associated with editor (#10055) 2020-05-08 14:50:48 -07:00
Chris LaFreniere e4614582cd Cleanup nbformat, more common tests (#10311) 2020-05-08 14:50:24 -07:00