Commit Graph

5447 Commits

Author SHA1 Message Date
Alexander Ivanov
ccde5123fa Improve tree control sample. (#14549)
While working on the tree control for our extension, I noticed that the sample implementation was not optimal. For instance, `vscode.TreeDataProvider.onDidChangeTreeData` should only be called once for the top-most node that has changed, as all children will be refreshed as well.

This change updates the code of the sample to track state changes during propagation and only raise the event for the top-most parent node that has its state changing.

There also was an issue with root node `1` not rendering, which impacted the new algorithm, as it was not refreshing the tree, when invisible root was changing. In order to address this, I updated `getChildren` to actually return the `1` node, when root was requested. This in turn changed the presentation (`1` is now rendered in the tree) and addressed the problem with tree not refreshing when `1` is the node that raises the event.

Lastly, there is one more optimization that I didn't make due to the bug that is in the works: `getTreeItem` can actually return the `element` directly, without the copy, as it already implements `TreeComponentItem`. The problem currently is that `TreeNode` also defines an `id`, which causes an error during refresh. Once that is addressed - this part can be optimized as well.
2021-03-04 11:38:30 -08:00
Charles Gagnon
9c886dd80a Remove unneeded validation error messages (#14531) 2021-03-04 09:50:57 -08:00
Chris LaFreniere
8c04266ff4 Notebooks: Persist Chart Data when Re-Executing Cell (#14512)
* empty chart

* Update chart data appropriately

* Adding tests

* wip, cleanup

* PR feedback
2021-03-03 22:40:11 -08:00
Udeesha Gautam
8e2fd2ac84 update sqltoolsservice for dacfx (#14535)
* update sqltoolsservice for dacfx

* fixing wrong string
2021-03-03 20:10:46 -08:00
Lucy Zhang
74629c951d Notebooks: Fix pip installation not working (#14506)
* upgrade pip after python installation

* add comment

* only upgrade pip for new python installations

* reinstall pip version instead of upgrade to latest

* update comment

* get pip version through packages list
2021-03-03 17:44:45 -08:00
Charles Gagnon
2620d060dc Fix error when running Notebook integration tests (#14536) 2021-03-03 15:48:41 -08:00
Kim Santiago
42fba14d88 Fix how data workspace handles untitled workspaces (#14505)
* add more workspace apis

* update dialog and check workspace scheme

* cleanup

* add comment

* update create project from db dialog

* cleanup

* update names

* add test
2021-03-03 15:31:21 -08:00
Chris LaFreniere
6ecacd6faa wip (#14530) 2021-03-03 11:50:44 -08:00
Maddy
ae55da3c35 fix the check (#14529) 2021-03-03 11:28:12 -08:00
Kim Santiago
cea55560e8 fix a couple things in create project from db dialog (#14511) 2021-03-03 10:33:52 -08:00
Charles Gagnon
625c4520da Fix input box validation (#14508)
* Fix input box validation

* just use return from inputbox validate
2021-03-03 10:19:10 -08:00
Chris LaFreniere
56dcd4ba50 Only serialize attachments in JSON if exists (#14516) 2021-03-03 09:06:16 -08:00
Barbara Valdez
3f0ca8b714 Create book dialog improvements (#14429)
* add improvements TODO on creating book experience

* fix create book to support a more complex folder structure

* replace \\ to a forward slash on windows

* address pr comments

* fix tests

* use the posix version of path.sep
2021-03-02 21:23:28 -08:00
Alan Ren
36e228ebf7 fix description not provided issue (#14510) 2021-03-02 18:07:40 -08:00
Justin M
7940714d00 Updated Kusto version from 1.22 to 1.27 (#14513) 2021-03-02 17:51:14 -08:00
Aasim Khan
f2ae5419bb Adding migration status and cutover to extension (#14482) 2021-03-02 17:11:17 -08:00
nasc17
1e67388653 Reset scheduling parameters CPU/mem request/limit to defaults (#14492)
* reset scheduling parameters

* Added right quotation marks

* Fixed comment

* Worker text box needs to have value, can't pass in emptry string

* Fixed ConfigurationSpecModel and added doc comment to handleOnTextChanged

* Add to information bubbles that user can reset scheduling parameters by passing in empty value

* Changed name of handleOnTextChanged
2021-03-02 16:15:40 -08:00
Alan Ren
18bdb0f37d pass in notification service (#14499)
* pass in notification service

* make the parameter required
2021-03-02 13:39:31 -08:00
Hale Rankin
3c38e0cc8b Notebook cell and modal fix - follow up after Lucy's 14433. (#14457)
* Modal - added code to stop the keyboard event after it is handled. textCell and codeCell - onKey now fired on keydown.

* Moved stop method into the conditional with Escape key.
2021-03-02 12:11:57 -08:00
Charles Gagnon
8b34e034fc Bump azdata tool version (#14498) 2021-03-02 11:05:36 -08:00
nasc17
9e02123330 Add loading component to Postgres Connection String Page (#14468)
* Add loading component

* Removed setting loading to true in update command
2021-03-01 16:45:33 -08:00
nasc17
cf08963fc1 Node configuration needs to show different size for data and logs volume for postgresql. (#14466)
* Included storage size of log and data

* Added backups and removed putting 0

* Added localized constants
2021-03-01 16:45:05 -08:00
Eric Humphrey
7d53e1c185 Fix spelling of retrieval (#14490)
Changed retrival to retrieval.
2021-03-01 15:52:11 -08:00
Chris LaFreniere
9273572d5a Fix cell attachment types (#14485) 2021-03-01 15:06:12 -08:00
Charles Gagnon
ff508b1bf4 Lint typings (#14488) 2021-03-01 14:42:26 -08:00
Maddy
af3373bc4b check for isDirty false explicitly (#14427)
* check for isDirty false explicitly

* revert back test to not pass isDirty
2021-03-01 14:14:00 -08:00
Maddy
14b9628b52 fix: find highlight disappears on clicking the cell (#14342)
* update content only when changed

* maintain thr highlight on rerenders

* pr comments
2021-03-01 13:43:41 -08:00
Charles Gagnon
9432330c46 Update dependencies for url-parse (#14476)
* Update dependencies

* add vscode back in for git

* revert yarn.lock

* re-add notebook redirect

* Fix git tests

* Update other testrunner references

* Add testrunner

* Add mocha-multi-reporters
2021-03-01 09:28:03 -08:00
Chris LaFreniere
48a63e1f50 Notebooks: Add Support for Cell Attachment Images (#14449)
* Add to interfaces

* Works E2E

* Consolidate interface

* Add comments, cleanup

* Add some tests

* Cleanup

* interface cleanup

* Add more tests

* Add comments

* Add type for cell attachment

* wip
2021-02-28 16:40:41 -08:00
Charles Gagnon
8ce32215ba Add remote debugging port to launch scripts (#14472) 2021-02-26 18:00:10 -08:00
Charles Gagnon
5d07a3272e Add URI handler for resource deployment (#14470)
* Add URL handler for resource deployment

* Add tests
2021-02-26 15:50:55 -08:00
Charles Gagnon
ad045de1f0 Fix azdata tests (#14471)
* Fix azdata tests

* More fixes
2021-02-26 14:40:26 -08:00
nasc17
ac9a2dcf68 Nasc/per role parameters (#14425)
* Creating separate pages for worker and coordinator parameters

* Added new gear, hid coordinator server parameters page

* Commented out azdataApi

* Added white gear, created abstract class for server parameters page

* Chaged gear name, condensed base class more, changed file name

* Added colored gears for parameter pages

* Edited to describe configuring both coordinator and worker
2021-02-26 13:33:40 -08:00
nasc17
b10626d6f4 Nasc/per role compute and storage pg (#14424)
* Start adding coordinator section

* Coordinator section shown on CS page

* Updated information bubbles, edited discard button

* Cleaned up code, hid coordinator section

* Add return types to functions, fixed configuration string name

* Configuration section does not need to be edited when model is refreshed since it is not seen

* Changed back information bubble to inform that both worker and coordinator nodes will be configured
2021-02-26 13:17:53 -08:00
Justin M
c6c65000ca Added NoAuth authenticationType for Kusto (#14375)
* Added NoAuth authenticationType for Kusto

* Added SqlLogin to Kusto as an AuthType. Renamed NoAuth to None
2021-02-26 12:28:43 -08:00
Justin M
862d0d88fa Update Kusto Version and ToolService Version (#14428)
* Updated kusto toolservice version from 60 to 80

* Updated Kusto version
2021-02-26 11:10:05 -08:00
Charles Gagnon
b304fadfde Standardize SQL CARBON EDIT tag (#14465) 2021-02-26 10:34:32 -08:00
Alan Ren
a378a52b33 fix sorting issue in azure resource grid (#14459) 2021-02-26 10:30:48 -08:00
Charles Gagnon
013ecc4ddc Add support for initial values of Azure fields in resource deployment (#14458) 2021-02-26 09:33:34 -08:00
Lucy Zhang
ab114376aa fix python wizard behavior and enable smoke test (#14433) 2021-02-26 05:04:27 -08:00
Chris LaFreniere
dbc655a8f5 Notebooks: Ensure WYSIWYG Mode for Keyboard Shortcuts (#14416)
* Ensure WYSIWYG Mode for kb shortcuts

* Move logic down to cell model
2021-02-25 16:57:06 -08:00
Karl Burtram
e761eb12ef Revert "Update dependencies for url-parse (#14423)" (#14456)
* Revert "Update dependencies for url-parse (#14423)"

This reverts commit 71cbe3fbf0.

* Fix merge break
2021-02-25 16:00:47 -08:00
Karl Burtram
8db8027b5a Update readme for 1.26.1 release (#14451) 2021-02-25 14:50:15 -08:00
Hale Rankin
9e02cf86a4 calloutDialog refactor - new superclasses for insert image and insert link (#14385)
* calloutDialog refactor - split code specific to image and link into their own super classes. Moved callout styles into a new stylesheet.

* Image and Link inserts working.

* Stylesheets cleanup. Refactor cleanup.

* Removed CSS comment. Added missing image callout style. Revised generic open and cancel classes. Moved all remaining localized strings into shared constants file.
2021-02-25 14:44:25 -08:00
Kim Santiago
4053666bef bump sql database projects version and dependency (#14442) 2021-02-25 13:33:26 -08:00
Aditya Bist
2a125ee43b normalize sql carbon tag (#14445) 2021-02-25 13:32:12 -08:00
Alan Ren
b28e845506 fix multiple button issue (#14443) 2021-02-25 13:23:56 -08:00
Christopher Suh
dbb6b71908 Assessment page changes (#14415)
* assessment page changes

* code cleanup

* remove dead code

* fixed hardcoded value

* fix instance table bug

* Revert "fix instance table bug"

This reverts commit a924f44e64062a427c9fe4b12c0f368e78e6c04f.

* Revert "fixed hardcoded value"

This reverts commit 75661c457b6161b03c823d783fa9db97431c563f.
2021-02-25 16:05:09 -05:00
Charles Gagnon
afa2256467 Update remote yarn.lock (#14438) 2021-02-25 12:14:40 -08:00
Christopher Suh
f461d2aa14 Target Page Changes (#14421)
* target page changes

* remove SourceConfigurationPage

* fix build errors

* fixed build errors

* passing selected Dbs on to migration state model

* code cleanup

* fix build errors
2021-02-24 20:02:36 -05:00