Commit Graph
76 Commits
Author SHA1 Message Date
Barbara Valdez ce13d01efb Book Editing: Support adding new sections to a book (#17074)
* add a new section command
2021-09-14 11:31:43 -07:00
Barbara Valdez 08eee69bbc only modify toc and move files if the target is a section or book (#17054) 2021-09-13 10:15:30 -07:00
Barbara Valdez 8161061d07 mark test as stable again (#16949) 2021-09-02 11:36:25 -07:00
Barbara Valdez bb3ccb92a4 Edit book using drag and drop (#16906)
- Use the onDrop method for moving notebooks/sections in the Notebooks Tree View.
- Allow multi selection in tree view
- Modify notebook commands to only show when a single tree item is selected.
2021-09-02 11:07:03 -07:00
Barbara Valdez 3dd212c90d Modify treeDataChange event (#125214) (#16907)
Modify treeDataChange event to support firing arrays.
2021-08-26 15:11:13 -07:00
Barbara Valdez 8aa0dffccf Remove circular reference from book tree item (#16579)
* Enable drag and drop and multiple selection in Book Tree View

* replace children for hasChildren to remove circular reference
2021-08-18 10:37:54 -07:00
Barbara Valdez 95a08d2ce7 Mark test as unstable (#16785)
* mark test as unstable

* fix close book test
2021-08-16 21:02:26 -07:00
Barbara Valdez b99be156ad set book as untrusted before running test (#16677) 2021-08-10 15:16:02 -07:00
Barbara ValdezandAlex Ross 30393a1f1b Integrate drag and drop api (#16500)
* Initial implementation of drag and drop api (#122239)

* Add drag and drop controller (#123542)

* Tree data transfer dnd (#128666)

* add drop method to sql files

Co-authored-by: Alex Ross <alros@microsoft.com>
2021-08-02 10:43:52 -07:00
Barbara Valdez f17689319c Revert to previous markdown renderer (#16246)
* Add marked files under sql/base/common
2021-07-16 17:51:53 -07:00
Barbara Valdez 6df69f525c Add conditional operator before checking length (#16180)
* add optional op to sections

* remove check for undefined
2021-07-16 11:38:18 -07:00
Barbara Valdez f7fc145b0c Set notebook path before moving. (#16055)
* set the original path when moving a single notebook

* save original file path before attempting to move in case of error_
)
2021-07-12 10:32:15 -07:00
Barbara Valdez 74cfac39d2 Fix book toc manager tests (#16034)
* fix book toc manager tests

* add js-yaml to notebooks package.json
2021-07-08 11:51:08 -07:00
Barbara Valdez 9a8c9041df add create book entry point to the bookTreeView (#15902) 2021-07-07 14:17:30 -07:00
Barbara Valdez a6644333c0 Pin and unpin notebook smoke test (#15936)
* add pin/unpin smoketest

* fix simple search query assert
2021-06-30 22:14:18 -07:00
Barbara Valdez 0e10e3e3ca fix WYSIWYG toolbar (#15901)
* fix WYSIWYG toolbar

* add height

* remove new rule and specify css selectors
2021-06-30 17:28:11 -07:00
Barbara Valdez ae7e69381a Resize open book icon (#15828)
* resize icon

* rename icon and remove icon from commands
2021-06-24 09:50:50 -07:00
Barbara Valdez aef6511ba6 Show book's notebook TOC title in pinned notebooks view (#15583)
* Show notebook title in pinned notebooks view

* fix test

* change interface name
2021-05-27 14:09:51 -07:00
Barbara Valdez 555e6a10e9 change book icon (#15539) 2021-05-20 16:05:24 -07:00
Barbara Valdez 4c66b04572 Init assets in dialog model (#15533)
* check that there are assets before filtering

* init assets as empty array
2021-05-20 15:11:15 -07:00
Barbara Valdez 558dfd693c Notebooks View: Do not recenter view when selecting a notebook that is visible (#15442)
* do not focus element when tree item is visible

* reset reveal behavior

* add comment
2021-05-13 10:19:19 -07:00
Barbara Valdez fd0a0ec2b0 replace notebook tab icon (#15282) 2021-04-29 11:31:45 -07:00
Barbara Valdez f712c14b93 fix search loading animation (#15063) 2021-04-08 15:29:40 -07:00
Barbara Valdez 4f67f32262 fix anchor links in wysiwyg (#14950)
* fix anchor links in wysiwyg
2021-04-08 10:56:11 -07:00
Barbara Valdez a7a6918b1a bump sqlservernotebook version (#15025) 2021-04-07 14:39:01 -07:00
Barbara Valdez fde5caa9a4 Add documentation and fix paths (#14948)
* use posix relative path

* add doc link in dialog

* rename book to Jupyter book
2021-04-02 15:44:25 -07:00
Barbara Valdez a00ffa0469 fix search action (#14937)
* fix search action

* remove book version from book tree item
2021-04-01 11:16:32 -07:00
Barbara Valdez fc13fb2200 Book Fixes (#14931)
* change folder icon and fix book path

* change folder icon in dark mode

* add folder.svg under resources
2021-03-31 14:02:08 -07:00
Barbara Valdez 8aa222d1c8 Add new file UI (#14773)
Adds a notebook or markdown file to a book's top level or a section by right click on Book Tree View
2021-03-30 18:44:52 -07:00
Barbara Valdez 15f7b12849 Search smoke tests (#13469)
* Add smoke test

* add simple tests for searching in notebooks view

* address pr comments

* address pr comments

* add search smoke tests to separate file

* remove span from selector
2021-03-25 12:43:55 -07:00
Barbara Valdez 5c67f3dbed fix tests on windows (#14827)
* fix tests on windows

* fix test
2021-03-23 10:03:48 -07:00
Barbara Valdez 5da4690be8 fix relative paths in wysiwyg (#14743)
* Convert relative paths to absolute paths based on the notebook uri before converting to markdown
2021-03-18 10:24:15 -07:00
Barbara Valdez 784d76b886 Remove book notebook from toc (#14704)
* Add remove notebook from book
2021-03-16 15:02:29 -07:00
Barbara Valdez 4b462a41ab Queue concurrent calls when initializing contents in BookModel (#14586)
* Initial work for handling concurrent operations when calling initialized books

* fixes to init contents

* create a queue of deferred promises for initializing books

* resolve active promise and set to undefined

* remove duplicated variable

* address pr comments
2021-03-09 10:19:30 -08:00
Barbara Valdez 0ef99ab42a remove Jupyter string from books and notebooks in UI (#14583) 2021-03-05 16:26:34 -08:00
Barbara Valdez a17a4a585e [Editing Books] - Refactor buildToc method (#14532)
* refactor buildToc method to only modify the section found and return a boolean

* fix tests

* Address pr comments
2021-03-05 11:41:31 -08:00
Barbara Valdez 3f0ca8b714 Create book dialog improvements (#14429)
* add improvements TODO on creating book experience

* fix create book to support a more complex folder structure

* replace \\ to a forward slash on windows

* address pr comments

* fix tests

* use the posix version of path.sep
2021-03-02 21:23:28 -08:00
Barbara Valdez 3d5ff25d13 Fix debounce issue when book toc is updated (#14392)
* pass function to debounce

* remove debounce decorator and move watch methods to bookmodel

* Move the vscode tree change data event to book model

* address pr comments

* fix book tests
2021-02-24 14:24:50 -08:00
Barbara Valdez 5ece9b968a Create book UI (#14210)
* Add dialog for creating books

* create empty book

* add localized constants

* add validation to dialog

* reset the create book command to original

* address pr comments

* change error message

* Init book toc manager in bookTreeView
2021-02-22 13:29:09 -08:00
Barbara Valdez 0f748a60b3 Fix not numbered inconsistency (#14269)
* fix not numbered field

* fix for adding extra field and removing it from sections

* use const for variable

* use spread operator to create new object

* address pr comments

* change function name and simplify

* Add comment and put the initializeContents in the finally block
2021-02-12 19:17:22 -08:00
Barbara Valdez 415689de9f Fix search results display (#14265)
* fix search results

* fix paths for windows
2021-02-12 16:51:14 -08:00
Barbara Valdez 612c385725 mark test as unstable (#14284) 2021-02-12 16:44:07 -08:00
Barbara Valdez 75cda19504 Add await to refresh book method (#14236)
* add await to refresh book method

* change name of method

* Reload tree view

* address pr comments

* adding finally on finally
2021-02-11 21:57:53 -08:00
Barbara Valdez 06bace1fcf replace backlash when moving notebooks on windows (#14186) 2021-02-07 20:17:30 -08:00
Barbara Valdez 467a34e878 Fix book editing issues (#14177)
* Fix issue moving a duplicated section to another book
2021-02-05 18:50:29 -08:00
Barbara Valdez 3c4ffd2a9c Fix book tests on Windows. (#14173)
* fix tests

* fix reveal active item test

* show error message

* revert trusted book test back to original
2021-02-05 10:45:59 -08:00
Barbara Valdez cce8a961ac Fix decorations for modified notebooks in Books View (#14152)
* Tree item resource uri should be the root when it's a book and notebook path for notebooks
2021-02-03 18:17:08 -08:00
Barbara Valdez 9ac180d772 Editing Books (#13535)
* start work on ui

* Move notebooks complete

* Simplify version handling

* fix issues with add section method

* fix issues with the edit experience and add the quick pick for editing

* add version handler for re-writing tocs

* fix book toc manager tests

* add notebook test

* fix localize constant

* normalize paths on windows

* check that a section has sections before attempting to mve files

* Implement method for renaming duplicated files

* moving last notebook from section converts the section into notebook

* Add recovery method restore original state of file system

* Add clean up, for files that are copied instead of renamed

* remove dir complexity

* divide edit book in methods for easier testing and remove promise chain

* Keep structure of toc

* normalize paths on windows

* fix external link

* Add other fields for versions

* fix paths in uri of findSection

* add section to section test

* Add error messages

* address pr comments and add tests

* check that the new path of a notebook is different from the original path before deleting
2021-02-02 20:39:11 -08:00
Barbara Valdez fa150fbe67 Initialize releases when creating remoteBookController (#14064)
* Check that releases if not undefined

* Initialize model with empty releases
2021-01-27 15:17:32 -08:00
Barbara Valdez 9df56c5c0f Normalize path to change (#13660) 2020-12-03 19:17:55 -08:00
Barbara Valdez 08735c9434 add right padding to notebook toolbar action item (#13640)
* add right padding to action item

* remove extra line and add space
2020-12-03 10:23:20 -08:00
Barbara Valdez 6f731fcd9e add await to thenable method (#13635) 2020-12-02 16:14:26 -08:00
Barbara Valdez d3bcb942f5 Add synapse repo to dropdown option (#13536)
* Add synapse repo

* fix typo
2020-11-24 15:01:34 -08:00
Barbara Valdez 3f76d343a5 Table with no headings gets corrupted when editing (#13293)
* fix data loss issue when modifying table with no headings

* fix comment

* Add tests and extra empty space to empty header format
2020-11-09 09:42:42 -08:00
Barbara Valdez e83d3ba57f Remove button property setter causing exception (#13284)
* Fix navigation buttons

* Remove icon set in welcome page
2020-11-06 14:49:14 -08:00
Barbara Valdez 036faeb06d [Backend] Editing and creating books (#13089)
* Add interface for modifying the table of contents of books

* Add logic for creating toc

* Fix issue with toc

* Add test for creating toc

* Delete bookTocManager.test.ts

* update allowed extensions

* Fix failing tests and add test

* Add tests for creating books

* Remove unused methods

* add section to section
2020-11-02 14:55:44 -08:00
Barbara Valdez 42e16b1752 Support trusted books in new version of Jupyter Books (#12874)
* Fix path gor v1 and v2 boooks

* Add tests and address PR comments

* fix failing tests

* Address pr comments

* address pr comments
2020-10-27 20:57:44 -07:00
Barbara Valdez 2801e59edc Fix links on WYSIWYG (#12952)
* fix for removed links in untrusted notebooks

* replace whitespaces on link for %20

* remove dot from hyperlinks

* Address PR comments

* Change name of variable
2020-10-16 17:51:14 -07:00
Barbara Valdez 5fb7c879ed replace pip in notebook (#12808) 2020-10-08 14:16:44 -07:00
Barbara Valdez 825663fd77 Fix search for pinned notebooks (#12719)
* fix search for pinned notebooks

* fix filtering when verifying that a search folder is not a subdirectory from the current folder queries path

* Show book node on pinned notebooks search results

* fix parent node on pinned notebooks search results

* fix search for pinned notebook and modify how pinned notebooks are stored in workspace

* update format of pinned notebooks for users that used the september release version

* removed unused functions

* Address PR comments

* fix parent node for legacy version of jupyter books

* remove cast from book path
2020-10-06 11:54:42 -07:00
b110e4dea1 In-Viewlet Notebooks Search (#12455)
* fix search

* Add sql carbon tags to vs files

Co-authored-by: chlafreniere <hichise@gmail.com>
Co-authored-by: abist <adbist@microsoft.com>
2020-09-19 14:38:27 -07:00
Barbara Valdez e8624f2de7 Add warning message for users using the new version of jupyter book (#12496)
* Add warning message for users

* Address pr comments
2020-09-18 18:49:55 -07:00
Barbara Valdez 77f28083e3 Update Windows command and minor update to installation cell (#12361)
* Fix windows command and minor update to installation cell

* Add expand_section field on the first section of the book
2020-09-17 11:56:25 -07:00
Barbara Valdez ed65a5124e Fix highlight issue (#12278)
* Fix highlight issue

* Address PR comments
2020-09-16 12:01:46 -07:00
Barbara Valdez e16d3ed827 Address comments jupyter create book notebook (#12250)
* Remove toc file link and add warning for windows users
2020-09-11 17:31:30 -07:00
Barbara Valdez 173a715a4d Fix pinned notebooks navigator (#12246) 2020-09-11 16:39:40 -07:00
Barbara Valdez 3ff9df8e0b Add support for new version of Jupyter Book (#12086)
* Add support for new jupyter book version

* Add changes to the jupyter notebook to create books

* Create config file

* Add support of new version of jupyter book on ADS

* Fix paths for opening folder with v1 and v2 books

* Add tests for jupyter book v2

* Update tests

* Fix tests

* Fix get parent issue

* Address PR comments

* Fix bookVersion condition in getSections and fix issue on create book notebook

* Fix search

* update python notebook

* Remove commented lines
2020-09-10 11:32:58 -07:00
Barbara Valdez fa5bfee0cf Add tests to GitHubRemoteBook (#11953)
* Tests for githubRemoteBook class

* Add some tests and remove unused class

* Address PR comments
2020-09-04 18:51:04 -07:00
Barbara Valdez e7ec278ef2 Replace URL and use vscode.URI on local paths (#11624)
* Use vscode.URI for local paths

* Use vscode.uri file method to set the name for remotebookfull path compressed file

* Add await on extract tar function

* Replace remote paths too

* Use vscode.uri.file instead of parse for local paths
2020-08-04 13:22:28 -07:00
Barbara Valdez c52155b621 Add setting for collapsing/expanding books at root level (#11543)
* Add setting for max number of expanded books

* Remove extra commas

* Add setting for expanding/collapsing books at root level

* Change typo in name of setting

* Change default value to false
2020-07-31 14:44:45 -07:00
Barbara Valdezandchlafreniere 6d9efbd603 Open books from Github (#10670)
* Add open book option in UI

* Add dropdowns option on dialog

* Add flow logic

* Fetch releases and validate URL

* Add class for github books and shared file books

* Change code structure

* Unblock local copy + stack overflows

* Download books from github

* Remove unused files

* Clean code and use the openNotebookFolder command to open remote book

* Checkpoint

* Refactor remote book dialog model to only hold data

* Remove ApiWrapper and refactor createlocalcopy method

* Use sinon js framework instead of typemoq for testing remotebookController

* Remove api wrapper

* Add some tests

* Add more tests and address pr comments

* Address PR comments

* Fix remotebook broken tests

* Add download location in output channel and use openBook command

* Address PR comments

* Fix typos, print error message and remove failing test

* Print error message

* Separate tests in different files

* Declare controller variable inside extension.tst

Co-authored-by: chlafreniere <hichise@gmail.com>
2020-07-24 19:39:03 -07:00
Barbara Valdez 2a6fcee913 Add more tests to local content manager (#10350)
* Add more tests

* Add descriptive messages to asserts and remove formats check

* Address comments
2020-07-06 16:58:19 -07:00
Barbara Valdez 8370a24f8c Test content manager (#9942)
* Add tests

* Address comments, will add more tests on next PR
2020-04-27 10:59:52 -07:00
Barbara Valdez 6200075624 Fix relative paths on anchor links (#9958)
* Fix relative links in notebooks
2020-04-17 16:12:07 -07:00
Barbara Valdez 00cc0074f7 Fix anchor links in notebooks (#9848)
* Fix links using anchors issue #8428

* Address PR comments
2020-04-03 16:02:55 -07:00
Barbara Valdez 548c69e074 Fix offset when scrolling to section (#9847) 2020-04-03 14:25:51 -07:00