Alan Ren
d62068025c
Merge fix the selectbox issue for chart
2019-04-16 13:40:24 -07:00
Aditya Bist
b2952d2ddf
fix job action context ( #5053 )
2019-04-16 13:36:30 -07:00
Gene Lee
a21244816d
Add support for new endpoint key string 'gateway' ( #4954 )
2019-04-16 10:45:00 -07:00
Chris LaFreniere
a9aeb57dc4
Fix to ensure that we rewrite spark ui links correctly ( #4962 )
2019-04-16 10:34:01 -07:00
Gene Lee
00537ed199
Fixed bug: CheckboxTreeNode label overflows, and node icon disappears ( #5022 )
2019-04-16 10:31:40 -07:00
Alex Ross
c2df3e0e0a
Merge 51b0b28134d51361cf996d2f0a1c698247aeabd8
2019-04-15 10:15:55 -07:00
Charles Gagnon
e3afb1cffc
Fix wrong release notes being loaded ( #5008 )
2019-04-11 20:56:19 -07:00
Kevin Cunnane
b475311f85
Fix #4500 Untitled notebook reopen doesn't show dirty ( #5005 )
...
* Fix 2 notebook issues
- Do not create notebook model twice on start
- Do not cause disposed warnings due to markdown cell deserialization
* Fix notebook dirty on open issue
Before model is resolved we weren't getting dirty events.
Solution is to use backing text model until it's ready.
Must hook to the dirty event & notify to get the dot to appear
# Conflicts:
# src/sql/workbench/parts/notebook/cellViews/code.component.ts
2019-04-11 20:56:03 -07:00
Maddy
45005d61e0
add wrap to the <pre> tag ( #5002 )
...
* add wrap to the <pre> tag
* removed styles for browser support
2019-04-11 20:46:41 -07:00
Anthony Dresser
adfddeae27
restore line height to account list renderer ( #4999 )
2019-04-11 20:46:27 -07:00
Anthony Dresser
a7429267bb
revert data explorer id to connections ( #5003 )
2019-04-11 20:46:08 -07:00
kisantia
ff415d6a03
bump SQL Tools to 1.5.0-alpha.85 to get invalid dacpac version fix ( #5001 )
2019-04-11 15:25:55 -07:00
udeeshagautam
b4dc35a4de
Fix for 4104 : Multiple consecutive spaces in query results cells are condensed into one ( #4983 )
...
* preserving spaces in query results - all beginning, trailing and middle spaces will be shown as is
* removing the change through formatting and replacing with css change formatting was leaving special char while removing nbsp
2019-04-11 15:25:41 -07:00
Aditya Bist
29c7ccad39
Added some usage details ( #4711 )
...
* added some details
* remove unused import
* added new metrics, removed churn
* merged master and code review comments
* code review comments
* normalized days to calendar days/weeks/months
* cleaned up code
* changed comment to start required check for PR
* fix failing test
* fix test
* removed null assignment
* fix null test script
2019-04-11 15:25:24 -07:00
Yurong He
1da3635d03
Fix ##3479 ctrl+a select active cell output or preview markdown ( #4981 )
...
* Enable ctrl+a to select the output or markdown content when the cell is active
* Moved toggleUserSelect into ngOnChanges
* Resolve PR comments
2019-04-11 15:25:02 -07:00
Chris LaFreniere
1f50015ed2
Add New Notebook from Server Dashboard ( #4971 )
2019-04-11 15:24:47 -07:00
Aditya Bist
01892422cb
Azure extension changes ( #4987 )
...
* removed search box
* removed commented code
# Conflicts:
# src/sql/parts/objectExplorer/viewlet/serverTreeView.ts
2019-04-11 15:24:31 -07:00
Cory Rivera
afce60b06f
Add additional error handling to Python installation for Notebooks ( #4891 )
...
* Also enabled integration tests for python installation.
2019-04-11 15:01:02 -07:00
Chris LaFreniere
a2b87f6158
Fix for relative markdown image paths ( #4889 )
...
* Fix for relative markdown image paths
* PR comments
2019-04-11 15:00:45 -07:00
Chris LaFreniere
76a2f92daf
Notebooks: Potential Fix for "Notebook Provider does not Exist" Error ( #4848 )
...
* Fallback to SQL
* Fix providers not found issue
* await whenInstalledExtensionsRegistered
* PR comments
2019-04-11 15:00:21 -07:00
Gene Lee
5b09d57196
Fixed Broken Notebook Preview ( #4895 )
2019-04-11 14:59:09 -07:00
Karl Burtram
95bf18f859
Fix merge build break
2019-04-10 16:16:43 -07:00
Kevin Cunnane
1fc648ff37
Mitigate (but not fully fix) Run Cell from disconnected notebook ( #4960 )
...
This is a partial fix that lays groundwork for full "Prompt to connect" if a kernel needs a connection.
I am waiting on Yurong's refactoring of connection handling before doing any of the prompt work.
- Adds kernel metadata about whether a connection is required.
- For Jupyter, only Spark kernels are listed as requiring a connection
- If this is true and there's no active connection, will show notification and not call execute
In the future, this path will still be used if user is prompted to connect and cancels out.
The future change will be to inject a "connect" handler from notebook.component to the cell callback and use to set connection context
2019-04-10 13:50:23 -07:00
Kevin Cunnane
37ba956bad
Fix #4893 New Notebook Can Open Existing Noteboon ( #4959 )
...
Add back check for textDocuments with same name, should've been there anyhow
On rehydration files show as text docs before clicking as only get
changed by customInputConverter code path.
We should look at this long term - ideally we'd update notebookDocuments
with correct values on initial start. #4958 opened to track this.
2019-04-10 13:47:49 -07:00
Kevin Cunnane
697f887539
Fix #4930 Text cells are referred to as text and markdown in commands ( #4956 )
2019-04-10 13:44:20 -07:00
Anthony Dresser
7b42141958
Merge 2de47c2a50
2019-04-10 13:44:11 -07:00
Chris LaFreniere
158b00f9b4
always serialize execution count ( #4864 )
2019-04-10 13:39:54 -07:00
Matt Bierner
43ac8dfd20
Adopt TS 3.4.3
...
Fixes #72005
2019-04-10 13:30:11 -07:00
Sandeep Somavarapu
34d8d52e7a
Fix #71947
2019-04-09 13:09:10 -07:00
Sandeep Somavarapu
c738b26c04
Fix #71585
2019-04-09 13:09:03 -07:00
Johannes Rieken
6090e7173f
properly check picked formatter, #71988
2019-04-09 13:06:45 -07:00
Johannes Rieken
7ebf746584
use editor for format on save and honor silent mode
2019-04-09 13:06:36 -07:00
Matt Bierner
e9d04d75ac
Fixes #71688
2019-04-09 13:06:20 -07:00
Joao Moreno
605160a1ba
Cherry pick 3773487012c98ef7974a0182771ea19178f2a525
2019-04-09 13:04:37 -07:00
Johannes Rieken
82b8750b63
show notification when formatter is disabled/uninstalled, message otherwise
2019-04-09 12:59:00 -07:00
Rob Lourens
61f7f19d12
Fix #71465 - "find in files shortcut broken"
2019-04-09 12:58:48 -07:00
Anthony Dresser
9bd7e30d18
revert vscode cahnges ( #4879 )
2019-04-05 09:15:38 -07:00
Aditya Bist
572010ded1
fixed azure extension issues ( #4859 )
2019-04-04 15:32:04 -07:00
David Shiflet
1f22326e78
Reuse existing saved connection that matches args ( #4839 )
...
* Reuse existing saved connection that matches args
* search subgroups for matches
2019-04-04 11:11:18 -07:00
Yurong He
504d5c91bc
Fixed #4800 need to use ConnectionProfile in order to get the correct… ( #4812 )
...
* Fixed #4800 need to use ConnectionProfile in order to get the correct connection
* Go back to create connect in run cell to avoid to fail to run cell or close the connection used by other.
2019-04-03 19:00:56 -07:00
Chris LaFreniere
a34692b6f2
Fix for dispose method of undefined ( #4843 )
2019-04-03 18:08:42 -07:00
Karl Burtram
73b5d23210
Update bug template labels ( #4840 )
2019-04-03 16:47:55 -07:00
Anthony Dresser
e31de8b137
fixed more null references ( #4841 )
2019-04-03 16:30:58 -07:00
Anthony Dresser
cef5bbb2be
Strict null pass on some base ui files ( #4832 )
...
* more strict null checks in base browser code
* revert changes to radiobutton
* fix some more minor things, enable strict null check in pipelines
* formatting
* fix compile errors
* make null undefined
* more null to undefined
2019-04-03 16:18:33 -07:00
Anthony Dresser
80a8e1a4da
More builder removal ( #4810 )
...
* remove more builder references
* formatting
2019-04-03 16:18:03 -07:00
Anthony Dresser
fcb8fe50fe
Advanced Description On Bottom ( #4836 )
...
* move description to the bottom
* formatting
2019-04-03 15:49:53 -07:00
Karl Burtram
5235c8aad6
Turn-off classifier bot while doing label refactoring ( #4834 )
2019-04-03 13:59:48 -07:00
Karl Burtram
5b67525211
Bump SQL Tools to 1.5.0-alpha.84 ( #4830 )
2019-04-03 11:43:43 -07:00
Anthony Dresser
fb697729c0
Data Explorer Icons ( #4806 )
...
* inital icon support
* add necessary classes for icons
* initialize icon to blank string
2019-04-03 11:10:48 -07:00
Chris LaFreniere
76fe0fef49
Fix broken test merge conflicts ( #4823 )
2019-04-03 10:44:01 -07:00