Yurong He
5f198dba08
Added hard coded pySpark3 kernel for analyze notebook. Good to know and fix it in time. ( #4009 )
2019-02-11 17:21:08 -08:00
Yurong He
62404721ed
Fixed #3954 pass connection info to new notebook flow ( #4000 )
...
* Fixed #3954
The problem is: connectionProfileId is not passed into New Notebook flow.
The fix is: plumbing connectionProfileId via NotebookInput.
* Resolved PR comments
2019-02-11 15:28:05 -08:00
Yurong He
294aa81298
Added serverVersion to contextProvider key, so Sql server preview das… ( #3981 )
...
* Added serverVersion to contextProvider key, so Sql server preview dashboard tab could be filter by it.
* User major version instead of serverVersion
2019-02-08 11:17:46 -08:00
Yurong He
d9079fe18e
Fixed #3888 . Don't know why it works in previous extension not in mssql after ported. But look like needs utils.getErrorMessage to get msg. ( #3969 )
2019-02-07 11:47:53 -08:00
Yurong He
3cde070d3b
Added submit spark job to data service context menu ( #3968 )
2019-02-07 11:46:59 -08:00
Yurong He
8fa247145e
As PM suggested, moved it to Data Services node. ( #3930 )
2019-02-06 14:22:37 -08:00
Yurong He
04bb65dcf7
Fixe Linux EMFILE: too many open file problem. ( #3912 )
...
* Fixe Linux EMFILE: too many open file problem.
Separated mssql from packageTask like azurecore.
* Make mssql depends on azurecore
* Minor fixes
2019-02-06 14:09:19 -08:00
Yurong He
8cf8cefc92
Removed dup OE contribution. The conflict wasn't detected during checkin. ( #3906 )
2019-02-05 11:36:33 -08:00
Yurong He
80c1c4c6c8
Mssql extension exposes OE getNode API for Sql-2019vNext extension ( #3901 )
...
* Mssql extension exposes OE getNode API for Sql-2019Vnext extension
* Resolved PR comments
2019-02-04 19:55:32 -08:00
Yurong He
ef8afab7e8
Added error node to OE tree ( #3889 )
...
* Add error node to OE tree
* Add globalerror_red.svg for error node.
* Fixed wrong import resolved automatically
* Resolve PR comments
2019-02-04 19:18:58 -08:00
Yurong He
84e0e08aec
Ported Analyze notebook code from SqlOpsStudio and make it work. ( #3899 )
...
* Ported Analyze notebook code from SqlOpsStudio and make it work.
if config.notebook.sqlKernelEnabled is true, use SQL provider;
Use Jupyter provider if Python is install, otherwise use buildIn Kernel.
* Analyze in Notebook Kernel can only be Python or "No Kernel". So remove Sql Kernel.
2019-02-04 15:41:01 -08:00
Yurong He
15929e8cf2
Add new notebook to OE server context menu ( #3892 )
2019-02-04 11:25:33 -08:00
Yurong He
a6defd9b62
Fixed build issue: ERROR: D:/a/1/s/src/sql/workbench/services/notebook/common/sqlSessionManager.ts[21, 1]: Duplicate imports for 'sqlops'. ( #3894 )
2019-02-01 14:39:09 -08:00
Yurong He
60b2b92803
Fixed #3873 with update the version of vscode-nls ( #3879 )
...
Fixed #3873 with update the version of vscode-nls (#3879 )
Added dependencies needed for prompts.
2019-01-31 17:57:04 -08:00
Yurong He
ecac6201d0
Rename nodeType name in order to have file context menu in both mssql and SqlOpsStudio ( #3862 )
...
* Added data service context menu: file related operations. All new files are ported from SqlOpsStudio. Will remove these functionality from SqlOpsStudio.
* Used the existing constant hadoopKnoxEndpointName
* Rename nodeType name from hdfs to bdc. So we can have file context menu in both mssql and SqlOpsStudio. Need to add "Create External Table from CSV" support for bdc nodeType
* Rename bdc to mssqlcluster
2019-01-31 13:34:59 -08:00
Yurong He
3ddc5e7846
Added Unified connection support ( #3785 )
...
* Added Unified connection support
* Use generic way to do expandNode.
Cleanup the ported code and removed unreference code. Added as needed later.
Resolved PR comments.
* Minor fixes and removed timer for all expanders for now. If any providers can't response, the tree node will spin and wait. We may improve later.
* Change handSessionClose to not thenable.
Added a node to OE to show error message instead of reject. So we could show partial expanded result if get any.
Resolve PR comments
* Minor fixes of PR comments
2019-01-29 14:37:14 -08:00
Yurong He
b439ea45ec
Bump to 69 to fix #3839 doesn't have model.sys.assemblies ( #3842 )
2019-01-29 10:09:45 -08:00
Yurong He
487fb02313
Bump sqltoolservice version to 67 for unified connection support ( #3827 )
2019-01-25 11:24:26 -08:00
Yurong He
2349aa4df8
Fixed #3596 by change URI.parse to URI.file to get the path ( #3597 )
2018-12-11 11:23:29 -08:00
Yurong He
a93a173183
The CSS class is overwritten by the previous change. Add it back ( #3583 )
2018-12-10 17:36:58 -08:00
Yurong He
ded073edd9
Added clear output to ToggleMoreAction and added it to markdown preview ( #3535 )
...
* Added toggleMoreActions to Markdown Preview only.
When it is in editor mode, only editor display ToggleMoreActions.
* Added clear output back
2018-12-10 11:17:35 -08:00
Yurong He
7a84cff5b4
Fixed #3508 by removing the fixed height of toolbar ( #3518 )
2018-12-07 15:16:53 -08:00
Yurong He
2af627b704
Fixed #3497 ( #3517 )
2018-12-07 14:16:00 -08:00
Yurong He
944a77fe42
Fixed #3287 adding loading-spinner to markdown cell ( #3505 )
2018-12-07 13:07:00 -08:00
Yurong He
3b08721835
Fixed #3415 add padding-left/right 8px ( #3462 )
...
* Fixed #3415 add padding-left/right 8px
* We will keep CSS consistent for review and editing mode. So removed codes not used.
2018-12-07 09:02:20 -08:00
Yurong He
4a7cf8d870
Disable key binding for this release. ( #3466 )
2018-12-06 10:04:02 -08:00
Yurong He
3446ff88cf
Fixed #3472 check SaveKernelInfo not null ( #3473 )
2018-12-05 14:21:14 -08:00
Yurong He
8f817ce689
Fixed Notebooks regression: invalid kernels aren't handled #3404 ( #3447 )
...
* Fixed the not supported kernel in saved notebook
* Resolve PR comment.
2018-12-05 10:54:37 -08:00
Yurong He
58bfcb4273
Fixed can't read indexof exception when no big data cluster connection and switch to PySpark3 ( #3413 )
2018-12-04 10:36:34 -08:00
Yurong He
27a978cba5
Fixed #3387 ( #3401 )
2018-12-04 09:41:31 -08:00
Yurong He
5add835750
Fixed issue: Notebook: Can't use PySpark3 even though having big data cluster connected #3363 ( #3380 )
2018-12-03 10:53:04 -08:00
Yurong He
0926057bfe
Fixed #3294 removed dead code for "attach to" and remove disable to make it respond theme change ( #3349 )
...
* Fixed #3294
* Fixed #3294
2018-11-29 19:28:08 -08:00
Yurong He
3ca72b7398
Fixed Spark UI links within Notebooks are not working notebooks sql2019Preview ( #3344 )
...
#3277
2018-11-29 12:52:18 -08:00
Yurong He
702dbddd78
Fixed some issues for Markdown and CSS ( #3336 )
...
* Fixed few markdown cell issues
* Change the boolean value from 1 to true
2018-11-29 12:50:53 -08:00
Yurong He
bc13beaa85
Revert "Hide run button in markdown editor and pull toggleMoreAction to a seperate class ( #3321 )" ( #3328 )
...
This reverts commit 9ea8baca05 .
2018-11-27 23:43:16 -08:00
Yurong He
9ea8baca05
Hide run button in markdown editor and pull toggleMoreAction to a seperate class ( #3321 )
2018-11-27 15:32:20 -08:00
Yurong He
b3eb809550
Hide ToggleMoreAction for inactive cell ( #3235 )
...
* Hide ToggleMoreAction for inactive cell
* Revert wrong merge
* Undo bad merge
* Enable markdown to hide ToggleMoreAction
* Resolve PR comments
* Fixed the name
* Change name
* Fix toggleMoreActions by passing in CellContext instead of just nb model
* Fixed the warning by removing notificationService from the caller
2018-11-27 12:54:27 -08:00
Yurong He
e607f68b3e
Add more actions to cell ( #3217 )
...
* Added toggle more actions to cell
* Resolve PR comments
-- Added INotificationService for notification msg
* Reduced ToggleMoreAction to smaller size. So the dropdown could be displayed closer to it instead of at the buttom of the cell.
2018-11-14 17:51:59 -08:00
Yurong He
db3bb82dbd
Change code and text font to 11 ( #3216 )
...
Ajust the padding top to 0
Change task bar height to 36
2018-11-14 15:36:24 -08:00
Yurong He
5889c600fa
Resend selectBox change to on against master. PR against nativeNotebook was approved already. ( #3215 )
2018-11-14 13:48:41 -08:00