Commit Graph

7353 Commits

Author SHA1 Message Date
Charles Gagnon
e9c8eb8564 Fix Mac signing (#18534) (#18539)
* Install .NET SDK for Mac signing

* Install runtime

* Specify 2.1.0

* Install SDK

(cherry picked from commit 23cbb98162)
1.35.0
2022-02-23 08:40:05 -08:00
Charles Gagnon
c2d6a2f4ff Port url-parse update (#18537) 2022-02-23 08:29:21 -08:00
Charles Gagnon
b0d3c95bec Fixing query editor smoke test (#18515) (#18530)
* Fixing query editor smoke test

* Fixing notification toast for telemetry opt out

* Adding SQL Carbon edit

(cherry picked from commit 5731366a1c)

Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
2022-02-22 16:03:48 -08:00
Alan Ren
734de6251d highlight problematic property in the designer when error is selected (#18512) (#18518)
* navigate to property when selecting error message

* use list component

* highlight problematic property

* remove unnecessary call

* comment

* comment
2022-02-22 16:03:24 -08:00
Candice Ye
8fc95f45d4 Updated package.json for arc and azcli extensions to version 1.0.0 (#18526)
* Update arc extension to 1.0.0

* Update azcli extension version to 1.0.0
2022-02-22 13:57:08 -08:00
Karl Burtram
34aa77eea3 Fix opt out prompt behavior (#18498) (#18499)
* fix header

* fix product name

Co-authored-by: Aditya Bist <adbist@microsoft.com>
2022-02-18 15:57:39 -08:00
Karl Burtram
b292e4233e Port - Restrict which sites out webview iframe can frame (#18495) (#18497)
* protocol handler - normalize paths

* use `extUri` for normalizing paths

* :lipstick;

* Add content security policy to top level webview

This change hardens our webviews by adding a fairly restrictive csp to them. This CSP should only apply to the outer webview iframe, not to the inner iframe which is controlled by extensions

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Matt Bierner <matb@microsoft.com>

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Matt Bierner <matb@microsoft.com>
2022-02-18 15:39:44 -08:00
Aasim Khan
fc1e3a24ef Removing extra toUrl call (#18492) (#18496) 2022-02-18 15:39:16 -08:00
Karl Burtram
0148071c0d Add mxgraph to thirdyparty notices (#18486) (#18488) 2022-02-18 15:38:59 -08:00
Barbara Valdez
560e8974dd Fix search experience in notebooks (#18474) (#18485)
* fix search on notebooks

* keep focus on findwidget
2022-02-18 15:38:38 -08:00
Barbara Valdez
23fbd4c1ed fix section markdown and html link (#18478) (#18482)
* fix section markdown and html link
2022-02-18 11:39:09 -08:00
Charles Gagnon
f0186bc5c0 Add timeout delay to Notebook cell connect (#18475) (#18480)
(cherry picked from commit a1a1793221)
2022-02-18 11:31:31 -08:00
Alan Ren
295009ec3d fix a typo in table designer (#18464) (#18471) 2022-02-17 19:53:06 -08:00
Christopher Suh
ee835356be Clear account tokens before refresh (#18452) (#18470)
* clear account tokens on refresh

* update refresh button after refresh
2022-02-17 19:52:40 -08:00
Lewis Sanchez
62822874ad Adds a tooltip title prop to the diagram node. (#18458) (#18463)
* Adds a tooltip title prop to the diagram node. (#18458)

* Adds a tooltip title prop to the diagram node.

* Updates azdataGraph package version to 0.0.16

* Fixes ansi_up version in remote package.json to match root package.json

* Fixes ansi_up version in remote/web package.json to match root version
2022-02-17 19:52:17 -08:00
Charles Gagnon
932865ceee Add option to disable running integration tests (#18454)
* Add option to disable running integration tests

* succeeded
2022-02-17 14:14:10 -08:00
Alan Ren
b02e97e851 table designer validation support (#18438) (#18453)
* table designer validation

* vbump sts
2022-02-17 14:13:37 -08:00
Neetu Singh
3faf51b573 [Port] [SQL Migration] Bug fixes for new feature SKU Recommendation in migration extension (#18449)
* Bump follow-redirects in /extensions/resource-deployment (#18349)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* LEGO: check in for main to temporary branch. (#18347)

Co-authored-by: Alex Ma <alma1@microsoft.com>

* [Loc] update to sql.xlf and sql-migration (#18352)

* Bump follow-redirects in /extensions/github-authentication (#18348)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump follow-redirects from 1.14.7 to 1.14.8 in /extensions/azurecore (#18350)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump ajv from 6.12.0 to 6.12.6 in /extensions/mssql (#18316)

Bumps [ajv](https://github.com/ajv-validator/ajv) from 6.12.0 to 6.12.6.
- [Release notes](https://github.com/ajv-validator/ajv/releases)
- [Commits](https://github.com/ajv-validator/ajv/compare/v6.12.0...v6.12.6)

---
updated-dependencies:
- dependency-name: ajv
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Database Projects - Add existing file (#18066)

* Add existing file to sqlproj

* Address PR comments

* Fix failing test

* Add convertSlashesForSqlProj to test failure

* Using proper zoom icon (#18338)

* Bump ansi_up (#18190)

* Fixing graph editing (#18361)

* Update to langpacks and xlfs for February Release, (#18354)

* Update to langpacks and xlfs

* fixed id for git

* Added small fix for locFunc (#18364)

* Small update to the changelog (#18369)

* [Loc] small update to sql-database-projects xlf (#18396)

* azdataGraph version bump to 0.0.15 (#18388)

* azdataGraph version bump to 0.0.15

* Updates azdataGraph version in remote package.json

* Updates azdataGraph version in remote web package.json

* Adding tooltips and fixing spacing (#18400)

* avoid auto language detection for sql editor (#18402)

* avoid auto lang detection for sql editor

* update comment

* fix SDK style projects not being able to find system dacpacs (#18218)

* fix SDK style projects not being able to find system dacpacs

* fix tests

* LEGO: check in for main to temporary branch. (#18417)

* LEGO: check in for main to temporary branch. (#18419)

* Bump url-parse (#18422)

* make sure the content is not undefined (#18406)

* [SKU Recommendation] Adding telemetry for errors happening during data collection/ get  recommendation and telemetry (#18345)

* Adding telemetry for errors happening during data collection/ telemetry for sku recommendation

* log and error happended during get sku recommendation

* Resolving comments from PR https://github.com/microsoft/azuredatastudio/pull/18252. 1) Adding click and close events to dispoable collection to avoid leaks. 2) Adding readable constant for number representing minutes.

* Changes - 1) updating migration workflow strings, 2) adding more onclick events to disposable collection.

* Remove PaaS, IaaS terms from string

* Changes -
1) Renamed 'Saved assessment result' to 'saved session'.
2) Removed Title from 'saved session' page.
3) Added stop data collection on migration start.

* Fixing context menu strings (#18404)

* Fixing context menu strings

* Fixing string

* Adding zoom button (#18407)

* Adding zoom button

* Fixing string

* Fixing the height of the query plan (#18409)

* Fixing the height of the query plan

* Fixing layout issues

* Fix on click edit mode states (#18321)

* fix click code cell

* modified editmode when updating active cell

* Updating readme with new gif that includes SKU Recommendation (#18432)

* Fix contributed icons for ModelView trees not showing (#18430)

* Fix contributed icons for ModelView trees not showing

* Use asCssUrl

* Fixed color contrast for error message in connect a dc window. (#18411)

* Fixed color contrast for error message in connect a dc window.

* Remove color check for error message

* Remove more unneeded checks

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* fix holding down key scrolling issue (#18322)

* Stop propagation + debounce scroll

Co-authored-by: chgagnon <chgagnon@microsoft.com>

* LEGO: check in for main to temporary branch. (#18443)

* Adds Operational Cost to Query Plan Vertex Labels. (#18435)

* Adds operational cost to graph node labels.

* Code clean up.

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: csigs <csigs@users.noreply.github.com>
Co-authored-by: Alex Ma <alma1@microsoft.com>
Co-authored-by: Z Chen <13544267+zijchen@users.noreply.github.com>
Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: Barbara Valdez <34872381+barbaravaldez@users.noreply.github.com>
Co-authored-by: Candice Ye <candiceye@berkeley.edu>
2022-02-17 14:12:58 -08:00
Barbara Valdez
1928d076b1 fix holding down key scrolling issue (#18322) (#18439)
* Stop propagation + debounce scroll

Co-authored-by: chgagnon <chgagnon@microsoft.com>

Co-authored-by: chgagnon <chgagnon@microsoft.com>
2022-02-17 09:23:52 -08:00
Aasim Khan
c2d294cb79 Fixing the height of the query plan (#18409) (#18433)
* Fixing the height of the query plan

* Fixing layout issues
2022-02-17 09:23:25 -08:00
Aasim Khan
5e7356d652 Adding zoom button (#18407) (#18431)
* Adding zoom button (#18407)

* Adding zoom button

* Fixing string

* Using proper zoom icon (#18338)
2022-02-17 09:22:54 -08:00
Aasim Khan
8335854015 Fixing context menu strings (#18404) (#18427)
* Fixing context menu strings

* Fixing string
2022-02-17 09:22:23 -08:00
Charles Gagnon
52d33b493a Fix contributed icons for ModelView trees not showing (#18430) (#18436)
* Fix contributed icons for ModelView trees not showing

* Use asCssUrl

(cherry picked from commit 2be1394748)
2022-02-16 19:41:45 -08:00
Barbara Valdez
2e53b4c241 Fix on click edit mode states (#18321) (#18434)
* fix click code cell

* modified editmode when updating active cell
2022-02-16 17:03:17 -08:00
Alan Ren
efade32c62 make sure the content is not undefined (#18406) (#18426) 2022-02-16 15:14:52 -08:00
Charles Gagnon
2fd6990e73 Bump url-parse (#18422) (#18424)
(cherry picked from commit 3dbd5ac2c1)
2022-02-16 14:42:34 -08:00
Aasim Khan
d204fa9940 Adding tooltips and fixing spacing (#18400) (#18403) 2022-02-16 13:30:53 -08:00
Alex Ma
1f08aded06 Port of langpacks for release/1.35 (#18365)
* Update to langpacks and xlfs

* fixed id for git

* changed release date
2022-02-16 12:34:19 -08:00
Alan Ren
fc2138228d avoid auto language detection for sql editor (#18402) (#18408)
* avoid auto lang detection for sql editor

* update comment
2022-02-16 11:02:31 -08:00
Aasim Khan
a830820915 Fixing graph editing (#18361) (#18398) 2022-02-15 13:32:32 -08:00
dependabot[bot]
3c72b76c0b Bump follow-redirects in /extensions/integration-tests (#18351)
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-14 10:15:04 -08:00
dependabot[bot]
e751b6141a Bump ajv from 6.10.0 to 6.12.6 in /extensions/machine-learning (#18319)
Bumps [ajv](https://github.com/ajv-validator/ajv) from 6.10.0 to 6.12.6.
- [Release notes](https://github.com/ajv-validator/ajv/releases)
- [Commits](https://github.com/ajv-validator/ajv/compare/v6.10.0...v6.12.6)

---
updated-dependencies:
- dependency-name: ajv
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-14 10:13:04 -08:00
dependabot[bot]
fc2e7a8bd5 Bump ajv from 6.10.0 to 6.12.6 in /extensions/integration-tests (#18317)
Bumps [ajv](https://github.com/ajv-validator/ajv) from 6.10.0 to 6.12.6.
- [Release notes](https://github.com/ajv-validator/ajv/releases)
- [Commits](https://github.com/ajv-validator/ajv/compare/v6.10.0...v6.12.6)

---
updated-dependencies:
- dependency-name: ajv
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-14 10:12:27 -08:00
dependabot[bot]
06db0d029b Bump follow-redirects from 1.14.7 to 1.14.8 in /build/actions (#18342)
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-14 10:10:57 -08:00
csigs
b522433d73 LEGO: check in for main to temporary branch. (#18344) 2022-02-14 09:37:03 -08:00
csigs
23f37d7b52 LEGO: check in for main to temporary branch. (#18341) 2022-02-14 09:36:43 -08:00
Raymond Truong
3cfd1d23da [Feature] SKU recommendations in SQL migration extension (#18252)
* Initial check in for SQL migration SKU recommendation feature (#18116)

Co-authored-by: Raymond Truong <ratruong@microsoft.com>

* add TargetSelectionPage, remove AccountSelectionPage, fix saveAndClose bugs (#18092)

* update sku interfaces (#18150)

* create the skuRecommendationResultsDialog (#18151)

* add TargetSelectionPage, remove AccountSelectionPage, fix saveAndClose bugs

* create skuRecommendationResultsDialog

* Replace placeholder SKU recommendation results with actual results (#18153)

* Replace placeholder SKU recommendation results with actual backend call results

* Remove skuRecommendationExample

* Replace number fields in interfaces with correct enums, and update UI text

* add getAzureRecommendationDialog for performance collection (#18159)

* add getAzureRecommendationDialog when there are no recommendations available

* update 'get azure rec' / 'view details' link values

* add condition to check if recommendations are available

* Implement start/stop perf data collection + import perf data into new UI (#18149)

* Implement start/stop perf data collection

* add getAzureRecommendationDialog when there are no recommendations available

* update 'get azure rec' / 'view details' link values

* add condition to check if recommendations are available

* Implement import existing data + start/stop perf collection with new UI

Co-authored-by: Rachel Kim <rackim@microsoft.com>

* Expose SqlInstanceRequirements in SKU recommendation results (#18207)

* Expose SqlInstanceRequirements

* Move string literals to constants file

* Fix formatting in mssql.d.ts

* create storage properties table (#18215)

* Edit sku recommendation parameters (#18244)

* Edit sku recommendation parameters

* make _targetPercentileDropdown not editable; styling updates

* Azure recommendation section exposes data collection status and stop option (#18246)

* Edit sku recommendation parameters

* create azure recommendation details section on sku page

* Improve error handling + add auto refresh + other small changes (#18228)

* Update source properties table

* WIP - refresh perf data collection

* Add auto refresh logic

* Address comments

Co-authored-by: Rachel Kim <rackim@microsoft.com>

* Show/hide azure recommendation components based on data collection source and status (#18254)

* add refresh recommendation button; show/hide content based on perf collection status

* show/hide azure rec content based on perf data source scenarios

* add popups for start/stop; allow user to restart data collection; add perf collection to save close; add info tooltips (#18278)

* Update SKU recommendation timer logic (#18281)

* Update timer logic

* Fix misc UI bugs

* update sql migration extension readme (#18295)

* Remove empty constant, as this may have broken the build

* Fix 'save and close' behavior for SKU recommendation (#18301)

* Update timer logic

* Fix misc UI bugs

* 'WIP'

* Add logic to restore correct SKU recommendation state when reloading

* SKU UX enhancements - status info, button validations, savedInfo logic (#18320)

* add stop/inprogress status icons to perf collection status text, update restart icon

* refactor savedInfo as an interface, edit parameter recommednations are saved, add open folder inputbox validation, handle no recommendations available scenario

* fix getazureredialog bug, cleanup cold

* nit card styling

* Update recommendations whenever user changes list of databases to assess + misc clean up (#18323)

* Consolidate constants, clean up redundant functions, misc clean up

* Remove old SKU recommendation interfaces

* Update some more strings

* Telemetry events for SKU Recommendation (#18282)

* Telemetry events for SKU Recommendation

* Addressing comments -
1) fixed camel casing
2) removed extra logging to console
3) added telemetry for subid, rg, tenantid on targetselectionpage

* Resolving conflicts

* Addressing comments - 1) removing filename 2) moving all numbers to measurements.

* Resolving comment - Fixing telemetry value for tenant id.

* removing warning 'logError' is declared but its value is never read (#18333)

* Stop existing data collection when leaving and starting a new migration + update timers (#18339)

* Refresh recommendations when pressing stop data collection button

* Fix orphaned data collection when save and closing and starting a new
migration

* Revert "Refresh recommendations when pressing stop data collection button"

This reverts commit e6fb2ade8f8a41952adb81cb0ee852414dfa4ef2.

* Update timers to use production values

* Remove unused import

* address bug bash issues: add learn more link, add last refreshed time, fix vm card view detail open issue, remember last selected folder, remove strings, refactor refresh logic on sku page (#18340)

* Address comments

* Update to sqltoolsservice 3.0.0-release.204

Co-authored-by: Rachel Kim <rackim@microsoft.com>
Co-authored-by: Neetu Singh <23.neetu@gmail.com>
2022-02-11 21:23:49 -08:00
Aasim Khan
08815a3c0f Adding save file functionality to query plan (#18337) 2022-02-11 19:53:11 -08:00
Alan Ren
57d5d94c46 fix connection error scenario (#18335)
* fix connection error scenario

* pr comments
2022-02-11 18:49:29 -08:00
Aasim Khan
d76f239ae2 Fixing init value of custom zoom widget (#18331) 2022-02-11 17:32:07 -08:00
Alex Ma
54eb7db261 [Loc] Update to arc and sql xlf (#18336) 2022-02-11 16:19:06 -08:00
Aasim Khan
b25935f8a5 removing feature specific query plan flag (#18330) 2022-02-11 14:17:39 -08:00
Aasim Khan
b65e6d0bab Fixed tooltip not hiding when scrolling through graph control (#18314) 2022-02-11 14:17:26 -08:00
Aasim Khan
066d7a14a3 Fixing icons and styling in Query Plan (#18328)
* Fixing icons and styling

* Fixng some hc styling
2022-02-11 13:41:43 -08:00
Charles Gagnon
e78a95e7d3 Fix Notebook navigation key events triggering incorrectly (#18329) 2022-02-11 13:40:17 -08:00
Candice Ye
85cfde7421 Enabled dynamic options to use CategoryValue type. SQL MIAA deploy now up to parity with Portal. (#18279)
* Removed extra backup policy field in MIAA deploy. Re-ordered fields in MIAA deploy for parity.

* Enabled dynamic options to work with categoryvalue type objects.

* Removed defaultValue CategoryValue typing, fixed some type checks.

* Added a clarifying comment to setModelValues and removed unnecessary type from defaultValue

* Removed CategoryValue from selection

* Undo parenthesis for single type
2022-02-11 11:19:30 -08:00
Alex Ma
56f72e33b1 [Loc] update to sql-migration and sql (#18327) 2022-02-11 11:10:02 -08:00
csigs
2924376f96 LEGO: check in for main to temporary branch. (#18326) 2022-02-11 11:03:47 -08:00
dependabot[bot]
2ca75e2437 Bump ajv from 6.10.0 to 6.12.6 in /extensions/big-data-cluster (#18318)
Bumps [ajv](https://github.com/ajv-validator/ajv) from 6.10.0 to 6.12.6.
- [Release notes](https://github.com/ajv-validator/ajv/releases)
- [Commits](https://github.com/ajv-validator/ajv/compare/v6.10.0...v6.12.6)

---
updated-dependencies:
- dependency-name: ajv
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-11 10:11:49 -08:00
Charles Gagnon
91b8fcd5f7 Fix Notebook registered file type (#18312) 2022-02-10 22:19:04 -08:00