Commit Graph

527 Commits

Author SHA1 Message Date
Alan Ren
295009ec3d fix a typo in table designer (#18464) (#18471) 2022-02-17 19:53:06 -08:00
Alan Ren
b02e97e851 table designer validation support (#18438) (#18453)
* table designer validation

* vbump sts
2022-02-17 14:13:37 -08:00
Raymond Truong
3cfd1d23da [Feature] SKU recommendations in SQL migration extension (#18252)
* Initial check in for SQL migration SKU recommendation feature (#18116)

Co-authored-by: Raymond Truong <ratruong@microsoft.com>

* add TargetSelectionPage, remove AccountSelectionPage, fix saveAndClose bugs (#18092)

* update sku interfaces (#18150)

* create the skuRecommendationResultsDialog (#18151)

* add TargetSelectionPage, remove AccountSelectionPage, fix saveAndClose bugs

* create skuRecommendationResultsDialog

* Replace placeholder SKU recommendation results with actual results (#18153)

* Replace placeholder SKU recommendation results with actual backend call results

* Remove skuRecommendationExample

* Replace number fields in interfaces with correct enums, and update UI text

* add getAzureRecommendationDialog for performance collection (#18159)

* add getAzureRecommendationDialog when there are no recommendations available

* update 'get azure rec' / 'view details' link values

* add condition to check if recommendations are available

* Implement start/stop perf data collection + import perf data into new UI (#18149)

* Implement start/stop perf data collection

* add getAzureRecommendationDialog when there are no recommendations available

* update 'get azure rec' / 'view details' link values

* add condition to check if recommendations are available

* Implement import existing data + start/stop perf collection with new UI

Co-authored-by: Rachel Kim <rackim@microsoft.com>

* Expose SqlInstanceRequirements in SKU recommendation results (#18207)

* Expose SqlInstanceRequirements

* Move string literals to constants file

* Fix formatting in mssql.d.ts

* create storage properties table (#18215)

* Edit sku recommendation parameters (#18244)

* Edit sku recommendation parameters

* make _targetPercentileDropdown not editable; styling updates

* Azure recommendation section exposes data collection status and stop option (#18246)

* Edit sku recommendation parameters

* create azure recommendation details section on sku page

* Improve error handling + add auto refresh + other small changes (#18228)

* Update source properties table

* WIP - refresh perf data collection

* Add auto refresh logic

* Address comments

Co-authored-by: Rachel Kim <rackim@microsoft.com>

* Show/hide azure recommendation components based on data collection source and status (#18254)

* add refresh recommendation button; show/hide content based on perf collection status

* show/hide azure rec content based on perf data source scenarios

* add popups for start/stop; allow user to restart data collection; add perf collection to save close; add info tooltips (#18278)

* Update SKU recommendation timer logic (#18281)

* Update timer logic

* Fix misc UI bugs

* update sql migration extension readme (#18295)

* Remove empty constant, as this may have broken the build

* Fix 'save and close' behavior for SKU recommendation (#18301)

* Update timer logic

* Fix misc UI bugs

* 'WIP'

* Add logic to restore correct SKU recommendation state when reloading

* SKU UX enhancements - status info, button validations, savedInfo logic (#18320)

* add stop/inprogress status icons to perf collection status text, update restart icon

* refactor savedInfo as an interface, edit parameter recommednations are saved, add open folder inputbox validation, handle no recommendations available scenario

* fix getazureredialog bug, cleanup cold

* nit card styling

* Update recommendations whenever user changes list of databases to assess + misc clean up (#18323)

* Consolidate constants, clean up redundant functions, misc clean up

* Remove old SKU recommendation interfaces

* Update some more strings

* Telemetry events for SKU Recommendation (#18282)

* Telemetry events for SKU Recommendation

* Addressing comments -
1) fixed camel casing
2) removed extra logging to console
3) added telemetry for subid, rg, tenantid on targetselectionpage

* Resolving conflicts

* Addressing comments - 1) removing filename 2) moving all numbers to measurements.

* Resolving comment - Fixing telemetry value for tenant id.

* removing warning 'logError' is declared but its value is never read (#18333)

* Stop existing data collection when leaving and starting a new migration + update timers (#18339)

* Refresh recommendations when pressing stop data collection button

* Fix orphaned data collection when save and closing and starting a new
migration

* Revert "Refresh recommendations when pressing stop data collection button"

This reverts commit e6fb2ade8f8a41952adb81cb0ee852414dfa4ef2.

* Update timers to use production values

* Remove unused import

* address bug bash issues: add learn more link, add last refreshed time, fix vm card view detail open issue, remember last selected folder, remove strings, refactor refresh logic on sku page (#18340)

* Address comments

* Update to sqltoolsservice 3.0.0-release.204

Co-authored-by: Rachel Kim <rackim@microsoft.com>
Co-authored-by: Neetu Singh <23.neetu@gmail.com>
2022-02-11 21:23:49 -08:00
Raymond Truong
b7ad010e43 Update mssql/sqltoolsservice for SKU recommendation changes (#18315)
* Add new contracts

* Increment sqltoolsservice to 3.0.0-release.202
2022-02-10 20:58:13 -08:00
Alan Ren
7bc954f942 add table designer menu to Azure view (#18307) 2022-02-10 14:36:56 -08:00
Aasim Khan
1eff096220 Vbumping STS to get latest Query Plan code (#18300)
* Vbumping sts to get latest qp code

* Updating azdataGraph in remote package.json

* Revert "Updating azdataGraph in remote package.json"

This reverts commit 704aa6b653b20c6bc439ba2ac46f4dcdead0128d.
2022-02-10 13:37:49 -08:00
Alan Ren
021b7f6e71 add preview flag for table designer (#18253) 2022-02-09 09:38:14 -08:00
Alan Ren
3ddc319736 enable AAD auth for table designer (#18248) 2022-02-08 16:17:07 -08:00
Alan Ren
33d9e05e00 minor code refactoring (#18227) 2022-02-04 21:31:15 -08:00
Alan Ren
4c49e1cd41 refresh the table designer after publishing (#18220) 2022-02-04 09:32:07 -08:00
Charles Gagnon
7ee1ea7eeb Add guide for updating STS (#18212)
* Add guide for updating STS

* Add file name
2022-02-03 10:39:38 -08:00
Alan Ren
c535c2dbde table designer improvements (#18206)
* new table experience

* new table info for existing table

* allow delete confirmation

* fix editor lock isue

* vbump sts

* PR feedback
2022-02-02 18:46:09 -08:00
Aasim Khan
644d24ca13 vbumping sts to get latest execution plan changes (#18205) 2022-02-02 14:44:31 -08:00
Aditya Bist
de5090e47a Added data points for Table Designer (#18182)
* added server infor and metrics for table designer

* update generate script

* pr comments

* format more files

* pr comments

* make changes to core

* remove unused imports

* add server info

* revert enum change and add publish event

* format doc

* nitpicks

* remove os version

* remove modifier from telemetry info

* remove error message
2022-02-02 12:40:05 -08:00
Charles Gagnon
de1a0f4f0f Bump y18n (#18196) 2022-02-01 15:27:45 -08:00
Charles Gagnon
8e1e9a95c3 Move to MS vscodetestcover and update lodash (#18192) 2022-02-01 14:09:10 -08:00
Charles Gagnon
1c9ba64ee0 check-param-names (#18189) 2022-01-31 12:39:22 -08:00
Hai Cao
2f6fa1e1df add "New Table" menu to Tables node in OE (#18038) 2022-01-20 16:37:23 -08:00
Alan Ren
5847bd302d td support indexes (#18121)
* support indexes

* add pending action warning

* vbump STS
2022-01-18 22:20:45 -08:00
Charles Gagnon
567244c629 Update jsprim (#18090) 2022-01-14 11:17:23 -08:00
Alan Ren
2b2193b387 vbump sts and update td contract names (#18056) 2022-01-12 13:38:31 -08:00
Alan Ren
254d307e2f bump sts (#18008) 2022-01-06 15:08:22 -08:00
Alan Ren
ff84cc17c4 save/generate script for table designer (#17972)
* save changes

* refactoring

* update height

* Register undo redo command (#17948)

* register undo redo command

* sql-migration vbump 0.1.12 (#17955)

* fix pre/post deploy scripts getting double counted in the files for sdk style projects (#17954)

* fix pre/post deploy scripts getting double counted in the files for sdk style projects

* add test

* update comment

* vbump sql database projects to 0.15.0 (#17956)

* LEGO: check in for main to temporary branch. (#17957)

* null check before calling isDisposable (#17959)

* Updated credentials system (#17888)

* linting

* added flags

* remove testing values

* format

* format doc

* tested in linux

* remove unused interface

* comments

* review comments

* clean imports

* pr comments

* format doc

* changed promise location

* insiders december

* pr comments

* test ado change

* fix test

* comment out code for hygiene

* remove unused imports

* test creds from client only

* remove unused import

* trying enabling keytar

* trying enabling keytar

* disable in correct script

* print statements

* remove print statements

* check mock output

* add linux check

* remove print statements

* Consolidate INotebookEditOperation interfaces (#17944)

* Add redo action for split cells (#17947)

* add redo action for split cells

* Handle delete folder for SDK style sql projects (#17961)

* handle delete folder for sdk style projects

* cleanup

* compare original sqlproj contents

* remove redundant checks

* enable find in cell output when output is a data stream (#17759)

* initial changes

* add isCodeOutput and apply decorations on output

* Add extension gallery update reminder action (#17644)

* Fix extensionsGallery.json name (#17646)

* Remove galleries list action (#17648)

* multi-level table support (#17638)

* multi-level table support

* comments

* address comments

* add period to end of sentence.

* Show connection string example for add sql binding quickpick (#17650)

* add connection string example

* reorder

* Resolves same-origin-policy violation when ADS web is running in a container (#17555)

* Stops appending port to authority for web mode

* Clarifies comment

* Adds missing sql carbon edit tag

* vbump STS (#17653)

* use latest STS (#17658)

* Refactoring readProjFile() (#17637)

* move reading project parts to different helper functions

* cleanup

* remove comment

* addressing comments

* Corrects Web Build Pipeline ENOENT Error (#17656)

* Checks for successful directory creation

* Revert "Checks for successful directory creation"

This reverts commit 372409ef323f0d82e11992bc7bc33d607a7d5581.

* Checks for the existence of the logs directory before accessing.

* Adds SQL carbon edit comment

* Removing call to copy from non-existing directory.

* Removes unneeded import

* Checks for file existence before copying.

* Provides explanation for modification

* Replaces file existence check with exception handling.

* Bump tools service (#17671)

* Apply changes from Remote Database to sqlproj - mssql changes (#17655)

* update project from database

* update project from database

* update project from database

* Re-adding schemaComparePublishChanges for temporary backcompat

* Adding comment for keeping enum values in sync

* Correcting enum value

Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>

* update add file/folder for msbuild sdk style projects (#17660)

* update add file for msbuild sdk style projects

* also handle add folder

* fix comment

* fix issue reported by component governance (#17678)

* update json-schema version

* remove unused packages

* update package.json

* SQL Binding: Give default connection setting name (#17659)

* show sqlconnectionstring in quickpick

* fix duplicate sqlconnectionstring setting

* add (new)

* add sqlconnectionstring as default setting name

* check if sqlconnectionstring already exists

* Provide aria-labels for node checkboxes in the tree view. (#17676)

During accessibility testing, it was discovered that screen reader does not announce what checkboxes in the tree view represent. It was merely announcing "checkbox unchecked", so it was not clear without visuals which checkbox the focus is on.

This change sets an `aria-label` of the checkbox elements to match the label of the owning tree node. This way the announcement becomes "My Node; checkbox; unchecked". This is fine as a quick solution to the problem, but in the future we may want to consider adding additional checkbox label property to the nodes exposed by the tree provider, so that each checkbox can announce additional information, if needed.

* Respect ARIA label specified int he tree component options. (#17674)

During accessibility testing it was discovered that tree view in our wizard reads "Tree Node tree view" instead of the proper label that is specified. It turned out to be the problem with the tree component, where `ariaLabel` was hardcoded to "Tree Node", instead of the one provided in the options.

This change addresses the problem by passing through `ariaLabel` from the options object to the underlying tree control. I also removed the default `Tree Node` hardcoded label, as it didn't make much sense. This does mean that all tree-views that do not explicitly specify their aria-label will now get an empty label. I think this is better than having unrelated, unlocalized `Tree Node`.

I'm also worried about changes to the `ariaLabel` property after the component was initialized. I updated the code to propagate the value to the underlying tree view in the `setProperties` override of the tree component and hope that it will take care of it.

* Fix sql projects net6 warnings (#17673)

* fix .net 6 error showing on startup

* fix double warning

* addressing comments

* update key string

* undo adding space in net core sdk location setting (#17684)

* update names for msbuild sdk style projects (#17677)

* update names for msbuild sdk style projects

* remove msbuild from names

* update comments

* Designer: property descriptions (#17668)

* format

* added strings

* format doc

* use codicon instead

* show descriptions in property pane only

* fix ssdt string bug

* fix overflow option

* review comments

* review comments

* changes

* sts 156 vbump (#17683)

* Sql Binding: Add "Check out pane for more details" when nuget package download fails (#17680)

* check output for more details

* detail error

* wait for result from showerrormessage

* [Loc] Update to sql-database-projects and sql.xlf (#17687)

* update the vmImage for build jobs (#17689)

* update vmImage for windows build

* update tar command

* use specific macos version

* support building msbuild sdk style projects (#17675)

* support building msbuild sdk style projects

* fixes after merge

* add foreign keys and constraints (#17697)

* foreign keys and constraints

* refactoring

* fix issues

* properties pane improvements (#17700)

* [Loc] update to tabledesignercomponentinput (#17704)

* Add instructions for developing VS Code version of sql-database-projects (#17705)

* Adding UI for deploying a db proj to docker (#17495)

* code refactoring (#17706)

* Improve accessibility for wizard steps navigation (#17669)

Our extension is relying on the wizard dialog. During accessibility testing it was discovered that wizard step buttons are being reported as links by the screen reader (NVDA, JAWS). Claimed expected behavior by the tester is that they should be announced as buttons.

I discussed this issue with accessibility SMEs and they said it is perfectly fine to keep them as links. They did mention that they would probably design the UX differently from the start, but given that we already have it this way, links are fine. They did suggest to add few additional ARIA attributes to the link elements:

- `aria-current="step"` if the link is for the currently active step. This literally just announces "current step" at the end, when you focus on a link
- `aria-disabled="true"` makes it say "**unavailable**; link; *<step number>*" when in NVDA "browse" mode and move to the grayed-out link.

So this change implements the said improvements.

* bump sts version to 159 (#17709)

* LEGO: check in for main to temporary branch. (#17699)

* LEGO: check in for main to temporary branch. (#17702)

Co-authored-by: Alex Ma <alma1@microsoft.com>

* [Loc] update to sql-database-projects (#17713)

* LEGO: check in for main to temporary branch. (#17715)

* Register additional editor overrides when adding new notebook file types (#17708)

* Also standardized file extension contributions to always start with a period, and to always do lower case string comparisons for file extensions.

* input width in designer (#17714)

* Add additional properties to wizard page navigation events (#17716)

* Fix open external not working (#17717)

* save password checkbox fix (#17718)

* save password checkbox fix

* remove code to reset the checkbox value

* allow build to continue when cache task fails (#17720)

* cache task should not fail the build

* update cachesalt

* Fix language flavor change on connection when in sqlcmd mode (#17719)

* Fix language flavor change on connection when in sqlcmd mode

* comment + fix

* LEGO: check in for main to temporary branch. (#17722)

* LEGO: check in for main to temporary branch. (#17724)

Co-authored-by: Alex Ma <alma1@microsoft.com>

* Update one more variable name for sdk style projects (#17710)

* LEGO: check in for main to temporary branch. (#17725)

Co-authored-by: Alex Ma <alma1@microsoft.com>

* LEGO: check in for main to temporary branch. (#17726)

Co-authored-by: Alex Ma <alma1@microsoft.com>

* LEGO: check in for main to temporary branch. (#17730)

* Fix "unsupported version" error when adding sql binding package (#17721)

* Apply changes from remote database to sqlproj - schema-compare changes (#17679)

* update project from database

* update project from database

* Merge from main

* Removing dupe test stub

* PR feedback

* cleanup

* PR feedback

* Fixing tests, adding stubs to update sqlproj as schema compare target

* updating code comment

Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>

* [Loc] Update to schema-compare XLF (#17733)

* Enabled deployment of Azure Arc data controllers in directly connected mode (#17707)

* Added fields for connectivity mode, custom loc, auto-metrics, auto-logs, and the dynamic enablement of such fields.

* Changed the description of the data controller details page.

* Change notebook params to work for direct mode

* Added login to dc deployment notebooks

* Fixed auto upload metrics and logs true/false, separated login into another cell.

* Removed localization of indirect and direct connectivity labels.

* Fix ordering of reading sqlproj Build Includes and Removes (#17712)

* evaluate includes and removes in order in sqlproj

* fix after merge

* fix comment

* update comment

* Add resource deployment samples for (#17734)

* Update remove file for sdk style sql projects (#17688)

* add support for removing file in new style project

* fix test

* only load files, not whole project when checking if a <Build Remove> needs to be added

* merge changes

* fixes after merge

* [Loc] update to Arc XLF (#17737)

* Bump to latest version of azdata (#17735)

* Remove .net 6 version cutoff for building sql projects (#17736)

* remove .net 6 version cutoff for building sql projects

* Revert "Warning when .NET 6 SDK is detected (#17422)"

This reverts commit 2ed8aeb565.

* add back skipVersionSupportedCheck

* add back return false

* addressing comments

* [Loc] update to sql-database-projects xlf (#17743)

* Add additional notebook tests for handling relative links. (#17739)

* [Loc] Fix for duplicate strings in LCL files (#17756)

* WIP spanish lcl duplicate removal

* Revert "WIP spanish lcl duplicate removal"

This reverts commit 5f943153ec8980849a045c8bf7256d852571a778.

* fix for duplicate strings

* removed spaces

* Fixes ADS Web bug around copying user codes and opening a browser tab when adding an Azure Account. (#17760)

* Fixes bug around copying user codes and opening a browser tab.

* Code review changes

* Additional review changes.

* Unnecessary import removed

* Editing pipeline ACR service connection endpoint to the latest one created  (#17767)

* using the new registry endpoint

* updating the service connection

* Changing the name of acr service endpoint to SqlToolsContainer

* Updating web build acr endpoint as well.

* Notebooks: Add Tooltips for Link/Image Buttons on Markdown Toolbar (#17763)

* Add title for tooltips

* Tweak tooltips

* Added UI for user to accept EULA when deploying sql proj to docker container (#17762)

* fix sorting bug (#17769)

* fix sorting bug

* comments

* Set default radio button selection, evaluate default component popula… (#17764)

* Set default radio button selection, evaluate default component population off of selection instead of unprocessed input

* rename var

* if -> switches

* Remove project radio buttons because they require commands that aren't yet checked in (and fail as a result)

* Added fix for Publish Target Label Position (#17771)

* Added fix for Publish Target Label Position

* renamed checkbox

* LEGO: check in for main to temporary branch. (#17775)

* LEGO: check in for main to temporary branch. (#17778)

Co-authored-by: Alex Ma <alma1@microsoft.com>

* update dashboard taskbar separator (#17779)

* remove comments

* fix applying decorations

* add test

* enable find in sql result set

* add tests and update sql results highlight logic

* calculate the outputComponent index

* fix editor issues later

* remove newline replace on search

* address comments

* fix highlight issue

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
Co-authored-by: Lucy Zhang <luczhan@microsoft.com>
Co-authored-by: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com>
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com>
Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>
Co-authored-by: Alexander Ivanov <nahk-ivanov@users.noreply.github.com>
Co-authored-by: Aditya Bist <adbist@microsoft.com>
Co-authored-by: Sai Avishkar Sreerama <74571829+ssreerama@users.noreply.github.com>
Co-authored-by: Alex Ma <alma1@microsoft.com>
Co-authored-by: Leila Lali <llali@microsoft.com>
Co-authored-by: csigs <csigs@users.noreply.github.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: Candice Ye <candiceye@berkeley.edu>
Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>

* Remove undo/redo listeners from notebook component (#17966)

* remove undo/redo hostlisteners

* fix table focus issue (#17970)

* fix table focus issue

* fix hygiene error

* web

* new sts

* add await

* pr comments

* comments

Co-authored-by: Barbara Valdez <34872381+barbaravaldez@users.noreply.github.com>
Co-authored-by: brian-harris <61598682+brian-harris@users.noreply.github.com>
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: csigs <csigs@users.noreply.github.com>
Co-authored-by: Aditya Bist <adbist@microsoft.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Maddy <12754347+MaddyDev@users.noreply.github.com>
Co-authored-by: Lucy Zhang <luczhan@microsoft.com>
Co-authored-by: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com>
Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com>
Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>
Co-authored-by: Alexander Ivanov <nahk-ivanov@users.noreply.github.com>
Co-authored-by: Sai Avishkar Sreerama <74571829+ssreerama@users.noreply.github.com>
Co-authored-by: Alex Ma <alma1@microsoft.com>
Co-authored-by: Leila Lali <llali@microsoft.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: Candice Ye <candiceye@berkeley.edu>
Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>
2022-01-06 11:45:40 -08:00
Charles Gagnon
2bc6a0cd01 VS Code merge to df8fe74bd55313de0dd2303bc47a4aab0ca56b0e (#17979)
* Merge from vscode 504f934659740e9d41501cad9f162b54d7745ad9

* delete unused folders

* distro

* Bump build node version

* update chokidar

* FIx hygiene errors

* distro

* Fix extension lint issues

* Remove strict-vscode

* Add copyright header exemptions

* Bump vscode-extension-telemetry to fix webpacking issue with zone.js

* distro

* Fix failing tests (revert marked.js back to current one until we decide to update)

* Skip searchmodel test

* Fix mac build

* temp debug script loading

* Try disabling coverage

* log error too

* Revert "log error too"

This reverts commit af0183e5d4ab458fdf44b88fbfab9908d090526f.

* Revert "temp debug script loading"

This reverts commit 3d687d541c76db2c5b55626c78ae448d3c25089c.

* Add comments explaining coverage disabling

* Fix ansi_up loading issue

* Merge latest from ads

* Use newer option

* Fix compile

* add debug logging warn

* Always log stack

* log more

* undo debug

* Update to use correct base path (+cleanup)

* distro

* fix compile errors

* Remove strict-vscode

* Fix sql editors not showing

* Show db dropdown input & fix styling

* Fix more info in gallery

* Fix gallery asset requests

* Delete unused workflow

* Fix tapable resolutions for smoke test compile error

* Fix smoke compile

* Disable crash reporting

* Disable interactive

Co-authored-by: ADS Merger <karlb@microsoft.com>
2022-01-06 09:06:56 -08:00
Aditya Bist
2a681605fa Updated credentials system (#17888)
* linting

* added flags

* remove testing values

* format

* format doc

* tested in linux

* remove unused interface

* comments

* review comments

* clean imports

* pr comments

* format doc

* changed promise location

* insiders december

* pr comments

* test ado change

* fix test

* comment out code for hygiene

* remove unused imports

* test creds from client only

* remove unused import

* trying enabling keytar

* trying enabling keytar

* disable in correct script

* print statements

* remove print statements

* check mock output

* add linux check

* remove print statements
2021-12-17 10:55:42 -08:00
Karl Burtram
046cc7c798 Fix typo in vbump (#17937) 2021-12-15 12:17:57 -08:00
Karl Burtram
30fe784b78 Bump STS to rollback data type changes (#17935) 2021-12-15 12:10:21 -08:00
Alan Ren
13a82fce94 vbump sts (#17865) 2021-12-08 13:28:00 -08:00
Alan Ren
cde4e05320 bump sts version (#17809) 2021-12-03 13:33:53 -08:00
Alan Ren
c74a89674a bump sts version to 159 (#17709) 2021-11-18 17:48:10 -08:00
Sai Avishkar Sreerama
3cbd2fe5df sts 156 vbump (#17683) 2021-11-16 16:51:38 -06:00
Alan Ren
fc0d175f39 fix issue reported by component governance (#17678)
* update json-schema version

* remove unused packages

* update package.json
2021-11-15 17:45:21 -08:00
Benjin Dubishar
b5f8e81250 Apply changes from Remote Database to sqlproj - mssql changes (#17655)
* update project from database

* update project from database

* update project from database

* Re-adding schemaComparePublishChanges for temporary backcompat

* Adding comment for keeping enum values in sync

* Correcting enum value

Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>
2021-11-15 15:42:56 -08:00
Benjin Dubishar
d6159a2370 Bump tools service (#17671) 2021-11-15 14:40:40 -08:00
Alan Ren
4538103e60 use latest STS (#17658) 2021-11-12 13:33:52 -08:00
Alan Ren
7a1c0a67b9 vbump STS (#17653) 2021-11-11 15:07:09 -08:00
Sai Avishkar Sreerama
8a6268cce8 STS VBump with v147 (#17627) 2021-11-08 15:06:35 -06:00
Benjin Dubishar
9b06f3551d Revert "Bump tools service (#17607)" (#17613)
This reverts commit b4d72af3d4.
2021-11-05 16:52:48 -07:00
Benjin Dubishar
b4d72af3d4 Bump tools service (#17607) 2021-11-05 14:48:28 -07:00
Alan Ren
c9be45b9c7 feature flag for table designer (#17597) 2021-11-05 11:19:59 -07:00
Karl Burtram
d7b0b6c251 Add untrusted workspace supported flags (#17557) 2021-11-01 20:48:05 -07:00
Aasim Khan
447b969b5c updating sts to get sql star expansion (#17528) 2021-10-28 13:17:39 -07:00
Alan Ren
7b9caffcc2 vbump sqltools service (#17484) 2021-10-25 11:00:10 -07:00
Alan Ren
328ed83cb9 add disposeTableDesigner (#17394) 2021-10-19 14:28:56 -07:00
Alan Ren
569d5cf694 rename dataModel to viewModel (#17387) 2021-10-19 09:52:03 -07:00
Alan Ren
af8611455c use STS to process the requests (#17358) 2021-10-14 13:36:46 -07:00
Sai Avishkar Sreerama
16fb0dd4eb vbump sts (#17355) 2021-10-13 23:11:11 -05:00
Alan Ren
ce4459a7b2 Table Designer - Save Changes feature and Editor related features (#17335)
* table designer add/remove row support

* save changes and editor support

* address comments

* fix build error

* including missing change

* lower case request name
2021-10-11 15:09:25 -07:00
Alan Ren
abe54a2b92 initial PR for table designer feature (#17200)
* wip

* wire up e2e

* hook up styler and add as dataprotocal feature

* designer child component rendering

* table component updates

* styler and selectbox column editor

* fix editor size and dupe component creation issue

* fix checkbox column and add more testing data

* properties pane

* only rerender when needed

* properties pane update

* update commands

* cleanup for PR

* revert unwanted changes

* Adding a few tests for Add SQL binding (#17079)

* initial changes

* add a couple more tests

* LEGO: check in for main to temporary branch. (#17089)

* LEGO: check in for main to temporary branch. (#17091)

Co-authored-by: kburtram <karlb@microsoft.com>

* Adds autorest-based SQL Project generation to SQL Database Projects extension (#17078)

* Initial changes

* checkpoint

* Constructing project with post deployment script

* Correcting to intentionally read from cached list of projects

* Adding activation event, fixing fresh workspace bug

* Convert netcoreTool and autorestHelper to share a helper class for streamed command

* Include npm package version to force update

* test checkpoint

* Unit tests

* Added contextual quickpicks for autorest dialogs

* Adding projectController test

* Added projectController test, some refactoring for testability

* Merge branch 'main' into benjin/autorest

* Fixing 'which' import

* PR feedback

* Fixing tests

* Adding additional information for when project provider tests fail

* Hopefully fixing failing tests (unable to repro locally)

* Adding Generate Project item to workspace menu

* PR feedback

* LEGO: check in for main to temporary branch. (#17097)

* added sql database projects strings (#17100)

* Set kernelAlias in startSession when isValidConnection is truthy (#17102)

* PR follow-up comments (#17113)

* Change recompare message after changing options to modal (#17103)

* Change recompare message to modal

* change options to yes and no

* Remove commented code block in git extension (#17116)

* Remove commented code block in git extension

* Add SQL CARBON EDIT tag

* [Loc] Small change to generatingProjectFailed (#17118)

* Add Null Shortcut and added NULL text for default NULL value. (#17085)

* added test key event

* added null function to tryHandleKeyEvent

* added null formatting

* added working null insert.

* added editDataGridPanel string null support

* Bump nth-check from 2.0.0 to 2.0.1 in /build (#17115)

Bumps [nth-check](https://github.com/fb55/nth-check) from 2.0.0 to 2.0.1.
- [Release notes](https://github.com/fb55/nth-check/releases)
- [Commits](https://github.com/fb55/nth-check/compare/v2.0.0...v2.0.1)

---
updated-dependencies:
- dependency-name: nth-check
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add excludeFlags to extenson marketplace query (#17121)

* Add excludeFlags to extenson marketplace query

* Remove dead code

* Remove extraneous blank line

* Address code review feedback

* Adding Derived Columns to ADS Flatfile Import (#16795)

* Adding derived column boilerplate

* brandan preliminary frontend changes

* empty commit

* added new param

* updating contracts, dialogue changes

* utils changes, saving timeout attempt

* pushing for aasim

* Cleaning up code and fixing the issue in theory

* changing button, did not solve independent scroll

* Fixing the scroll bar issue

* updating flat file service

* adding override keyword to overrriden method

* improving UI

* pushing changes associated with resolved comments

* localizing strings, editing comments

* all comments resolved

* Fixing a test

* updating import package
Updating azure MFA bug

* Clearing navigation validator
Fixing broken table name change

* fixed prose test

* removing unused code from tests

* Fixed PR comments

* Fixing some PR comments

* WIP

* Fixing transformation code and create derived column dialog styling

* removing unused code

* Adding comment for console log

* fixed table styling

* Adding some aria labels

* Fixed some code cleanup issues

* update import service

Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
Co-authored-by: bnhoule <t-bhoule@microsoft.com>

* Change keybindings for copying query with Results (#17127)

Co-authored-by: Monica Gupta <mogupt@microsoft.com>

* sql proj - publish to docker improvements  (#17124)

* Add AAD token expiration handling for query runner (#17117)

* Add AAD token refresh for notebook

* move token refresh to query management and remove previous refresh calls

* Add guids to RunAll and RunCell events (#17123)

Add guids to RunAll and RunCell events

* add error banner for failed migration cutover and cancel migration (#17106)

* [Loc] update to sql migration, database projects and import extension strings (#17130)

* Apply optional storage class settings in sql mi create command (#17129)

* Make storage classes optional

* Fix notebook to use storage class options

Co-authored-by: Charmaine Chan <chachan@microsoft.com>

* Add support for adding new setting in local.settings.json in add SQL binding quickpick (#17093)

* be able to add new setting in local.settings.json

* cleanup

* addressing comments

* remove todo comment

* addressing comments

* update some strings to uris

* bump version of sqltoolsservice (#17133)

* mark schema compare tests as unstable (#17140)

* [Loc] Update for arc and sql-database-projects (#17148)

* ML extension vbump (#17143)

* Configure docker image and web smoke tests for ADSWeb. (#17136)

* Adjusts timeout period

* Revert "Adjusts timeout period"

This reverts commit 0f372eae2a4611554093b6c09f1ff6c451132e19.

* Adds firefox as browser option

* Corrects yaml smoke test script

* Resets args array to original values

* Corrects build path

* Resolves ignoring browser option error

* continue even after writing to stderr

* Adjusts smoke test (browser) script

* More adjustments to smoke test script

* Corrects server path

* Uses build variable directly in build path

* Specifies browser type since cannot be ignored error

* Adds browser option

* Updates web build image and corrects smoke test exe command

* Removes commented out task

* Updates dockerfile to support web smoketests

* Removes failOnStderr flag

* Use curl instead of wget in Dockerfile

* Fixed a bug with cancling publish (#17160)

* Save And Close Functionality (#17000)

* save and close

* wip

* working save and close

* cleanup

* pr changes

* pr changes

* fix capitalization

* fix build

* pr fix

* Added dynamic options for SQL MIAA Deployment Wizard and updated checkbox field (#17119)

* Dynamic enablement

* Added new package.json field for dynamic options and corresponding functions and classes.

* Enabled dynamic options non-generalized and changed formatting of checkbox to have label on the left.

* Added setOptions under InputComponentInfo for generalization, comments under checkbox component, and changed Replicas to High Availability to reflect parity in portal.

* fix unit test

Co-authored-by: Candice Ye <canye@microsoft.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>

* LEGO: check in for main to temporary branch. (#17168)

* [Loc] added new arc strings and fix for sql-database-projects lcl file for Japanese (#17171)

* [Loc] added new arc strings and fix for sql-database-projects xlf

* removed newline

* Port of Vscode fix for colors too close (#17146)

* default light colors list.focusHighlightForeground too close to list.activeSelectionBackground. Fixes #127597

* remove activeSelectionBackground from theme-carbon as it conflicts with vscode.

* remove dark carbon background

Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>

* Markdown Horizontal Scrollbar Fix (#17083)

* dynamically change horizontal scrollbar

* working horizontal scrollbar

* created new event to handle both scrollbar and mouse wheel

* only show scrollbar when needed

* LEGO: check in for main to temporary branch. (#17181)

* Bump axios to 0.21.4 (#17161)

* Kusto version bump to 0.5.6 (#17114)

* Bumped Kusto toolsservice version to 125 and bumped version to 0.5.6

* Changed netcoreapp3.1 to net5.0 in Kusto config.json

* AzureMonitor bump ToolService version and extension version. (#17174)

* Bump concat-with-sourcemaps from 1.0.4 to 1.1.0 (#17158)

Bumps [concat-with-sourcemaps](https://github.com/floridoo/concat-with-sourcemaps) from 1.0.4 to 1.1.0.
- [Release notes](https://github.com/floridoo/concat-with-sourcemaps/releases)
- [Commits](https://github.com/floridoo/concat-with-sourcemaps/commits)

---
updated-dependencies:
- dependency-name: concat-with-sourcemaps
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update service downloader to 0.2.3 (#17186)

* Notebook Views grid fixes (#17170)

* update data workspace restart ADS to open workspace message (#17188)

* update message

* update string

* Add back "Remove Project" (#17178)

* remove project working with full paths

* use relative paths

* const

* addressing comments

* Bump github-auth axios to 0.21.4 (#17189)

* LEGO: check in for main to temporary branch. (#17192)

* LEGO: check in for main to temporary branch. (#17190)

Co-authored-by: kburtram <karlb@microsoft.com>

* [Loc] Add a small change to dataworkspace (#17194)

* added bump to sqltoolsservice version (#17195)

* Check if file is dirty before adding sql binding (#17175)

* check if file is dirty before adding sql binding

* Addressing comments

* Add vertical scroll bar to Preview in Split View (#17164)

* reset max height

* add editor height

* set md editor height

* Split up NotebookProvider into separate providers for handling file serialization and cell execution. (#17176)

* fix floating promises

* pr comments

* reuse component definition

* comments

* fix error

Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: csigs <csigs@users.noreply.github.com>
Co-authored-by: kburtram <karlb@microsoft.com>
Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com>
Co-authored-by: Alex Ma <alma1@microsoft.com>
Co-authored-by: Justin M <63619224+JustinMDotNet@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: bnhoule <52506119+bnhoule@users.noreply.github.com>
Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
Co-authored-by: bnhoule <t-bhoule@microsoft.com>
Co-authored-by: Monica Gupta <scorpio90m@gmail.com>
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
Co-authored-by: Leila Lali <llali@microsoft.com>
Co-authored-by: Hai Cao <hacao@microsoft.com>
Co-authored-by: Daniel Grajeda <dagrajed@microsoft.com>
Co-authored-by: brian-harris <61598682+brian-harris@users.noreply.github.com>
Co-authored-by: Charmaine Chan <69230572+charmainewkchan@users.noreply.github.com>
Co-authored-by: Charmaine Chan <chachan@microsoft.com>
Co-authored-by: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com>
Co-authored-by: Christopher Suh <chsuh@microsoft.com>
Co-authored-by: Candice Ye <candiceye@berkeley.edu>
Co-authored-by: Candice Ye <canye@microsoft.com>
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
Co-authored-by: Vasu Bhog <vabhog@microsoft.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Barbara Valdez <34872381+barbaravaldez@users.noreply.github.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
2021-10-08 19:24:31 -07:00
Alan Ren
a25dd2c03b fix component detection error (#17319) 2021-10-08 13:03:40 -07:00