Commit Graph

189 Commits

Author SHA1 Message Date
Neetu Singh
3faf51b573 [Port] [SQL Migration] Bug fixes for new feature SKU Recommendation in migration extension (#18449)
* Bump follow-redirects in /extensions/resource-deployment (#18349)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* LEGO: check in for main to temporary branch. (#18347)

Co-authored-by: Alex Ma <alma1@microsoft.com>

* [Loc] update to sql.xlf and sql-migration (#18352)

* Bump follow-redirects in /extensions/github-authentication (#18348)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump follow-redirects from 1.14.7 to 1.14.8 in /extensions/azurecore (#18350)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump ajv from 6.12.0 to 6.12.6 in /extensions/mssql (#18316)

Bumps [ajv](https://github.com/ajv-validator/ajv) from 6.12.0 to 6.12.6.
- [Release notes](https://github.com/ajv-validator/ajv/releases)
- [Commits](https://github.com/ajv-validator/ajv/compare/v6.12.0...v6.12.6)

---
updated-dependencies:
- dependency-name: ajv
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Database Projects - Add existing file (#18066)

* Add existing file to sqlproj

* Address PR comments

* Fix failing test

* Add convertSlashesForSqlProj to test failure

* Using proper zoom icon (#18338)

* Bump ansi_up (#18190)

* Fixing graph editing (#18361)

* Update to langpacks and xlfs for February Release, (#18354)

* Update to langpacks and xlfs

* fixed id for git

* Added small fix for locFunc (#18364)

* Small update to the changelog (#18369)

* [Loc] small update to sql-database-projects xlf (#18396)

* azdataGraph version bump to 0.0.15 (#18388)

* azdataGraph version bump to 0.0.15

* Updates azdataGraph version in remote package.json

* Updates azdataGraph version in remote web package.json

* Adding tooltips and fixing spacing (#18400)

* avoid auto language detection for sql editor (#18402)

* avoid auto lang detection for sql editor

* update comment

* fix SDK style projects not being able to find system dacpacs (#18218)

* fix SDK style projects not being able to find system dacpacs

* fix tests

* LEGO: check in for main to temporary branch. (#18417)

* LEGO: check in for main to temporary branch. (#18419)

* Bump url-parse (#18422)

* make sure the content is not undefined (#18406)

* [SKU Recommendation] Adding telemetry for errors happening during data collection/ get  recommendation and telemetry (#18345)

* Adding telemetry for errors happening during data collection/ telemetry for sku recommendation

* log and error happended during get sku recommendation

* Resolving comments from PR https://github.com/microsoft/azuredatastudio/pull/18252. 1) Adding click and close events to dispoable collection to avoid leaks. 2) Adding readable constant for number representing minutes.

* Changes - 1) updating migration workflow strings, 2) adding more onclick events to disposable collection.

* Remove PaaS, IaaS terms from string

* Changes -
1) Renamed 'Saved assessment result' to 'saved session'.
2) Removed Title from 'saved session' page.
3) Added stop data collection on migration start.

* Fixing context menu strings (#18404)

* Fixing context menu strings

* Fixing string

* Adding zoom button (#18407)

* Adding zoom button

* Fixing string

* Fixing the height of the query plan (#18409)

* Fixing the height of the query plan

* Fixing layout issues

* Fix on click edit mode states (#18321)

* fix click code cell

* modified editmode when updating active cell

* Updating readme with new gif that includes SKU Recommendation (#18432)

* Fix contributed icons for ModelView trees not showing (#18430)

* Fix contributed icons for ModelView trees not showing

* Use asCssUrl

* Fixed color contrast for error message in connect a dc window. (#18411)

* Fixed color contrast for error message in connect a dc window.

* Remove color check for error message

* Remove more unneeded checks

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* fix holding down key scrolling issue (#18322)

* Stop propagation + debounce scroll

Co-authored-by: chgagnon <chgagnon@microsoft.com>

* LEGO: check in for main to temporary branch. (#18443)

* Adds Operational Cost to Query Plan Vertex Labels. (#18435)

* Adds operational cost to graph node labels.

* Code clean up.

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: csigs <csigs@users.noreply.github.com>
Co-authored-by: Alex Ma <alma1@microsoft.com>
Co-authored-by: Z Chen <13544267+zijchen@users.noreply.github.com>
Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: Barbara Valdez <34872381+barbaravaldez@users.noreply.github.com>
Co-authored-by: Candice Ye <candiceye@berkeley.edu>
2022-02-17 14:12:58 -08:00
Raymond Truong
3cfd1d23da [Feature] SKU recommendations in SQL migration extension (#18252)
* Initial check in for SQL migration SKU recommendation feature (#18116)

Co-authored-by: Raymond Truong <ratruong@microsoft.com>

* add TargetSelectionPage, remove AccountSelectionPage, fix saveAndClose bugs (#18092)

* update sku interfaces (#18150)

* create the skuRecommendationResultsDialog (#18151)

* add TargetSelectionPage, remove AccountSelectionPage, fix saveAndClose bugs

* create skuRecommendationResultsDialog

* Replace placeholder SKU recommendation results with actual results (#18153)

* Replace placeholder SKU recommendation results with actual backend call results

* Remove skuRecommendationExample

* Replace number fields in interfaces with correct enums, and update UI text

* add getAzureRecommendationDialog for performance collection (#18159)

* add getAzureRecommendationDialog when there are no recommendations available

* update 'get azure rec' / 'view details' link values

* add condition to check if recommendations are available

* Implement start/stop perf data collection + import perf data into new UI (#18149)

* Implement start/stop perf data collection

* add getAzureRecommendationDialog when there are no recommendations available

* update 'get azure rec' / 'view details' link values

* add condition to check if recommendations are available

* Implement import existing data + start/stop perf collection with new UI

Co-authored-by: Rachel Kim <rackim@microsoft.com>

* Expose SqlInstanceRequirements in SKU recommendation results (#18207)

* Expose SqlInstanceRequirements

* Move string literals to constants file

* Fix formatting in mssql.d.ts

* create storage properties table (#18215)

* Edit sku recommendation parameters (#18244)

* Edit sku recommendation parameters

* make _targetPercentileDropdown not editable; styling updates

* Azure recommendation section exposes data collection status and stop option (#18246)

* Edit sku recommendation parameters

* create azure recommendation details section on sku page

* Improve error handling + add auto refresh + other small changes (#18228)

* Update source properties table

* WIP - refresh perf data collection

* Add auto refresh logic

* Address comments

Co-authored-by: Rachel Kim <rackim@microsoft.com>

* Show/hide azure recommendation components based on data collection source and status (#18254)

* add refresh recommendation button; show/hide content based on perf collection status

* show/hide azure rec content based on perf data source scenarios

* add popups for start/stop; allow user to restart data collection; add perf collection to save close; add info tooltips (#18278)

* Update SKU recommendation timer logic (#18281)

* Update timer logic

* Fix misc UI bugs

* update sql migration extension readme (#18295)

* Remove empty constant, as this may have broken the build

* Fix 'save and close' behavior for SKU recommendation (#18301)

* Update timer logic

* Fix misc UI bugs

* 'WIP'

* Add logic to restore correct SKU recommendation state when reloading

* SKU UX enhancements - status info, button validations, savedInfo logic (#18320)

* add stop/inprogress status icons to perf collection status text, update restart icon

* refactor savedInfo as an interface, edit parameter recommednations are saved, add open folder inputbox validation, handle no recommendations available scenario

* fix getazureredialog bug, cleanup cold

* nit card styling

* Update recommendations whenever user changes list of databases to assess + misc clean up (#18323)

* Consolidate constants, clean up redundant functions, misc clean up

* Remove old SKU recommendation interfaces

* Update some more strings

* Telemetry events for SKU Recommendation (#18282)

* Telemetry events for SKU Recommendation

* Addressing comments -
1) fixed camel casing
2) removed extra logging to console
3) added telemetry for subid, rg, tenantid on targetselectionpage

* Resolving conflicts

* Addressing comments - 1) removing filename 2) moving all numbers to measurements.

* Resolving comment - Fixing telemetry value for tenant id.

* removing warning 'logError' is declared but its value is never read (#18333)

* Stop existing data collection when leaving and starting a new migration + update timers (#18339)

* Refresh recommendations when pressing stop data collection button

* Fix orphaned data collection when save and closing and starting a new
migration

* Revert "Refresh recommendations when pressing stop data collection button"

This reverts commit e6fb2ade8f8a41952adb81cb0ee852414dfa4ef2.

* Update timers to use production values

* Remove unused import

* address bug bash issues: add learn more link, add last refreshed time, fix vm card view detail open issue, remember last selected folder, remove strings, refactor refresh logic on sku page (#18340)

* Address comments

* Update to sqltoolsservice 3.0.0-release.204

Co-authored-by: Rachel Kim <rackim@microsoft.com>
Co-authored-by: Neetu Singh <23.neetu@gmail.com>
2022-02-11 21:23:49 -08:00
Rachel Kim
a2e34c4609 Add new help articles to sql migration dashboard (#18240)
* add new articles to help section

* Update extensions/sql-migration/src/dashboard/sqlServerDashboard.ts

* fix typo, remove link

* remove locale in links

Co-authored-by: Mohamed Kabiruddin <39162740+mokabiru@users.noreply.github.com>
2022-02-10 18:30:19 -08:00
Charles Gagnon
2bc6a0cd01 VS Code merge to df8fe74bd55313de0dd2303bc47a4aab0ca56b0e (#17979)
* Merge from vscode 504f934659740e9d41501cad9f162b54d7745ad9

* delete unused folders

* distro

* Bump build node version

* update chokidar

* FIx hygiene errors

* distro

* Fix extension lint issues

* Remove strict-vscode

* Add copyright header exemptions

* Bump vscode-extension-telemetry to fix webpacking issue with zone.js

* distro

* Fix failing tests (revert marked.js back to current one until we decide to update)

* Skip searchmodel test

* Fix mac build

* temp debug script loading

* Try disabling coverage

* log error too

* Revert "log error too"

This reverts commit af0183e5d4ab458fdf44b88fbfab9908d090526f.

* Revert "temp debug script loading"

This reverts commit 3d687d541c76db2c5b55626c78ae448d3c25089c.

* Add comments explaining coverage disabling

* Fix ansi_up loading issue

* Merge latest from ads

* Use newer option

* Fix compile

* add debug logging warn

* Always log stack

* log more

* undo debug

* Update to use correct base path (+cleanup)

* distro

* fix compile errors

* Remove strict-vscode

* Fix sql editors not showing

* Show db dropdown input & fix styling

* Fix more info in gallery

* Fix gallery asset requests

* Delete unused workflow

* Fix tapable resolutions for smoke test compile error

* Fix smoke compile

* Disable crash reporting

* Disable interactive

Co-authored-by: ADS Merger <karlb@microsoft.com>
2022-01-06 09:06:56 -08:00
brian-harris
6f3a68bf68 sql-migration vbump 0.1.12 (#17955) 2021-12-16 13:55:06 -08:00
goyal-anjali
80541ce6f0 Add telemetry to troubleshoot customer issues (#17748)
* Add telemetry to troubleshoot customer issues

* Updating logerror method calls with custom errors

* Add performance telemetry
2021-12-06 11:39:41 +05:30
Rachel Kim
8d8b3983a9 Support multiple database migrations using network share (#17796)
* update database backup model to take list of network shares

* remove refreshMigrationTiles after startMigration in statemachine; add null checks
2021-12-03 17:07:11 -08:00
Rachel Kim
6aab9d41a3 Add backups restored progress when migrating from Azure Blob Storage (#17795) 2021-12-03 17:06:37 -08:00
brian-harris
f9e1f38393 set initial target db name (#17801) 2021-12-03 10:58:17 -08:00
brian-harris
36364e10c4 add migration state management improvement (#17799)
* add migration state management improvement

* remove extra lines
2021-12-02 15:40:58 -08:00
Karl Burtram
d7b0b6c251 Add untrusted workspace supported flags (#17557) 2021-11-01 20:48:05 -07:00
Christopher Suh
66ebbc2181 Save & Close Fixes (#17469)
* wip

* fixed save & close summary page

* cleanup

* pr comments
2021-11-01 15:12:04 -07:00
brian-harris
7a5ad9f3aa bump version to 0.1.10 (#17510) 2021-10-27 12:13:58 -07:00
brian-harris
aa0e52c245 improve account and tenant selection error handling (#17476)
* improve account/tenant selection error handling

* remove extra space from user string
2021-10-25 12:26:38 -07:00
Charles Gagnon
89c15c9496 Fix assessment results dialog telemetry (#17483) 2021-10-25 09:51:00 -07:00
brian-harris
70f6eebc5a apply unique filter to getLocations api's (#17454)
* apply unique filter to getLocations api's

* filter resource locations to distinct list

* simplify location filter
2021-10-22 16:00:07 -07:00
Rachel Kim
4b26be5742 Retry sql migration (#17376) 2021-10-21 10:06:10 -07:00
Rachel Kim
4ed4e5f39c Add DMS values to migration extension save and close feature (#17375) 2021-10-15 16:09:43 -07:00
brian-harris
2e677dbda6 add assessment error handling and bypass option (#17369)
* add assessment error handling and bypass option

* add desriptive text and results warnings
2021-10-15 15:15:52 -07:00
Rachel Kim
340acd750f fix typos in strings file (#17364) 2021-10-14 17:47:13 -07:00
stuti149
5de8d82417 update extension to use new offlineConfiguratin and offline property names (#17316) 2021-10-14 14:08:24 -07:00
Christopher Suh
95db579902 Fixes for Save & Close (#17341)
* wip

* wip

* fixes

* cleanup

* cleanup
2021-10-12 10:08:36 -07:00
Rachel Kim
e5f50499ce Standardize font styling on sql migration extension (#16968) 2021-10-11 14:58:37 -07:00
goyal-anjali
26b9b96f10 Fix DMS dropdowns reset every time we enter Data Migration Service page (#17225)
* Add placeholder for DMS resource group dropdown

* Show placeholder and not initialize value for dropdown
2021-10-08 10:37:53 +05:30
goyal-anjali
0dd544aff4 Add callout dialog from error count to detailed error message on migration status dialog (#16850) 2021-10-07 22:43:31 +05:30
stuti149
13712c3a38 remove list filter logic to allow all available DMS regions to be used (#17203) 2021-09-30 22:34:27 +05:30
stuti149
09884789b5 Update extension border / line styling (#17059)
* updated border styling of tables

* reducing border thickness

* fixing styling for dark mode

* fixing for dark mode

* removing box shadow from checkbox
2021-09-30 22:34:07 +05:30
goyal-anjali
5710a53e86 Update action buttons texts (#17193)
Update texts for action buttons
2021-09-30 19:14:57 +05:30
Christopher Suh
207254fa6c Save And Close Functionality (#17000)
* save and close

* wip

* working save and close

* cleanup

* pr changes

* pr changes

* fix capitalization

* fix build

* pr fix
2021-09-24 14:59:35 -07:00
brian-harris
155ea4c707 add error banner for failed migration cutover and cancel migration (#17106) 2021-09-21 23:31:36 -07:00
Aasim Khan
95e82d53e6 Adding lists support in text component (#17065)
* Adding lists support in text component

* Fixing get textType

* Code cleanup

* Combining values into value
2021-09-14 12:43:14 -07:00
Rachel Kim
ceaa3efebd Add more telemetry props to sql migration extension (#17026) 2021-09-13 10:11:42 -07:00
goyal-anjali
869f83f5a3 Update card styling on extension dashboard (#17032) 2021-09-12 01:24:07 +05:30
Aasim Khan
cbba05f54f Using updated assessment nuget to get blocking issues (#17038) 2021-09-09 22:23:02 -07:00
goyal-anjali
2a3e98b263 Add a button which would allow the user to jump directly to add account dialog from Migration Status Dialog (#17011) 2021-09-10 01:40:03 +05:30
goyal-anjali
2cc4129f5c Remove the gray background/gray text for pre-selected values (#17005)
* Correct spelling

* Change styling for pre-selected values
2021-09-09 15:14:28 +05:30
stuti149
e962d63fa4 Updated Backup File Table Styling Similar to Migration Status Dailog (#16931)
* updated backup file table styling similar to migration status dailog

* alignining back up table with header

* fixing changes
2021-09-04 09:14:11 +05:30
Alex Ma
1e9cf0b9e4 tab fix for sql-migration after compile (#16996) 2021-09-03 13:23:44 -07:00
goyal-anjali
9f09f7be5d Update watermark and add styling for SQL Migration Dashboard (#16916)
*Update watermark, backgroung css and add gradient
*Remove unused images
2021-09-03 22:56:16 +05:30
goyal-anjali
34b5a983c0 Show image with "Add Account" message if user hasn't signed in - Migration Status Dialog (#16932) 2021-09-01 22:31:21 +05:30
Rachel Kim
22141259d3 Update public preview readme for sql migration extension (#16920) 2021-08-27 16:57:52 -07:00
stuti149
acc6fd0f96 Put search/ status/refresh in single line (#16898) 2021-08-27 13:35:37 +05:30
Rachel Kim
dc1e460f71 add autoCutoverConfiguration to getMigrationStatus (#16803) 2021-08-26 10:46:38 -07:00
stuti149
042d467fe7 disable cancel button after clicked once (#16783)
* disable cancel button after clicked once

* remove enabling of cancel button when cancelling
2021-08-26 22:13:50 +05:30
goyal-anjali
c00fc80f22 Adding info tooltips across migration wizard (#16654)
Adding info tooltips across migration wizard
2021-08-24 21:49:23 +05:30
Rachel Kim
c8602c2ced Update sql migration extension strings (#16801)
* initial capitalize; add periods; replace (s) with plural nouns to improve localization
2021-08-19 11:07:51 -07:00
Rachel Kim
ad75b03565 fix create dms dialog string (#16808) 2021-08-18 16:27:24 -07:00
brian-harris
c12cdffe9b Dev/brih/bugs/merge rtm hotfix changes (#16792)
* improves migration context loading error handling

* remove secrets and encode uris
2021-08-16 16:24:41 -07:00
goyal-anjali
1121429f5c Localize strings (#16781)
Localize all user viewable strings
2021-08-16 23:29:40 +05:30
Rachel Kim
7a57e62cd6 fix sql migration bugs on showing/hiding content based on scenarios (#16778) 2021-08-13 19:35:06 -07:00