Aasim Khan
438bc67072
Fixed the generate script logic for notebook wizards. ( #13418 )
...
* Fixed the generate script logic for notebook wizards.
* -reverted previous changes
-added last page check to the page validation change logic.
* checking if the page is valid when entering it.
* removing unnecessary index variable in forEach loop
* added comments for generate script button enabling on notebookwizard page.
2020-11-17 10:26:45 -08:00
Charles Gagnon
472c9decfa
Display error when doing notebook convert ( #13438 )
...
* Display error when doing notebook convert
* Update STS
2020-11-17 10:03:33 -08:00
Charles Gagnon
6cd2d6c942
Fix extension install version check ( #13436 )
2020-11-17 09:58:50 -08:00
Arvind Ranasaria
39e1181c5d
Remove WizardBase.ts ( #13350 )
2020-11-16 19:21:26 -08:00
Lucy Zhang
c898b50b94
Remove resultSet from IDisplayResult metadata ( #13450 )
...
* remove resultSet from IDisplayResult metadata
* remove metadata from IDisplayResult
2020-11-16 17:54:09 -08:00
Justin M
271fe62344
12567 Fixed Notebooks not adding to recent connections ( #13113 )
...
* 12567 Changed tryAddActiveConnection to always add recent connection
* 12567 Reverted change to tryAddActiveConnection. Removed this._params.input from connectionDialogService > createModel
* 12567 Simplified conditional in connectionDialogService
2020-11-16 11:27:09 -08:00
Justin M
c18a54bc1d
12666 Passed azureAccount into onFetchDatabases and set on tempProfile. ( #13239 )
2020-11-16 11:24:22 -08:00
Charles Gagnon
b57bf53b67
Fix ModelView container child layout issues ( #13412 )
2020-11-16 10:59:21 -08:00
Charles Gagnon
c699179e15
Re-register contributed book commands when new extension loaded ( #13403 )
2020-11-16 10:47:27 -08:00
Alan Ren
690937443c
enable the outline for active tab header ( #13415 )
2020-11-16 10:21:30 -08:00
Kim Santiago
698b79f0f3
bump sql database projects version ( #13408 )
2020-11-14 11:10:14 -08:00
Alan Ren
798af5fc2d
uncomment the hideContextMenu ( #13411 )
2020-11-13 16:30:17 -08:00
Charles Gagnon
af55dcfb42
Convert ModelView validate to Promise ( #13390 )
...
* Convert ModelView validate to Promise
* more cleanup
2020-11-13 15:31:22 -08:00
Charles Gagnon
76781d6cf4
Fix ModelView logging error ( #13410 )
2020-11-13 14:40:00 -08:00
Alan Ren
99e3da5b48
Editable dropdown component improvement ( #13389 )
...
* replace Tree with List
* comments
2020-11-13 13:36:54 -08:00
Chris LaFreniere
6b657259a5
Ensure that we close editors before utils tests ( #13391 )
2020-11-13 11:16:14 -08:00
Charles Gagnon
cbe2ba0901
Add some more logging to ModelView components ( #13387 )
...
* Add some more logging to ModelView components
* Remove catch
* remove unused
2020-11-13 10:30:40 -08:00
Arvind Ranasaria
b3d99117ca
onComplete -> onLeave for toolsAndEulaPage ( #13394 )
2020-11-13 09:59:08 -08:00
Charles Gagnon
32ac586431
Add MIAA Compute+Storage page ( #13367 )
...
* Add MIAA Compute+Storage page
* update min memory limits
* update strings
* feedback
2020-11-13 07:20:46 -08:00
Aasim Khan
bd4676ac8c
removing separate heading for page number and clubbing it with wizard title ( #13380 )
2020-11-13 00:38:04 -08:00
Charles Gagnon
536628603e
Fix ModelView container validation ordering ( #13386 )
...
* Fix ModelView container validation ordering
* Also validate component after adding
* undo child component validate call
2020-11-12 17:17:27 -08:00
Kim Santiago
ea7fe08b98
remove sqlproj from Project tree node ( #13379 )
2020-11-12 15:49:34 -08:00
Aasim Khan
6c920f6d54
Fixed the table width so it does not overflow from the wizard. ( #13372 )
2020-11-12 15:06:03 -08:00
Alex Ma
a2f7136728
Update for Azure SQL Hybrid Cloud Toolkit ( #13360 )
...
* Added azurehybridtoolkit to list of external extensions
* Added updated book
* added to recommended extensions
* extensions.js updated for build
* added small changes to extension
* small changes to extension
* tsconfig change
* gitignore and vscode changes
* changed package display name
2020-11-12 14:22:50 -08:00
Charles Gagnon
a082c1e478
Ignore built notebook component files ( #13369 )
2020-11-12 13:17:54 -08:00
Lucy Zhang
32a6385fef
Notebooks: Save cell connection name in cell metadata ( #13208 )
...
* save connection info in notebook metadata
* update attachTo dropdown based on saved alias
* add setting for saving connection (default=false)
* save/read cell connection name to/from metadata
* get started on toggling multi connection mode
* add activeConnection property to cell model
* add changeContext method for cell
* add comments
* add unit test for reading connection name
* save connection mode in metadata
* clean up code
* address PR comments
2020-11-12 10:44:34 -08:00
Karl Burtram
468119caa4
Update readme and changelog for 1.24.0 ( #13370 )
1.24.0_release
1.24.0
2020-11-12 10:09:59 -08:00
Kim Santiago
abdf575885
fix wizard page name and step getting announced when pages are added and removed ( #13362 )
2020-11-12 09:44:33 -08:00
Lucy Zhang
07df54ee61
Notebook: Add smoke test for trusted notebooks ( #13330 )
...
* add smoke test for trusted notebooks
* change repo
* update trustNotebook method
* pr comment
2020-11-12 06:45:20 -08:00
Kim Santiago
850422164c
Add setting for default dacpac save location ( #13194 )
...
* add setting for default save location
* lowercase
* addressing comments
2020-11-11 17:20:58 -08:00
Charles Gagnon
865d49c2fb
Always upload build artifacts + logs during product build ( #13356 )
2020-11-11 15:16:07 -08:00
Charles Gagnon
b17ce7a531
Use progress notification for azdata install/updates ( #13355 )
2020-11-11 15:14:02 -08:00
Charles Gagnon
d64062dfe0
Update minimum azdata version to 20.2.4 ( #13357 )
2020-11-11 15:13:43 -08:00
Karl Burtram
1b0f3af094
Bump ADS to 1.25 for Dec release ( #13358 )
2020-11-11 14:04:57 -08:00
Alex Ma
fa608f9f80
Azure SQL Hybrid Cloud Toolkit Notebooks Extension Command ( #13286 )
...
* added extension folder incomplete
* WIP extension progress
* notebook finally opens in side panel
* notebook now opens via notebook extension
* html file spaces restored
* package json fixed
* fixed vscode import issue
* more cleanup
* remove git stuff
* placeholder icon logos added
* fixed gulpfile
* cleanup changes
* vscode import fixed
* fixed main and yarn.lock
* added provided notebooks view
* formatting for package.json
* removed first command as its not necessary
* fixed notebook typo
* readded spaces
2020-11-11 13:50:36 -08:00
Charles Gagnon
b32e5f8f25
Add debug logging for ModelView ( #13346 )
2020-11-11 10:33:13 -08:00
Charles Gagnon
c37f178e71
Undo temporary changes made ( #13349 )
2020-11-11 10:26:22 -08:00
Alan Ren
3be00b1635
add tabindex and handle keyboard selection ( #13348 )
2020-11-10 23:00:03 -08:00
Lucy Zhang
b397150264
Notebooks: Add smoke test ( #13196 )
...
* add new smoketest
* change repro
* rename methods
* add waitforallresults method
* pr comment
2020-11-10 17:31:17 -08:00
Chris LaFreniere
8c6a966bb9
Re-enable notebook editor unit tests ( #13328 )
...
* wip
* Re-enable notebook editor tests
* PR Feedback
2020-11-10 17:04:30 -08:00
Charles Gagnon
b83da2dfa8
Run initial modelview actions first ( #13317 )
...
* Run initial modelview actions first
* add param
* Comments and typings
* Catch promise error
* fix db projects test
* remove extra calls
2020-11-10 17:00:16 -08:00
Charles Gagnon
b4dd0442c5
Fix extension unit test script cleanup ( #13345 )
2020-11-10 16:11:43 -08:00
Charles Gagnon
d4e8053797
Increase yarn timeout when installing packages ( #13347 )
...
* Increase yarn timeout when installing packages
* Update other platforms
2020-11-10 16:05:50 -08:00
Aditya Bist
8bbcfff119
fix agent types ( #13340 )
2020-11-10 13:38:57 -08:00
Arvind Ranasaria
d7a6b55f82
Hook up generateScriptButton to lastPageValidation ( #13339 )
2020-11-10 13:16:25 -08:00
Kim Santiago
3dd74971d8
Adding @kisantia as a codeowner for dacpac and schema compare extensions ( #13336 )
...
* adding @kisantia as a codeowner for dacpac and schema compare extensions
* fix paths for other extensions
* add owners for sql database projects
2020-11-10 13:15:28 -08:00
Alan Ren
e076062d4f
restore focus on escape ( #13285 )
...
* restore focus on escape
* obtain focus on action click
* comment
* comment 2
* simplify the implementation
* remove the toggle action completely
* remove the import
* implement aria requirements
2020-11-10 11:31:53 -08:00
Srivatsan Vasudevan
fbe8e9d9f3
Schema Compare object type labels missing space ( #13315 )
...
* Added spaces to the database trigger, symmetric key and stored procedure labels in Schema Compare object types.
2020-11-10 10:32:19 -08:00
Aasim Khan
1c9322c0e8
Fixes for incorrect button labels and the password validation error. ( #13333 )
2020-11-10 09:05:28 -08:00
Charles Gagnon
0d49744061
Upload user dir from test runs ( #13326 )
...
* Add archive logs step to linux build
* right file
* try
* try this
* correct order
* build artifact
* export
* log
* use tmp
* zip up all
* Remove extra publish
* other scripts
* add test name to dir
2020-11-10 08:57:57 -08:00