Commit Graph

4069 Commits

Author SHA1 Message Date
v-bbrady
eabacae0c0 fixes show all extensions button #10445 #10625 (#11104)
* fixes button alignment and missing icons issues with ads welcome page

* removes dead code, registers new Button

* creates one button component and adds proper attributes depending on platform

* Add CodeQL Analysis workflow (#10195)

* Add CodeQL Analysis workflow

* Fix path

* adds return types to functions

* fixes show all extensions command

* formats css

* fixes layering issue

* updates querySelectors to be more specific

Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
2020-07-06 14:01:08 -07:00
Amir Omidi
84a7d1916a Fixes the azure account pane location (#11211) 2020-07-06 13:32:23 -07:00
Kim Santiago
b238819c89 Standardize slashes in sqlproj (#11174)
* standardize slashes that go in sqlproj

* update tests to not have os specific baselines

* fix test

* fix delete tests

* some cleanup
2020-07-06 13:17:55 -07:00
Amir Omidi
b0cab3125e Revert "Prints out the actual error that happened" (#11212)
* Revert "Prints out the actual error that happened (#11208)"

This reverts commit 6eb88924f6.

* Fix the JSON.stringify
2020-07-06 12:23:46 -07:00
Amir Omidi
0043a7f93b Change branding of linux version (#11133) 2020-07-06 12:04:11 -07:00
Amir Omidi
6eb88924f6 Prints out the actual error that happened (#11208) 2020-07-06 11:58:14 -07:00
Kim Santiago
ac71c6f06d Add "Open Containing Folder" to project context menu (#11187)
* add command to open the folder the project is in

* move commands to constants
2020-07-06 11:42:25 -07:00
Amir Omidi
2d989e1180 Move the tests out to their own tasks (#11179)
* Move the tests out to their own tasks

* Revert change

* Lets try this

* Actually reference to the tests

* Lets try this

* lets try this too?

* this one?

* Manually define them :(

* Formatting

* Add the node command

* Fix machine learning and address comments
2020-07-02 17:51:21 -07:00
Hale Rankin
ecfac10949 Notebook UI - Markdown toolbar - Headings dropdown (#11049)
* Adds heading dropdown to markdown toolbar.

* Added a method specific to headings that places markdown at beginning of line selected.

* Rewrote comment for my new method.

* Revised code to support multi select for headers, similar to how unordered list is applied. Multi-line headings can be undone if the multi lines are selected.

* Modified transformText to make single-line undo operation possible with just the cursor position.

* Added utility methods to help determine if the selection is a line-only or multi-line.

* Building isReplaceOperation to determine when preceeding characters need to be replaced with a new MarkdownButtonType.

* Updated comments.

* Applied changes written by Chris.

* Reverted changes to earlier stage where heading addition works just like list item additions.

* getExtendedSelectedText now returns an actual value in range for MarkdownLineType.EVERY_LINE.

* Added conditional so that Preview element is updated only when Preview is enabled.

* Updated tests for heading toolbar: heading 1, 2 and 3.

* Removed code that could not be reached.

* Corrected tests for headings.

* wip

(cherry picked from commit 43deb9635cc0eeebaffef22d4373f1f6ad713ace)

* cleanup

* fix error

* Fix tests

* Add more testing

* delete

* re-add

Co-authored-by: chgagnon <chgagnon@microsoft.com>
2020-07-02 17:30:29 -07:00
Jorge Berumen
a06a06bb58 Add Azure DevOps as a resource for authentication (#11146)
* Adding ado as auth resource
* Removing Gov ADO resource
* Correctly handling azureDevOpsResource not being present for usgov
2020-07-02 17:22:31 -07:00
Kim Santiago
3306f386f0 Cleanup publish database dialog and test sqllint errors (#11178)
* cleanup publish database dialog and test

* fix more tests

* fix other tests

* add back skips

* use Promise.resolve()
2020-07-02 17:02:52 -07:00
Kartik Arora
29509ccfbb Onboarding pull request (#11176)
* initial check in for kartik
2020-07-02 11:59:23 -07:00
Sakshi Sharma
fd29e35199 Schema compare test coverage (#11080)
* Schema compare tests for updateSourceAndTarget method

* Merge conflict resolution

* Move resetbutton call before adding them to toolbar

* PR comments- added a buttons interface for readability and created a test class to add test functionality to the orginal class

* Moved interface ButtonState to test code
2020-07-01 18:35:54 -07:00
Karl Burtram
a4539daa62 Move account management icon to action bar (#11173) 2020-07-01 15:55:12 -07:00
Maddy
d51bba8fe9 check for jupyter-book versions and install 6.4 (#11167)
* check for jupyter-book versions and install 6.4

* added a note before installation
2020-07-01 15:27:45 -07:00
Charles Gagnon
bd801ad8da Fix errors throw when doing validity checks (#11171) 2020-07-01 14:37:28 -07:00
Sakshi Sharma
d6768ba12e Add missing await (#11151)
* Add missing await

* Removed async from method publishProject
2020-07-01 13:28:32 -07:00
AzureDataStudio
4c27001de5 Merge remote-tracking branch 'origin/ads-main-vscode-2020-07-01T03-37-25' into main 2020-06-30 22:30:53 -07:00
ADS Merger
f6b44865cc Merge from vscode b16b467d3e03e1a1ae05b5836e4e5a5af504e86d 2020-07-01 03:37:27 +00:00
Kim Santiago
1e805a4156 Change deploy to publish in sql project codebase (#11144)
* change deploy to publish

* rename to IPublishSettings

* change a few more profiles to settings
2020-06-30 19:23:03 -07:00
Chris LaFreniere
2b5ae5e3a8 Update singular vcore string (#11157) 2020-06-30 17:10:46 -07:00
Charles Gagnon
a1f600657a Add more arc tests (#11145)
* Add more arc tests

* Update comment
2020-06-30 14:05:27 -07:00
Kim Santiago
41315c6e0a Show error when trying to add file/folder that already exists to project (#11122)
* show error when trying to create file or folder that already exists

* add test for file that already exists

* add folder tests

* fix error messages

* hide Properties folder

* update comment
2020-06-30 13:42:50 -07:00
Vladimir Chernov
b875d919d2 spell error in Severity column name (#11156) 2020-06-30 23:33:52 +03:00
AzureDataStudio
59b69311d7 fix hygiene, update sqlite
skip failing tests
2020-06-30 11:31:12 -07:00
ADS Merger
1388493cc1 Merge from vscode 2cd495805cf99b31b6926f08ff4348124b2cf73d 2020-06-30 11:31:11 -07:00
Chris LaFreniere
a8a7559229 Add more notebook extension tests (#11143)
* more tests

* More tests

* More tests

* Add prompt tests
2020-06-30 11:01:51 -07:00
Chris LaFreniere
a32f42d475 Update Arc Extension with New Strings and azdata Version (#11148)
* Strings and azdata version changes

* change azdata description
2020-06-30 09:08:01 -07:00
Anthony Dresser
ef8205f918 Remove deleting the old config (unsupported) and add notification (#11142)
* Add CodeQL Analysis workflow (#10195)

* Add CodeQL Analysis workflow

* Fix path

* remove deleting the old config (unsupported) and add notification

* fix tests

Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
2020-06-29 21:40:03 -07:00
Charles Gagnon
749c42ce41 Improve handling of connection errors for arc controllers (#11139)
* some fixes for failed connections

* cleanup

* add back in prompt
2020-06-29 19:50:27 -07:00
Anthony Dresser
93a88e38fe Messages panel wordwrap (#10970)
* Add CodeQL Analysis workflow (#10195)

* Add CodeQL Analysis workflow

* Fix path

* fix word wrap support in the message panel

* fix width on message treee

* fix import

* fix settings editor to reflect the changes in the settings ids

* fix tests

* add configuration upgrader

* make sure to maintian execution order

* make the compiler happy

* add tests for upgrader

Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
2020-06-29 16:25:11 -07:00
Kim Santiago
6b8eafbf2e Update import project to have friendly names for the extract file organization options (#11123)
* udpate import to have friendly names for the extract file organization options

* update tests

* update message

* remove camelcase stuff

* use localized constants instead of enum
2020-06-29 15:37:28 -07:00
Anthony Dresser
5d3178f649 delete duplicate workflow (#11132) 2020-06-29 13:53:26 -07:00
Alan Ren
476e3f7299 move the macOS ESRP signing steps to a separate job (#11129)
* move ESRP signing to a separate job

* rename job

* depends on

* signing

* rename task
2020-06-29 13:41:02 -07:00
Brian Bergeron
1f558dd2aa Arc - Fix sqlmiaa initial load (#11125) 2020-06-29 13:34:46 -07:00
Charles Gagnon
064ada1d2f Change Azure region dropdown to use azurecore API (#11131)
* Change Azure region dropdown to use azurecore API for getting display name

* Fix compile errors

* Adding a few things to the vscodeignore

* and another
2020-06-29 12:44:04 -07:00
v-bbrady
e540096e07 Bbrady/fixes tour start button (#11092)
* builds getting started tour

* reorganizes ts according to amirs comments

* Fix hygiene issues

* updates class names

* adds description to new configuration value

* uses core components

* PR fixes based on Charles comments

* formats css

* updates guided tour based on charles comments

* updates css formatting

* fixes read more link

* formats gettingStartedTour.ts

* updates copy

* Add CodeQL Analysis workflow (#10195)

* Add CodeQL Analysis workflow

* Fix path

* updates pr based on pr comments

* removes unused decleration

* formatting

* reformats css document

* updates file path

* updates images

* fixes start button issue

* merges master

Co-authored-by: Amir Omidi <amomidi@microsoft.com>
Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
2020-06-29 09:55:19 -07:00
Chris LaFreniere
061d3510b9 Run ADS Commands from Notebooks (#11069)
* Run commands

* cleanup

* Plumbed through error and message output

* undo unnecessary changes

* Remove change to fix tests

* pr feedback
2020-06-28 21:17:50 -07:00
Aasim Khan
a9848a7a96 Added check all nulls to modify column Page (#10683) (#10751)
* -Added check all null checkbox

* Modified declarative table to add check all columns  in the column header

* -changed to using existing methods for firing events.

* -changed table height to auto
-center aligned data in table cell
-Check all generates event for only changed values

* -changes column header from text to column header (#10787)

* This fixes the weird angular stuff - we need to do this in every other component

* -added changes made by amir for dom object tracking
-added automatic checkall detection.
-made text-align center in table cells

* -fixed styling issues and issue with checkboxes

* -Removed unsued function

Co-authored-by: Amir Omidi <amomidi@microsoft.com>
2020-06-26 19:02:59 -07:00
Chris LaFreniere
9dc7ca056f Change nb before/after strings (#11121) 2020-06-26 17:36:28 -07:00
Alan Ren
e452cd20d4 format file and add metadata (#11108) 2020-06-26 14:57:06 -07:00
Benjin Dubishar
a3030aaf0d Update package.json (#11113) 2020-06-26 14:56:42 -07:00
Maddy
6870bdaf72 revert back to original code (#11116)
* revert back to original code

* skip failing tests
2020-06-26 14:17:42 -07:00
Hale Rankin
7ef8acf04e Markdown toolbar > Preview toggle feature (#10963)
* Added toggle preview button to Markdown toolbar. Revised components, theme and styles to present the preview as a second column beside the markdown.

* Added showPreview to model and began working on togglePreview.

* Uncommented use of cellModel.showPreview

* add cell model event for onPreviewChange

* Renamed my showPreview boolean to prevent confusion with local boolean used in toogglePreview.

* Added CSS class when preview is enabled. Adjusted styles accordingly.

* Swapped icon show/hide references for correct sequence. Modified updatePreview to include state of doShowPreview.

* Added check for isEditMode so we can run togglePreview and show it once editor closes.

* Added listener to code.component that triggers layoutEmitter on changes to peview.

* Renamed local boolean doShowPreview. Removed unneeded code. Fixed ambiguity in my use of booleans, adding a getter and setter to textCell.

* Cleaned up implementation of new get/set for toggling preview.

Co-authored-by: chlafreniere <hichise@gmail.com>
2020-06-26 13:47:17 -07:00
Hale Rankin
00fe535add 10887 - Fixes icon position beside Cell and Run all in notebook toolbar. (#10897) 2020-06-26 13:46:52 -07:00
Hale Rankin
8f6c5af94f Cleaned up code for Add cell button in both main toolbar and cell toolbar. Corrected toolip to read: Add cell. (#10829) 2020-06-26 13:46:31 -07:00
Hale Rankin
8d7b3ef6ec Cell toolbar More Actions menu -- remove duplicate separators (#10827)
* Added code to remove multiple separators from more actions menu.

* Moved check for separators after list is deduped.

* Logic cleanup

* Added unit test for cell toolbar ellipses menu.

* Fix tests

Co-authored-by: chgagnon <chgagnon@microsoft.com>
2020-06-26 13:45:53 -07:00
Alan Ren
dbf9d3426c icon for ASDE (#11111) 2020-06-26 11:54:29 -07:00
Brian Bergeron
6c86122aae Arc - Fix KeyValueContainer refresh and disposal (#11090) 2020-06-26 09:48:35 -07:00
Aasim Khan
fb52760be1 Additional tests for import extension (#10953)
* Setting up tests on import extension

* -Added API wrappers for all the azdata and vscode APIs to make them easily mockable
-Added some unit tests for the import extension
-Some code logic separations

* -added code report for the import extension in ci

* changes code coverage to 36%

* adding some comments

* Removing unnecessary exports

* -refactored test code to replicate src structure
-some changes mentioned in the pr

* removed unnecessary prefixes from test case name
2020-06-25 19:22:25 -07:00