* Extension unit tests continue on error
* Fix script syntax issue.
* Block syntax issue
* Remove condition expression
* Brings back condition for sql product build linux yml
* Comment out condition in ci.yml
* Adds continue on error clause to ci.yml extension unit tests
* Adds condition to extension unit tests step in ci.yml
* Adds run extension unit test case for fail on error
* Adds fail on error case to Run Extension Unit Tests script
* Explicitly states continue on error false.
* Format adjustment to yml file
* Changes default state to fail on error
* Update .github/workflows/ci.yml
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Update build/azure-pipelines/linux/sql-product-build-linux.yml
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Update build/azure-pipelines/linux/sql-product-build-linux.yml
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Brings back original comment.
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Adds context menu option placeholder plan container
* Adds context menu and button to add execution plan to placeholder
* Minor clean up
* Replaces taskbar with button to add execution plans
* Removes unneeded CSS styling.
* Adjusts button type to secondary
* Boilerplate for new context menu options
* Enables checkmarks for expensive operator context menu actions
* Updates azdataGraph version to 0.0.44
* Adds clearing logic to actions and retrieves additional info from nodes
* Removes unnecessary actions that aren't supported by other providers
* Finishes setting up the rest of the context menu actions
* Corrects context menu action label
* Defines new widget type for finding expensive operations
* Adds TODO for class icon name
* Creates action to open the expensive operation widget
* Adds escape and enter key shortcuts to findExpensiveOperation widget
* Styles find expensive operation widget
* Corrects class name for finding expensive operator action
* Corrects import statement.
* Code clean up
* Bumps azdataGraph version to 0.0.45
* Adds an info box for when a metric doesn't find any nodes
* Adds label to find expensive operator widget
* Invokes dispose when widget controller removes widget
* Implements disposable in all execution plan widgets.
* Adds off action to clear highlighting
* Adds a default setting and default prompt for highlighting metric
* Fixes not all code paths return error
* Removes shortcut key from text for widget actions
* Adds enum description
* Removes added dictionary type, and renames class name
* Removes unnecessary null checks
* Removes cost metric dictionary and adds corresponding properties
* Code review changes
* Removes incorrectly implemented key down event for widget.
* Renames widget and action class names for highlighting expensive ops
* File rename
* Cleans up labels to better reflect highlight action
* Removes hardcoded button width style and sets it to auto
* More clean up
* Clean up import statement
* Code review changes
* Drop down list only shows available metrics
* Updates highlight expensive operation icon
* Update STS version
* Fixes incorrect label when plans are vertical
* Code review changes.
* Adds helper methods to get localized strings
* Helper functions moved to module level
* Renames fields from top and bottom to primary and secondary
* Adds find node button to comparison plans.
* Can search multiple nodes (improve widget UI and initialization)
* Adjusts how second plan is added to the node search widget
* Adds styling to the find node action bar
* Removes unused code
* Minor clean up
* Cleans up CSS redundancy
* Adjusts property names according to access specifiers
* Corrects find node behavior to match SSMS
* Dependency injects instantiation service
* Adds additional property to telemetry event.
* Adds undefined to getter return signatures for plans
* Adds checks around active execution plan properties
* Code review change
* Code review changes
* Update azdataGraph version to 0.0.31
* Adds icons
* Bumps azdataGraph version to 0.0.32
* Removes whitespace
* Uses icon that better adapts to color theme changes.
* Disables collapse for execution plans in plan comparison editor view
* Updates properties view title when the orientation changes
* Property orientation labels change when the plan orientation changes.
* Renames top and bottom containers to secondary and primary
* Minor clean up
* Removes unnecessary class members
* Promotes constants to module level
* Moves function to module level
* Renames value1 and value2 to primary and secondary
* Replaces orientation string literal type with enum
* Resolves undefined orientation bug
* Removes unused orientation getter
* Updates property table columns only
* Uses orientation enum in editor view and properties view
* Clean up
* Ctrl/Cmd + m, no longer executes queries.
* Adjusts command label
* Code review changes
* Uses category parameter to categorize actual plan command
* Actual execution plan command label matches estimated plan command label
* Revert "Actual execution plan command label matches estimated plan command label"
This reverts commit 15f301dfc64341d631ca5e9b1314d8cf739b2088.
* Centralizes localized category string (#19857)
* Actual Plan action uses centralized category
* Commenting out for now, but will delete in next commit
* Adds SQL carbon edit markers
* Uses multiline comments
* Formats file
* Code review changes
* Edit comment moved to same line
* Add ts-ignore directive to unused method
* Creates toggle button to switch between estimate and actual query plans
* Renames ID for the toggleActualExecutionPlanModeAction class
* Renames button back to explain
* Creating actual execution plans resembles SSMS
* Adds CTRL/CMD + L shortcut to display estimated execution plans
* Alphabetically organizes telemetry actions
* Adds telemetry when the setting for actual execution plan toggle is used
* Resolves build errors
* Fixes broken unit tests.
* Code review changes
* Removes unnecessary null-coalescing operator.
* Creates placeholder icons for actual execution plans enabled
* Code review changes
* Shortens label names
* Telemetry moved to toggle button
* Telemetry review changes
* Clarifies misleading label
* Adds telemetry when plan comparison is invoked
* Small formatting change.
* Adds telemetry to add execution plan button
* Removes unused ExecutionPlanComparisonEditorView constructor parameters
* Small formatting adjustment
* Adds telemetry to ExecutionPlanComparisonEditorView properties
* Code review changes
* Adds hot key combination for finding nodes in execution plans.
* Captures cmd + f key combinations for other platforms
* Stops event propagation when targeted hot key sequence is pressed
* Resolves cannot read property 'accessToken' of undefined.
* Checks for and specifies undefined as refreshToken return type
* Adds documentation and checks for undefined results from refreshToken
* Adds telemetry around how the properties window is opened
* Adds telemetry around accessing execution plan top operations
* Adds key for viewing top operations
* Adds telemetry around using the open query button and context menu item
* Adds telemetry around execution plan zoom in, out, to fit, and custom
* Adds telemetry around searching for nodes in execution plans
* Reduces telemetry additional properties to 1.
* Code review changes
* Removes unnecessary export
* Checks for successful directory creation
* Revert "Checks for successful directory creation"
This reverts commit 372409ef323f0d82e11992bc7bc33d607a7d5581.
* Checks for the existence of the logs directory before accessing.
* Adds SQL carbon edit comment
* Removing call to copy from non-existing directory.
* Removes unneeded import
* Checks for file existence before copying.
* Provides explanation for modification
* Replaces file existence check with exception handling.
* Adds loggings to ADS pipeline
* Skips notebook smoke tests for ADS web.
* Skips failing create book dialog tests in web build
* Ignores import tests ADS web
* Groups related tests together for ADS Web and non-web
* Updates distro commit hash
* Corrects keyboard shortcuts for linux
* Changed python to match the one listed in docker/Dockerfile
* Revert "Changed python to match the one listed in docker/Dockerfile"
This reverts commit 683c226eb600bc89b449f258d463d2a6b14aebe6.
* Adjusts retry count for dialog elements to close.
* Code clean up
* Revert "Adjusts retry count for dialog elements to close."
This reverts commit 64a8bf48fa72eb26830aeaa55721c7ff846d131e.
* Code cleanup
* Adjusts key binding
* Stops flagging untitled editors with pre-loaded content as dirty
* Code changes address broken unit tests.
* Completes original comment
* Defines new non dirty text editor model
* Revert "Completes original comment"
This reverts commit 6d0e90bb9f0650eead5a0ec1ca8524dfe96c56cd.
* Revert "Code changes address broken unit tests."
This reverts commit 5b8cdd9f0bb43638bdd427a454ea177f6fbc024d.
* Revert "Stops flagging untitled editors with pre-loaded content as dirty"
This reverts commit 7a39226b7961af3aba8dc2f08113ed09eb2a1d61.
* Stops marking untitled editors with JSON as dirty
* Code clean up.
* Adjusts timeout period
* Revert "Adjusts timeout period"
This reverts commit 0f372eae2a4611554093b6c09f1ff6c451132e19.
* Adds firefox as browser option
* Corrects yaml smoke test script
* Resets args array to original values
* Corrects build path
* Resolves ignoring browser option error
* continue even after writing to stderr
* Adjusts smoke test (browser) script
* More adjustments to smoke test script
* Corrects server path
* Uses build variable directly in build path
* Specifies browser type since cannot be ignored error
* Adds browser option
* Updates web build image and corrects smoke test exe command
* Removes commented out task
* Updates dockerfile to support web smoketests
* Removes failOnStderr flag
* Use curl instead of wget in Dockerfile
* Adds smoketests for ADS web.
* Refines element selector for editor suggestion list
* Revert "Refines element selector for editor suggestion list"
This reverts commit 61b34cd07ab9fa16546d7aab5bce24c73559c6b0.
* Skip tests that timeout for not finding targeted DOM element
* Missed undoing a modification
* Reinstates skipped tests
* Removes unnecssary TODO
* Disables smoke tests for darwin
* Fixed indenting to resolve azure DevOps yaml error
* Updates server path based on setup doc
* Moves smoketests after extensions are built
* Corrects indentation
* Fixes indentation with bottom half of smoketests script
* Updates sqlite URL to latest release
* Yields correct ADS sqlite release version for web and non web
* removes accidental whitespace from previous commit
* Code review changes
* Additional review change
* update distro
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Enable Azure Data Studio's database selector to behave like the one in SSMS
* Revert "Enable Azure Data Studio's database selector to behave like the one in SSMS"
This reverts commit d146eef998a3192f76df80794a31a45c8be7f786.
* Database selector auto commits selection
* Adds comment explaining change
* Auto commits selected database on blur
* Confirms db name changed before committing db selection
* Moves changed db check to selected database method
* Makes use of dbName instead of having to get value from dropdown
* Code review change
* Fix query database drop-down rendering location after resize
* Revert "Fix query database drop-down rendering location after resize"
This reverts commit 62481a93e696d4fa79ce40ecef3a2567a65dd20c.
* Fixes drop down list rendering issues by closing the list on window
resize
* comment providing the explanation for new listener and checks if list is visible before hiding
Lewis Sanchez