Commit Graph

3765 Commits

Author SHA1 Message Date
Christopher Suh
f5bed289af Expand account picker support to multiple providers (#23952)
* fix dropdown behavior

* expand account picker support to multiple providers

* fix tests

* fixed unresolved promise issue
2023-07-21 08:43:18 -07:00
Cheena Malhotra
8c895cb71d Fix context menu in treeViews (#23948) 2023-07-20 13:50:44 -07:00
Christopher Suh
91359a32c9 Remove ADAL Code (#23360)
* initial commit, removed all adal code

* remove all authLibrary references in extension/azurecore

* removed authLibrary references from src/sql

* remove MSAL/ADAL setting option

* wip fixing tests and removing Msal from method names

* fixed tests

* create accountInfo mock

* fix tests

* fix clientApplication mock

* remove clientapplication

* fix compile

* add typing

* wip

* wip

* wip

* fix tree provider

* remove SimpleTokenCache, FileDatabase & tests

* remove remaining adal / authentication library references:

* remove comma from package.nls.json

* fix error fetching subscriptions

* fix tests

* remove getAzureAuthenticationLibraryConfig

* remove adal check

* fix build

* remove test

* undo remove customProviderSettings

* fix bracket
2023-07-20 10:37:38 -07:00
Christopher Suh
a2b1c2cfc5 pass provider ID info to runAddAccountAction (#23938) 2023-07-20 10:16:28 -07:00
Karl Burtram
1addfae2e8 Remove some TODOs mostly for styling (#23934)
* Remove some TODOs mostly for styling

* Remove unused
2023-07-19 17:56:49 -07:00
Aasim Khan
760ccfdef3 Removing unnecessary tree expansions causing errors to popup again (#23932) 2023-07-19 15:42:56 -07:00
Aasim Khan
38312de87b Fixing issue that caused moving connections from one group to other to throw (#23933) 2023-07-19 15:33:26 -07:00
Cheena Malhotra
a833ae7b79 Allow empty username + fix profiles on read (#23924) 2023-07-18 16:03:10 -07:00
Alex Ma
a0a685bbcf Remove/comment out connection title generation from all areas. (#23873) 2023-07-18 10:47:50 -07:00
Kim Santiago
eeab2b4abe Fix horizontal split view not working (#23889)
* Horizontal splitview sorta working

* remove the old element

* support getting size from model view container

* cleanup

* make splitViewHeight optional

* Update src/sql/azdata.proposed.d.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* fix test

---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2023-07-17 12:31:04 -10:00
Charles Gagnon
a81181108d More file moves for layering fixes (#23893) 2023-07-15 14:26:15 -07:00
Charles Gagnon
4cc916314b Move some test files (#23892) 2023-07-15 11:10:43 -07:00
Cheena Malhotra
62f123af67 Fix serverInfo undefined due to wrong connection URI set on connection. (#23884) 2023-07-14 18:33:24 -07:00
Charles Gagnon
6c37ba6c21 Better fix for file browser race condition (#23879) 2023-07-14 12:34:48 -07:00
Sakshi Sharma
7bc05e507d Add limit on the file size that can be opened with Open XEL feature (#23841)
* Add limit on the file size that can be opened with Open XEL feature

* Add limit on the file size that can be opened and post a notification for large files

* Update wording

* Use FileService interface instead of fs to fix layering rules
2023-07-13 20:32:55 -07:00
Lucy Zhang
9c43a373f8 fix dropdown alignment (#23870) 2023-07-13 17:56:45 -07:00
Charles Gagnon
4ba2c6c5af Fix file browser opening race condition (#23867) 2023-07-13 15:35:07 -07:00
Aasim Khan
99bf9f20e6 Setting right options of command based new connections (#23849) 2023-07-12 23:58:45 -07:00
Maddy
4d6b657e5d update ITreeElement with ICompressedTreeElement (#23839) 2023-07-12 23:34:52 -07:00
Aasim Khan
5452c7f3ab Fixing chartjs (#23831) 2023-07-12 22:52:23 -07:00
Charles Gagnon
d294c81588 Fix dialog buttons (#23843)
* Fix dialog buttons

* comments

* Remove debug
2023-07-12 20:53:59 -07:00
Aasim Khan
953ea05802 Fixing unsupported providers behavior on Async Server Tree (#23758)
* Throwing error so that connection loading fails.

* Fixing stuff

* Fixing tests
2023-07-11 22:59:00 -07:00
Aasim Khan
8fa62fe519 Adding null checks in disconnecting connections from async tree (#23636)
* Adding null checks in disconnecting connections

* Fixing stuff

* Update src/sql/workbench/contrib/objectExplorer/browser/serverTreeView.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2023-07-11 17:00:18 -07:00
Cheena Malhotra
ba483815b2 Fix connection URI default value comparisons (#23705) 2023-07-11 10:44:59 -07:00
Christopher Suh
95599ae39b fix dropdown behavior (#23708) 2023-07-10 14:59:21 -07:00
Sakshi Sharma
2fd2b79611 ADS changes for opening XEL files (#23666)
* Initial set of changes for opening XEL files in ADS

* Code cleanup and update STS version

* Fix runtime errors

* Address comments

* Address comments and update Start button to be disabled for file session

* Code cleanup
2023-07-09 10:22:12 -07:00
Cheena Malhotra
3f19d0026e Change dialog style for Device code flow dialog (#23417) 2023-07-07 22:28:50 -07:00
Chris LaFreniere
1fca6876e6 Don't set buttonoption for link/image md nb (#23694) 2023-07-07 13:14:10 -07:00
Alan Ren
1bc22d896b fix button text issue in welcome page (#23679)
* fix button color

* remove imports
2023-07-06 16:14:28 -07:00
Charles Gagnon
0dda36cd6e Add back eslint and tsec to basic checks (#23637)
* Add back eslint and tsec to basic checks

* ext

* enable tsec

* Add comments

* Add check-clean-git-state

* Make executable

* update build & distro

* Update size

* distro
2023-07-05 17:15:27 -07:00
Aasim Khan
28e59f44e2 Adding execution plan component to model view. (#23620) 2023-07-05 13:33:28 -07:00
Charles Gagnon
cf8b8d1891 Fix bad layering (#23635) 2023-07-05 09:50:21 -07:00
Aasim Khan
0484cd086c Remove server group colors from connection profile in OE (#23622)
* Remove server group

* remove css
2023-07-04 10:55:19 -07:00
Lewis Sanchez
d495ebebe3 Remove extra filter icon from top ops tab (#23629) 2023-07-03 18:02:47 -07:00
Charles Gagnon
e7762b7c5a Fix some test layering issues (#23627) 2023-07-03 16:11:07 -07:00
Charles Gagnon
9c2307cdd9 More layering fixes (#23625) 2023-07-03 15:17:29 -07:00
Charles Gagnon
5dd09343ac Move some files for correct code layering (#23624) 2023-07-03 14:25:04 -07:00
Alan Ren
5e1db4eb97 fix the selected cell style (#23617) 2023-06-30 17:48:04 -07:00
Cheena Malhotra
35597c921a Bring parity with vs treeview for all non tracked code. (#23598) 2023-06-30 15:19:22 -07:00
Alan Ren
299bd7ddbc add action name to label (#23595) 2023-06-30 15:11:03 -07:00
Cheena Malhotra
dda9c2b9f0 Fix console error for new connection dialog (#23612) 2023-06-30 14:15:20 -07:00
Cheena Malhotra
bc515e8f45 Fix continuous loop on Cancel (#23609) 2023-06-30 14:15:09 -07:00
Cheena Malhotra
a6bd752082 Revert "Fix for database name in connection details after changing database (#22376)" (#23610) 2023-06-30 13:12:59 -07:00
Cheena Malhotra
fa335d32be Fix Azure tree view (#23584) 2023-06-29 20:48:04 -07:00
Alan Ren
116270f2f6 change the text to more generic (#23582) 2023-06-29 20:24:52 -07:00
Alan Ren
f9be3a9ac8 fix slickgrid keyboard event handler (#23575)
* fix slickgrid keyboard events

* add back some code
2023-06-29 17:11:51 -07:00
Charles Gagnon
cf607e98a1 Fix missing telemetry opt out toast (#23570)
* Fix telemetry opt out toast

* fix imports

* cleanup
2023-06-29 15:10:21 -07:00
Cheena Malhotra
a5394a0bca Fix dashboard color theme overrides (#23533) 2023-06-29 12:03:58 -07:00
Cheena Malhotra
8d0ba0fe12 Fix Get current connection string command (#23543) 2023-06-29 00:24:14 -07:00
Aasim Khan
dcef1d98a0 Fixing setting layout in OE (#23536) 2023-06-29 00:09:05 -07:00