ckaczor/azuredatastudio
Archived
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
3,190 Commits 1 Branch 152 Tags
fe9ffddd3b75dcdd0caa60e931120862ad771b07
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Charles Gagnon fe9ffddd3b Fix loading and clickable div screen reader issues (#9088) 
* Fix loading and clickable div screen reader issues

* Change back to default clickable to false
 2020-02-07 13:27:29 -08:00
Charles Gagnon 39ac8498dc Fix feature request links (#9089) 
* Fix feature request links

* fwlink for send a smile link too
 2020-02-07 13:03:49 -08:00
Charles Gagnon 86ad477c77 Add enabled property and make default account option empty (#9036) 
* Add enabled property and make default account option empty

* Rmove unused loc string

* Add descriptive comment and support required azure dropdowns.
 2020-02-04 08:06:14 -08:00
Charles Gagnon 62df5359e2 Even more robust handling of extension tree loading (#9007) 
* Even more robust handling of extension tree loading

* Fix initial loading and add new test for CMS

* Fix compile errors

* Fix logic

* Remove debug log statements
 2020-02-04 08:03:34 -08:00
Charles Gagnon 5a2bbc0375 Add location to azure-account deploy field (#9019) 2020-02-03 18:25:54 -08:00
Charles Gagnon 402d693885 Fix action id for OpenFileInFolderAction (#9005) 
* Fix action id for OpenFileInFolderAction

* Undo unrelated change
 2020-01-31 13:15:23 -08:00
Charles Gagnon 261e6fa89e Fix error when using azure-account deployment field (#8992) 
* Fix error when using azure-account deployment field

* Make param optional

* Remove extra comment
 2020-01-30 16:51:10 -08:00
Charles Gagnon 637a33c7a7 Support for removing hardcoded deployment options (#8986) 
* Support for removing hardcode deployment options

* Add missing file

* Generalize errors and make name and id required. Sort dropdowns.

* Fix test

* Capitalize text
 2020-01-30 10:35:37 -08:00
Charles Gagnon ddfdd43fc3 Bump extension versions (#8990) 2020-01-29 17:20:11 -08:00
Charles Gagnon 5618799305 Refactor node loading logic for tree controllers (#8980) 
* Refactor node loading logic for tree controllers

* Add comment
 2020-01-28 17:12:15 -08:00
Charles Gagnon 461dd79bc2 Only log if an actual error occurred (#8979) 2020-01-28 13:05:31 -08:00
Charles Gagnon 2dfd75352f Add coverage for extension tests (#8961) 
* wip

* Add code coverage files to all extensions

* Update vscodetestcover

* Update yarn.lock

* Update CMS yarn.lock

* Update vscodetestcover version
 2020-01-28 07:23:45 -08:00
Charles Gagnon 379eae22ed Switch schema-compare to using ads common events (#8957) 
* Switch schema-compare to using ads common events

* Update yarn.lock
 2020-01-24 15:30:31 -08:00
Charles Gagnon 8b9aeb8679 Fix some dtslint errors in azdata.d.ts (#8931) 
* Fix some dtslint errors in azdata.d.ts

* Undo return type change
 2020-01-22 13:04:52 -08:00
Charles Gagnon 308dfee963 Bump SMO to fix script external table issue (#8922) 2020-01-21 17:23:55 -08:00
Charles Gagnon d517cf0c8c Fix new editor windows to open with global connection (#8901) 
* Fix new editor windows to open with global connection

* Fix test

* Fix tests

* Move logic to queryInputFactory

* Remove unused function

* Remove unneeded check

* Add tests
 2020-01-17 07:44:28 -08:00
Charles Gagnon 9acd757f6a Bump vscode version to latest from merge (#8894) 2020-01-16 08:29:52 -08:00
Charles Gagnon 7ecb6b4427 Change test timeout for extension unit tests to 10sec (#8848) 2020-01-08 13:49:34 -08:00
Charles Gagnon c79929fdd2 Fix small icon in dev build (#8672) 
* Fix small icon in dev build

* Use distro instead (icons are temp)

* New insiders icons

* Fix merge conflicts

* Add back in types
 2020-01-08 13:45:18 -08:00
Charles Gagnon 041f34beda Fix book provider load to not throw on startup (#8835) 
* Fix book provider load to not throw on startup

* Move tests to stable

* Rename method

* Fix floating promises and broken test
 2020-01-07 17:32:51 -08:00
Charles Gagnon fa2fcf2e40 Log original kerberos errors to console (#8804) 
* Log original kerberos errors to console for debugging purposes

* Fix compile error
 2020-01-03 15:30:42 -08:00
Charles Gagnon d647dbde09 Make dropdown update width immediately upon opening (#8716) 
* Make dropdown update width immediately upon opening

* remove type

* min size of the input container width

* use clamp
 2020-01-03 11:07:24 -08:00
Charles Gagnon a42407b81a Fix missing action buttons with single view (#8694) 2019-12-16 10:33:21 -08:00
Charles Gagnon a622e4ac40 Fix options dropdown arrow alignment in options dialog (#8695) 2019-12-16 09:58:57 -08:00
Charles Gagnon 01b9754c80 Fix alignment of select dropdown in modal dialogs (#8683) 2019-12-13 16:23:25 -08:00
Charles Gagnon b650168704 Add de viewlet tests back (#8673) 2019-12-13 14:08:01 -08:00
Charles Gagnon 9587edd867 Bump extension versions (#8674) 
* Bump agent version

* Bump more extensions

* Undo version change for BDC - is builtin
 2019-12-13 11:11:56 -08:00
Charles Gagnon 5bf85a2855 Add tests for refresh scripting action (#8648) 
* Add tests for refresh action

* Revert changes to make tree public

* Move tests into subsuite
 2019-12-12 16:04:28 -08:00
Charles Gagnon 856fec4243 Remove preview tags (#8653) 2019-12-12 11:24:05 -08:00
Charles Gagnon 7e970d04ca Fix tree refresh (#8625) 
* first part

* remove another refresh collapse expand

* Fix scriptable nodes

* Fix test
 2019-12-11 16:34:03 -08:00
Charles Gagnon 808ce4366d Fix error deleting mount (#8637) 2019-12-11 16:31:44 -08:00
Charles Gagnon 99c473cdf6 Fix shift + enter to go to previous find entry in profiler (#8615) 2019-12-10 07:33:49 -08:00
Charles Gagnon 42ff30515c Don't instrument any test code for coverage (#8598) 2019-12-09 09:01:10 -08:00
Charles Gagnon 6e8cc3aaca Fix accessibility issues with Manage Access dialog (#8586) 
* Fix accessibility issues with Manage Access dialog

* implement more property interfaces

* Fix lgtm errors

* Simplify condition
 2019-12-06 15:09:42 -08:00
Charles Gagnon d1c7370f1c Make links more descriptive (#8591) 2019-12-06 13:06:49 -08:00
Charles Gagnon 6cce532ca4 Fix wizard not displaying error messages (#8545) 2019-12-03 17:40:19 -08:00
Charles Gagnon 7f16a4d857 Fix refresh action (#8519) 
* Fix refresh action

* Refactor to async

* Fix missing bracket

* Remove unused error level

* Add back in error message

* Fix missing service
 2019-12-03 17:40:02 -08:00
Charles Gagnon d358cdac1e Add tests for declarative table component (#8499) 2019-12-03 09:04:33 -08:00
Charles Gagnon 4f8ced1f6b More dangling promise cleanup (#8518) 
* More dangling promise cleanup

* return void

* Function to async

* Fix a couple missed promises
 2019-12-02 15:54:33 -08:00
Charles Gagnon b8bc629970 Add aria labels and consolidate loc strings (#8494) 2019-12-02 13:33:24 -08:00
Charles Gagnon d451528b36 Fix loading component not disappearing (#8495) 2019-11-27 14:42:28 -08:00
Charles Gagnon 3135b8525b Add styling and component column type to declarative table (#8476) 
* Initial wip

* wip

* Working implementation

* Make widths a bit nicer and remove sqlops addition

* Add sqlops back in

* Fix timing issue with tables

* Undo change to sql.bat and remove loading component when done
 2019-11-27 08:06:41 -08:00
Charles Gagnon 0e9797c394 Fix more floating promises (#8460) 2019-11-27 08:04:51 -08:00
Charles Gagnon 52de2b4751 Fix clickable being announced for all modelview text (#8384) 
* Fix clickable being announced for all modelview text

* Remove unused method

* Move API changes into proposed
 2019-11-22 11:01:46 -08:00
Charles Gagnon f1ca2a35ef Add thank you to changelog (#8424) 
@aspnerd Thanks again for the fix! Let me know if you'd prefer not to be added to this list.
 2019-11-21 11:53:03 -08:00
Charles Gagnon 019d5088ec Add engine edition to connection telemetry (#8425) 2019-11-21 10:05:44 -08:00
Charles Gagnon e6ffb97a7b Add info message for copy (#8416) 
* Couple of a11y fixes for BDC Dashboard

* Moving ariaRole into separate PR

* Remove missed ariaRole tag

* Switch to just using notification dialog

* add back in blank line
 2019-11-20 15:49:21 -08:00
Charles Gagnon f26c790736 Add aria role and selected properties (#8405) 
* Add aria role and selected properties

* Add img role fix

* Add title to text
 2019-11-20 13:56:59 -08:00
Charles Gagnon 164ec41fb1 Bump SqlToolsService (#8404) 2019-11-20 13:32:41 -08:00
Charles Gagnon f976fc9418 Update js file with monaco -> ads workbench (#8398) 2019-11-19 17:35:07 -08:00
Charles Gagnon 55059907a3 Fix a couple a11y issues with manage access (#8386) 
* Fix a couple a11y issues with manage access

* Fix strict null check

* Fix another strict null check
 2019-11-19 13:42:53 -08:00
Charles Gagnon 8ca0082ec4 Fix tab navigation within modal dialog (#8326) 
* Fix tab navigation within modal dialog

* Add import

* Fix spelling

* Change to just add/remove items from DOM as necessary
 2019-11-19 12:43:55 -08:00
Charles Gagnon 5b50696a1b Fix more floating promises (#8374) 
* Fix more floating promises

* Fix a few more

* Test fixes

* Fix spellings

* More promise fixes

* couple more

* Few more fixes

* One more missed one
 2019-11-18 17:11:25 -08:00
Charles Gagnon ee5dbdffb9 Add charle-gagnon to default assignee (#8382) 2019-11-18 13:32:19 -08:00
Charles Gagnon 8a44de27e7 monacoworkbench -> adsworkbench (#8380) 
* monacoworkbench -> adsworkbench

* Fix typo
 2019-11-18 10:57:39 -08:00
Charles Gagnon 66048f1d63 Default checkbox aria label to label (#8367) 2019-11-18 10:24:27 -08:00
Charles Gagnon ae8304fc33 Add focus function for modelview components (#8348) 
* Add focus method for modelview components

* Remove focus properties from table and radiobutton

* Fix break
 2019-11-15 17:36:55 -08:00
Charles Gagnon 82185f75d7 Fix tab focus for select box (#8349) 2019-11-15 14:31:40 -08:00
Charles Gagnon ba8c331356 Add alert role to error message element (#8354) 2019-11-15 11:51:08 -08:00
Charles Gagnon cf5297958a Update iKey (#8353) 2019-11-15 11:26:12 -08:00
Charles Gagnon 7563416754 Fix a couple a11y issues (#8334) 
* Fix a couple a11y issues

* Add other dialog
 2019-11-15 07:41:09 -08:00
Charles Gagnon 6ef87d7067 Insiders icons (#8313) 
* Add separate icons for non-stable builds (#8078)

* Fixes

* Fix linux icon path

* WIP

* WIP

* WIP

* Undo all

* Try removing insiders icons completely

* Revert "Try removing insiders icons completely"

This reverts commit 7cdb04fcc3ba6ed92132e5d9113cc331e24b3c26.

* Revert "Undo all"

This reverts commit efac800b63483fbbcacdac45d885275c53350941.

* Revert "WIP"

This reverts commit b20517f374b85f6b02c665b86e73d9ae1b45258b.

* Revert "WIP"

This reverts commit 01383896ccc4939b000d0f08a1b370f6e66b0f3c.

* Revert "WIP"

This reverts commit da7da0a43401f1c97f1bfa66f255666cffe22948.

* Fixes

* Remove test

* Switch logic check

* Use insiders icons only

* Add newline
 2019-11-14 17:21:57 -08:00
Charles Gagnon 18ab2ae799 Remove TelemetryUtils and use IAdsTelemetryService directly (#8289) 
* Remove TelemetryUtils and use IAdsTelemetryService directly

* Fix event names and cleanup

* Fix tests

* Fix strict null check
 2019-11-13 13:54:55 -08:00
Charles Gagnon 86d6295bf0 Fix welcome page icon (#8318) 
* Fix welcome page icon

* Remove title metadata

* Add comment
 2019-11-13 07:31:04 -08:00
Charles Gagnon 3f306d2396 Fix spacing for form layout (#8321) 2019-11-13 07:30:09 -08:00
Charles Gagnon 4f69ed5745 Fix missing icon and add test (#8307) 
* Fix missing icon and add test

* Remove debug statement
 2019-11-12 16:31:39 -08:00
Charles Gagnon ddddf3beb4 Fix null ref error in query history (#8304) 
* Fix null ref error in query history

* Add null check
 2019-11-12 13:38:58 -08:00
Charles Gagnon 0ae525cbd5 Fix a few more floating promises (#8290) 
* Fix a few more floating promises

* More explicit calls
 2019-11-11 13:42:03 -08:00
Charles Gagnon 8b17b77010 Undo codicon change to fix modelview images (#8201) 2019-11-11 08:28:48 -08:00
Charles Gagnon b1496aa12f Don't show dialog cancelled errors for mount (#8272) 2019-11-07 16:00:23 -08:00
Charles Gagnon 30acba7921 Add preview title to BDC/HDFS components (#8268) 
* Add preview title to BDC/HDFS components

* Additional dialogs

* More dialogs
 2019-11-07 15:34:38 -08:00
Charles Gagnon efebd681b6 Add level to dialog titles and form component titles (#8233) 
* Add level to dialog titles and form component titles

* Switch to h1

* h2 instead of role and aria-level
 2019-11-07 09:32:02 -08:00
Charles Gagnon d635390b33 Fix missing dashboard icons (#8249) 2019-11-07 08:05:06 -08:00
Charles Gagnon e49ff93122 Fix link for manual install of VSIX's (#8221) 2019-11-05 10:44:26 -08:00
Charles Gagnon 399788ccc1 Fix row/column count and table aria label (#8219) 2019-11-05 09:52:59 -08:00
Charles Gagnon 08fde8719d Make declarative table read blank for empty text cells (#8215) 2019-11-05 08:02:37 -08:00
Charles Gagnon f7bef3f87b Update to new iKey (#8206) 2019-11-05 07:55:26 -08:00
Charles Gagnon 9eb438bb24 Add separate icons for non-stable builds (#8078) 2019-11-04 17:05:25 -08:00
Charles Gagnon 38decaea90 Fix test script overwriting grep option (#8209) 
* Fix test script overwriting grep option

* Better logic and fix unstable scripts too
 2019-11-04 11:35:52 -08:00
Charles Gagnon 5dc7049f8c Fix floating promises in connection widget (#8198) 
* Fix floating promises in connection widget

* PR feedback

* More feedback changes

* Couple missed promises
 2019-11-04 07:24:38 -08:00
Charles Gagnon a8eed6114b Fix race conditions with BDC dashboard init (#8135) 
* Fix race conditions with initialized

* Check for undefined status

* Disable no-floating-promises check

* Add catch instead of disabling tslint disable
 2019-11-02 14:58:56 -07:00
Charles Gagnon 5bbc17be5c Fix ssl config issue (#8187) 
* Fix ssl config issue

(cherry picked from commit cacd481bff)

* Better fix

* Actually return...
 2019-11-01 16:25:44 -07:00
Charles Gagnon abbb1e54da Add config for ignoring SSL errors on BDC queries (#8169) 
* Add config for ignoring SSL errors on BDC queries

* Fix error handling in write stream

* Disable tslint check

* Handle promise appropriately

* PR comments

* Change defaults to true
 2019-11-01 15:20:47 -07:00
Charles Gagnon 7569f7fa32 Fix node update in bdc dashboard on reconnect (#8138) 
* Fix node update in bdc dashboard on reconnect

* Fix no floating promises

* Fix opening from dashboard to always save controller node
 2019-10-31 14:42:15 -07:00
Charles Gagnon dbf834c00f Fix metrics log links (#8140) 2019-10-31 13:24:56 -07:00
Charles Gagnon ef9321ef2c Add error messages to BDC dashboard page (#8103) 
* Add error messages to BDC dashboard page

* Remove testing code

* PR fixes
 2019-10-30 15:23:34 -07:00
Charles Gagnon 82e5221024 Fix modal event propagation (#8050) 
* Fix event propagation

* Remove unneeded onkeyup method

* Move event handling code into SQL classes
 2019-10-30 11:29:01 -07:00
Charles Gagnon d315ccff68 Fix BDC remember password and reprompting connection (#7957) 
* Fix remember password and reprompting connection

* comment

* Fix to remember password for session

* Fix floating promises
 2019-10-29 07:27:31 -07:00
Charles Gagnon cea8d62051 Add SQL Metrics links to BDC dashboard (#8056) 
* Add SQL metrics link to dashboard pages

* Only show SQL metrics column for SQL service

* Add param doc
 2019-10-28 15:07:32 -07:00
Charles Gagnon fa79e5b016 Fix for propagating aria-label title of form components to loading component (#8051) 2019-10-28 14:48:47 -07:00
Charles Gagnon 833adf3515 Fix hygiene errors (#8019) 2019-10-27 14:38:26 -07:00
Charles Gagnon bd15a96b83 Make form components use title as aria-label (#8040) 2019-10-27 14:37:34 -07:00
Charles Gagnon c5d427ebb1 Fix column text overflow on BDC status pages (#7928) 
* Fix column text overflow on status page

* Fix typo

* Fix another typo
 2019-10-24 18:31:57 -07:00
Charles Gagnon 696f6841cb Change BDC view errors to use modal dialog instead of error toast (#7985) 
* Change BDC view errors to use modal dialog instead of error toast

* Move to common control
 2019-10-24 13:05:07 -07:00
Charles Gagnon cef60f3ae5 Fix troubleshoot URL lookup (#7978) 2019-10-24 10:14:39 -07:00
Charles Gagnon 4a68ab4659 Hygiene linting for extensions + new rule (#7843) 
* linting for extensions + new rule

* Remove unneeded array

* Fix spelling mistake

* Fix bad merge
 2019-10-22 18:56:31 -07:00
Charles Gagnon a70ebeed1c BDC Dashboard context sensitive troubleshoot links (#7895) 
* Add context awareness to troubleshoot button on dashboard

* Remove tests for now

* Undo yarn.lock changes

* Correct yarn.lock version

* Lower case service check
 2019-10-22 14:24:26 -07:00
Charles Gagnon 8f2113e6b5 Fix HDFS paths to be encoded properly (#7896) 2019-10-22 14:05:23 -07:00
Charles Gagnon 03cb0565d4 Clean up bdc devDependencies (#7872) 
* Clean up bgc devDependencies

* Add extra files to .vscodeignore
 2019-10-22 11:07:35 -07:00
Charles Gagnon dd14f9b93d Fix telemetry opt out message (#7891) 2019-10-22 11:00:57 -07:00