Commit Graph

1163 Commits

Author SHA1 Message Date
Sai Avishkar Sreerama
5663ddba68 OptionsMapTable preparing from DacFx description,value,displayname at… (#1550)
* OptionsMapTable preparing from DacFx description,value,displayname attributes

* Review Comments addressed for options map table changes

* OptionsMapTable final changes

* Code review comments updated code changes

* Test fix: Adding missing change while splitting the PR

* DacFx vBump

* Reverted to displayName and code updates

* final:prop name changed, references updated, tests fixed, comments addressed

* Code review comments updated for name,exception etc

* updates method names

* property name changes to BooleanOptionsDictionary and comment updates

* Removed the unused properties, null cases handeled, hardcoded values are replaced
2022-07-07 16:56:16 -05:00
Alex Hsu
6558f2036d LEGO: Merge pull request 1566
LEGO: Merge pull request 1566
2022-07-07 08:35:44 -07:00
Charles Gagnon
ac9f88266c BatchParser target netstandard2.0 and remove Hosting dependency (#1564)
* Remove Hosting dependency from BatchParser, wip for logging replacement

* netstandard2.0 and fixes

* comment + cleanup

* comment

* fix build

* Update newtonsoft

* localize errors
2022-07-06 15:26:06 -07:00
Aasim Khan
e64e31e487 Adding top operations to execution plan (#1563)
* Adding more rules for prop

* adding top operations to ep

* Reverting changes made to display cost

* Fixing comments

* Removing whitespace

* Fixing data size property
2022-07-05 20:18:24 -07:00
Cory Rivera
671310880b Clean up notebook export code (#1565)
* Add null checks when converting notebooks to SQL, and SQL to notebooks.

* Remove unnecessary newlines and spaces from multi-line comments.

* Use the current environment's newline characters when converting cell text to a SQL query.

* Add additional unit tests for notebook conversion.
2022-07-01 15:28:05 -07:00
Alan Ren
2c783a4011 use file path instead of content in the request (#1562)
* use file path instead of content in the request

* remove unused using statement
2022-06-30 15:19:56 -07:00
Alan Ren
0b3c86cde8 add parse t-sql script handler (#1561)
* add parse t-sql script handler

* handle error
2022-06-30 11:05:38 -07:00
Alex Ma
deae354f31 Fix for rowId not decrementing if reverting an create row (#1560)
* Decrement NextRowId if reverting addition of a row that is not committed yet.

* added test and message

* added fixed and extensive tests

* added assert messages
2022-06-27 14:47:46 -07:00
Sai Avishkar Sreerama
0b2eb44769 These changes needs to remove from main and have to merge with other changes. (#1552) 2022-06-21 12:34:44 -07:00
ssreerama
1de6c6070a Merge branch 'main' of https://github.com/microsoft/sqltoolsservice 2022-06-21 12:06:52 -07:00
ssreerama
8d32704823 Getting include objects types names from the DacFx to avoid the duplication and hardcoded values in the ADS 2022-06-21 12:06:31 -07:00
Charles Gagnon
c64c32967f Add event TID to SqlClient events (#1549) 2022-06-21 11:09:52 -07:00
Charles Gagnon
dd11be3d38 Consolidate to net6.0 (#1547)
* Add SqlClient event listener

* comments

* ensure not disposed early

* initial

* net6.0

* undo
2022-06-21 08:53:23 -07:00
Alex Ma
a8bf275e04 [Loc] update to sr xlf for 6/20/2022 (#1548) 2022-06-20 16:51:04 -07:00
csigs
fb5ea303bc LEGO: Merge pull request 1546
LEGO: Merge pull request 1546
2022-06-20 08:35:43 -07:00
Charles Gagnon
d9e1678694 Add SqlClient event listener (#1544)
* Add SqlClient event listener

* comments

* ensure not disposed early
2022-06-17 20:06:09 -07:00
Alan Ren
afb2245be1 localize the rule descriptions (#1543) 2022-06-17 13:54:06 -07:00
Alan Ren
17b6073c87 include additional data for error object (#1539)
* include additional data for error

* fix tests
2022-06-10 20:40:22 -07:00
Charles Gagnon
b182e9fe53 Bump SMO to 161.47021.0 (#1538) 2022-06-10 13:02:49 -07:00
Charles Gagnon
294873613a Add Operations to GetAzureFunctions request (#1527)
* Add Operations to GetAzureFunctions request

* add comment

* comments
2022-06-06 12:59:59 -07:00
Benjamin Russell
97a106c575 Removing a lot of redundant async/await wrappers (#1486)
* Removing a lot of redundant async/await wrappers

* Removing kusto changes
2022-06-05 08:26:21 -07:00
Charles Gagnon
36d92a1cc4 Fix backup closing parent connection (#1530)
* Fix backup closing parent connection

* always dispose

* update comment
2022-06-03 17:01:42 -07:00
Aasim Khan
3ff5c6c95c Adding more rules for prop (#1529) 2022-06-03 11:50:09 -07:00
Alan Ren
674ac5243a disable table renaming for sql proj (#1526) 2022-06-01 15:34:33 -07:00
Hai Cao
33636efa87 [Table Designer] Fix a few computed col issues (#1518) 2022-06-01 15:00:01 -07:00
Alex Ma
9a341c6bd9 [Loc] update to fr, ja, ko, zh-hans, and zh-hant xlfs (#1525) 2022-06-01 14:23:56 -07:00
Alan Ren
63bef2b904 enable table designer for sqlproj (#1511)
* enable table designer for sqlproj

* return issues and new table info on initialization

* vbump dacfx

* Revert "vbump dacfx"

This reverts commit f59768b41f67866bd7620e06b141e8bfdb1523aa.
2022-06-01 14:17:04 -07:00
Aasim Khan
fed1cef7bf Adding property type and rules to compare properties in Execution Plans (#1522)
* Adding plan index in file info

* Adding basic framework for prop comparison

* Remoing none and and fixing some better values

* Fixing file formatting

* Fixing some formatting

* Fixing casing

* Fixing compilation

* fixing compilation error
2022-05-31 17:15:43 -07:00
Raymond Truong
0c37dc50f9 [SQL Migration] Update assessment NuGet version + mark GAed VM SKUs as non-preview (#1510)
* Update assessment NuGet version and metadata

* Consider Eb VM SKUs without preview flag as they are now GAed

* Update assessment NuGet to 1.0.20220527.33
2022-05-31 14:54:29 -07:00
Charles Gagnon
076ed9644b Add route to GetAzureFunctions request + cleanup (#1521)
* Add route to GetAzureFunctions request + cleanup

* update comments

* comments

* Add comment
2022-05-31 10:22:20 -07:00
Alex Ma
1ed6c132a4 [Loc] update to xlfs 5-27-2022 (#1520) 2022-05-27 10:11:49 -07:00
csigs
df6283e721 LEGO: Merge pull request 1519
LEGO: Merge pull request 1519
2022-05-27 09:08:24 -07:00
Alex Ma
f6068e28db [Loc] changes to xlf and resx files for 5/26/2022 (#1517) 2022-05-26 14:51:05 -07:00
Charles Gagnon
45cb5f28fd Enable nullable (#1515) 2022-05-26 14:41:50 -07:00
csigs
51f31c4c4e LEGO: Merge pull request 1513
LEGO: Merge pull request 1513
2022-05-26 09:09:16 -07:00
Hai Cao
bc1b60fa87 [Table Designer] Add apis to support computed column (#1495) 2022-05-23 15:41:07 -07:00
Sai Avishkar Sreerama
62d3cdc99a Revert "Revert "Adding new Dac Deployment Options and getting descriptions fr…" (#1507)
* Adding missing Deploy options

* SQL DB Project database genScript/Publish working but tests

* Test cases fixed for the changes for DacFx and SC services

* Refactored the model name and tested the changes with ADS extensions.

* updated DeploymentOptionProperty model and corresponding updates.

* Adding DisplayNames to the deploymentOptionProperty to maintain names in STS for all extensions.

* MapTabe intialization in constructor

* Updated comment with more meaning

* Porperty strong type update with actual type

* Creating model with generic type getting using Activator.CreateInstance

* Rebase to main and resolved merge conflicts

* Xml comments added and code updated

* Deployment options update

* Deployoptions typo and comments updates a

* updated deployment options comments

* removed unnecessary using statement

* code refactor

* Revert "Revert "Adding new Dac Deployment Options and getting descriptions from DacFx API (#1357)" (#1493)"

This reverts commit 2b48331115.

* removing duplicated default empty string value
2022-05-23 16:19:15 -05:00
Hai Cao
262fd00afd fix memory optimized option inconsistent state (#1503)
* disable mem optimized instead of removing options

* bump DacFx
2022-05-23 13:27:18 -07:00
Aasim Khan
25f5f024dd Adding plan index in file info (#1501) 2022-05-19 13:52:02 -07:00
Aasim Khan
e7c7489b21 Removing circular references from Plan Comparison (#1498) 2022-05-18 00:13:26 -07:00
Christopher Suh
106b6baeda Refreshes token for intellisense (#1476)
* check if token refresh needed

* add more checks

* simplify logic

* add summary and change to false

* wip

* wip

* add ExpiresOn field to check when token needs to be refreshed

* expired token check

* wip

* wip

* wip

* update expiresOn check

* wip

* wip

* working refresh token

* add closing tag

* fix summary

* pr comments

* add max tolerance

* refactoring

* refactoring and updating descriptions

* remove comment

* pr updates

* more pr comments

* pr comments

* wip

* pr comments - add state tracker

* update comment

* fix type

* pr comments

* fix race condition

* wip

* pr comments

* add comment

* pr comments

* nullable int

* pr comments

* remove uri from map upon disconnect

* pr comments

* remove uri from map upon editor close

* pr comments
2022-05-13 13:47:37 -05:00
Aditya Bist
01fe402adf Add error link to period col error (#1494)
* add error link to period col error

* remove sql server 15 from link
2022-05-13 10:18:58 -07:00
Charles Gagnon
7787a6af7b Fix Backup/Restore parameters defaulting to wrong DeviceType (#1490) 2022-05-12 13:34:49 -07:00
Udeesha Gautam
2b48331115 Revert "Adding new Dac Deployment Options and getting descriptions from DacFx API (#1357)" (#1493)
This reverts commit a3a66137b8.
2022-05-12 13:30:04 -07:00
Karl Burtram
a70402fe60 Revert SMO bump (#1492) 2022-05-11 15:34:15 -07:00
Alex Ma
fc13b46269 [Loc] change note of costformat to reflect updates (#1491) 2022-05-11 13:00:16 -07:00
Charles Gagnon
a4ef58212b Fix Agent actions for docker servers (#1489) 2022-05-10 11:09:57 -07:00
Sai Avishkar Sreerama
a3a66137b8 Adding new Dac Deployment Options and getting descriptions from DacFx API (#1357)
* Adding missing Deploy options

* SQL DB Project database genScript/Publish working but tests

* Test cases fixed for the changes for DacFx and SC services

* Refactored the model name and tested the changes with ADS extensions.

* updated DeploymentOptionProperty model and corresponding updates.

* Adding DisplayNames to the deploymentOptionProperty to maintain names in STS for all extensions.

* MapTabe intialization in constructor

* Updated comment with more meaning

* Porperty strong type update with actual type

* Creating model with generic type getting using Activator.CreateInstance

* Rebase to main and resolved merge conflicts

* Xml comments added and code updated

* Deployment options update

* Deployoptions typo and comments updates a

* updated deployment options comments

* removed unnecessary using statement

* code refactor
2022-05-10 22:59:26 +05:30
Charles Gagnon
70be8f5ef5 Don't add parentheses to ANSI Scalar functions (#1487)
* Don't add parentheses to ANSI Scalar functions

* fix test
2022-05-09 18:57:14 -07:00
Aasim Khan
99d0959291 Adding decimal values to costs (#1449) 2022-05-09 09:53:36 -07:00