Commit Graph
29 Commits
Author SHA1 Message Date
Udeesha Gautam fe4c2ce5b9 update dacfx to bring in ASDE support - first set of features (#1088) 2020-10-01 12:32:09 -07:00
Udeesha Gautam bb735a409f update DacFx (#1072) 2020-09-10 09:29:49 -07:00
Udeesha Gautam d2f5bfaa16 update dacfx to latest (#1044) 2020-08-10 18:52:29 -07:00
Udeesha Gautam 616a79c83d GetConnectionString API fix to not change the cache only return the value (#1040)
* Get connection string call was changing the connection info (ref object) received from cache. Changing it to just get and make changes to only the returned string..

* Change to ensure PR validation works
2020-08-09 19:17:16 -07:00
Udeesha Gautam 9d52370df0 Updating to latest DacFx for a bug fix (#1010) 2020-07-29 10:28:01 -07:00
Udeesha Gautam 4c819e0fc1 Fixes for tests affected by MDS update (#987)
* Fixing tests in parallel that were affected by MDS update
2020-06-23 11:27:19 -07:00
Udeesha Gautam 3049dacb84 Update DacFx and MDS to same version (#986)
* Updating DacFx and MDS nuget to match versions

* Fixing a test. It's unreleated to change.
2020-06-22 15:16:13 -07:00
Udeesha Gautam 9eec757ad1 Updating DacFx nuget to one with SqlTasks (#958)
* Updating DacFx nuget to one with SqlTasks

* Adding common references to build props to avoid multiple places for update
2020-05-08 17:43:04 -07:00
Udeesha Gautam 808e8d1d6f Schema compare options update to ensure tests pass
Schema compare options update to ensure tests pass
2020-01-14 20:42:17 -08:00
Udeesha Gautam fe17962ac9 SqlCmd Connect/On Error/Include commands support (#898)
* Initial Investigation

* Working code with include, connect, on error and tests

* Adding some loc strings

* Some cleanup and more tests

* Some dummy change to trigger build

* Adding PR comments

* Addressing PR comments
2020-01-10 17:54:39 -08:00
Udeesha Gautam d75edd0dbe Revert "Explicitly erroring out on some failing commands that were not already included (#882)" (#887)
This reverts commit 57b7126ccf.
2019-10-30 14:51:41 -07:00
Udeesha Gautam 57b7126ccf Explicitly erroring out on some failing commands that were not already included (#882)
* Excplitly erroring out on some failing commands that was not happening before

* Ensuring the error message goes through without getting converted to different error
2019-10-25 15:41:59 -07:00
Udeesha Gautam 68145d5e7c Feature/sqlcmd : Enable running scripts with SQLCMD variables - Part 1 (#839)
* Part1 : Changes to make cmdcmd script to work with parameters in script

* Stop SQL intellisense for SQLCMD

* Adding test for Intellisense handling of SQLCMD page

* Removing unintentional spacing changes caused by formatting

* Updating with smaller CR comments. Will discuss regarding script vs other options in batch info

* Removing unintentional change

* Adding latest PR comments
2019-08-09 14:25:47 -07:00
Udeesha Gautam 4fe02a6885 Update dacfx to latest preview (#845)
* updating dacfx with private nuget for testing

* Updating to real dacfx-preview version

* Removing additional refs added by nuget package manager (these were not there previously)
2019-08-08 20:55:06 -07:00
Udeesha Gautam a6450eb180 Bug/schemacompare publish and script tasks to send back results (#830)
* Fix Schema compare Publish and Script generation task to return back error messages correctly.

* Elaborating test a bit more to cover tasks

* Validate one task at a time for better clarity

* send back only errors not whole messages since task view doesnt have a good way (other than hover text) to show long messages

* Fixing the negative test cases
2019-06-27 15:55:26 -07:00
Udeesha Gautam 347d233e95 Change to pass Schema compare Operation id from ADS (#828)
* Changing that SC Operation id be passed from ADS and some test addition

* Fixing typos
2019-06-19 09:49:50 -07:00
udeeshagautam 3e1f186891 Schema compare cancel operation (#826)
* First cut of schema compare cancel (private nuget)

* Update Dacfx nuget to a published version
2019-06-14 18:19:36 -07:00
udeeshagautam 432e054d55 Feature/schemacompare scmp save (#824)
* First cut of scmp Save related changes and some test refactoring

* Adding Exclude/Include objects in saving

* Add diff entry validation as part of test

* Adding PR comments - major change is change to nameparts in place of name hence preserving any "."/"[" in name and avoiding any string operations

* One more UT scenario addition for create excluded object
2019-06-13 17:28:59 -07:00
udeeshagautam 758eefe749 Change to scope file tree to the known path if root folders dont return correctly (#816)
* Change to scope file tree to the known path if root folders dont return correctly.

* Fixing a typo (duplicate assignment)
2019-05-25 09:53:11 -07:00
udeeshagautam b30926b273 Adding some default values to match SSDT and other tools (#818)
* Adding some default values to match DacFx deploy Extension and other tools. This help the default behavior but doesn't fix the issue.

* Fixing a test for default values and adding comment
2019-05-24 10:51:21 -07:00
udeeshagautam 64fa9cc7af Removing Exclude/Include to show in tasks view (parity with SSDT) (#814) 2019-05-21 00:01:32 -07:00
udeeshagautam db70f421ae Fix for Full/Log/Differential backup #5370 (#811)
* fixing the order of setting backup properties so that they are correctly propogated to actual action

* Adding a backup type specific test and enabling 'few' old ones which seem to work consistentenly

* Adding finally block, close connection and name change as per PR comments
2019-05-14 17:00:21 -07:00
udeeshagautam c86f43618c Proposed fix for : 3653 : Cancel not working even after disconnecting (#797)
* Proposed changes to stop query execution if an exception has occured before/during batch execution

* Sending the error message was causing a test to fail - so removing for now. We can update the test to expect this is needed.
2019-05-14 16:15:09 -07:00
udeeshagautam a24a107f21 Loc Strings Fix (#803)
* Adding missing loc changes for include exclude node

* Adding the autogenerated file
2019-04-29 12:13:20 -07:00
udeeshagautam f8cd355e61 Feature/schemacompare Exclude-Include and Options enhancement (#799)
* Initial code for Including/Excluding individual changes (no tests added yet)

* Adding Exclude include tests. Default options call and additional options tests.

* Taking PR comments

* Retry in test for reliability
2019-04-25 22:07:00 -07:00
udeeshagautam 9e14336293 Feature/schemacompare options (#798)
* Initial working code for schema compare options

* Removing the unnecessary default value attribute

* Cleaning up tests

* Taking PR comments

* Taking name change for Schema Compare Options --> Deployment Options

* Remove parent to avoid circular reference (to avoid issues with serialization)
2019-04-18 12:52:10 -07:00
udeeshagautam 5778dc7b01 Fix for : 4045: Cannot cancel a Query. Query runs too long. (And SMO update) (#780)
* Fix for : 4045: Cannot cancel a Query. Query runs too long.
HandleExecuteRequest was returning a task to awaiter - which was getting waited on. changed it to async function to start task in new thread and return nothing to awaiter . Also the cancellation token set by cancel request was getting checked only after making the connection to execute batches. Added an additional check for cancellation token befor the connection has been made.

Fix for 4319: Error showing dbs when using AAD in... 1.5.0-alpha.74
David has already created a new version of SMO nuget with the fix. - incorporating the same (150.18096.0-preview).

* Adding awaitable internal task for tests to run properly

* Adding more cancel tests
2019-03-13 15:39:00 -07:00
udeeshagautam 676ce9c7de Missing one spelling Fix (#778) 2019-03-01 14:51:15 -08:00
udeeshagautam 9551022fff Feature/cms backend (#776)
* First cut of CMS get Server Api - returns only names

* Adding Proper naming and some more functions

* Adding add remove Server and tests for it

* Changing relative path to derive from KeyChain.Urn and Nuget update

* Adding async thread for requests

* Addressing CR comments and adding one more test

* Adressed PR comments around naming
2019-03-01 11:55:19 -08:00