Commit Graph

961 Commits

Author SHA1 Message Date
David Shiflet
856a042ea3 Update SMO to SSMS 18.2 version (#850)
Needed to get support for external table syntax updates
2019-08-14 09:38:32 -07:00
Udeesha Gautam
68145d5e7c Feature/sqlcmd : Enable running scripts with SQLCMD variables - Part 1 (#839)
* Part1 : Changes to make cmdcmd script to work with parameters in script

* Stop SQL intellisense for SQLCMD

* Adding test for Intellisense handling of SQLCMD page

* Removing unintentional spacing changes caused by formatting

* Updating with smaller CR comments. Will discuss regarding script vs other options in batch info

* Removing unintentional change

* Adding latest PR comments
2019-08-09 14:25:47 -07:00
Kevin Cunnane
d42e3626cb Fix serialization tests & don't block thread (#846)
* Fix serialization tests & don't block thread
- Fixed potential null ref when closing streams
- Always clean up serialization queue if an error occurs
- Stop blocking dispatcher thread by not awaiting task that processes the message
- Improved error logging in EventFlowValidator to help debug issues
- Close stream on exception
2019-08-09 09:48:57 -07:00
Udeesha Gautam
4fe02a6885 Update dacfx to latest preview (#845)
* updating dacfx with private nuget for testing

* Updating to real dacfx-preview version

* Removing additional refs added by nuget package manager (these were not there previously)
2019-08-08 20:55:06 -07:00
Shengyu Fu
8d7acab1ab Merge branch 'shengyfu-pr/842' 2019-08-07 11:57:54 -07:00
Shengyu Fu
4f4d94bb88 Merge branch 'shengyu_0804' of https://github.com/shengyfu/sqltoolsservice into shengyfu-pr/842 2019-08-07 11:56:14 -07:00
Shengyu Fu
c919dba89f Adding Title/Tooltip for Command class. 2019-08-06 17:18:20 -07:00
Kevin Cunnane
7ef82feea7 Add serialization service support (#840)
Added a method that handles serialization requests
Support splitting save over multiple requests to reduce overall message size
Added unit tests
String changes used a new version of the string tool for generation.
Will publish PR separately for the changes to build & localization
so this can run on Mac without .Net Core 1.0
2019-08-06 16:50:42 -07:00
Shengyu Fu
9bbc7a20c9 Fix tests with the updated the Command class 2019-08-05 16:22:51 -07:00
Charles Gagnon
92bb281cdd Ensure test file is deleted and fix test project path (#843)
* Ensure test file is always deleted

* Fix up project path
2019-08-05 14:05:32 -07:00
Shengyu Fu
3fc9da02ca Need to match the command field in the vscode language service client contract 2019-08-04 15:15:41 -07:00
Kevin Cunnane
e0cce7061e Remove .Net Core 1.0 requirement for Loc and fix mac build (#841)
* Remove .Net Core 1.0 requirement for Loc and fix mac build
Use StringResourceTool to remove .Net Core 1.0 dependency for Loc
Fixed Mac build by copying the code used in internal repo for build.
- This now mostly matches internal, so expect this should work OK.
2019-08-01 14:55:32 -07:00
Charles Gagnon
ec09ad21d2 Revert "Default to Server level context for all OE nodes (#829)" (#838)
This reverts commit a4b6c300ac.

(cherry picked from commit 7512a2bbe3154e4dd4b63927fcba52db78424994)
2019-07-29 16:55:37 -07:00
Kim Santiago
f7a7a3d466 Fix DacFx wizard not supporting AAD auth (#836)
* pass Azure authentication token if using AAD auth

* add check for null
2019-07-24 17:23:55 -07:00
Shengyu Fu
e1b9890f5c Adding completion extension loading and execution logic (#833)
* Adding ICompletionExtension interface

* Adding extension loading and execution logic

* Fixing compilation error in VS 2017

* Using MEF for completion extension discovery

* using await on GetCompletionItems

* Adding an integration test for completion extension and update the completion extension interface

* Update the completion extension test

* Fix issues based on review comments

* Remove try/cache based on review comments, fix a integration test.

* More changes based on review comments

* Fixing SendResult logic for completion extension loading

* Only load completion extension from the assembly passed in, add more comments in the test

* Adding right assert messages in the test.

* More fixes based on review comments

* Dropping ICompletionExtensionProvider, load assembly only if it's loaded at the first time or updated since last load.

* Fix based on the latest review comments

* Adding missing TSQL functions in default completion list

* Update jsonrpc documentation for completion/extLoad
2019-07-19 12:04:03 -07:00
Alan Ren
e3ec6eb739 Handling the HierarchyId for edit data scenario (#709)
* Handling the HierarchyId for edit data scenario

* comments
2019-07-09 17:03:55 -07:00
Charles Gagnon
c1f2411b02 FIx intellisense cache not refreshing (#831)
* FIx intellisense cache not refreshing

* Remove extra newlines

* Output label to provide more useful information in case of error
2019-06-27 23:50:41 +00:00
Udeesha Gautam
a6450eb180 Bug/schemacompare publish and script tasks to send back results (#830)
* Fix Schema compare Publish and Script generation task to return back error messages correctly.

* Elaborating test a bit more to cover tasks

* Validate one task at a time for better clarity

* send back only errors not whole messages since task view doesnt have a good way (other than hover text) to show long messages

* Fixing the negative test cases
2019-06-27 15:55:26 -07:00
Charles Gagnon
a4b6c300ac Default to Server level context for all OE nodes (#829) 2019-06-27 17:50:35 +00:00
Aditya Bist
fc50913f14 chagned strings to enums and can edit step completion actions (#827) 2019-06-20 00:30:37 -07:00
Udeesha Gautam
347d233e95 Change to pass Schema compare Operation id from ADS (#828)
* Changing that SC Operation id be passed from ADS and some test addition

* Fixing typos
2019-06-19 09:49:50 -07:00
udeeshagautam
3e1f186891 Schema compare cancel operation (#826)
* First cut of schema compare cancel (private nuget)

* Update Dacfx nuget to a published version
2019-06-14 18:19:36 -07:00
udeeshagautam
432e054d55 Feature/schemacompare scmp save (#824)
* First cut of scmp Save related changes and some test refactoring

* Adding Exclude/Include objects in saving

* Add diff entry validation as part of test

* Adding PR comments - major change is change to nameparts in place of name hence preserving any "."/"[" in name and avoiding any string operations

* One more UT scenario addition for create excluded object
2019-06-13 17:28:59 -07:00
Kim Santiago
b451670222 Schema Compare open SCMP file (#825)
* initial open scmp changes

* more open scmp changes and adding tests

* moving some common test code

* simplify endpoint info parsing

* addressing comments and moving more common test code

* addressing comments
2019-06-13 14:24:19 -07:00
Kim Santiago
3566471c6c removing unused request context from dacfx and schema compare tests (#823) 2019-06-10 16:58:31 -07:00
Kim Santiago
f7c86a80ca Open dacfx deploy script instead of saving to file path (#822)
* open dacfx deploy script

* moving test db cleanups into finally blocks
2019-06-10 09:26:42 -07:00
Karl Burtram
43abb8def2 Restrict settings to known values (#821) 2019-06-04 13:27:18 -07:00
udeeshagautam
758eefe749 Change to scope file tree to the known path if root folders dont return correctly (#816)
* Change to scope file tree to the known path if root folders dont return correctly.

* Fixing a typo (duplicate assignment)
2019-05-25 09:53:11 -07:00
udeeshagautam
b30926b273 Adding some default values to match SSDT and other tools (#818)
* Adding some default values to match DacFx deploy Extension and other tools. This help the default behavior but doesn't fix the issue.

* Fixing a test for default values and adding comment
2019-05-24 10:51:21 -07:00
Aditya Bist
5583cc182f get more info for proxies (#815) 2019-05-21 11:49:14 -07:00
udeeshagautam
64fa9cc7af Removing Exclude/Include to show in tasks view (parity with SSDT) (#814) 2019-05-21 00:01:32 -07:00
kisantia
e68b6d62aa Open schema compare generated script (#813) 2019-05-20 14:14:50 -07:00
Karl Burtram
151a2de625 Query execution settings support (#812)
* WIP

* WIP 3

* WIP 3

* Additional query settings updates

* Add settings tets

* Address code review feeback

* Updates from testing
2019-05-16 15:21:17 -07:00
udeeshagautam
db70f421ae Fix for Full/Log/Differential backup #5370 (#811)
* fixing the order of setting backup properties so that they are correctly propogated to actual action

* Adding a backup type specific test and enabling 'few' old ones which seem to work consistentenly

* Adding finally block, close connection and name change as per PR comments
2019-05-14 17:00:21 -07:00
udeeshagautam
c86f43618c Proposed fix for : 3653 : Cancel not working even after disconnecting (#797)
* Proposed changes to stop query execution if an exception has occured before/during batch execution

* Sending the error message was causing a test to fail - so removing for now. We can update the test to expect this is needed.
2019-05-14 16:15:09 -07:00
NiranjanVirtuosity
2e2b764c6d Invoke-SqlCmd handles ":!!if" in inconsistent way (PS5 vs PS6) (#806)
* Invoke-SqlCmd handles ":!!if" in inconsistent way (PS5 vs PS6)

Fix: Set wordBounday to false for "!!" in Lexer.cs

* Issue : Invoke-SqlCmd handles ":!!if" in inconsistent way (PS5 vs PS6)
TFS: http://sqlbuvsts01:8080/Main/SQL%20Server/_workitems#id=12817630&triage=true&_a=edit
Fix:
1) Wrote two test cases in BatchParserTests.cs
2019-05-13 15:09:21 -07:00
kisantia
5392f81d54 Fix schema compare script formatting (#809)
* Add GO after each statement and remove leading and trailing whitespace

* Addressing comments

* formatting
2019-05-13 10:04:02 -07:00
Aditya Bist
eb2044155b Fix Dashboard OS version script (#804)
* fix OS version script

* lower everything to find keyword

* add check to another file
2019-05-03 16:20:19 -07:00
udeeshagautam
a24a107f21 Loc Strings Fix (#803)
* Adding missing loc changes for include exclude node

* Adding the autogenerated file
2019-04-29 12:13:20 -07:00
David Shiflet
5f2d3014a0 update smo to 150 GA (#801) 2019-04-29 08:24:57 -04:00
udeeshagautam
f8cd355e61 Feature/schemacompare Exclude-Include and Options enhancement (#799)
* Initial code for Including/Excluding individual changes (no tests added yet)

* Adding Exclude include tests. Default options call and additional options tests.

* Taking PR comments

* Retry in test for reliability
2019-04-25 22:07:00 -07:00
Charles Gagnon
85f34b65f1 Fix a number of cred scan hits (#800)
Bunch of secrets in files, usually fixed by generating random password. The deleted script files didn't seem to be used anywhere.
2019-04-24 13:31:34 -07:00
Dhruva N
e9bf57bc67 Include ManagedBatchParser tests to improve code coverage (#793)
* Include ManagedBatchParser test to improve code coverage

* Fix some failing test cases and revert appveyor.yml
2019-04-22 17:35:48 -07:00
udeeshagautam
9e14336293 Feature/schemacompare options (#798)
* Initial working code for schema compare options

* Removing the unnecessary default value attribute

* Cleaning up tests

* Taking PR comments

* Taking name change for Schema Compare Options --> Deployment Options

* Remove parent to avoid circular reference (to avoid issues with serialization)
2019-04-18 12:52:10 -07:00
kisantia
213fe4ab37 Add schema compare publish changes operation (#795)
* add schema compare publish changes operation
2019-04-09 15:04:59 -07:00
Charles Gagnon
8ba59859dc Correct typo in NodeType for SecurityPolicy (#796) 2019-04-08 07:39:31 -07:00
kisantia
dc5ab60df5 Fix invalid dacpac version crashing sqltoolsservice (#789)
* fix invalid dacpac version crashing sqltoolsservice
2019-04-03 17:30:10 -07:00
Kevin Cunnane
49cecaf72a Fix build on non-Windows OS (#785)
Remove TVFSample.csproj from main solution.
This is .Net 4.6 targeted so shouldn't be in the core buld.
2019-04-01 12:59:20 -07:00
kisantia
0c46c5bfdb Add schema compare generate script operation (#787)
* add generate script operation
2019-03-29 14:12:37 -07:00
Aditya Bist
c0ec9272b3 match agent behavior to ssms (#781) 2019-03-29 13:39:42 -07:00