ckaczor/azuredatastudio
Archived
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
9,991 Commits 1 Branch 152 Tags
main
Commit Graph
91 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Christopher Suh 587d31ab2c Transfer URI Correctly (#24614) 
* transfer uri regardless of queryrunner presence

* throw error if new URI already exists

* bump sts version
 2023-10-10 10:12:33 -07:00
Christopher Suh 62959d565c update commit hash for AGC merge (#24622) 2023-10-09 14:05:50 -07:00
Christopher Suh 05b6593f58 Create a custom Air-Gapped Cloud Build (#24595) 
* initial commit with new build step for agc

* add mixin agc step

* add commit hash
 2023-10-05 10:26:41 -07:00
Christopher Suh 186f8d3771 Change HTTP request to axios (#24549) 
* change request to axios

* fix typo

* remove httpClient

* fix build

* change azurenetworkresponse to axiosresponse
 2023-10-03 19:04:10 -07:00
Christopher Suh 86d0779c87 fix dashboard opening server vs database view (#24546) 2023-09-29 14:40:47 -07:00
Christopher Suh 86b3eaee5a Remove deprecated azure graph endpoints (#24460) 
* remove deprecated azure graph endpoints

* cleanup enums

* cleanup ProviderSettingsJson: remove graphResource

* change enums back
 2023-09-18 15:01:24 -07:00
Christopher Suh 0513282081 fix yarn.lock files so ^3.0.4 points to 3.1.2 (#24425) 2023-09-14 12:34:02 -07:00
Christopher Suh 5f45c000da Fix copy on Linux (#24341) 
* add return type for copy results from STS

* fix test error

* change Result type to CopyResultsRequestResult

* remove async

* bump data protocol client

* bump dataprotocol client version

* bump version in yarn.lock

* add async back
 2023-09-09 07:16:05 -04:00
Christopher Suh 45440d261b add ai key to fix undefined error (#24279) 2023-09-05 11:37:27 -04:00
Christopher Suh 9eee1384b4 Add telemetry to custom provider endpoints (#24229) 
* add telemetry to custom provider endpoints

* add reload ads telemetry

* change import

* add telemetry error event

* use vscode getpackageinfo

* remove getpackageinfo, fix semicolon

* use enum for telemetry message

* add enum, use error object instead of message for telemetry
 2023-08-30 10:07:53 -07:00
Christopher Suh f7c71a1fb3 Change proxy to Axios (#24118) 2023-08-16 21:23:50 -07:00
Christopher Suh 7e16d9660f initial commit, added more relevant error codes (#24005) 2023-07-28 09:43:52 -07:00
Christopher Suh 08909dfb27 Add no clouds selected warning popup (#24004) 
* initial commit, add no clouds selected warning popup

* move to constants file
 2023-07-27 17:42:47 -07:00
Christopher Suh f5bed289af Expand account picker support to multiple providers (#23952) 
* fix dropdown behavior

* expand account picker support to multiple providers

* fix tests

* fixed unresolved promise issue
 2023-07-21 08:43:18 -07:00
Christopher Suh 91359a32c9 Remove ADAL Code (#23360) 
* initial commit, removed all adal code

* remove all authLibrary references in extension/azurecore

* removed authLibrary references from src/sql

* remove MSAL/ADAL setting option

* wip fixing tests and removing Msal from method names

* fixed tests

* create accountInfo mock

* fix tests

* fix clientApplication mock

* remove clientapplication

* fix compile

* add typing

* wip

* wip

* wip

* fix tree provider

* remove SimpleTokenCache, FileDatabase & tests

* remove remaining adal / authentication library references:

* remove comma from package.nls.json

* fix error fetching subscriptions

* fix tests

* remove getAzureAuthenticationLibraryConfig

* remove adal check

* fix build

* remove test

* undo remove customProviderSettings

* fix bracket
 2023-07-20 10:37:38 -07:00
Christopher Suh a2b1c2cfc5 pass provider ID info to runAddAccountAction (#23938) 2023-07-20 10:16:28 -07:00
Christopher SuhCheena MalhotraCharles Gagnon
 		a752c84216 Add support for custom endpoints (#23390) 
* initial commit, add support for custom endpoints

* add template file with public azure endpoints

* add throw error, fix compile

* update description

* move custom provider to settings.json

* cleanup

* test

* wip

* try fix build error

* wip fix build issue

* add typings for package.json

* test remove default

* fix typings

* fix typing

* add object definitions

* add additional checks

* test define object

* add default

* remove default and extra checks

* Organize code well to fix integration tests (#23697)

* pr review updates

* fix custom setting checker

* fix default behavior

* add more required, change name for default cloud

* add one more required

* modify required properties to match with api

* Update extensions/azurecore/package.json

Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>

* Update extensions/azurecore/package.json

Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>

* pr review changes

* remove default value from display name

* make akv optional

* remove default name

* remove default

* update descriptions, function names

* add client ID

* small fix

* Update extensions/azurecore/package.nls.json

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Update extensions/azurecore/package.json

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* updated names

* add custom for configkey

* providerSettingsJson -> customProviderSettings

---------

Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
 2023-07-18 14:16:53 -07:00
Christopher Suh 95599ae39b fix dropdown behavior (#23708) 2023-07-10 14:59:21 -07:00
Christopher Suh 831b9eecc2 Add Patch Support (#23591) 
* add patch support

* docs and cleanup

* one more doc
 2023-07-03 12:44:19 -07:00
Christopher Suh b409d9e5bb update tenant version (#23525) 2023-06-30 13:02:34 -07:00
Christopher SuhandCheena Malhotra 0042e34617 Add adal deprecated warning upon ADS startup (#23462) 
* initial commit, add adal deprecated warning upon ADS startup

* change our to the

* Update extensions/azurecore/src/extension.ts

Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>

---------

Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>
 2023-06-26 02:07:24 -07:00
Christopher Suh 897f026d1e Firewall Dialog Account/Tenant Selection (#22695) 
* preselect account in firewall dialog from connection details

* cleanup

* fix element reference

* add initial tenant selection

* fix compile & cleanup

* pr comments

* change to private
 2023-04-12 15:59:31 -07:00
Christopher Suh 62c2fd3290 add ms graph endpoint for us gov (#22574) 2023-04-12 14:58:58 -07:00
Christopher Suh 6857718cb3 Fix http request format (#22618) 
* fix http request format

* encode to utf 8 and add body for put requests

* encode proxy request body

* change ?.data to ?.body

* add note for textencoder

* change content-type to application/json
 2023-04-10 14:36:35 -07:00
Christopher Suh e7a5ea6ee8 Add No Resources Found label under azure browse (#22660) 
* Add No Resources Found label under azure browse

* update localize message

* add period
 2023-04-10 10:27:01 -07:00
Christopher Suh ccd5775093 Update remaining Axios calls (#22525) 
* initial commit adding put and delete operations

* change response.data => response.body

* add client response interface

* add error to interface

* add reqHeaders
 2023-03-31 12:22:31 -07:00
Christopher SuhandCharles Gagnon 2e1689b44d Add warning message when pii logging enabled (#22533) 
* add warning message when pii logging enabled

* fix typo

* Update extensions/azurecore/src/localizedConstants.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* update warning message

---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
 2023-03-30 14:44:25 -07:00
Christopher Suh 87fb3f9b86 Add kusto endpoints for non-public clouds (#22515) 
* add kusto endpoints for non-public clouds

* fix endpoints
 2023-03-29 11:42:38 -07:00
Christopher Suh 738987c4d5 Show message indicating that ADAL is being deprecated (#22432) 
* show message indicating that ADAL is being deprecated

* pr comments update

* added settings deprecation message

* fix deprecation message
 2023-03-24 14:42:45 -07:00
Christopher Suh 00897fc513 Replace Axios calls with HttpClient (#22417) 
* replace axios calls with httpClient

* add latest files

* fix url
 2023-03-23 13:47:25 -07:00
Christopher Suh 14ea5e9dd7 fix logic (#22405) 2023-03-22 12:57:49 -07:00
Christopher Suh 20c290aa91 Better error messages from connection failures in MSAL (#22065) 
* better error messages from connection failures in MSAL\, fix typo

* cleanup

* pr comments

* rename error interface

* address pr comments

* update api

* fix typings

* change one more typing

* fix build

* fix tests
 2023-03-02 15:38:12 -08:00
Christopher SuhandCharles Gagnon b7e0bbb64a Update api to pass more detailed error messaging from azurecore (#22003) 
* update api to pass more detailed error messaging from azurecore

* fix formatting

* fix buid error

* fix pr comments

* move to azdata.proposed.d.ts

* pr comments

* Update extensions/azurecore/src/account-provider/auths/azureAuth.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* refactor

* pr comments

* Update src/sql/workbench/services/accountManagement/browser/accountManagementService.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* pr comments

* Update src/sql/azdata.proposed.d.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Update extensions/azurecore/src/account-provider/auths/azureAuth.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* fix formatting

* fix compile error

* fix compile error

* pr comments

---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
 2023-02-23 13:00:18 -08:00
Christopher Suh 6231df85e0 Handle undefined error when opening connection dialog (#21980) 
* handle undefined error when opening connection dialog

* combine into else if

* change log

* update log message
 2023-02-17 15:22:51 -08:00
Christopher Suh 7150257218 Fix Account Dialog with Multiple Providers (#21836) 
* fix uncaught error in showSplitView

* fixed bugs around account dialog with multiple providers

* cleanup

* fix index out of bounds error

* Fire account list update after removing provider, other pr fixes
 2023-02-07 15:00:47 -08:00
Christopher Suh 8f638be687 remove germany and us national clouds (#21825) 2023-02-02 16:11:04 -08:00
Christopher Suh 51da512edb Fix Cloud Endpoints (#21805) 
* replace hardcoded endpoints

* cleanup
 2023-02-01 12:32:47 -08:00
Christopher Suh 90ef8e4907 Remove duplicate account entries (#21575) 2023-01-12 12:35:16 -08:00
Christopher Suh b5d2debebb make MSAL default auth library (#21355) 2022-12-02 11:47:06 -08:00
Christopher Suh 86c3f315f2 Add MSAL Authentication Library support (#21024) 2022-11-23 14:06:44 -08:00
Christopher Suh 0bc5f68d29 Fix prompt for auth/device auth method (#21272) 2022-11-18 15:17:46 -08:00
Christopher Suh c1e90092a8 add instructions to close Developer Tools (#21227) 2022-11-14 16:25:02 -08:00
Christopher Suh e87995527b Removed localization from error messages (#21085) 
* removed localization from error messages

* use logger

* localize message displayed to user
 2022-11-02 18:17:59 -07:00
Christopher SuhIan HuffIan Huff
 		ab958a2724 quick draft PR for not throwing when looking for a chunked password (#150402) (#20956) 
* quick draft PR for not throwing when looking for a chunked password

* update comment with more info

Co-authored-by: Ian Huff <ianhuff@Ians-MacBook-Pro.local>

Co-authored-by: Ian Huff <ianhu@microsoft.com>
Co-authored-by: Ian Huff <ianhuff@Ians-MacBook-Pro.local>
 2022-10-24 17:48:06 -07:00
Christopher Suh d0cab10cc9 revert redirect uri bc it is not used by us (#20705) 2022-10-03 02:03:21 -04:00
Christopher Suh 2a3e41e821 Update redirect-uri to localhost (#20692) 
* wip

* change clientId

* change redirect-uri to localhost

* change clientId to staging env

* wip, using ppe endpoint

* management-preview

* change back management endpoint

* localhost/redirect

* wip

* route redirect

* change back to prod endpoints/clientId

* add error handling
 2022-09-30 11:59:53 -04:00
Christopher Suh 791443ddb7 Improve the tenant logging (#20688) 
* added tenant response logging

* add headers to logging

* throw error after tenant response failure
 2022-09-28 22:27:02 -07:00
Christopher Suh 1b9f4cbbae Changed add connection -> new connection (#19596) 
* changed add connection -> new connection

* remove xlf file changes

* fix spacing

* fix workspace settings
 2022-06-02 14:04:34 -07:00
Christopher Suh 8352c7631c vbump and typo fix (#19374) 2022-05-13 13:18:57 -07:00
Christopher Suh 86e0c6963f Refreshes token for intellisense (#19214) 
* wip

* wip

* wip

* working refresh token for intellisense

* pr review comments

* pr review comments

* add link

* pr comments

* change authority -> tenantId

* refactor tenant

* fix build

* add js doc comments, other pr changes

* fix error messaging

* add log

* added logs

* remove expiresOn

* fix error messaging

* pr comments

* remove localized strings from logs
 2022-05-13 09:33:14 -05:00
Christopher Suh 84001139cc Update CI to windows-2019 (#18606) 
* Revert "Update CI for new windows-latest (#18585)"

This reverts commit ebd4c6844b.

* update to windows-2019
 2022-03-01 18:26:58 -08:00
Christopher Suh ebd4c6844b Update CI for new windows-latest (#18585) 
* change to windows-2019

* fix for windows-latest
 2022-02-28 18:20:12 -08:00
Christopher Suh dfa6799fcc Add label instructions for Needs Logs - Azure (#18559) 
* added instructions for Needs Logs - Azure label

* formatting fixes
 2022-02-27 15:21:16 -08:00
Christopher Suh bafbca492b Clear account tokens before refresh (#18452) 
* clear account tokens on refresh

* update refresh button after refresh
 2022-02-17 17:25:05 -08:00
Christopher Suh cb11c2bb22 Improve verbose logging (#18147) 
* added verbose logging

* refactor logger

* added more info to logs

* add azure loggingLevel, fix logging logic, remove unused code

* fix typescript error

* mask pii data

* fix pii logging

* log tenants

* fix error function

* remove extra info and add else

* use wrapper functions for writing logs, update settings description

* change default to error, change description for pii, refactor

* fix pii logging
 2022-02-02 14:39:09 -08:00
Christopher Suh 66ebbc2181 Save & Close Fixes (#17469) 
* wip

* fixed save & close summary page

* cleanup

* pr comments
 2021-11-01 15:12:04 -07:00
Christopher Suh 95db579902 Fixes for Save & Close (#17341) 
* wip

* wip

* fixes

* cleanup

* cleanup
 2021-10-12 10:08:36 -07:00
Christopher Suh 207254fa6c Save And Close Functionality (#17000) 
* save and close

* wip

* working save and close

* cleanup

* pr changes

* pr changes

* fix capitalization

* fix build

* pr fix
 2021-09-24 14:59:35 -07:00
Christopher Suh 47b249a7b1 keytar ci build fix (#16555) 2021-08-04 11:52:45 -07:00
Christopher Suh 6d4608dd8b SQL Assessment Database Selector (#16030) 
* wip

* wip

* database selector table

* fixed db icon

* wip

* fixed assessment results table

* replaced large query

* fix build error

* updated spacing and other fixes

* removed commented code

* added search bar, fix margins, disable checkbox for offline db

* change width of checkbox column

* changed api to require databases

* Revert "changed api to require databases"

This reverts commit 20fe2d8bd223bae90dfb09609225a1781267a01d.

* removed optional flag from databases parameter

* removed icons on assessment dialog page

* formatting changes, fixed search

* bump STS

* bumped extension version number

* one excludeDbs
 2021-07-21 17:58:32 -07:00
Christopher Suh fdcb97c7f7 bump sts version (#15744) 2021-06-16 15:43:11 -07:00
Christopher Suh 448d21849b bump sts version (#15428) 2021-05-12 10:38:16 -07:00
Christopher Suh b13dc0cd03 fixed account icon loading... issue (#15335) 2021-05-05 17:10:44 -07:00
Christopher Suh 9fabf85fe2 Fix VM Page displaying MI assessment results (#15190) 
* fix vm page displaying mi assessment results

* vm page fix
 2021-04-23 12:07:17 -07:00
Christopher Suh dbcada5e30 Display "No Issues" Message (#15176) 
* wip

* no warnings screen for dbs with no warnings

* cleanup
 2021-04-19 10:01:46 -07:00
Christopher Suh fe9d3bc63b Disable checkbox for blocking migration issues (#15131) 
* disable checkbox for blocking issues

* wip

* disable checkbox fixes

* fix strings
 2021-04-17 09:03:46 -07:00
Christopher Suh 95f8c3c8b0 ADS Migration UI Fixes (#15011) 
* wip database count

* wip

* added warnings count

* changed warnings to issue details when DB selected

* updated selected dbs

* issues -> issue

* fix issues/warnings
 2021-04-07 11:07:15 -07:00
Christopher Suh 4dc3999f46 Sort Dbs by number of issues (#14961) 
* wip

* sorted dbs by number of issues
 2021-04-05 08:46:45 -07:00
Christopher Suh cb619f55c7 mi page shows prompt to select DB to see any warnings (#14921) 2021-03-30 23:19:12 -07:00
Christopher Suh 28577baa87 Assessment Progress Page (#14909) 
* wip assessment in progress page

* wip

* working assessment loader

* wip, radio cards not showing up

* working assessments in progress page

* cleanup

* bumped sqlmigration extension version

* cleanup
 2021-03-30 23:18:54 -07:00
Christopher Suh 896d0b0ea1 bump sts version (#14895) 2021-03-29 12:49:21 -07:00
Christopher Suh be9d18428f Deselect row everytime setProperties called (#14838) 
* deselect row everytime setProperties called

* added data

* changed clear to only happen if data property changed
 2021-03-23 15:40:21 -07:00
Christopher Suh 1a74d0f3d4 bumped sqltoolsservice version (#14823) 2021-03-22 11:33:11 -07:00
Christopher Suh 172f428789 Fixed formatting/bugs (#14790) 
* formatting changes & assessment title

* fixed width for description/impacted objects

* fixed formatting

* removed master, model, tempdb, and msdb

* fix warnings number

* used static variable
 2021-03-18 14:33:17 -07:00
Christopher Suh 5917f869ef Update version number for next release (#14772) 2021-03-17 14:58:51 -04:00
Christopher Suh 3d78fe02a4 Update CHANGELOG.md (#14766) 
* Update CHANGELOG.md

* Update CHANGELOG.md
 2021-03-17 13:51:15 -04:00
Christopher Suh 04d9b54c49 Updating README for March Release (#14752) 2021-03-17 13:42:26 -04:00
Christopher Suh 6389a5b0b0 Target Page Updates (#14581) 
* fixed target page links

* wip

* wip

* update target page values

* wip

* fixed number of dbs

* add vm assessment dialog
 2021-03-10 02:45:46 -05:00
Christopher Suh dbb6b71908 Assessment page changes (#14415) 
* assessment page changes

* code cleanup

* remove dead code

* fixed hardcoded value

* fix instance table bug

* Revert "fix instance table bug"

This reverts commit a924f44e64062a427c9fe4b12c0f368e78e6c04f.

* Revert "fixed hardcoded value"

This reverts commit 75661c457b6161b03c823d783fa9db97431c563f.
 2021-02-25 16:05:09 -05:00
Christopher Suh f461d2aa14 Target Page Changes (#14421) 
* target page changes

* remove SourceConfigurationPage

* fix build errors

* fixed build errors

* passing selected Dbs on to migration state model

* code cleanup

* fix build errors
 2021-02-24 20:02:36 -05:00
Christopher SuhandVasu Bhog fcd099dd64 Bumped turndown version (#14343) 
* bumped turndown

* fix WYSIWYG test

* remove comment

Co-authored-by: Vasu Bhog <vabhog@microsoft.com>
 2021-02-18 20:36:32 -05:00
Christopher Suh bc9719d5a8 Fix parentheses for firewall ip address (#13903) 
* fix parentheses for firewall ip address

* use template string
 2021-01-04 17:02:06 -05:00
Christopher Suh 36f758dfca Revert "Bump SQL Tools to 3.0.0-release.42 (#12929)" (#12946) 
This reverts commit 52e7bcdf09.
 2020-10-15 14:50:34 -07:00
Christopher SuhADS MergerKarl Burtram
 		6ff1e3866b Merge from vscode fcf3346a8e9f5ee1e00674461d9e2c2292a14ee3 (#12295) 
* Merge from vscode fcf3346a8e9f5ee1e00674461d9e2c2292a14ee3

* Fix test build break

* Update distro

* Fix build errors

* Update distro

* Update REH build file

* Update build task names for REL

* Fix product build yaml

* Fix product REH task name

* Fix type in task name

* Update linux build step

* Update windows build tasks

* Turn off server publish

* Disable REH

* Fix typo

* Bump distro

* Update vscode tests

* Bump distro

* Fix type in disto

* Bump distro

* Turn off docker build

* Remove docker step from release

Co-authored-by: ADS Merger <andresse@microsoft.com>
Co-authored-by: Karl Burtram <karlb@microsoft.com>
 2020-10-03 11:42:05 -07:00
Christopher Suh aa151b280f Added Column folder drag & drop (#11595) 
* wip

* working folder drag/drop

* helper method

* cleanup

* cleanup

* cleanup

* added view

* helper method for nodeTypeId

* made method static for access from editordroptarget

* pr changes
 2020-08-04 20:49:21 -04:00
Christopher Suh 6d77176b92 focus in editor after dropping (#11525) 2020-07-27 12:36:36 -04:00
cssuh 0833de1e7c Merge branch 'ads-main-vscode-2020-07-15T23-51-12' into main 2020-07-17 15:00:28 -04:00
Christopher Suh 48ef272c66 fix for dragged table name (#11376) 
* fix for dragged table name

* escaped bracket characters

* fixed escaping brackets

* moved outer brackets

* using interpolated strings
 2020-07-16 17:53:04 -04:00
Christopher Suh 30e8edd875 added name (#11302) 2020-07-10 18:16:01 -04:00
Christopher Suh aa4045c8a9 ServerTreeView unit tests (#11207) 
* added unit tests

* removed newlines
 2020-07-06 20:25:07 -04:00
Christopher Suh 0c56e4a603 Column/Table Drag & Drop (#10702) 
* able to drag objects from left pane

* changed scheme from file

* base functionality working

* extended functionality to tables

* added string literals and formatting

* cleanup

* cleanup

* added table/column parsing

* removed bad logic

* updated to use metadata

* cleanup and added sql carbon edit tags

* moved changes from vs into sql code base

* refactoring drag and drop

* cleanup

* cleanup

* cleanup

* added unit tests

* pr changes

* moved treeMock file

* fixed small bug
 2020-06-15 23:52:46 -04:00