Commit Graph
100 Commits
Author SHA1 Message Date
Lucy Zhang 4ab2d3f8c0 add logging (#17940) 2021-12-16 05:55:57 -08:00
Lucy Zhang 969eb16df7 Wait for all notebook models to load before shutting down active sessions during python upgrade (#17766)
* handle undefined model

* wait for kernel to load before restart

* comment

* await editor model resolved

* remove cast
2021-12-03 16:39:07 -08:00
Lucy Zhang 9b87973205 Enable add sql binding quickpick (#17790)
* enable add sql binding command

* add preview to command

* use resourceScheme instead of resourceExtname

* bump version to 0.15.0

* revert version bump
2021-12-02 12:19:11 -08:00
Lucy Zhang 3d9f54b0c0 Sql Binding: Add "Check out pane for more details" when nuget package download fails (#17680)
* check output for more details

* detail error

* wait for result from showerrormessage
2021-11-16 15:01:05 -08:00
Lucy Zhang 343e314103 SQL Binding: Give default connection setting name (#17659)
* show sqlconnectionstring in quickpick

* fix duplicate sqlconnectionstring setting

* add (new)

* add sqlconnectionstring as default setting name

* check if sqlconnectionstring already exists
2021-11-15 18:53:52 -08:00
Lucy Zhang ba92694fa3 Show connection string example for add sql binding quickpick (#17650)
* add connection string example

* reorder
2021-11-11 10:54:13 -08:00
Lucy Zhang 8c3c18e8dc decrease length of installed packages table (#17556) 2021-11-02 12:04:39 -07:00
Lucy Zhang 8212eecec7 add listener for celltype change (#17414) 2021-10-20 13:51:27 -07:00
Lucy Zhang 9a05d81215 use setContent instead of addElement (#17386) 2021-10-18 18:32:05 -07:00
Lucy Zhang e315115f00 Hide notebook toolbar icons in diff editor (#17303)
* hide notebook toolbar icons in diff editor

* move showActions to notebookInput

* make showActions readonly
2021-10-15 05:19:14 -07:00
Lucy Zhang 30e26d63a4 Increase smoke test timeout and python installation timeout (#17035)
* add screenshots

* inc time

* fix comment, remove screenshot

* increase timeout only for python test

* comment
2021-09-10 06:44:35 -07:00
Lucy Zhang 9389ec9101 increase python installation timeout to 5min (#17019) 2021-09-08 06:24:37 -07:00
Lucy Zhang 05d8ad4811 escape any open wizards after each test (#16938) 2021-08-30 14:56:28 -07:00
Lucy Zhang ea5f9091d1 add horizontal scroll bar to output (#16918) 2021-08-27 11:42:02 -07:00
Lucy Zhangandchgagnon b799d81e72 Update sqlite version for smoke tests (#16903)
* update sqlite

* bump distro

Co-authored-by: chgagnon <chgagnon@microsoft.com>
2021-08-26 10:04:50 -07:00
Lucy Zhang 78f1b3b768 take screenshot of failed test before close editor (#16876) 2021-08-25 08:19:24 -07:00
Lucy Zhang e2f9580163 take screenshot when wizard page not loaded (#16867) 2021-08-24 07:14:51 -07:00
Lucy Zhang 1aee3498bc Filter plugin: don't set columns if auto size column plugin is also on (#16833)
* don't rerender columns if autosize plugin is on

* add comments

* pr comments

* pr comments

* pr comments

* add comment
2021-08-23 08:32:30 -07:00
Lucy Zhang 8eaccff202 remove extra step (#16806) 2021-08-18 06:17:18 -07:00
Lucy Zhang 6014b17d52 increase wait time for python install location (#16784) 2021-08-16 10:58:07 -07:00
Lucy Zhang 627ffff506 Refactor auto size columns plugin (#16709)
* refactor auto size columns plugin

* clean up

* pr comments

* pr comments
2021-08-12 13:55:19 -07:00
Lucy Zhang 9f761c44c4 Add incremental grid loading option to notebooks (#16577)
* render grids incrementally

* add loading spinner

* fix loading animation

* move rendergrids to notebook editor component

* add setting for incremental grid loading

* check configuration

* just use setTimeout to queue grids

* remove extra line

* add setter/getter for isloading

* add comment
2021-08-05 13:44:26 -07:00
Lucy Zhang 7c14ec2b6d Add intellisense checks in code cell smoke test (#16362)
* check colorization and completion suggestions

* check for suggestions widget

* make selector more specific
2021-07-27 11:02:52 -07:00
Lucy Zhang 24349885d3 fix accept fn for waitForTextContent (#16449) 2021-07-27 09:15:35 -07:00
Lucy Zhang 63d4cc0e80 don't show python upgrade prompt multiple times (#16080) 2021-07-15 06:50:46 -07:00
Lucy Zhang 6c5d35eaae Check kernel dependencies when a new session is started (#16040)
* check dependencies when a new session is started

* fix test

* fix issue when kernel spec is not found
2021-07-09 12:51:21 -07:00
Lucy Zhang f8c4d332bb add height css (#16026) 2021-07-07 13:49:33 -07:00
Lucy Zhang 9ba4057a3c fix notebook icon highlights (#16009) 2021-07-06 17:50:54 -07:00
Lucy Zhang 9ac1f16cea Fix notebook toolbar when ADS screen width is decreased (#15987)
* fix toolbar when width is decreased

* remove height css
2021-07-06 11:45:46 -07:00
Lucy Zhang 7ccbe61a1a Remove old python installation after new Python is successfully downloaded (#15931)
* remove old python after new download

* remove catch
2021-06-29 08:55:41 -07:00
Lucy Zhang 5fa53c3519 clean up trust notebook smoke test (#15926) 2021-06-28 15:39:29 -07:00
Lucy Zhang 189fe762a9 remove layout call in output component init (#15905) 2021-06-28 14:48:44 -07:00
Lucy Zhang ff1a642157 Add jupyter server shutdown timeout setting (#15913)
* add jupyter server shutdown timeout setting

* no timeout if setting is 0

* set minimum value to 0
2021-06-25 15:16:32 -07:00
Lucy Zhang 0d2710341a increase jupyter server shutdown timeout (#15899) 2021-06-24 15:13:08 -07:00
Lucy Zhang c636e24d03 Add simple notebook code cell smoke test (#15870)
* simple code cell test

* change test order

* fix select all text keybinding
2021-06-22 20:31:53 -07:00
Lucy Zhang 3634110974 fix python dialog selectors (#15866) 2021-06-22 17:03:44 -07:00
Lucy Zhang 4c039f7a88 Re-enable notebook text cell smoke test (#15720)
* re-enable text cell test

* close notebook after text cell test
2021-06-16 06:20:21 -07:00
Lucy Zhang 24cd2106a1 make python installation more stable (#15719) 2021-06-15 14:08:55 -07:00
Lucy Zhang d6d2e7dc08 filter out prose-accelerator (#15633) 2021-06-08 11:48:57 -07:00
Lucy Zhang 43e8fde775 Update Python to 3.8.8 (#15278)
* update python fwlinks and remove bundle ver

* start fixing path for users with python 36

* prompt user for python version upgrade

* update python path after removing 3.6

* prompt users to upgrade and show pkg warning

* make prompt async

* remove python bundle ver from ML extension

* shutdown python 3.6 before deleting

* check useExistingPython before update prompt

* add dont ask again option

* remove 3.6 after installing 3.8

fix merge conflict

* give option to remove python36

* list user installed pip packages in warning

* create notebook to install pip packages

* update getPythonExePath method and add comments

* clean up code

* add comments

* pr comments

* add comment

* remove option to keep python36

* shutdown active servers before removing python36

* fix error removing old python w/ path change

* update to 3.8.10

* restart sessions for mac/linux
2021-05-19 15:15:07 -07:00
Lucy Zhang d820137267 remove close toast from dialogs (#15503) 2021-05-18 12:23:50 -07:00
Lucy Zhang f03a129186 skip text cell smoketest (#15411) 2021-05-11 13:45:10 -07:00
Lucy Zhang 4bc87c46a6 Fix notebook icons (#15346)
* remove width and height from nb svgs

* fix textcell toolbar icons
2021-05-06 15:58:59 -07:00
Lucy Zhang 2a354aef09 basic text cell functionality smoke test (#15195) 2021-05-06 15:53:20 -07:00
Lucy Zhang 7e1c0076ba Try to make smoke tests more stable (#15212)
* make sure dialog buttons are not disabled

* use 'enter' to close connect dialog

* retry clikcing the Connect button

* wait for dialog gone after reclicking

* pr comments + add logging

* use debug to log

* close toasts before clicking dialog buttons

* await close notification toast call

* click python wizard buttons instead of enter
2021-04-27 13:53:17 -07:00
Lucy Zhang aa315ae19f Update azuredatastudio-sqlite version (#15174)
* update ads-sqlite version

* update distro value
2021-04-16 13:49:47 -07:00
Lucy Zhang 24a425ac64 temp skip failingnb integration tests (#15087) 2021-04-09 15:57:45 -07:00
Lucy Zhang dd5adad772 Notebooks: fix save as csv/excel/json/xml (#14882)
* add getEncoding method to notebooks

* fix row 501 missing in serialization

* fix row index

* pr comment
2021-03-29 07:14:49 -07:00
Lucy Zhang bbee4a1f38 only restart server if there is an active session (#14885) 2021-03-26 15:04:08 -07:00
Lucy Zhang f59e9b5695 Notebooks: Use new Python installation after configuration change (#14765)
* start new jupyter server

* restart session working (removed extra code)

* only restart server once

* shutdown session first then stop server

* add comments remove extra lines

* add comment

* fix test

* only restart jupyter sessions

* Dispose jupytersessionmanager and create new one

* move restart server logic out of notebookmodel

* move methods to azdata proposed

* pr comment
2021-03-24 15:31:20 -07:00
Lucy Zhang 780ca84f9a Enable status bar for notebooks (#14817)
* enable status bar for notebooks

* add onCellExecutionStart event to notebook service

* fix test, change var name
2021-03-22 14:54:13 -07:00
Lucy Zhang af19f93b78 clean up sqlnotebookmanager (#14793) 2021-03-18 15:01:14 -07:00
Lucy Zhang f125b9b2c7 Notebooks: Fix callout dialog being cut off at the bottom of the document (#14579)
* add above position for callout dialog

* use if else
2021-03-05 15:23:44 -08:00
Lucy Zhang 8e07a6f239 pass in pythonexecutable when getting packages (#14550) 2021-03-04 15:26:46 -08:00
Lucy Zhang 74629c951d Notebooks: Fix pip installation not working (#14506)
* upgrade pip after python installation

* add comment

* only upgrade pip for new python installations

* reinstall pip version instead of upgrade to latest

* update comment

* get pip version through packages list
2021-03-03 17:44:45 -08:00
Lucy Zhang ab114376aa fix python wizard behavior and enable smoke test (#14433) 2021-02-26 05:04:27 -08:00
Lucy Zhang 8727a8e97a disable nb smoke tests (#14365) 2021-02-19 10:27:17 -08:00
Lucy Zhang 800cd2fa89 catch getpythonuserdir error (#14193) 2021-02-10 10:13:08 -08:00
Lucy Zhang c1bfed836b add multi_connection_mode unit test (#14195) 2021-02-08 12:14:28 -08:00
Lucy Zhang 67829af0c5 Notebooks: add multi_connection field to notebook metadata (#14097)
* add multi_connection to nb metadata

* address PR comments

* pr comments

* adsd notebookmetadatakeys object

* pr comments

* use isUUID util method
2021-02-05 13:46:31 -08:00
Lucy Zhang 667c12abdc Notebooks: Fix Notebook validation Error when opened in Jupyter (#14110)
* delete transient node for display data

* add comment
2021-01-29 14:40:02 -08:00
Lucy Zhang 068649cba4 Change configure Jupyter server steps from async to sync (#13937)
* change config steps to sync

* fix tests

* use pathexistsSync

* remove pathExistsSync call

* address PR comments
2021-01-20 15:45:54 -08:00
Lucy Zhang 8671b6aa5d Fix redo keyboard shortcut in notebook markdown (#13967)
* add cmd+y for redo

* add ctrl+shift+z for redo

* remove listener for redo when in markdown mode
2021-01-15 08:24:06 -08:00
Lucy Zhang 1ec42a082e click first element in quick input result list (#13954) 2021-01-13 10:51:22 -08:00
Lucy Zhang 569be8eb24 Add setting to customize notebook markdown preview line height (#13923)
* add md preview line height settings

* remove if condition

* listen for configuration change

* change setting description

* only change line height outside of edit mode

* set minimum line height to 1

* combine ondidchangeconfiguration callbacks
2021-01-08 14:45:26 -08:00
Lucy Zhang fae0600a46 Notebooks: add behavior checks to untrusted notebook smoke test (#13885)
* check untrusted notebook behavior

* remove skips

* check for elements after trusted nb is reopened

* move trusted element checks to notebook method

* make selector more specific
2021-01-06 07:16:35 -08:00
Lucy Zhang 57446faa1e Notebooks: Improve Jupyter server start time (#13838)
* let jupyter server find port

* add undefined to return type

* remove time log

* add test for port number

* check that match[1] exists
2020-12-21 08:03:26 -08:00
Lucy Zhang 60925aa3a9 add . as trigger character (#13811) 2020-12-16 13:36:58 -08:00
Lucy Zhang b46afde818 Log active element when notebook smoke test fails (#13724)
* add error log for active element

* fix active element selector

* await isActiveElement call

* call waitforactiveleement
2020-12-11 14:23:21 -08:00
Lucy Zhang f96fd911c1 Notebooks: Remove result set summary from saved metadata (#13616)
* remove result set summary from metadata

* remove batchId and id from celloutputmetadata

* remove extra line
2020-12-07 12:28:07 -08:00
Lucy Zhang 64dd0f0cad dont add column header in continue request (#13568) 2020-11-30 11:29:50 -08:00
Lucy Zhang 1554e51932 Add logs to smoke tests (#13533)
* add logs

* fix log option

* update log folder
2020-11-25 06:58:43 -08:00
Lucy Zhang aa30b52d03 Notebooks: Fix query results not displaying table rows (#13488)
* fix PQSQL queries not displaying rows

* comment

* change comment and fix unit test
2020-11-20 15:31:01 -08:00
Lucy Zhang c898b50b94 Remove resultSet from IDisplayResult metadata (#13450)
* remove resultSet from IDisplayResult metadata

* remove metadata from IDisplayResult
2020-11-16 17:54:09 -08:00
Lucy Zhang 32a6385fef Notebooks: Save cell connection name in cell metadata (#13208)
* save connection info in notebook metadata

* update attachTo dropdown based on saved alias

* add setting for saving connection (default=false)

* save/read cell connection name to/from metadata

* get started on toggling multi connection mode

* add activeConnection property to cell model

* add changeContext method for cell

* add comments

* add unit test for reading connection name

* save connection mode in metadata

* clean up code

* address PR comments
2020-11-12 10:44:34 -08:00
Lucy Zhang 07df54ee61 Notebook: Add smoke test for trusted notebooks (#13330)
* add smoke test for trusted notebooks

* change repo

* update trustNotebook method

* pr comment
2020-11-12 06:45:20 -08:00
Lucy Zhang b397150264 Notebooks: Add smoke test (#13196)
* add new smoketest

* change repro

* rename methods

* add waitforallresults method

* pr comment
2020-11-10 17:31:17 -08:00
Lucy Zhang 7bdb7c328a add unit test for data conversion (#13190) 2020-11-03 15:05:57 -08:00
Lucy Zhang 69527f91b0 Notebooks: Save connection information in metadata (#13060)
* save connection info in notebook metadata

* update attachTo dropdown based on saved alias

* add setting for saving connection (default=false)

* dont show saved conn if seting off + added test

* show conn dialog if save conn name setting off

* address PR comments and fix unit test

* change connectionName to connection_name
2020-10-30 13:56:33 -07:00
Lucy Zhang 86357b45b0 Notebooks: re-factor grid streaming (#12937)
* refactor grid streaming (convert to data first)

* change convertRowsToHtml method to return value

* remove griddataconversioncomplete checks

* send row data from STS to gridoutput component

* clean up code

* send data updates to cell model

* serialize cell output at the end of cell execution

* remove unused parameters

* update output contents instead of output reference

* remove unnecessary promise

* move azdata changes to proposed

* update comment
2020-10-28 09:08:15 -07:00
Lucy Zhang bed70ebd09 Re-enable notebook smoke test and increase timeout (#13007) 2020-10-21 07:57:45 -07:00
Lucy Zhang eb36a275a2 increase wait time for python installation (#12993) 2020-10-19 13:36:24 -07:00
Lucy Zhang 767465edbf wait for kernel change before running cell (#12949) 2020-10-16 09:59:03 -07:00
Lucy Zhang 7bc26cc493 Add simple notebook smoke test (#12898)
* add simple notebook smoke test

* add id for notebook dropdown elements
2020-10-14 05:58:32 -07:00
Lucy Zhang b910bf2f33 Notebooks: Fix strict compile errors (#12591)
* strict compile for sqlSessionManager.ts

* start clientSession.ts fixes

* strict compile for clientSession.ts

* strict compile for notebookModel.ts

* add display name

* clean up code

* clean up code

* initialize string to empty string

* address PR comments

* address PR comments

* address PR comments

* remove errorMessage check
2020-10-08 15:39:57 -07:00
Lucy Zhang cf9754f627 revert grid streaming changes (#12650) 2020-09-28 18:34:58 -07:00
Lucy Zhang 56c989ac7b Fix notebook toolbar screen reader reading order (#12252)
* add presentation role to selectContainer

* make nb toolbar dropdown arrow unfocusable

* remove empty string content change
2020-09-25 12:49:42 -07:00
Lucy Zhang f8eb203643 add event.preventDefault() (#12564) 2020-09-23 07:10:36 -07:00
Lucy Zhang 3fd92adf78 Add test for notebook result grid streaming (#12539)
* start testing convertAllData

* add test for convertAllData method

* clean up code
2020-09-22 12:15:33 -07:00
Lucy Zhang d00f94f51c update resultSet in data provider (#12478) 2020-09-18 16:41:41 -07:00
Lucy Zhang 945e04ed92 Fix notebook table rendering with multiple code cells (#12363)
* create unique query runner for each cell

* use cellUri instead of cellId to identify runner

* disconnect each query runner connection

* remove queryrunners size check
2020-09-17 09:44:10 -07:00
Lucy Zhang 0be5f67621 Fix notebook cancel query bug (#12300)
* fix undefined query runner error

* store connection id

* revert sqlSessionManager change
2020-09-15 11:31:31 -07:00
Lucy Zhang f99adf3de4 Notebooks: Hide link and image buttons in text cell toolbar in WYSIWYG mode (#12240)
* hide link and image buttons in WYSIWYG mode

* defined taskbar actions

* rename arrays
2020-09-11 15:55:06 -07:00
Lucy Zhang e3ec6bf9c5 Add grid streaming support for notebooks (#12175)
* add onResultUpdate handler in gridoutput

* convert rows to mimetype and html

* wait for data conversion to finish before saving

* detach changeRef after output is created

* fix save grid action

* move data conversion check to each cell

* move conversion logic to dataprovider

* notify data converting when user saves

* add comments and remove unused methods

* fix method return type

* fix tests

* fix convertData method header

* move azdata changes to azdata proposed

* address PR comments

* display top rows message

* fix messages/table ordering and query 100 rows

* add missing escape import

* set default max rows to 5000

* add undefined check to updateResultSet

* change gridDataConversionComplete return type
2020-09-10 13:31:40 -07:00
Lucy Zhang bfe694763b Add tests for Jupyter Session (#12053)
* add tests for Jupyter Session

* remove comment and fix description

* throw error if spark kernel provider is not mssql

* use localize strings and add pythonEnvVarPath test
2020-09-02 11:44:15 -07:00
Lucy Zhang a3121c0b2d Add tests for Jupyter Session (#11961)
* add tests for config kernel and connection

* move sinon.restore and fix config filepath
2020-08-25 18:59:53 -07:00
Lucy Zhang 69a96a7d5d Adding tests for DataResourceDataProvider (#11743)
* tests for getRow method

* use suiteSetup

* added more tests

* revert changes to gridOutput.component.ts

* mocked out services for DataResourceDataProvider

* add test for serializeResults

* change path to fsPath

* fix param type and use fs promises

* use async in startSerialization

* mock ContextService
2020-08-19 17:08:27 -07:00
Lucy Zhang fefb47da83 change notebook grid actions orientation to horizontal (#11870)
* change actions orientation to horizontal

* add missing import
2020-08-19 14:42:06 -07:00
Lucy Zhang b16c6f3faa update sqltoolsservice version (#11843) 2020-08-18 09:41:07 -07:00
Lucy Zhang 1e00898105 change wizard title to heading 2 (#11711) 2020-08-07 13:37:53 -07:00