Commit Graph

756 Commits

Author SHA1 Message Date
Karl Burtram
62a519cab5 Enable docker container support in VSO integration tests (#590)
* Add container scripts for VSO builds

* Remove relative path from kubectl.exe

* Use a variable and iex for kubectl path

* Use envvar for working dir path

* Try agent directory

* Update kubeconfig path

* Write connection settings json in build script

* Output logging

* remove _work prefix

* End end point instead of service name

* Disable failing tests

* Change service name prefix so it's different than SSMS containers
2018-03-15 12:48:39 -07:00
Matt Irvine
365fe2282e Support Object Explorer FindNodes request (#589) 2018-03-15 10:47:52 -07:00
Karl Burtram
d36efb578c Disabling test that has failed in the CI builds on-and-off the past few weeks (#588) 2018-03-13 10:11:14 -07:00
Matt Irvine
0eaf60c93a Detect system connection for OE if database display name is blank (#583) 2018-02-12 11:13:03 -08:00
Leila Lali
c40c740a73 fixed the bug with loading default constraints in oe (#582)
* fixed the bug with loading default constraints in oe
2018-02-09 08:51:41 -08:00
Leila Lali
fc4282b701 fixed the issue with defualt values for options not loaded correctly (#581) 2018-02-06 20:23:23 -05:00
Matt Irvine
efd38be0be Use requested database when determining if a connection is a system db connection (#580) 2018-02-06 15:19:18 -08:00
Karl Burtram
f18c63940e Fix test build break (#579) 2018-02-01 19:00:06 -05:00
Karl Burtram
0121531bf6 Bugs fixes so XEvent profiler isn't broken (#577)
* Fix a few issues with profiler method handlers

* Filter out profiler polling events

* Add a unit test for profiler events

* Add method comment headers
2018-01-17 18:21:40 -08:00
Anthony Dresser
7b1a88f842 updates backup and restore to have their own prefix, not use diasasterrecovery (#573) 2018-01-16 14:03:35 -08:00
Benjamin Russell
b7cffa3194 Edit Data: Fix to work with tables with triggers (#576)
* Moving logic for adding default values to new rows

* Fixing implementation of script generation to handle default values all around

* Unit tests!

* WIP

* Reworking row create script/command generation to work more cleanly and work on triggered tables

* Addressing some bugs with the create row implementation

* Implementing the trigger table fix for row updates
Some small improvements to the create/update tests.
2018-01-10 14:02:07 -08:00
Leila Lali
4d4e0b1194 The filter for the function is valid for all sql version except for DW (#574) 2018-01-08 09:34:44 -08:00
Matt Irvine
104c484f3a Fix old localization targets (#572) 2018-01-02 17:01:00 -05:00
Leila Lali
0ccc01eda9 fixed a bug with OE connection changed the db name and blocked restore (#570) 2018-01-02 10:57:37 -08:00
Matt Irvine
1c2b44fe74 Mark database OE nodes as leaf nodes if they are unavailable (#569) 2017-12-13 10:58:23 -08:00
Leila Lali
eacc0111f0 Added functions to metadata list result (#568)
* added functions to be included in metadata list result
2017-12-11 15:20:36 -08:00
Leila Lali
dedca05721 fixed the keys filter to support 2012 and 2014 also (#565)
* fixed the keys filter to support 2 all sql versions also
2017-12-11 10:34:26 -08:00
Kevin Cunnane
392325036e Fix uplevel SQL Server support and differentiate External and FileTable types in object explorer list (#567)
* Differentiate External and FileTable types in object explorer list
- Add (External) and (File Table) to the labels
- Pre-fetch these properties to avoid perf hit

Note on testing: These are both quite hard to initialize, so adding tests to the integration tests would require always having a server with Polybase enabled / FileTable enabled. Given this I feel it should be OK to use manual testing. Long term, we should have unit-level tests that cover the functionality or figure out how to have a perfect pre-configured server and a set of tests to run the breadth of this logic against it.

* Fix handling of vNext servers to default to latest known version
- Default uplevel / unknown versions to the latest version
- In the IsValidFor check also just see if the server version registers as "All" since this is the default for unknown servers. This is a backup handler, the 1st fix is the primary one
2017-12-08 17:52:49 -08:00
Kevin Cunnane
b51608f022 Fix batch parse failure message to give clear description of what failed (#566) 2017-12-08 16:12:27 -08:00
Leila Lali
d20215cb19 added script as alter (#564)
* added script as alter
2017-12-07 12:49:38 -08:00
Monasr
4dd30c5341 check in latest localized XLIFF for December update (#561) 2017-12-06 17:28:22 -08:00
Anthony Dresser
8b148090fd fix edge case for single batch multi line (#540) 2017-12-06 16:28:07 -08:00
Matt Irvine
90611034cf Disable flaky test (#559) 2017-12-06 16:10:41 -08:00
Benjamin Russell
64133d929e Edit Data: Better Formatting Errors (#562)
* Refactoring sql script formatting helpers into To and From helpers

* Updates to make error messages for formatting errors more useful

* Fixing dumb breaks in unit tests

* Addressing comments from PR

* Updates to the SR files...
2017-12-05 17:00:13 -08:00
Leila Lali
e7b76a6dec Feature/script execute (#563)
* added script as execute for stored procedures
2017-12-05 13:17:51 -08:00
Leila Lali
6f32221496 fixed the issue with scripting a view with trigger in dw database (#554) 2017-12-01 14:50:14 -08:00
Leila Lali
1ec297efe2 improving OE tables expand (#555)
* improving OE tables expand for dw database
2017-12-01 14:49:42 -08:00
Leila Lali
ab332cba9b using existing connection for scripting as operation (#556)
* using connection binding queue for scripting to be able to use existing connection
2017-12-01 14:34:09 -08:00
Leila Lali
864c4f60cd Adding Indexes of all types to OE indexes folder (#557) 2017-12-01 13:40:21 -08:00
Matt Irvine
4174d5acaf Work around URI parsing issue for Windows drives (#558) 2017-11-29 12:22:03 -08:00
Benjamin Russell
2190039df2 Edit Data: Create Row with Nullable Columns (#553)
* WIP

* All the new RowCreate tests are working

* Fixing a couple bugs with the row delete and row update tests

* Regenerating localization files

* Fixing multiple iteration in tests
2017-11-28 14:59:48 -08:00
Aditya Bist
bc8aef6a15 fixed sproc failing peek definition (#550)
* fixed sproc failing peek definition

* changed commented out tests for peek definition
2017-11-27 15:08:22 -08:00
Leila Lali
530b66fc54 Adding new handler for script as requests (#552)
* added new scripting handler for script as request
*change the language service to get the peek definition using scripting as operatin
2017-11-27 15:04:17 -08:00
Kevin Cunnane
b8e46ce65f Support GO N syntax to execute multiple times (#551)
* Support `GO N` syntax to execute multiple times
- Plumbed through the batch execution count from the parser and used in the batch execution code path
- Functionality matches SSMS:
  - Outputs loop start/end messages that match SSMS if you're doing multi-batch execution
  - Outputs an "ignoring failure" error if an error happens during a batch
- Added tests for this
- Manually verified end to end also

* Fixing test error
2017-11-22 11:33:19 -08:00
Kevin Cunnane
42ee96f99f Fix Ops Studio issue 97 where query connection is dropped (#549)
- Fixes https://github.com/Microsoft/sqlopsstudio/issues/97.
- This should fix the bulk of the issues reported by users since it's the 1st use of this connection in the query code path.
- Implemented the fix in the connection service. This will always open a connection when calling `GetOrOpenConnection`. I cannot see a reason why the connection returned from this should ever be closed.
- resolve issues in both this code path and the edit data code path since both use this method.
2017-11-21 14:46:20 -08:00
Monasr
c512d53caa Loc checkin for November update (#548) 2017-11-20 15:14:32 -08:00
Benjamin Russell
d7080eb07e Edit Data: Fixing Defaults Behavior (#533)
* Moving logic for adding default values to new rows

* Fixing implementation of script generation to handle default values all around

* Unit tests!

* Addressing PR comments
2017-11-20 14:14:41 -08:00
Leila Lali
7a3baf6620 loading database status for all databases in the server to fix the perf issue (#547) 2017-11-15 15:46:53 -08:00
Leila Lali
4bcf181787 fixing a restore bug - relocating db files of a windows server db in mac (#546)
* fixed the bug with relocating db files in mac
2017-11-15 10:28:16 -08:00
Leila Lali
ba359e7a68 fix the file path with the wrong path separator (#545)
* fix the file path with the wrong path separator

* fixed a typo
2017-11-06 12:12:52 -08:00
Leila Lali
3bb86af10b Fix/scripting server name (#543)
* binding queue should not throw excpetion if fails to connect

* getting the server name using the server connection

* removed extra comment
2017-11-02 15:39:38 -07:00
Leila Lali
54c29f20a6 binding queue should not throw excpetion if fails to connect (#542) 2017-11-02 10:53:18 -07:00
Leila Lali
17e7ddd66f handling database info and metadata request async (#541) 2017-11-01 10:58:47 -07:00
Kate Shin
93ec9864f6 remove unused metadata queries from backup (#538) 2017-11-01 10:55:17 -07:00
Kevin Cunnane
185978eb80 Fix empty result set error handling and metadata service returning correct type name (#535)
- HandleSimpleExecuteRequest now handles the case where no rows are in a result by cleanly returning a success message but with no rows included. This is handled in the front-end instead and goes through the standard path (with a clean explanation message) instead of showing a `error: no results to return`
- MetadataService was always meant to include the type name in the return result, as otherwise the front end has to guess. In order to fix a bug where this resulted in scripting based on the metadata failing (as front-end used `Procedure` instead of `StoredProcedure`), I'm returning the data here. I'll have a matching front end fix but this is overall a good solution to have.
2017-10-30 11:36:46 -07:00
Matt Irvine
f711aaea5b Fix typo in docs/design/index.md (#536) 2017-10-30 10:57:29 -07:00
Aditya Bist
10cb78b712 listDatabases now shows online databases only (#534) 2017-10-27 16:10:38 -07:00
Leila Lali
a2a392938e fixed a typo (#532) 2017-10-27 11:00:39 -07:00
Karl Burtram
7ccf78aec1 Add group id and db display name to OE connection queue key (#531) 2017-10-26 10:56:22 -07:00
Saurabh Singh
4c329921c7 Update smo (#530)
* update the version in CSPROJ

* Add the updated SMO package
2017-10-26 10:55:04 -07:00