* Extension unit tests continue on error
* Fix script syntax issue.
* Block syntax issue
* Remove condition expression
* Brings back condition for sql product build linux yml
* Comment out condition in ci.yml
* Adds continue on error clause to ci.yml extension unit tests
* Adds condition to extension unit tests step in ci.yml
* Adds run extension unit test case for fail on error
* Adds fail on error case to Run Extension Unit Tests script
* Explicitly states continue on error false.
* Format adjustment to yml file
* Changes default state to fail on error
* Update .github/workflows/ci.yml
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Update build/azure-pipelines/linux/sql-product-build-linux.yml
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Update build/azure-pipelines/linux/sql-product-build-linux.yml
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Brings back original comment.
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Adding column resize keyboard shortcuts in slickgrid
* Switching to standard keyboard evt
* Adding comment for the functionality
* Cleaning up code and adding more comments
* Using quick input to get column resize width
* Adding check for negative sizes
* Fixing some stuff
* added loading status to tree elements during refresh
* added message
* added lambda function
* added async
* moved addtraits to below null check
* Added debug lines for now
* added wip stack
* moved loading icon logic to inside tree item code
* added dispose logic
* Added comment explaining actions
* removed reference to NodeJs Timeout
* added showLoading status to Tree creation utils
* fixed spaces
* removed unnecessary space
* removed unnecessary timer for more responsive results
* removed call in connectionTreeActions test
* added fix to test
* stick to refresh only
* added 100 ms timeout
* added request comment
* Add TrustServerCertificate to request body
* Preselect all dbs for migration
* Make disabled checkbox not auto selected
* Clarify assessment results in card
* Fix incorrect number of dbs ready for migration without issues to MI
* Fix SQL DB assessment results incorrectly greying out dbs with MI blocking issues
* Revert "Clarify assessment results in card"
This reverts commit e8b83f3c19a20ba29133aaa68c4644b04d4154fe.
* Revert "Fix incorrect number of dbs ready for migration without issues to MI"
This reverts commit d4e10875d132dd218d95be91ae7d46672e247706.
* Revert "Fix SQL DB assessment results incorrectly greying out dbs with MI blocking issues"
This reverts commit e2a7dcd7352d1c215052a2f6f3f6130fc710eff8.
* Add new fields
* Fix null reference exception in SKU rec with save and close
* Remove unused files
* Warnings for in progress migrations in list view
* Fix unscrollable assessment results
* Fix updating SKU parameters before recommendations are ready
* Remove checksum info box
* Address PR feedback
* Update test naming convention from Electron to Core to avoid confusions
* Added comments
* Fix comment placement
* Remove CARBON EDIT from sql-* files
* Give saveAsExcel its own config options
* Wired up correctly
* Merge conflicts
* PR comments 1
Co-authored-by: Ben Russell <russellben@microsoft.com>
* add import permissions option to create project from db dialog
* change 'import' to 'include'
* update azdata dependency version
* update STS to 4.3.0.37
* fix test
* Adds context menu option placeholder plan container
* Adds context menu and button to add execution plan to placeholder
* Minor clean up
* Replaces taskbar with button to add execution plans
* Removes unneeded CSS styling.
* Adjusts button type to secondary
* Clarify assessment results in card
* Fix incorrect number of dbs ready for migration without issues to MI
* Fix SQL DB assessment results incorrectly greying out dbs with MI blocking issues
* Update error banner for blocked databases
* Reword error message
* Boilerplate for new context menu options
* Enables checkmarks for expensive operator context menu actions
* Updates azdataGraph version to 0.0.44
* Adds clearing logic to actions and retrieves additional info from nodes
* Removes unnecessary actions that aren't supported by other providers
* Finishes setting up the rest of the context menu actions
* Corrects context menu action label
* Defines new widget type for finding expensive operations
* Adds TODO for class icon name
* Creates action to open the expensive operation widget
* Adds escape and enter key shortcuts to findExpensiveOperation widget
* Styles find expensive operation widget
* Corrects class name for finding expensive operator action
* Corrects import statement.
* Code clean up
* Bumps azdataGraph version to 0.0.45
* Adds an info box for when a metric doesn't find any nodes
* Adds label to find expensive operator widget
* Invokes dispose when widget controller removes widget
* Implements disposable in all execution plan widgets.
* Adds off action to clear highlighting
* Adds a default setting and default prompt for highlighting metric
* Fixes not all code paths return error
* Removes shortcut key from text for widget actions
* Adds enum description
* Removes added dictionary type, and renames class name
* Removes unnecessary null checks
* Removes cost metric dictionary and adds corresponding properties
* Code review changes
* Removes incorrectly implemented key down event for widget.
* Renames widget and action class names for highlighting expensive ops
* File rename
* Cleans up labels to better reflect highlight action
* Removes hardcoded button width style and sets it to auto
* More clean up
* Clean up import statement
* Code review changes
* Drop down list only shows available metrics
* Updates highlight expensive operation icon
* Update STS version
* initial
* Fix and revert secret storage changes
* persist to file
* Add debounce and write on dispose
* Fix run
* No ext dependencies and show warning message
* Remove test stuff
* comments
* Fix tests and console logs
* allow mark tests as unstable
* fix
* fix invert
* stable and whole test suite
* docs and mark test cases as unstable
* a couple more unstable test cases
* Fixes incorrect label when plans are vertical
* Code review changes.
* Adds helper methods to get localized strings
* Helper functions moved to module level
* Renames fields from top and bottom to primary and secondary
* Set target platform for mssql vscode extension- create project from db feature
* Addressed comments
* Address comment to add EngineEdition information in vscode-mssql.d.ts
* add logging for data workspace extension
* Addressing comments
* adding back getProjectsInWorkspace() in constructor
* Add more logging in activate()
* Added username field to PG and removed defaultvalue for port
* Disabled system username for miaa. Added username to pg create notebook.
* Block system for pg username
* Remove sql username from pg create
* Add service type
* bump version for preview
* Add dev use label
* Changed postgres icon
* Fixed PG create page not displaying. Wrong type
* Fixed service type
* changed naming for admin usernames sql and pg
* sql and pg dev use fix
* Move port under service type and make storage class not required
* Fixed regex to include things like sa1 system1
* Made storage class params optional
* Added placeholder text and changed PG admin username label
* Remove backups
* Removed postgres hardcoded username in connectionstring
* Remove more postgres username hardcoded
Co-authored-by: Candice Ye <canye@microsoft.com>
* fixing icons for new ledger object SubTypes
* removing irrelevant context menu options from ledger objects in OE
* aligning LedgerDropped subtype context key specifically with the Table NodeType context key
* download Microsoft.Build.Sql sdk and extract
* cleanup extracted folder and nuget
* add constants
* cleanup
* remove package-lock.json
* making outputChannel required and some cleanup
* only download if the files aren't already there
* Add todo
* add try catches
* addressing comments
* WIP - show error message for failed SKU recommendation
* WIP - run query to get correct instance name
* WIP - integrate elastic model recommendation
* Remove private endpoint restriction text
* Add feature switch for elastic recommendation
* Clean up
* Clean up
* Misc UI fixes
* Update package.json with updated azdata dependency
* Remove unused lines
* Fix broken next button
* Vbump extension to 1.0.6
* Update SQL DB card to show number of recommendations for correct model
* Hard code enginer ver to 14 and remove extension from wizard field and notebook
* Removed hyperscale text from everywhere but links
* Made PostgreSQL into PostgreSQL server and other text changes. Removed worker nodes
* Removed coordinator node text
* Removed worker nodes from compute + storage. Changed az arc-server to server-arc. postgresParameters.ts may need
* Removed tabs for extensions, coord nodes, worker nodes, resource health, diagnose and solve
* Removed node configuation and pg version from overview and properties. Edited arialabels
* Change server group nodes to server
* Removed type from overview table and aded Preview tags
* Removed info bubble and added padding to top of title
* Removed checkbox from PG create wizard. Added link and text
* Remove engine version
* Changed naming conventions
* Removed coord and server group from variables
* Removed properties
* Removed Server table, admin username, reset password
* Removed function from notebook
* Change wording
* bump version
Co-authored-by: Candice Ye <canye@microsoft.com>
* Revert "Revert "Fix sql projects not using OutputPath in sqlproj for publishing (#19987)" (#20127)"
This reverts commit dc7522c661.
* read configuration from sqlproj
* Add more tests
* use last OutputPath in sqlproj
* Remove references to getProviderMetadataForAccount
* Fix broken next button
* Clean up
* Adding to other PR instead - Revert "Clean up"
This reverts commit 410e136c0d1dcc24b38697791801fe3b90b1ecd4.
* Adding to other PR instead - Revert "Fix broken next button"
This reverts commit 748f75daf1594694e618f946c8026cb3256c58a9.
* sql db wizard with target selection
* add database table selection
* add sqldb to service and IR page
* Code complete
* navigation bug fixes
* fix target db selection
* improve sqldb error and status reporting
* fix error count bug
* remove table status inference
* address review feedback
* update resource strings and content
* fix migraton status string, use localized value
* fix ux navigation issues
* fix back/fwd w/o changes from changing data
* Add correct host to ARM REST API calls
* Clean up
* Missed a spot
* One more comment
* Expose new function getProviderMetadataForAccount in azurecore API
* Adding a loader spinner before the options load
* removing the local var and using const
* Reducing delay between button click and loader visibility,
* Max for syncsecondary. Fix syncsecondary update.
* Update the value not the placeholder for SQL MIAA
* Disable save toolbar icon after save/update complete
Co-authored-by: Candice Ye <canye@microsoft.com>
* Re-enabled config for direct mode
* Changed name and placement
* Shortened description
* Remove pg and sql as categories for DC
Co-authored-by: Candice Ye <canye@microsoft.com>
* Include Object Types logic refactored and options fetching from DacFx
* Removed localized object types constants
* Prop name updated and references and tests updated
* updated comments
* STS vBump
* updating the test file to pass the PR Validations
* Include Objects Coming from DacFx and tests all working as expected
* Exclude Object types functionality is working as expected and Unit tests
* more refactor updates
* Updated comments and prop name
* Addressing the coments and code updates accordingly
* Updating according to the comments
* STS vbump
* These changes should be deleted with SC changes, not here
* format fixed
* options loading from profile if has profile loaded
* Removing profile file unwanted changes
* updating profiles options comment
* STS vBump
* revert STS version from this PR
* Made SQL MIAA a new tile from New Deployment
* Remove MIAA from SQL tile. Fix helptext for MIAA tile.
* Switched positions of sql miaa and pg tiles. Made New Instance have miaa instead of sql tile.
Co-authored-by: Candice Ye <canye@microsoft.com>
* refresh does not differentiate direct vs indirect
* For direct mode MIAA commands, always use --use-k8s
* Changed comment language to use ARM instead of direct and K8S API instead of indirect
Co-authored-by: Candice Ye <canye@microsoft.com>
* Adds find node button to comparison plans.
* Can search multiple nodes (improve widget UI and initialization)
* Adjusts how second plan is added to the node search widget
* Adds styling to the find node action bar
* Removes unused code
* Minor clean up
* Cleans up CSS redundancy
* Adjusts property names according to access specifiers
* Corrects find node behavior to match SSMS
* Dependency injects instantiation service
* Adds additional property to telemetry event.
* Adds undefined to getter return signatures for plans
* Adds checks around active execution plan properties
* Code review change
* Code review changes
* dropdown not supporting dynamic enablement
* paused for weekend
* Make connection mode display with capitalization but value lowercase
* Undo changes in modelviewutils
Co-authored-by: Candice Ye <canye@microsoft.com>
* If no agreements item, then do not generate an Accept Terms of Use title. Remove sql miaa agreement.
* Added back the arc-specific change
* Added back nls
Co-authored-by: Candice Ye <canye@microsoft.com>
* Update azdataGraph version to 0.0.31
* Adds icons
* Bumps azdataGraph version to 0.0.32
* Removes whitespace
* Uses icon that better adapts to color theme changes.
* Disables collapse for execution plans in plan comparison editor view
* Made kube config and context dependent on direct mode
* Make config profile a dropdown
* Re enabled config profile
Co-authored-by: Candice Ye <canye@microsoft.com>
* OptionsDialog and buttons CSS styling updates
* final css changes for sql db options tab
* modified options button into itmes list
* updated tab name
* Added removed line git blame
* OptionsMapTable logic to replace the deployment hardcoded values final
* Test modifiaction
* OptionsMApTable updates with STS and review commetns
* comments added and option string moved to constants file
* Reverting the options button css related change and will put in other PR
* converted optionsMapTable to custom type and references.
* Options prop changes and model updates
* Reset btn event method name fixed
* removed local booleanOptionDict var and using the existing one
* updated code with removed local vars
* Update to booleanOptionsDictionary name
* merged two variable to one
* Refactoring code and updating variables
* separated lookup and data array and refactor
* missing visibility
* reset logic revised and no other edgecases found
* variable names updated to meaningful
* vbump here to test the checks, sending new vbump PR separately
* Updates properties view title when the orientation changes
* Property orientation labels change when the plan orientation changes.
* Renames top and bottom containers to secondary and primary
* Minor clean up
* Removes unnecessary class members
* Promotes constants to module level
* Moves function to module level
* Renames value1 and value2 to primary and secondary
* Replaces orientation string literal type with enum
* Resolves undefined orientation bug
* Removes unused orientation getter
* Updates property table columns only
* Uses orientation enum in editor view and properties view
* Clean up
* Adding top operations to execution plans
* Adding title to links
* Fixing pr comments
* Hiding top operations icon in execution plan editor
* Reducing outline width, adding separator and removing placeholder text
* Registering TopOperationsTabView
* Added label description for RWX storage class
* Added link and description above backups
* Made field have no default value by making it plain textfield
* Made label width wider to accomodate long labels
* Better spacing for RWX. Fixed info bubble overlap
Co-authored-by: Candice Ye <canye@microsoft.com>
* Switch query events to just send ranges instead of full query text
* undo azdata changes
* fix type
* comment + remove unneeded ?
* range -> batchRanges
* undo
* Changed namespace to have empty default value. Added cluster name as a field for direct mode. Updated summary page and notebook as necessary.
* Made storage class = default if storage class is undefined
* Moved cluster name before custom location
Co-authored-by: Candice Ye <canye@microsoft.com>
* Ctrl/Cmd + m, no longer executes queries.
* Adjusts command label
* Code review changes
* Uses category parameter to categorize actual plan command
* Actual execution plan command label matches estimated plan command label
* Revert "Actual execution plan command label matches estimated plan command label"
This reverts commit 15f301dfc64341d631ca5e9b1314d8cf739b2088.
* Centralizes localized category string (#19857)
* Actual Plan action uses centralized category
Didn't notice that this had already been bumped from what was listed in the gallery (0.1.0 currently). So reverting back to 0.2.0 until after the next version is released.
* Commenting out for now, but will delete in next commit
* Adds SQL carbon edit markers
* Uses multiline comments
* Formats file
* Code review changes
* Edit comment moved to same line
* Add ts-ignore directive to unused method
* Fixing tabbing logic for tab headers
* Renaming stuff
Making null checks concise
Adding comments
* Renaming css class and interfaces from active to selected
* Renaming styling classes and objects
* Changing tabbing logic to match w3 behavior
* Fixing focus logic in tab
* Adding helper comment
* Code cleanup
* Adding arialive to flex and div container
* Fixing compilation issues
* Moving ariaLive to container properties
* fixes
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Added syncSecondaryToCommit to SQL update and create, as well as notebook, wizard, and compute+storage interfaces
* Added readable secondaries and syncSecondaryToCommit to cost and SQL MI create
* Added readable secondaries to notebook
* removed resource-deployment changes
Co-authored-by: Candice Ye <canye@microsoft.com>
* Fixed dynamic enablement
* Set to false or original logic in constructor
* Changed boolean to also undefined
* Moved comment to constructor
Co-authored-by: Candice Ye <canye@microsoft.com>
* Creates toggle button to switch between estimate and actual query plans
* Renames ID for the toggleActualExecutionPlanModeAction class
* Renames button back to explain
* Creating actual execution plans resembles SSMS
* Adds CTRL/CMD + L shortcut to display estimated execution plans
* Alphabetically organizes telemetry actions
* Adds telemetry when the setting for actual execution plan toggle is used
* Resolves build errors
* Fixes broken unit tests.
* Code review changes
* Removes unnecessary null-coalescing operator.
* Creates placeholder icons for actual execution plans enabled
* Code review changes
* Shortens label names
* Telemetry moved to toggle button
* Telemetry review changes
* Clarifies misleading label
* added filter for AsyncDataProvider Filter crash
* fixed cell switch back for editdata
* Added new setData check
* disable selecting of all columns when new row is being added
* Changed comment
* removed try catch check due to Aasim's PR
* added previous dataset to handlechange
* added feedback changes
* added fix for infinite loop
* changes made as suggested by Alan
* following Charles' feedback
* removed onGridRendered as its pointless jumping
* initilaizing the sqlproj display options work
* added more code to the options dialog, need default option values
* Except REset Button, all works and need to refactor and test
* DisplayOptions for SQL DB Proj completed, refactor needed
* Tests for display options
* refactor code and removed unnecessary await calls
* Description values getting from STS API and code refactor
* DacpacExtesnion test model error fix
* updates related to STS model updates
* Dac Deployement options model updates according to STS changes
* Undoing file updates and moving as separate PR
* Undoing vscode whitespace changes which were added accidentally
* Options display name coming from API
* Updated model with dac deploy options display names coming from the STS API
* errors fixed after merge to main
* separating model related changes after merge, separate PR exists
* wrong Comment for the test case removed
* code refactor updates
* Hyperlink changes to secondary button and style updates
* refactoring code and comments
* importing type only instead of whole azdata and comment updates
* projectcontroller test fix
* removed duplicate file updates from other PR
* code refactor according to comments
* Added dispose to the onclick handler
* Added test case
* parameter change results error and fixed
* Addressing all comments with updates
* Unused variable removed and missed with previous commit
* Updated the ppublish button and width
* Adjusted the database dropdown and options margins to make all input align in same line
* Updated the database width and moved stylings to uiconstants file
* Introduce tabs for notebook views
Cards have been restructured to contain tabs instead of cells directly.
Tabs then contain the cards that are displayed. Cards may contain one or
more cards.
The panel component has been reused to implement the cells. There is
still some cleanup left to do of unused functions, but I want to reduce
the size of the PR as much as possible.
* Adds telemetry when plan comparison is invoked
* Small formatting change.
* Adds telemetry to add execution plan button
* Removes unused ExecutionPlanComparisonEditorView constructor parameters
* Small formatting adjustment
* Adds telemetry to ExecutionPlanComparisonEditorView properties
* Code review changes
* add 'open in designer' to context menu of tables in sql projects
* fix tests
* Address comments
* enable table designer for sql database proj
* update label and issues on init
* vbump sts
* use promisified fs
* pr comments
Co-authored-by: Alan Ren <alanren@microsoft.com>
* fix page being reset twice and add back smoke test
* add missing await
* check pyarrow info loaded
* install latest package version
* fix version select box selector
* split out into two PRs
* Dac Deployement options model updates according to STS changes
* Undoing vscode whitespace changes which were added accidentally
* Updated model with dac deploy options display names coming from the STS API
* Combining all exisitng code updates into single branch/pr. it includes mssql model updates and SC/dacpac model, code and testupdates
* sql db proj test failure fix
* STS version bump to 4.0.0.4
* Adding code for execution plan comparison editor
* Handling floating promises and fixing a loc string
* Fixing some polygon stuff
* Fixing azdatagraph null check bug
* Adding progress notification for similar areas
* Removing some floating promises
* Fixing button enabled state
* Bump version of arc and azcli to 1.3.0
* Fixed refresh to do dc config show and endpoint list first, then check the connectionmode
* Await calls to refresh indirect and direct
* Made sql mi-arc delete also handle direct mode. Made customlocation for sql mi create work again, regex problem.
Co-authored-by: Candice Ye <canye@microsoft.com>
* Display cdb nodes to browse azure tree
* Update icons
* Update node label
* Remove console logs
* Fix i18n in cosmosDbMongoTreeDataProvider
* Disable Mongo provider in azure tree for now
* Revert "Disable Mongo provider in azure tree for now"
This reverts commit 8b2d2079f43624596a41b82a71a5e40eef1ad4b1.
* Fix build issues related to merge
* Add COSMOSDB_MONGO in provider extension map
* Define providerId string as constant. Rename constants to follow azurecore/ naming conventions (all caps)
* remove password enter manually - since we prompt user to include it prior
* go back to connection profile prompt
* add manual entry if connection info password is not saved
* add tests that verify all password prompt scenarios
* nit
* first wip for table menu prompt
* fix up some table prompts
* use simpleExecuteRequest
* fix table prompt scenario for sql binding also
* fix/add more testing and address comments
* add brackets to selected database
* add manually entered option
* added clickable more info links to designer validation issues
* fix selection issue
* remove more info if none
* change quote style
* clear the dom node
* format
* added buttons and initial drag plugin
* initial drag and drop working
* add actions and taskbar
* drag and drop bugfix and other changes
* fix few issues
* more changes
* fix all move and insertion issues
* PRcomments
* fit and finish comments
* remove dead code
* bump sts
* add style for object being dragged
* add plugin to copyright filter
* Add to eslintrc
* fix drag contrast ratio
* generalize logic for cell focus
* demo feedback
* feedback
* add action state
* feedback
* remove unncecessary check
* add move actions to context menu
* change to const
* fix bug with tables and fix drop color
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* Rebase from main branch
* Made mssql a module
* remove rpc specific stuff
* Added create sas RPC call
* Backup to url works now
* Moved createSas RPC to the BlobService
* Relocated createSas RPC from sql-dataprotocolclient to the mssql
* After rebase
* Removed duplicate symbol
* Renamed Blob to AzureBlob and relocated CreateSasResponse to mssql extension
* Removed AzureBlobProvider, removed AzureBlobService feature
* renamed blob to azureblob, converted thenable to promise
* Simplify API
* fixes
* docs update, blob to azureblob update
* UI design first commit
* Detected Managed Instance, trying to script backup to url
* azure subscription api added, but ADS crashes
* Created url dialog component and added link account
* Changed backup component UI logic
* Changed b/r UI, added restore from URL, detected MI from restore component
* Removed mocked and added real Azure API, changed RestoreDialog UI
* Added file fetching API
* added create sas RPC call
* Backup to url works now
* Fixed some bugs
* Moved createSas RPC to the BlobService
* Relocated createSas RPC from sql-dataprotocolclient to the mssql
* Rebase createSas changed to the backupRestoreManagedInstance
* PR comments fix
* Enabled backup to url for gov clouds
* Replaced anchor element with Link class
* Fixed pick azure account logic
* Removed duplicates from eslintrc
* Fixed url browser dialog
* Fixed restore UI, disabled url empty url browser dropdowns, fixed backup OK button
* bumped sts version
* bumped sts version
* Fix config
* Fixed URL browser dialog UX
* Backup and restore dialog fix
* Referencing azure resource types directly
* Scoped url browser dialog css classes
* Made the url browser dialog field a local variable
* moved url browser files from fileBrowser to the urlBrowser folder
* Changed deviceType from number to enum
* Added all device type options
* Moved mssql
* Added MI backup button comment
* Removed unhelpful comment
* Revert differential copy only backup mistake
* Renamed azurebrowser to urlBrowserDialog
* Localize create sas button label
* Removed unnecessary spinner
* Use UTC date instead of locale date
* Removed * and added required flag
* Use async instead of nested thens
* Added target database tooltip
* Using deferred promise instead of event emitter
* Added error handling to the url browser dialog
* Registered backup component elements
* Register backup component listeners
* Removed redundant setDefaultBackupPaths call
* Added setBackupPathList docs
* Add return types
* Remove code from comment
* Register restore dialog elements
* Register restore dialog listeners
* Pass engine edition enum instead of boolean
* Capitalize enum values
* DatabaseEngineEdition fix
* Use DeviceType instead of number
* Use deferred pointer
* Add new ModalDialogName
* Use constructor fields
* Register URL browser dialog components
* Remove unnecessary helper function
* nextYear function doc and move
* split registerListeners method
* showDialog returns promise
* Backup device type comment
* Pass aria label through constructor
* Fix backup button
* Remove comment
* Comment unsupported MI backup options
* Remove one liner helper function
* Restore dialog methods return types
* Remove comment
* JS doc format
* Renamed UrlBrowserDialog to BackupRestoreUrlBrowserDialog
* Moved MediaDeviceType, added PhisicalDeviceType
* Reorder and rename physical device type
* remove extra spaces
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* Adding ability to expand and columns tables
* Bolding icons
Fixing variable names
* Adding helper function
Making css more target
* Adding keyboard navigation and parsing treegrid data
* Adding attributes, data transformations and key events to the treegrid
* Expanded
* changing var name
* FIxing formatter name
* Adding back cell styling
* Removing comments
* Making a new TreeGrid component.
Separating treegrid logic from tableDataView
* Fixing comments
* changing method name
* Modifying only visible row dom attributes
* Removing white space, moving role attribute setter to constructor.
* Fixing some more PR comments
* Adding comments and renaming functions
* Fixing comments
* Fixing comments
* Fixing comments
* Fixing some logic and removing unused attributes from element
* Adding expandable formatter to the first column
* Making the formatter generic
* Reverting formatter code
* Adding doc comments
* Fixing comments
* Removing duplicated code
* Adding comments
* Setting columns only when the table is initialized
* Letting users set expanded state instead of forcing it to false
* Added sql upgrade management page and fixed icon for dc and sql upgrade
* Added logic for figuring out MIAA version, loading proper entries for table.
* Added PR comment changes
Co-authored-by: Candice Ye <canye@microsoft.com>
* Adds hot key combination for finding nodes in execution plans.
* Captures cmd + f key combinations for other platforms
* Stops event propagation when targeted hot key sequence is pressed
* add tab index to cell output
* add sr-only element to announce cell exe complete
* use onExecutionComplete event
* remove extra change
* simplify alert message
* add alert for cell execution start
* make sure cell is ran
* make sure dialog is gone before runing cell again
* ensure package is done installing
* show task panel
* remove comment
* pr comments
* pr comments
* add 7.0.0 package version
* Resolves cannot read property 'accessToken' of undefined.
* Checks for and specifies undefined as refreshToken return type
* Adds documentation and checks for undefined results from refreshToken
* WIP
* WIP
* WIP
* Fix location dropdown not working properly
* Clean up comments
* Switch button order in selectMigrationServiceDialog
* Vbump to 1.0.1
* Refactor to avoid duplicate API calls
* Add null checks
* Fix migration status dialog not sorting migrations properly
* Address comments, remove unnecessary code
* Address comments - separate util methods by resource type, use logError instead of console.log
* Remove unused methods
* Fix DMS creation on newly created resource group
* Fix stale account behavior
* Address comments - remove telemetry context from util method calls
* Clean up imports
* Fix dashboard service monitoring not working
* Fix null reference on database backup page, and resources not updating properly when location is changed
* Fix dashboard not auto selecting DMS after migration started
* Add null checks
* Added sqlmiaa upgrade command and params to azcli api
* Put params under args
* Removed an extra comma
Co-authored-by: Candice Ye <canye@microsoft.com>
* initial refactor
* fix projectFolder cases
* update create azure function with sql binding when no folder is opened
* corner case exit browse file
* add version since targetFramework is set to specific core tools version
* update telemetry and address comments
* use project folder instead
* fix create project from database when launched from disconnected node
* don't open dashboard
* fix tests
* update order so connection dialog opens first if can't connect
* Rebase from main branch
* Made mssql a module
* remove rpc specific stuff
* Added create sas RPC call
* Backup to url works now
* Moved createSas RPC to the BlobService
* Relocated createSas RPC from sql-dataprotocolclient to the mssql
* After rebase
* Removed duplicate symbol
* Renamed Blob to AzureBlob and relocated CreateSasResponse to mssql extension
* Removed AzureBlobProvider, removed AzureBlobService feature
* renamed blob to azureblob, converted thenable to promise
* Simplify API
* fixes
* docs update, blob to azureblob update
* bumped sts version
* Fix config
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* Removed configure retention policy link. Log errors for upgrade instead of blocking the upgrade. Changed text of version log link.
* Addressing comments on PR
Co-authored-by: Candice Ye <canye@microsoft.com>
* Fixed a connect to Server typo
* Added upgrade tab with description and title. Table is still stuck loading.
* Renamed backups to upgrades.
* Removed loading icon
* Table appearing and not stuck loading
* Saving for now to upgrade arc and azcli versions
* Added upgrade confirmation dialog, populated dummy data and added upgrade apis.
* Added parsing of versions and current version from listupgrades
* Upgrade itself not working, but added upgrade as a part of azure cli api.
* Table now populating with release dates and version numbers. Upgrade button only shows for appropriate cells. Upgrade done but no release version column.
* Changed text using PM advice
* Removed comments from controllerUpgrades.ts
* Replaced code in upgradecontroller.ts and made refresh work
* Removed one call to handleTablesUpdated
* Removed some code in upgradeControllers.ts and it still works
* removing more code for pitr refresh from upgradeController.ts
* Created and used UpgradeModel even though it is empty
* Added upgrademodel
* PR comments addressed
Co-authored-by: Candice Ye <canye@microsoft.com>
* Add sqlproj property to trace the origin of the project.
As part of the database migration process (schema conversion, in particular) we want to be able to tell when converted schemas are being built/deployed to the actual database server. Given that we rely on the SQL Database Projects ADS extension for the compilation/deployment, we don't have too many options other than updating the said extension.
The suggested approach is to make the following changes:
1) Add new property to the sqlproj file (called `DatabaseSource`), which will maintain the origin(s) of the project. The property can contain multiple values (separated by semicolon), in case same project contains objects produced by multiple sources (extract schema, convert from another database, etc.).
2) During build and deploy actions, send the well-known values from the newly added property to the telemetry. We don't want to send any random value of the property, as it may raise some privacy concerns. Instead we define a list of the well-known values that we know do not carry any personal information and send those, if they are specified.
This change adds all necessary APIs to the SQl Database projects extension which will be consumed by our migration extensions to populate new `DatabaseSource` property.
* Use `undefined` instead of `null`
Co-authored-by: Kim Santiago <kisantia@microsoft.com>
* Fix SQL Binding when creating new project
* Use sql binding templates
* fix openDialog to use select
Co-authored-by: Vasu Bhog <vabhog@microsoft.com>
* Adds telemetry around how the properties window is opened
* Adds telemetry around accessing execution plan top operations
* Adds key for viewing top operations
* Adds telemetry around using the open query button and context menu item
* Adds telemetry around execution plan zoom in, out, to fit, and custom
* Adds telemetry around searching for nodes in execution plans
* Reduces telemetry additional properties to 1.
* Code review changes
* Removes unnecessary export
* fix connectionSettingName for create azure function with sql binding
* add sql binding user enters connection string manually
* address comments + fix test
* final comments
* Adding badge icons to executionplan
* Fixing doc comment
* Fixing doc comments
* Making enum value more readable
* Changing default to undefined.
* Fixing some icon names
* Add unified col for data type deit
* remove seperate type setting cols and rename unified col to 'type'
* remove advanced type from properties window
* add description to col, idx, constraints
* nit
* bump STS to .227
* listen on focus_in of toolbar
* update styles on focus_in
* listen for active cell change on notebook componen
* add tabbing order to textcells
* remove duplicate listener
* clean up
* undo
* remove visible check from cellToolbar
* remove duplicate detectChanges on updateActiveCell
* only update active cell if it's already not
* add aria-label for accessibility
* localize the aria label
* refactor
* add cellLabel property to CellModel
* remove updateActiveCell from code component
* regression from merge fix
* set edit mode as true when focusing on cell
* moce check to model
* merge changes correctly
* update edit mode if code cell
* fixes
Co-authored-by: barbaravaldez <bavaldez@microsoft.com>
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* fix for user using command palette command
* rework if a user uses the create azure function via the command
* for now only show in vs code
* move logic to azureFunctionService + address comments
* fix command location
* address comments
* fix validateFunction
* WIP - implemented logic to show resource groups as derived from list of resources, instead of directly listing all resource groups
* Remove comments
* Remove getResourceGroupByName and craft resource group object manually instead
* Update subscription and location list when tenant is changed
* Define Azure resource types locally instead of modifying azurecore
* Add SQL VM scenario
* Split getAzureResourceGroupDropdownValues into four separate functions
* Refresh only subscription list when tenant is changed
* Create new DMS dialog should show all resource groups
* Remove unnecessary async code
* add graph icons to OE and TD
* PR comments
* change enum type
* change sub type to icon and make basic as default
* changed icontype to icon
* change default logic location
* change icon name to be more generic
* use right icons
* added graph node types from edit and publish results
* make generic property bag
* review comments
* add comment for function
* edit comment
* change name to telemetry info
* add wizard page and selected operation for dacfx wizard cancel telemetry
* update name
* send version for extract
* pass version directly into function call
* Added monitor log-analytics workspace list to az api
* Made resource group and subscription optional for logs analytics workspace list
* Added dynamic fields for workspace names, id, primary key, based on value of auto-logs checkbox
* Hooked up the newly created source provider for log analytics workspaces. Dropdown now populates all workspace names.
* Added workspaceUtils.ts for a valueprovider. Now workspace name maps to id automatically.
* Replaced promise.all with promise.resolve
* Added workspace id and primary key as env variables in the notebook
* Removed extra space in package.json
* Made getOptions more concise and put azApi definition in function.
* Changed notebook to handle new Azure CLI command with param --clustername
* add more telemetry for sql database projects
* add publishToContainer events
* send target platform when publishing
* add duration for createProjectFromDb and updateProjectFromDb
* Pushing Execution Plan Editor
* Renaming class
Handling error
* Awaiting for handlers to be registered
* Addressing some PR comments
* Fixing return type for provider
* Fixing editor id and removing unnecessary overrides
* Adding a namespace
* adding execution plan namespace
* Adding protocol comment
* Fixing if logic
* Fixing error message
* Cleaning up code
* cleanup code
* Adding help comments
* Fixing method call
* Using path.ts to get the base file name
* converting to lambda functions
* Adding comment for run action
* Fixing pr comments
* Fixing editor label
* Fixing doc comments
* Adding some more comments
* Fixign branding in comments
* add step to choose target platform in new project quickpick
* add comment
* only splice if the default target platform index isn't -1
* change 3 to 5 in comment
* Add MI ready state check and error message
* Fix a typo
* Update error message logic
* Update '(Unavailable)' prefix to be localized string
* Show error messsage when non-Ready MI is initially selected (not just on Next button)
* Update error message with appropriate casing and actionable step
* wip for refactor of mssql to sql-bindings
* remove STS dependency
* work to bring function over and setup with vscodeMsql APIs
* copy typings from vscode-mssql
* WIP
* Change instance name from machine name to full instance name returned by assessment
* Get full instance name from source connection profile instead of relying on assessment result
* Combine correct machine name with correct instance name
* Making infobox clickable
* Making it accessible
* Moving API to proposed
* Matching styling from portal
* Fixing some styling
* Moving to proposed
* Removing extra spacing
* Registering and Unregistering listeners
* Fixing listeners
* Registering emitter only once.
* Changing emitter type from undefined to void
* Adding arialabel to clickable link
* Changing property name to suit its purpose
* add ability for md + text reports
* change report type
* re add types for ads
* match fields and add enum for mimetype
* rename preview report
* update type
* rename generate report type
* fix comment
* add loadSavedInfo function in stateMachine; only open wizard if didLoadSavedInfo
* * add loadSavedInfo function in stateMachine; only open wizard if didLoadSavedInfo
* replaced savedInfo.miggrationServiceId string with sqlMigrationServer object
* selectDatbasesFromList helper function to check previously selected dbs in dbSelectorPage and sqlDatabaseTree
* * remove savedInfo references from targetSelectionPage, migrationModePage
* add selectDefaultDropdownValue helper to stateMachine to handle unify savedInfo selection logic
* add updateDropdownLoadingStatus to targetSelectionPage
* check if values exist before making api calls in statemachine
* removed savedInfo references from databaseBackupPage, integrationRuntimePage
* databaseBackupPage - targetDatabaseNames, networkShares, blobs need to rely on savedInfo as user may update the list of migrationdbs during the retry/saveAndClose
* re-add serverAssessments to savedInfo; only getAssessments if it does not exist or needs to be updated; fix networkShare type savedInfo
* rename _assessmentDbs to _databasesForAssessment; _migrationDbs to _databasesForMigration
* load blobs/networkshares savedinfo; move selectDefaultDropdownValue to utils
* fix selectDefaultDropdownValue; refreshDatabaseBackupPage when user changes target subscription or location
* protocol handler - normalize paths
* use `extUri` for normalizing paths
* :lipstick;
* Add content security policy to top level webview
This change hardens our webviews by adding a fairly restrictive csp to them. This CSP should only apply to the outer webview iframe, not to the inner iframe which is controlled by extensions
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Matt Bierner <matb@microsoft.com>
* Fixed color contrast for error message in connect a dc window.
* Remove color check for error message
* Remove more unneeded checks
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Adding telemetry for errors happening during data collection/ telemetry for sku recommendation
* log and error happended during get sku recommendation
* Resolving comments from PR https://github.com/microsoft/azuredatastudio/pull/18252. 1) Adding click and close events to dispoable collection to avoid leaks. 2) Adding readable constant for number representing minutes.
* Changes - 1) updating migration workflow strings, 2) adding more onclick events to disposable collection.
* Remove PaaS, IaaS terms from string
* Changes -
1) Renamed 'Saved assessment result' to 'saved session'.
2) Removed Title from 'saved session' page.
3) Added stop data collection on migration start.
* Initial check in for SQL migration SKU recommendation feature (#18116)
Co-authored-by: Raymond Truong <ratruong@microsoft.com>
* add TargetSelectionPage, remove AccountSelectionPage, fix saveAndClose bugs (#18092)
* update sku interfaces (#18150)
* create the skuRecommendationResultsDialog (#18151)
* add TargetSelectionPage, remove AccountSelectionPage, fix saveAndClose bugs
* create skuRecommendationResultsDialog
* Replace placeholder SKU recommendation results with actual results (#18153)
* Replace placeholder SKU recommendation results with actual backend call results
* Remove skuRecommendationExample
* Replace number fields in interfaces with correct enums, and update UI text
* add getAzureRecommendationDialog for performance collection (#18159)
* add getAzureRecommendationDialog when there are no recommendations available
* update 'get azure rec' / 'view details' link values
* add condition to check if recommendations are available
* Implement start/stop perf data collection + import perf data into new UI (#18149)
* Implement start/stop perf data collection
* add getAzureRecommendationDialog when there are no recommendations available
* update 'get azure rec' / 'view details' link values
* add condition to check if recommendations are available
* Implement import existing data + start/stop perf collection with new UI
Co-authored-by: Rachel Kim <rackim@microsoft.com>
* Expose SqlInstanceRequirements in SKU recommendation results (#18207)
* Expose SqlInstanceRequirements
* Move string literals to constants file
* Fix formatting in mssql.d.ts
* create storage properties table (#18215)
* Edit sku recommendation parameters (#18244)
* Edit sku recommendation parameters
* make _targetPercentileDropdown not editable; styling updates
* Azure recommendation section exposes data collection status and stop option (#18246)
* Edit sku recommendation parameters
* create azure recommendation details section on sku page
* Improve error handling + add auto refresh + other small changes (#18228)
* Update source properties table
* WIP - refresh perf data collection
* Add auto refresh logic
* Address comments
Co-authored-by: Rachel Kim <rackim@microsoft.com>
* Show/hide azure recommendation components based on data collection source and status (#18254)
* add refresh recommendation button; show/hide content based on perf collection status
* show/hide azure rec content based on perf data source scenarios
* add popups for start/stop; allow user to restart data collection; add perf collection to save close; add info tooltips (#18278)
* Update SKU recommendation timer logic (#18281)
* Update timer logic
* Fix misc UI bugs
* update sql migration extension readme (#18295)
* Remove empty constant, as this may have broken the build
* Fix 'save and close' behavior for SKU recommendation (#18301)
* Update timer logic
* Fix misc UI bugs
* 'WIP'
* Add logic to restore correct SKU recommendation state when reloading
* SKU UX enhancements - status info, button validations, savedInfo logic (#18320)
* add stop/inprogress status icons to perf collection status text, update restart icon
* refactor savedInfo as an interface, edit parameter recommednations are saved, add open folder inputbox validation, handle no recommendations available scenario
* fix getazureredialog bug, cleanup cold
* nit card styling
* Update recommendations whenever user changes list of databases to assess + misc clean up (#18323)
* Consolidate constants, clean up redundant functions, misc clean up
* Remove old SKU recommendation interfaces
* Update some more strings
* Telemetry events for SKU Recommendation (#18282)
* Telemetry events for SKU Recommendation
* Addressing comments -
1) fixed camel casing
2) removed extra logging to console
3) added telemetry for subid, rg, tenantid on targetselectionpage
* Resolving conflicts
* Addressing comments - 1) removing filename 2) moving all numbers to measurements.
* Resolving comment - Fixing telemetry value for tenant id.
* removing warning 'logError' is declared but its value is never read (#18333)
* Stop existing data collection when leaving and starting a new migration + update timers (#18339)
* Refresh recommendations when pressing stop data collection button
* Fix orphaned data collection when save and closing and starting a new
migration
* Revert "Refresh recommendations when pressing stop data collection button"
This reverts commit e6fb2ade8f8a41952adb81cb0ee852414dfa4ef2.
* Update timers to use production values
* Remove unused import
* address bug bash issues: add learn more link, add last refreshed time, fix vm card view detail open issue, remember last selected folder, remove strings, refactor refresh logic on sku page (#18340)
* Address comments
* Update to sqltoolsservice 3.0.0-release.204
Co-authored-by: Rachel Kim <rackim@microsoft.com>
Co-authored-by: Neetu Singh <23.neetu@gmail.com>
* Removed extra backup policy field in MIAA deploy. Re-ordered fields in MIAA deploy for parity.
* Enabled dynamic options to work with categoryvalue type objects.
* Removed defaultValue CategoryValue typing, fixed some type checks.
* Added a clarifying comment to setModelValues and removed unnecessary type from defaultValue
* Removed CategoryValue from selection
* Undo parenthesis for single type
* add new articles to help section
* Update extensions/sql-migration/src/dashboard/sqlServerDashboard.ts
* fix typo, remove link
* remove locale in links
Co-authored-by: Mohamed Kabiruddin <39162740+mokabiru@users.noreply.github.com>
* Vbumping sts to get latest qp code
* Updating azdataGraph in remote package.json
* Revert "Updating azdataGraph in remote package.json"
This reverts commit 704aa6b653b20c6bc439ba2ac46f4dcdead0128d.
* add sdk style project template
* update description and order
* add SDK style project option to create project from db dialog
* fix test
* switch to checkbox
* remove not used string
* fix test
* Changed instances of sql edit to sql update
* Updated az sql mi-arc edit to be update. Changed the params for indirect and direct mode.
* Removed preview from everywhere in arc and azcli extensions.
* Bumped version numbers for both extensions and removed preview bool in package.jsons
* rough changes for adsweb-lite
* commit id of latest quality
* fix for aria label
* distro commit id changes
* merged latest changes distro id
* python path changes + quality name change
* Hide container views/settings/panel for ADSWeb
* undo unintentional change
* No python prompt changes for tsgops-image
* distro id changed for tsgops quality name
* changed quality name to tsgops
* changed name to tsgops-image
* python address change
* unintended changes undo
* correct python installation path for tsgops
* enable preview features tsgops
* no prompt for tsgops-lite image
* revert preview feature change
* Fixes for few comments
* removed extra line
* add deleted line
* Addressed comments
* Addressed final comments
* eslint error fix
* fix
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
* added server infor and metrics for table designer
* update generate script
* pr comments
* format more files
* pr comments
* make changes to core
* remove unused imports
* add server info
* revert enum change and add publish event
* format doc
* nitpicks
* remove os version
* remove modifier from telemetry info
* remove error message
* Also reduced the number of timeouts for waiting on notebook provider descriptors, and fixed an issue with undefined cancellation tokens in vscode notebook conversion code.
* set mode explicitly to notebook
* move setMode to untitledNotebookInput
* wait until input is resolved for setMode
* invoke only when textInput is undefined
* pass the untitledTextInput in test
* add sdk style project template
* update description and order
* update template
* update template and add link
* remove ToolsVersion and xmlns from project node
* update template name to SQL Database (SDK)
* Adding initial boilerplate for qp2
* Adding feature flag in query plan 2
* Clearing show plan 2 after every run
* Adding sub tree cost
* removing unused method.
* WIP 2
* Adding properties view and relative cost to query plan
* WIP
* Add icons to ads
* Assing relative costs and prop windows
* Enabling older query plan again
* Making some PR fixes
* Some more PR related fixes
* Use MS org azdataGraph module
* Moving new properties to azdata proposed.
* Moving new class properties to proposed
* added missing doc component.
* Changing how azdatagraph package is referenced
* Removing empty lines, fixing localization keys
* Removing empty line, localizing some string
* making css classes more specific
* making some logic concise
* localizing some more strings
* Making more css classes specific
* Removing important tag from css props
* Checking if sum is greater than 0 to prevent divide by zero exceptions
* Fixed loader error in bootstrap
* Fixing query index
* -fixing image paths
-making css class more class specific by using nested selectors
Co-authored-by: kburtram <karlb@microsoft.com>
* load name and options from publihs profile for vscode publish quickpick
* fix when a publish profile doesn't have the target db name
* update condition
* simplify
* save changes
* refactoring
* update height
* Register undo redo command (#17948)
* register undo redo command
* sql-migration vbump 0.1.12 (#17955)
* fix pre/post deploy scripts getting double counted in the files for sdk style projects (#17954)
* fix pre/post deploy scripts getting double counted in the files for sdk style projects
* add test
* update comment
* vbump sql database projects to 0.15.0 (#17956)
* LEGO: check in for main to temporary branch. (#17957)
* null check before calling isDisposable (#17959)
* Updated credentials system (#17888)
* linting
* added flags
* remove testing values
* format
* format doc
* tested in linux
* remove unused interface
* comments
* review comments
* clean imports
* pr comments
* format doc
* changed promise location
* insiders december
* pr comments
* test ado change
* fix test
* comment out code for hygiene
* remove unused imports
* test creds from client only
* remove unused import
* trying enabling keytar
* trying enabling keytar
* disable in correct script
* print statements
* remove print statements
* check mock output
* add linux check
* remove print statements
* Consolidate INotebookEditOperation interfaces (#17944)
* Add redo action for split cells (#17947)
* add redo action for split cells
* Handle delete folder for SDK style sql projects (#17961)
* handle delete folder for sdk style projects
* cleanup
* compare original sqlproj contents
* remove redundant checks
* enable find in cell output when output is a data stream (#17759)
* initial changes
* add isCodeOutput and apply decorations on output
* Add extension gallery update reminder action (#17644)
* Fix extensionsGallery.json name (#17646)
* Remove galleries list action (#17648)
* multi-level table support (#17638)
* multi-level table support
* comments
* address comments
* add period to end of sentence.
* Show connection string example for add sql binding quickpick (#17650)
* add connection string example
* reorder
* Resolves same-origin-policy violation when ADS web is running in a container (#17555)
* Stops appending port to authority for web mode
* Clarifies comment
* Adds missing sql carbon edit tag
* vbump STS (#17653)
* use latest STS (#17658)
* Refactoring readProjFile() (#17637)
* move reading project parts to different helper functions
* cleanup
* remove comment
* addressing comments
* Corrects Web Build Pipeline ENOENT Error (#17656)
* Checks for successful directory creation
* Revert "Checks for successful directory creation"
This reverts commit 372409ef323f0d82e11992bc7bc33d607a7d5581.
* Checks for the existence of the logs directory before accessing.
* Adds SQL carbon edit comment
* Removing call to copy from non-existing directory.
* Removes unneeded import
* Checks for file existence before copying.
* Provides explanation for modification
* Replaces file existence check with exception handling.
* Bump tools service (#17671)
* Apply changes from Remote Database to sqlproj - mssql changes (#17655)
* update project from database
* update project from database
* update project from database
* Re-adding schemaComparePublishChanges for temporary backcompat
* Adding comment for keeping enum values in sync
* Correcting enum value
Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>
* update add file/folder for msbuild sdk style projects (#17660)
* update add file for msbuild sdk style projects
* also handle add folder
* fix comment
* fix issue reported by component governance (#17678)
* update json-schema version
* remove unused packages
* update package.json
* SQL Binding: Give default connection setting name (#17659)
* show sqlconnectionstring in quickpick
* fix duplicate sqlconnectionstring setting
* add (new)
* add sqlconnectionstring as default setting name
* check if sqlconnectionstring already exists
* Provide aria-labels for node checkboxes in the tree view. (#17676)
During accessibility testing, it was discovered that screen reader does not announce what checkboxes in the tree view represent. It was merely announcing "checkbox unchecked", so it was not clear without visuals which checkbox the focus is on.
This change sets an `aria-label` of the checkbox elements to match the label of the owning tree node. This way the announcement becomes "My Node; checkbox; unchecked". This is fine as a quick solution to the problem, but in the future we may want to consider adding additional checkbox label property to the nodes exposed by the tree provider, so that each checkbox can announce additional information, if needed.
* Respect ARIA label specified int he tree component options. (#17674)
During accessibility testing it was discovered that tree view in our wizard reads "Tree Node tree view" instead of the proper label that is specified. It turned out to be the problem with the tree component, where `ariaLabel` was hardcoded to "Tree Node", instead of the one provided in the options.
This change addresses the problem by passing through `ariaLabel` from the options object to the underlying tree control. I also removed the default `Tree Node` hardcoded label, as it didn't make much sense. This does mean that all tree-views that do not explicitly specify their aria-label will now get an empty label. I think this is better than having unrelated, unlocalized `Tree Node`.
I'm also worried about changes to the `ariaLabel` property after the component was initialized. I updated the code to propagate the value to the underlying tree view in the `setProperties` override of the tree component and hope that it will take care of it.
* Fix sql projects net6 warnings (#17673)
* fix .net 6 error showing on startup
* fix double warning
* addressing comments
* update key string
* undo adding space in net core sdk location setting (#17684)
* update names for msbuild sdk style projects (#17677)
* update names for msbuild sdk style projects
* remove msbuild from names
* update comments
* Designer: property descriptions (#17668)
* format
* added strings
* format doc
* use codicon instead
* show descriptions in property pane only
* fix ssdt string bug
* fix overflow option
* review comments
* review comments
* changes
* sts 156 vbump (#17683)
* Sql Binding: Add "Check out pane for more details" when nuget package download fails (#17680)
* check output for more details
* detail error
* wait for result from showerrormessage
* [Loc] Update to sql-database-projects and sql.xlf (#17687)
* update the vmImage for build jobs (#17689)
* update vmImage for windows build
* update tar command
* use specific macos version
* support building msbuild sdk style projects (#17675)
* support building msbuild sdk style projects
* fixes after merge
* add foreign keys and constraints (#17697)
* foreign keys and constraints
* refactoring
* fix issues
* properties pane improvements (#17700)
* [Loc] update to tabledesignercomponentinput (#17704)
* Add instructions for developing VS Code version of sql-database-projects (#17705)
* Adding UI for deploying a db proj to docker (#17495)
* code refactoring (#17706)
* Improve accessibility for wizard steps navigation (#17669)
Our extension is relying on the wizard dialog. During accessibility testing it was discovered that wizard step buttons are being reported as links by the screen reader (NVDA, JAWS). Claimed expected behavior by the tester is that they should be announced as buttons.
I discussed this issue with accessibility SMEs and they said it is perfectly fine to keep them as links. They did mention that they would probably design the UX differently from the start, but given that we already have it this way, links are fine. They did suggest to add few additional ARIA attributes to the link elements:
- `aria-current="step"` if the link is for the currently active step. This literally just announces "current step" at the end, when you focus on a link
- `aria-disabled="true"` makes it say "**unavailable**; link; *<step number>*" when in NVDA "browse" mode and move to the grayed-out link.
So this change implements the said improvements.
* bump sts version to 159 (#17709)
* LEGO: check in for main to temporary branch. (#17699)
* LEGO: check in for main to temporary branch. (#17702)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* [Loc] update to sql-database-projects (#17713)
* LEGO: check in for main to temporary branch. (#17715)
* Register additional editor overrides when adding new notebook file types (#17708)
* Also standardized file extension contributions to always start with a period, and to always do lower case string comparisons for file extensions.
* input width in designer (#17714)
* Add additional properties to wizard page navigation events (#17716)
* Fix open external not working (#17717)
* save password checkbox fix (#17718)
* save password checkbox fix
* remove code to reset the checkbox value
* allow build to continue when cache task fails (#17720)
* cache task should not fail the build
* update cachesalt
* Fix language flavor change on connection when in sqlcmd mode (#17719)
* Fix language flavor change on connection when in sqlcmd mode
* comment + fix
* LEGO: check in for main to temporary branch. (#17722)
* LEGO: check in for main to temporary branch. (#17724)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* Update one more variable name for sdk style projects (#17710)
* LEGO: check in for main to temporary branch. (#17725)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* LEGO: check in for main to temporary branch. (#17726)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* LEGO: check in for main to temporary branch. (#17730)
* Fix "unsupported version" error when adding sql binding package (#17721)
* Apply changes from remote database to sqlproj - schema-compare changes (#17679)
* update project from database
* update project from database
* Merge from main
* Removing dupe test stub
* PR feedback
* cleanup
* PR feedback
* Fixing tests, adding stubs to update sqlproj as schema compare target
* updating code comment
Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>
* [Loc] Update to schema-compare XLF (#17733)
* Enabled deployment of Azure Arc data controllers in directly connected mode (#17707)
* Added fields for connectivity mode, custom loc, auto-metrics, auto-logs, and the dynamic enablement of such fields.
* Changed the description of the data controller details page.
* Change notebook params to work for direct mode
* Added login to dc deployment notebooks
* Fixed auto upload metrics and logs true/false, separated login into another cell.
* Removed localization of indirect and direct connectivity labels.
* Fix ordering of reading sqlproj Build Includes and Removes (#17712)
* evaluate includes and removes in order in sqlproj
* fix after merge
* fix comment
* update comment
* Add resource deployment samples for (#17734)
* Update remove file for sdk style sql projects (#17688)
* add support for removing file in new style project
* fix test
* only load files, not whole project when checking if a <Build Remove> needs to be added
* merge changes
* fixes after merge
* [Loc] update to Arc XLF (#17737)
* Bump to latest version of azdata (#17735)
* Remove .net 6 version cutoff for building sql projects (#17736)
* remove .net 6 version cutoff for building sql projects
* Revert "Warning when .NET 6 SDK is detected (#17422)"
This reverts commit 2ed8aeb565.
* add back skipVersionSupportedCheck
* add back return false
* addressing comments
* [Loc] update to sql-database-projects xlf (#17743)
* Add additional notebook tests for handling relative links. (#17739)
* [Loc] Fix for duplicate strings in LCL files (#17756)
* WIP spanish lcl duplicate removal
* Revert "WIP spanish lcl duplicate removal"
This reverts commit 5f943153ec8980849a045c8bf7256d852571a778.
* fix for duplicate strings
* removed spaces
* Fixes ADS Web bug around copying user codes and opening a browser tab when adding an Azure Account. (#17760)
* Fixes bug around copying user codes and opening a browser tab.
* Code review changes
* Additional review changes.
* Unnecessary import removed
* Editing pipeline ACR service connection endpoint to the latest one created (#17767)
* using the new registry endpoint
* updating the service connection
* Changing the name of acr service endpoint to SqlToolsContainer
* Updating web build acr endpoint as well.
* Notebooks: Add Tooltips for Link/Image Buttons on Markdown Toolbar (#17763)
* Add title for tooltips
* Tweak tooltips
* Added UI for user to accept EULA when deploying sql proj to docker container (#17762)
* fix sorting bug (#17769)
* fix sorting bug
* comments
* Set default radio button selection, evaluate default component popula… (#17764)
* Set default radio button selection, evaluate default component population off of selection instead of unprocessed input
* rename var
* if -> switches
* Remove project radio buttons because they require commands that aren't yet checked in (and fail as a result)
* Added fix for Publish Target Label Position (#17771)
* Added fix for Publish Target Label Position
* renamed checkbox
* LEGO: check in for main to temporary branch. (#17775)
* LEGO: check in for main to temporary branch. (#17778)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* update dashboard taskbar separator (#17779)
* remove comments
* fix applying decorations
* add test
* enable find in sql result set
* add tests and update sql results highlight logic
* calculate the outputComponent index
* fix editor issues later
* remove newline replace on search
* address comments
* fix highlight issue
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
Co-authored-by: Lucy Zhang <luczhan@microsoft.com>
Co-authored-by: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com>
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com>
Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>
Co-authored-by: Alexander Ivanov <nahk-ivanov@users.noreply.github.com>
Co-authored-by: Aditya Bist <adbist@microsoft.com>
Co-authored-by: Sai Avishkar Sreerama <74571829+ssreerama@users.noreply.github.com>
Co-authored-by: Alex Ma <alma1@microsoft.com>
Co-authored-by: Leila Lali <llali@microsoft.com>
Co-authored-by: csigs <csigs@users.noreply.github.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: Candice Ye <candiceye@berkeley.edu>
Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>
* Remove undo/redo listeners from notebook component (#17966)
* remove undo/redo hostlisteners
* fix table focus issue (#17970)
* fix table focus issue
* fix hygiene error
* web
* new sts
* add await
* pr comments
* comments
Co-authored-by: Barbara Valdez <34872381+barbaravaldez@users.noreply.github.com>
Co-authored-by: brian-harris <61598682+brian-harris@users.noreply.github.com>
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: csigs <csigs@users.noreply.github.com>
Co-authored-by: Aditya Bist <adbist@microsoft.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Maddy <12754347+MaddyDev@users.noreply.github.com>
Co-authored-by: Lucy Zhang <luczhan@microsoft.com>
Co-authored-by: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com>
Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com>
Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>
Co-authored-by: Alexander Ivanov <nahk-ivanov@users.noreply.github.com>
Co-authored-by: Sai Avishkar Sreerama <74571829+ssreerama@users.noreply.github.com>
Co-authored-by: Alex Ma <alma1@microsoft.com>
Co-authored-by: Leila Lali <llali@microsoft.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: Candice Ye <candiceye@berkeley.edu>
Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>
* Start rerouting VSCode cell execution APIs.
* Add more conversion code.
* Convert VSCode notebook registrations into ADS equivalents.
* Update vscode notebook provider kernels when notebook controller's supportedLanguages are set.
* Update an error message.
* Add another session argument.
* Add base classes for converting notebook serializers.
* Disable some vscode notebook methods.
* Disable more vscode APIs.
* Disable more stuff.
* Start implementing serializer notebook data conversions.
* Use direct references to extension host notebook methods, rather than azdata ones.
* Add a comment.
* Remove a space.
* Use import type to fix module loading errors.
* Use internal cancellation token class.
* Start adding cell output conversion.
* Convert data from byte array to a string.
* More output work.
* Use a Set for proxy filtering.
* Start adding tests.
* Include metadata in cell conversion. Fix other test failures.
* Fix serialize tests.
* Add more tests.
* Remove wildcard characters from vscode filenames.
* Start implementing session details.
* Add more kernel info.
* Add kernel spec.
* Add Future callback wrapper class.
* Start implementing execute conversion.
* Pass notebook URI to requestExecute.
* Start working on CellExecution methods.
* Move some code around to fix layering issues.
* Use proxy to access browser code, rather than direct imports.
* Move files around to fix layering issues.
* Remove unused imports.
* Start implementing some notebook cell execution behaviors.
* Revert some unnecessary extHost API changes.
* Check for nbformat.
* Also handle nbformat in serialize case.
* Active notebook extensions when resolving NotebookInput.
* Fix nbformat handling.
* Disable VSCode notebooks code.
* Filter out notebook services from registration assertion.
* Wait for providers to load before calling canResolve.
* Use controller's viewType for notebook provider ID, instead of controller ID.
* Start adding extHostNotebook tests for new APIs.
* Re-order proxy calls.
* Remove commented code.
* Move vscode provider files to browser folder. Fix RPC serialization issues by using readonly field instead of getter for providerId.
* Add a comment.
* Remove unnecessary dispose call.
* Handle disposable from registerExecuteProvider.
* Remove a comment.
* Remove unnecessary provider fields.
* Remove reference to notebook service to fix circular reference issue in stringify.
* Add object types for methods in ADSNotebookController.
* Wait for controller languages to be ready before marking session manager as ready.
* Add correct promise.
* Add undefined return type for optional supportedLanguages property.
* Refine promise logic.
* Move vscode functionality back to ExtHostNotebook, since the NotebookService can't be passed back over RPC (some kind of circular reference error).
* Fix remaining issues from last commit.
* Replace "not implemented" methods with placeholder return types in order to enable testing.
* Also wait for execution handler to be set before marking session manager as ready.
* Fix usage of NotebookRegistry when updating provider description languages.
* Refine file extension conversion.
* Fix file extension conversion to match ADS extension behavior.
* Emit new provider registration event when adding supported languages.
* Remove checks for duplicate file providers and kernels.
* Fix a test failure.
* Fix file extension parsing.
* Use default executeManager if one isn't defined for provider in notebookModel.
* Add descriptors for waiting on standardKernels registration.
* Increase timeout
* Add an error message.
* Start working on retrieving default kernel from registered providers, rather than always falling back to SQL.
* Revert "Start working on retrieving default kernel from registered providers, rather than always falling back to SQL."
This reverts commit 1916ea1ce3a0072f51bec683116dc7bb6c7aefdc.
* Emit activation events after provider registration.
* Wait on standard kernels availability when getting an execute provider.
* Throw an error if session manager isn't ready yet.
* Actually resolve language promise correctly.
* Add some checks for undefined notebook data objects.
* Create kernel spec data correctly.
* Add extension changes for local testing only.
* Clean up test class.
* Add a reminder comment.
* Undo commented out notebook stuff
* Temporarily hard code default kernel.
* Retrieve default kernel in notebookModel if it's not already provided.
* Revert an import change.
* Remove unnecessary method from extHostNotebook.
* Move an interface around.
* wip
* Check for proposed API for some VSCode extHost methods.
* Remove a comment.
* Fix notebookUtils tests.
* Fix notebookModel tests.
* Fix notebookFindModel tests.
* Fix notebookViewsExtension tests.
* Fix remaining notebookView tests.
* Refactor output conversion functionality into separate methods.
* Update some unit tests for output conversion.
* Move a method.
* Rename conversion methods to fit acronym styling.
* Add another conversion test case.
* Revert local testing changes.
* Remove old method.
* cleanup
* Remove some comments.
* Move localized string to locConstants.
* Add a space to loc string.
* Add comments to new SQL Carbon Edit tags.
* Create constants for nbformat and nbformat_minor.
* Move some vscode-only fields to proposed APIs.
* Check for valid state
* Properly null check
* Adding logging for provider wait timeouts.
* wip update
* Fix compile
* Switch to cell edits
* Update docs
* Remove custom output type
* cleanup
* fix
* cleanup
* more cleanup
* Fixes
* Fix tests and lint errors
Co-authored-by: Cory Rivera <corivera@microsoft.com>
* initial changes
* add isCodeOutput and apply decorations on output
* Add extension gallery update reminder action (#17644)
* Fix extensionsGallery.json name (#17646)
* Remove galleries list action (#17648)
* multi-level table support (#17638)
* multi-level table support
* comments
* address comments
* add period to end of sentence.
* Show connection string example for add sql binding quickpick (#17650)
* add connection string example
* reorder
* Resolves same-origin-policy violation when ADS web is running in a container (#17555)
* Stops appending port to authority for web mode
* Clarifies comment
* Adds missing sql carbon edit tag
* vbump STS (#17653)
* use latest STS (#17658)
* Refactoring readProjFile() (#17637)
* move reading project parts to different helper functions
* cleanup
* remove comment
* addressing comments
* Corrects Web Build Pipeline ENOENT Error (#17656)
* Checks for successful directory creation
* Revert "Checks for successful directory creation"
This reverts commit 372409ef323f0d82e11992bc7bc33d607a7d5581.
* Checks for the existence of the logs directory before accessing.
* Adds SQL carbon edit comment
* Removing call to copy from non-existing directory.
* Removes unneeded import
* Checks for file existence before copying.
* Provides explanation for modification
* Replaces file existence check with exception handling.
* Bump tools service (#17671)
* Apply changes from Remote Database to sqlproj - mssql changes (#17655)
* update project from database
* update project from database
* update project from database
* Re-adding schemaComparePublishChanges for temporary backcompat
* Adding comment for keeping enum values in sync
* Correcting enum value
Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>
* update add file/folder for msbuild sdk style projects (#17660)
* update add file for msbuild sdk style projects
* also handle add folder
* fix comment
* fix issue reported by component governance (#17678)
* update json-schema version
* remove unused packages
* update package.json
* SQL Binding: Give default connection setting name (#17659)
* show sqlconnectionstring in quickpick
* fix duplicate sqlconnectionstring setting
* add (new)
* add sqlconnectionstring as default setting name
* check if sqlconnectionstring already exists
* Provide aria-labels for node checkboxes in the tree view. (#17676)
During accessibility testing, it was discovered that screen reader does not announce what checkboxes in the tree view represent. It was merely announcing "checkbox unchecked", so it was not clear without visuals which checkbox the focus is on.
This change sets an `aria-label` of the checkbox elements to match the label of the owning tree node. This way the announcement becomes "My Node; checkbox; unchecked". This is fine as a quick solution to the problem, but in the future we may want to consider adding additional checkbox label property to the nodes exposed by the tree provider, so that each checkbox can announce additional information, if needed.
* Respect ARIA label specified int he tree component options. (#17674)
During accessibility testing it was discovered that tree view in our wizard reads "Tree Node tree view" instead of the proper label that is specified. It turned out to be the problem with the tree component, where `ariaLabel` was hardcoded to "Tree Node", instead of the one provided in the options.
This change addresses the problem by passing through `ariaLabel` from the options object to the underlying tree control. I also removed the default `Tree Node` hardcoded label, as it didn't make much sense. This does mean that all tree-views that do not explicitly specify their aria-label will now get an empty label. I think this is better than having unrelated, unlocalized `Tree Node`.
I'm also worried about changes to the `ariaLabel` property after the component was initialized. I updated the code to propagate the value to the underlying tree view in the `setProperties` override of the tree component and hope that it will take care of it.
* Fix sql projects net6 warnings (#17673)
* fix .net 6 error showing on startup
* fix double warning
* addressing comments
* update key string
* undo adding space in net core sdk location setting (#17684)
* update names for msbuild sdk style projects (#17677)
* update names for msbuild sdk style projects
* remove msbuild from names
* update comments
* Designer: property descriptions (#17668)
* format
* added strings
* format doc
* use codicon instead
* show descriptions in property pane only
* fix ssdt string bug
* fix overflow option
* review comments
* review comments
* changes
* sts 156 vbump (#17683)
* Sql Binding: Add "Check out pane for more details" when nuget package download fails (#17680)
* check output for more details
* detail error
* wait for result from showerrormessage
* [Loc] Update to sql-database-projects and sql.xlf (#17687)
* update the vmImage for build jobs (#17689)
* update vmImage for windows build
* update tar command
* use specific macos version
* support building msbuild sdk style projects (#17675)
* support building msbuild sdk style projects
* fixes after merge
* add foreign keys and constraints (#17697)
* foreign keys and constraints
* refactoring
* fix issues
* properties pane improvements (#17700)
* [Loc] update to tabledesignercomponentinput (#17704)
* Add instructions for developing VS Code version of sql-database-projects (#17705)
* Adding UI for deploying a db proj to docker (#17495)
* code refactoring (#17706)
* Improve accessibility for wizard steps navigation (#17669)
Our extension is relying on the wizard dialog. During accessibility testing it was discovered that wizard step buttons are being reported as links by the screen reader (NVDA, JAWS). Claimed expected behavior by the tester is that they should be announced as buttons.
I discussed this issue with accessibility SMEs and they said it is perfectly fine to keep them as links. They did mention that they would probably design the UX differently from the start, but given that we already have it this way, links are fine. They did suggest to add few additional ARIA attributes to the link elements:
- `aria-current="step"` if the link is for the currently active step. This literally just announces "current step" at the end, when you focus on a link
- `aria-disabled="true"` makes it say "**unavailable**; link; *<step number>*" when in NVDA "browse" mode and move to the grayed-out link.
So this change implements the said improvements.
* bump sts version to 159 (#17709)
* LEGO: check in for main to temporary branch. (#17699)
* LEGO: check in for main to temporary branch. (#17702)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* [Loc] update to sql-database-projects (#17713)
* LEGO: check in for main to temporary branch. (#17715)
* Register additional editor overrides when adding new notebook file types (#17708)
* Also standardized file extension contributions to always start with a period, and to always do lower case string comparisons for file extensions.
* input width in designer (#17714)
* Add additional properties to wizard page navigation events (#17716)
* Fix open external not working (#17717)
* save password checkbox fix (#17718)
* save password checkbox fix
* remove code to reset the checkbox value
* allow build to continue when cache task fails (#17720)
* cache task should not fail the build
* update cachesalt
* Fix language flavor change on connection when in sqlcmd mode (#17719)
* Fix language flavor change on connection when in sqlcmd mode
* comment + fix
* LEGO: check in for main to temporary branch. (#17722)
* LEGO: check in for main to temporary branch. (#17724)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* Update one more variable name for sdk style projects (#17710)
* LEGO: check in for main to temporary branch. (#17725)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* LEGO: check in for main to temporary branch. (#17726)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* LEGO: check in for main to temporary branch. (#17730)
* Fix "unsupported version" error when adding sql binding package (#17721)
* Apply changes from remote database to sqlproj - schema-compare changes (#17679)
* update project from database
* update project from database
* Merge from main
* Removing dupe test stub
* PR feedback
* cleanup
* PR feedback
* Fixing tests, adding stubs to update sqlproj as schema compare target
* updating code comment
Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>
* [Loc] Update to schema-compare XLF (#17733)
* Enabled deployment of Azure Arc data controllers in directly connected mode (#17707)
* Added fields for connectivity mode, custom loc, auto-metrics, auto-logs, and the dynamic enablement of such fields.
* Changed the description of the data controller details page.
* Change notebook params to work for direct mode
* Added login to dc deployment notebooks
* Fixed auto upload metrics and logs true/false, separated login into another cell.
* Removed localization of indirect and direct connectivity labels.
* Fix ordering of reading sqlproj Build Includes and Removes (#17712)
* evaluate includes and removes in order in sqlproj
* fix after merge
* fix comment
* update comment
* Add resource deployment samples for (#17734)
* Update remove file for sdk style sql projects (#17688)
* add support for removing file in new style project
* fix test
* only load files, not whole project when checking if a <Build Remove> needs to be added
* merge changes
* fixes after merge
* [Loc] update to Arc XLF (#17737)
* Bump to latest version of azdata (#17735)
* Remove .net 6 version cutoff for building sql projects (#17736)
* remove .net 6 version cutoff for building sql projects
* Revert "Warning when .NET 6 SDK is detected (#17422)"
This reverts commit 2ed8aeb565.
* add back skipVersionSupportedCheck
* add back return false
* addressing comments
* [Loc] update to sql-database-projects xlf (#17743)
* Add additional notebook tests for handling relative links. (#17739)
* [Loc] Fix for duplicate strings in LCL files (#17756)
* WIP spanish lcl duplicate removal
* Revert "WIP spanish lcl duplicate removal"
This reverts commit 5f943153ec8980849a045c8bf7256d852571a778.
* fix for duplicate strings
* removed spaces
* Fixes ADS Web bug around copying user codes and opening a browser tab when adding an Azure Account. (#17760)
* Fixes bug around copying user codes and opening a browser tab.
* Code review changes
* Additional review changes.
* Unnecessary import removed
* Editing pipeline ACR service connection endpoint to the latest one created (#17767)
* using the new registry endpoint
* updating the service connection
* Changing the name of acr service endpoint to SqlToolsContainer
* Updating web build acr endpoint as well.
* Notebooks: Add Tooltips for Link/Image Buttons on Markdown Toolbar (#17763)
* Add title for tooltips
* Tweak tooltips
* Added UI for user to accept EULA when deploying sql proj to docker container (#17762)
* fix sorting bug (#17769)
* fix sorting bug
* comments
* Set default radio button selection, evaluate default component popula… (#17764)
* Set default radio button selection, evaluate default component population off of selection instead of unprocessed input
* rename var
* if -> switches
* Remove project radio buttons because they require commands that aren't yet checked in (and fail as a result)
* Added fix for Publish Target Label Position (#17771)
* Added fix for Publish Target Label Position
* renamed checkbox
* LEGO: check in for main to temporary branch. (#17775)
* LEGO: check in for main to temporary branch. (#17778)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* update dashboard taskbar separator (#17779)
* remove comments
* fix applying decorations
* add test
* enable find in sql result set
* add tests and update sql results highlight logic
* calculate the outputComponent index
* fix editor issues later
* remove newline replace on search
* address comments
* fix highlight issue
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
Co-authored-by: Lucy Zhang <luczhan@microsoft.com>
Co-authored-by: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com>
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com>
Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>
Co-authored-by: Alexander Ivanov <nahk-ivanov@users.noreply.github.com>
Co-authored-by: Aditya Bist <adbist@microsoft.com>
Co-authored-by: Sai Avishkar Sreerama <74571829+ssreerama@users.noreply.github.com>
Co-authored-by: Alex Ma <alma1@microsoft.com>
Co-authored-by: Leila Lali <llali@microsoft.com>
Co-authored-by: csigs <csigs@users.noreply.github.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: Candice Ye <candiceye@berkeley.edu>
Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>
* Added customlocation, location, resource group, and connection mode to controllerinfo. Updated SQL MIAA create notebook with direct mode params.
* Removed annotations from metadata in postgres test file.
* Only parse the customlocation if the connection mode is direct.
Co-authored-by: Candice Ye <canye@microsoft.com>
* enable add sql binding command
* add preview to command
* use resourceScheme instead of resourceExtname
* bump version to 0.15.0
* revert version bump
* Set default radio button selection, evaluate default component population off of selection instead of unprocessed input
* rename var
* if -> switches
* Remove project radio buttons because they require commands that aren't yet checked in (and fail as a result)
* using the new registry endpoint
* updating the service connection
* Changing the name of acr service endpoint to SqlToolsContainer
* Updating web build acr endpoint as well.
* remove .net 6 version cutoff for building sql projects
* Revert "Warning when .NET 6 SDK is detected (#17422)"
This reverts commit 2ed8aeb565.
* add back skipVersionSupportedCheck
* add back return false
* addressing comments
* add support for removing file in new style project
* fix test
* only load files, not whole project when checking if a <Build Remove> needs to be added
* merge changes
* fixes after merge
* Added fields for connectivity mode, custom loc, auto-metrics, auto-logs, and the dynamic enablement of such fields.
* Changed the description of the data controller details page.
* Change notebook params to work for direct mode
* Added login to dc deployment notebooks
* Fixed auto upload metrics and logs true/false, separated login into another cell.
* Removed localization of indirect and direct connectivity labels.
Our extension is relying on the wizard dialog. During accessibility testing it was discovered that wizard step buttons are being reported as links by the screen reader (NVDA, JAWS). Claimed expected behavior by the tester is that they should be announced as buttons.
I discussed this issue with accessibility SMEs and they said it is perfectly fine to keep them as links. They did mention that they would probably design the UX differently from the start, but given that we already have it this way, links are fine. They did suggest to add few additional ARIA attributes to the link elements:
- `aria-current="step"` if the link is for the currently active step. This literally just announces "current step" at the end, when you focus on a link
- `aria-disabled="true"` makes it say "**unavailable**; link; *<step number>*" when in NVDA "browse" mode and move to the grayed-out link.
So this change implements the said improvements.
During accessibility testing it was discovered that tree view in our wizard reads "Tree Node tree view" instead of the proper label that is specified. It turned out to be the problem with the tree component, where `ariaLabel` was hardcoded to "Tree Node", instead of the one provided in the options.
This change addresses the problem by passing through `ariaLabel` from the options object to the underlying tree control. I also removed the default `Tree Node` hardcoded label, as it didn't make much sense. This does mean that all tree-views that do not explicitly specify their aria-label will now get an empty label. I think this is better than having unrelated, unlocalized `Tree Node`.
I'm also worried about changes to the `ariaLabel` property after the component was initialized. I updated the code to propagate the value to the underlying tree view in the `setProperties` override of the tree component and hope that it will take care of it.
During accessibility testing, it was discovered that screen reader does not announce what checkboxes in the tree view represent. It was merely announcing "checkbox unchecked", so it was not clear without visuals which checkbox the focus is on.
This change sets an `aria-label` of the checkbox elements to match the label of the owning tree node. This way the announcement becomes "My Node; checkbox; unchecked". This is fine as a quick solution to the problem, but in the future we may want to consider adding additional checkbox label property to the nodes exposed by the tree provider, so that each checkbox can announce additional information, if needed.
* Checks for successful directory creation
* Revert "Checks for successful directory creation"
This reverts commit 372409ef323f0d82e11992bc7bc33d607a7d5581.
* Checks for the existence of the logs directory before accessing.
* Adds SQL carbon edit comment
* Removing call to copy from non-existing directory.
* Removes unneeded import
* Checks for file existence before copying.
* Provides explanation for modification
* Replaces file existence check with exception handling.
* Use built-in SQL ExecuteProvider by default if no other provider exists.
* Gracefully handle case where standardKernels are not defined for a provider.
* Standardize on just using arrays for various provider registration details.
* use glob to get files for new style msbuild sdk sqlproj
* add tests
* cleanup
* fix test
* don't show bin and obj files and folders
* handle other glob patterns
* fix duplicate entries getting added for glob patterns in project's folder
* format doc
* correct class name
* set content
* remove mssql commands
* merge classes
* code refactoring and bug fixing
* remove unnecessary class
* handle promise
Co-authored-by: Alan Ren <alanren@microsoft.com>
* respect include header option
* use correct option for copying
* check for setting when copying
* add dependency injection
* use instantiation service
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* Clean up extension descriptions
* More cleanup
* learning to spell
* Remove unused loc strings
* Add bundling information & rename view container
* Update data workspace readme
* don't show SSDT update warning for new style projects
* update strings
* add checks for the 2 other ways to specify msbuild sdk
* add link to docs on how to use project sdk
Co-authored-by: Kim Santiago <kisantia@Kims-MacBook-Pro.local>
* Changed the placement of the getValue comment in IValueProvider interface.
* Simplified some params values to feed into deployment notebook better. Added logic to add flags to the sql miaa create calls in notebook. Removed variablename from estimated cost.
* Changed High Availability to Replicas
Co-authored-by: Candice Ye <canye@microsoft.com>
Separate the Views load from the initialization. This way we can load previously created views, and only add the new views data to the document when needed. For now, this happens only when a view is created.
* Added valueprovider for pricing. Pushing this for troubleshooting help.
* Committing changes for troubleshooting help. Moved InputValueType to typings file.
* Add readonly inputs to list
* Fixed ordering of package.json merge items
* Estimated cost moved to input page, ValueProvider only takes in a triggerfields[] and not a single string, fixed pricing logic.
* Removed pricingModel.ts
* Reverted some comments and code changes that were used in debugging.
* Changed some values from localizedConstants to single-quote constants'
* Changed some values from localizedConstants to single-quote constants'
* Added copyright header to pricingUtils.ts
* Removed try catch in extension.ts valueproviders, made some values in PricingUtils.ts top-level instead of exporting.
* Minor changes, added some comments and localized USD.
* Changes pricingutils classes to be constants, and added disposable to Hookupvalueprovider
Co-authored-by: Candice Ye <canye@microsoft.com>
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* Adds loggings to ADS pipeline
* Skips notebook smoke tests for ADS web.
* Skips failing create book dialog tests in web build
* Ignores import tests ADS web
* Groups related tests together for ADS Web and non-web
* Updates distro commit hash
* Adding prompt for project name
* Updating test
* PR feedback
* Fixing rename logic so that folder is also named according to project
* Updating autorest test to confirm rename
* Giving user option to install autorest globally or run via npx
* Adds message for when no files are generated (no models in spec)
* Adding test
* Reinstating the rest of the test suite
* PR feedback
* Fixing tests to stub new prompt when test runner doesn't have autorest installed
* PR feedback
* fix typo
* fix typo
* backup page
* config rpo first
* rpo az cli
* working 1
* working 2
* working -3
* working -3
* working 4
* working with button component
* remove Date usage, use string instead
* cleanup
* cleanup 2
* Update localizedConstants.ts
rectify the wording until, figure out a way to fetch earliest backup
* pitr dialog, remove rpo
* pr feedback
* pr feedback
* pr feedback
* pr feedback
* feedback
* remove iso time conversion and show time as-is
* save lastEditMode
* change style to active
* addActiveClassFromEditMode
* add undefined to declaration
* remove from public interface
* private
* lastEditMode to last selected mode
* comments
* set active in one place
* rename method
* table designer add/remove row support
* save changes and editor support
* address comments
* fix build error
* including missing change
* lower case request name
* Corrects keyboard shortcuts for linux
* Changed python to match the one listed in docker/Dockerfile
* Revert "Changed python to match the one listed in docker/Dockerfile"
This reverts commit 683c226eb600bc89b449f258d463d2a6b14aebe6.
* Adjusts retry count for dialog elements to close.
* Code clean up
* Revert "Adjusts retry count for dialog elements to close."
This reverts commit 64a8bf48fa72eb26830aeaa55721c7ff846d131e.
* Code cleanup
* Adjusts key binding
* wip
* wire up e2e
* hook up styler and add as dataprotocal feature
* designer child component rendering
* table component updates
* styler and selectbox column editor
* fix editor size and dupe component creation issue
* fix checkbox column and add more testing data
* properties pane
* only rerender when needed
* properties pane update
* update commands
* cleanup for PR
* revert unwanted changes
* Adding a few tests for Add SQL binding (#17079)
* initial changes
* add a couple more tests
* LEGO: check in for main to temporary branch. (#17089)
* LEGO: check in for main to temporary branch. (#17091)
Co-authored-by: kburtram <karlb@microsoft.com>
* Adds autorest-based SQL Project generation to SQL Database Projects extension (#17078)
* Initial changes
* checkpoint
* Constructing project with post deployment script
* Correcting to intentionally read from cached list of projects
* Adding activation event, fixing fresh workspace bug
* Convert netcoreTool and autorestHelper to share a helper class for streamed command
* Include npm package version to force update
* test checkpoint
* Unit tests
* Added contextual quickpicks for autorest dialogs
* Adding projectController test
* Added projectController test, some refactoring for testability
* Merge branch 'main' into benjin/autorest
* Fixing 'which' import
* PR feedback
* Fixing tests
* Adding additional information for when project provider tests fail
* Hopefully fixing failing tests (unable to repro locally)
* Adding Generate Project item to workspace menu
* PR feedback
* LEGO: check in for main to temporary branch. (#17097)
* added sql database projects strings (#17100)
* Set kernelAlias in startSession when isValidConnection is truthy (#17102)
* PR follow-up comments (#17113)
* Change recompare message after changing options to modal (#17103)
* Change recompare message to modal
* change options to yes and no
* Remove commented code block in git extension (#17116)
* Remove commented code block in git extension
* Add SQL CARBON EDIT tag
* [Loc] Small change to generatingProjectFailed (#17118)
* Add Null Shortcut and added NULL text for default NULL value. (#17085)
* added test key event
* added null function to tryHandleKeyEvent
* added null formatting
* added working null insert.
* added editDataGridPanel string null support
* Bump nth-check from 2.0.0 to 2.0.1 in /build (#17115)
Bumps [nth-check](https://github.com/fb55/nth-check) from 2.0.0 to 2.0.1.
- [Release notes](https://github.com/fb55/nth-check/releases)
- [Commits](https://github.com/fb55/nth-check/compare/v2.0.0...v2.0.1)
---
updated-dependencies:
- dependency-name: nth-check
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add excludeFlags to extenson marketplace query (#17121)
* Add excludeFlags to extenson marketplace query
* Remove dead code
* Remove extraneous blank line
* Address code review feedback
* Adding Derived Columns to ADS Flatfile Import (#16795)
* Adding derived column boilerplate
* brandan preliminary frontend changes
* empty commit
* added new param
* updating contracts, dialogue changes
* utils changes, saving timeout attempt
* pushing for aasim
* Cleaning up code and fixing the issue in theory
* changing button, did not solve independent scroll
* Fixing the scroll bar issue
* updating flat file service
* adding override keyword to overrriden method
* improving UI
* pushing changes associated with resolved comments
* localizing strings, editing comments
* all comments resolved
* Fixing a test
* updating import package
Updating azure MFA bug
* Clearing navigation validator
Fixing broken table name change
* fixed prose test
* removing unused code from tests
* Fixed PR comments
* Fixing some PR comments
* WIP
* Fixing transformation code and create derived column dialog styling
* removing unused code
* Adding comment for console log
* fixed table styling
* Adding some aria labels
* Fixed some code cleanup issues
* update import service
Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
Co-authored-by: bnhoule <t-bhoule@microsoft.com>
* Change keybindings for copying query with Results (#17127)
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
* sql proj - publish to docker improvements (#17124)
* Add AAD token expiration handling for query runner (#17117)
* Add AAD token refresh for notebook
* move token refresh to query management and remove previous refresh calls
* Add guids to RunAll and RunCell events (#17123)
Add guids to RunAll and RunCell events
* add error banner for failed migration cutover and cancel migration (#17106)
* [Loc] update to sql migration, database projects and import extension strings (#17130)
* Apply optional storage class settings in sql mi create command (#17129)
* Make storage classes optional
* Fix notebook to use storage class options
Co-authored-by: Charmaine Chan <chachan@microsoft.com>
* Add support for adding new setting in local.settings.json in add SQL binding quickpick (#17093)
* be able to add new setting in local.settings.json
* cleanup
* addressing comments
* remove todo comment
* addressing comments
* update some strings to uris
* bump version of sqltoolsservice (#17133)
* mark schema compare tests as unstable (#17140)
* [Loc] Update for arc and sql-database-projects (#17148)
* ML extension vbump (#17143)
* Configure docker image and web smoke tests for ADSWeb. (#17136)
* Adjusts timeout period
* Revert "Adjusts timeout period"
This reverts commit 0f372eae2a4611554093b6c09f1ff6c451132e19.
* Adds firefox as browser option
* Corrects yaml smoke test script
* Resets args array to original values
* Corrects build path
* Resolves ignoring browser option error
* continue even after writing to stderr
* Adjusts smoke test (browser) script
* More adjustments to smoke test script
* Corrects server path
* Uses build variable directly in build path
* Specifies browser type since cannot be ignored error
* Adds browser option
* Updates web build image and corrects smoke test exe command
* Removes commented out task
* Updates dockerfile to support web smoketests
* Removes failOnStderr flag
* Use curl instead of wget in Dockerfile
* Fixed a bug with cancling publish (#17160)
* Save And Close Functionality (#17000)
* save and close
* wip
* working save and close
* cleanup
* pr changes
* pr changes
* fix capitalization
* fix build
* pr fix
* Added dynamic options for SQL MIAA Deployment Wizard and updated checkbox field (#17119)
* Dynamic enablement
* Added new package.json field for dynamic options and corresponding functions and classes.
* Enabled dynamic options non-generalized and changed formatting of checkbox to have label on the left.
* Added setOptions under InputComponentInfo for generalization, comments under checkbox component, and changed Replicas to High Availability to reflect parity in portal.
* fix unit test
Co-authored-by: Candice Ye <canye@microsoft.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
* LEGO: check in for main to temporary branch. (#17168)
* [Loc] added new arc strings and fix for sql-database-projects lcl file for Japanese (#17171)
* [Loc] added new arc strings and fix for sql-database-projects xlf
* removed newline
* Port of Vscode fix for colors too close (#17146)
* default light colors list.focusHighlightForeground too close to list.activeSelectionBackground. Fixes#127597
* remove activeSelectionBackground from theme-carbon as it conflicts with vscode.
* remove dark carbon background
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
* Markdown Horizontal Scrollbar Fix (#17083)
* dynamically change horizontal scrollbar
* working horizontal scrollbar
* created new event to handle both scrollbar and mouse wheel
* only show scrollbar when needed
* LEGO: check in for main to temporary branch. (#17181)
* Bump axios to 0.21.4 (#17161)
* Kusto version bump to 0.5.6 (#17114)
* Bumped Kusto toolsservice version to 125 and bumped version to 0.5.6
* Changed netcoreapp3.1 to net5.0 in Kusto config.json
* AzureMonitor bump ToolService version and extension version. (#17174)
* Bump concat-with-sourcemaps from 1.0.4 to 1.1.0 (#17158)
Bumps [concat-with-sourcemaps](https://github.com/floridoo/concat-with-sourcemaps) from 1.0.4 to 1.1.0.
- [Release notes](https://github.com/floridoo/concat-with-sourcemaps/releases)
- [Commits](https://github.com/floridoo/concat-with-sourcemaps/commits)
---
updated-dependencies:
- dependency-name: concat-with-sourcemaps
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update service downloader to 0.2.3 (#17186)
* Notebook Views grid fixes (#17170)
* update data workspace restart ADS to open workspace message (#17188)
* update message
* update string
* Add back "Remove Project" (#17178)
* remove project working with full paths
* use relative paths
* const
* addressing comments
* Bump github-auth axios to 0.21.4 (#17189)
* LEGO: check in for main to temporary branch. (#17192)
* LEGO: check in for main to temporary branch. (#17190)
Co-authored-by: kburtram <karlb@microsoft.com>
* [Loc] Add a small change to dataworkspace (#17194)
* added bump to sqltoolsservice version (#17195)
* Check if file is dirty before adding sql binding (#17175)
* check if file is dirty before adding sql binding
* Addressing comments
* Add vertical scroll bar to Preview in Split View (#17164)
* reset max height
* add editor height
* set md editor height
* Split up NotebookProvider into separate providers for handling file serialization and cell execution. (#17176)
* fix floating promises
* pr comments
* reuse component definition
* comments
* fix error
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: csigs <csigs@users.noreply.github.com>
Co-authored-by: kburtram <karlb@microsoft.com>
Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com>
Co-authored-by: Alex Ma <alma1@microsoft.com>
Co-authored-by: Justin M <63619224+JustinMDotNet@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: bnhoule <52506119+bnhoule@users.noreply.github.com>
Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
Co-authored-by: bnhoule <t-bhoule@microsoft.com>
Co-authored-by: Monica Gupta <scorpio90m@gmail.com>
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
Co-authored-by: Leila Lali <llali@microsoft.com>
Co-authored-by: Hai Cao <hacao@microsoft.com>
Co-authored-by: Daniel Grajeda <dagrajed@microsoft.com>
Co-authored-by: brian-harris <61598682+brian-harris@users.noreply.github.com>
Co-authored-by: Charmaine Chan <69230572+charmainewkchan@users.noreply.github.com>
Co-authored-by: Charmaine Chan <chachan@microsoft.com>
Co-authored-by: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com>
Co-authored-by: Christopher Suh <chsuh@microsoft.com>
Co-authored-by: Candice Ye <candiceye@berkeley.edu>
Co-authored-by: Candice Ye <canye@microsoft.com>
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
Co-authored-by: Vasu Bhog <vabhog@microsoft.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Barbara Valdez <34872381+barbaravaldez@users.noreply.github.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
* Stops flagging untitled editors with pre-loaded content as dirty
* Code changes address broken unit tests.
* Completes original comment
* Defines new non dirty text editor model
* Revert "Completes original comment"
This reverts commit 6d0e90bb9f0650eead5a0ec1ca8524dfe96c56cd.
* Revert "Code changes address broken unit tests."
This reverts commit 5b8cdd9f0bb43638bdd427a454ea177f6fbc024d.
* Revert "Stops flagging untitled editors with pre-loaded content as dirty"
This reverts commit 7a39226b7961af3aba8dc2f08113ed09eb2a1d61.
* Stops marking untitled editors with JSON as dirty
* Code clean up.
* check if database connection
* Change name of isMaster and remove import
* Set to false
* take out connecttodatabase
* remove connecttodatabase
* Original database
* remove empty string check
* clean
* set original database for when saving connection
* pass unit test
* map -> find
* PR changes
* Comments for original database
* Initial Split code
* minor change
* minor changes
* Added split cell button to initActionBar, created split cell class to pss cell context.
* added changes
* fixed index
* Split Cell Working in markdown mode
* Fixed highlighting
* Preserve the edit state
* Added new icon and updated styles and cellToolbar component with new icon name.
* Addressed PR
* Addressed PR
* Added back isEditMode flag
* Moved split action to after edit toggle.
* Fixed typo
* Addressed PR
* Addressed PR
* Removed deletion of the cell
* fixed the comments
Co-authored-by: Hale Rankin <harankin@microsoft.com>
* updated border styling of tables
* reducing border thickness
* fixing styling for dark mode
* fixing for dark mode
* removing box shadow from checkbox
* dynamically change horizontal scrollbar
* working horizontal scrollbar
* created new event to handle both scrollbar and mouse wheel
* only show scrollbar when needed
* default light colors list.focusHighlightForeground too close to list.activeSelectionBackground. Fixes#127597
* remove activeSelectionBackground from theme-carbon as it conflicts with vscode.
* remove dark carbon background
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
* Dynamic enablement
* Added new package.json field for dynamic options and corresponding functions and classes.
* Enabled dynamic options non-generalized and changed formatting of checkbox to have label on the left.
* Added setOptions under InputComponentInfo for generalization, comments under checkbox component, and changed Replicas to High Availability to reflect parity in portal.
* fix unit test
Co-authored-by: Candice Ye <canye@microsoft.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
* Adjusts timeout period
* Revert "Adjusts timeout period"
This reverts commit 0f372eae2a4611554093b6c09f1ff6c451132e19.
* Adds firefox as browser option
* Corrects yaml smoke test script
* Resets args array to original values
* Corrects build path
* Resolves ignoring browser option error
* continue even after writing to stderr
* Adjusts smoke test (browser) script
* More adjustments to smoke test script
* Corrects server path
* Uses build variable directly in build path
* Specifies browser type since cannot be ignored error
* Adds browser option
* Updates web build image and corrects smoke test exe command
* Removes commented out task
* Updates dockerfile to support web smoketests
* Removes failOnStderr flag
* Use curl instead of wget in Dockerfile
* be able to add new setting in local.settings.json
* cleanup
* addressing comments
* remove todo comment
* addressing comments
* update some strings to uris
* Initial changes
* checkpoint
* Constructing project with post deployment script
* Correcting to intentionally read from cached list of projects
* Adding activation event, fixing fresh workspace bug
* Convert netcoreTool and autorestHelper to share a helper class for streamed command
* Include npm package version to force update
* test checkpoint
* Unit tests
* Added contextual quickpicks for autorest dialogs
* Adding projectController test
* Added projectController test, some refactoring for testability
* Merge branch 'main' into benjin/autorest
* Fixing 'which' import
* PR feedback
* Fixing tests
* Adding additional information for when project provider tests fail
* Hopefully fixing failing tests (unable to repro locally)
* Adding Generate Project item to workspace menu
* PR feedback
* Adds smoketests for ADS web.
* Refines element selector for editor suggestion list
* Revert "Refines element selector for editor suggestion list"
This reverts commit 61b34cd07ab9fa16546d7aab5bce24c73559c6b0.
* Skip tests that timeout for not finding targeted DOM element
* Missed undoing a modification
* Reinstates skipped tests
* Removes unnecssary TODO
* Disables smoke tests for darwin
* Fixed indenting to resolve azure DevOps yaml error
* Updates server path based on setup doc
* Moves smoketests after extensions are built
* Corrects indentation
* Fixes indentation with bottom half of smoketests script
* Updates sqlite URL to latest release
* Yields correct ADS sqlite release version for web and non web
* removes accidental whitespace from previous commit
* Code review changes
* Additional review change
* update distro
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Adding error message and placeholder for dropdown
* Fixing default error message for empty required dropdown
* Fixing a small input value updating bug
* Fixed a commend
* Fixed a comment
* PR fixes
* Using codicon
* Fixed screen reader not reading error message
* Adding support for multiple dropdowns error message
* Adding error border
* Fixing error border styling.
* Added more specific classes for styling
* Making styling more specific
* debug messages to figure out what is calling this
* added existing connection handling.
* added timeout for isConnected
* restored connectionStatusManager
* added timeout for updating the connection state
* added existing profile check in queryInputFactory
* moved existing profile check to outer
* added to nonSync
* added mock getConnectionProfile
* added push instead of assign
* added additional tests
* removed getConnectionProfile
* added test message for getConnectionProfile
* fixed tests, need to add more
* added working tests
* moved connect to helper method
* rearranged test order and added sync
* changed wording
* small capitalization change
* Adding user config for default auth type
* adding feature
* removing the SqlLogin default from the model
* fixing bug, removing dead code
* removing unneeded instance of configurationService
* fixing line break
* removing extra parameter
* removing comments
* Fix test breaks
* Fix build break
* More breaks
* Address code review feedback
Co-authored-by: Troy Witthoeft <troy.witthoeft@gmail.com>
* removed clear results and results visible.
* revert changes, still work in progress
* added small debug message
* added flag for state
* removed clear in queryResultsView
* moved carbon edit message
* simplifcation
* fixed spacing
* added clarifying message
* added clarifying comment
* added original tab clear line for future things
* added support for regular saves
* removed vscode changes
* added queryEditorTextInput to other versions
* added stuff
* reverted changes to queryTextEditorInput
* deleted duplicates
* moved untitledQueryEditorInput
* added FileQueryEditorInput constructor
* added instantiation
* added queryEditorTest
* added temporary state for save editor input
* added back in FileQueryEditorInput
* added example of both to test
* restored input.
* Added current results processing
* removed queryeditor import
* added disable dispose, WIP
* added small change to dispose
* added oldUri
* added small changes for adding renameQuery
* added first parts of renameQuery, need to add more in other parts. (Place next to disposeQuery).
* moved rename around in queryModel
* added rename to testQueryManagementServices, now need to add to queryrunner.
* added to queryRunner, need to test
* added renameQuery calls
* added renameQuery to extensions
* moved untitledQueryEditorInput to its old location
* removed duplicate untitledQueryEditorInput
* test import
* test blah
* moved fileQueryEditorInput to services
* deleted original fileQueryEditorInput
* Moved fileQueryEditorInput to new location
* added workbenchinstantiationservice
* added titledQueryEditorInput
* restored untitledQueryEditorInput.ts
* removed instantiation service
* made changes to titledQueryEditorInput
* Revert "deleted original fileQueryEditorInput"
This reverts commit dd5eb19ea1489d9c0dda159e6a798975240dab65.
* reverted back to pre move
* added altered untitledQueryEditorInput
* temporarily using old version of save until determining point where new URI is assigned.
* renamed oldUri to newUri to better reflect its actual use.
* added some debug messages for examining how uris work
* made small changes to untitledQueryEditorInput
* restored save to have actual code.
* moved renameQuery to proposed.
* added partially working save as for results (Pressing run breaks query)
* removed instantiationservice
* added newUri for dataservice
* added queryRunner.uri for queryModelService
* moved untitledQueryEditorInput to old location
* changed todomessage
* added explanation messages
* fixed spaces and added description
* moved untitledQueryEditorInput to new location
* added rename for connectionmanagementservice
* added carbon edit message
* removed carbon edit to editorservice
* removed another space
* added get and set for isSaving value
* removed accessor
* Update azdata.proposed.d.ts
added space
* fixed azdata.proposed
* added changeConnectionUriForQuery
* restored request
* replaced changeconnectionuri to changeuri
* Revert "replaced changeconnectionuri to changeuri"
This reverts commit eed8e518dee69cf2922ff86dc1763e6fb7715a71.
* made required changes
* fixed exclamation mark
* removed error on queryRunner changeconnection
* added save connect button status
* added additional state properties to save
* added wip setstate
* added changes for better naming
* added changes in preparation for vscode merge
* take screenshot of failed test before close editor (#16876)
* Add setting for enabling using new markdown renderer (#16864)
* Add setting for enabling using new markdown renderer
* Use const
* Fix circular dependency
* Default setting to false
* fix refresh node and add sample (#16888)
* Merge from vscode e3c4990c67c40213af168300d1cfeb71d680f877 (#16569)
* Bump VS Code version to latest sync point (#16891)
* Fix duplicate editor windows on reload (#16893)
* reset the icon before use (#16896)
* Undo merge icon change (#16894)
* disable cancel button after clicked once (#16783)
* disable cancel button after clicked once
* remove enabling of cancel button when cancelling
* Update sqlite version for smoke tests (#16903)
* update sqlite
* bump distro
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* add autoCutoverConfiguration to getMigrationStatus (#16803)
* Enable scripting for triggers and other objects (#16885)
* WIP 1
* Add parentName to azdata
* Add some additional types for scripting
* Add parent type name to support view subobjects
* bump dependencies and address review comments
* Modify treeDataChange event (#125214) (#16907)
Modify treeDataChange event to support firing arrays.
* Move create new option for publish to top and filter out system dbs (#16908)
* Move create new option for publish to top
* Move New tag to description
* fix
* Open project to default location (#16910)
* Have create proj from database show default save location as option (#16909)
* Default create proj location to setting
* update icons
* undo
* Put search/ status/refresh in single line (#16898)
* add horizontal scroll bar to output (#16918)
* Fix extension linting warnings and enable extension linting in pipelines (#16922)
* Fix extension linting errors
* fix test
* Update public preview readme for sql migration extension (#16920)
* Add sql bindings package reference to project (#16912)
* list packages and add packages working
* cleanup and remove list packages
* cleanup
* change to pull in latest package version
* Add STS root folder override (#16927)
* Add STS root folder override
* Display message to user
* Show once for any service
* Fix some unhandled promise lint errors (#16924)
* Moved items around to handle new untitledQueryEditorInput location (#16914)
* moved items around to handle new untitledQueryEditorInput location
* added editor inputs to constants.
* added interface for untitledQueryEditorInput
* added IUntitledQueryEditorInput
* Revert "added IUntitledQueryEditorInput"
This reverts commit 67955eb289458e7ac4e7e5ce0ee077f38ed82a2c.
* Revert "added interface for untitledQueryEditorInput"
This reverts commit 88552dbd811b643fd51d5d21f4571b677d7bfc73.
* Revert "Revert "added interface for untitledQueryEditorInput""
This reverts commit 13a89c40e4cb0a3fa495f5b150c066892387e509.
* Revert "Revert "added IUntitledQueryEditorInput""
This reverts commit 8b2258ab49275a271a39036ea1734feca98ee753.
* added extends for IUntitledQueryEditorInput
* added casting in editorGroupView
* Revert "added casting in editorGroupView"
This reverts commit 61500ea43690b08ba2393808a8d118abc60da4ac.
* Revert "Moved items around to handle new untitledQueryEditorInput location (#16914)"
This reverts commit 87a663ee6b7cc3330c0528b20fb74f557451f911.
* Revert "Fix some unhandled promise lint errors (#16924)"
This reverts commit 73218a840df188f1ae26ff1c2e1aa5b85b9cfcb0.
* Revert "Add STS root folder override (#16927)"
This reverts commit 35936d464f2e452cd29659fffef20018ac6ffdd4.
* Revert "Add sql bindings package reference to project (#16912)"
This reverts commit 72d29ed7a7d298716ba159548af1f08adc82db25.
* Revert "Update public preview readme for sql migration extension (#16920)"
This reverts commit 3b3c3921557aabe86c927e6a833c0c41b48f7e23.
* Revert "Fix extension linting warnings and enable extension linting in pipelines (#16922)"
This reverts commit f5ea3e69ae5132c09eba699e8c25d1a1a66e0914.
* Revert "add horizontal scroll bar to output (#16918)"
This reverts commit 76bf86a2536edfe84b0f323571e489d69fe9fe00.
* Revert "Put search/ status/refresh in single line (#16898)"
This reverts commit d9553d09141c159e8b1cc27f6422e51b68800c7c.
* Revert "Have create proj from database show default save location as option (#16909)"
This reverts commit 88b9b7734b467a2552dfeea9c844b90361a660de.
* Revert "Open project to default location (#16910)"
This reverts commit a46170b347a28ff77f40883b055153823a86308e.
* Revert "Move create new option for publish to top and filter out system dbs (#16908)"
This reverts commit 4be47daf63771b6c3b12b786ba687dfc6ca0e3c6.
* Revert "Modify treeDataChange event (#125214) (#16907)"
This reverts commit 4161c21abcc78a9b5a65e52ae7d7f960ea71219b.
* Revert "Enable scripting for triggers and other objects (#16885)"
This reverts commit 2ece3ffb12478faf0f49df1e66bcc7acc0631500.
* Revert "add autoCutoverConfiguration to getMigrationStatus (#16803)"
This reverts commit 366633e7247d508138b45e902d7e034c79763dec.
* Revert "Update sqlite version for smoke tests (#16903)"
This reverts commit 64f66d7b18418b028cfa56b984d6f9979f65cc50.
* Revert "disable cancel button after clicked once (#16783)"
This reverts commit 12044e30746f44188d46a781f582781bf3638762.
* Revert "Undo merge icon change (#16894)"
This reverts commit 0801d14267a9980a2c29374666ad7fee14dfcafb.
* Revert "reset the icon before use (#16896)"
This reverts commit 971c39e8bc5c774fb49d81c5c36617ec45b4078c.
* Revert "Fix duplicate editor windows on reload (#16893)"
This reverts commit 4df3085b09b645a3ef2728c3ab3778fb7a63f2ba.
* Revert "Bump VS Code version to latest sync point (#16891)"
This reverts commit c1bc6639efcdf69d9b9c57cc44af3a1d19514f83.
* Revert "Merge from vscode e3c4990c67c40213af168300d1cfeb71d680f877 (#16569)"
This reverts commit c92da9c02ee221ca69813af69b039d3f3846aa42.
* Revert "fix refresh node and add sample (#16888)"
This reverts commit df820f6c03d167d933d089bfadf5296a7dcaf834.
* Revert "Add setting for enabling using new markdown renderer (#16864)"
This reverts commit e3c036dfbaa0a1e1588f348eb9eb4a7edb4f9bda.
* Revert "take screenshot of failed test before close editor (#16876)"
This reverts commit d466b19a6e56a43654c779c1dab60724b1f0c3db.
* fix spaces
* changed uri to public
* fixed formatting on azdata.proposed
* added queryprovider at the end
* changed already in connections list message.
* added notifyconnectionurichanged
* added changes to fix
* fixed testQueryModelService
* fixed leftover stuff
* more renames
* Added small changes
* added messages to untitledQueryEditorInput
* added work in progress fileQueryEditorInput save as
* fixed space
* removed changeUri
* remove saveAs from queryEditorInput
* removed undefined from createFileQueryEditorInput in untitled.
* changed saveAs for fileQueryEditorInput
* changed saveAs to use createInstance
* bumped version of STS in config.json
* bump version of dataprotocol-client
* update to yarn.lock
* more changes
* removed space for untitledQueryEditorInput
* some refactoring done
* removed already has provider check due to existing provider still existing
* added a comment
* fixed typo
* change results order around
* added already existing connection message
* restored untitledQueryEditorInput
* removed message
* added existing connection
* Revert "added existing connection"
This reverts commit 3cc34f6b1e670bb7b257e046f53560471badfd34.
* add try catch to restore older overwrite file behavior
* added types and error handling
* added error comments.
* changed message of both files
* fixed formatting for azdata.proposed.d.ts
Co-authored-by: Lucy Zhang <luczhan@microsoft.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: stuti149 <87131830+stuti149@users.noreply.github.com>
Co-authored-by: Rachel Kim <rackim@microsoft.com>
Co-authored-by: Karl Burtram <karlb@microsoft.com>
Co-authored-by: Barbara Valdez <34872381+barbaravaldez@users.noreply.github.com>
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
- Use the onDrop method for moving notebooks/sections in the Notebooks Tree View.
- Allow multi selection in tree view
- Modify notebook commands to only show when a single tree item is selected.
* added azuremonitor, need to work on cms
* finished CMS, need to do Kusto and MSSQL
* Added kusto, need to finish mssql
* added some strings need to finish mssql
* finished MSSQL
* WIP 1
* Add parentName to azdata
* Add some additional types for scripting
* Add parent type name to support view subobjects
* bump dependencies and address review comments
* Enable Azure Data Studio's database selector to behave like the one in SSMS
* Revert "Enable Azure Data Studio's database selector to behave like the one in SSMS"
This reverts commit d146eef998a3192f76df80794a31a45c8be7f786.
* Database selector auto commits selection
* Adds comment explaining change
* Auto commits selected database on blur
* Confirms db name changed before committing db selection
* Moves changed db check to selected database method
* Makes use of dbName instead of having to get value from dropdown
* Code review change
* Adding support for aad connections in import extension
* Adding support for AAD by passing azure account token
* Adding a test for aad connections and fixing broken tests
* removing extra await
* formatting
* update comment
* format doc
* fix connection test
* remove unused imports
* test server info mock
* try with mocks
* add server info check for tests
* added logic for corner case
* Added back Don't Ask Again logic
* If no Azure CLI found, throw error instead of returning undefined.
* Deleted 'restart ADS' text for arcdata extension prompts
* Added error catch for parse version and parsed out the * in az --version
* Added back findAz()
* Added arcdata version to AzTool. Parse --version using regex.
* Return undefined if no az found.
* Added userRequested param for findAz
* No longer await on extension activate. Re-added some functions for az install.
* Install works for windows
* Changed auto install for az on Linux and MacOS.
* Added comment for findSpecificAzAndArc and uncommented some localizedConstants
* Added comment for getSemVersionArc and took out the path for some tests.
* Made findSpecificAzAndArc return an object instead of a list
* Removed azToolService test
* Removed azToolService tests and renamed suite to azcli Extension Tests
* Got rid of new Regexp for regex in parseVersions
* Added back azToolService.ts
* Added logic to enable prompt user to install arcdata extension and auto-install capability. No update capability yet.
Co-authored-by: Candice Ye <canye@microsoft.com>
* empty table shows no backup file image
* string displayed modified and empty table text will only be displayed after checking function _shouldDisplayBackupFileTable
* format fix
* format changes
* format fix
* Merge conflict resolution
* Throw error for unsupported versions of Dotnet
* Fix for darwin
* Fix for all platforms
* Address comments
* Fix extensionsGaller.json
* Address comments
* Update default installation path for linux
* Fix test
* Revert default installation location change for Linux
* Address comments
* Removed extra try-catch block
* Fix query database drop-down rendering location after resize
* Revert "Fix query database drop-down rendering location after resize"
This reverts commit 62481a93e696d4fa79ce40ecef3a2567a65dd20c.
* Fixes drop down list rendering issues by closing the list on window
resize
* comment providing the explanation for new listener and checks if list is visible before hiding
* initial quick pick
* move constants
* remove commented code for now
* addressing comments
* update name
* update name in other places
* remove azure functions from name and rename file
* Automatically add intermediate folders for SQL project items.
While using the SQL database projects through the API, I noticed that project may end up in somewhat inconsistent state, where files will be added to the project, but their parent folders will not. This in turn resulted in failure to remove these folders from project - they will show up in the UI tree, but deleting them will cause an error. In order to align with how Visual Studio manages the projects, this change will ensure that all intermediate folders are present in the project, when new files or folders are added.
While this change improves project "correctness" when accessing it through SQL projects extension APIs, there is still a possibility that someone will open an "incorrect" previously created project. This change does not address it and folder removal may still fail.
* Update the code to never throw on duplicate items when adding files and folders to project.
After a conversation with the sqlproj owners, we agreed that there are no scenarios that would prompt us to throw an error, if duplicate item is being added to the project. Ultimately, the goal of such a request would be to have an item in the project file, which is already present, therefore the call becomes a no-op.
This allowed me to simplify the new code that was ensuring all intermediate folders are present in the project when adding files and folders.
* Add CodeQL Analysis workflow (#10195)
* Add CodeQL Analysis workflow
* Fix path
* Fixed UI regression in main
* removed the file which should not been included
* Addressed PR comments
* Addressed PR
Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
* Initial implementation of drag and drop api (#122239)
* Add drag and drop controller (#123542)
* Tree data transfer dnd (#128666)
* add drop method to sql files
Co-authored-by: Alex Ross <alros@microsoft.com>
* Changed azdata to az in azcli extension and resource-deployment, and some arc. Removed user, pass, url from controller connect blade. Commented out tests. Ported over work from old branch.
* Changed unit tests, all unit tests passing. Changed parameters to new ones, fixed some Controller Connect issues.
* Connect data controller and create dc working.
* Changed az back to azdata in necessary places in resource-deployment.
* Changed notebook values and added namespace to some params.
* Added some changes from PR to this branch
* Changed azdata.ts to az.ts and changed subscription parameter
* Brought over changes from azcli PR into this branch.
* added endpoint, username, password to getIsPassword
* Changed notebooks to use proper az params, hard coded in some values to verify it is working, removed some variableNames from package.json.
* Changed -sc to --storage-class in notebook
* Added namespace to SQL deploy, deleted dc create in api
* Deleted more dc create code and uncommented findAz() with unfinished work on Do Not Ask Again.
* Removed (preview) from extensions/arc and extensions/azcli excluding preview:true in package.json
* Commented out install/update prompts until DoNotAskAgain is implemented
* Fixed bugs: JSON Output errors are now being caught, --infrastructure now has a required UI component with dropdown options, config page loads properly, SQL create flags use full names instead of shortnames.
* Adds validation to pg extensions and bug fixes (#16486)
* Extensions
* Server parameters
* Change locaiton of postgres extensions, pr fixes
* Change location of list
* List spacing
* Commented out Don't Ask Again prompt implementation.
* Uncommented header of a test file.
* Added Azure CLI arcdata extension to Prerequisites
* Reverted package.json and yarn.lock
* Took away casting of stderr and stdout in executeCommand.
* Deleted override function for initializeFields in connectControllerDialog.ts
* Removed fakeAzApi for testing and added back in (Preview)
* Removed en-us from python notebook links.
* Deleted azdata tool from tool tests in resource-deployment
* Deleted another instance of azdata in tool test
* Add back in azdata tooltype
* Remove en-us
* Replaced AzdataTool in typings
* Reverting adding azdata tool back in
* Changed Azdata to AzdataToolOld
* Added back azdata tool type
* Added AzdataToolOld to tool types
* fix test
Co-authored-by: Candice Ye <canye@microsoft.com>
Co-authored-by: nasc17 <nasc@microsoft.com>
Co-authored-by: nasc17 <69922333+nasc17@users.noreply.github.com>
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* Adding support for sending additional headers in azure http requests
* Added session ids in all azure rest calls
* Fixed param name
* Adding default parameter value for request headers
* Changed azdata to az in azcli extension and resource-deployment, and some arc. Removed user, pass, url from controller connect blade. Commented out tests. Ported over work from old branch.
* Changed unit tests, all unit tests passing. Changed parameters to new ones, fixed some Controller Connect issues.
* Connect data controller and create dc working.
* Changed az back to azdata in necessary places in resource-deployment.
* Changed notebook values and added namespace to some params.
* Reverted all changes that are not in azcli. Also deleted some unused variables in azcli constants.ts and some tests.
* Fixed package.json
* Deleted en-us from links, changed az. to azcli.arc in package.json
* Addressed PR comments.
Co-authored-by: Candice Ye <canye@microsoft.com>
* Added missing resources to chinaAzureSettings and germanyAzureSettings in providerSettings
* Update providerSettings.ts
* Fixed typo in mooncake armResource
* Fixed host for China Cloud in ProviderSettings
* Adding telemetry for assessment
* Removing dms loading fix
* Fixing PR
* removing collection of account id
* moving database warning count to the server assessment event
* Removing individual warning and issue events
* Adding aggregates for database issues and warnings
* removing extra line
* Adding other telemetry events in sql migration
* Fixed changes made in the PR
* Fixing attribute names
* Consolidating issues and errors in 1 event
* Converting dependencies to dev depenedencies
* Adding a catch for the telemetry function
* moving the non type uuid to non dev
* Made hashmap code cleaner
* Fixing cutover start time
* Fixing object creation
* Reverting back to old method.
* Modifying the date time to js objects
* Converting issues and warnings to json object
* LEGO: check in for main to temporary branch.
* Update sql-migration.xlf.lcl
* Update sql-migration.xlf.lcl
Co-authored-by: Alex Ma <alma1@microsoft.com>
* Add aria labels to pod drop down on resource health and tables on overview
* Added roles
* Fix strings
* Added role to table headers
* Added heading levels
Allow plotly to resize based on the size of the output itself, not only when the window is resized. This allows cells in Notebook Views to adjust based on resize.
The autodash feature in notebook views creates an initial grid layout for users when a view is created. It is intended to reduce the effort required by the user to start editing their view. Instead of displaying every cell and stacking them vertically like the default notebook layout, we use guidelines to determine which cells are worth displaying and how to arrange them.
* Transition to withProps in arc
* Transition to withProps inputbox
* Transition to withProps in checkbox
* Transition to withProps text
* Transition to withProps in declarative table
* Transition to withProps hyperlink
* Transition to withProps in button
* Transition to withProps radiobutton
* Transition to withProps in input
* Transition to withProps button
* Transition to withProps in text
* Transition to withProps image
* Transition to withProps declare table
* Transition to withProps in table
* Transition to withProps radio button
* Transition to withProps in image
* Transition to withProps radio button
* Transition to withProps in commit
* Transition to withProps div cont
* Transition to withProps in comp
* Transition to withProps radio card
* Transition to withProps in comp icon
* Transition to withProps card
* Transition to withProps list
* Adding option to treat hyperlinks as buttons
* Adding ext host endpoints for is button property in hyperlinks
* Removing isButton flag and plugging in aria role in the hyperlink component
* Removing attribute null check
* Update for German Resources
* added strings for Spanish XLFs
* added french resource xlfs
* massive commit on 7/18/21
* another update to extensions and sql
* add migrations status context menu and commands
* add migration status images
* remove test code, add account validation
* fix command registration to occure once
* fix typo
* add target platform as an option in create project api
* move constant
* WIP
* show versions in dialog and create project with selected version
* validate version
* add error messages
* add test
* change version to target platform
* cleanup
* more cleanup
* use withProps
* add aria-label / name to image only buttons
* add correct aria label to image buttons
* add key number to button aria-label, title and action messages to differentient keys
* update to existing german extensions
* Update for existing Spanish Resources
* Added updates to existing French Resources
* update for Italian Resources
* Update for existing Japanese resources
* update for Korean resources
* update for Portuguese resources
* russian resources updated
* update for chinese resources
* Fixing some assessment styling
* Adding styling capabilities to loading component.
* Changing assessment loader height from px to %
* using margin-top instead of height to align loader
This repository includes configuration for a development container for working with Code - OSS in an isolated local container or using [GitHub Codespaces](https://github.com/features/codespaces).
[](https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/microsoft/vscode)
> **Tip:** The default VNC password is `vscode`. The VNC server runs on port `5901` with a web client at `6080`. For better performance, we recommend using a [VNC Viewer](https://www.realvnc.com/en/connect/download/viewer/). Applications like the macOS Screen Sharing app will not perform as well.
This repository includes configuration for a development container for working with Code - OSS in a local container or using [GitHub Codespaces](https://github.com/features/codespaces).
> **Tip:** The default VNC password is `vscode`. The VNC server runs on port `5901` and a web client is available on port `6080`.
## Quick start - local
If you already have VS Code and Docker installed, you can click the badge above or [here](https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/microsoft/vscode) to get started. Clicking these links will cause VS Code to automatically install the Remote - Containers extension if needed, clone the source code into a container volume, and spin up a dev container for use.
1. Install Docker Desktop or Docker for Linux on your local machine. (See [docs](https://aka.ms/vscode-remote/containers/getting-started) for additional details.)
2.**Important**: Docker needs at least **4 Cores and 6 GB of RAM (8 GB recommended)** to run full build. If you on macOS, or using the old Hyper-V engine for Windows, update these values for Docker Desktop by right-clicking on the Docker status bar item, going to **Preferences/Settings > Resources > Advanced**.
2.**Important**: Docker needs at least **4 Cores and 8 GB of RAM** to run a full build. If you are on macOS, or are using the old Hyper-V engine for Windows, update these values for Docker Desktop by right-clicking on the Docker status bar item and going to **Preferences/Settings > Resources > Advanced**.
> **Note:** The [Resource Monitor](https://marketplace.visualstudio.com/items?itemName=mutantdino.resourcemonitor) extension is included in the container so you can keep an eye on CPU/Memory in the status bar.
@@ -16,53 +20,56 @@ This repository includes configuration for a development container for working w

> Note that the Remote - Containers extension requires the Visual Studio Code distribution of Code - OSS. See the [FAQ](https://aka.ms/vscode-remote/faq/license) for details.
> **Note:** The Remote - Containers extension requires the Visual Studio Code distribution of Code - OSS. See the [FAQ](https://aka.ms/vscode-remote/faq/license) for details.
4. Press <kbd>Ctrl/Cmd</kbd> + <kbd>Shift</kbd> + <kbd>P</kbd> and select **Remote - Containers: Open Repository in Container...**.
4. Press <kbd>Ctrl/Cmd</kbd> + <kbd>Shift</kbd> + <kbd>P</kbd> or <kbd>F1</kbd> and select **Remote-Containers: Clone Repository in Container Volume...**.
> **Tip:** While you can use your local source tree instead, operations like `yarn install` can be slow on macOS or using the Hyper-V engine on Windows. We recommend the "open repository" approach instead since it uses "named volume" rather than the local filesystem.
> **Tip:** While you can use your local source tree instead, operations like `yarn install` can be slow on macOS or when using the Hyper-V engine on Windows. We recommend the "clone repository in container" approach instead since it uses "named volume" rather than the local filesystem.
5. Type `https://github.com/microsoft/vscode` (or a branch or PR URL) in the input box and press <kbd>Enter</kbd>.
6. After the container is running, open a web browser and go to [http://localhost:6080](http://localhost:6080) or use a [VNC Viewer](https://www.realvnc.com/en/connect/download/viewer/) to connect to `localhost:5901` and enter `vscode` as the password.
6. After the container is running, open a web browser and go to [http://localhost:6080](http://localhost:6080), or use a [VNC Viewer](https://www.realvnc.com/en/connect/download/viewer/) to connect to `localhost:5901` and enter `vscode` as the password.
Anything you start in VS Code or the integrated terminal will appear here.
Anything you start in VS Code, or the integrated terminal, will appear here.
Next: **[Try it out!](#try-it)**
## Quick start - GitHub Codespaces
> **IMPORTANT:** You need to use a "Standard" sized codespace or larger (4-core, 8GB) since VS Code needs 6GB of RAM to compile. This is now the default for GitHub Codespaces, but do not downgrade to "Basic" unless you do not intend to compile.
1. From the [microsoft/vscode GitHub repository](https://github.com/microsoft/vscode), click on the **Code** dropdown, select **Open with Codespaces**, and then click on **New codespace**. If prompted, select the **Standard** machine size (which is also the default).
1. From the [microsoft/vscode GitHub repository](https://github.com/microsoft/vscode), click on the **Code** dropdown, select **Open with Codespaces**, and the **New codespace**
> **Note:** You will not see these options within GitHub if you are not in the Codespaces beta.
> Note that you will not see these options if you are not in the beta yet.
2. After the codespace is up and running in your browser, press <kbd>Ctrl/Cmd</kbd> + <kbd>Shift</kbd> + <kbd>P</kbd> or <kbd>F1</kbd> and select **Ports: Focus on Ports View**.
2.After the codespace is up and running in your browser, press <kbd>F1</kbd> and select **Ports: Focus on Ports View**.
3.You should see **VNC web client (6080)** under in the list of ports. Select the line and click on the globe icon to open it in a browser tab.
3. You should see port `6080` under **Forwarded Ports**. Select the line and click on the globe icon to open it in a browser tab.
> If you do not see port `6080`, press <kbd>F1</kbd>, select **Forward a Port** and enter port `6080`.
> **Tip:** If you do not see the port, <kbd>Ctrl/Cmd</kbd> + <kbd>Shift</kbd> + <kbd>P</kbd> or <kbd>F1</kbd>, select **Forward a Port** and enter port `6080`.
4. In the new tab, you should see noVNC. Click **Connect** and enter `vscode` as the password.
Anything you start in VS Code or the integrated terminal will appear here.
Anything you start in VS Code, or the integrated terminal, will appear here.
Next: **[Try it out!](#try-it)**
### Using VS Code with GitHub Codespaces
You will likely see better performance when accessing the codespace you created from VS Code since you can use a[VNC Viewer](https://www.realvnc.com/en/connect/download/viewer/). Here's how to do it.
You may see improved VNC responsiveness when accessing a codespace from VS Code client since you can use a[VNC Viewer](https://www.realvnc.com/en/connect/download/viewer/). Here's how to do it.
1.[Create a codespace](#quick-start---github-codespaces) if you have not already.
1. Install [Visual Studio Code Stable](https://code.visualstudio.com/) or [Insiders](https://code.visualstudio.com/insiders/) and the the [GitHub Codespaces extension](https://marketplace.visualstudio.com/items?itemName=GitHub.codespaces).
2. Set up [VS Code for use with GitHub Codespaces](https://docs.github.com/github/developing-online-with-codespaces/using-codespaces-in-visual-studio-code)
> **Note:** The GitHub Codespaces extension requires the Visual Studio Code distribution of Code - OSS.
3. After the VS Code is up and running, press <kbd>F1</kbd>, choose **Codespaces: Connect to Codespace**, and select the codespace you created.
2. After the VS Code is up and running, press <kbd>Ctrl/Cmd</kbd> + <kbd>Shift</kbd> + <kbd>P</kbd> or <kbd>F1</kbd>, choose **Codespaces: Create New Codespace**, and use the following settings:
-`microsoft/vscode` for the repository.
- Select any branch (e.g. **main**) - you can select a different one later.
- Choose **Standard** (4-core, 8GB) as the size.
4. After you've connected to the codespace, use a [VNC Viewer](https://www.realvnc.com/en/connect/download/viewer/) to connect to `localhost:5901` and enter `vscode` as the password.
4. After you have connected to the codespace, you can use a [VNC Viewer](https://www.realvnc.com/en/connect/download/viewer/) to connect to `localhost:5901` and enter `vscode` as the password.
5. Anything you start in VS Code or the integrated terminal will appear here.
> **Tip:** You may also need change your VNC client's **Picture Quality** setting to **High** to get a full color desktop.
5. Anything you start in VS Code, or the integrated terminal, will appear here.
Next: **[Try it out!](#try-it)**
@@ -70,20 +77,18 @@ Next: **[Try it out!](#try-it)**
This container uses the [Fluxbox](http://fluxbox.org/) window manager to keep things lean. **Right-click on the desktop** to see menu options. It works with GNOME and GTK applications, so other tools can be installed if needed.
Note you can also set the resolution from the command line by typing `set-resolution`.
> **Note:** You can also set the resolution from the command line by typing `set-resolution`.
To start working with Code - OSS, follow these steps:
1. In your local VS Code, open a terminal (<kbd>Ctrl/Cmd</kbd> + <kbd>Shift</kbd> + <kbd>\`</kbd>) and type the following commands:
1. In your local VS Code client, open a terminal (<kbd>Ctrl/Cmd</kbd> + <kbd>Shift</kbd> + <kbd>\`</kbd>) and type the following commands:
```bash
yarn install
bash scripts/code.sh
```
Note that a previous run of `yarn install` will already be cached, so this step should simply pick up any recent differences.
2. After the build is complete, open a web browser or a [VNC Viewer](https://www.realvnc.com/en/connect/download/viewer/) to the desktop environnement as described in the quick start and enter `vscode` as the password.
2. After the build is complete, open a web browser or a [VNC Viewer](https://www.realvnc.com/en/connect/download/viewer/) to connect to the desktop environment as described in the quick start and enter `vscode` as the password.
3. You should now see Code - OSS!
@@ -91,7 +96,7 @@ Next, let's try debugging.
1. Shut down Code - OSS by clicking the box in the upper right corner of the Code - OSS window through your browser or VNC viewer.
2. Go to your local VS Code client, and use Run / Debug view to launch the **VS Code** configuration. (Typically the default, so you can likely just press <kbd>F5</kbd>).
2. Go to your local VS Code client, and use the **Run / Debug** view to launch the **VS Code** configuration. (Typically the default, so you can likely just press <kbd>F5</kbd>).
> **Note:** If launching times out, you can increase the value of `timeout` in the "VS Code", "Attach Main Process", "Attach Extension Host", and "Attach to Shared Process" configurations in [launch.json](../.vscode/launch.json). However, running `scripts/code.sh` first will set up Electron which will usually solve timeout issues.
# This dockerfile is used to build up from a base image to create an image with cached results of running "prepare.sh".
# This dockerfile is used to build up from a base image to create an image a cache.tar file containing the results of running "prepare.sh".
# Other image contents: https://github.com/microsoft/vscode-dev-containers/blob/master/repository-containers/images/github.com/microsoft/vscode/.devcontainer/base.Dockerfile
# Syntax can be found here: https://docs.github.com/free-pro-team@latest/github/creating-cloning-and-archiving-repositories/about-code-owners#codeowners-syntax
comment:"We need more info to debug your particular issue. If you could attach your logs to the issue (ensure no private data is in them), it would help us fix the issue much faster.
First open the Settings page, find the `Mssql: Tracing Level` setting and change that to `All` then restart ADS and repro your issue.
There are two types of logs to collect:
Next there are two types of logs to collect:
**Console Logs**
@@ -25,3 +27,27 @@ There are two types of logs to collect:
- Run the command: **`Developer: Open Logs Folder`**
- This will open the log folder locally. Please zip up this folder and attach it to the issue."
# actions for Needs Logs - Azure label
Needs Logs - Azure:
comment:"We need more info to debug your Azure Active Directory issue. If you could attach your logs to the issue (ensure no private data is in them), it would help us fix the issue much faster.
- In the settings menu, find the setting titled `Azure: Logging Level` and select the `Verbose` option
- Run the process that produces your error
- Open command palette (Click **View** -> **Command Palette**)
- Run the command: **`Developer: Open Logs Folder`**
- Follow this path to find the Azure Accounts log file: `[default log folder]/exthost1/output_logging_[earliest timestamp]/#-Azure Acounts.log`
- Please attach the Azure-Accounts.log file to the issue."
# actions for Out of Scope label
Out of Scope:
comment:"Thank you for opening this suggestion! This enhancement is not planned in our
medium-term roadmap. The issue is being closed to reduce active issues to focus on
enhancements that are being considered for an upcoming release. We will review closed issues
with the 'Out of Scope' label when doing long-term planning."
"value": "### Categorizing Issues\n\nEach issue must have a type label. Most type labels are grey, some are yellow. Bugs are grey with a touch of red.",
"value": "## tl;dr: Triage Inbox\n\nAll inbox issues but not those that need more information. These issues need to be triaged, e.g assigned to a user or ask for more information",
"editable": true
"value": "## tl;dr: Triage Inbox\n\nAll inbox issues but not those that need more information. These issues need to be triaged, e.g assigned to a user or ask for more information"
},
{
"kind": 2,
"language": "github-issues",
"value": "$inbox -label:\"needs more info\"",
"editable": true
},
{
"kind": 1,
"language": "markdown",
"value": "##### `Config`: defines the inbox query",
"editable": true
"value": "$inbox -label:\"needs more info\" sort:created-desc"
"value": "New issues or pull requests submitted by the community are initially triaged by an [automatic classification bot](https://github.com/microsoft/vscode-github-triage-actions/tree/master/classifier-deep). Issues that the bot does not correctly triage are then triaged by a team member. The team rotates the inbox tracker on a weekly basis.\n\nA [mirror](https://github.com/JacksonKearl/testissues/issues) of the VS Code issue stream is available with details about how the bot classifies issues, including feature-area classifications and confidence ratings. Per-category confidence thresholds and feature-area ownership data is maintained in [.github/classifier.json](https://github.com/microsoft/vscode/blob/main/.github/classifier.json). \n\n💡 The bot is being run through a GitHub action that runs every 30 minutes. Give the bot the opportunity to classify an issue before doing it manually.\n\n### Inbox Tracking\n\nThe inbox tracker is responsible for the [global inbox](https://github.com/microsoft/vscode/issues?utf8=%E2%9C%93&q=is%3Aopen+no%3Aassignee+-label%3Afeature-request+-label%3Atestplan-item+-label%3Aplan-item) containing all **open issues and pull requests** that\n- are neither **feature requests** nor **test plan items** nor **plan items** and\n- have **no owner assignment**.\n\nThe **inbox tracker** may perform any step described in our [issue triaging documentation](https://github.com/microsoft/vscode/wiki/Issues-Triaging) but its main responsibility is to route issues to the actual feature area owner.\n\nFeature area owners track the **feature area inbox** containing all **open issues and pull requests** that\n- are personally assigned to them and are not assigned to any milestone\n- are labeled with their feature area label and are not assigned to any milestone.\nThis secondary triage may involve any of the steps described in our [issue triaging documentation](https://github.com/microsoft/vscode/wiki/Issues-Triaging) and results in a fully triaged or closed issue.\n\nThe [github triage extension](https://github.com/microsoft/vscode-github-triage-extension) can be used to assist with triaging — it provides a \"Command Palette\"-style list of triaging actions like assignment, labeling, and triggers for various bot actions.",
"editable": true
},
{
"kind": 1,
"language": "markdown",
"value": "## All Inbox Items\n\nAll issues that have no assignee and that have neither **feature requests** nor **test plan items** nor **plan items**.",
"editable": true
"value": "##### `Config`: defines the inbox query"
"value": "New issues or pull requests submitted by the community are initially triaged by an [automatic classification bot](https://github.com/microsoft/vscode-github-triage-actions/tree/master/classifier-deep). Issues that the bot does not correctly triage are then triaged by a team member. The team rotates the inbox tracker on a weekly basis.\n\nA [mirror](https://github.com/JacksonKearl/testissues/issues) of the VS Code issue stream is available with details about how the bot classifies issues, including feature-area classifications and confidence ratings. Per-category confidence thresholds and feature-area ownership data is maintained in [.github/classifier.json](https://github.com/microsoft/vscode/blob/main/.github/classifier.json). \n\n💡 The bot is being run through a GitHub action that runs every 30 minutes. Give the bot the opportunity to classify an issue before doing it manually.\n\n### Inbox Tracking\n\nThe inbox tracker is responsible for the [global inbox](https://github.com/microsoft/vscode/issues?utf8=%E2%9C%93&q=is%3Aopen+no%3Aassignee+-label%3Afeature-request+-label%3Atestplan-item+-label%3Aplan-item) containing all **open issues and pull requests** that\n- are neither **feature requests** nor **test plan items** nor **plan items** and\n- have **no owner assignment**.\n\nThe **inbox tracker** may perform any step described in our [issue triaging documentation](https://github.com/microsoft/vscode/wiki/Issues-Triaging) but its main responsibility is to route issues to the actual feature area owner.\n\nFeature area owners track the **feature area inbox** containing all **open issues and pull requests** that\n- are personally assigned to them and are not assigned to any milestone\n- are labeled with their feature area label and are not assigned to any milestone.\nThis secondary triage may involve any of the steps described in our [issue triaging documentation](https://github.com/microsoft/vscode/wiki/Issues-Triaging) and results in a fully triaged or closed issue.\n\nThe [github triage extension](https://github.com/microsoft/vscode-github-triage-extension) can be used to assist with triaging — it provides a \"Command Palette\"-style list of triaging actions like assignment, labeling, and triggers for various bot actions."
},
{
"kind": 1,
"language": "markdown",
"value": "## All Inbox Items\n\nAll issues that have no assignee and that have neither **feature requests** nor **test plan items** nor **plan items**."
"value": "### Bug Verification Queries\n\nBefore shipping we want to verify _all_ bugs. That means when a bug is fixed we check that the fix actually works. It's always best to start with bugs that you have filed and the proceed with bugs that have been filed from users outside the development team. ",
"editable": true
"value": "### Bug Verification Queries\n\nBefore shipping we want to verify _all_ bugs. That means when a bug is fixed we check that the fix actually works. It's always best to start with bugs that you have filed and the proceed with bugs that have been filed from users outside the development team. "
},
{
"kind": 1,
"language": "markdown",
"value": "#### Config: update list of `repos` and the `milestone`",
"editable": true
"value": "#### Config: update list of `repos` and the `milestone`"
* Fixed bug that caused folders in the servers tree to display incorrect contents [#21245](https://github.com/microsoft/azuredatastudio/issues/21245)
## Version 1.40.0
* Release date: November 16, 2022
* Release status: General Availability
### What's new in 1.40.0
| New Item | Details |
|----------|---------|
| Connections | Connections for SQL now default to Encrypt = 'True'. |
| ARM64 Support for macOS | ARM64 build for macOS is now available. |
| Table Designer | Announcing the General Availability of the Table Designer. |
| Table Designer | Period columns now added by default when System-Versioning table option is selected. |
| Table Designer | Added support for hash indexes for In-Memory tables, and added support for columnstore indexes. |
| Table Designer | New checkbox added, "Preview Database Updates", when making database changes to ensure that users are aware of potential risks prior to updating the database.|
| Table Designer | "Move Up" and "Move Down" buttons added to support column reordering for Primary Keys. |
| Query Plan Viewer | Announcing the General Availability of the Query Plan Viewer in Azure Data Studio. |
| Query Plan Viewer | Added support for identification of most expensive operator(s) in a plan. |
| Query Plan Viewer | Updates were made to the properties window to allow for full display of text upon hovering over a cell. Full text can also be copied. |
| Query Plan Viewer | Implemented filter functionality in the Properties pane for an execution plan. |
| Query Plan Viewer | Added support for collapsing and expanding all subcategories within the Plan Comparison Properties window. |
| Query History Extension | Announcing the General Availability of the SQL History Extension. |
| Query History Extension | Now includes ability to persist history across multiple user sessions. |
| Query History Extension | Added the ability to limit the number of entries stored in the history. |
| Schema Compare | Users can now open .scmp files directly from the context menu for existing files in the file explorer. |
| Query Editor | Now allows full display for text strings larger than 65,535 characters. |
| Query Editor | Added support for the SHIFT key when making multiple cell selections. |
| MySQL Extension | Support for MySQL extension is now available in preview. |
| Azure SQL Migration Extension | Azure SQL Database Offline Migrations is now available in preview. Customers can use this new capability to save and share reports as needed. |
| Database Migration Assessment for Oracle | Assessment tooling for Oracle database migrations to Azure Database for PostgreSQL and Azure SQL available in preview. |
| VS Code merge | VS Code merges to version 1.67. Read [their release notes](https://code.visualstudio.com/updates/v1_67) to learn more. |
| SQL Database Projects | Adds SQL projects support for syntax introduced in SQL Server 2022.|
### Bug fixes in 1.40.0
| New Item | Details |
|----------|---------|
| Connections | Fixed bug that occurred when trying to connect to the Dedicated Admin Connection (DAC) on SQL Server. |
| Connections | Fixed issue with wrong tenant showing up while trying to connect to a database with Azure Active Directory login. |
| Connections | Fixed zoom reset behavior when adding a new connection. |
| Connections | Fixed loading bug what occurred when attempting to sign in to Azure via proxy. |
| Connections | Fixed issue encountered while attempting to connect to a "sleeping" Azure SQL Database. |
| Object Explorer | Fixed the SELECT script generation issue for Synapse Databases. |
| Schema Compare | Fixed error that caused duplication of comment headers when applying schema changes on stored procedure objects. |
| Schema Compare | Fixed issue that prevented schema compare issues when creating a new empty schema with a "DOMAIN\User" pattern. |
| Query Editor | Fixed bug that caused results to be lost upon saving query files. |
| Table Designer | Fixed a bug that caused creation of a new table when renaming an existing table. |
| Query Plan Viewer | Fixed missing index recommendation T-SQL syntax. |
| SQL Projects | Fixed bug in SQL Projects that led to extension not using output path when publishing a project. |
| SQL Projects | Fixed bug that caused .NET install to not be found when using the SQL Projects extension on Linux platforms. |
## Version 1.39.1
* Release date: August 30, 2022
* Release status: General Availability
## What's new in 1.39.1
* Bug fixes in 1.39.1
* Fixed bug that caused Database Trees in server connections to not expand in the Object Explorer.
## Version 1.39.0
* Release date: August 24, 2022
* Release status: General Availability
## What's new in 1.39.0
* New Features:
* Deployment Wizard - Azure Data Studio now supports SQL Server 2022 (Preview) in the Deployment Wizard for both local and container installation.
* Object Explorer - Added Ledger icons and scripting support to Object Explorer for Ledger objects.
* Dashboard - Added hexadecimal values to support color detection.
* Query Plan Viewer - Added the ability to copy text from cells in the Properties Pane of a query plan.
* Query Plan Viewer - Introduced a "find node" option in plan comparison to search for nodes in either the original or added plan.
* Table Designer - Now supports the ability to add included columns to a nonclustered index, and the ability to create filtered indexes.
* SQL Projects - Publish options were added to the Publish Dialog.
* Query History Extension - Added double-click support for query history to either open the query or immediately execute it, based on user configuration.
* Bug Fixes:
* Dashboard - Fixed an accessibility issue that prevented users from being able to access tooltip information using the keyboard.
* Voiceover - Fixed a bug that caused voiceover errors across the Dashboard, SQL Projects, SQL Import Wizard, and SQL Migration extensions.
* Schema Compare - Fixed a bug that caused the UI to jump back to the top of the options list after selecting/deselecting any option.
* Schema Compare - Fixed a bug involving Schema Compare (.SCMP) file incompatibility with Database Project information causing errors when reading and using information stored in this file type.
* Object Explorer - Fixed a bug that caused menu items in Object Explorer not to show up for non-English languages.
* Table Designer - Fixed a bug that caused the History Table name not to be consistent with the current table name when working with System-Versioned Tables.
* Table Designer - Fixed a bug in the Primary Key settings that caused the "Allow Nulls" option to be checked, but disabled, preventing users from changing this option.
* Query Editor - Fixed a bug that prevented the SQLCMD in T-SQL from working correctly, giving false errors when running scripts in Azure Data Studio.
* Query Editor - Fixed a bug that caused user-specified zoom settings to reset to default when selecting JSON values after query that returned JSON dataset was ran.
* SQL Projects - Fixed a bug that caused the "Generate Script" command to not work correctly when targeting a new Azure SQL Database.
* Notebooks - Fixed a bug that caused pasted images to disappear from editor after going out of edit mode.
* Notebooks - Fixed a bug that caused a console error message to appear after opening a markdown file.
* Notebooks - Fixed a bug that prevented markdown cell toolbar shortcuts from working after creating a new split view cell.
* Notebooks - Fixed a bug that caused text cells to be erroneously created in split view mode when the notebook default text edit mode was set to "Markdown".
## Version 1.38.0
* Release date: July 27, 2022
* Release status: General Availability
## What's new in 1.38.0
* New Features:
* VS Code merges to 1.62 - This release includes updates to VS Code from the three previous VS Code releases. Read [their release notes](https://code.visualstudio.com/updates/v1_62) to learn more.
* Table Designer - New column added to Table Designer for easier access to additional actions specific to individual rows.
* Query Plan Viewer - The Top Operations pane view now includes clickable links to operations in each of its rows to show the runtime statistics which can be used to evaluate estimated and actual rows when analyzing a plan.
* Query Plan Viewer - Improved UI on selected operation node in the Execution Plan.
* Query Plan Viewer - The keyboard command **CTRL + M** no longer executes queries. It now just enables or disables the actual execution plan creation when a query is executed.
* Query Plan Viewer - Plan labels are now updated in the Properties window when plans are compared and the orientation is toggled from horizontal to vertical, and back.
* Query Plan Viewer - Updates were made to the Command Palette. All execution plan commands are prefixed with "Execution Plan", so that they are easier to find and use.
* Query Plan Viewer - A collapse/expand functionality is now available at the operator level to allow users to hide or display sections of the plan during analysis.
* Query History - The Query History extension was refactored to be fully implemented in an extension. This makes the history view behave like all other extension views and also allows for searching and filtering in the view by selecting the view and typing in your search text.
* Bug Fixes:
* Table Designer - Error found in edit data tab when switching back to previously selected column when adding a new row. To fix this, editing the table is now disabled while new rows are being added and only reenabled afterwards.
* Query Editor - Fixed coloring issues for new T-SQL functions in the Query Editor.
* Query Plan Viewer - Fixed bug that caused custom zoom level spinner to allow values outside valid range.
* Dashboard - Fixed issue that caused incorrect displaying of insight widgets on the dashboard.
* Notebooks - Fixed issue where keyboard shortcuts and toolbar buttons were not working when first creating a Split View markdown cell.
* Notebooks - Fixed issue where cell languages were not being set correctly when opening an ADS .NET Interactive notebook in VS Code.
* Notebooks - Fixed issue where notebook was being opened as empty when exporting a SQL query as a notebook.
* Notebooks - Disables install and uninstall buttons in Manage Packages dialog while a package is being installed or uninstalled.
* Notebooks - Fixed issue where cell toolbar buttons were not refreshing when converting cell type.
* Notebooks - Fixed issue where notebook was not opening if a cell contains an unsupported output type.
* Schema Compare - Fixed issue where views and stored procedures were not correctly recognized by schema compare after applying changes.
## Version 1.37.0
* Release date: June 15, 2022
* Release status: General Availability
## What's new in this version
* New Features:
* Backup & Restore - Backup & Restore to URL is now available in preview for Azure SQL Managed Instances.
* Table Designer - Added API to support computed column capabilities on Table Designer.
* Table Designer - Can now specify where to add new columns and columns can now be re-arranged by mouse dragging.
* Table Designer - Table Designer is now supported by SQL Projects to add or modify database schema without need to be connected to a server instance.
* Query Plan Viewer - Smart plan comparison is now available. Can now compare execution plans and view detailed differences between plans in the Properties Table.
* Query Plan Viewer - Added toggle button to switch between estimated and actual execution plans.
* Query Plan Viewer - Query Plan now comes with improved precision to operator costs for larger plans.
* MongoDB Extension for Azure Cosmos DB (Preview) - This extension introduces support for access to Mongo resources for Cosmos DB.
* Bug Fixes:
* Table Designer - Fixed issue that caused app to not prompt user to save before closing.
* Table Designer - Fixed issue that returned empty data set upon attempting to edit the first cell of a new row.
* Table Designer - Improved resize to fit experience when zooming in on user interface as well as tab behavior issues.
* Query Plan Viewer - Fixed bug that caused custom zoom level spinner to allow values outside valid range.
* Schema Compare - Fixed issue with indexes not being added correctly when updating project from database.
* Notebooks - Fixed inconsistencies with notebook cell behavior and toolbars.
* Notebooks - Fixed issues with keyboard navigation.
## Version 1.36.2
* Release date: May 20, 2022
* Release status: General Availability
## What's new in this version
- Fix connectivity issue with PBI data source
- Fix query plan zoom and icon issues
- Issues fixed in this release https://github.com/microsoft/azuredatastudio/milestone/89?closed=1
## Version 1.36.1
* Release date: April 22, 2022
* Release status: General Availability
## What's new in this version
* April Hotfix addressing these issues https://github.com/microsoft/azuredatastudio/milestone/88?closed=1.
- General Availability of the Azure SQL Migration Extension for ADS
- Support for .NET Interactive Notebooks Extension
- New Table Designer Features including support for System Versioned, Graph and Memory Optomized Tables
- Query Plan Viewer Updates includign warning and parallelism icons, the option to disable tooltips and support for opening .sqlplan files
- Improvements in SQL Projects and Schema Compare
## Version 1.35.1
* Release date: March 17, 2022
* Release status: General Availability
## Hotfix release
- Fix for [Excel number format #18615](https://github.com/microsoft/azuredatastudio/issues/18615)
- Fix for [Geometry Data Type Returned as Unknown Charset in Results Grid #18630](https://github.com/microsoft/azuredatastudio/issues/18630)
## Version 1.35.0
* Release date: February 24, 2022
* Release status: General Availability
## What's new in this version
* New Features:
* Table Designer - Added functionality for creation and management of tables for SQL Servers. Built using DacFx framework
* Query Plan Viewer - Added functionality for users to view a graphic view of estimated and actual query plans without need for an extension
* Azure Arc Extension - Updated the Data Controller deployment wizard and the SQL Managed Instance - Azure Arc deployment wizard to reflect the deployment experience in Azure Portal
* Bug Fixes:
* Azure Arc Extension - SQL Managed Instance-Azure Arc is now fixed for both indirect connectivity mode and direct connectivity mode
* Notebooks - Support for keyboard navigation between cells to minimize mouse clicking
## Version 1.34.0
* Release date: December 15, 2021
* Release status: General Availability
## What's new in this version
* New Features:
* Added “Currently restoring backup file” in the migration progress details page of Azure SQL Migration extension when backup files location is Azure Storage blob container
* Enhancements to diagnostics in Azure SQL Migration extension
* Support for project build with .NET 6 in SQL Database Projects extension
* Publish to container in SQL Database Projects extension
* Undo and redo support for notebook cell-level operations
* Extension Updates:
* Azure SQL Migration
* Langpacks
* SQL Database Projects
* Bug Fixes:
* Fix for multiple database migrations when using network share as backup files location in Azure SQL Migration extension
* Fix for multiple database migrations when using blob storage containers as backup files location in Azure SQL Migration extension
* Fix to pre-populate target database names in the migration wizard in Azure SQL Migration extension
* Fix to column sorting in grids where the presence of null values could lead to unexpected results
* Fix for Python upgrades when two or more notebooks were open
## Version 1.33.1
* Release date: Nov 4, 2021
* Release status: General Availability
## Hotfix release
- Fix for [#16535 Unable to See Saved Connections in Restricted Mode](https://github.com/microsoft/azuredatastudio/issues/17535)
- Fix for [#17579 Can't type in Notebook code cell after editing text cell](https://github.com/microsoft/azuredatastudio/issues/17579)
## Version 1.33.0
* Release date: October 27, 2021
* Release status: General Availability
## What's new in this version
* New Notebook Features:
* Notebook Views
* Split cell support
* Keyboard shortcuts for Markdown Toolbar Cells
* Ctrl/Cmd + B = Bold Text
* Ctrl/Cmd + I = Italicize Text
* Ctrl/Cmd + U = Underline Text
* Ctrl/Cmd + Shift + K = Add Code Block
* Ctrl/Cmd + Shift + H = Highlight Text
* Book improvements
* Add a new section
* Drag and Drop
* Extension Updates:
* Import
* Langpacks
* Schema Compare
* Sql Database Projects
* Bug Fixes
* Notebook linking improvements
* Horizontal Scrollbar improvement (when word wrap is off in MD Splitview / MD mode) in Notebooks
* Vertical Scrollbar improvement for MD Splitview in Notebooks
## Version 1.32.0
* Release date: August 18, 2021
* Release status: General Availability
* Extension Updates:
* Arc/Az CLI extensions - Azure Arc extension now uses Azure CLI instead of Azure Data CLI for deploying and interacting with Azure Arc
instances
* Langpacks
* SQL Database Projects
* Azure Monitor
* Machine Learning
## Version 1.31.1
* Release date: July 29, 2021
* Release status: General Availability
## Hotfix Release
- Fix for [#16436 Database Connection Toolbar Missing](https://github.com/microsoft/azuredatastudio/issues/16436)
## Version 1.31.0
* Release date: July 21, 2021
* Release status: General Availability
* New Notebook Features:
* WYSIWYG link improvements
* Extension Updates:
* Import
* SandDance
* SQL Database Projects
* Bug Fixes
* Accessibility bug fixes
## Version 1.30.0
* Release date: June 17, 2021
* Release status: General Availability
* New Notebook Features:
* Show book's notebook TOC title in pinned notebooks view
* Add new book icon
* Add new book icon
* Update Python to 3.8.10
* Query Editor Features:
* Added filtering/sorting feature for query result grid in query editor and notebook, the feature can be invoked from the column headers. Note that this feature is only available when you enable the preview features
@@ -14,7 +290,7 @@
* SQL Database Projects
* Machine Learning
* Bug Fixes
* Fix WYSIWYG Table cell adding new line in table cell
* Fix WYSIWYG Table cell adding new line in table cell
[](https://gitter.im/Microsoft/sqlopsstudio?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
Some files were not shown because too many files have changed in this diff
Show More
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.