* Changelog for 1.45 (#23987)
(cherry picked from commit 283686df18)
* fixing the minor changelog issue Cheena pointed out where the table didnt format correctly (#23989)
(cherry picked from commit a7491170c3)
* Port request of title generation removal
* added fix to CMS
* added updated mainthread
* Revert "added updated mainthread"
This reverts commit a5806555a17bb7495c5a3573a98bd36a0f361785.
* Revert "added fix to CMS"
This reverts commit 2b8c24f09e4d7eadfcd047bbc554285ebd9811bc.
* Revert "Port request of title generation removal"
This reverts commit e6a2302778c9fd580f1f3d6de72c5037c14d815b.
* Remove/comment out connection title generation from all areas. (#23873)
---------
Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>
* Add limit on the file size that can be opened with Open XEL feature
* Add limit on the file size that can be opened and post a notification for large files
* Update wording
* Use FileService interface instead of fs to fix layering rules
* Fix error when opening create project from db dialog without connection
* Update extensions/sql-database-projects/src/dialogs/createProjectFromDatabaseDialog.ts
---------
Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com>
* Makes use of xvfb to run unit tests
* Restore test script as before, but with xvfb
* Use same command that worked in CLI
* Add --build CLI arg
* Add coverage arg
* Revert change to core unit test script
* Reset core unit tests script in linux pipeline
* Revert "Skip flaky vscode test suites (#23535)"
This reverts commit 882bdb3aab.
* Revert "Disable failing vscode test suite (#23539)"
This reverts commit 562a0ce595.
* Revert "Disable vscode remote configuration suite (#23545)"
This reverts commit 40fa1cebd8.
* Revert "Disable editor resolver service test suite (#23550)"
This reverts commit cd68dca844.
* Revert "Disable upstream extension enablement suite (#23557)"
This reverts commit faf3c6976e.
* Revert "Skip a few more suites impacted by xterm issue (#23589)"
This reverts commit 1662cedf17.
# Conflicts:
# src/vs/workbench/contrib/experiments/test/electron-sandbox/experimentService.test.ts
* Use DOM Renderer for tests
* Remove extra whitespace
* Update comment
* Initial set of changes for opening XEL files in ADS
* Code cleanup and update STS version
* Fix runtime errors
* Address comments
* Address comments and update Start button to be disabled for file session
* Code cleanup
* Initial commit for adding a basic general tab for the database properties
* Refactoring for dialog inputs
* removed properties nodeType and using database node and additional cleanup, diabling the functionality.
* Changes according to STS data fetch
* Reuse database Dialog
* Undo contract file change
* more refactoring
* fetched scrollbar fix into this PR
* Tabbed panel is being used for horizontal tabs
* stying fix for general tab button
* final commit for today :)
* Updates according to STS changes
* missed updates
* Refactored updates
* moved options as discussed and added collapsible sections... need to fix scroll bar
* Fixing the horizontal scroll bar of tabbedpanel
* initial updates
* need to fix the error!
* rror fixed and options are loading with sample values
* need to load real values for all felds and map values to dropdown options
* Dd loading correctly, need to add validation to recovery field and save options back
* refactor
* removing nullable property
* All changes done except recoveryTime validation
* Refactoring
* all values are saving as expected, isDirty flag is fixed. Todo: recovery validation and tests
* added general section for the options tab
* modifying pageVerify and userAccess to string array
* updates to general section of options tb
* disabling couple of general properties for MI
* Adding server edition conditions and toggling the UI options
* adding numeric validation to the recovey time
* Removing serveInfo logic and using the unsupported options approach from STS
* addressing comments and little code refactor
* changes with nullOrUndefined helper method
* replacing dropdowns with checkboxes
* adding unit test for helper method
* removed commented sample code and added comments
* initial changes for making a QDS report with placeholders
* Add icon for configure button
* Add another example report to show layout
* move files
* add placeholder names to components and cleanup toolbar
* cleanup
* switch to createViews() instead of createTop and BottomSections()
* add QueryStoreView class for the different components in a report
* cleanup
* add more comments
* fix yarn not running for query store extension folder
* add missing break
* change one more view to container
* Reenable extension unit tests
* Turn off Notebook Trust test cases
* Skip another failing notebook trust test
* Limit scope of disabled tests to only folder scenarios
* log when an editor action doesn't run because of enablement
* notebooks create/dispose editors. this means controllers must be created eagerly (😢) and that notebooks need a custom way of plugging comparision keys for session. works unless creating another session for the same cell of a duplicated editor
* Set offSide to sql lang configuration to true (#183461)
* Fixes#181764 (#183550)
* fix typo
* Always scroll down and focus the input (#183557)
* Fixes#180386 (#183561)
* cli: ensure ordering of rpc server messages (#183558)
* cli: ensure ordering of rpc server messages
Sending lots of messages to a stream would block them around the async
tokio mutex, which is "fair" so doesn't preserve ordering. Instead, use
the write_loop approach I introduced to the server_multiplexer for the
same reason some time ago.
* fix clippy
* update for May endgame
* testing: allow invalidateTestResults to take an array (#183569)
* Document `ShareProvider` API proposal (#183568)
* Document `ShareProvider` API proposal
* Remove mention of VS Code from JSDoc
* Add support for rendering svg and md in welcome message (#183580)
* Remove toggle setting more eagerly (#183584)
* rm message abt macOS
* Change text (#183589)
* Change text
* Accidentally changed the wrong file
* cli: improve output for code tunnel status (#183571)
* testing: allow invalidateTestResults to take an array
* cli: improve output for code tunnel status
Fixes#183570
* [json/css/html] update services (#183595)
* Add experimental setting to enable this dialog
* Fix exporting chat model to JSON before it is initialized (#183597)
* minimum scrolling to reveal the next cell on shift+enter (#183600)
do minimum scrolling to reveal the next cell on Execute cell and select next
* Fixing Jupyter notebook issue 13263 (#183527)
fix for the issue, still need to understand why there is strange focusing
* Tweak proposed API JSDoc (#183590)
* Tweak proposed API JSDoc
* workbench -> workspace
* fix ? operator
* Use active editor and show progress when sharing (#183603)
Use active editor and show progress
* use scroll setting variable correctly
* Schedule welcome widget to show once between typing. (#183606)
* Schedule dialog to show once between typing
* Don't re-render if already displayed once
* Add F10 keybinding for debugger step, even on Web. (#183510)
Fixes#181792.
Previously, for Web the keyboard shortcut was Alt-F10, because it was
believed that F10 could not be bound on browsers. This turned out to be
incorrect, so we make the shortcut consistent (F10) with desktop VSCode
which is also what many other debuggers use.
We keep Alt-F10 on web as a secondary keybinding to keep the experience
some web users may have gotten used to by now.
* Also pass process.env
* Restore missing chat clear commands (#183651)
* chore: update electron@22.5.4 (#183716)
* Show remote indicator in web when remoteAuthority is set (#183728)
* feat: .vuerc as json file (#153017)
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
* Delete --compatibility=1.63 code from the server (#183738)
* Copy vscode.dev link to tunnel generates an invalid link when an untitled workspace is open (#183739)
* Recent devcontainer display string corrupted on Get Started page (#183740)
* Improve "next codeblock" navigation (#183744)
* Improve "next codeblock" navigation
Operate on the current focused response, or the last one, and scroll to the selected item
* Normalize command title
* Git - run git status if similarityThreshold changes (#183762)
* fix aria-label issue in kb editor
fixes A11y_GradeB_VSCode_Keyboard shortcut reads words together - Blind: Arrow key navigation to row Find the binding keys and "when" cell data are read together resulting in a word " CTRL + FeditorFocus instead of CTRL + F editorFocus" #182490
* Status - fix compact padding (#183768)
* Remove angle brackets from VB brackets (#183782)
Fixes#183359
* Update language config schema with more details about brackets. (#183779)
* fix comment (#183812)
* Support for `Notebook` CodeAction Kind (#183457)
* nb kind support -- wip
* allow notebook codeactions around single cell edit check
* move notebook code action type out of editor
---------
Co-authored-by: rebornix <penn.lv@gmail.com>
* cli: fix connection default being applied (#183827)
* cli: bump to openssl 1.1.1u (#183828)
* Implement "delete" action for chat history (#183609)
* Use desired file name when generating new md pasted file paths (#183861)
Fixes#183851
* Default to filename for markdown new file if empty (#183864)
Fixes#183848
* Fix small typo (#183865)
Fixes#183819
* Noop when moving a symbol into the file it is already in (#183866)
Fixes#183793
* Adjust codeAction validation to account for notebook kind (#183859)
* Make JS/TS `go to configuration` commands work on non-`file:` file systems (#183688)
Make `go to project` commands work on non-`file:` file systems
Fixes#183685
* Can't do regex search after opening notebook (#183884)
Fixes#183858
* Default to current dir for `move to file` select (#183875)
Fixes#183870
`showOpenDialog` seems to ignore `defaultUri` if the file doesn't exist
* Use `<...>` style markdown links when needed (#183876)
Fixes#183849
* Remove check for context keys
* Update xterm package
* Enable updating a chat model without triggering incremental typing (#183894)
* Enable chat "move" commands on empty sessions (#183895)
* Enable chat "move" commands on empty sessions
and also imported sessions
* Fix command name
* Fix some chat keybindings on windows (#183896)
* "Revert File" on inactive editors are ignored (fix#177557) (#183903)
* Empty reason while switching profile (fix#183775) (#183904)
* fix https://github.com/microsoft/vscode-internalbacklog/issues/4278 (#183910)
* fix https://github.com/microsoft/vscode/issues/183770 (#183914)
* code --status displays a lot of errors before actual status output (fix#183787) (#183915)
* joh/icy manatee (#183917)
* Use idle value for widget of interactive editor controller
https://github.com/microsoft/vscode/issues/183820
* also make preview editors idle values
https://github.com/microsoft/vscode/issues/183820
* Fix#183777 (#183929)
* Fix#182309 (#183925)
* Tree checkbox item -> items (#183931)
Fixes#183826
* Fixes#183909 (#183940)
* Fix#183837 (#183943)
fix#183837
* Git - fix#183941 (#183944)
* Update xterm.css
Fixes#181242
* chore: add @ulugbekna and @aiday-mar to my-endgame notebook (#183946)
* Revert "When snippet mode is active, make `Tab` not accept suggestion but advance placeholder"
This reverts commit 50a80cdb61511343996ff1d41d0b676c3d329f48.
* revert not focusing completion list when quick suggest happens during snippet
* change `snippetsPreventQuickSuggestions` default to false
* Fix#181446 (#183956)
* fix https://github.com/microsoft/vscode-internalbacklog/issues/4298 (#183957)
* fix: remove extraneous incorrect context keys (#183959)
These were actually getting added in getTestItemContextOverlay, and the test ID was using the extended ID which extensions do not know about.
Fixes#183612
* Fixes https://github.com/microsoft/monaco-editor/issues/3920 (#183960)
* fix https://github.com/microsoft/vscode-internalbacklog/issues/4324 (#183961)
* fix#183030
* fix#180826 (#183962)
* make message more generic for interactive editor help
* .
* fix#183968
* Keep codeblock toolbar visible when focused
* Fix when clause on "Run in terminal" command
* add important info to help menu
* fix#183970
* Set `isRefactoring` for all TS refactoring edits (#183982)
* consolidate
* Disable move to file in TS versions < 5.2 (#183992)
There are still a few key bugs with refactoring. We will ship this as a preview for TS 5.2+ instead of for 5.1
* Polish query accepting (#183995)
We shouldn't send the same request to Copilot if the query hasn't changed. So if the query is the same, we short circut.
Fixes https://github.com/microsoft/vscode-internalbacklog/issues/4286
Also, when we open in chat, we should use the last accepted query, not what's in the input box.
Fixes https://github.com/microsoft/vscode-internalbacklog/issues/4280
* Allow widget to have focus (#184000)
So that selecting non-code text works.
Fixes https://github.com/microsoft/vscode-internalbacklog/issues/4294
* Fix microsoft/vscode-internalbacklog#4257. Mitigate zindex for zone widgets. (#184001)
* Change welcome dialog contribution to Eventually
* Misc fixes
* Workspace folder picker entry descriptions are suboptimal for some filesystems (fix#183418) (#184018)
* cli - ignore std error unless verbose (#183787) (#184031)
* joh/inquisitive meerkat (#184034)
* only stash sessions that are none empty
https://github.com/microsoft/vscode-internalbacklog/issues/4281
* only unstash a session once - unless new exchanges are made,
https://github.com/microsoft/vscode-internalbacklog/issues/4281
* account for all exchange types
* Improve declared components (#184039)
* make sure to read setting (#184040)
d'oh, related to https://github.com/microsoft/vscode/issues/173387#issuecomment-1571696644
* [html] update service (#184049)
[html] update service. FIxes#181176
* reset context keys on reset/hide (#184042)
fixes https://github.com/microsoft/vscode-internalbacklog/issues/4330
* use `Lazy`, not `IdleValue` for the IE widget held by the eager controller (#184048)
https://github.com/microsoft/vscode/issues/183820
* fix https://github.com/microsoft/vscode-internalbacklog/issues/4333 (#184067)
* use undo-loop instead of undo-edit when discarding chat session (#184063)
* use undo-loop instead of undo-edit when discarding chat session
fixes https://github.com/microsoft/vscode-internalbacklog/issues/4118
* fix tests, wait for correct state
* Add logging to node download (#184070)
Add logging to node download. For #182951
* re-enable default zone widget revealing when showing (#184072)
fixes https://github.com/microsoft/vscode-internalbacklog/issues/4332, also fixes https://github.com/microsoft/vscode-internalbacklog/issues/3784
* fix#178202
* Allow APIs in stable (#184062)
* Fixmicrosoft/vscode-internalbacklog#4206. Override List view whitespace css for monaco editor (#184087)
* Fix JSDoc grammatical error (#184090)
* Pick up TS 5.1.3 (#184091)
Fixes#182931
* Misc fixes
* update distro (#184097)
* chore: update electron@22.5.5 (#184116)
* Extension host veto is registered multiple times on restart (fix#183778) (#184127)
Extension host veto is registered multiple times on restart (#183778)
* Do not auto start the local web worker extension host (#184137)
* Allow embedders to intercept trustedTypes.createPolicy calls (#184136)
Allow embedders to intercept trustedTypes.createPolicy calls (#184100)
* fix: reading from console output for --status on windows and linux (#184138)
fix: reading from console output for --status on windows and linux (#184118)
* Misc fixes
* code --status displays a lot of errors before actual status output (fix#183787) (#184200)
fix 183787
* (cherry-pick to 1.79 from main) Handle galleryExtension failure in featuredExtensionService (#184205)
Handle galleryExtension failure in featuredExtensionService (#184198)
Handle galleryExtension failure
* Fix#184183. Multiple output height updates are skipped. (#184188)
* Post merge init fixes
* Misc build issues
* disable toggle inline diff of `alt` down
https://github.com/microsoft/vscode-internalbacklog/issues/4342
* Take into account already activated extensions when computing running locations (#184303)
Take into account already activated extensions when computing running locations (fixes#184180)
* Avoid `extensionService.getExtension` and use `ActivationKind.Immediate` to allow that URI handling works while resolving (#184310)
Avoid `extensionService.getExtension` and use `ActivationKind.Immediate` to allow that URI handling works while resolving (fixes#182217)
* WIP
* rm fish auto injection
* More breaks
* Fix Port Attributes constructor (#184412)
* WIP
* WIP
* Allow extensions to get at the exports of other extensions during resolving (#184487)
Allow extensions to get at the exports of other extensions during resolving (fixes#184472)
* do not auto finish session when inline chat widgets have focus
re https://github.com/microsoft/vscode-internalbacklog/issues/4354
* fix compile errors caused by new base method
* WIP
* WIP
* WIP
* WIP
* Build errors
* unc - fix path traversal bypass
* Bump version
* cherry-pick prod changes from main
* Disable sandbox
* Build break from merge
* bump version
* Merge pull request #184739 from max06/max06/issue184659
Restore ShellIntegration for fish (#184659)
* Git - only add --find-renames if the value is not the default one (#185053)
Git - only add --find-renames if the value is not the default one (#184992)
* Cherry-pick: Revert changes to render featured extensions when available (#184747)
Revert changes to render featured extensions when available. (#184573)
* Lower timeouts for experimentation and gallery service
* Revert changes to render extensions when available
* Add audio cues
* fix: disable app sandbox when --no-sandbox is present (#184913)
* fix: disable app sandbox when --no-sandbox is present (#184897)
* fix: loading minimist in packaged builds
* Runtime errors
* UNC allow list checks cannot be disabled in extension host (fix#184989) (#185085)
* UNC allow list checks cannot be disabled in extension host (#184989)
* Update src/vs/base/node/unc.js
Co-authored-by: Robo <hop2deep@gmail.com>
---------
Co-authored-by: Robo <hop2deep@gmail.com>
* Add notebook extension
* Fix mangling issues
* Fix mangling issues
* npm install
* npm install
* Issues blocking bundle
* Fix build folder compile errors
* Fix windows bundle build
* Linting fixes
* Fix sqllint issues
* Update yarn.lock files
* Fix unit tests
* Fix a couple breaks from test fixes
* Bump distro
* redo the checkbox style
* Update linux build container dockerfile
* Bump build image tag
* Bump native watch dog package
* Bump node-pty
* Bump distro
* Fix documnetation error
* Update distro
* redo the button styles
* Update datasource TS
* Add missing yarn.lock files
* Windows setup fix
* Turn off extension unit tests while investigating
* color box style
* Remove appx
* Turn off test log upload
* update dropdownlist style
* fix universal app build error (#23488)
* Skip flaky bufferContext vscode test
---------
Co-authored-by: Johannes <johannes.rieken@gmail.com>
Co-authored-by: Henning Dieterichs <hdieterichs@microsoft.com>
Co-authored-by: Julien Richard <jairbubbles@hotmail.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Megan Rogge <merogge@microsoft.com>
Co-authored-by: meganrogge <megan.rogge@microsoft.com>
Co-authored-by: Rob Lourens <roblourens@gmail.com>
Co-authored-by: Connor Peet <connor@peet.io>
Co-authored-by: Joyce Er <joyce.er@microsoft.com>
Co-authored-by: Bhavya U <bhavyau@microsoft.com>
Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
Co-authored-by: Aaron Munger <aamunger@microsoft.com>
Co-authored-by: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Co-authored-by: rebornix <penn.lv@gmail.com>
Co-authored-by: Ole <oler@google.com>
Co-authored-by: Jean Pierre <jeanp413@hotmail.com>
Co-authored-by: Robo <hop2deep@gmail.com>
Co-authored-by: Yash Singh <saiansh2525@gmail.com>
Co-authored-by: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com>
Co-authored-by: Ulugbek Abdullaev <ulugbekna@gmail.com>
Co-authored-by: Alex Ross <alros@microsoft.com>
Co-authored-by: Michael Lively <milively@microsoft.com>
Co-authored-by: Matt Bierner <matb@microsoft.com>
Co-authored-by: Andrea Mah <31675041+andreamah@users.noreply.github.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Sandeep Somavarapu <sasomava@microsoft.com>
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com>
Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
Co-authored-by: Joao Moreno <Joao.Moreno@microsoft.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
* Properly close dialog with escape
* Revert "Properly close dialog with escape"
This reverts commit 9ea5ec4beebcbbd4f0623ed0b5da0f1026fcd5be.
* Remove focus on ok button in filter dialog
* Sets the focus on the filterTable
* Initial commit for adding a basic general tab for the database properties
* Refactoring for dialog inputs
* removed properties nodeType and using database node and additional cleanup, diabling the functionality.
* Changes according to STS data fetch
* Reuse database Dialog
* Undo contract file change
* more refactoring
* fetched scrollbar fix into this PR
* Tabbed panel is being used for horizontal tabs
* stying fix for general tab button
* final commit for today :)
* Updates according to STS changes
* missed updates
* Refactored updates
* moved options as discussed and added collapsible sections... need to fix scroll bar
* Fixing the horizontal scroll bar of tabbedpanel
* remove advanced options for table designer and notebook Actions title (unnecessary in usage context)
* Revert "remove advanced options for table designer and notebook Actions title (unnecessary in usage context)"
This reverts commit e30aee5151319863aebbb4738fb30354c179c2c5.
* added changes based on feedback
* added null check and updated tests
* WIP change to connection title generation
* WIP connection management service update
* fix to connectionManagementService test
* fix editorConnectionTitles
* renamed nondefault to distinguishing options
* use stored connections for options
* removed erroneous connection name set to null
* added title by ID search for title generation
* Add recent connection title
* added fix for stub bug
* added child title options appended
* WIP rework of getEditorTitle
* more work done
* WIP changes for 5-2-2023
* moved server info to generate titles.
* added reworked title generation
* added working active connection title generation and cleanup
* added comments to argument
* remove unnecessary spaces
* added id fix assign
* added fromEditor save
* Revert "Revert new connection string format (#22997)"
This reverts commit 898bb73a34.
* added small fix to tests and exclude empty properties
* made small fixes for tests
* update expected ID
* added support for old password key and removed empty options
* added in authenticationType core property
* fix for whitespace indentation
* added connection save profile to thing
* made some small fixes to connection options
* added small change to connectionDialogService
* added nullcheck for saveProfile
* added negation for connection saveProfile
* remove duplicate editor title generation
* added edit profile handling for titles
* Cleanup serverCapabilities property
* fixed dependency issues
* removed connectionproviderproperties
* added fix for treeupdateutils
* made update to title generation
* added recent connections change
* Revert "Cleanup serverCapabilities property"
This reverts commit 2c7b94f98cabddb34116dcdd83177614a484c026.
* added dashboard text and fix for connection store test
* added group name to end also temporary added dashboard changes based on feedback
* added in new SQL version
* added fix to edit connections
* added clarifying information to title generation
---------
Co-authored-by: Cheena Malhotra <cmalhotra@microsoft.com>
* Upgrading chartjs
* Upgrading charjs in exthost and removing ng2-charts
* Updating lock file
* Fixing paths in workbench for new chartjs
* Removing more any
* Removing more any
* Fixing colors
* Fixing more stuff
* Updating distro hash
* add package reference type for system db references
* Add radio buttons
* hookup
* add test
* handle changing reference type radio buttons
* cleanup
* update strings
* change style to type
* change more places with style to type
* blank lines
* add copy results to query provider
* mark as optional
* fix test stub
* Update src/sql/azdata.proposed.d.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* address comments
* update return type
---------
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Initial support for MongoDB clusters / vCore
* Get cluster connection string from arm
* Preserve Azure account for any auth type
When a service has been selected through the Azure
browser, we want to preserve the Azure account
information even if a different authentication has
been selected. This allows doing ARM operations
using the signed in Azure account for any resources
including those with a different login types such
as clusters.
* Update product pipelines to add back core integration tests to Darwin and extension unit tests to Linux
* Update whitespace
* Update indentation
* Skip failing tests for now
* Fixing server group styling
* Hiding border when the tree item are selected focused or hovered
* Fixing styles and re-enabling guides
* removing unused import
* Fixing indicator width
* wip
* Update typings
* nullable
* update test service
* support securables
* updata test data
* fix issues
* fix build failure
* update test mocks
* fix typo
* fix reference
* fix findobjectdialog issue
* update SearchResultItem type
* fix table component perf issue
* hide effective permission for server role
* hide effective permission for app role and db role
* vbump sts and fix a couple issues
* STS update and UI update
* fix user login display issue
* vbump sts
* Adding init change
* Adding filter cache in OE
* Adding more filtering changes
* Fixed stuff with dialog
* Fixing filter
* Adding support for connecitons
* Fixed stuff
* filtering
* Fixing date
* Filters
* Removing is filtering supported
* Removing contracts
* Fixing filters
* Fixing cache
* Adding some accessibility changes
* Reverting some more changes to pull in changes from the main
* Adding comments
* Fixing boolean operators
* Fixing stuff
* Fixing stuff
* Fixing error handling and making dialog generic
* Fixing more stuff
* Making filter a generic dialog
* adding erase icon
* removing floating promises
* Fixing compile issue
* Adding support for choice filter with different and actual value.
* Adding null checks
* Adding durability type fix
* Fixing filtering for providers that do not play well with empty filter properties
- Bucketized errors to track top errors
- Created separate login migration specific error to improve monitoring
---------
Co-authored-by: Akshay Mata <akma@microsoft.com>
* Compile build folder
* Fix build compile issues (#22813)
* Revert changes
* Update gulp-shell
* Test
* Update
* Update modifiers
* Try reverting minimist
* Generates linux deb artifact (#22922)
* Remove deb files that were brought in with the latest merge.
* Add debian back to linux gulp file
* Remove async from anonymous function.
* Remove run core integration tests build step in pipeline
* Revert "Remove async from anonymous function."
This reverts commit 7ad1ce2942954fce58939b9965343b46b9311a7e.
* Revert "Add debian back to linux gulp file"
This reverts commit 96b7c0f0995c8024ef67ed886da34255a5caa325.
* Revert "Remove deb files that were brought in with the latest merge."
This reverts commit bf3aae233b8da1f9111a149a96d77cc78d376094.
* Removes dependency checks
* Fix dependency gen errors
* Reenable "Build Deb" step
* Reenable publish deb
* Run core integration tests
* Revert "Run core integration tests"
This reverts commit 7cafbada194feebe771862af796fb3416b5dd686.
* Revert "Try reverting minimist"
This reverts commit 38fd843c1d5c33318a92f4bbc7057e951c5a9f71.
* Disable code coverage step intermin
---------
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com>
* Template
* Refactor
* Update strings
* Clean up
* Add clear button
* Clean up
* Fix typo and use aka.ms link
* Refactor to use GroupContainer
* Remove dialog and clean up common strings
* Fix previous/forward behavior
* Make group container default to collapsed
* Clean up
* Slightly reword string
* Add https to aka.ms link
Add troubleshooting links to error message when SQL-Migration fails to download the MigrationService as seen in this issue: #22558
---------
Co-authored-by: Akshay Mata <akma@microsoft.com>
* Adding exclude folder and base for move folder
* checkpoint
* rename
* Fixing up tests
* Adding exclude test to projController
* Adding tests
* fixing order of service.moveX() calls
* Updating move() order in sqlproj service
* PR feedback
* unskipping
* reskipping test
* Fixing folder move conditional
* updating comments
* server role dialogs
* dialogs for other types
* refactor
* find object dialog
* script button
* refactoring
* fix issues
* fix title
* vbump sts
* remove language from links
* x subscription migration support
* refresh after cutover
* fix service irregular status load behavior
* queue service status requests, fix typo
* add migationTargetServerName helper method
* save context before api call
* update vscode-mssql.d.ts
* update extensions that need updates because of the vscode-mssql.d.ts changes
* remove skip
* fix sql projects tests failing because vscode-mssql couldn't be found
* Connection URI made to include every option available instead of basic details (#22045)
* Revert "Merge remote-tracking branch 'origin' into feat/connectionUri"
This reverts commit 11b2d31bf99e216daee823f732254f69a017fee1, reversing
changes made to 36e4db8c0744f81565efdfd2f56a3ae3c0026896.
* Revert "Revert "Merge remote-tracking branch 'origin' into feat/connectionUri""
This reverts commit f439673c2693e1144c52e04c14e82cd8566c13a6.
* Added changes and fixes for feat connectionuri (#22706)
* add title generation at start
* added await to refreshConnectionTreeTitles
* Converting remaining services to use `runWithErrorHandling()`
* Updating sqlops-dataprotocolclient to 1.3.3
* upgrading dataprotocol and swapping to that baseService
* Adding async to make thenable -> promise conversion happy
---------
Co-authored-by: Alan Ren <alanren@microsoft.com>
* Add profile section in Publish project UI
* Move publish profile row below Publish Target
* Add contract for savePublishProfie and SaveProfileAs button functionality
* Make the DacFx contract functional
* Send values from UI to DacFx service call
* Fix build error
* Address comment, remove print statements
* Address comments
* Set correct connection string
* Fix functionality for rename, exclude, delete publish profiles. Add new profile to the tree and sqlproj.
* Address comment to update alignement of button
* Address comments
* Update button to use title casing
* fix http request format
* encode to utf 8 and add body for put requests
* encode proxy request body
* change ?.data to ?.body
* add note for textencoder
* change content-type to application/json
* Hide more info for assessment issues without help links
* Add info box about blob container folders
* WIP - reuse create DMS dialog for IR registration
* Revert "Add info box about blob container folders"
This reverts commit 30b8892ea7918841a6466b59058181062d367ba5.
* Add help link to target platform selection page explaining Azure SQL offerings
* Revert "WIP - reuse create DMS dialog for IR registration"
This reverts commit 5fac6b5c7148b2520cc42ce9fad549cde28baba2.
* Don't show storage account warning banner for DB scenario
* Vbump extension and migration service
* Test - fix http request format from chsuh/fixFormat
* Add instructions for table mapping and schema migration
* Revert "Test - fix http request format from chsuh/fixFormat"
This reverts commit 4992603532e98dff3b7ba6f04ba9304d173fc5ad.
* disabling revert SQLCMD var value button when no changes to values; changing string
* Updating docstring
* Updating behavior to account for SQLCMD vars defined in publish profiles
* Changing look of new OE
* Fixing styling
* Fixing moving of connected profile
* Fixing drag and drop where treenodes delete connection nodes
* Fixing Deleting and disconnecting in AsyncServerTree
* Adding constant for OE timeout
* Updated interfaces
* Removing test compilation errors
* Fixing most events in async server tree
* Fixing connection pane styling
* Fixing find node function
* Fixing some more operations
* Fixing some ops
* All operations done
* Fixed active connections
* Fixed data source
* Adding support for setting parents
* code cleanup
* Fixing icon styling issues
* Fix errors
* Fixing comment
* Fixing spacing
* Adding explanation to OE service.
* Reverting server delegate changes
* Reverting styling
* reverting more styling change
* reverting more styling
* Fixing has children
* Fixing drag and drop to tree nodes
* fixing drag and drop
* reverting timing
* fixing drag and drop
* cleaning some code
* Fixed server and group moving
* spell check
* consolidating some logic
* Fixed whitespace
* fixing moving to root group
* add new migration details
* move migraiton target type enum to utils
* address review feedback, refectore, text update
* fix variable name
* limit and filter migrations list to mi/vm/db
* Move call to STS move api into project.ts (#22071)
* move call to STS move api into project.ts
* remove undefined
* Remove convert to sdk style code (#22081)
* remove convert to sdk style code
* remove from package.json
* Merging latest from main (#22097)
* [SQL-Migration] Login migrations telemetry (#22038)
This PR enhances telemetry for login migrations (and in the following ways:
Add details for starting migration (number of logins migrating, type of logins)
Log Migration result (number of errors per step, duration of each step, type of logins, if system error occurred)
Add sql-migration extension to our telemetry
Adds details when trying to connect to target
Tracks clicking "done" from the wizard
Fixes bucketizing for navigating telemetry in the login migration wizard
Sample usage of kusto query for new telemetry:
RawEventsADS
| where EventName contains 'sql-migration'
| extend view = tostring(Properties['view'])
| extend action = tostring(Properties['action'])
| extend buttonPressed = tostring(Properties['buttonpressed'])
| extend pageTitle = tostring(Properties['pagetitle'])
| extend adsVersion = tostring(Properties['common.adsversion'])
| extend targetType = tostring(Properties['targettype'])
| extend tenantId = tostring(Properties['tenantid'])
| extend subscriptionId = tostring(Properties['subscriptionid'])
| where view contains "login"
//| where adsVersion contains "1.42.0-insider"
| where ClientTimestamp >= ago(18h)
| project EventName, ClientTimestamp, SessionId, view, pageTitle, action, buttonPressed, targetType
, tenantId, subscriptionId
, adsVersion, OSVersion, Properties
* Add Secure Enclaves dropdown with customizable Advanced options (#22019)
* Update extension READMEs (#22079)
* Fix query-history README images (#22084)
* [Loc] update to mssql and sql-migration xlf files (#22087)
* [Loc] small fix to Portuguese lcl file (#22088)
* [Loc] small fix to Portuguese lcl file
* remove newline
* Adding None bindings to the sqlProjects service (#22085)
* Adding None bindings
* updating names of None bindings
---------
Co-authored-by: AkshayMata <akam520@gmail.com>
Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Alex Ma <alma1@microsoft.com>
* Swap add and update sqlcmd variables in sql projects to use STS apis (#22086)
* delete sqlcmd variable working
* undo add
* remove variable from add and update sqlcmd variable apis
* hookup add and edit sqlcmd variable
* update vscode-mssql.d.ts
* move add and edit to project.ts
* update STS and tests
* move delete sqlcmd variable to project.ts (#22104)
* add test for add and edit sqlcmd variable (#22107)
* Swapping property access to STS (#22115)
* checkpoint
* Adding sqlproj property bindings
* Swapping out property loading and setting
* consolidating to this.sqlProjService
* Update dacpac reference to use STS api (#22116)
* Update add dacpac reference to use STS api
* remove changes for project ref
* validate unset settings from add database reference dialog
* update one more place getting sqlprojservice
* addressing comments
* fix path for dacpac reference (#22143)
* Swap add project reference to call STS (#22148)
* initial changes for swapping add project reference
* fix include path
* move common logic to helper function
* read sqlcmd variables from STS (#22147)
* Swapping .sqlproj- and crossplat compatibility-related functions to use STS (#22146)
* Supporting roundtrip
* Updating sqlproj style checks and cross-platform compatibility to use STS
* removing unnecessary awaits
* Fixing assertions
* Adding roundtrip update confirmations
* test cleanup
* cleaning up comment; localizing error
* Swap add system db reference (#22171)
* swap adding system database references
* fix tests
* remove only in test
* Read database references from STS (#22179)
* Read database references from STS
* fix system dacpac names
* fix project reference name
* Swap changeTargetPlatform to call STS (#22172)
* swap changeTargetPlatform to call STS
* Address comments
* De-duplicating enum for SystemDatabase (#22196)
* Deudping SystemDatabase enum
* simplifying enum refs
* Removing the now-unused imports code from SqlProjects (#22199)
* Removing unused importTargets entries
* whitespace; also to retrigger github checks on correct branch
* Hooking in Move() for Nones and PublishProfiles (#22200)
* Swap delete database reference to call STS (#22215)
* initial changes
* update contracts
* remove unnecessary info from SystemDatabaseReferenceProjectEntry
* uppercase master and msdb
* cleanup
* update test
* update comment
* undo change in projectController.ts
* remove unused system dacpac helper functions (#22204)
* more cleanup of project.ts (#22242)
* fix a couple database reference tests (#22248)
* Organizing sqlcmd variable and db reference code (#22284)
* organize database references and sqlcmd variable functions
* separate database reference tests
* Script and folder get + add support (#22166)
* Initial sqlobjectscripts
* adding mock filter
* test fixing
* another test passing
* swapping pre/post/none checkpoint
* awaiters
* convert addExistingItem
* swapping folders
* removing print
* stripping out project folder and file readers
* adding some regions
* Updating sqlproj style checks and cross-platform compatibility to use STS
* Updating sqlproj style checks and cross-platform compatibility to use STS
* added type property to tree items
* projectController swapovers
* removing imported targets
* Deleting the last of the TS XML parsing!
* Removing old functions
* renamed readNoneScripts to readNoneItems
* fixing path passed to STS calls
* remove system dacpac tests that were moved to DacFx (#22299)
* fix error when opening file after adding a file to sql project (#22309)
* fix error when opening file after adding a file to sql project
* remove unused import
* fix exclude for table and externalStreamingJob (#22310)
* add reload project (#22313)
* set DSP from STS (#22320)
* fix adding post-deployment script and existing item (#22317)
* Test cleanup for .sqlproj content operations (#22330)
* Fixing up tests
* sqlproj content operations tests
* remove only
* Cleanup
* Correcting collation
* cleanup constants.ts (#22336)
* fix folders not showing in project tree (#22319)
* Fix project controller tests (#22327)
* fixing ProjectController tests after swap
* remove only from database reference tests
* change system dbs back to lowercase in sql projects (#22353)
* Bump tools service
* Updated yarn.lock file
* pass SystemDacpacsLocation when building legacy style sql projects (#22329)
* Benjin/fix types (#22365)
* Updated yarn.lock file
* Fixing types
* fix projectController tests (#22375)
* Fixing the deletion flow for files and folders (#22366)
* checkpoint
* PR feedback
* Fixing up SDK-style operations project test group (#22377)
* Fixing up SDK-style project test group
* Removing .only
* Fixing up database reference tests (#22380)
* Fixing DB reference test group
* Extra cleanup
* removing only
* Consolidating None and PublishProfile; lighting up test (#22382)
* Lighting up project property tests (#22395)
* Checkpoint
* Lighting up project property tests
* removing timeout
* Fixing buildHelper test (#22400)
* Unskipping up roundtrip test (#22397)
* Refactoring database references to split literalVariable from databaseName (#22412)
* refactoring database references to split databaseVariableLiteralValue out from databaseName
* renaming more properties
* Removing branch in entry population
* removing only
* Fixing baselines for delete test
* PR feedback
* Fixing up ProjectTree tests (#22419)
* Fixing up projectTree tests
* remove only
* Updating projectController exclude test (#22413)
* Updating test
* moving filtering for external folders to readFolders() method
* Removing EntryType import
* fix ups (#22435)
* adding extra info for test failure
* hide exclude folder from context menu until it's supported (#22454)
* Adding current test name to generated folder to avoid conflicts (#22478)
* Adding current test name to generated folder to avoid conflicts
* passing correct test parameter in
* Adding trimming and entropy
* Deleting unused baselines (#22497)
* Replacing addToProject() with addSqlObjectScripts() (#22489)
* checkpoint
* Fixing test
* Updating file scraper function to filter only to .sql files (no folders, no txt)
* changing var names to reflect that the lists only contain .sql scripts
---------
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: AkshayMata <akam520@gmail.com>
Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Alex Ma <alma1@microsoft.com>
* Fixing new connection node not expanding in OE
* Fixing new connections not expanding and fixing expand request not resolving because of some provider error.
* Fixing test
* Adding a setting for node expansion timeout
* Not saving when loading tree based connections
* Adding some logs
* Removing special casing for mssql provider
* Missing providers
* Adding user toast for node expansion timeout
* Adding notification service to test
* Fixing node type for mssql
* remove polling
* Fixing onNodeStatus
* Fixing stuff
* consolidating functions
* Consolidating resolve logic
* removing extra try catch
* code cleanup
* adding size checks
* Removing commented code
* Ignoring errors from other sessions and nodepaths.
* Fix for newline replacement
* added proper null regex and null character check
* removed cell class
* removed unnecessary function
* revert back to old check
* change onbeforeeditcell
* small fix to typo in onBeforeEditCell
* made changes based on feedback
* added comments clarifying isDBCellValue
* update the rendered text onCellSourceChange
* fix test
* fix highlight in split mode
* update corresponding test
* update hasEditor with getEditor
* update event
* add comment
* Moves New Deployment to file menu bar.
* Add deployment back to breadcrumb menu
* Update extensions/resource-deployment/DEVELOPER_GUIDE.md
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Adjust new deployment mnemonic
* Remove unused localized string
---------
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
This PR enhances telemetry for login migrations (and in the following ways:
Add details for starting migration (number of logins migrating, type of logins)
Log Migration result (number of errors per step, duration of each step, type of logins, if system error occurred)
Add sql-migration extension to our telemetry
Adds details when trying to connect to target
Tracks clicking "done" from the wizard
Fixes bucketizing for navigating telemetry in the login migration wizard
Sample usage of kusto query for new telemetry:
RawEventsADS
| where EventName contains 'sql-migration'
| extend view = tostring(Properties['view'])
| extend action = tostring(Properties['action'])
| extend buttonPressed = tostring(Properties['buttonpressed'])
| extend pageTitle = tostring(Properties['pagetitle'])
| extend adsVersion = tostring(Properties['common.adsversion'])
| extend targetType = tostring(Properties['targettype'])
| extend tenantId = tostring(Properties['tenantid'])
| extend subscriptionId = tostring(Properties['subscriptionid'])
| where view contains "login"
//| where adsVersion contains "1.42.0-insider"
| where ClientTimestamp >= ago(18h)
| project EventName, ClientTimestamp, SessionId, view, pageTitle, action, buttonPressed, targetType
, tenantId, subscriptionId
, adsVersion, OSVersion, Properties
* swap rename to use DacFx project apis
* add support for rename pre/post deploy scripts and add tests
* update the enum names too
* check instanceof instead of getting and iterating through all the collections
This PR fixes an issue where the JSON-RPC Migration Service crashes when ADS is reloaded.
This situation applies when user tried to reload ADS where SQL-migration extension was running:
when connecting to DB, SQL-migration extension loads and migration service launches
if a previous MigrationService zombie process is stil running (if extension was used before), then that zombie process will have a lock on the log file
new launches of MigrationService on reloaded ADS fails b/c it can't obtain log file handle due to lock in step 2
The fix stops the MigrationService on extension deactivate and will ensure that a zombie MigrationService process isn't hanging around on reloads.
No hotfix needed as 1.4.0 was baking in insiders and has not been released to stable yet. Additionally, this mainly affects developers as they are most likely to reload ADS this way. Caveat: users do need to reload after installing latest version, however they will not hit this code path (since the migration service process is only in new versions of the extension)
* show error if trying to create or open project when no project extensions are found
* only check if project providers are available on startup and when extensions change
* addressing comments
* Update extensions/data-workspace/src/services/workspaceService.ts
use some instead of find
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
---------
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
This PR updates the JSON-RPC Migration service to the latest version. Critically, it also changes the dotnet version to 7.0. The STS dotnet version was recently changed, which changed the names of the release packages and broke our existing links.
* Read publish profiles stored in sqlproj file and present it in the projects tree
* Save publish profile and add it to sqlproj file, and present it in the tree
* Fix context menu operations
* Add tests
* Address comments
* starts of sqlprojectsservice
* copy to mssql
* adding all the boilerplate
* updating service call structures
* Fixing up test mocks
* Adding comments to all the bindings
* blank space
* swapping for Promise; adding vscode-mssql type bindings
* patching
* Fix empty name in delete connection prompt
* Update src/sql/workbench/services/objectExplorer/browser/connectionTreeAction.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
---------
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* initial commit
* leave only march release objects
* clean up
* login dialog
* localize and use background operation
* code cleanup
* remove tab
* support server role in login
* remove canEditName
* add user support
* comments and bug fixes
* remove hasDBAccess for now
* refactoring
* fix error
* user dialog UI
* telemetry, error handling and refactoring
* Fix references to dialogInfo (#21914)
* update telemetry
* Bump STS and use actual object management service
* add preview and handle no-change scenario
* fix merge issue
---------
Co-authored-by: Karl Burtram <karlb@microsoft.com>
* Read encrypt and trust server certificate
* Set hostname in certificate setting
* Address comment- open connection dialog if the connection string in publish profile doesn't load a connection, instead of throwing an error.
* Adding migration service to sql migrations
* enabling auto flush log
* Adding support for env variable
* Adding TDE Migration service
* code cleanup
* updating service downloader
* Removing custom output channel
* remove unnecessary await
* Updated service version to get latest code
* Consolidate TDE into migration service
* Sync to latest main
* Update sql-migration package version
* Fix merge conflict error
* Fixing all merge conflicts
* Fixing stuff
* removing extra whitespace
* Cleaning up
---------
Co-authored-by: Akshay Mata <akma@microsoft.com>
* WIP
* Always get latest current connection
* Update more references
* Clean up
* Clean up
* vbump
* Update comments
* Address PR feedback
* Separate into helper methods
* fix uncaught error in showSplitView
* fixed bugs around account dialog with multiple providers
* cleanup
* fix index out of bounds error
* Fire account list update after removing provider, other pr fixes
This PR fixes a regression for migration login for MI instances that was introduced in https://github.com/microsoft/azuredatastudio/pull/21776/files#diff-93c1a62583fa32d99f775b71ad27922cf31f660d10717ecc6966784306de1b6f.
After that change, support for MI would fail as MI server types were going into the Sql VM path in sqlutils because the underlying logic for isSqlServerVM() was returning wrong results.
The new approach uses the targetType set in StateMachine to extract the correct serverName for connection string based on the targetType.
Testing:
- Tested SQL VM login migration end to end
- Tested SQL MI login migration end to end
This change also bumps the sql-migration version to 1.3.0
* Add validation for new file names for sql projects
* Addres comments and add validation for new project dialog
* Address comments
* Address comments on test
* Fix tests
* Remove extra error messages and rename file
* Address comments
* Fix tests
* Add test file back
* use pathname vs nodeValue
* add test
* add comment
* only when editing in rich text
* refactor
* fix build errors
* fix hygiene errors
* remove fs check
* compare decodedUri to get correct relative paths
* Add Azure Resource 'Sql' to MSSQL extension. (#21600)
* [Loc] added sql.xlf schema (#21687)
* vbump profiler extension (#21685)
* Fix connect icon for Arc extension (#21659)
* Juno: check in to lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20230121171613142. (#21690)
* Juno: check in to lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20230122164538349. (#21693)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* Juno: check in to lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20230123164122334. (#21697)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* use normalize to get the path correctly
* add comment
* refactor
* more tests
* typo fix
---------
Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>
Co-authored-by: Alex Ma <alma1@microsoft.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Alex Hsu <csigs@users.noreply.github.com>
This PR bumps sql-migration version to 1.2.2 in order to release to insider's gallery. This also disables the LoginMigration button as we do not want to release it to public yet.
* Adding prompt for disconnect
* changing to Idialog service
* Code cleanup and fixing comments
* Adding comments and making a test async
* removing then and awaiting for function
This PR adds various login migration improvements:
- Enabled windows login by prompting user for AAD domain name if a windows login is selected
image
- Adds new login details dialog which gives granular status on each step of the login migration for each login
image
- Checks if windows login migration is supported for selected target type, and only collections source windows logins accordingly
- Perf optimization by source and target login in background of step 1 in order to significantly speed up loading of page 2
* Disable IR scenario and add info box for source < 2014
* Update text and link
* Clean up
* Fix issue where switching to another target platform wouldn't clear restriction
* Remove locale from documentation URL
* Refactor
* Clean up
* Autoselect blob scenario
* Refactor
* Add page blog check
* Clean up
* Update UI logic
* Add allow list of valid notebook command uris (#163322)
This restricts notebooks to run three command uris. These 3 commands should all be safe to run, even with untrusted inputs
* Fix incorrectly resolved merge conflict
Co-authored-by: Matt Bierner <matb@microsoft.com>
* update to langpack xlfs
* update to langpack source files
* added updated source files and dates
* Update for 12-19-2022
* Update for 12-21-2022
* update for 1/3/2023
* update to azurecore 1-9-2023
* last update to langpack source file before release
Adding collation validation in target database selection page.
collecting source database info including state, size, collation etc in the step 1 (select databases to assess and migrate)
comparing source database collation and target database collation in target selection page.
image
* change how data workspace activates project extensions
* cleanup
* undo whitespace change
* Update extensions/data-workspace/src/services/workspaceService.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* activate extensions on data workspace new and open commands
* Update extensions/data-workspace/src/services/workspaceService.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Add dropdown populated with projects in current workspace in Update Project from database dialog for target project location
* Select first from the list if no project is preselected
* Address comments
* Added initial password connection dialog box
* made small changes
* more preliminary work
* more WIP changes
* more cleanup done
* added dialog instantiation
* added placeholder dialog window
* added changePasswordController
* made some changes to changePasswordController
* some changes made
* added more changes
* more changes made to dialogue
* added password confirm box
* added WIP change password function
* small changes made to API
* small changes for test
* added uri
* added valid password
* added TODO comments
* added small change to connectionManagementService
* added connectionManagementService password change
* added comment on what to do next
* made some simplification of change password
* added response callback
* added fixes to protocol
* added throw error for passwordChangeResult
* WIP added call to self after password change
* WIP changes to implementing new password change dialog
* added changes to passwordChangeDialog
* added launchChangePasswordDialog
* remove erroneous css
* added working dialog
* removed old password change dialog
* fixed space
* added checkbox option to passwordChangeDialog
* added test signatures
* added error handling
* added some changes
* added changes to HTML for passwordChangeDialog
* added CSS to passwordChangeDialog
* added display none for matching passwords
* added documentation changes
* small cleanup
* added working error catch and retry
* added await
* added recovery instructions
* Added ok button hide for button click.
* added loading spinner
* fixed for semicolon
* added updated message
* Added message change
* added minor fixes
* added small fixes
* made more changes
* renamed messages to errorDetails
* added styling to passwordChangeDialog
* simplified error message
* changed comment
* modified azdata to be consistent
* small changes
* change to azdata for consistency
* added clarification for provider
* removed additional instructions
* Added new dialog title
* addressed feedback
* added comments
* added changes
* Adding wizard and dialog loading
* Moving apis to proposed
* fixing namespace
* Only firing event when the value changes
* Only firing when value is changed
* Adding loading complete message to dialog and wizard
* Registering listeners and making a new base interface for loading components
* Fixing api comment
* Renaming prop to loadingCompleted
* old loading icon
* hide publish to new Azure server under preview setting
* try adding additional properties instead of replacing everything in configuration
* cleanup and change to adding configuration properties instead of replacing the whole thing
* add more info in comment
* remove extra line
* Vbump and update dependent ADS version (#21179)
* [SQL Migration] Add new Azure Core API changes back in to support USGov + other non-public clouds (#20476)
* WIP - show error message for failed SKU recommendation
* WIP - run query to get correct instance name
* WIP - integrate elastic model recommendation
* Remove private endpoint restriction text
* Add feature switch for elastic recommendation
* Clean up
* Clean up
* Misc UI fixes
* Update package.json with updated azdata dependency
* Remove unused lines
* Fix broken next button
* Vbump extension to 1.0.6
* Revert "[SQL Migration] Revert dependency on new Azure Core API changes (#20469)"
This reverts commit b7a633be25.
* [SQL Migration] Add additional condition for cutover (#21178)
* Add new cutover condition
* Implement helper hasRestoreBlockingReason()
* update the default Microsoft.Build.Sql version used by sql projects
* update Microsoft.Build.Sql SDK version
* update baselines and template to also use 0.1.7-preview
* Extension unit tests continue on error
* Fix script syntax issue.
* Block syntax issue
* Remove condition expression
* Brings back condition for sql product build linux yml
* Comment out condition in ci.yml
* Adds continue on error clause to ci.yml extension unit tests
* Adds condition to extension unit tests step in ci.yml
* Adds run extension unit test case for fail on error
* Adds fail on error case to Run Extension Unit Tests script
* Explicitly states continue on error false.
* Format adjustment to yml file
* Changes default state to fail on error
* Update .github/workflows/ci.yml
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Update build/azure-pipelines/linux/sql-product-build-linux.yml
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Update build/azure-pipelines/linux/sql-product-build-linux.yml
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Brings back original comment.
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Adding column resize keyboard shortcuts in slickgrid
* Switching to standard keyboard evt
* Adding comment for the functionality
* Cleaning up code and adding more comments
* Using quick input to get column resize width
* Adding check for negative sizes
* Fixing some stuff
* added loading status to tree elements during refresh
* added message
* added lambda function
* added async
* moved addtraits to below null check
* Added debug lines for now
* added wip stack
* moved loading icon logic to inside tree item code
* added dispose logic
* Added comment explaining actions
* removed reference to NodeJs Timeout
* added showLoading status to Tree creation utils
* fixed spaces
* removed unnecessary space
* removed unnecessary timer for more responsive results
* removed call in connectionTreeActions test
* added fix to test
* stick to refresh only
* added 100 ms timeout
* added request comment
* Add TrustServerCertificate to request body
* Preselect all dbs for migration
* Make disabled checkbox not auto selected
* Clarify assessment results in card
* Fix incorrect number of dbs ready for migration without issues to MI
* Fix SQL DB assessment results incorrectly greying out dbs with MI blocking issues
* Revert "Clarify assessment results in card"
This reverts commit e8b83f3c19a20ba29133aaa68c4644b04d4154fe.
* Revert "Fix incorrect number of dbs ready for migration without issues to MI"
This reverts commit d4e10875d132dd218d95be91ae7d46672e247706.
* Revert "Fix SQL DB assessment results incorrectly greying out dbs with MI blocking issues"
This reverts commit e2a7dcd7352d1c215052a2f6f3f6130fc710eff8.
* Add new fields
* Fix null reference exception in SKU rec with save and close
* Remove unused files
* Warnings for in progress migrations in list view
* Fix unscrollable assessment results
* Fix updating SKU parameters before recommendations are ready
* Remove checksum info box
* Address PR feedback
* Update test naming convention from Electron to Core to avoid confusions
* Added comments
* Fix comment placement
* Remove CARBON EDIT from sql-* files
* Give saveAsExcel its own config options
* Wired up correctly
* Merge conflicts
* PR comments 1
Co-authored-by: Ben Russell <russellben@microsoft.com>
* add import permissions option to create project from db dialog
* change 'import' to 'include'
* update azdata dependency version
* update STS to 4.3.0.37
* fix test
* Adds context menu option placeholder plan container
* Adds context menu and button to add execution plan to placeholder
* Minor clean up
* Replaces taskbar with button to add execution plans
* Removes unneeded CSS styling.
* Adjusts button type to secondary
* Clarify assessment results in card
* Fix incorrect number of dbs ready for migration without issues to MI
* Fix SQL DB assessment results incorrectly greying out dbs with MI blocking issues
* Update error banner for blocked databases
* Reword error message
* Boilerplate for new context menu options
* Enables checkmarks for expensive operator context menu actions
* Updates azdataGraph version to 0.0.44
* Adds clearing logic to actions and retrieves additional info from nodes
* Removes unnecessary actions that aren't supported by other providers
* Finishes setting up the rest of the context menu actions
* Corrects context menu action label
* Defines new widget type for finding expensive operations
* Adds TODO for class icon name
* Creates action to open the expensive operation widget
* Adds escape and enter key shortcuts to findExpensiveOperation widget
* Styles find expensive operation widget
* Corrects class name for finding expensive operator action
* Corrects import statement.
* Code clean up
* Bumps azdataGraph version to 0.0.45
* Adds an info box for when a metric doesn't find any nodes
* Adds label to find expensive operator widget
* Invokes dispose when widget controller removes widget
* Implements disposable in all execution plan widgets.
* Adds off action to clear highlighting
* Adds a default setting and default prompt for highlighting metric
* Fixes not all code paths return error
* Removes shortcut key from text for widget actions
* Adds enum description
* Removes added dictionary type, and renames class name
* Removes unnecessary null checks
* Removes cost metric dictionary and adds corresponding properties
* Code review changes
* Removes incorrectly implemented key down event for widget.
* Renames widget and action class names for highlighting expensive ops
* File rename
* Cleans up labels to better reflect highlight action
* Removes hardcoded button width style and sets it to auto
* More clean up
* Clean up import statement
* Code review changes
* Drop down list only shows available metrics
* Updates highlight expensive operation icon
* Update STS version
* initial
* Fix and revert secret storage changes
* persist to file
* Add debounce and write on dispose
* Fix run
* No ext dependencies and show warning message
* Remove test stuff
* comments
* Fix tests and console logs
* allow mark tests as unstable
* fix
* fix invert
* stable and whole test suite
* docs and mark test cases as unstable
* a couple more unstable test cases
* Fixes incorrect label when plans are vertical
* Code review changes.
* Adds helper methods to get localized strings
* Helper functions moved to module level
* Renames fields from top and bottom to primary and secondary
* Set target platform for mssql vscode extension- create project from db feature
* Addressed comments
* Address comment to add EngineEdition information in vscode-mssql.d.ts
* add logging for data workspace extension
* Addressing comments
* adding back getProjectsInWorkspace() in constructor
* Add more logging in activate()
* Added username field to PG and removed defaultvalue for port
* Disabled system username for miaa. Added username to pg create notebook.
* Block system for pg username
* Remove sql username from pg create
* Add service type
* bump version for preview
* Add dev use label
* Changed postgres icon
* Fixed PG create page not displaying. Wrong type
* Fixed service type
* changed naming for admin usernames sql and pg
* sql and pg dev use fix
* Move port under service type and make storage class not required
* Fixed regex to include things like sa1 system1
* Made storage class params optional
* Added placeholder text and changed PG admin username label
* Remove backups
* Removed postgres hardcoded username in connectionstring
* Remove more postgres username hardcoded
Co-authored-by: Candice Ye <canye@microsoft.com>
* fixing icons for new ledger object SubTypes
* removing irrelevant context menu options from ledger objects in OE
* aligning LedgerDropped subtype context key specifically with the Table NodeType context key
* download Microsoft.Build.Sql sdk and extract
* cleanup extracted folder and nuget
* add constants
* cleanup
* remove package-lock.json
* making outputChannel required and some cleanup
* only download if the files aren't already there
* Add todo
* add try catches
* addressing comments
* WIP - show error message for failed SKU recommendation
* WIP - run query to get correct instance name
* WIP - integrate elastic model recommendation
* Remove private endpoint restriction text
* Add feature switch for elastic recommendation
* Clean up
* Clean up
* Misc UI fixes
* Update package.json with updated azdata dependency
* Remove unused lines
* Fix broken next button
* Vbump extension to 1.0.6
* Update SQL DB card to show number of recommendations for correct model
* Hard code enginer ver to 14 and remove extension from wizard field and notebook
* Removed hyperscale text from everywhere but links
* Made PostgreSQL into PostgreSQL server and other text changes. Removed worker nodes
* Removed coordinator node text
* Removed worker nodes from compute + storage. Changed az arc-server to server-arc. postgresParameters.ts may need
* Removed tabs for extensions, coord nodes, worker nodes, resource health, diagnose and solve
* Removed node configuation and pg version from overview and properties. Edited arialabels
* Change server group nodes to server
* Removed type from overview table and aded Preview tags
* Removed info bubble and added padding to top of title
* Removed checkbox from PG create wizard. Added link and text
* Remove engine version
* Changed naming conventions
* Removed coord and server group from variables
* Removed properties
* Removed Server table, admin username, reset password
* Removed function from notebook
* Change wording
* bump version
Co-authored-by: Candice Ye <canye@microsoft.com>
* Revert "Revert "Fix sql projects not using OutputPath in sqlproj for publishing (#19987)" (#20127)"
This reverts commit dc7522c661.
* read configuration from sqlproj
* Add more tests
* use last OutputPath in sqlproj
* Remove references to getProviderMetadataForAccount
* Fix broken next button
* Clean up
* Adding to other PR instead - Revert "Clean up"
This reverts commit 410e136c0d1dcc24b38697791801fe3b90b1ecd4.
* Adding to other PR instead - Revert "Fix broken next button"
This reverts commit 748f75daf1594694e618f946c8026cb3256c58a9.
* sql db wizard with target selection
* add database table selection
* add sqldb to service and IR page
* Code complete
* navigation bug fixes
* fix target db selection
* improve sqldb error and status reporting
* fix error count bug
* remove table status inference
* address review feedback
* update resource strings and content
* fix migraton status string, use localized value
* fix ux navigation issues
* fix back/fwd w/o changes from changing data
* Add correct host to ARM REST API calls
* Clean up
* Missed a spot
* One more comment
* Expose new function getProviderMetadataForAccount in azurecore API
* Adding a loader spinner before the options load
* removing the local var and using const
* Reducing delay between button click and loader visibility,
* Max for syncsecondary. Fix syncsecondary update.
* Update the value not the placeholder for SQL MIAA
* Disable save toolbar icon after save/update complete
Co-authored-by: Candice Ye <canye@microsoft.com>
* Re-enabled config for direct mode
* Changed name and placement
* Shortened description
* Remove pg and sql as categories for DC
Co-authored-by: Candice Ye <canye@microsoft.com>
* Include Object Types logic refactored and options fetching from DacFx
* Removed localized object types constants
* Prop name updated and references and tests updated
* updated comments
* STS vBump
* updating the test file to pass the PR Validations
* Include Objects Coming from DacFx and tests all working as expected
* Exclude Object types functionality is working as expected and Unit tests
* more refactor updates
* Updated comments and prop name
* Addressing the coments and code updates accordingly
* Updating according to the comments
* STS vbump
* These changes should be deleted with SC changes, not here
* format fixed
* options loading from profile if has profile loaded
* Removing profile file unwanted changes
* updating profiles options comment
* STS vBump
* revert STS version from this PR
* Made SQL MIAA a new tile from New Deployment
* Remove MIAA from SQL tile. Fix helptext for MIAA tile.
* Switched positions of sql miaa and pg tiles. Made New Instance have miaa instead of sql tile.
Co-authored-by: Candice Ye <canye@microsoft.com>
* refresh does not differentiate direct vs indirect
* For direct mode MIAA commands, always use --use-k8s
* Changed comment language to use ARM instead of direct and K8S API instead of indirect
Co-authored-by: Candice Ye <canye@microsoft.com>
* Adds find node button to comparison plans.
* Can search multiple nodes (improve widget UI and initialization)
* Adjusts how second plan is added to the node search widget
* Adds styling to the find node action bar
* Removes unused code
* Minor clean up
* Cleans up CSS redundancy
* Adjusts property names according to access specifiers
* Corrects find node behavior to match SSMS
* Dependency injects instantiation service
* Adds additional property to telemetry event.
* Adds undefined to getter return signatures for plans
* Adds checks around active execution plan properties
* Code review change
* Code review changes
* dropdown not supporting dynamic enablement
* paused for weekend
* Make connection mode display with capitalization but value lowercase
* Undo changes in modelviewutils
Co-authored-by: Candice Ye <canye@microsoft.com>
* If no agreements item, then do not generate an Accept Terms of Use title. Remove sql miaa agreement.
* Added back the arc-specific change
* Added back nls
Co-authored-by: Candice Ye <canye@microsoft.com>
* Update azdataGraph version to 0.0.31
* Adds icons
* Bumps azdataGraph version to 0.0.32
* Removes whitespace
* Uses icon that better adapts to color theme changes.
* Disables collapse for execution plans in plan comparison editor view
* Made kube config and context dependent on direct mode
* Make config profile a dropdown
* Re enabled config profile
Co-authored-by: Candice Ye <canye@microsoft.com>
* OptionsDialog and buttons CSS styling updates
* final css changes for sql db options tab
* modified options button into itmes list
* updated tab name
* Added removed line git blame
* OptionsMapTable logic to replace the deployment hardcoded values final
* Test modifiaction
* OptionsMApTable updates with STS and review commetns
* comments added and option string moved to constants file
* Reverting the options button css related change and will put in other PR
* converted optionsMapTable to custom type and references.
* Options prop changes and model updates
* Reset btn event method name fixed
* removed local booleanOptionDict var and using the existing one
* updated code with removed local vars
* Update to booleanOptionsDictionary name
* merged two variable to one
* Refactoring code and updating variables
* separated lookup and data array and refactor
* missing visibility
* reset logic revised and no other edgecases found
* variable names updated to meaningful
* vbump here to test the checks, sending new vbump PR separately
* Updates properties view title when the orientation changes
* Property orientation labels change when the plan orientation changes.
* Renames top and bottom containers to secondary and primary
* Minor clean up
* Removes unnecessary class members
* Promotes constants to module level
* Moves function to module level
* Renames value1 and value2 to primary and secondary
* Replaces orientation string literal type with enum
* Resolves undefined orientation bug
* Removes unused orientation getter
* Updates property table columns only
* Uses orientation enum in editor view and properties view
* Clean up
* Adding top operations to execution plans
* Adding title to links
* Fixing pr comments
* Hiding top operations icon in execution plan editor
* Reducing outline width, adding separator and removing placeholder text
* Registering TopOperationsTabView
* Added label description for RWX storage class
* Added link and description above backups
* Made field have no default value by making it plain textfield
* Made label width wider to accomodate long labels
* Better spacing for RWX. Fixed info bubble overlap
Co-authored-by: Candice Ye <canye@microsoft.com>
* Switch query events to just send ranges instead of full query text
* undo azdata changes
* fix type
* comment + remove unneeded ?
* range -> batchRanges
* undo
* Changed namespace to have empty default value. Added cluster name as a field for direct mode. Updated summary page and notebook as necessary.
* Made storage class = default if storage class is undefined
* Moved cluster name before custom location
Co-authored-by: Candice Ye <canye@microsoft.com>
* Ctrl/Cmd + m, no longer executes queries.
* Adjusts command label
* Code review changes
* Uses category parameter to categorize actual plan command
* Actual execution plan command label matches estimated plan command label
* Revert "Actual execution plan command label matches estimated plan command label"
This reverts commit 15f301dfc64341d631ca5e9b1314d8cf739b2088.
* Centralizes localized category string (#19857)
* Actual Plan action uses centralized category
Didn't notice that this had already been bumped from what was listed in the gallery (0.1.0 currently). So reverting back to 0.2.0 until after the next version is released.
* Commenting out for now, but will delete in next commit
* Adds SQL carbon edit markers
* Uses multiline comments
* Formats file
* Code review changes
* Edit comment moved to same line
* Add ts-ignore directive to unused method
* Fixing tabbing logic for tab headers
* Renaming stuff
Making null checks concise
Adding comments
* Renaming css class and interfaces from active to selected
* Renaming styling classes and objects
* Changing tabbing logic to match w3 behavior
* Fixing focus logic in tab
* Adding helper comment
* Code cleanup
* Adding arialive to flex and div container
* Fixing compilation issues
* Moving ariaLive to container properties
* fixes
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Added syncSecondaryToCommit to SQL update and create, as well as notebook, wizard, and compute+storage interfaces
* Added readable secondaries and syncSecondaryToCommit to cost and SQL MI create
* Added readable secondaries to notebook
* removed resource-deployment changes
Co-authored-by: Candice Ye <canye@microsoft.com>
* Fixed dynamic enablement
* Set to false or original logic in constructor
* Changed boolean to also undefined
* Moved comment to constructor
Co-authored-by: Candice Ye <canye@microsoft.com>
* Creates toggle button to switch between estimate and actual query plans
* Renames ID for the toggleActualExecutionPlanModeAction class
* Renames button back to explain
* Creating actual execution plans resembles SSMS
* Adds CTRL/CMD + L shortcut to display estimated execution plans
* Alphabetically organizes telemetry actions
* Adds telemetry when the setting for actual execution plan toggle is used
* Resolves build errors
* Fixes broken unit tests.
* Code review changes
* Removes unnecessary null-coalescing operator.
* Creates placeholder icons for actual execution plans enabled
* Code review changes
* Shortens label names
* Telemetry moved to toggle button
* Telemetry review changes
* Clarifies misleading label
* added filter for AsyncDataProvider Filter crash
* fixed cell switch back for editdata
* Added new setData check
* disable selecting of all columns when new row is being added
* Changed comment
* removed try catch check due to Aasim's PR
* added previous dataset to handlechange
* added feedback changes
* added fix for infinite loop
* changes made as suggested by Alan
* following Charles' feedback
* removed onGridRendered as its pointless jumping
* initilaizing the sqlproj display options work
* added more code to the options dialog, need default option values
* Except REset Button, all works and need to refactor and test
* DisplayOptions for SQL DB Proj completed, refactor needed
* Tests for display options
* refactor code and removed unnecessary await calls
* Description values getting from STS API and code refactor
* DacpacExtesnion test model error fix
* updates related to STS model updates
* Dac Deployement options model updates according to STS changes
* Undoing file updates and moving as separate PR
* Undoing vscode whitespace changes which were added accidentally
* Options display name coming from API
* Updated model with dac deploy options display names coming from the STS API
* errors fixed after merge to main
* separating model related changes after merge, separate PR exists
* wrong Comment for the test case removed
* code refactor updates
* Hyperlink changes to secondary button and style updates
* refactoring code and comments
* importing type only instead of whole azdata and comment updates
* projectcontroller test fix
* removed duplicate file updates from other PR
* code refactor according to comments
* Added dispose to the onclick handler
* Added test case
* parameter change results error and fixed
* Addressing all comments with updates
* Unused variable removed and missed with previous commit
* Updated the ppublish button and width
* Adjusted the database dropdown and options margins to make all input align in same line
* Updated the database width and moved stylings to uiconstants file
* Introduce tabs for notebook views
Cards have been restructured to contain tabs instead of cells directly.
Tabs then contain the cards that are displayed. Cards may contain one or
more cards.
The panel component has been reused to implement the cells. There is
still some cleanup left to do of unused functions, but I want to reduce
the size of the PR as much as possible.
* Adds telemetry when plan comparison is invoked
* Small formatting change.
* Adds telemetry to add execution plan button
* Removes unused ExecutionPlanComparisonEditorView constructor parameters
* Small formatting adjustment
* Adds telemetry to ExecutionPlanComparisonEditorView properties
* Code review changes
* add 'open in designer' to context menu of tables in sql projects
* fix tests
* Address comments
* enable table designer for sql database proj
* update label and issues on init
* vbump sts
* use promisified fs
* pr comments
Co-authored-by: Alan Ren <alanren@microsoft.com>
* fix page being reset twice and add back smoke test
* add missing await
* check pyarrow info loaded
* install latest package version
* fix version select box selector
* split out into two PRs
* Dac Deployement options model updates according to STS changes
* Undoing vscode whitespace changes which were added accidentally
* Updated model with dac deploy options display names coming from the STS API
* Combining all exisitng code updates into single branch/pr. it includes mssql model updates and SC/dacpac model, code and testupdates
* sql db proj test failure fix
* STS version bump to 4.0.0.4
* Adding code for execution plan comparison editor
* Handling floating promises and fixing a loc string
* Fixing some polygon stuff
* Fixing azdatagraph null check bug
* Adding progress notification for similar areas
* Removing some floating promises
* Fixing button enabled state
* Bump version of arc and azcli to 1.3.0
* Fixed refresh to do dc config show and endpoint list first, then check the connectionmode
* Await calls to refresh indirect and direct
* Made sql mi-arc delete also handle direct mode. Made customlocation for sql mi create work again, regex problem.
Co-authored-by: Candice Ye <canye@microsoft.com>
* Display cdb nodes to browse azure tree
* Update icons
* Update node label
* Remove console logs
* Fix i18n in cosmosDbMongoTreeDataProvider
* Disable Mongo provider in azure tree for now
* Revert "Disable Mongo provider in azure tree for now"
This reverts commit 8b2d2079f43624596a41b82a71a5e40eef1ad4b1.
* Fix build issues related to merge
* Add COSMOSDB_MONGO in provider extension map
* Define providerId string as constant. Rename constants to follow azurecore/ naming conventions (all caps)
* remove password enter manually - since we prompt user to include it prior
* go back to connection profile prompt
* add manual entry if connection info password is not saved
* add tests that verify all password prompt scenarios
* nit
* first wip for table menu prompt
* fix up some table prompts
* use simpleExecuteRequest
* fix table prompt scenario for sql binding also
* fix/add more testing and address comments
* add brackets to selected database
* add manually entered option
* added clickable more info links to designer validation issues
* fix selection issue
* remove more info if none
* change quote style
* clear the dom node
* format
* added buttons and initial drag plugin
* initial drag and drop working
* add actions and taskbar
* drag and drop bugfix and other changes
* fix few issues
* more changes
* fix all move and insertion issues
* PRcomments
* fit and finish comments
* remove dead code
* bump sts
* add style for object being dragged
* add plugin to copyright filter
* Add to eslintrc
* fix drag contrast ratio
* generalize logic for cell focus
* demo feedback
* feedback
* add action state
* feedback
* remove unncecessary check
* add move actions to context menu
* change to const
* fix bug with tables and fix drop color
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* Rebase from main branch
* Made mssql a module
* remove rpc specific stuff
* Added create sas RPC call
* Backup to url works now
* Moved createSas RPC to the BlobService
* Relocated createSas RPC from sql-dataprotocolclient to the mssql
* After rebase
* Removed duplicate symbol
* Renamed Blob to AzureBlob and relocated CreateSasResponse to mssql extension
* Removed AzureBlobProvider, removed AzureBlobService feature
* renamed blob to azureblob, converted thenable to promise
* Simplify API
* fixes
* docs update, blob to azureblob update
* UI design first commit
* Detected Managed Instance, trying to script backup to url
* azure subscription api added, but ADS crashes
* Created url dialog component and added link account
* Changed backup component UI logic
* Changed b/r UI, added restore from URL, detected MI from restore component
* Removed mocked and added real Azure API, changed RestoreDialog UI
* Added file fetching API
* added create sas RPC call
* Backup to url works now
* Fixed some bugs
* Moved createSas RPC to the BlobService
* Relocated createSas RPC from sql-dataprotocolclient to the mssql
* Rebase createSas changed to the backupRestoreManagedInstance
* PR comments fix
* Enabled backup to url for gov clouds
* Replaced anchor element with Link class
* Fixed pick azure account logic
* Removed duplicates from eslintrc
* Fixed url browser dialog
* Fixed restore UI, disabled url empty url browser dropdowns, fixed backup OK button
* bumped sts version
* bumped sts version
* Fix config
* Fixed URL browser dialog UX
* Backup and restore dialog fix
* Referencing azure resource types directly
* Scoped url browser dialog css classes
* Made the url browser dialog field a local variable
* moved url browser files from fileBrowser to the urlBrowser folder
* Changed deviceType from number to enum
* Added all device type options
* Moved mssql
* Added MI backup button comment
* Removed unhelpful comment
* Revert differential copy only backup mistake
* Renamed azurebrowser to urlBrowserDialog
* Localize create sas button label
* Removed unnecessary spinner
* Use UTC date instead of locale date
* Removed * and added required flag
* Use async instead of nested thens
* Added target database tooltip
* Using deferred promise instead of event emitter
* Added error handling to the url browser dialog
* Registered backup component elements
* Register backup component listeners
* Removed redundant setDefaultBackupPaths call
* Added setBackupPathList docs
* Add return types
* Remove code from comment
* Register restore dialog elements
* Register restore dialog listeners
* Pass engine edition enum instead of boolean
* Capitalize enum values
* DatabaseEngineEdition fix
* Use DeviceType instead of number
* Use deferred pointer
* Add new ModalDialogName
* Use constructor fields
* Register URL browser dialog components
* Remove unnecessary helper function
* nextYear function doc and move
* split registerListeners method
* showDialog returns promise
* Backup device type comment
* Pass aria label through constructor
* Fix backup button
* Remove comment
* Comment unsupported MI backup options
* Remove one liner helper function
* Restore dialog methods return types
* Remove comment
* JS doc format
* Renamed UrlBrowserDialog to BackupRestoreUrlBrowserDialog
* Moved MediaDeviceType, added PhisicalDeviceType
* Reorder and rename physical device type
* remove extra spaces
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* Adding ability to expand and columns tables
* Bolding icons
Fixing variable names
* Adding helper function
Making css more target
* Adding keyboard navigation and parsing treegrid data
* Adding attributes, data transformations and key events to the treegrid
* Expanded
* changing var name
* FIxing formatter name
* Adding back cell styling
* Removing comments
* Making a new TreeGrid component.
Separating treegrid logic from tableDataView
* Fixing comments
* changing method name
* Modifying only visible row dom attributes
* Removing white space, moving role attribute setter to constructor.
* Fixing some more PR comments
* Adding comments and renaming functions
* Fixing comments
* Fixing comments
* Fixing comments
* Fixing some logic and removing unused attributes from element
* Adding expandable formatter to the first column
* Making the formatter generic
* Reverting formatter code
* Adding doc comments
* Fixing comments
* Removing duplicated code
* Adding comments
* Setting columns only when the table is initialized
* Letting users set expanded state instead of forcing it to false
* Added sql upgrade management page and fixed icon for dc and sql upgrade
* Added logic for figuring out MIAA version, loading proper entries for table.
* Added PR comment changes
Co-authored-by: Candice Ye <canye@microsoft.com>
* Adds hot key combination for finding nodes in execution plans.
* Captures cmd + f key combinations for other platforms
* Stops event propagation when targeted hot key sequence is pressed
* add tab index to cell output
* add sr-only element to announce cell exe complete
* use onExecutionComplete event
* remove extra change
* simplify alert message
* add alert for cell execution start
* make sure cell is ran
* make sure dialog is gone before runing cell again
* ensure package is done installing
* show task panel
* remove comment
* pr comments
* pr comments
* add 7.0.0 package version
* Resolves cannot read property 'accessToken' of undefined.
* Checks for and specifies undefined as refreshToken return type
* Adds documentation and checks for undefined results from refreshToken
* WIP
* WIP
* WIP
* Fix location dropdown not working properly
* Clean up comments
* Switch button order in selectMigrationServiceDialog
* Vbump to 1.0.1
* Refactor to avoid duplicate API calls
* Add null checks
* Fix migration status dialog not sorting migrations properly
* Address comments, remove unnecessary code
* Address comments - separate util methods by resource type, use logError instead of console.log
* Remove unused methods
* Fix DMS creation on newly created resource group
* Fix stale account behavior
* Address comments - remove telemetry context from util method calls
* Clean up imports
* Fix dashboard service monitoring not working
* Fix null reference on database backup page, and resources not updating properly when location is changed
* Fix dashboard not auto selecting DMS after migration started
* Add null checks
* Added sqlmiaa upgrade command and params to azcli api
* Put params under args
* Removed an extra comma
Co-authored-by: Candice Ye <canye@microsoft.com>
* initial refactor
* fix projectFolder cases
* update create azure function with sql binding when no folder is opened
* corner case exit browse file
* add version since targetFramework is set to specific core tools version
* update telemetry and address comments
* use project folder instead
* fix create project from database when launched from disconnected node
* don't open dashboard
* fix tests
* update order so connection dialog opens first if can't connect
* Rebase from main branch
* Made mssql a module
* remove rpc specific stuff
* Added create sas RPC call
* Backup to url works now
* Moved createSas RPC to the BlobService
* Relocated createSas RPC from sql-dataprotocolclient to the mssql
* After rebase
* Removed duplicate symbol
* Renamed Blob to AzureBlob and relocated CreateSasResponse to mssql extension
* Removed AzureBlobProvider, removed AzureBlobService feature
* renamed blob to azureblob, converted thenable to promise
* Simplify API
* fixes
* docs update, blob to azureblob update
* bumped sts version
* Fix config
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* Removed configure retention policy link. Log errors for upgrade instead of blocking the upgrade. Changed text of version log link.
* Addressing comments on PR
Co-authored-by: Candice Ye <canye@microsoft.com>
* Fixed a connect to Server typo
* Added upgrade tab with description and title. Table is still stuck loading.
* Renamed backups to upgrades.
* Removed loading icon
* Table appearing and not stuck loading
* Saving for now to upgrade arc and azcli versions
* Added upgrade confirmation dialog, populated dummy data and added upgrade apis.
* Added parsing of versions and current version from listupgrades
* Upgrade itself not working, but added upgrade as a part of azure cli api.
* Table now populating with release dates and version numbers. Upgrade button only shows for appropriate cells. Upgrade done but no release version column.
* Changed text using PM advice
* Removed comments from controllerUpgrades.ts
* Replaced code in upgradecontroller.ts and made refresh work
* Removed one call to handleTablesUpdated
* Removed some code in upgradeControllers.ts and it still works
* removing more code for pitr refresh from upgradeController.ts
* Created and used UpgradeModel even though it is empty
* Added upgrademodel
* PR comments addressed
Co-authored-by: Candice Ye <canye@microsoft.com>
* Add sqlproj property to trace the origin of the project.
As part of the database migration process (schema conversion, in particular) we want to be able to tell when converted schemas are being built/deployed to the actual database server. Given that we rely on the SQL Database Projects ADS extension for the compilation/deployment, we don't have too many options other than updating the said extension.
The suggested approach is to make the following changes:
1) Add new property to the sqlproj file (called `DatabaseSource`), which will maintain the origin(s) of the project. The property can contain multiple values (separated by semicolon), in case same project contains objects produced by multiple sources (extract schema, convert from another database, etc.).
2) During build and deploy actions, send the well-known values from the newly added property to the telemetry. We don't want to send any random value of the property, as it may raise some privacy concerns. Instead we define a list of the well-known values that we know do not carry any personal information and send those, if they are specified.
This change adds all necessary APIs to the SQl Database projects extension which will be consumed by our migration extensions to populate new `DatabaseSource` property.
* Use `undefined` instead of `null`
Co-authored-by: Kim Santiago <kisantia@microsoft.com>
* Fix SQL Binding when creating new project
* Use sql binding templates
* fix openDialog to use select
Co-authored-by: Vasu Bhog <vabhog@microsoft.com>
* Adds telemetry around how the properties window is opened
* Adds telemetry around accessing execution plan top operations
* Adds key for viewing top operations
* Adds telemetry around using the open query button and context menu item
* Adds telemetry around execution plan zoom in, out, to fit, and custom
* Adds telemetry around searching for nodes in execution plans
* Reduces telemetry additional properties to 1.
* Code review changes
* Removes unnecessary export
* fix connectionSettingName for create azure function with sql binding
* add sql binding user enters connection string manually
* address comments + fix test
* final comments
* Adding badge icons to executionplan
* Fixing doc comment
* Fixing doc comments
* Making enum value more readable
* Changing default to undefined.
* Fixing some icon names
* Add unified col for data type deit
* remove seperate type setting cols and rename unified col to 'type'
* remove advanced type from properties window
* add description to col, idx, constraints
* nit
* bump STS to .227
* listen on focus_in of toolbar
* update styles on focus_in
* listen for active cell change on notebook componen
* add tabbing order to textcells
* remove duplicate listener
* clean up
* undo
* remove visible check from cellToolbar
* remove duplicate detectChanges on updateActiveCell
* only update active cell if it's already not
* add aria-label for accessibility
* localize the aria label
* refactor
* add cellLabel property to CellModel
* remove updateActiveCell from code component
* regression from merge fix
* set edit mode as true when focusing on cell
* moce check to model
* merge changes correctly
* update edit mode if code cell
* fixes
Co-authored-by: barbaravaldez <bavaldez@microsoft.com>
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* fix for user using command palette command
* rework if a user uses the create azure function via the command
* for now only show in vs code
* move logic to azureFunctionService + address comments
* fix command location
* address comments
* fix validateFunction
* WIP - implemented logic to show resource groups as derived from list of resources, instead of directly listing all resource groups
* Remove comments
* Remove getResourceGroupByName and craft resource group object manually instead
* Update subscription and location list when tenant is changed
* Define Azure resource types locally instead of modifying azurecore
* Add SQL VM scenario
* Split getAzureResourceGroupDropdownValues into four separate functions
* Refresh only subscription list when tenant is changed
* Create new DMS dialog should show all resource groups
* Remove unnecessary async code
* add graph icons to OE and TD
* PR comments
* change enum type
* change sub type to icon and make basic as default
* changed icontype to icon
* change default logic location
* change icon name to be more generic
* use right icons
* added graph node types from edit and publish results
* make generic property bag
* review comments
* add comment for function
* edit comment
* change name to telemetry info
* add wizard page and selected operation for dacfx wizard cancel telemetry
* update name
* send version for extract
* pass version directly into function call
* Added monitor log-analytics workspace list to az api
* Made resource group and subscription optional for logs analytics workspace list
* Added dynamic fields for workspace names, id, primary key, based on value of auto-logs checkbox
* Hooked up the newly created source provider for log analytics workspaces. Dropdown now populates all workspace names.
* Added workspaceUtils.ts for a valueprovider. Now workspace name maps to id automatically.
* Replaced promise.all with promise.resolve
* Added workspace id and primary key as env variables in the notebook
* Removed extra space in package.json
* Made getOptions more concise and put azApi definition in function.
* Changed notebook to handle new Azure CLI command with param --clustername
* add more telemetry for sql database projects
* add publishToContainer events
* send target platform when publishing
* add duration for createProjectFromDb and updateProjectFromDb
* Pushing Execution Plan Editor
* Renaming class
Handling error
* Awaiting for handlers to be registered
* Addressing some PR comments
* Fixing return type for provider
* Fixing editor id and removing unnecessary overrides
* Adding a namespace
* adding execution plan namespace
* Adding protocol comment
* Fixing if logic
* Fixing error message
* Cleaning up code
* cleanup code
* Adding help comments
* Fixing method call
* Using path.ts to get the base file name
* converting to lambda functions
* Adding comment for run action
* Fixing pr comments
* Fixing editor label
* Fixing doc comments
* Adding some more comments
* Fixign branding in comments
* add step to choose target platform in new project quickpick
* add comment
* only splice if the default target platform index isn't -1
* change 3 to 5 in comment
* Add MI ready state check and error message
* Fix a typo
* Update error message logic
* Update '(Unavailable)' prefix to be localized string
* Show error messsage when non-Ready MI is initially selected (not just on Next button)
* Update error message with appropriate casing and actionable step
* wip for refactor of mssql to sql-bindings
* remove STS dependency
* work to bring function over and setup with vscodeMsql APIs
* copy typings from vscode-mssql
* WIP
* Change instance name from machine name to full instance name returned by assessment
* Get full instance name from source connection profile instead of relying on assessment result
* Combine correct machine name with correct instance name
* Making infobox clickable
* Making it accessible
* Moving API to proposed
* Matching styling from portal
* Fixing some styling
* Moving to proposed
* Removing extra spacing
* Registering and Unregistering listeners
* Fixing listeners
* Registering emitter only once.
* Changing emitter type from undefined to void
* Adding arialabel to clickable link
* Changing property name to suit its purpose
* add ability for md + text reports
* change report type
* re add types for ads
* match fields and add enum for mimetype
* rename preview report
* update type
* rename generate report type
* fix comment
* add loadSavedInfo function in stateMachine; only open wizard if didLoadSavedInfo
* * add loadSavedInfo function in stateMachine; only open wizard if didLoadSavedInfo
* replaced savedInfo.miggrationServiceId string with sqlMigrationServer object
* selectDatbasesFromList helper function to check previously selected dbs in dbSelectorPage and sqlDatabaseTree
* * remove savedInfo references from targetSelectionPage, migrationModePage
* add selectDefaultDropdownValue helper to stateMachine to handle unify savedInfo selection logic
* add updateDropdownLoadingStatus to targetSelectionPage
* check if values exist before making api calls in statemachine
* removed savedInfo references from databaseBackupPage, integrationRuntimePage
* databaseBackupPage - targetDatabaseNames, networkShares, blobs need to rely on savedInfo as user may update the list of migrationdbs during the retry/saveAndClose
* re-add serverAssessments to savedInfo; only getAssessments if it does not exist or needs to be updated; fix networkShare type savedInfo
* rename _assessmentDbs to _databasesForAssessment; _migrationDbs to _databasesForMigration
* load blobs/networkshares savedinfo; move selectDefaultDropdownValue to utils
* fix selectDefaultDropdownValue; refreshDatabaseBackupPage when user changes target subscription or location
* protocol handler - normalize paths
* use `extUri` for normalizing paths
* :lipstick;
* Add content security policy to top level webview
This change hardens our webviews by adding a fairly restrictive csp to them. This CSP should only apply to the outer webview iframe, not to the inner iframe which is controlled by extensions
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Matt Bierner <matb@microsoft.com>
* Fixed color contrast for error message in connect a dc window.
* Remove color check for error message
* Remove more unneeded checks
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Adding telemetry for errors happening during data collection/ telemetry for sku recommendation
* log and error happended during get sku recommendation
* Resolving comments from PR https://github.com/microsoft/azuredatastudio/pull/18252. 1) Adding click and close events to dispoable collection to avoid leaks. 2) Adding readable constant for number representing minutes.
* Changes - 1) updating migration workflow strings, 2) adding more onclick events to disposable collection.
* Remove PaaS, IaaS terms from string
* Changes -
1) Renamed 'Saved assessment result' to 'saved session'.
2) Removed Title from 'saved session' page.
3) Added stop data collection on migration start.
* Initial check in for SQL migration SKU recommendation feature (#18116)
Co-authored-by: Raymond Truong <ratruong@microsoft.com>
* add TargetSelectionPage, remove AccountSelectionPage, fix saveAndClose bugs (#18092)
* update sku interfaces (#18150)
* create the skuRecommendationResultsDialog (#18151)
* add TargetSelectionPage, remove AccountSelectionPage, fix saveAndClose bugs
* create skuRecommendationResultsDialog
* Replace placeholder SKU recommendation results with actual results (#18153)
* Replace placeholder SKU recommendation results with actual backend call results
* Remove skuRecommendationExample
* Replace number fields in interfaces with correct enums, and update UI text
* add getAzureRecommendationDialog for performance collection (#18159)
* add getAzureRecommendationDialog when there are no recommendations available
* update 'get azure rec' / 'view details' link values
* add condition to check if recommendations are available
* Implement start/stop perf data collection + import perf data into new UI (#18149)
* Implement start/stop perf data collection
* add getAzureRecommendationDialog when there are no recommendations available
* update 'get azure rec' / 'view details' link values
* add condition to check if recommendations are available
* Implement import existing data + start/stop perf collection with new UI
Co-authored-by: Rachel Kim <rackim@microsoft.com>
* Expose SqlInstanceRequirements in SKU recommendation results (#18207)
* Expose SqlInstanceRequirements
* Move string literals to constants file
* Fix formatting in mssql.d.ts
* create storage properties table (#18215)
* Edit sku recommendation parameters (#18244)
* Edit sku recommendation parameters
* make _targetPercentileDropdown not editable; styling updates
* Azure recommendation section exposes data collection status and stop option (#18246)
* Edit sku recommendation parameters
* create azure recommendation details section on sku page
* Improve error handling + add auto refresh + other small changes (#18228)
* Update source properties table
* WIP - refresh perf data collection
* Add auto refresh logic
* Address comments
Co-authored-by: Rachel Kim <rackim@microsoft.com>
* Show/hide azure recommendation components based on data collection source and status (#18254)
* add refresh recommendation button; show/hide content based on perf collection status
* show/hide azure rec content based on perf data source scenarios
* add popups for start/stop; allow user to restart data collection; add perf collection to save close; add info tooltips (#18278)
* Update SKU recommendation timer logic (#18281)
* Update timer logic
* Fix misc UI bugs
* update sql migration extension readme (#18295)
* Remove empty constant, as this may have broken the build
* Fix 'save and close' behavior for SKU recommendation (#18301)
* Update timer logic
* Fix misc UI bugs
* 'WIP'
* Add logic to restore correct SKU recommendation state when reloading
* SKU UX enhancements - status info, button validations, savedInfo logic (#18320)
* add stop/inprogress status icons to perf collection status text, update restart icon
* refactor savedInfo as an interface, edit parameter recommednations are saved, add open folder inputbox validation, handle no recommendations available scenario
* fix getazureredialog bug, cleanup cold
* nit card styling
* Update recommendations whenever user changes list of databases to assess + misc clean up (#18323)
* Consolidate constants, clean up redundant functions, misc clean up
* Remove old SKU recommendation interfaces
* Update some more strings
* Telemetry events for SKU Recommendation (#18282)
* Telemetry events for SKU Recommendation
* Addressing comments -
1) fixed camel casing
2) removed extra logging to console
3) added telemetry for subid, rg, tenantid on targetselectionpage
* Resolving conflicts
* Addressing comments - 1) removing filename 2) moving all numbers to measurements.
* Resolving comment - Fixing telemetry value for tenant id.
* removing warning 'logError' is declared but its value is never read (#18333)
* Stop existing data collection when leaving and starting a new migration + update timers (#18339)
* Refresh recommendations when pressing stop data collection button
* Fix orphaned data collection when save and closing and starting a new
migration
* Revert "Refresh recommendations when pressing stop data collection button"
This reverts commit e6fb2ade8f8a41952adb81cb0ee852414dfa4ef2.
* Update timers to use production values
* Remove unused import
* address bug bash issues: add learn more link, add last refreshed time, fix vm card view detail open issue, remember last selected folder, remove strings, refactor refresh logic on sku page (#18340)
* Address comments
* Update to sqltoolsservice 3.0.0-release.204
Co-authored-by: Rachel Kim <rackim@microsoft.com>
Co-authored-by: Neetu Singh <23.neetu@gmail.com>
* Removed extra backup policy field in MIAA deploy. Re-ordered fields in MIAA deploy for parity.
* Enabled dynamic options to work with categoryvalue type objects.
* Removed defaultValue CategoryValue typing, fixed some type checks.
* Added a clarifying comment to setModelValues and removed unnecessary type from defaultValue
* Removed CategoryValue from selection
* Undo parenthesis for single type
* add new articles to help section
* Update extensions/sql-migration/src/dashboard/sqlServerDashboard.ts
* fix typo, remove link
* remove locale in links
Co-authored-by: Mohamed Kabiruddin <39162740+mokabiru@users.noreply.github.com>
* Vbumping sts to get latest qp code
* Updating azdataGraph in remote package.json
* Revert "Updating azdataGraph in remote package.json"
This reverts commit 704aa6b653b20c6bc439ba2ac46f4dcdead0128d.
* add sdk style project template
* update description and order
* add SDK style project option to create project from db dialog
* fix test
* switch to checkbox
* remove not used string
* fix test
* Changed instances of sql edit to sql update
* Updated az sql mi-arc edit to be update. Changed the params for indirect and direct mode.
* Removed preview from everywhere in arc and azcli extensions.
* Bumped version numbers for both extensions and removed preview bool in package.jsons
* rough changes for adsweb-lite
* commit id of latest quality
* fix for aria label
* distro commit id changes
* merged latest changes distro id
* python path changes + quality name change
* Hide container views/settings/panel for ADSWeb
* undo unintentional change
* No python prompt changes for tsgops-image
* distro id changed for tsgops quality name
* changed quality name to tsgops
* changed name to tsgops-image
* python address change
* unintended changes undo
* correct python installation path for tsgops
* enable preview features tsgops
* no prompt for tsgops-lite image
* revert preview feature change
* Fixes for few comments
* removed extra line
* add deleted line
* Addressed comments
* Addressed final comments
* eslint error fix
* fix
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
* added server infor and metrics for table designer
* update generate script
* pr comments
* format more files
* pr comments
* make changes to core
* remove unused imports
* add server info
* revert enum change and add publish event
* format doc
* nitpicks
* remove os version
* remove modifier from telemetry info
* remove error message
* Also reduced the number of timeouts for waiting on notebook provider descriptors, and fixed an issue with undefined cancellation tokens in vscode notebook conversion code.
* set mode explicitly to notebook
* move setMode to untitledNotebookInput
* wait until input is resolved for setMode
* invoke only when textInput is undefined
* pass the untitledTextInput in test
* add sdk style project template
* update description and order
* update template
* update template and add link
* remove ToolsVersion and xmlns from project node
* update template name to SQL Database (SDK)
* Adding initial boilerplate for qp2
* Adding feature flag in query plan 2
* Clearing show plan 2 after every run
* Adding sub tree cost
* removing unused method.
* WIP 2
* Adding properties view and relative cost to query plan
* WIP
* Add icons to ads
* Assing relative costs and prop windows
* Enabling older query plan again
* Making some PR fixes
* Some more PR related fixes
* Use MS org azdataGraph module
* Moving new properties to azdata proposed.
* Moving new class properties to proposed
* added missing doc component.
* Changing how azdatagraph package is referenced
* Removing empty lines, fixing localization keys
* Removing empty line, localizing some string
* making css classes more specific
* making some logic concise
* localizing some more strings
* Making more css classes specific
* Removing important tag from css props
* Checking if sum is greater than 0 to prevent divide by zero exceptions
* Fixed loader error in bootstrap
* Fixing query index
* -fixing image paths
-making css class more class specific by using nested selectors
Co-authored-by: kburtram <karlb@microsoft.com>
* load name and options from publihs profile for vscode publish quickpick
* fix when a publish profile doesn't have the target db name
* update condition
* simplify
* save changes
* refactoring
* update height
* Register undo redo command (#17948)
* register undo redo command
* sql-migration vbump 0.1.12 (#17955)
* fix pre/post deploy scripts getting double counted in the files for sdk style projects (#17954)
* fix pre/post deploy scripts getting double counted in the files for sdk style projects
* add test
* update comment
* vbump sql database projects to 0.15.0 (#17956)
* LEGO: check in for main to temporary branch. (#17957)
* null check before calling isDisposable (#17959)
* Updated credentials system (#17888)
* linting
* added flags
* remove testing values
* format
* format doc
* tested in linux
* remove unused interface
* comments
* review comments
* clean imports
* pr comments
* format doc
* changed promise location
* insiders december
* pr comments
* test ado change
* fix test
* comment out code for hygiene
* remove unused imports
* test creds from client only
* remove unused import
* trying enabling keytar
* trying enabling keytar
* disable in correct script
* print statements
* remove print statements
* check mock output
* add linux check
* remove print statements
* Consolidate INotebookEditOperation interfaces (#17944)
* Add redo action for split cells (#17947)
* add redo action for split cells
* Handle delete folder for SDK style sql projects (#17961)
* handle delete folder for sdk style projects
* cleanup
* compare original sqlproj contents
* remove redundant checks
* enable find in cell output when output is a data stream (#17759)
* initial changes
* add isCodeOutput and apply decorations on output
* Add extension gallery update reminder action (#17644)
* Fix extensionsGallery.json name (#17646)
* Remove galleries list action (#17648)
* multi-level table support (#17638)
* multi-level table support
* comments
* address comments
* add period to end of sentence.
* Show connection string example for add sql binding quickpick (#17650)
* add connection string example
* reorder
* Resolves same-origin-policy violation when ADS web is running in a container (#17555)
* Stops appending port to authority for web mode
* Clarifies comment
* Adds missing sql carbon edit tag
* vbump STS (#17653)
* use latest STS (#17658)
* Refactoring readProjFile() (#17637)
* move reading project parts to different helper functions
* cleanup
* remove comment
* addressing comments
* Corrects Web Build Pipeline ENOENT Error (#17656)
* Checks for successful directory creation
* Revert "Checks for successful directory creation"
This reverts commit 372409ef323f0d82e11992bc7bc33d607a7d5581.
* Checks for the existence of the logs directory before accessing.
* Adds SQL carbon edit comment
* Removing call to copy from non-existing directory.
* Removes unneeded import
* Checks for file existence before copying.
* Provides explanation for modification
* Replaces file existence check with exception handling.
* Bump tools service (#17671)
* Apply changes from Remote Database to sqlproj - mssql changes (#17655)
* update project from database
* update project from database
* update project from database
* Re-adding schemaComparePublishChanges for temporary backcompat
* Adding comment for keeping enum values in sync
* Correcting enum value
Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>
* update add file/folder for msbuild sdk style projects (#17660)
* update add file for msbuild sdk style projects
* also handle add folder
* fix comment
* fix issue reported by component governance (#17678)
* update json-schema version
* remove unused packages
* update package.json
* SQL Binding: Give default connection setting name (#17659)
* show sqlconnectionstring in quickpick
* fix duplicate sqlconnectionstring setting
* add (new)
* add sqlconnectionstring as default setting name
* check if sqlconnectionstring already exists
* Provide aria-labels for node checkboxes in the tree view. (#17676)
During accessibility testing, it was discovered that screen reader does not announce what checkboxes in the tree view represent. It was merely announcing "checkbox unchecked", so it was not clear without visuals which checkbox the focus is on.
This change sets an `aria-label` of the checkbox elements to match the label of the owning tree node. This way the announcement becomes "My Node; checkbox; unchecked". This is fine as a quick solution to the problem, but in the future we may want to consider adding additional checkbox label property to the nodes exposed by the tree provider, so that each checkbox can announce additional information, if needed.
* Respect ARIA label specified int he tree component options. (#17674)
During accessibility testing it was discovered that tree view in our wizard reads "Tree Node tree view" instead of the proper label that is specified. It turned out to be the problem with the tree component, where `ariaLabel` was hardcoded to "Tree Node", instead of the one provided in the options.
This change addresses the problem by passing through `ariaLabel` from the options object to the underlying tree control. I also removed the default `Tree Node` hardcoded label, as it didn't make much sense. This does mean that all tree-views that do not explicitly specify their aria-label will now get an empty label. I think this is better than having unrelated, unlocalized `Tree Node`.
I'm also worried about changes to the `ariaLabel` property after the component was initialized. I updated the code to propagate the value to the underlying tree view in the `setProperties` override of the tree component and hope that it will take care of it.
* Fix sql projects net6 warnings (#17673)
* fix .net 6 error showing on startup
* fix double warning
* addressing comments
* update key string
* undo adding space in net core sdk location setting (#17684)
* update names for msbuild sdk style projects (#17677)
* update names for msbuild sdk style projects
* remove msbuild from names
* update comments
* Designer: property descriptions (#17668)
* format
* added strings
* format doc
* use codicon instead
* show descriptions in property pane only
* fix ssdt string bug
* fix overflow option
* review comments
* review comments
* changes
* sts 156 vbump (#17683)
* Sql Binding: Add "Check out pane for more details" when nuget package download fails (#17680)
* check output for more details
* detail error
* wait for result from showerrormessage
* [Loc] Update to sql-database-projects and sql.xlf (#17687)
* update the vmImage for build jobs (#17689)
* update vmImage for windows build
* update tar command
* use specific macos version
* support building msbuild sdk style projects (#17675)
* support building msbuild sdk style projects
* fixes after merge
* add foreign keys and constraints (#17697)
* foreign keys and constraints
* refactoring
* fix issues
* properties pane improvements (#17700)
* [Loc] update to tabledesignercomponentinput (#17704)
* Add instructions for developing VS Code version of sql-database-projects (#17705)
* Adding UI for deploying a db proj to docker (#17495)
* code refactoring (#17706)
* Improve accessibility for wizard steps navigation (#17669)
Our extension is relying on the wizard dialog. During accessibility testing it was discovered that wizard step buttons are being reported as links by the screen reader (NVDA, JAWS). Claimed expected behavior by the tester is that they should be announced as buttons.
I discussed this issue with accessibility SMEs and they said it is perfectly fine to keep them as links. They did mention that they would probably design the UX differently from the start, but given that we already have it this way, links are fine. They did suggest to add few additional ARIA attributes to the link elements:
- `aria-current="step"` if the link is for the currently active step. This literally just announces "current step" at the end, when you focus on a link
- `aria-disabled="true"` makes it say "**unavailable**; link; *<step number>*" when in NVDA "browse" mode and move to the grayed-out link.
So this change implements the said improvements.
* bump sts version to 159 (#17709)
* LEGO: check in for main to temporary branch. (#17699)
* LEGO: check in for main to temporary branch. (#17702)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* [Loc] update to sql-database-projects (#17713)
* LEGO: check in for main to temporary branch. (#17715)
* Register additional editor overrides when adding new notebook file types (#17708)
* Also standardized file extension contributions to always start with a period, and to always do lower case string comparisons for file extensions.
* input width in designer (#17714)
* Add additional properties to wizard page navigation events (#17716)
* Fix open external not working (#17717)
* save password checkbox fix (#17718)
* save password checkbox fix
* remove code to reset the checkbox value
* allow build to continue when cache task fails (#17720)
* cache task should not fail the build
* update cachesalt
* Fix language flavor change on connection when in sqlcmd mode (#17719)
* Fix language flavor change on connection when in sqlcmd mode
* comment + fix
* LEGO: check in for main to temporary branch. (#17722)
* LEGO: check in for main to temporary branch. (#17724)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* Update one more variable name for sdk style projects (#17710)
* LEGO: check in for main to temporary branch. (#17725)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* LEGO: check in for main to temporary branch. (#17726)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* LEGO: check in for main to temporary branch. (#17730)
* Fix "unsupported version" error when adding sql binding package (#17721)
* Apply changes from remote database to sqlproj - schema-compare changes (#17679)
* update project from database
* update project from database
* Merge from main
* Removing dupe test stub
* PR feedback
* cleanup
* PR feedback
* Fixing tests, adding stubs to update sqlproj as schema compare target
* updating code comment
Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>
* [Loc] Update to schema-compare XLF (#17733)
* Enabled deployment of Azure Arc data controllers in directly connected mode (#17707)
* Added fields for connectivity mode, custom loc, auto-metrics, auto-logs, and the dynamic enablement of such fields.
* Changed the description of the data controller details page.
* Change notebook params to work for direct mode
* Added login to dc deployment notebooks
* Fixed auto upload metrics and logs true/false, separated login into another cell.
* Removed localization of indirect and direct connectivity labels.
* Fix ordering of reading sqlproj Build Includes and Removes (#17712)
* evaluate includes and removes in order in sqlproj
* fix after merge
* fix comment
* update comment
* Add resource deployment samples for (#17734)
* Update remove file for sdk style sql projects (#17688)
* add support for removing file in new style project
* fix test
* only load files, not whole project when checking if a <Build Remove> needs to be added
* merge changes
* fixes after merge
* [Loc] update to Arc XLF (#17737)
* Bump to latest version of azdata (#17735)
* Remove .net 6 version cutoff for building sql projects (#17736)
* remove .net 6 version cutoff for building sql projects
* Revert "Warning when .NET 6 SDK is detected (#17422)"
This reverts commit 2ed8aeb565.
* add back skipVersionSupportedCheck
* add back return false
* addressing comments
* [Loc] update to sql-database-projects xlf (#17743)
* Add additional notebook tests for handling relative links. (#17739)
* [Loc] Fix for duplicate strings in LCL files (#17756)
* WIP spanish lcl duplicate removal
* Revert "WIP spanish lcl duplicate removal"
This reverts commit 5f943153ec8980849a045c8bf7256d852571a778.
* fix for duplicate strings
* removed spaces
* Fixes ADS Web bug around copying user codes and opening a browser tab when adding an Azure Account. (#17760)
* Fixes bug around copying user codes and opening a browser tab.
* Code review changes
* Additional review changes.
* Unnecessary import removed
* Editing pipeline ACR service connection endpoint to the latest one created (#17767)
* using the new registry endpoint
* updating the service connection
* Changing the name of acr service endpoint to SqlToolsContainer
* Updating web build acr endpoint as well.
* Notebooks: Add Tooltips for Link/Image Buttons on Markdown Toolbar (#17763)
* Add title for tooltips
* Tweak tooltips
* Added UI for user to accept EULA when deploying sql proj to docker container (#17762)
* fix sorting bug (#17769)
* fix sorting bug
* comments
* Set default radio button selection, evaluate default component popula… (#17764)
* Set default radio button selection, evaluate default component population off of selection instead of unprocessed input
* rename var
* if -> switches
* Remove project radio buttons because they require commands that aren't yet checked in (and fail as a result)
* Added fix for Publish Target Label Position (#17771)
* Added fix for Publish Target Label Position
* renamed checkbox
* LEGO: check in for main to temporary branch. (#17775)
* LEGO: check in for main to temporary branch. (#17778)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* update dashboard taskbar separator (#17779)
* remove comments
* fix applying decorations
* add test
* enable find in sql result set
* add tests and update sql results highlight logic
* calculate the outputComponent index
* fix editor issues later
* remove newline replace on search
* address comments
* fix highlight issue
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
Co-authored-by: Lucy Zhang <luczhan@microsoft.com>
Co-authored-by: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com>
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com>
Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>
Co-authored-by: Alexander Ivanov <nahk-ivanov@users.noreply.github.com>
Co-authored-by: Aditya Bist <adbist@microsoft.com>
Co-authored-by: Sai Avishkar Sreerama <74571829+ssreerama@users.noreply.github.com>
Co-authored-by: Alex Ma <alma1@microsoft.com>
Co-authored-by: Leila Lali <llali@microsoft.com>
Co-authored-by: csigs <csigs@users.noreply.github.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: Candice Ye <candiceye@berkeley.edu>
Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>
* Remove undo/redo listeners from notebook component (#17966)
* remove undo/redo hostlisteners
* fix table focus issue (#17970)
* fix table focus issue
* fix hygiene error
* web
* new sts
* add await
* pr comments
* comments
Co-authored-by: Barbara Valdez <34872381+barbaravaldez@users.noreply.github.com>
Co-authored-by: brian-harris <61598682+brian-harris@users.noreply.github.com>
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: csigs <csigs@users.noreply.github.com>
Co-authored-by: Aditya Bist <adbist@microsoft.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Maddy <12754347+MaddyDev@users.noreply.github.com>
Co-authored-by: Lucy Zhang <luczhan@microsoft.com>
Co-authored-by: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com>
Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com>
Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>
Co-authored-by: Alexander Ivanov <nahk-ivanov@users.noreply.github.com>
Co-authored-by: Sai Avishkar Sreerama <74571829+ssreerama@users.noreply.github.com>
Co-authored-by: Alex Ma <alma1@microsoft.com>
Co-authored-by: Leila Lali <llali@microsoft.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: Candice Ye <candiceye@berkeley.edu>
Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>
* Start rerouting VSCode cell execution APIs.
* Add more conversion code.
* Convert VSCode notebook registrations into ADS equivalents.
* Update vscode notebook provider kernels when notebook controller's supportedLanguages are set.
* Update an error message.
* Add another session argument.
* Add base classes for converting notebook serializers.
* Disable some vscode notebook methods.
* Disable more vscode APIs.
* Disable more stuff.
* Start implementing serializer notebook data conversions.
* Use direct references to extension host notebook methods, rather than azdata ones.
* Add a comment.
* Remove a space.
* Use import type to fix module loading errors.
* Use internal cancellation token class.
* Start adding cell output conversion.
* Convert data from byte array to a string.
* More output work.
* Use a Set for proxy filtering.
* Start adding tests.
* Include metadata in cell conversion. Fix other test failures.
* Fix serialize tests.
* Add more tests.
* Remove wildcard characters from vscode filenames.
* Start implementing session details.
* Add more kernel info.
* Add kernel spec.
* Add Future callback wrapper class.
* Start implementing execute conversion.
* Pass notebook URI to requestExecute.
* Start working on CellExecution methods.
* Move some code around to fix layering issues.
* Use proxy to access browser code, rather than direct imports.
* Move files around to fix layering issues.
* Remove unused imports.
* Start implementing some notebook cell execution behaviors.
* Revert some unnecessary extHost API changes.
* Check for nbformat.
* Also handle nbformat in serialize case.
* Active notebook extensions when resolving NotebookInput.
* Fix nbformat handling.
* Disable VSCode notebooks code.
* Filter out notebook services from registration assertion.
* Wait for providers to load before calling canResolve.
* Use controller's viewType for notebook provider ID, instead of controller ID.
* Start adding extHostNotebook tests for new APIs.
* Re-order proxy calls.
* Remove commented code.
* Move vscode provider files to browser folder. Fix RPC serialization issues by using readonly field instead of getter for providerId.
* Add a comment.
* Remove unnecessary dispose call.
* Handle disposable from registerExecuteProvider.
* Remove a comment.
* Remove unnecessary provider fields.
* Remove reference to notebook service to fix circular reference issue in stringify.
* Add object types for methods in ADSNotebookController.
* Wait for controller languages to be ready before marking session manager as ready.
* Add correct promise.
* Add undefined return type for optional supportedLanguages property.
* Refine promise logic.
* Move vscode functionality back to ExtHostNotebook, since the NotebookService can't be passed back over RPC (some kind of circular reference error).
* Fix remaining issues from last commit.
* Replace "not implemented" methods with placeholder return types in order to enable testing.
* Also wait for execution handler to be set before marking session manager as ready.
* Fix usage of NotebookRegistry when updating provider description languages.
* Refine file extension conversion.
* Fix file extension conversion to match ADS extension behavior.
* Emit new provider registration event when adding supported languages.
* Remove checks for duplicate file providers and kernels.
* Fix a test failure.
* Fix file extension parsing.
* Use default executeManager if one isn't defined for provider in notebookModel.
* Add descriptors for waiting on standardKernels registration.
* Increase timeout
* Add an error message.
* Start working on retrieving default kernel from registered providers, rather than always falling back to SQL.
* Revert "Start working on retrieving default kernel from registered providers, rather than always falling back to SQL."
This reverts commit 1916ea1ce3a0072f51bec683116dc7bb6c7aefdc.
* Emit activation events after provider registration.
* Wait on standard kernels availability when getting an execute provider.
* Throw an error if session manager isn't ready yet.
* Actually resolve language promise correctly.
* Add some checks for undefined notebook data objects.
* Create kernel spec data correctly.
* Add extension changes for local testing only.
* Clean up test class.
* Add a reminder comment.
* Undo commented out notebook stuff
* Temporarily hard code default kernel.
* Retrieve default kernel in notebookModel if it's not already provided.
* Revert an import change.
* Remove unnecessary method from extHostNotebook.
* Move an interface around.
* wip
* Check for proposed API for some VSCode extHost methods.
* Remove a comment.
* Fix notebookUtils tests.
* Fix notebookModel tests.
* Fix notebookFindModel tests.
* Fix notebookViewsExtension tests.
* Fix remaining notebookView tests.
* Refactor output conversion functionality into separate methods.
* Update some unit tests for output conversion.
* Move a method.
* Rename conversion methods to fit acronym styling.
* Add another conversion test case.
* Revert local testing changes.
* Remove old method.
* cleanup
* Remove some comments.
* Move localized string to locConstants.
* Add a space to loc string.
* Add comments to new SQL Carbon Edit tags.
* Create constants for nbformat and nbformat_minor.
* Move some vscode-only fields to proposed APIs.
* Check for valid state
* Properly null check
* Adding logging for provider wait timeouts.
* wip update
* Fix compile
* Switch to cell edits
* Update docs
* Remove custom output type
* cleanup
* fix
* cleanup
* more cleanup
* Fixes
* Fix tests and lint errors
Co-authored-by: Cory Rivera <corivera@microsoft.com>
* initial changes
* add isCodeOutput and apply decorations on output
* Add extension gallery update reminder action (#17644)
* Fix extensionsGallery.json name (#17646)
* Remove galleries list action (#17648)
* multi-level table support (#17638)
* multi-level table support
* comments
* address comments
* add period to end of sentence.
* Show connection string example for add sql binding quickpick (#17650)
* add connection string example
* reorder
* Resolves same-origin-policy violation when ADS web is running in a container (#17555)
* Stops appending port to authority for web mode
* Clarifies comment
* Adds missing sql carbon edit tag
* vbump STS (#17653)
* use latest STS (#17658)
* Refactoring readProjFile() (#17637)
* move reading project parts to different helper functions
* cleanup
* remove comment
* addressing comments
* Corrects Web Build Pipeline ENOENT Error (#17656)
* Checks for successful directory creation
* Revert "Checks for successful directory creation"
This reverts commit 372409ef323f0d82e11992bc7bc33d607a7d5581.
* Checks for the existence of the logs directory before accessing.
* Adds SQL carbon edit comment
* Removing call to copy from non-existing directory.
* Removes unneeded import
* Checks for file existence before copying.
* Provides explanation for modification
* Replaces file existence check with exception handling.
* Bump tools service (#17671)
* Apply changes from Remote Database to sqlproj - mssql changes (#17655)
* update project from database
* update project from database
* update project from database
* Re-adding schemaComparePublishChanges for temporary backcompat
* Adding comment for keeping enum values in sync
* Correcting enum value
Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>
* update add file/folder for msbuild sdk style projects (#17660)
* update add file for msbuild sdk style projects
* also handle add folder
* fix comment
* fix issue reported by component governance (#17678)
* update json-schema version
* remove unused packages
* update package.json
* SQL Binding: Give default connection setting name (#17659)
* show sqlconnectionstring in quickpick
* fix duplicate sqlconnectionstring setting
* add (new)
* add sqlconnectionstring as default setting name
* check if sqlconnectionstring already exists
* Provide aria-labels for node checkboxes in the tree view. (#17676)
During accessibility testing, it was discovered that screen reader does not announce what checkboxes in the tree view represent. It was merely announcing "checkbox unchecked", so it was not clear without visuals which checkbox the focus is on.
This change sets an `aria-label` of the checkbox elements to match the label of the owning tree node. This way the announcement becomes "My Node; checkbox; unchecked". This is fine as a quick solution to the problem, but in the future we may want to consider adding additional checkbox label property to the nodes exposed by the tree provider, so that each checkbox can announce additional information, if needed.
* Respect ARIA label specified int he tree component options. (#17674)
During accessibility testing it was discovered that tree view in our wizard reads "Tree Node tree view" instead of the proper label that is specified. It turned out to be the problem with the tree component, where `ariaLabel` was hardcoded to "Tree Node", instead of the one provided in the options.
This change addresses the problem by passing through `ariaLabel` from the options object to the underlying tree control. I also removed the default `Tree Node` hardcoded label, as it didn't make much sense. This does mean that all tree-views that do not explicitly specify their aria-label will now get an empty label. I think this is better than having unrelated, unlocalized `Tree Node`.
I'm also worried about changes to the `ariaLabel` property after the component was initialized. I updated the code to propagate the value to the underlying tree view in the `setProperties` override of the tree component and hope that it will take care of it.
* Fix sql projects net6 warnings (#17673)
* fix .net 6 error showing on startup
* fix double warning
* addressing comments
* update key string
* undo adding space in net core sdk location setting (#17684)
* update names for msbuild sdk style projects (#17677)
* update names for msbuild sdk style projects
* remove msbuild from names
* update comments
* Designer: property descriptions (#17668)
* format
* added strings
* format doc
* use codicon instead
* show descriptions in property pane only
* fix ssdt string bug
* fix overflow option
* review comments
* review comments
* changes
* sts 156 vbump (#17683)
* Sql Binding: Add "Check out pane for more details" when nuget package download fails (#17680)
* check output for more details
* detail error
* wait for result from showerrormessage
* [Loc] Update to sql-database-projects and sql.xlf (#17687)
* update the vmImage for build jobs (#17689)
* update vmImage for windows build
* update tar command
* use specific macos version
* support building msbuild sdk style projects (#17675)
* support building msbuild sdk style projects
* fixes after merge
* add foreign keys and constraints (#17697)
* foreign keys and constraints
* refactoring
* fix issues
* properties pane improvements (#17700)
* [Loc] update to tabledesignercomponentinput (#17704)
* Add instructions for developing VS Code version of sql-database-projects (#17705)
* Adding UI for deploying a db proj to docker (#17495)
* code refactoring (#17706)
* Improve accessibility for wizard steps navigation (#17669)
Our extension is relying on the wizard dialog. During accessibility testing it was discovered that wizard step buttons are being reported as links by the screen reader (NVDA, JAWS). Claimed expected behavior by the tester is that they should be announced as buttons.
I discussed this issue with accessibility SMEs and they said it is perfectly fine to keep them as links. They did mention that they would probably design the UX differently from the start, but given that we already have it this way, links are fine. They did suggest to add few additional ARIA attributes to the link elements:
- `aria-current="step"` if the link is for the currently active step. This literally just announces "current step" at the end, when you focus on a link
- `aria-disabled="true"` makes it say "**unavailable**; link; *<step number>*" when in NVDA "browse" mode and move to the grayed-out link.
So this change implements the said improvements.
* bump sts version to 159 (#17709)
* LEGO: check in for main to temporary branch. (#17699)
* LEGO: check in for main to temporary branch. (#17702)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* [Loc] update to sql-database-projects (#17713)
* LEGO: check in for main to temporary branch. (#17715)
* Register additional editor overrides when adding new notebook file types (#17708)
* Also standardized file extension contributions to always start with a period, and to always do lower case string comparisons for file extensions.
* input width in designer (#17714)
* Add additional properties to wizard page navigation events (#17716)
* Fix open external not working (#17717)
* save password checkbox fix (#17718)
* save password checkbox fix
* remove code to reset the checkbox value
* allow build to continue when cache task fails (#17720)
* cache task should not fail the build
* update cachesalt
* Fix language flavor change on connection when in sqlcmd mode (#17719)
* Fix language flavor change on connection when in sqlcmd mode
* comment + fix
* LEGO: check in for main to temporary branch. (#17722)
* LEGO: check in for main to temporary branch. (#17724)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* Update one more variable name for sdk style projects (#17710)
* LEGO: check in for main to temporary branch. (#17725)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* LEGO: check in for main to temporary branch. (#17726)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* LEGO: check in for main to temporary branch. (#17730)
* Fix "unsupported version" error when adding sql binding package (#17721)
* Apply changes from remote database to sqlproj - schema-compare changes (#17679)
* update project from database
* update project from database
* Merge from main
* Removing dupe test stub
* PR feedback
* cleanup
* PR feedback
* Fixing tests, adding stubs to update sqlproj as schema compare target
* updating code comment
Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>
* [Loc] Update to schema-compare XLF (#17733)
* Enabled deployment of Azure Arc data controllers in directly connected mode (#17707)
* Added fields for connectivity mode, custom loc, auto-metrics, auto-logs, and the dynamic enablement of such fields.
* Changed the description of the data controller details page.
* Change notebook params to work for direct mode
* Added login to dc deployment notebooks
* Fixed auto upload metrics and logs true/false, separated login into another cell.
* Removed localization of indirect and direct connectivity labels.
* Fix ordering of reading sqlproj Build Includes and Removes (#17712)
* evaluate includes and removes in order in sqlproj
* fix after merge
* fix comment
* update comment
* Add resource deployment samples for (#17734)
* Update remove file for sdk style sql projects (#17688)
* add support for removing file in new style project
* fix test
* only load files, not whole project when checking if a <Build Remove> needs to be added
* merge changes
* fixes after merge
* [Loc] update to Arc XLF (#17737)
* Bump to latest version of azdata (#17735)
* Remove .net 6 version cutoff for building sql projects (#17736)
* remove .net 6 version cutoff for building sql projects
* Revert "Warning when .NET 6 SDK is detected (#17422)"
This reverts commit 2ed8aeb565.
* add back skipVersionSupportedCheck
* add back return false
* addressing comments
* [Loc] update to sql-database-projects xlf (#17743)
* Add additional notebook tests for handling relative links. (#17739)
* [Loc] Fix for duplicate strings in LCL files (#17756)
* WIP spanish lcl duplicate removal
* Revert "WIP spanish lcl duplicate removal"
This reverts commit 5f943153ec8980849a045c8bf7256d852571a778.
* fix for duplicate strings
* removed spaces
* Fixes ADS Web bug around copying user codes and opening a browser tab when adding an Azure Account. (#17760)
* Fixes bug around copying user codes and opening a browser tab.
* Code review changes
* Additional review changes.
* Unnecessary import removed
* Editing pipeline ACR service connection endpoint to the latest one created (#17767)
* using the new registry endpoint
* updating the service connection
* Changing the name of acr service endpoint to SqlToolsContainer
* Updating web build acr endpoint as well.
* Notebooks: Add Tooltips for Link/Image Buttons on Markdown Toolbar (#17763)
* Add title for tooltips
* Tweak tooltips
* Added UI for user to accept EULA when deploying sql proj to docker container (#17762)
* fix sorting bug (#17769)
* fix sorting bug
* comments
* Set default radio button selection, evaluate default component popula… (#17764)
* Set default radio button selection, evaluate default component population off of selection instead of unprocessed input
* rename var
* if -> switches
* Remove project radio buttons because they require commands that aren't yet checked in (and fail as a result)
* Added fix for Publish Target Label Position (#17771)
* Added fix for Publish Target Label Position
* renamed checkbox
* LEGO: check in for main to temporary branch. (#17775)
* LEGO: check in for main to temporary branch. (#17778)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* update dashboard taskbar separator (#17779)
* remove comments
* fix applying decorations
* add test
* enable find in sql result set
* add tests and update sql results highlight logic
* calculate the outputComponent index
* fix editor issues later
* remove newline replace on search
* address comments
* fix highlight issue
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
Co-authored-by: Lucy Zhang <luczhan@microsoft.com>
Co-authored-by: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com>
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com>
Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>
Co-authored-by: Alexander Ivanov <nahk-ivanov@users.noreply.github.com>
Co-authored-by: Aditya Bist <adbist@microsoft.com>
Co-authored-by: Sai Avishkar Sreerama <74571829+ssreerama@users.noreply.github.com>
Co-authored-by: Alex Ma <alma1@microsoft.com>
Co-authored-by: Leila Lali <llali@microsoft.com>
Co-authored-by: csigs <csigs@users.noreply.github.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: Candice Ye <candiceye@berkeley.edu>
Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>
* Added customlocation, location, resource group, and connection mode to controllerinfo. Updated SQL MIAA create notebook with direct mode params.
* Removed annotations from metadata in postgres test file.
* Only parse the customlocation if the connection mode is direct.
Co-authored-by: Candice Ye <canye@microsoft.com>
* enable add sql binding command
* add preview to command
* use resourceScheme instead of resourceExtname
* bump version to 0.15.0
* revert version bump
* Set default radio button selection, evaluate default component population off of selection instead of unprocessed input
* rename var
* if -> switches
* Remove project radio buttons because they require commands that aren't yet checked in (and fail as a result)
* using the new registry endpoint
* updating the service connection
* Changing the name of acr service endpoint to SqlToolsContainer
* Updating web build acr endpoint as well.
* remove .net 6 version cutoff for building sql projects
* Revert "Warning when .NET 6 SDK is detected (#17422)"
This reverts commit 2ed8aeb565.
* add back skipVersionSupportedCheck
* add back return false
* addressing comments
* add support for removing file in new style project
* fix test
* only load files, not whole project when checking if a <Build Remove> needs to be added
* merge changes
* fixes after merge
* Added fields for connectivity mode, custom loc, auto-metrics, auto-logs, and the dynamic enablement of such fields.
* Changed the description of the data controller details page.
* Change notebook params to work for direct mode
* Added login to dc deployment notebooks
* Fixed auto upload metrics and logs true/false, separated login into another cell.
* Removed localization of indirect and direct connectivity labels.
Our extension is relying on the wizard dialog. During accessibility testing it was discovered that wizard step buttons are being reported as links by the screen reader (NVDA, JAWS). Claimed expected behavior by the tester is that they should be announced as buttons.
I discussed this issue with accessibility SMEs and they said it is perfectly fine to keep them as links. They did mention that they would probably design the UX differently from the start, but given that we already have it this way, links are fine. They did suggest to add few additional ARIA attributes to the link elements:
- `aria-current="step"` if the link is for the currently active step. This literally just announces "current step" at the end, when you focus on a link
- `aria-disabled="true"` makes it say "**unavailable**; link; *<step number>*" when in NVDA "browse" mode and move to the grayed-out link.
So this change implements the said improvements.
During accessibility testing it was discovered that tree view in our wizard reads "Tree Node tree view" instead of the proper label that is specified. It turned out to be the problem with the tree component, where `ariaLabel` was hardcoded to "Tree Node", instead of the one provided in the options.
This change addresses the problem by passing through `ariaLabel` from the options object to the underlying tree control. I also removed the default `Tree Node` hardcoded label, as it didn't make much sense. This does mean that all tree-views that do not explicitly specify their aria-label will now get an empty label. I think this is better than having unrelated, unlocalized `Tree Node`.
I'm also worried about changes to the `ariaLabel` property after the component was initialized. I updated the code to propagate the value to the underlying tree view in the `setProperties` override of the tree component and hope that it will take care of it.
During accessibility testing, it was discovered that screen reader does not announce what checkboxes in the tree view represent. It was merely announcing "checkbox unchecked", so it was not clear without visuals which checkbox the focus is on.
This change sets an `aria-label` of the checkbox elements to match the label of the owning tree node. This way the announcement becomes "My Node; checkbox; unchecked". This is fine as a quick solution to the problem, but in the future we may want to consider adding additional checkbox label property to the nodes exposed by the tree provider, so that each checkbox can announce additional information, if needed.
* Checks for successful directory creation
* Revert "Checks for successful directory creation"
This reverts commit 372409ef323f0d82e11992bc7bc33d607a7d5581.
* Checks for the existence of the logs directory before accessing.
* Adds SQL carbon edit comment
* Removing call to copy from non-existing directory.
* Removes unneeded import
* Checks for file existence before copying.
* Provides explanation for modification
* Replaces file existence check with exception handling.
* Use built-in SQL ExecuteProvider by default if no other provider exists.
* Gracefully handle case where standardKernels are not defined for a provider.
* Standardize on just using arrays for various provider registration details.
* use glob to get files for new style msbuild sdk sqlproj
* add tests
* cleanup
* fix test
* don't show bin and obj files and folders
* handle other glob patterns
* fix duplicate entries getting added for glob patterns in project's folder
* format doc
* correct class name
* set content
* remove mssql commands
* merge classes
* code refactoring and bug fixing
* remove unnecessary class
* handle promise
Co-authored-by: Alan Ren <alanren@microsoft.com>
* respect include header option
* use correct option for copying
* check for setting when copying
* add dependency injection
* use instantiation service
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* Clean up extension descriptions
* More cleanup
* learning to spell
* Remove unused loc strings
* Add bundling information & rename view container
* Update data workspace readme
* don't show SSDT update warning for new style projects
* update strings
* add checks for the 2 other ways to specify msbuild sdk
* add link to docs on how to use project sdk
Co-authored-by: Kim Santiago <kisantia@Kims-MacBook-Pro.local>
* Changed the placement of the getValue comment in IValueProvider interface.
* Simplified some params values to feed into deployment notebook better. Added logic to add flags to the sql miaa create calls in notebook. Removed variablename from estimated cost.
* Changed High Availability to Replicas
Co-authored-by: Candice Ye <canye@microsoft.com>
Separate the Views load from the initialization. This way we can load previously created views, and only add the new views data to the document when needed. For now, this happens only when a view is created.
* Added valueprovider for pricing. Pushing this for troubleshooting help.
* Committing changes for troubleshooting help. Moved InputValueType to typings file.
* Add readonly inputs to list
* Fixed ordering of package.json merge items
* Estimated cost moved to input page, ValueProvider only takes in a triggerfields[] and not a single string, fixed pricing logic.
* Removed pricingModel.ts
* Reverted some comments and code changes that were used in debugging.
* Changed some values from localizedConstants to single-quote constants'
* Changed some values from localizedConstants to single-quote constants'
* Added copyright header to pricingUtils.ts
* Removed try catch in extension.ts valueproviders, made some values in PricingUtils.ts top-level instead of exporting.
* Minor changes, added some comments and localized USD.
* Changes pricingutils classes to be constants, and added disposable to Hookupvalueprovider
Co-authored-by: Candice Ye <canye@microsoft.com>
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* Adds loggings to ADS pipeline
* Skips notebook smoke tests for ADS web.
* Skips failing create book dialog tests in web build
* Ignores import tests ADS web
* Groups related tests together for ADS Web and non-web
* Updates distro commit hash
This repository includes configuration for a development container for working with Code - OSS in a local containeror using [GitHub Codespaces](https://github.com/features/codespaces).
This dev container includes configuration for a development container for working with Code - OSS in a local container. For using [GitHub Codespaces](https://github.com/features/codespaces) follow the [prebuilt setup](prebuilt/README.md) which installs VNC for displaying the application window.
> **Tip:** The default VNC password is `vscode`. The VNC server runs on port `5901` and a web client is available on port `6080`.
> **Note:** You will need X11's `DISPLAY` or Wayland's `WAYLAND_DISPLAY` environment variable set locally to allow for the Code - OSS window to display. See [Running GUI app on WSL](https://learn.microsoft.com/en-us/windows/wsl/tutorials/gui-apps) for Windows and [Quartz](https://www.xquartz.org) for Mac.
## Quick start - local
## Quick start
1. Install Docker Desktop or Docker for Linux on your local machine. (See [docs](https://aka.ms/vscode-remote/containers/getting-started) for additional details.)
2.**Important**: Docker needs at least **4 Cores and 6 GB of RAM (8 GB recommended)** to run a full build. If you are on macOS, or are using the old Hyper-V engine for Windows, update these values for Docker Desktop by right-clicking on the Docker status bar item and going to **Preferences/Settings > Resources > Advanced**.
2.**Important**: Docker needs at least **4 Cores and 8 GB of RAM** to run a full build with **9 GB of RAM** being recommended. If you are on macOS, or are using the old Hyper-V engine for Windows, update these values for Docker Desktop by right-clicking on the Docker status bar item and going to **Preferences/Settings > Resources > Advanced**.
> **Note:** The [Resource Monitor](https://marketplace.visualstudio.com/items?itemName=mutantdino.resourcemonitor) extension is included in the container so you can keep an eye on CPU/Memory in the status bar.
3. Install [Visual Studio Code Stable](https://code.visualstudio.com/) or [Insiders](https://code.visualstudio.com/insiders/) and the [Remote - Containers](https://aka.ms/vscode-remote/download/containers) extension.
3. Install [Visual Studio Code Stable](https://code.visualstudio.com/) or [Insiders](https://code.visualstudio.com/insiders/) and the [Dev Containers](https://aka.ms/vscode-remote/download/containers) extension.


> **Note:** The Remote - Containers extension requires the Visual Studio Code distribution of Code - OSS. See the [FAQ](https://aka.ms/vscode-remote/faq/license) for details.
> **Note:** The Dev Containers extension requires the Visual Studio Code distribution of Code - OSS. See the [FAQ](https://aka.ms/vscode-remote/faq/license) for details.
4.Press <kbd>Ctrl/Cmd</kbd> + <kbd>Shift</kbd> + <kbd>P</kbd> or <kbd>F1</kbd> and select **Remote-Containers: Clone Repository in Container Volume...**.
> **Tip:** While you can use your local source tree instead, operations like `yarn install` can be slow on macOS or when using the Hyper-V engine on Windows. We recommend the "clone repository in container" approach instead since it uses "named volume" rather than the local filesystem.
5. Type `https://github.com/microsoft/vscode` (or a branch or PR URL) in the input box and press <kbd>Enter</kbd>.
6. After the container is running, open a web browser and go to [http://localhost:6080](http://localhost:6080), or use a [VNC Viewer](https://www.realvnc.com/en/connect/download/viewer/) to connect to `localhost:5901` and enter `vscode` as the password.
Anything you start in VS Code, or the integrated terminal, will appear here.
Next: **[Try it out!](#try-it)**
## Quick start - GitHub Codespaces
1. From the [microsoft/vscode GitHub repository](https://github.com/microsoft/vscode), click on the **Code** dropdown, select **Open with Codespaces**, and then click on **New codespace**. If prompted, select the **Standard** machine size (which is also the default).
> **Note:** You will not see these options within GitHub if you are not in the Codespaces beta.
2. After the codespace is up and running in your browser, press <kbd>Ctrl/Cmd</kbd> + <kbd>Shift</kbd> + <kbd>P</kbd> or <kbd>F1</kbd> and select **Ports: Focus on Ports View**.
3. You should see **VNC web client (6080)** under in the list of ports. Select the line and click on the globe icon to open it in a browser tab.
> **Tip:** If you do not see the port, <kbd>Ctrl/Cmd</kbd> + <kbd>Shift</kbd> + <kbd>P</kbd> or <kbd>F1</kbd>, select **Forward a Port** and enter port `6080`.
4. In the new tab, you should see noVNC. Click **Connect** and enter `vscode` as the password.
Anything you start in VS Code, or the integrated terminal, will appear here.
Next: **[Try it out!](#try-it)**
### Using VS Code with GitHub Codespaces
You may see improved VNC responsiveness when accessing a codespace from VS Code client since you can use a [VNC Viewer](https://www.realvnc.com/en/connect/download/viewer/). Here's how to do it.
1. Install [Visual Studio Code Stable](https://code.visualstudio.com/) or [Insiders](https://code.visualstudio.com/insiders/) and the the [GitHub Codespaces extension](https://marketplace.visualstudio.com/items?itemName=GitHub.codespaces).
> **Note:** The GitHub Codespaces extension requires the Visual Studio Code distribution of Code - OSS.
2. After the VS Code is up and running, press <kbd>Ctrl/Cmd</kbd> + <kbd>Shift</kbd> + <kbd>P</kbd> or <kbd>F1</kbd>, choose **Codespaces: Create New Codespace**, and use the following settings:
-`microsoft/vscode` for the repository.
- Select any branch (e.g. **main**) - you select a different one later.
- Choose **Standard** (4-core, 8GB) as the size.
4. After you have connected to the codespace, you can use a [VNC Viewer](https://www.realvnc.com/en/connect/download/viewer/) to connect to `localhost:5901` and enter `vscode` as the password.
> **Tip:** You may also need change your VNC client's **Picture Quaility** setting to **High** to get a full color desktop.
5. Anything you start in VS Code, or the integrated terminal, will appear here.
4.Due to the size of the repository we strongly recommend cloning it on a Linux filesystem for better bind mount performance. On macOS we recommend using a Docker volume (press <kbd>F1</kbd> and select **Dev Containers: Clone Repository in Container Volume...**) and on Windows we recommend using a WSL folder:
- Make sure you are running a recent WSL version to get X11 and Wayland support.
- Use the WSL extension for VS Code to open the cloned folder in WSL.
- Press <kbd>F1</kbd> and select **Dev Containers: Reopen in Container**.
Next: **[Try it out!](#try-it)**
## Try it!
This container uses the [Fluxbox](http://fluxbox.org/) window manager to keep things lean. **Right-click on the desktop** to see menu options. It works with GNOME and GTK applications, so other tools can be installed if needed.
> **Note:** You can also set the resolution from the command line by typing `set-resolution`.
To start working with Code - OSS, follow these steps:
1. In your local VS Code client, open a terminal (<kbd>Ctrl/Cmd</kbd> + <kbd>Shift</kbd> + <kbd>\`</kbd>) and type the following commands:
@@ -84,18 +36,20 @@ To start working with Code - OSS, follow these steps:
bash scripts/code.sh
```
2. After the build is complete, open a web browser or a [VNC Viewer](https://www.realvnc.com/en/connect/download/viewer/) to connect to the desktop environment as described in the quick start and enter `vscode` as the password.
3. You should now see Code - OSS!
2. You should now see Code - OSS!
Next, let's try debugging.
1. Shut down Code - OSS by clicking the box in the upper right corner of the Code - OSS window through your browser or VNC viewer.
1. Shut down Code - OSS by clicking the box in the upper right corner of the Code - OSS window.
2. Go to your local VS Code client, and use the **Run / Debug** view to launch the **VS Code** configuration. (Typically the default, so you can likely just press <kbd>F5</kbd>).
> **Note:** If launching times out, you can increase the value of `timeout` in the "VS Code", "Attach Main Process", "Attach Extension Host", and "Attach to Shared Process" configurations in [launch.json](../.vscode/launch.json). However, running `scripts/code.sh` first will set up Electron which will usually solve timeout issues.
> **Note:** If launching times out, you can increase the value of `timeout` in the "VS Code", "Attach Main Process", "Attach Extension Host", and "Attach to Shared Process" configurations in [launch.json](../../.vscode/launch.json). However, running `scripts/code.sh` first will set up Electron which will usually solve timeout issues.
3. After a bit, Code - OSS will appear with the debugger attached!
Enjoy!
# Notes
The container comes with VS Code Insiders installed. To run it from an Integrated Terminal use `VSCODE_IPC_HOOK_CLI= /usr/bin/code-insiders .`.
# This dockerfile is used to build up from a base image to create an image with cached results of running "prepare.sh".
# Other image contents: https://github.com/microsoft/vscode-dev-containers/blob/master/repository-containers/images/github.com/microsoft/vscode/.devcontainer/base.Dockerfile
[](https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/microsoft/vscode)
This repository includes configuration for a development container for working with Code - OSS in a local container or using [GitHub Codespaces](https://github.com/features/codespaces).
> **Tip:** The default VNC password is `vscode`. The VNC server runs on port `5901` and a web client is available on port `6080`.
## Quick start - local
If you already have VS Code and Docker installed, you can click the badge above or [here](https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/microsoft/vscode) to get started. Clicking these links will cause VS Code to automatically install the Dev Containers extension if needed, clone the source code into a container volume, and spin up a dev container for use.
1. Install Docker Desktop or Docker for Linux on your local machine. (See [docs](https://aka.ms/vscode-remote/containers/getting-started) for additional details.)
2.**Important**: Docker needs at least **4 Cores and 8 GB of RAM** to run a full build with **9 GB of RAM** being recommended. If you are on macOS, or are using the old Hyper-V engine for Windows, update these values for Docker Desktop by right-clicking on the Docker status bar item and going to **Preferences/Settings > Resources > Advanced**.
> **Note:** The [Resource Monitor](https://marketplace.visualstudio.com/items?itemName=mutantdino.resourcemonitor) extension is included in the container so you can keep an eye on CPU/Memory in the status bar.
3. Install [Visual Studio Code Stable](https://code.visualstudio.com/) or [Insiders](https://code.visualstudio.com/insiders/) and the [Dev Containers](https://aka.ms/vscode-remote/download/containers) extension.

> **Note:** The Dev Containers extension requires the Visual Studio Code distribution of Code - OSS. See the [FAQ](https://aka.ms/vscode-remote/faq/license) for details.
4. Press <kbd>Ctrl/Cmd</kbd> + <kbd>Shift</kbd> + <kbd>P</kbd> or <kbd>F1</kbd> and select **Dev Containers: Clone Repository in Container Volume...**.
> **Tip:** While you can use your local source tree instead, operations like `yarn install` can be slow on macOS or when using the Hyper-V engine on Windows. We recommend the "clone repository in container" approach instead since it uses "named volume" rather than the local filesystem.
5. Type `https://github.com/microsoft/vscode` (or a branch or PR URL) in the input box and press <kbd>Enter</kbd>.
6. After the container is running, open a web browser and go to [http://localhost:6080](http://localhost:6080), or use a [VNC Viewer](https://www.realvnc.com/en/connect/download/viewer/) to connect to `localhost:5901` and enter `vscode` as the password.
Anything you start in VS Code, or the integrated terminal, will appear here.
Next: **[Try it out!](#try-it)**
## Quick start - GitHub Codespaces
1. From the [microsoft/vscode GitHub repository](https://github.com/microsoft/vscode), click on the **Code** dropdown, select **Open with Codespaces**, and then click on **New codespace**. If prompted, select the **Standard** machine size (which is also the default).
> **Note:** You will not see these options within GitHub if you are not in the Codespaces beta.
2. After the codespace is up and running in your browser, press <kbd>Ctrl/Cmd</kbd> + <kbd>Shift</kbd> + <kbd>P</kbd> or <kbd>F1</kbd> and select **Ports: Focus on Ports View**.
3. You should see **VNC web client (6080)** under in the list of ports. Select the line and click on the globe icon to open it in a browser tab.
> **Tip:** If you do not see the port, <kbd>Ctrl/Cmd</kbd> + <kbd>Shift</kbd> + <kbd>P</kbd> or <kbd>F1</kbd>, select **Forward a Port** and enter port `6080`.
4. In the new tab, you should see noVNC. Click **Connect** and enter `vscode` as the password.
Anything you start in VS Code, or the integrated terminal, will appear here.
Next: **[Try it out!](#try-it)**
### Using VS Code with GitHub Codespaces
You may see improved VNC responsiveness when accessing a codespace from VS Code client since you can use a [VNC Viewer](https://www.realvnc.com/en/connect/download/viewer/). Here's how to do it.
1. Install [Visual Studio Code Stable](https://code.visualstudio.com/) or [Insiders](https://code.visualstudio.com/insiders/) and the the [GitHub Codespaces extension](https://marketplace.visualstudio.com/items?itemName=GitHub.codespaces).
> **Note:** The GitHub Codespaces extension requires the Visual Studio Code distribution of Code - OSS.
2. After the VS Code is up and running, press <kbd>Ctrl/Cmd</kbd> + <kbd>Shift</kbd> + <kbd>P</kbd> or <kbd>F1</kbd>, choose **Codespaces: Create New Codespace**, and use the following settings:
-`microsoft/vscode` for the repository.
- Select any branch (e.g. **main**) - you can select a different one later.
- Choose **Standard** (4-core, 8GB) as the size.
4. After you have connected to the codespace, you can use a [VNC Viewer](https://www.realvnc.com/en/connect/download/viewer/) to connect to `localhost:5901` and enter `vscode` as the password.
> **Tip:** You may also need change your VNC client's **Picture Quality** setting to **High** to get a full color desktop.
5. Anything you start in VS Code, or the integrated terminal, will appear here.
Next: **[Try it out!](#try-it)**
## Try it!
This container uses the [Fluxbox](http://fluxbox.org/) window manager to keep things lean. **Right-click on the desktop** to see menu options. It works with GNOME and GTK applications, so other tools can be installed if needed.
> **Note:** You can also set the resolution from the command line by typing `set-resolution`.
To start working with Code - OSS, follow these steps:
1. In your local VS Code client, open a terminal (<kbd>Ctrl/Cmd</kbd> + <kbd>Shift</kbd> + <kbd>\`</kbd>) and type the following commands:
```bash
yarn install
bash scripts/code.sh
```
2. After the build is complete, open a web browser or a [VNC Viewer](https://www.realvnc.com/en/connect/download/viewer/) to connect to the desktop environment as described in the quick start and enter `vscode` as the password.
3. You should now see Code - OSS!
Next, let's try debugging.
1. Shut down Code - OSS by clicking the box in the upper right corner of the Code - OSS window through your browser or VNC viewer.
2. Go to your local VS Code client, and use the **Run / Debug** view to launch the **VS Code** configuration. (Typically the default, so you can likely just press <kbd>F5</kbd>).
> **Note:** If launching times out, you can increase the value of `timeout` in the "VS Code", "Attach Main Process", "Attach Extension Host", and "Attach to Shared Process" configurations in [launch.json](../../.vscode/launch.json). However, running `scripts/code.sh` first will set up Electron which will usually solve timeout issues.
3. After a bit, Code - OSS will appear with the debugger attached!
# This dockerfile is used to build up from a base image to create an image a cache.tar file containing the results of running "prepare.sh".
# Other image contents: https://github.com/microsoft/vscode-dev-containers/blob/master/repository-containers/images/github.com/microsoft/vscode/.devcontainer/base.Dockerfile
// FORKED FROM https://github.com/eslint/eslint/blob/b23ad0d789a909baf8d7c41a35bc53df932eaf30/lib/rules/no-unused-expressions.js
// and added support for `OptionalCallExpression`, see https://github.com/facebook/create-react-app/issues/8107 and https://github.com/eslint/eslint/issues/12642
/**
* @fileoverview Flag expressions in statement position that do not side effect
comment:'region comments should start with a camel case identifier, `:`, then either a GH issue link or owner, e.g #region myProposalName: https://github.com/microsoft/vscode/issues/<number>',
comment:"We need more info to debug your particular issue. If you could attach your logs to the issue (ensure no private data is in them), it would help us fix the issue much faster.
There are two types of logs to collect:
**Console Logs**
- Open Developer Tools (Help -> Toggle Developer Tools)
- Click the **Console** tab
- Click in the log area and select all text (CTRL+A)
- Save this text into a file named console.log and attach it to this issue.
**Application Logs**
- Open command palette (Click **View** -> **Command Palette**)
- Run the command: **`Developer: Open Logs Folder`**
- This will open the log folder locally. Please zip up this folder and attach it to the issue."
# actions for Out of Scope label
Out of Scope:
comment:"Thank you for opening this suggestion! This enhancement is not planned in our
medium-term roadmap. The issue is being closed to reduce active issues to focus on
enhancements that are being considered for an upcoming release. We will review closed issues
with the 'Out of Scope' label when doing long-term planning."
We need more info to debug your particular issue. If you could attach your logs to the issue (ensure no private data is in them), it would help us fix the issue much faster.
1. First open the Settings page, find the `Mssql: Tracing Level` setting and change that to `All` then restart Azure Data Studio.
2. Open command palette (Click **View** -> **Command Palette**) and run the command `Developer: Set Log Level...` and set the level to `Trace`.
3. Run the repro scenarios.
4. Collect the following logs:
**Console Logs**
- Open Developer Tools (Help -> Toggle Developer Tools)
- Click the **Console** tab
- Click in the log area and select all text (CTRL+A)
- Save this text into a file named console.log and attach it to this issue.
- Developer Tools can be closed via Help -> Toggle Developer Tools
**Application Logs**
- Open command palette (Click **View** -> **Command Palette**)
- Run the command: **`Developer: Open Logs Folder`**
- This will open the log folder locally. Please zip up this folder and attach it to the issue.
5. Now you can revert the Log/Tracing levels changes made in step 1 and step 2.
# actions for Needs Logs - Azure label
Needs Logs - Azure:
comment:|
We need more info to debug your Azure Active Directory issue. If you could attach your logs to the issue (ensure no private data is in them), it would help us fix the issue much faster.
- In the settings menu, find the setting titled `Azure: Logging Level` and select the `Verbose` option
- Restart Azure Data Studio
- Run the process that produces your error
- Open command palette (Click **View** -> **Command Palette**)
- Run the command: **`Developer: Open Logs Folder`**
- Follow this path to find the Azure Accounts log file: `[default log folder]/exthost1/output_logging_[earliest timestamp]/#-Azure Acounts.log`
- Please attach the Azure-Accounts.log file to the issue.
# actions for Out of Scope label
Out of Scope:
comment:"Thank you for your feedback! This feature is currently out of scope and we do not plan to work on it in a currently planned release. We will close this issue to keep our backlog focused on requests that we are planning to work on. Please note that users can continue to vote and comment on closed issues, which we encourage as it helps us understand user interest and can provide more details about why a feature is requested."
"value": "### Categorizing Issues\n\nEach issue must have a type label. Most type labels are grey, some are yellow. Bugs are grey with a touch of red.",
"value": "## tl;dr: Triage Inbox\n\nAll inbox issues but not those that need more information. These issues need to be triaged, e.g assigned to a user or ask for more information",
"editable": true
"value": "## tl;dr: Triage Inbox\n\nAll inbox issues but not those that need more information. These issues need to be triaged, e.g assigned to a user or ask for more information"
},
{
"kind": 2,
"language": "github-issues",
"value": "$inbox -label:\"needs more info\"",
"editable": true
},
{
"kind": 1,
"language": "markdown",
"value": "##### `Config`: defines the inbox query",
"value": "New issues or pull requests submitted by the community are initially triaged by an [automatic classification bot](https://github.com/microsoft/vscode-github-triage-actions/tree/master/classifier-deep). Issues that the bot does not correctly triage are then triaged by a team member. The team rotates the inbox tracker on a weekly basis.\n\nA [mirror](https://github.com/JacksonKearl/testissues/issues) of the VS Code issue stream is available with details about how the bot classifies issues, including feature-area classifications and confidence ratings. Per-category confidence thresholds and feature-area ownership data is maintained in [.github/classifier.json](https://github.com/microsoft/vscode/blob/main/.github/classifier.json). \n\n💡 The bot is being run through a GitHub action that runs every 30 minutes. Give the bot the opportunity to classify an issue before doing it manually.\n\n### Inbox Tracking\n\nThe inbox tracker is responsible for the [global inbox](https://github.com/microsoft/vscode/issues?utf8=%E2%9C%93&q=is%3Aopen+no%3Aassignee+-label%3Afeature-request+-label%3Atestplan-item+-label%3Aplan-item) containing all **open issues and pull requests** that\n- are neither **feature requests** nor **test plan items** nor **plan items** and\n- have **no owner assignment**.\n\nThe **inbox tracker** may perform any step described in our [issue triaging documentation](https://github.com/microsoft/vscode/wiki/Issues-Triaging) but its main responsibility is to route issues to the actual feature area owner.\n\nFeature area owners track the **feature area inbox** containing all **open issues and pull requests** that\n- are personally assigned to them and are not assigned to any milestone\n- are labeled with their feature area label and are not assigned to any milestone.\nThis secondary triage may involve any of the steps described in our [issue triaging documentation](https://github.com/microsoft/vscode/wiki/Issues-Triaging) and results in a fully triaged or closed issue.\n\nThe [github triage extension](https://github.com/microsoft/vscode-github-triage-extension) can be used to assist with triaging — it provides a \"Command Palette\"-style list of triaging actions like assignment, labeling, and triggers for various bot actions.",
"editable": true
},
{
"kind": 1,
"language": "markdown",
"value": "## All Inbox Items\n\nAll issues that have no assignee and that have neither **feature requests** nor **test plan items** nor **plan items**.",
"editable": true
"value": "##### `Config`: defines the inbox query"
"value": "New issues or pull requests submitted by the community are initially triaged by an [automatic classification bot](https://github.com/microsoft/vscode-github-triage-actions/tree/master/classifier-deep). Issues that the bot does not correctly triage are then triaged by a team member. The team rotates the inbox tracker on a weekly basis.\n\nA [mirror](https://github.com/JacksonKearl/testissues/issues) of the VS Code issue stream is available with details about how the bot classifies issues, including feature-area classifications and confidence ratings. Per-category confidence thresholds and feature-area ownership data is maintained in [.github/classifier.json](https://github.com/microsoft/vscode/blob/main/.github/classifier.json). \n\n💡 The bot is being run through a GitHub action that runs every 30 minutes. Give the bot the opportunity to classify an issue before doing it manually.\n\n### Inbox Tracking\n\nThe inbox tracker is responsible for the [global inbox](https://github.com/microsoft/vscode/issues?utf8=%E2%9C%93&q=is%3Aopen+no%3Aassignee+-label%3Afeature-request+-label%3Atestplan-item+-label%3Aplan-item) containing all **open issues and pull requests** that\n- are neither **feature requests** nor **test plan items** nor **plan items** and\n- have **no owner assignment**.\n\nThe **inbox tracker** may perform any step described in our [issue triaging documentation](https://github.com/microsoft/vscode/wiki/Issues-Triaging) but its main responsibility is to route issues to the actual feature area owner.\n\nFeature area owners track the **feature area inbox** containing all **open issues and pull requests** that\n- are personally assigned to them and are not assigned to any milestone\n- are labeled with their feature area label and are not assigned to any milestone.\nThis secondary triage may involve any of the steps described in our [issue triaging documentation](https://github.com/microsoft/vscode/wiki/Issues-Triaging) and results in a fully triaged or closed issue.\n\nThe [github triage extension](https://github.com/microsoft/vscode-github-triage-extension) can be used to assist with triaging — it provides a \"Command Palette\"-style list of triaging actions like assignment, labeling, and triggers for various bot actions."
},
{
"kind": 1,
"language": "markdown",
"value": "## All Inbox Items\n\nAll issues that have no assignee and that have neither **feature requests** nor **test plan items** nor **plan items**."
"value": "### Bug Verification Queries\n\nBefore shipping we want to verify _all_ bugs. That means when a bug is fixed we check that the fix actually works. It's always best to start with bugs that you have filed and the proceed with bugs that have been filed from users outside the development team. ",
"editable": true
"value": "### Bug Verification Queries\r\n\r\nBefore shipping we want to verify _all_ bugs. That means when a bug is fixed we check that the fix actually works. It's always best to start with bugs that you have filed and the proceed with bugs that have been filed from users outside the development team. "
},
{
"kind": 1,
"language": "markdown",
"value": "#### Config: update list of `repos` and the `milestone`",
"editable": true
"value": "#### Config: update list of `repos` and the `milestone`"
| Object Explorer | Introduced an action to collapse all open objects in Object Explorer |
| Object Explorer | Added ability to use left and right arrows in OE to open or close trees |
| Object Explorer | Right-click menu options updated and order modified |
| Profiler / Extended Events | Introduced support for opening .XEL files up to 1GB in size |
| Query Editor | Introduced a new configuration option to control whether to add a line break between rows when copying if the previous row has a trailing line break |
| Result Set | Introduced keyboard shortcut (Ctrl/CMD + Shift + C) to copy information from the results grid with headers |
| Result Set | Introduced keyboard shortcut (Ctrl/CMD + Shift + O) to sort columns in a result set |
| SQL Database Projects Extension | Added the ability to create a publish profile from the Add Item… menu |
| Table Designer | Added configuration option to prevent DDL triggers from being disabled as part of the table modification |
| User Management | Improved table component performance in the Securables dialog of User properties |
| VS Code merge | VS Code merges to version 1.79, read [their release notes](https://code.visualstudio.com/updates/v1_79) to learn more |
### Bug fixes in 1.45.0
| New Item | Details |
| --- | --- |
| Accessibility | Improved contrast for buttons on Welcome page when using light themes |
| Accessibility | Improved focus on Home tab when using High Contrast Aquatic/Desert theme |
| Accessibility | Corrected border color the issue reporter dialog when using light theme |
| Accessibility | Fixed multiple issues with screen readers |
| Accessibility | Improved keyboard navigation in select database dropdown and added visual label |
| Accessibility | Added required indicator for Server group name when configuring a server group |
| Accessibility | Fixed display so contents are visible at 200% zoom in Notebook cell |
| Accessibility | Added tooltip for Learn more button in New Deployment window |
| Backup/Restore | Addressed issue with backup/restore dialog titles not updating for non-MSSQL databases |
| Central Management Servers Extension | Resolved error generated after saving a connection using SQL authentication |
| Charting | Addressed issue with mix/max value setting for a chart axis |
| Connection | Improved dialog window for adding an Azure account when authentication code is required |
| Connection | Fixed throttling of ARM requests when in the Browse Connections tab |
| General | Fixed issue with vertical scrolling in dialog windows |
| General | Fixed error "Cannot read properties of undefined" |
| Notebooks | Addressed inability to open JSON in a new tab from Notebook results cell |
| Notebooks | Fixed error "Unable to load and parse grammar for scope markdown.math.inline" when creating a Notebook text cell |
| Object Explorer | Addressed connection leak which occurred when renaming a table |
| Object Explorer | Improved error handling in server tree expand requests |
| Object Explorer | Fixed issue with unexpected connection drops in Object Explorer |
| SQL Database Projects Extension | Introduced ability to add sqlcmd variables without a default value via the quickpick |
| User Management | Removed unsupported database roles for Azure SQL DB user creation |
| User Management | Included MUST_CHANGE option for Azure SQL when creating a new login or for a password change |
### Known issues in 1.45.0
New Item | Details | Workaround |
| --- | --- | --- |
| Installation | Azure Data Studio installation fails on RHEL 8 | Use RHEL 9, or manually install glibc-2.29 and add it to the Library Path and then re-install ADS |
## May 2023 (hotfix)
Azure Data Studio 1.44.1 is the latest general availability (GA) release.
- Release number: 1.44.1
- Release date: June 5, 2023
### Bug fixes in 1.44.1
| New Item | Details |
| --- | --- |
| Backup & Restore | Fixed an issue in Object Explorer where the Restore dialog failed to open. https://github.com/microsoft/azuredatastudio/issues/23257 |
| Connection | Resolved issue that caused a login failure in Azure SQL for hyphenated user accounts. https://github.com/microsoft/azuredatastudio/issues/23210 |
| Object Explorer | Addressed inability to open a view using CTRL/CMD + Q or the Open View menu. https://github.com/microsoft/azuredatastudio/issues/23236 |
| Query Editor | Introduced a performance improvement in the Query Editor language service by enabling connection pooling. https://github.com/microsoft/azuredatastudio/issues/22970 |
## Version 1.44.0
Azure Data Studio 1.44.0 is the latest general availability (GA) release.
- Release number: 1.44.0
- Release date: May 24, 2023
### What's new in 1.44.0
| New Item | Details |
| --- | --- |
| Connection | Enabled Sql Authentication Provider by default for Azure SQL connections and the MSAL Authentication Library. Learn more at [Connect with Azure Data Studio](https://aka.ms/azuredatastudio-connection) |
| Connection | Introduced support for passing in advanced connection options in command line arguments |
| Connection | Added ability to provide an Application Name in the connection string parameter |
| General | Added support for customizing table keyboard shortcuts |
| General | Added warning notification on startup if Azure PII logging is enabled |
| GitHub Copilot | GitHub Copilot extension for autocomplete-style suggestions added to extension gallery. Learn more at https://aka.ms/ads-copilot |
| Notebooks | Fixed issue where deleted text listed using the Find feature |
| Object Explorer | Introduced filtering capability for Object Explorer (preview) |
| Query Editor | Shorted text for Change Connection and Export as Notebook button |
| Query Results | Increased the default max column width |
| SQL Database Projects Extension | Released version 1.1.1 |
| SQL Database Projects Extension | Improved performance of loading one or more large projects |
| SQL Database Projects Extension | Introduced ability to save publish settings to a new or existing publish profile |
| User Management | Added support for creating database and server roles (preview) |
| User Management | Improved authentication options when creating database users (preview) |
### Bug fixes in 1.44.0
| New Item | Details |
| --- | --- |
| Accessibility | Added labels to radio groups in SQL Database Projects dialog |
| Accessibility | Fixed issue with narrator reading character twice in network share path for Azure SQL migration extension |
| Accessibility | Addressed problem where keyboard focus did not shift to error message when creating a new database |
| Accessibility | Fixed issue with voiceover not announcing label names correctly when updating a database project |
| Connection | Improved token refresh behavior |
| Connection | Enabled support to login with blank passwords when creating MSSQL connection |
| Connection | Added change password dialog display after password expiration occurs for a SQL login |
| Connection | Addressed scenario where Intellisense stopped working after a connection token expired |
| Connection | Fixed behavior where PostgreSQL username was incorrectly replaced |
| Connection | Implemented support for connections against the same server but with different properties |
| Connection | Resolved issue where connection status changed to red (disconnected) after moving an active connection to a server group |
| Connection | Updated Azure node in Connection dialog to include notation when no subscriptions are found |
| Connection | Updated firewall dialog to pre-select the account and tenant in the connection dialog |
| Extension | Fixed an issue with over-encoded URLs in diagnostic error messages |
| Intellisense | Resolved issue with SORT_IN_TEMPDB not recognized as valid T-SQL syntax when creating an object |
| Notebooks | Updated Notebook connection to support MySQL and PostgreSQL when connecting to an existing Notebook |
| Query Results | Fixed overlapping action display when multiple result sets are returned |
| Schema Compare | Update scmp files to be backwards compatible |
| SQL Database Projects Extension | Fixed multiple issues related to SQLCMD variables and projects |
| SQL Database Projects Extension | Addressed a failure that was occurring when using schema compare with Azure Synapse dedicated pools |
| SQL Database Projects Extension | Resolved problem where a database project would not build after a reference to a system database was added from SSDT |
| SQL Database Projects Extension | Fixed issue where projects were listed twice when using multi root workspaces |
| SQL Database Projects Extension | Fixed an issue where file structure information was not stored in the scmp file after a schema compare |
| SQL Database Projects (VS Code) | Updated default folder location when creating a new project from database workflow |
For a full list of bug fixes addressed for the May 2023 release, visit the [May 2023 Release on GitHub](https://github.com/microsoft/azuredatastudio/milestone/98?closed=1).
## Version 1.43.0
* Release number: 1.43.0
* Release date: April 12, 2023
### What's new in 1.43.0
| New Item | Details |
| --- | --- |
| Connection | Added notation for required properties (e.g. Attestation protocol and Attestation URL) when Secure Enclaves are enabled |
| SQL Database Projects extension | General Availability |
| SQL Database Projects extension | Move and rename files within Database Projects view |
| SQL Database Projects extension | SQLCMD variables available for editing in Database Projects view |
| Object Explorer | Double-clicking on a user or table in Object Explorer will open the designer for the object |
| Query Editor | Added a Parse button to the Query Editor toolbar for parsing queries before execution |
| Query Results | Added support to select a row in query results via double click |
### Bug fixes in 1.43.0
| New Item | Details |
| --- | --- |
| Connection | Added support for linked accounts with same username but different domains |
| Connection | Added ability to include optional name and grouping when creating a new connection using a connection string |
| Connection | Updating username in MSSQL connections to use Preferred username for the display name |
| Connection | Fixed issue with encoding for OSX keychain on macOS |
| Connection | Added support for Azure MFA and ‘Sql Authentication Provider’ on Linux |
| Dataverse | Addressed error generated when expanding the database node for a Dataverse database in Object Explorer |
| IntelliCode extension | Fixed error that occurred when launching Azure Data Studio with Visual Studio Code IntelliCode extension installed |
| PostgreSQL extension | Implemented support for exporting query results on Apple M1 from a notebook |
| SQL Database Projects extension | Added Accessibility Fixes related to screen reader, label names, and improved focus when navigating |
For a full list of bug fixes addressed for the April 2023 release, visit the [April 2023 Release on GitHub](https://github.com/microsoft/azuredatastudio/milestone/99?closed=1).
## Version 1.42.0
* Release number: 1.42.0
* Release date: March 22, 2023
### What's new in 1.42.0
| New Item | Details |
| --- | --- |
| ARM64 Support for macOS | Implemented native arm64 SqlToolsService support for arm64 Windows and macOS. |
| Connection | Changed the icon under Linked Accounts when adding a new Azure account. |
| Connection | Introduced support for the Command Timeout connection property. |
| Connection | Added support for all three connection encryption options: Strict, Mandatory, and Optional. |
| Connection | Introduced HostNameInCertificate connection property under Security on the Advanced tab, for server with a certificate configured. |
| Connection | Added new advanced option in the Connection dialog to support Secure Enclaves. |
| Connection | Introduced a new setting, Mssql Enable Sql Authentication Provider to allow connections to be maintained without the concern of losing access token lifetime or getting dropped by server. Access tokens will be refreshed internally by the SqlClient driver whenever they are found to be expired. This option is disabled by default. |
| Connection | Added support for connections to Microsoft Dataverse using the TDS endpoint. |
| Connection | Introduced support for change password. |
| Connection | Added support for encryption options for Arc SQL Managed Instance when server certificates are not installed. |
| Deployment | Moved the New Deployment option from the Connections breadcrumb to the File Menu. |
| Object Explorer | Introduced ability to group objects in Object Explorer by database schema. This applies to all MSSQL connections when enabled or disabled. |
| Object Explorer | Introduced a new option to allow a custom timeout to be configured for Object Explorer. Within Settings, enable Mssql > Object Explorer: Expand Timeout. |
| Query Results | Added option to disable special handling for JSON strings. |
### Bug fixes in 1.42.0
| New Item | Details |
| --- | --- |
| Accessibility | Updated server group color display to improve visibility and contrast. |
| Connection | Removed refresh action for connections which are disconnected. |
| Connection | Fixed issue with MSAL not properly set for connections. |
| Connection | Added ability to delete a server group if no connections exist for it. |
| Connection | Added connection display name to the Delete Connection dialog. |
| Connection | Azure connections with "Do not save" for the server group are no longer added to the default server group list. |
| Connection | Improved error handling in the connection dialog. |
| Connection | Fixed issue where saved passwords were not retained for Azure SQL connections. |
| Connection | Improved method to retrieve database access when connecting to Azure SQL. |
| Connection | Improved connection experience for cloud users. |
| Connection | Improved account and tenant selection when connecting to Azure SQL in the connection dialog. |
| Deployment | Improved narration for deployment wizard. |
| Installation | Updated default install location for the Windows on ARM installer. |
| MySQL Extension | Addressed issue where dialog boxes in the MySQL connection pane were not editable. |
| Notebooks | Fixed issue with updating the relative path in a Notebook cell. |
| Notebooks | Fixed issue that caused internal notebook links to break when editing characters in the page. |
| Notebooks | Addressed error thrown when opening a Notebook via a link. |
| Object Explorer | Fixed issue with Object Explorer node not expanding. |
| Query Editor | Fixed database dropdown list for contained users to display correctly. |
| Query Editor | Addressed issue where database dropdown list was not ordered the same as in Object Explorer. |
| Query Editor | Added the ability to properly escape special characters when they exist in object names. |
| Query Editor | Fixed issue which caused query timer to continue to run even though execution was complete. |
| Query Plan Viewer | Addressed an issue where a query plan would not render when opened via a URL. |
| Query Results | Improved precision formatting for datetimeoffset data type. |
For a full list of bug fixes addressed for the March 2023 release, visit the [bugs and issues list on GitHub](https://github.com/microsoft/azuredatastudio/milestone/95?closed=1).
#### Known issues
For a list of the current known issues, visit the [issues list on GitHub](https://github.com/microsoft/azuredatastudio/issues?q=is%3Aissue).
## Version 1.41.2
* Release date: February 10, 2023
* Release status: General Availability
### Bug fixes in 1.41.2
| New Item | Details |
| --- | --- |
| Connection | Fixed a regression blocking connections to sovereign Azure clouds |
| Query Editor | Fixed a regression causing the Output window to display on each query execution |
## Version 1.41.1
* Release date: January 30, 2023
* Release status: General Availability
### Bug fixes in 1.41.1
| New Item | Details |
| --- | --- |
| Connection | Fixed a bug causing incorrect Azure account tenant selection when connecting to server through Azure view |
| Object Explorer | Fixed a regression causing Object Explorer to not show database objects for Azure SQL DB Basic SLO |
| Azure SQL Migration Extension | Premium series memory optimized SQL MI SKUs included in recommendations. |
| Connection | Migrated Azure authentication library from ADAL to MSAL. MSAL is the library used by default starting with release 1.41. However, if you encounter issues, you can change back to ADAL within **Settings > Azure: Authentication Library**. |
| Connection | Added ability to provide a description when creating a firewall rule from Azure Data Studio. |
| Connection | Include ability to change password for new or expired login. |
| Connection | Add support for SQL Server Alias use when connecting to a server. |
| MongoDB Atlas Extension | Provides the ability to connect to and query data on MongoDB Atlas (Preview). |
| Notebooks | Provide option for users to convert markdown to a table or not when HTML table tag is present. |
| Object Explorer | Databases are no longer brought online in serverless Azure SQL when Databases node is expanded. |
| Object Explorer | Added support for Ledger views. |
| Object Explorer | Fixed issue with key binding for objectExplorer.manage not working. |
| Query Editor | Fixes and updates to SQL grammar (colorization and auto-complete). |
| Query Plan Viewer | Changed default folder to be user’s home directory when saving a query plan. |
| Query Results | Added ability to only copy Column Headers, and only for cells that are highlighted. |
| Query Results | Added option to show or hide the action bar in the results window. |
| Query Results | Increased height of horizontal scrollbar in results window. |
| Query Results | Added new aggregate details in the results toolbar when selecting multiple cells. |
| SQL Projects Extension | Provide the ability select an existing project via a new dropdown. |
### Bug fixes in 1.41.0
| New Item | Details |
| --- | --- |
| Accessibility | Accessibility improvements were made in the Query Plan Viewer, Query History Extension and Migration Extension. |
| Big Data Cluster | Fix missing connect icon in BDC view header bar. |
| Big Data Cluster | Fixed issue preventing HDFS nodes for BDC servers in Object Explorer from expanding. |
| Connection | Added ability to delete a connection that has expired AAD credentials. |
| Connection | Improved experience when Azure Active Directory token expiration occurs. |
| Connection | Improved connection experience when using multiple Azure tenants. |
| Connection | Addressed problem with adding a firewall exception for a non-default Azure subscription. |
| Migration Extension | Added support for non-public clouds for migration scenarios. |
| MySQL Extension | Updated resource endpoints to support AAD logins in the MySQL extension. |
| Notebooks | Improve Intellisense refresh in Notebook cells. |
| Notebooks | Address issue with "New Notebook Job" resulting in an empty form. |
| Object Explorer | Fixed issue with database list not loading. |
| Query Execution | Fixed error generated when executing a query with LEFT JOIN and NULL values. |
| Query Plan Viewer | When saving query plans (.sqlplan file), the filename will numerically increment to prevent duplicate filenames. |
| Query Results | Fixed issue where users were unable to open JSON data as a new file. |
| Query Results | Provide proper cell selection and navigation in the query results grid. |
| Query Results | Improved the handling of line breaks when copying cell contents. |
| Query Results | Addressed issue where a column would re-size incorrectly when auto-sizing in the results output. |
| Query Results | Fixed behavior where focus was incorrectly set on a cell using keyboard navigation. |
| Resource Deployment | Remove 'Preview' flag for SQL Server 2022 deployment types. |
| Schema Compare Extension | Fixed problem where differences in schema compare were not being highlighted. |
| Schema Compare Extension | Permissions are now included in schema compare when the "Include Permissions" option is selected. |
| SQL Projects Extension | Changes to db_datawriter or db_datareader roles are now supported. |
| SQL Projects Extension | Updated Database Projects Net Core SDK Location dialog to be more descriptive. |
| Table Designer | Updated Table Designer to disable transaction support for Azure Synapse databases. |
| Table Designer | Addressed problem of the table name not refreshing after being updated prior to publishing. |
| Table Designer | Fixed issue where table designer could not be opened for existing Ledger tables. |
## Version 1.40.2
* Release date: December 27, 2022
* Release status: General Availability
### Bug fixes in 1.40.2
* Fix potential elevation of privilege issue using Bash shell on Windows. VS Code issue [#160827](https://github.com/microsoft/vscode/issues/160827)
## Version 1.40.1
* Release date: November 22, 2022
* Release status: General Availability
### Bug fixes in 1.40.1
* Fixed bug that caused folders in the servers tree to display incorrect contents [#21245](https://github.com/microsoft/azuredatastudio/issues/21245)
## Version 1.40.0
* Release date: November 16, 2022
* Release status: General Availability
### What's new in 1.40.0
| New Item | Details |
|----------|---------|
| Connections | Connections for SQL now default to Encrypt = 'True'. |
| ARM64 Support for macOS | ARM64 build for macOS is now available. |
| Table Designer | Announcing the General Availability of the Table Designer. |
| Table Designer | Period columns now added by default when System-Versioning table option is selected. |
| Table Designer | Added support for hash indexes for In-Memory tables, and added support for columnstore indexes. |
| Table Designer | New checkbox added, "Preview Database Updates", when making database changes to ensure that users are aware of potential risks prior to updating the database.|
| Table Designer | "Move Up" and "Move Down" buttons added to support column reordering for Primary Keys. |
| Query Plan Viewer | Announcing the General Availability of the Query Plan Viewer in Azure Data Studio. |
| Query Plan Viewer | Added support for identification of most expensive operator(s) in a plan. |
| Query Plan Viewer | Updates were made to the properties window to allow for full display of text upon hovering over a cell. Full text can also be copied. |
| Query Plan Viewer | Implemented filter functionality in the Properties pane for an execution plan. |
| Query Plan Viewer | Added support for collapsing and expanding all subcategories within the Plan Comparison Properties window. |
| Query History Extension | Announcing the General Availability of the SQL History Extension. |
| Query History Extension | Now includes ability to persist history across multiple user sessions. |
| Query History Extension | Added the ability to limit the number of entries stored in the history. |
| Schema Compare | Users can now open .scmp files directly from the context menu for existing files in the file explorer. |
| Query Editor | Now allows full display for text strings larger than 65,535 characters. |
| Query Editor | Added support for the SHIFT key when making multiple cell selections. |
| MySQL Extension | Support for MySQL extension is now available in preview. |
| Azure SQL Migration Extension | Azure SQL Database Offline Migrations is now available in preview. Customers can use this new capability to save and share reports as needed. |
| Database Migration Assessment for Oracle | Assessment tooling for Oracle database migrations to Azure Database for PostgreSQL and Azure SQL available in preview. |
| VS Code merge | VS Code merges to version 1.67. Read [their release notes](https://code.visualstudio.com/updates/v1_67) to learn more. |
| SQL Database Projects | Adds SQL projects support for syntax introduced in SQL Server 2022.|
### Bug fixes in 1.40.0
| New Item | Details |
|----------|---------|
| Connections | Fixed bug that occurred when trying to connect to the Dedicated Admin Connection (DAC) on SQL Server. |
| Connections | Fixed issue with wrong tenant showing up while trying to connect to a database with Azure Active Directory login. |
| Connections | Fixed zoom reset behavior when adding a new connection. |
| Connections | Fixed loading bug what occurred when attempting to sign in to Azure via proxy. |
| Connections | Fixed issue encountered while attempting to connect to a "sleeping" Azure SQL Database. |
| Object Explorer | Fixed the SELECT script generation issue for Synapse Databases. |
| Schema Compare | Fixed error that caused duplication of comment headers when applying schema changes on stored procedure objects. |
| Schema Compare | Fixed issue that prevented schema compare issues when creating a new empty schema with a "DOMAIN\User" pattern. |
| Query Editor | Fixed bug that caused results to be lost upon saving query files. |
| Table Designer | Fixed a bug that caused creation of a new table when renaming an existing table. |
| Query Plan Viewer | Fixed missing index recommendation T-SQL syntax. |
| SQL Projects | Fixed bug in SQL Projects that led to extension not using output path when publishing a project. |
| SQL Projects | Fixed bug that caused .NET install to not be found when using the SQL Projects extension on Linux platforms. |
## Version 1.39.1
* Release date: August 30, 2022
* Release status: General Availability
### Bug fixes in 1.39.1
* Fixed bug that caused Database Trees in server connections to not expand in the Object Explorer.
## Version 1.39.0
* Release date: August 24, 2022
* Release status: General Availability
### What's new in 1.39.0
* New Features:
* Deployment Wizard - Azure Data Studio now supports SQL Server 2022 (Preview) in the Deployment Wizard for both local and container installation.
* Object Explorer - Added Ledger icons and scripting support to Object Explorer for Ledger objects.
* Dashboard - Added hexadecimal values to support color detection.
* Query Plan Viewer - Added the ability to copy text from cells in the Properties Pane of a query plan.
* Query Plan Viewer - Introduced a "find node" option in plan comparison to search for nodes in either the original or added plan.
* Table Designer - Now supports the ability to add included columns to a nonclustered index, and the ability to create filtered indexes.
* SQL Projects - Publish options were added to the Publish Dialog.
* Query History Extension - Added double-click support for query history to either open the query or immediately execute it, based on user configuration.
* Bug Fixes:
* Dashboard - Fixed an accessibility issue that prevented users from being able to access tooltip information using the keyboard.
* Voiceover - Fixed a bug that caused voiceover errors across the Dashboard, SQL Projects, SQL Import Wizard, and SQL Migration extensions.
* Schema Compare - Fixed a bug that caused the UI to jump back to the top of the options list after selecting/deselecting any option.
* Schema Compare - Fixed a bug involving Schema Compare (.SCMP) file incompatibility with Database Project information causing errors when reading and using information stored in this file type.
* Object Explorer - Fixed a bug that caused menu items in Object Explorer not to show up for non-English languages.
* Table Designer - Fixed a bug that caused the History Table name not to be consistent with the current table name when working with System-Versioned Tables.
* Table Designer - Fixed a bug in the Primary Key settings that caused the "Allow Nulls" option to be checked, but disabled, preventing users from changing this option.
* Query Editor - Fixed a bug that prevented the SQLCMD in T-SQL from working correctly, giving false errors when running scripts in Azure Data Studio.
* Query Editor - Fixed a bug that caused user-specified zoom settings to reset to default when selecting JSON values after query that returned JSON dataset was ran.
* SQL Projects - Fixed a bug that caused the "Generate Script" command to not work correctly when targeting a new Azure SQL Database.
* Notebooks - Fixed a bug that caused pasted images to disappear from editor after going out of edit mode.
* Notebooks - Fixed a bug that caused a console error message to appear after opening a markdown file.
* Notebooks - Fixed a bug that prevented markdown cell toolbar shortcuts from working after creating a new split view cell.
* Notebooks - Fixed a bug that caused text cells to be erroneously created in split view mode when the notebook default text edit mode was set to "Markdown".
## Version 1.38.0
* Release date: July 27, 2022
* Release status: General Availability
### What's new in 1.38.0
* New Features:
* VS Code merges to 1.62 - This release includes updates to VS Code from the three previous VS Code releases. Read [their release notes](https://code.visualstudio.com/updates/v1_62) to learn more.
* Table Designer - New column added to Table Designer for easier access to additional actions specific to individual rows.
* Query Plan Viewer - The Top Operations pane view now includes clickable links to operations in each of its rows to show the runtime statistics which can be used to evaluate estimated and actual rows when analyzing a plan.
* Query Plan Viewer - Improved UI on selected operation node in the Execution Plan.
* Query Plan Viewer - The keyboard command **CTRL + M** no longer executes queries. It now just enables or disables the actual execution plan creation when a query is executed.
* Query Plan Viewer - Plan labels are now updated in the Properties window when plans are compared and the orientation is toggled from horizontal to vertical, and back.
* Query Plan Viewer - Updates were made to the Command Palette. All execution plan commands are prefixed with "Execution Plan", so that they are easier to find and use.
* Query Plan Viewer - A collapse/expand functionality is now available at the operator level to allow users to hide or display sections of the plan during analysis.
* Query History - The Query History extension was refactored to be fully implemented in an extension. This makes the history view behave like all other extension views and also allows for searching and filtering in the view by selecting the view and typing in your search text.
* Bug Fixes:
* Table Designer - Error found in edit data tab when switching back to previously selected column when adding a new row. To fix this, editing the table is now disabled while new rows are being added and only reenabled afterwards.
* Query Editor - Fixed coloring issues for new T-SQL functions in the Query Editor.
* Query Plan Viewer - Fixed bug that caused custom zoom level spinner to allow values outside valid range.
* Dashboard - Fixed issue that caused incorrect displaying of insight widgets on the dashboard.
* Notebooks - Fixed issue where keyboard shortcuts and toolbar buttons were not working when first creating a Split View markdown cell.
* Notebooks - Fixed issue where cell languages were not being set correctly when opening an ADS .NET Interactive notebook in VS Code.
* Notebooks - Fixed issue where notebook was being opened as empty when exporting a SQL query as a notebook.
* Notebooks - Disables install and uninstall buttons in Manage Packages dialog while a package is being installed or uninstalled.
* Notebooks - Fixed issue where cell toolbar buttons were not refreshing when converting cell type.
* Notebooks - Fixed issue where notebook was not opening if a cell contains an unsupported output type.
* Schema Compare - Fixed issue where views and stored procedures were not correctly recognized by schema compare after applying changes.
## Version 1.37.0
* Release date: June 15, 2022
* Release status: General Availability
### What's new in this version
* New Features:
* Backup & Restore - Backup & Restore to URL is now available in preview for Azure SQL Managed Instances.
* Table Designer - Added API to support computed column capabilities on Table Designer.
* Table Designer - Can now specify where to add new columns and columns can now be re-arranged by mouse dragging.
* Table Designer - Table Designer is now supported by SQL Projects to add or modify database schema without need to be connected to a server instance.
* Query Plan Viewer - Smart plan comparison is now available. Can now compare execution plans and view detailed differences between plans in the Properties Table.
* Query Plan Viewer - Added toggle button to switch between estimated and actual execution plans.
* Query Plan Viewer - Query Plan now comes with improved precision to operator costs for larger plans.
* MongoDB Extension for Azure Cosmos DB (Preview) - This extension introduces support for access to Mongo resources for Cosmos DB.
* Bug Fixes:
* Table Designer - Fixed issue that caused app to not prompt user to save before closing.
* Table Designer - Fixed issue that returned empty data set upon attempting to edit the first cell of a new row.
* Table Designer - Improved resize to fit experience when zooming in on user interface as well as tab behavior issues.
* Query Plan Viewer - Fixed bug that caused custom zoom level spinner to allow values outside valid range.
* Schema Compare - Fixed issue with indexes not being added correctly when updating project from database.
* Notebooks - Fixed inconsistencies with notebook cell behavior and toolbars.
* Notebooks - Fixed issues with keyboard navigation.
## Version 1.36.2
* Release date: May 20, 2022
* Release status: General Availability
### What's new in this version
- Fix connectivity issue with PBI data source
- Fix query plan zoom and icon issues
- Issues fixed in this release https://github.com/microsoft/azuredatastudio/milestone/89?closed=1
## Version 1.36.1
* Release date: April 22, 2022
* Release status: General Availability
### What's new in this version
* April Hotfix addressing these issues https://github.com/microsoft/azuredatastudio/milestone/88?closed=1.
- General Availability of the Azure SQL Migration Extension for ADS
- Support for .NET Interactive Notebooks Extension
- New Table Designer Features including support for System Versioned, Graph and Memory Optomized Tables
- Query Plan Viewer Updates includign warning and parallelism icons, the option to disable tooltips and support for opening .sqlplan files
- Improvements in SQL Projects and Schema Compare
## Version 1.35.1
* Release date: March 17, 2022
* Release status: General Availability
### Hotfix release
- Fix for [Excel number format #18615](https://github.com/microsoft/azuredatastudio/issues/18615)
- Fix for [Geometry Data Type Returned as Unknown Charset in Results Grid #18630](https://github.com/microsoft/azuredatastudio/issues/18630)
## Version 1.35.0
* Release date: February 24, 2022
* Release status: General Availability
### What's new in this version
* New Features:
* Table Designer - Added functionality for creation and management of tables for SQL Servers. Built using DacFx framework
* Query Plan Viewer - Added functionality for users to view a graphic view of estimated and actual query plans without need for an extension
* Azure Arc Extension - Updated the Data Controller deployment wizard and the SQL Managed Instance - Azure Arc deployment wizard to reflect the deployment experience in Azure Portal
* Bug Fixes:
* Azure Arc Extension - SQL Managed Instance-Azure Arc is now fixed for both indirect connectivity mode and direct connectivity mode
* Notebooks - Support for keyboard navigation between cells to minimize mouse clicking
## Version 1.34.0
* Release date: December 15, 2021
* Release status: General Availability
### What's new in this version
* New Features:
* Added “Currently restoring backup file” in the migration progress details page of Azure SQL Migration extension when backup files location is Azure Storage blob container
* Enhancements to diagnostics in Azure SQL Migration extension
* Support for project build with .NET 6 in SQL Database Projects extension
* Publish to container in SQL Database Projects extension
* Undo and redo support for notebook cell-level operations
* Extension Updates:
* Azure SQL Migration
* Langpacks
* SQL Database Projects
* Bug Fixes:
* Fix for multiple database migrations when using network share as backup files location in Azure SQL Migration extension
* Fix for multiple database migrations when using blob storage containers as backup files location in Azure SQL Migration extension
* Fix to pre-populate target database names in the migration wizard in Azure SQL Migration extension
* Fix to column sorting in grids where the presence of null values could lead to unexpected results
* Fix for Python upgrades when two or more notebooks were open
## Version 1.33.1
* Release date: Nov 4, 2021
* Release status: General Availability
### Hotfix release
- Fix for [#16535 Unable to See Saved Connections in Restricted Mode](https://github.com/microsoft/azuredatastudio/issues/17535)
- Fix for [#17579 Can't type in Notebook code cell after editing text cell](https://github.com/microsoft/azuredatastudio/issues/17579)
## Version 1.33.0
* Release date: October 27, 2021
* Release status: General Availability
### What's new in this version
* New Notebook Features:
* Notebook Views
* Split cell support
* Keyboard shortcuts for Markdown Toolbar Cells
* Ctrl/Cmd + B = Bold Text
* Ctrl/Cmd + I = Italicize Text
* Ctrl/Cmd + U = Underline Text
* Ctrl/Cmd + Shift + K = Add Code Block
* Ctrl/Cmd + Shift + H = Highlight Text
* Book improvements
* Add a new section
* Drag and Drop
* Extension Updates:
* Import
* Langpacks
* Schema Compare
* Sql Database Projects
* Bug Fixes
* Notebook linking improvements
* Horizontal Scrollbar improvement (when word wrap is off in MD Splitview / MD mode) in Notebooks
* Vertical Scrollbar improvement for MD Splitview in Notebooks
## Version 1.32.0
* Release date: August 18, 2021
* Release status: General Availability
* Extension Updates:
* Arc/Az CLI extensions - Azure Arc extension now uses Azure CLI instead of Azure Data CLI for deploying and interacting with Azure Arc
instances
* Arc/Az CLI extensions - Azure Arc extension now uses Azure CLI instead of Azure Data CLI for deploying and interacting with Azure Arc
instances
* Langpacks
* SQL Database Projects
* Azure Monitor
@@ -14,7 +599,7 @@
## Version 1.31.1
* Release date: July 29, 2021
* Release status: General Availability
## Hotfix Release
### Hotfix Release
- Fix for [#16436 Database Connection Toolbar Missing](https://github.com/microsoft/azuredatastudio/issues/16436)
## Version 1.31.0
@@ -305,7 +890,7 @@
* GA status for Big Data Cluster/SQL 2019 features [#8269](https://github.com/microsoft/azuredatastudio/issues/8269)
* Resolved [bugs and issues](https://github.com/microsoft/azuredatastudio/milestone/44?closed=1).
## Contributions and "thank you"
### Contributions and "thank you"
We would like to thank all our users who raised issues, and in particular the following users who helped contribute fixes:
## Version 1.13.1
@@ -319,7 +904,7 @@ We would like to thank all our users who raised issues, and in particular the fo
* General Availability release for Schema Compare and DACPAC extensions
* Resolved [bugs and issues](https://github.com/microsoft/azuredatastudio/milestone/43?closed=1).
## Contributions and "thank you"
### Contributions and "thank you"
We would like to thank all our users who raised issues, and in particular the following users who helped contribute fixes:
* aspnerd for `Use selected DB for import wizard schema list` [#7878](https://github.com/microsoft/azuredatastudio/pull/7878)
@@ -337,7 +922,7 @@ We would like to thank all our users who raised issues, and in particular the fo
* Release date: October 2, 2019
* Release status: General Availability
## What's new in this version
### What's new in this version
* Announcing the Query History panel
* Improved Query Results Grid copy selection support
* TempDB page added to Server Reports extension
@@ -348,14 +933,14 @@ We would like to thank all our users who raised issues, and in particular the fo
* Release date: September 10, 2019
* Release status: General Availability
## What's new in this version
### What's new in this version
* Resolved [bugs and issues](https://github.com/microsoft/azuredatastudio/milestone/41?closed=1).
## Version 1.10.0
* Release date: August 14, 2019
* Release status: General Availability
## What's new in this version
### What's new in this version
* [SandDance](https://github.com/microsoft/SandDance) integration — A new way to interact with data. Download the extension [here](https://docs.microsoft.com/sql/azure-data-studio/sanddance-extension)
* Notebook improvements
* Better loading performance
@@ -371,7 +956,7 @@ We would like to thank all our users who raised issues, and in particular the fo
* Release date: July 11, 2019
* Release status: General Availability
## What's new in this version
### What's new in this version
* Release of [SentryOne Plan Explorer Extension](https://www.sentryone.com/products/sentryone-plan-explorer-extension-azure-data-studio)
* **Schema Compare**
* Schema Compare File Support (.SCMP)
@@ -397,7 +982,7 @@ We would like to thank all our users who raised issues, and in particular the fo
* Release date: June 6, 2019
* Release status: General Availability
## What's new in this version
### What's new in this version
* Initial release of the Database Admin Tool Extensions for Windows *Preview* extension
* Initial release of the Central Management Servers extension
* **Schema Compare**
@@ -418,24 +1003,24 @@ We would like to thank all our users who raised issues, and in particular the fo
* Release date: May 8, 2019
* Release status: General Availability
## What's new in this version
### What's new in this version
* Announcing Schema Compare *Preview* extension
* Tasks Panel UX improvement
* Announcing new Welcome page
* Resolved [bugs and issues](https://github.com/microsoft/azuredatastudio/milestone/31?closed=1).
## Contributions and "thank you"
### Contributions and "thank you"
We would like to thank all our users who raised issues.
## Version 1.6.0
* Release date: April 18, 2019
* Release status: General Availability
## What's new in this version
### What's new in this version
* Align with latest VS Code editor platform (currently 1.33.1)
* Resolved [bugs and issues](https://github.com/Microsoft/azuredatastudio/milestone/26?closed=1).
## Contributions and "thank you"
### Contributions and "thank you"
We would like to thank all our users who raised issues, and in particular the following users who helped contribute fixes:
* yamatoya for `fix the format (#4899)`
@@ -444,13 +1029,13 @@ We would like to thank all our users who raised issues, and in particular the fo
* Release date: March 18, 2019
* Release status: General Availability
## What's new in this version
### What's new in this version
* Announcing T-SQL Notebooks
* Announcing PostgreSQL extension
* Announcing SQL Server Dacpac extension
* Resolved [bugs and issues](https://github.com/Microsoft/azuredatastudio/milestone/25?closed=1).
## Contributions and "thank you"
### Contributions and "thank you"
We would like to thank all our users who raised issues, and in particular the following users who helped contribute fixes:
* GeoffYoung for `Fix sqlDropColumn description #4422`
@@ -459,7 +1044,7 @@ We would like to thank all our users who raised issues, and in particular the fo
* Release date: February 13, 2019
* Release status: General Availability
## What's new in this version
### What's new in this version
* Added **Admin pack for SQL Server** extension pack to make it easier to install SQL Server admin-related extensions. This includes:
* [SQL Server Agent](https://docs.microsoft.com/en-us/sql/azure-data-studio/sql-server-agent-extension?view=sql-server-2017)
* [SQL Server Profiler](https://docs.microsoft.com/en-us/sql/azure-data-studio/sql-server-profiler-extension?view=sql-server-2017)
@@ -473,7 +1058,7 @@ We would like to thank all our users who raised issues, and in particular the fo
* Results streaming enabled by default for long running queries
* Resolved [bugs and issues](https://github.com/Microsoft/azuredatastudio/milestone/23?closed=1).
## Contributions and "thank you"
### Contributions and "thank you"
We would like to thank all our users who raised issues, and in particular the following users who helped contribute fixes:
* AlexFsmn for `Added context menu for DBs in explorer view to backup & restore db. #2277`
@@ -484,7 +1069,7 @@ We would like to thank all our users who raised issues, and in particular the fo
* Release date: January 9, 2019
* Release status: General Availability
## What's new in this version
### What's new in this version
*#13 Feature Request: Azure Active Directory Authentication
*#1040 Stream initial query results as they become available
*#3298Сan't add an azure account.
@@ -494,7 +1079,7 @@ We would like to thank all our users who raised issues, and in particular the fo
* Updates to [SQL Server 2019 extension](https://docs.microsoft.com/sql/azure-data-studio/sql-server-2019-extension?view=sql-server-ver15)
* **sp_executesql to SQL** and **New Database** extensions
## Contributions and "thank you"
### Contributions and "thank you"
We would like to thank all our users who raised issues, and in particular the following users who helped contribute fixes:
* Tarig0 for `Add Routine_Type to CreateStoredProc fixes #3257 (#3286)`
@@ -506,7 +1091,7 @@ We would like to thank all our users who raised issues, and in particular the fo
* Release date: November 6, 2018
* Release status: General Availability
## What's new in this version
### What's new in this version
* Update to the SQL Server 2019 Preview extension
* Introducing Paste the Plan extension
* Introducing High Color queries extension, including SSMS editor theme
@@ -515,7 +1100,7 @@ We would like to thank all our users who raised issues, and in particular the fo
* Upgrade SQL Tools Service to .Net Core 2.2 Preview 3 (for eventual AAD support)
* Fix customer reported GitHub issues
## Contributions and "thank you"
### Contributions and "thank you"
We would like to thank all our users who raised issues, and in particular the following users who helped contribute fixes:
* rdaniels6813 for `Add query plan theme support #3031`
@@ -529,12 +1114,12 @@ We would like to thank all our users who raised issues, and in particular the fo
* Release date: October 18, 2018
* Release status: General Availability
## What's new in this version
### What's new in this version
* Introducing the Azure Resource Explorer to browse Azure SQL Databases
* Improve Object Explorer and Query Editor connectivity robustness
* SQL Server 2019 and SQL Agent extension improvements
## Contributions and "thank you"
### Contributions and "thank you"
We would like to thank all our users who raised issues, and in particular the following users who helped contribute fixes:
* philoushka for `center the icon #2760`
@@ -546,7 +1131,7 @@ We would like to thank all our users who raised issues, and in particular the fo
* Release date: September 24, 2018
* Release status: General Availability
## What's new in this version
### What's new in this version
* Announcing the SQL Server 2019 Preview extension.
* Support for SQL Server 2019 preview features including Big Data Cluster support.
* Azure Data Studio Notebooks
@@ -557,7 +1142,7 @@ We would like to thank all our users who raised issues, and in particular the fo
* Accessibility improvements for screen reader, keyboard navigation and high-contrast.
* Added Connection name option to provide an alternative display name in the Servers viewlet.
## Contributions and "thank you"
### Contributions and "thank you"
We would like to thank all our users who raised issues, and in particular the following users who helped contribute fixes:
* AlexFsmn `Feature: Ability to add connection name #2332`
@@ -567,7 +1152,7 @@ We would like to thank all our users who raised issues, and in particular the fo
* Release date: August 30, 2018
* Release status: Public Preview
## What's new in this version
### What's new in this version
* Announcing the SQL Server Import Extension
* SQL Server Profiler Session management
* SQL Server Agent improvements
@@ -575,7 +1160,7 @@ We would like to thank all our users who raised issues, and in particular the fo
* Quality of Life improvements: Connection strings
* Fix many customer reported GitHub issues
## Contributions and "thank you"
### Contributions and "thank you"
We would like to thank all our users who raised issues, and in particular the following users who helped contribute fixes:
* SebastianPfliegel `Added more saveAsCsv options #2099`
@@ -593,7 +1178,7 @@ We would like to thank all our users who raised issues, and in particular the fo
* Release date: July 19, 2018
* Release status: Public Preview
## What's new in this version
### What's new in this version
* SQL Server Agent for Azure Data Studio extension improvements
* Added view of Alerts, Operators, and Proxies and icons on left pane
* Added dialogs for New Job, New Job Step, New Alert, and New Operator
@@ -614,7 +1199,7 @@ We would like to thank all our users who raised issues, and in particular the fo
* Release date: June 20, 2018
* Release status: Public Preview
## What's new in this version
### What's new in this version
* **SQL Server Profiler for Azure Data Studio *Preview*** extension initial release
* The new **SQL Data Warehouse** extension includes rich customizable dashboard widgets surfacing insights to your data warehouse. This unlocks key scenarios around managing and tuning your data warehouse to ensure it is optimized for consistent performance.
* **Edit Data "Filtering and Sorting"** support
@@ -627,7 +1212,7 @@ We would like to thank all our users who raised issues, and in particular the fo
* Release date: May 7, 2018
* Release status: Public Preview
## What's new in this version
### What's new in this version
The May release is focused on stabilization and bug fixes leading up to the Build conference. This build contains the following highlights.
* Announcing **Redgate SQL Search** extension available in Extension Manager
@@ -642,7 +1227,7 @@ The May release is focused on stabilization and bug fixes leading up to the Buil
* Release date: April 25, 2018
* Release status: Public Preview
## What's new in this version
### What's new in this version
The April Public Preview release contains some of the following highlights.
* Improvements to SQL Agent *Preview* extension
@@ -657,7 +1242,7 @@ The April Public Preview release contains some of the following highlights.
* Release date: March 28, 2017
* Release status: Public Preview
## What's new in this version
### What's new in this version
The March Public Preview release enables some key aspects of the Azure Data Studio
extensibility story. Here are some highlights in this release.
@@ -672,14 +1257,14 @@ extensibility story. Here are some highlights in this release.
* Release date: February 16, 2017
* Release status: Public Preview Hotfix 1
## What's new in this version
### What's new in this version
* Bug fix for `#717 Selecting partial query and hitting Cmd or Ctrl+C opens terminal with Error message`
## Version 0.26.6
* Release date: February 15, 2017
* Release status: Public Preview
## What's new in this version
### What's new in this version
The February release fixes several important customer reported issues, as well as various feature improvements. We've also introduced auto-update support in February which will simplify keeping updated with the lastest changes.
Here's some of the highlights in the February release.
@@ -699,7 +1284,7 @@ Here's some of the highlights in the February release.
* VS Code Editor 1.19 integration
* Update JustinPealing/html-query-plan component to pick-up several Query Plan viewer improvements
## Contributions and "thank you"
### Contributions and "thank you"
We would like to thank all our users who raised issues, and in particular the following users who helped contribute fixes:
* SebastianPfliegel for `Add cursor snippet (#475)`
@@ -710,7 +1295,7 @@ We would like to thank all our users who raised issues, and in particular the fo
* Release date: January 17, 2017
* Release status: Public Preview
## What's new in this version
### What's new in this version
The January release focuses on addressing a few of the top upvoted feature suggestions, as well as fixing high-priority bugs. This release period coincides with holiday vacations, so the churn in this release is
relatively scoped.
@@ -725,7 +1310,7 @@ Here's some of the highlights in the January release.
* Fix missing Azure Account branding icon
* Change "Server name" to "Server" in Connection Dialog
## Contributions and "thank you"
### Contributions and "thank you"
We would like to thank all our users who raised issues, and in particular the following users who helped contribute fixes:
* alextercete for `Fix "No extension gallery service configured" error (#427)`
@@ -735,7 +1320,7 @@ We would like to thank all our users who raised issues, and in particular the fo
* Release date: December 19, 2017
* Release status: Public Preview
## What's new in this version
### What's new in this version
* Azure Integration with Create Firewall Rule
* Windows Setup, Linux DEB and Linux RPM installation packages
* Manage Dashboard visual layout editor
@@ -759,7 +1344,7 @@ We would like to thank all our users who raised issues, and in particular the fo
* Allow expanding databases not in certain non-Online states
* Connection Dialog selects most common default authentication method based on platform
## Contributions and "thank you"
### Contributions and "thank you"
We would like to thank all our users who raised issues, and in particular the following users who helped contribute fixes:
* mwiedemeyer for `Fix #58: Default sort order for DB size widget (#111)`
* AlexTroshkin for `Show disconnect in context menu only when connectionProfile connected (#150)`
The software may collect information about you and your use of the software and send it to Microsoft. Microsoft may use this information to provide services and improve our products and services. You may turn off the telemetry as described in the repository. There are also some features in the software that may enable you and Microsoft to collect data from users of your applications. If you use these features, you must comply with applicable law, including providing appropriate notices to users of your applications together with a copy of Microsoft's privacy statement. Our privacy statement is located at <https://go.microsoft.com/fwlink/?LinkID=824704>. You can learn more about data collection and use in the help documentation and our privacy statement. Your use of the software operates as your consent to these practices.
[](https://gitter.im/Microsoft/sqlopsstudio?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
Azure Data Studio is a data management tool that enables you to work with SQL Server, Azure SQL DB and SQL DW from Windows, macOS and Linux.
Azure Data Studio is a data management and development tool with connectivity to popular cloud and on-premises databases. Azure Data Studio supports Windows, macOS, and Linux, with immediate capability to connect to Azure SQL and SQL Server. Browse the [extension library](wiki/List-of-Extensions) for additional database support options including MySQL, PostreSQL, and MongoDB.
## **Download the latest Azure Data Studio release**
Please visit our [download page](https://aka.ms/getazuredatastudio) for more specific installation instructions.
Check out the [change log](https://github.com/Microsoft/azuredatastudio/blob/main/CHANGELOG.md) or [release notes](https://learn.microsoft.com/sql/azure-data-studio/release-notes-azure-data-studio) for additional details of what's in the each release.
The [Azure Data Studio documentation](https://learn.microsoft.com/sql/azure-data-studio) includes complete details on getting started, connection quickstarts, and feature tutorials.
## **Feature Highlights**
@@ -64,8 +94,12 @@ This project has adopted the [Microsoft Open Source Code of Conduct](https://ope
## Localization
Azure Data Studio is localized into 10 languages: French, Italian, German, Spanish, Simplified Chinese, Traditional Chinese, Japanese, Korean, Russian, and Portuguese (Brazil). The language packs are available in the Extension Manager marketplace. Simply, search for the specific language using the extension marketplace and install. Once you install the selected language, Azure Data Studio will prompt you to restart with the new language.
## Telemetry
Azure Data Studio collects telemetry data, which is used to help understand how to improve the product. For example, this usage data helps to debug issues, such as slow start-up times, and to prioritize new features. While we appreciate the insights this data provides, we also know that not everyone wants to send usage data and you can disable telemetry as described in the [disable telemetry reporting](https://aka.ms/ads-disable-telemetry) documentation.
## Privacy Statement
The [Microsoft Enterprise and Developer Privacy Statement](https://privacy.microsoft.com/privacystatement) describes the privacy statement of this software.
The [Microsoft Privacy Statement](https://go.microsoft.com/fwlink/?LinkID=824704) describes the privacy statement of this software.
## Contributions and "Thank You"
We would like to thank all our users who raised issues, and in particular the following users who helped contribute fixes:
@@ -130,11 +164,3 @@ And of course, we'd like to thank the authors of all upstream dependencies. Ple
Copyright (c) Microsoft Corporation. All rights reserved.
Some files were not shown because too many files have changed in this diff
Show More
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.