* Added WIP table designer input change
* added test details to tableDesigner
* added connection name to details
* wip restoration of nonDefaultOptions
* added Verbosity todo for getTitle
* added updated info
* added fix for mainController
* fixed assignment
* added update to description
* restore title parts to old names
* added clarifying message
* added title to dashboard and profilerinput
* added advanced titles for edit data and query editor input
* added changes based on feedback
* added additional description
* Added some changes to tableDesigner input
* fixed comments
* removed erroneous import
* added updated titles and tooltips
* added small corrections
* added profiler XEL title feature
* added session name to profiler input tooltip
* added small tooltip rework
* remove unavailable session name
* added update to config.json
* add schema migration
* fix table selection issue
* fix table validation
* data only wont show schema info grids
* address comments
* update schema migration helper banner
* fix undefined
* refactor
* endedOn is - when not started
* fix toString
* refactor
* auto referesh dashboardtab and migrationtab
* add migration type in dashboard
* fix saving issue in page 0 and page 1
* fix compile issue
* fix save and close in page 3
* refactor
* fix save
* fix save
* fix save
* dont load location twice
* fix target type undefined issue
* set MI as default
* fix cannot load in step 3
* integrate assessment with schema
---------
Co-authored-by: Siyang Yao <siyao@microsoft.com>
* try deleting compilation downput after it's been extracted
* consolidate into same step as extraction
* Update build/azure-pipelines/linux/sql-product-build-linux.yml
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
---------
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Bump Electron to 22.3.24
* Bump distro
* Bump to release version in main.ts
* revert bump in this branch
* Bump to distro to fix conflict
* bump to releaseVersion in main
* changed distro to one in branch
* Revert "changed distro to one in branch"
This reverts commit 60213995a1fd2b9b548790c090c5a57ea363d278.
* Revert "Bump to distro to fix conflict"
This reverts commit e5119783f835a70fb56d52b8bc2919a311607f6c.
* Bump to distro (new)
---------
Co-authored-by: Alex Ma <alma1@microsoft.com>
* Initial update to german vscode
* more cleanup for vscode git german.
* added working alias replacer, need to add all string entities
* added aliased bundle strings
* added extension files, need to update package and readme
* added update to changelog, and restored vscode extensions
* added comments
* added doughnut chart component
* Changing chart to doughnutChart
* reverting to genreic chart component
* adding more chart supoort
* fix minor errors
* resolve some PR comments
* native chartjs, keyboard navigation and chart options
* fix build errors
* fix chart.js/auto error
* resolve PR comments
* modify chartdataset API
* Refactoring (#24327)
* working - displaying chart data with convert
* working - introduced typed properties
* working, added BarChartConfiguration to type param
* removed ChartProperties type param
* Adding doughnut support
* Correcting number vs. point issue
* including the right changes this time
* commenting out no-longer-used labels prop
* remove hardcoded canvasID, enabled Scatterplot config
* Moved graph testing to sample extension
* Reorganizing types; adding test back to assessment dialog
* Adding example for bubble chart
* Polar area working
* cleanup
* adding draw when options isn't set
* Moving chart example configs to other file
* some cleanup
* added some docstrings
* add multiple datasets to test scatter plot
* update scatter plot example in sample
* Adding height/width support
* swapping to `as` cast
* title working
* Settling chart title and legend display
* Adding comments
* updating data working
* Updating samples
* Typo in comment
* Reverting changes made for development
* Elaborating on color in docstrings
* Separating Data and Options in component payloads
* Removing chartId as an exposed property
* Changing chartType property to TChartType
* Fleshing out types file comments
* fixing scoping of chart component properties; renaming chart canvas ID prop
* correct internal chart options typing
* removing commented-out code
* removing unused ChartClickEvent type until data selection eventing is implemented
* renaming function
* deleted commented-out code
* Adding options setters that went missing after splitting Config to Data + Options
* adding type predicates for data conversion
* Adding back type setting (dropped when chart type conversion moved)
* Narrowing type for 'type'
* Fixing typos in docstring
---------
Co-authored-by: Deepak Saini <deepaksaini@microsoft.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Aasim Khan <aaskhan@microsoft.com>
Co-authored-by: Deepak Saini <deepak.saini1996@gmail.com>
* fix for File size input in DB properties can be decremented into the negative #24307
* Some DB Scoped Config options are sentence cased #24196
* cannot add a file with filestream data filegroup type #24359
* DB Scoped Secondary values aren't updated when hidden #24197
* DB Scoped Config shows secondary values for non-secondary options #24192
* Query store capture policy section is enabling on non-custom capture mode #24371
* queryStore WaitStatistics options should be a dropdown #24372
* add return type for copy results from STS
* fix test error
* change Result type to CopyResultsRequestResult
* remove async
* bump data protocol client
* bump dataprotocol client version
* bump version in yarn.lock
* add async back
* Send server contextualization to Copilot extension
* Keep context in editor input
* Remove unnecessary server context and extension service
* Send context when connecting from open editor
* Remove contextualization complete event
* Contextualize editor after connection success
* Minor clean up
* Remove nested then and use async/await
* Create helper function
* Remove unneeded async and add comment
* Encapsulate all context logic in service
* Use void operator to fix floating promise
* Correct return comment
* initial changes for loadin dsc table with real values from smo
* Displaying diff columns for DSC for diff sql server
* checkbox maiants the selection
* elevate option fails to load correct value when set to when_supported option
* all working till maxdop, todo pause option, save
* commented MAXDOP changes, as it is causing issues
* primary,sec,checkbox working as expected, TODO:MaxDop etc options,saving,tests
* Undo MAXDOP commented code
* refactored with service data
* column header width adjustments
* Maxdop and pause resume options completed, apply button is failing now
* Removed option names from loc and using Id instead as names may change in future like in doc
* Apply button fixed
* refactored to reduce table reload
* Ledger digest completed
* refactor done: maxdop secondary shows wrong data from pause_resume
* refactor more: all working but table focus disturbs on update table
* adds conditions for unsupported dsc to <2016 server
* maxdop secondary checkbox fix
* rows still loses focus after value change due to update table row data
* Fixed updating secondary dropdown value
* reusing the private method and removed the duplicated codes
* initial commit - fullText and owner need revision
* Enter key in input type allows the change to update the table data, reduces the live update issues
* Setting focus to the current row
* loading data, need stylings-increase col length, etc
* using the existed setTableData method
* Adding new file dialog
* creating addFile, but not displaying in table, issue with appendData
* Adding row to the table, options are getting from STS
* all working except InPercent value
* code review comment updates
* Input type checkbox update table additional validation
* all except path
* fixing the input type focus and reverting the enterKeyPress logic
* browse path is created, need stylings,refactor,filestream selection and add
* fixing the flickering issue with data refresh
* new file options toggle and grid display string updates
* moving code inline and using actual component
* cleanup
* Add file saving is done, except one styling issue with autogrowth section
* add,remove working, need to edit file
* add, edit, remove - all working, need css fixes and -1 fix
* addressing code review comments
* adding local changes adn fixing for edit file
* adjusting css
* addressing code review comment for using loc var instead of duplicated line of code to get the rowinfo
* all fixed, need testing and refactor
* vBump STS and fixing required field causing the apply button not enable for other options on main branch
* fixing autogrowth radio buttons change updates
* all working except some css
* disabled size for filestream
* fixing filegroups and filetypes scnearios, added filename validation for newfile, todo:editingNew file
* added max and min values to the inputs
* editing filename validation completed, all done exccept CSS
* all fixed except scroll bar
* edit db file header, filename enable issue fix
* PR comment supporting updates for STS
* initial commit
* min updates
* loading data into table.. adding rows
* modfying addButtonsForTable method and reusing it for edit button
* add empty row/remove done, edit name and other columns required and save with tests
* All working except new name validation
* adding validation
* code review comment updates
* Dialogbase addbuttons to table refactored
* more typo fixes
* all working except 'Remove' revist logic and delete correct row
* removing fulltext index prop
* adding defualt conditions to the columns checkboxes
* service fix
* using path.join instead of hardcoded separators
* updating files is updating filegroups tabs, removing fg to file update required
* fixed toggle remove button for tab;es
* filegroup refactor
* update filegroups and files on new fg name
* final commit changes
* code review updates
* vBump STS to 4.9.0.26
* Initial changes
* Add time, resource and chart component to config dialog
* Add appropriate components of Configuration to Overall Resource Consumption Report and Top Resource Consuming Queries
* Fix alignment and sizes of components
* Address comments. Add group containers for individual components
* Fix alignment
* Add extra label and address comments
* Address comments. Fix sequence of component addition
* Update function definition to take in config information, instead of boolean to accomodate all future reports. And update doc comment
* initial changes for loadin dsc table with real values from smo
* Displaying diff columns for DSC for diff sql server
* checkbox maiants the selection
* elevate option fails to load correct value when set to when_supported option
* all working till maxdop, todo pause option, save
* commented MAXDOP changes, as it is causing issues
* primary,sec,checkbox working as expected, TODO:MaxDop etc options,saving,tests
* Undo MAXDOP commented code
* refactored with service data
* column header width adjustments
* Maxdop and pause resume options completed, apply button is failing now
* Removed option names from loc and using Id instead as names may change in future like in doc
* Apply button fixed
* refactored to reduce table reload
* Ledger digest completed
* refactor done: maxdop secondary shows wrong data from pause_resume
* refactor more: all working but table focus disturbs on update table
* adds conditions for unsupported dsc to <2016 server
* maxdop secondary checkbox fix
* rows still loses focus after value change due to update table row data
* Fixed updating secondary dropdown value
* reusing the private method and removed the duplicated codes
* initial commit - fullText and owner need revision
* Enter key in input type allows the change to update the table data, reduces the live update issues
* Setting focus to the current row
* loading data, need stylings-increase col length, etc
* using the existed setTableData method
* Adding new file dialog
* creating addFile, but not displaying in table, issue with appendData
* Adding row to the table, options are getting from STS
* all working except InPercent value
* code review comment updates
* Input type checkbox update table additional validation
* all except path
* fixing the input type focus and reverting the enterKeyPress logic
* browse path is created, need stylings,refactor,filestream selection and add
* fixing the flickering issue with data refresh
* new file options toggle and grid display string updates
* moving code inline and using actual component
* cleanup
* Add file saving is done, except one styling issue with autogrowth section
* add,remove working, need to edit file
* add, edit, remove - all working, need css fixes and -1 fix
* addressing code review comments
* adding local changes adn fixing for edit file
* adjusting css
* addressing code review comment for using loc var instead of duplicated line of code to get the rowinfo
* all fixed, need testing and refactor
* vBump STS and fixing required field causing the apply button not enable for other options on main branch
* fixing autogrowth radio buttons change updates
* all working except some css
* disabled size for filestream
* fixing filegroups and filetypes scnearios, added filename validation for newfile, todo:editingNew file
* added max and min values to the inputs
* editing filename validation completed, all done exccept CSS
* all fixed except scroll bar
* edit db file header, filename enable issue fix
* PR comment supporting updates for STS
* min updates
* modfying addButtonsForTable method and reusing it for edit button
* code review comment updates
* Dialogbase addbuttons to table refactored
* more typo fixes
* removing fulltext index prop
* service fix
* using path.join instead of hardcoded separators
* final commit changes
* Update STS and add new platform
* Update vsix version
* Create Fabric DW project from database
* Fix target platform name
* Address comments
* Revert projects version to 1.3.0
* Update STS to 4.9.0.22
* PR comment
* Juno: check in to lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20230821154016684.
* fix for duplicate IDs
---------
Co-authored-by: Alex Ma <alma1@microsoft.com>
* Juno: check in to lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20230820154006840.
* added fix to spanish files
* WIP small fixes for italian
* fix for italian files
* fix for korean
* Final fix for now
* one last cleanup patch
* fix for space
* small fix to prev
* removed another dupe string
---------
Co-authored-by: Alex Ma <alma1@microsoft.com>
* Boilerplate for new metadata API endpoint
* Register all server metadata provider
* Fully registers data provider
* Registers metadata provider
* Instantiate metadata service
* Generates server metadata when connection is established
* Allow queryEditorInput to get server metadata
* Minor clean up
* Renames metadata provider and request endpoint
* Corrects documentation block
* Integrates get server metadata request endpoint
* Adjusts GetServerMetadataResult scripts type
* Add back Cargo.toml file
* Fix SQL hygiene error
* reflect changes made in in STS for table metadata
* Adds feature toggle to serverMetadataService
* Places toggle before request to get create scripts
* Fix build check issues
* Minor review changes
* Improves contextualization setting label
* Generalize contextualization service names
* Additional code review changes
* Update extensions/mssql/src/contracts.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Update src/sql/azdata.proposed.d.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Code reivew changes
* Capitalize c in contextualization
* Additional review changes
* Update provider type
* Simplify type and method names
* Unregister MSSQL ServerContextualization provider
---------
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* initial changes for loadin dsc table with real values from smo
* Displaying diff columns for DSC for diff sql server
* checkbox maiants the selection
* elevate option fails to load correct value when set to when_supported option
* all working till maxdop, todo pause option, save
* commented MAXDOP changes, as it is causing issues
* primary,sec,checkbox working as expected, TODO:MaxDop etc options,saving,tests
* Undo MAXDOP commented code
* refactored with service data
* column header width adjustments
* Maxdop and pause resume options completed, apply button is failing now
* Removed option names from loc and using Id instead as names may change in future like in doc
* Apply button fixed
* refactored to reduce table reload
* Ledger digest completed
* refactor done: maxdop secondary shows wrong data from pause_resume
* refactor more: all working but table focus disturbs on update table
* adds conditions for unsupported dsc to <2016 server
* maxdop secondary checkbox fix
* rows still loses focus after value change due to update table row data
* Fixed updating secondary dropdown value
* reusing the private method and removed the duplicated codes
* Enter key in input type allows the change to update the table data, reduces the live update issues
* Setting focus to the current row
* using the existed setTableData method
* code review comment updates
* Input type checkbox update table additional validation
* fixing the input type focus and reverting the enterKeyPress logic
* fixing the flickering issue with data refresh
* moving code inline and using actual component
* cleanup
* addressing code review comments
* addressing code review comment for using loc var instead of duplicated line of code to get the rowinfo
* vBump STS and fixing required field causing the apply button not enable for other options on main branch
* added changes to gulpfile and locfunc along with updated lcls
* Added Portuguese updated lcls
* added last batch of renamed lcl files
* added renamed XLF files
* Also fixed an issue where a manually edited text field doesn't get updated when selecting the same dropdown value from before the manual edit.
---------
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Horizontal splitview sorta working
* remove the old element
* support getting size from model view container
* cleanup
* make splitViewHeight optional
* Update src/sql/azdata.proposed.d.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* fix test
---------
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Add limit on the file size that can be opened with Open XEL feature
* Add limit on the file size that can be opened and post a notification for large files
* Update wording
* Use FileService interface instead of fs to fix layering rules
* Making IsLedger Property to Read-only
* refactor
* Update extensions/mssql/src/objectManagement/ui/databaseDialog.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
---------
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Makes use of xvfb to run unit tests
* Restore test script as before, but with xvfb
* Use same command that worked in CLI
* Add --build CLI arg
* Add coverage arg
* Revert change to core unit test script
* Reset core unit tests script in linux pipeline
* Revert "Skip flaky vscode test suites (#23535)"
This reverts commit 882bdb3aab.
* Revert "Disable failing vscode test suite (#23539)"
This reverts commit 562a0ce595.
* Revert "Disable vscode remote configuration suite (#23545)"
This reverts commit 40fa1cebd8.
* Revert "Disable editor resolver service test suite (#23550)"
This reverts commit cd68dca844.
* Revert "Disable upstream extension enablement suite (#23557)"
This reverts commit faf3c6976e.
* Revert "Skip a few more suites impacted by xterm issue (#23589)"
This reverts commit 1662cedf17.
# Conflicts:
# src/vs/workbench/contrib/experiments/test/electron-sandbox/experimentService.test.ts
* Use DOM Renderer for tests
* Remove extra whitespace
* Update comment
* Initial set of changes for opening XEL files in ADS
* Code cleanup and update STS version
* Fix runtime errors
* Address comments
* Address comments and update Start button to be disabled for file session
* Code cleanup
* Initial commit for adding a basic general tab for the database properties
* Refactoring for dialog inputs
* removed properties nodeType and using database node and additional cleanup, diabling the functionality.
* Changes according to STS data fetch
* Reuse database Dialog
* Undo contract file change
* more refactoring
* fetched scrollbar fix into this PR
* Tabbed panel is being used for horizontal tabs
* stying fix for general tab button
* final commit for today :)
* Updates according to STS changes
* missed updates
* Refactored updates
* moved options as discussed and added collapsible sections... need to fix scroll bar
* Fixing the horizontal scroll bar of tabbedpanel
* initial updates
* need to fix the error!
* rror fixed and options are loading with sample values
* need to load real values for all felds and map values to dropdown options
* Dd loading correctly, need to add validation to recovery field and save options back
* refactor
* removing nullable property
* All changes done except recoveryTime validation
* Refactoring
* all values are saving as expected, isDirty flag is fixed. Todo: recovery validation and tests
* added general section for the options tab
* modifying pageVerify and userAccess to string array
* updates to general section of options tb
* disabling couple of general properties for MI
* Adding server edition conditions and toggling the UI options
* adding numeric validation to the recovey time
* Removing serveInfo logic and using the unsupported options approach from STS
* addressing comments and little code refactor
* changes with nullOrUndefined helper method
* replacing dropdowns with checkboxes
* adding unit test for helper method
* removed commented sample code and added comments
* initial changes for making a QDS report with placeholders
* Add icon for configure button
* Add another example report to show layout
* move files
* add placeholder names to components and cleanup toolbar
* cleanup
* switch to createViews() instead of createTop and BottomSections()
* add QueryStoreView class for the different components in a report
* cleanup
* add more comments
* fix yarn not running for query store extension folder
* add missing break
* change one more view to container
* Reenable extension unit tests
* Turn off Notebook Trust test cases
* Skip another failing notebook trust test
* Limit scope of disabled tests to only folder scenarios
* log when an editor action doesn't run because of enablement
* notebooks create/dispose editors. this means controllers must be created eagerly (😢) and that notebooks need a custom way of plugging comparision keys for session. works unless creating another session for the same cell of a duplicated editor
* Set offSide to sql lang configuration to true (#183461)
* Fixes#181764 (#183550)
* fix typo
* Always scroll down and focus the input (#183557)
* Fixes#180386 (#183561)
* cli: ensure ordering of rpc server messages (#183558)
* cli: ensure ordering of rpc server messages
Sending lots of messages to a stream would block them around the async
tokio mutex, which is "fair" so doesn't preserve ordering. Instead, use
the write_loop approach I introduced to the server_multiplexer for the
same reason some time ago.
* fix clippy
* update for May endgame
* testing: allow invalidateTestResults to take an array (#183569)
* Document `ShareProvider` API proposal (#183568)
* Document `ShareProvider` API proposal
* Remove mention of VS Code from JSDoc
* Add support for rendering svg and md in welcome message (#183580)
* Remove toggle setting more eagerly (#183584)
* rm message abt macOS
* Change text (#183589)
* Change text
* Accidentally changed the wrong file
* cli: improve output for code tunnel status (#183571)
* testing: allow invalidateTestResults to take an array
* cli: improve output for code tunnel status
Fixes#183570
* [json/css/html] update services (#183595)
* Add experimental setting to enable this dialog
* Fix exporting chat model to JSON before it is initialized (#183597)
* minimum scrolling to reveal the next cell on shift+enter (#183600)
do minimum scrolling to reveal the next cell on Execute cell and select next
* Fixing Jupyter notebook issue 13263 (#183527)
fix for the issue, still need to understand why there is strange focusing
* Tweak proposed API JSDoc (#183590)
* Tweak proposed API JSDoc
* workbench -> workspace
* fix ? operator
* Use active editor and show progress when sharing (#183603)
Use active editor and show progress
* use scroll setting variable correctly
* Schedule welcome widget to show once between typing. (#183606)
* Schedule dialog to show once between typing
* Don't re-render if already displayed once
* Add F10 keybinding for debugger step, even on Web. (#183510)
Fixes#181792.
Previously, for Web the keyboard shortcut was Alt-F10, because it was
believed that F10 could not be bound on browsers. This turned out to be
incorrect, so we make the shortcut consistent (F10) with desktop VSCode
which is also what many other debuggers use.
We keep Alt-F10 on web as a secondary keybinding to keep the experience
some web users may have gotten used to by now.
* Also pass process.env
* Restore missing chat clear commands (#183651)
* chore: update electron@22.5.4 (#183716)
* Show remote indicator in web when remoteAuthority is set (#183728)
* feat: .vuerc as json file (#153017)
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
* Delete --compatibility=1.63 code from the server (#183738)
* Copy vscode.dev link to tunnel generates an invalid link when an untitled workspace is open (#183739)
* Recent devcontainer display string corrupted on Get Started page (#183740)
* Improve "next codeblock" navigation (#183744)
* Improve "next codeblock" navigation
Operate on the current focused response, or the last one, and scroll to the selected item
* Normalize command title
* Git - run git status if similarityThreshold changes (#183762)
* fix aria-label issue in kb editor
fixes A11y_GradeB_VSCode_Keyboard shortcut reads words together - Blind: Arrow key navigation to row Find the binding keys and "when" cell data are read together resulting in a word " CTRL + FeditorFocus instead of CTRL + F editorFocus" #182490
* Status - fix compact padding (#183768)
* Remove angle brackets from VB brackets (#183782)
Fixes#183359
* Update language config schema with more details about brackets. (#183779)
* fix comment (#183812)
* Support for `Notebook` CodeAction Kind (#183457)
* nb kind support -- wip
* allow notebook codeactions around single cell edit check
* move notebook code action type out of editor
---------
Co-authored-by: rebornix <penn.lv@gmail.com>
* cli: fix connection default being applied (#183827)
* cli: bump to openssl 1.1.1u (#183828)
* Implement "delete" action for chat history (#183609)
* Use desired file name when generating new md pasted file paths (#183861)
Fixes#183851
* Default to filename for markdown new file if empty (#183864)
Fixes#183848
* Fix small typo (#183865)
Fixes#183819
* Noop when moving a symbol into the file it is already in (#183866)
Fixes#183793
* Adjust codeAction validation to account for notebook kind (#183859)
* Make JS/TS `go to configuration` commands work on non-`file:` file systems (#183688)
Make `go to project` commands work on non-`file:` file systems
Fixes#183685
* Can't do regex search after opening notebook (#183884)
Fixes#183858
* Default to current dir for `move to file` select (#183875)
Fixes#183870
`showOpenDialog` seems to ignore `defaultUri` if the file doesn't exist
* Use `<...>` style markdown links when needed (#183876)
Fixes#183849
* Remove check for context keys
* Update xterm package
* Enable updating a chat model without triggering incremental typing (#183894)
* Enable chat "move" commands on empty sessions (#183895)
* Enable chat "move" commands on empty sessions
and also imported sessions
* Fix command name
* Fix some chat keybindings on windows (#183896)
* "Revert File" on inactive editors are ignored (fix#177557) (#183903)
* Empty reason while switching profile (fix#183775) (#183904)
* fix https://github.com/microsoft/vscode-internalbacklog/issues/4278 (#183910)
* fix https://github.com/microsoft/vscode/issues/183770 (#183914)
* code --status displays a lot of errors before actual status output (fix#183787) (#183915)
* joh/icy manatee (#183917)
* Use idle value for widget of interactive editor controller
https://github.com/microsoft/vscode/issues/183820
* also make preview editors idle values
https://github.com/microsoft/vscode/issues/183820
* Fix#183777 (#183929)
* Fix#182309 (#183925)
* Tree checkbox item -> items (#183931)
Fixes#183826
* Fixes#183909 (#183940)
* Fix#183837 (#183943)
fix#183837
* Git - fix#183941 (#183944)
* Update xterm.css
Fixes#181242
* chore: add @ulugbekna and @aiday-mar to my-endgame notebook (#183946)
* Revert "When snippet mode is active, make `Tab` not accept suggestion but advance placeholder"
This reverts commit 50a80cdb61511343996ff1d41d0b676c3d329f48.
* revert not focusing completion list when quick suggest happens during snippet
* change `snippetsPreventQuickSuggestions` default to false
* Fix#181446 (#183956)
* fix https://github.com/microsoft/vscode-internalbacklog/issues/4298 (#183957)
* fix: remove extraneous incorrect context keys (#183959)
These were actually getting added in getTestItemContextOverlay, and the test ID was using the extended ID which extensions do not know about.
Fixes#183612
* Fixes https://github.com/microsoft/monaco-editor/issues/3920 (#183960)
* fix https://github.com/microsoft/vscode-internalbacklog/issues/4324 (#183961)
* fix#183030
* fix#180826 (#183962)
* make message more generic for interactive editor help
* .
* fix#183968
* Keep codeblock toolbar visible when focused
* Fix when clause on "Run in terminal" command
* add important info to help menu
* fix#183970
* Set `isRefactoring` for all TS refactoring edits (#183982)
* consolidate
* Disable move to file in TS versions < 5.2 (#183992)
There are still a few key bugs with refactoring. We will ship this as a preview for TS 5.2+ instead of for 5.1
* Polish query accepting (#183995)
We shouldn't send the same request to Copilot if the query hasn't changed. So if the query is the same, we short circut.
Fixes https://github.com/microsoft/vscode-internalbacklog/issues/4286
Also, when we open in chat, we should use the last accepted query, not what's in the input box.
Fixes https://github.com/microsoft/vscode-internalbacklog/issues/4280
* Allow widget to have focus (#184000)
So that selecting non-code text works.
Fixes https://github.com/microsoft/vscode-internalbacklog/issues/4294
* Fix microsoft/vscode-internalbacklog#4257. Mitigate zindex for zone widgets. (#184001)
* Change welcome dialog contribution to Eventually
* Misc fixes
* Workspace folder picker entry descriptions are suboptimal for some filesystems (fix#183418) (#184018)
* cli - ignore std error unless verbose (#183787) (#184031)
* joh/inquisitive meerkat (#184034)
* only stash sessions that are none empty
https://github.com/microsoft/vscode-internalbacklog/issues/4281
* only unstash a session once - unless new exchanges are made,
https://github.com/microsoft/vscode-internalbacklog/issues/4281
* account for all exchange types
* Improve declared components (#184039)
* make sure to read setting (#184040)
d'oh, related to https://github.com/microsoft/vscode/issues/173387#issuecomment-1571696644
* [html] update service (#184049)
[html] update service. FIxes#181176
* reset context keys on reset/hide (#184042)
fixes https://github.com/microsoft/vscode-internalbacklog/issues/4330
* use `Lazy`, not `IdleValue` for the IE widget held by the eager controller (#184048)
https://github.com/microsoft/vscode/issues/183820
* fix https://github.com/microsoft/vscode-internalbacklog/issues/4333 (#184067)
* use undo-loop instead of undo-edit when discarding chat session (#184063)
* use undo-loop instead of undo-edit when discarding chat session
fixes https://github.com/microsoft/vscode-internalbacklog/issues/4118
* fix tests, wait for correct state
* Add logging to node download (#184070)
Add logging to node download. For #182951
* re-enable default zone widget revealing when showing (#184072)
fixes https://github.com/microsoft/vscode-internalbacklog/issues/4332, also fixes https://github.com/microsoft/vscode-internalbacklog/issues/3784
* fix#178202
* Allow APIs in stable (#184062)
* Fixmicrosoft/vscode-internalbacklog#4206. Override List view whitespace css for monaco editor (#184087)
* Fix JSDoc grammatical error (#184090)
* Pick up TS 5.1.3 (#184091)
Fixes#182931
* Misc fixes
* update distro (#184097)
* chore: update electron@22.5.5 (#184116)
* Extension host veto is registered multiple times on restart (fix#183778) (#184127)
Extension host veto is registered multiple times on restart (#183778)
* Do not auto start the local web worker extension host (#184137)
* Allow embedders to intercept trustedTypes.createPolicy calls (#184136)
Allow embedders to intercept trustedTypes.createPolicy calls (#184100)
* fix: reading from console output for --status on windows and linux (#184138)
fix: reading from console output for --status on windows and linux (#184118)
* Misc fixes
* code --status displays a lot of errors before actual status output (fix#183787) (#184200)
fix 183787
* (cherry-pick to 1.79 from main) Handle galleryExtension failure in featuredExtensionService (#184205)
Handle galleryExtension failure in featuredExtensionService (#184198)
Handle galleryExtension failure
* Fix#184183. Multiple output height updates are skipped. (#184188)
* Post merge init fixes
* Misc build issues
* disable toggle inline diff of `alt` down
https://github.com/microsoft/vscode-internalbacklog/issues/4342
* Take into account already activated extensions when computing running locations (#184303)
Take into account already activated extensions when computing running locations (fixes#184180)
* Avoid `extensionService.getExtension` and use `ActivationKind.Immediate` to allow that URI handling works while resolving (#184310)
Avoid `extensionService.getExtension` and use `ActivationKind.Immediate` to allow that URI handling works while resolving (fixes#182217)
* WIP
* rm fish auto injection
* More breaks
* Fix Port Attributes constructor (#184412)
* WIP
* WIP
* Allow extensions to get at the exports of other extensions during resolving (#184487)
Allow extensions to get at the exports of other extensions during resolving (fixes#184472)
* do not auto finish session when inline chat widgets have focus
re https://github.com/microsoft/vscode-internalbacklog/issues/4354
* fix compile errors caused by new base method
* WIP
* WIP
* WIP
* WIP
* Build errors
* unc - fix path traversal bypass
* Bump version
* cherry-pick prod changes from main
* Disable sandbox
* Build break from merge
* bump version
* Merge pull request #184739 from max06/max06/issue184659
Restore ShellIntegration for fish (#184659)
* Git - only add --find-renames if the value is not the default one (#185053)
Git - only add --find-renames if the value is not the default one (#184992)
* Cherry-pick: Revert changes to render featured extensions when available (#184747)
Revert changes to render featured extensions when available. (#184573)
* Lower timeouts for experimentation and gallery service
* Revert changes to render extensions when available
* Add audio cues
* fix: disable app sandbox when --no-sandbox is present (#184913)
* fix: disable app sandbox when --no-sandbox is present (#184897)
* fix: loading minimist in packaged builds
* Runtime errors
* UNC allow list checks cannot be disabled in extension host (fix#184989) (#185085)
* UNC allow list checks cannot be disabled in extension host (#184989)
* Update src/vs/base/node/unc.js
Co-authored-by: Robo <hop2deep@gmail.com>
---------
Co-authored-by: Robo <hop2deep@gmail.com>
* Add notebook extension
* Fix mangling issues
* Fix mangling issues
* npm install
* npm install
* Issues blocking bundle
* Fix build folder compile errors
* Fix windows bundle build
* Linting fixes
* Fix sqllint issues
* Update yarn.lock files
* Fix unit tests
* Fix a couple breaks from test fixes
* Bump distro
* redo the checkbox style
* Update linux build container dockerfile
* Bump build image tag
* Bump native watch dog package
* Bump node-pty
* Bump distro
* Fix documnetation error
* Update distro
* redo the button styles
* Update datasource TS
* Add missing yarn.lock files
* Windows setup fix
* Turn off extension unit tests while investigating
* color box style
* Remove appx
* Turn off test log upload
* update dropdownlist style
* fix universal app build error (#23488)
* Skip flaky bufferContext vscode test
---------
Co-authored-by: Johannes <johannes.rieken@gmail.com>
Co-authored-by: Henning Dieterichs <hdieterichs@microsoft.com>
Co-authored-by: Julien Richard <jairbubbles@hotmail.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Megan Rogge <merogge@microsoft.com>
Co-authored-by: meganrogge <megan.rogge@microsoft.com>
Co-authored-by: Rob Lourens <roblourens@gmail.com>
Co-authored-by: Connor Peet <connor@peet.io>
Co-authored-by: Joyce Er <joyce.er@microsoft.com>
Co-authored-by: Bhavya U <bhavyau@microsoft.com>
Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
Co-authored-by: Aaron Munger <aamunger@microsoft.com>
Co-authored-by: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Co-authored-by: rebornix <penn.lv@gmail.com>
Co-authored-by: Ole <oler@google.com>
Co-authored-by: Jean Pierre <jeanp413@hotmail.com>
Co-authored-by: Robo <hop2deep@gmail.com>
Co-authored-by: Yash Singh <saiansh2525@gmail.com>
Co-authored-by: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com>
Co-authored-by: Ulugbek Abdullaev <ulugbekna@gmail.com>
Co-authored-by: Alex Ross <alros@microsoft.com>
Co-authored-by: Michael Lively <milively@microsoft.com>
Co-authored-by: Matt Bierner <matb@microsoft.com>
Co-authored-by: Andrea Mah <31675041+andreamah@users.noreply.github.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Sandeep Somavarapu <sasomava@microsoft.com>
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com>
Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
Co-authored-by: Joao Moreno <Joao.Moreno@microsoft.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
* Properly close dialog with escape
* Revert "Properly close dialog with escape"
This reverts commit 9ea5ec4beebcbbd4f0623ed0b5da0f1026fcd5be.
* Remove focus on ok button in filter dialog
* Sets the focus on the filterTable
* Initial commit for adding a basic general tab for the database properties
* Refactoring for dialog inputs
* removed properties nodeType and using database node and additional cleanup, diabling the functionality.
* Changes according to STS data fetch
* Reuse database Dialog
* Undo contract file change
* more refactoring
* fetched scrollbar fix into this PR
* Tabbed panel is being used for horizontal tabs
* stying fix for general tab button
* final commit for today :)
* Updates according to STS changes
* missed updates
* Refactored updates
* moved options as discussed and added collapsible sections... need to fix scroll bar
* Fixing the horizontal scroll bar of tabbedpanel
* remove advanced options for table designer and notebook Actions title (unnecessary in usage context)
* Revert "remove advanced options for table designer and notebook Actions title (unnecessary in usage context)"
This reverts commit e30aee5151319863aebbb4738fb30354c179c2c5.
* added changes based on feedback
* added null check and updated tests
* WIP change to connection title generation
* WIP connection management service update
* fix to connectionManagementService test
* fix editorConnectionTitles
* renamed nondefault to distinguishing options
* use stored connections for options
* removed erroneous connection name set to null
* added title by ID search for title generation
* Add recent connection title
* added fix for stub bug
* added child title options appended
* WIP rework of getEditorTitle
* more work done
* WIP changes for 5-2-2023
* moved server info to generate titles.
* added reworked title generation
* added working active connection title generation and cleanup
* added comments to argument
* remove unnecessary spaces
* added id fix assign
* added fromEditor save
* Revert "Revert new connection string format (#22997)"
This reverts commit 898bb73a34.
* added small fix to tests and exclude empty properties
* made small fixes for tests
* update expected ID
* added support for old password key and removed empty options
* added in authenticationType core property
* fix for whitespace indentation
* added connection save profile to thing
* made some small fixes to connection options
* added small change to connectionDialogService
* added nullcheck for saveProfile
* added negation for connection saveProfile
* remove duplicate editor title generation
* added edit profile handling for titles
* Cleanup serverCapabilities property
* fixed dependency issues
* removed connectionproviderproperties
* added fix for treeupdateutils
* made update to title generation
* added recent connections change
* Revert "Cleanup serverCapabilities property"
This reverts commit 2c7b94f98cabddb34116dcdd83177614a484c026.
* added dashboard text and fix for connection store test
* added group name to end also temporary added dashboard changes based on feedback
* added in new SQL version
* added fix to edit connections
* added clarifying information to title generation
---------
Co-authored-by: Cheena Malhotra <cmalhotra@microsoft.com>
* Upgrading chartjs
* Upgrading charjs in exthost and removing ng2-charts
* Updating lock file
* Fixing paths in workbench for new chartjs
* Removing more any
* Removing more any
* Fixing colors
* Fixing more stuff
* Updating distro hash
* add package reference type for system db references
* Add radio buttons
* hookup
* add test
* handle changing reference type radio buttons
* cleanup
* update strings
* change style to type
* change more places with style to type
* blank lines
* add copy results to query provider
* mark as optional
* fix test stub
* Update src/sql/azdata.proposed.d.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* address comments
* update return type
---------
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Initial support for MongoDB clusters / vCore
* Get cluster connection string from arm
* Preserve Azure account for any auth type
When a service has been selected through the Azure
browser, we want to preserve the Azure account
information even if a different authentication has
been selected. This allows doing ARM operations
using the signed in Azure account for any resources
including those with a different login types such
as clusters.
* Update product pipelines to add back core integration tests to Darwin and extension unit tests to Linux
* Update whitespace
* Update indentation
* Skip failing tests for now
* Fixing server group styling
* Hiding border when the tree item are selected focused or hovered
* Fixing styles and re-enabling guides
* removing unused import
* Fixing indicator width
* wip
* Update typings
* nullable
* update test service
* support securables
* updata test data
* fix issues
* fix build failure
* update test mocks
* fix typo
* fix reference
* fix findobjectdialog issue
* update SearchResultItem type
* fix table component perf issue
* hide effective permission for server role
* hide effective permission for app role and db role
* vbump sts and fix a couple issues
* STS update and UI update
* fix user login display issue
* vbump sts
* Adding init change
* Adding filter cache in OE
* Adding more filtering changes
* Fixed stuff with dialog
* Fixing filter
* Adding support for connecitons
* Fixed stuff
* filtering
* Fixing date
* Filters
* Removing is filtering supported
* Removing contracts
* Fixing filters
* Fixing cache
* Adding some accessibility changes
* Reverting some more changes to pull in changes from the main
* Adding comments
* Fixing boolean operators
* Fixing stuff
* Fixing stuff
* Fixing error handling and making dialog generic
* Fixing more stuff
* Making filter a generic dialog
* adding erase icon
* removing floating promises
* Fixing compile issue
* Adding support for choice filter with different and actual value.
* Adding null checks
* Adding durability type fix
* Fixing filtering for providers that do not play well with empty filter properties
- Bucketized errors to track top errors
- Created separate login migration specific error to improve monitoring
---------
Co-authored-by: Akshay Mata <akma@microsoft.com>
* Compile build folder
* Fix build compile issues (#22813)
* Revert changes
* Update gulp-shell
* Test
* Update
* Update modifiers
* Try reverting minimist
* Generates linux deb artifact (#22922)
* Remove deb files that were brought in with the latest merge.
* Add debian back to linux gulp file
* Remove async from anonymous function.
* Remove run core integration tests build step in pipeline
* Revert "Remove async from anonymous function."
This reverts commit 7ad1ce2942954fce58939b9965343b46b9311a7e.
* Revert "Add debian back to linux gulp file"
This reverts commit 96b7c0f0995c8024ef67ed886da34255a5caa325.
* Revert "Remove deb files that were brought in with the latest merge."
This reverts commit bf3aae233b8da1f9111a149a96d77cc78d376094.
* Removes dependency checks
* Fix dependency gen errors
* Reenable "Build Deb" step
* Reenable publish deb
* Run core integration tests
* Revert "Run core integration tests"
This reverts commit 7cafbada194feebe771862af796fb3416b5dd686.
* Revert "Try reverting minimist"
This reverts commit 38fd843c1d5c33318a92f4bbc7057e951c5a9f71.
* Disable code coverage step intermin
---------
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com>
* Template
* Refactor
* Update strings
* Clean up
* Add clear button
* Clean up
* Fix typo and use aka.ms link
* Refactor to use GroupContainer
* Remove dialog and clean up common strings
* Fix previous/forward behavior
* Make group container default to collapsed
* Clean up
* Slightly reword string
* Add https to aka.ms link
Add troubleshooting links to error message when SQL-Migration fails to download the MigrationService as seen in this issue: #22558
---------
Co-authored-by: Akshay Mata <akma@microsoft.com>
* Adding exclude folder and base for move folder
* checkpoint
* rename
* Fixing up tests
* Adding exclude test to projController
* Adding tests
* fixing order of service.moveX() calls
* Updating move() order in sqlproj service
* PR feedback
* unskipping
* reskipping test
* Fixing folder move conditional
* updating comments
* server role dialogs
* dialogs for other types
* refactor
* find object dialog
* script button
* refactoring
* fix issues
* fix title
* vbump sts
* remove language from links
* x subscription migration support
* refresh after cutover
* fix service irregular status load behavior
* queue service status requests, fix typo
* add migationTargetServerName helper method
* save context before api call
* update vscode-mssql.d.ts
* update extensions that need updates because of the vscode-mssql.d.ts changes
* remove skip
* fix sql projects tests failing because vscode-mssql couldn't be found
* Connection URI made to include every option available instead of basic details (#22045)
* Revert "Merge remote-tracking branch 'origin' into feat/connectionUri"
This reverts commit 11b2d31bf99e216daee823f732254f69a017fee1, reversing
changes made to 36e4db8c0744f81565efdfd2f56a3ae3c0026896.
* Revert "Revert "Merge remote-tracking branch 'origin' into feat/connectionUri""
This reverts commit f439673c2693e1144c52e04c14e82cd8566c13a6.
* Added changes and fixes for feat connectionuri (#22706)
* add title generation at start
* added await to refreshConnectionTreeTitles
* Converting remaining services to use `runWithErrorHandling()`
* Updating sqlops-dataprotocolclient to 1.3.3
* upgrading dataprotocol and swapping to that baseService
* Adding async to make thenable -> promise conversion happy
---------
Co-authored-by: Alan Ren <alanren@microsoft.com>
* Add profile section in Publish project UI
* Move publish profile row below Publish Target
* Add contract for savePublishProfie and SaveProfileAs button functionality
* Make the DacFx contract functional
* Send values from UI to DacFx service call
* Fix build error
* Address comment, remove print statements
* Address comments
* Set correct connection string
* Fix functionality for rename, exclude, delete publish profiles. Add new profile to the tree and sqlproj.
* Address comment to update alignement of button
* Address comments
* Update button to use title casing
* fix http request format
* encode to utf 8 and add body for put requests
* encode proxy request body
* change ?.data to ?.body
* add note for textencoder
* change content-type to application/json
* Hide more info for assessment issues without help links
* Add info box about blob container folders
* WIP - reuse create DMS dialog for IR registration
* Revert "Add info box about blob container folders"
This reverts commit 30b8892ea7918841a6466b59058181062d367ba5.
* Add help link to target platform selection page explaining Azure SQL offerings
* Revert "WIP - reuse create DMS dialog for IR registration"
This reverts commit 5fac6b5c7148b2520cc42ce9fad549cde28baba2.
* Don't show storage account warning banner for DB scenario
* Vbump extension and migration service
* Test - fix http request format from chsuh/fixFormat
* Add instructions for table mapping and schema migration
* Revert "Test - fix http request format from chsuh/fixFormat"
This reverts commit 4992603532e98dff3b7ba6f04ba9304d173fc5ad.
* disabling revert SQLCMD var value button when no changes to values; changing string
* Updating docstring
* Updating behavior to account for SQLCMD vars defined in publish profiles
* Changing look of new OE
* Fixing styling
* Fixing moving of connected profile
* Fixing drag and drop where treenodes delete connection nodes
* Fixing Deleting and disconnecting in AsyncServerTree
* Adding constant for OE timeout
* Updated interfaces
* Removing test compilation errors
* Fixing most events in async server tree
* Fixing connection pane styling
* Fixing find node function
* Fixing some more operations
* Fixing some ops
* All operations done
* Fixed active connections
* Fixed data source
* Adding support for setting parents
* code cleanup
* Fixing icon styling issues
* Fix errors
* Fixing comment
* Fixing spacing
* Adding explanation to OE service.
* Reverting server delegate changes
* Reverting styling
* reverting more styling change
* reverting more styling
* Fixing has children
* Fixing drag and drop to tree nodes
* fixing drag and drop
* reverting timing
* fixing drag and drop
* cleaning some code
* Fixed server and group moving
* spell check
* consolidating some logic
* Fixed whitespace
* fixing moving to root group
* add new migration details
* move migraiton target type enum to utils
* address review feedback, refectore, text update
* fix variable name
* limit and filter migrations list to mi/vm/db
* Move call to STS move api into project.ts (#22071)
* move call to STS move api into project.ts
* remove undefined
* Remove convert to sdk style code (#22081)
* remove convert to sdk style code
* remove from package.json
* Merging latest from main (#22097)
* [SQL-Migration] Login migrations telemetry (#22038)
This PR enhances telemetry for login migrations (and in the following ways:
Add details for starting migration (number of logins migrating, type of logins)
Log Migration result (number of errors per step, duration of each step, type of logins, if system error occurred)
Add sql-migration extension to our telemetry
Adds details when trying to connect to target
Tracks clicking "done" from the wizard
Fixes bucketizing for navigating telemetry in the login migration wizard
Sample usage of kusto query for new telemetry:
RawEventsADS
| where EventName contains 'sql-migration'
| extend view = tostring(Properties['view'])
| extend action = tostring(Properties['action'])
| extend buttonPressed = tostring(Properties['buttonpressed'])
| extend pageTitle = tostring(Properties['pagetitle'])
| extend adsVersion = tostring(Properties['common.adsversion'])
| extend targetType = tostring(Properties['targettype'])
| extend tenantId = tostring(Properties['tenantid'])
| extend subscriptionId = tostring(Properties['subscriptionid'])
| where view contains "login"
//| where adsVersion contains "1.42.0-insider"
| where ClientTimestamp >= ago(18h)
| project EventName, ClientTimestamp, SessionId, view, pageTitle, action, buttonPressed, targetType
, tenantId, subscriptionId
, adsVersion, OSVersion, Properties
* Add Secure Enclaves dropdown with customizable Advanced options (#22019)
* Update extension READMEs (#22079)
* Fix query-history README images (#22084)
* [Loc] update to mssql and sql-migration xlf files (#22087)
* [Loc] small fix to Portuguese lcl file (#22088)
* [Loc] small fix to Portuguese lcl file
* remove newline
* Adding None bindings to the sqlProjects service (#22085)
* Adding None bindings
* updating names of None bindings
---------
Co-authored-by: AkshayMata <akam520@gmail.com>
Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Alex Ma <alma1@microsoft.com>
* Swap add and update sqlcmd variables in sql projects to use STS apis (#22086)
* delete sqlcmd variable working
* undo add
* remove variable from add and update sqlcmd variable apis
* hookup add and edit sqlcmd variable
* update vscode-mssql.d.ts
* move add and edit to project.ts
* update STS and tests
* move delete sqlcmd variable to project.ts (#22104)
* add test for add and edit sqlcmd variable (#22107)
* Swapping property access to STS (#22115)
* checkpoint
* Adding sqlproj property bindings
* Swapping out property loading and setting
* consolidating to this.sqlProjService
* Update dacpac reference to use STS api (#22116)
* Update add dacpac reference to use STS api
* remove changes for project ref
* validate unset settings from add database reference dialog
* update one more place getting sqlprojservice
* addressing comments
* fix path for dacpac reference (#22143)
* Swap add project reference to call STS (#22148)
* initial changes for swapping add project reference
* fix include path
* move common logic to helper function
* read sqlcmd variables from STS (#22147)
* Swapping .sqlproj- and crossplat compatibility-related functions to use STS (#22146)
* Supporting roundtrip
* Updating sqlproj style checks and cross-platform compatibility to use STS
* removing unnecessary awaits
* Fixing assertions
* Adding roundtrip update confirmations
* test cleanup
* cleaning up comment; localizing error
* Swap add system db reference (#22171)
* swap adding system database references
* fix tests
* remove only in test
* Read database references from STS (#22179)
* Read database references from STS
* fix system dacpac names
* fix project reference name
* Swap changeTargetPlatform to call STS (#22172)
* swap changeTargetPlatform to call STS
* Address comments
* De-duplicating enum for SystemDatabase (#22196)
* Deudping SystemDatabase enum
* simplifying enum refs
* Removing the now-unused imports code from SqlProjects (#22199)
* Removing unused importTargets entries
* whitespace; also to retrigger github checks on correct branch
* Hooking in Move() for Nones and PublishProfiles (#22200)
* Swap delete database reference to call STS (#22215)
* initial changes
* update contracts
* remove unnecessary info from SystemDatabaseReferenceProjectEntry
* uppercase master and msdb
* cleanup
* update test
* update comment
* undo change in projectController.ts
* remove unused system dacpac helper functions (#22204)
* more cleanup of project.ts (#22242)
* fix a couple database reference tests (#22248)
* Organizing sqlcmd variable and db reference code (#22284)
* organize database references and sqlcmd variable functions
* separate database reference tests
* Script and folder get + add support (#22166)
* Initial sqlobjectscripts
* adding mock filter
* test fixing
* another test passing
* swapping pre/post/none checkpoint
* awaiters
* convert addExistingItem
* swapping folders
* removing print
* stripping out project folder and file readers
* adding some regions
* Updating sqlproj style checks and cross-platform compatibility to use STS
* Updating sqlproj style checks and cross-platform compatibility to use STS
* added type property to tree items
* projectController swapovers
* removing imported targets
* Deleting the last of the TS XML parsing!
* Removing old functions
* renamed readNoneScripts to readNoneItems
* fixing path passed to STS calls
* remove system dacpac tests that were moved to DacFx (#22299)
* fix error when opening file after adding a file to sql project (#22309)
* fix error when opening file after adding a file to sql project
* remove unused import
* fix exclude for table and externalStreamingJob (#22310)
* add reload project (#22313)
* set DSP from STS (#22320)
* fix adding post-deployment script and existing item (#22317)
* Test cleanup for .sqlproj content operations (#22330)
* Fixing up tests
* sqlproj content operations tests
* remove only
* Cleanup
* Correcting collation
* cleanup constants.ts (#22336)
* fix folders not showing in project tree (#22319)
* Fix project controller tests (#22327)
* fixing ProjectController tests after swap
* remove only from database reference tests
* change system dbs back to lowercase in sql projects (#22353)
* Bump tools service
* Updated yarn.lock file
* pass SystemDacpacsLocation when building legacy style sql projects (#22329)
* Benjin/fix types (#22365)
* Updated yarn.lock file
* Fixing types
* fix projectController tests (#22375)
* Fixing the deletion flow for files and folders (#22366)
* checkpoint
* PR feedback
* Fixing up SDK-style operations project test group (#22377)
* Fixing up SDK-style project test group
* Removing .only
* Fixing up database reference tests (#22380)
* Fixing DB reference test group
* Extra cleanup
* removing only
* Consolidating None and PublishProfile; lighting up test (#22382)
* Lighting up project property tests (#22395)
* Checkpoint
* Lighting up project property tests
* removing timeout
* Fixing buildHelper test (#22400)
* Unskipping up roundtrip test (#22397)
* Refactoring database references to split literalVariable from databaseName (#22412)
* refactoring database references to split databaseVariableLiteralValue out from databaseName
* renaming more properties
* Removing branch in entry population
* removing only
* Fixing baselines for delete test
* PR feedback
* Fixing up ProjectTree tests (#22419)
* Fixing up projectTree tests
* remove only
* Updating projectController exclude test (#22413)
* Updating test
* moving filtering for external folders to readFolders() method
* Removing EntryType import
* fix ups (#22435)
* adding extra info for test failure
* hide exclude folder from context menu until it's supported (#22454)
* Adding current test name to generated folder to avoid conflicts (#22478)
* Adding current test name to generated folder to avoid conflicts
* passing correct test parameter in
* Adding trimming and entropy
* Deleting unused baselines (#22497)
* Replacing addToProject() with addSqlObjectScripts() (#22489)
* checkpoint
* Fixing test
* Updating file scraper function to filter only to .sql files (no folders, no txt)
* changing var names to reflect that the lists only contain .sql scripts
---------
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: AkshayMata <akam520@gmail.com>
Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Alex Ma <alma1@microsoft.com>
* Fixing new connection node not expanding in OE
* Fixing new connections not expanding and fixing expand request not resolving because of some provider error.
* Fixing test
* Adding a setting for node expansion timeout
* Not saving when loading tree based connections
* Adding some logs
* Removing special casing for mssql provider
* Missing providers
* Adding user toast for node expansion timeout
* Adding notification service to test
* Fixing node type for mssql
* remove polling
* Fixing onNodeStatus
* Fixing stuff
* consolidating functions
* Consolidating resolve logic
* removing extra try catch
* code cleanup
* adding size checks
* Removing commented code
* Ignoring errors from other sessions and nodepaths.
* Fix for newline replacement
* added proper null regex and null character check
* removed cell class
* removed unnecessary function
* revert back to old check
* change onbeforeeditcell
* small fix to typo in onBeforeEditCell
* made changes based on feedback
* added comments clarifying isDBCellValue
* update the rendered text onCellSourceChange
* fix test
* fix highlight in split mode
* update corresponding test
* update hasEditor with getEditor
* update event
* add comment
* Moves New Deployment to file menu bar.
* Add deployment back to breadcrumb menu
* Update extensions/resource-deployment/DEVELOPER_GUIDE.md
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Adjust new deployment mnemonic
* Remove unused localized string
---------
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
This PR enhances telemetry for login migrations (and in the following ways:
Add details for starting migration (number of logins migrating, type of logins)
Log Migration result (number of errors per step, duration of each step, type of logins, if system error occurred)
Add sql-migration extension to our telemetry
Adds details when trying to connect to target
Tracks clicking "done" from the wizard
Fixes bucketizing for navigating telemetry in the login migration wizard
Sample usage of kusto query for new telemetry:
RawEventsADS
| where EventName contains 'sql-migration'
| extend view = tostring(Properties['view'])
| extend action = tostring(Properties['action'])
| extend buttonPressed = tostring(Properties['buttonpressed'])
| extend pageTitle = tostring(Properties['pagetitle'])
| extend adsVersion = tostring(Properties['common.adsversion'])
| extend targetType = tostring(Properties['targettype'])
| extend tenantId = tostring(Properties['tenantid'])
| extend subscriptionId = tostring(Properties['subscriptionid'])
| where view contains "login"
//| where adsVersion contains "1.42.0-insider"
| where ClientTimestamp >= ago(18h)
| project EventName, ClientTimestamp, SessionId, view, pageTitle, action, buttonPressed, targetType
, tenantId, subscriptionId
, adsVersion, OSVersion, Properties
* swap rename to use DacFx project apis
* add support for rename pre/post deploy scripts and add tests
* update the enum names too
* check instanceof instead of getting and iterating through all the collections
This PR fixes an issue where the JSON-RPC Migration Service crashes when ADS is reloaded.
This situation applies when user tried to reload ADS where SQL-migration extension was running:
when connecting to DB, SQL-migration extension loads and migration service launches
if a previous MigrationService zombie process is stil running (if extension was used before), then that zombie process will have a lock on the log file
new launches of MigrationService on reloaded ADS fails b/c it can't obtain log file handle due to lock in step 2
The fix stops the MigrationService on extension deactivate and will ensure that a zombie MigrationService process isn't hanging around on reloads.
No hotfix needed as 1.4.0 was baking in insiders and has not been released to stable yet. Additionally, this mainly affects developers as they are most likely to reload ADS this way. Caveat: users do need to reload after installing latest version, however they will not hit this code path (since the migration service process is only in new versions of the extension)
* show error if trying to create or open project when no project extensions are found
* only check if project providers are available on startup and when extensions change
* addressing comments
* Update extensions/data-workspace/src/services/workspaceService.ts
use some instead of find
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
---------
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
This PR updates the JSON-RPC Migration service to the latest version. Critically, it also changes the dotnet version to 7.0. The STS dotnet version was recently changed, which changed the names of the release packages and broke our existing links.
* Read publish profiles stored in sqlproj file and present it in the projects tree
* Save publish profile and add it to sqlproj file, and present it in the tree
* Fix context menu operations
* Add tests
* Address comments
* starts of sqlprojectsservice
* copy to mssql
* adding all the boilerplate
* updating service call structures
* Fixing up test mocks
* Adding comments to all the bindings
* blank space
* swapping for Promise; adding vscode-mssql type bindings
* patching
* Fix empty name in delete connection prompt
* Update src/sql/workbench/services/objectExplorer/browser/connectionTreeAction.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
---------
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* initial commit
* leave only march release objects
* clean up
* login dialog
* localize and use background operation
* code cleanup
* remove tab
* support server role in login
* remove canEditName
* add user support
* comments and bug fixes
* remove hasDBAccess for now
* refactoring
* fix error
* user dialog UI
* telemetry, error handling and refactoring
* Fix references to dialogInfo (#21914)
* update telemetry
* Bump STS and use actual object management service
* add preview and handle no-change scenario
* fix merge issue
---------
Co-authored-by: Karl Burtram <karlb@microsoft.com>
* Read encrypt and trust server certificate
* Set hostname in certificate setting
* Address comment- open connection dialog if the connection string in publish profile doesn't load a connection, instead of throwing an error.
* Adding migration service to sql migrations
* enabling auto flush log
* Adding support for env variable
* Adding TDE Migration service
* code cleanup
* updating service downloader
* Removing custom output channel
* remove unnecessary await
* Updated service version to get latest code
* Consolidate TDE into migration service
* Sync to latest main
* Update sql-migration package version
* Fix merge conflict error
* Fixing all merge conflicts
* Fixing stuff
* removing extra whitespace
* Cleaning up
---------
Co-authored-by: Akshay Mata <akma@microsoft.com>
* WIP
* Always get latest current connection
* Update more references
* Clean up
* Clean up
* vbump
* Update comments
* Address PR feedback
* Separate into helper methods
* fix uncaught error in showSplitView
* fixed bugs around account dialog with multiple providers
* cleanup
* fix index out of bounds error
* Fire account list update after removing provider, other pr fixes
This PR fixes a regression for migration login for MI instances that was introduced in https://github.com/microsoft/azuredatastudio/pull/21776/files#diff-93c1a62583fa32d99f775b71ad27922cf31f660d10717ecc6966784306de1b6f.
After that change, support for MI would fail as MI server types were going into the Sql VM path in sqlutils because the underlying logic for isSqlServerVM() was returning wrong results.
The new approach uses the targetType set in StateMachine to extract the correct serverName for connection string based on the targetType.
Testing:
- Tested SQL VM login migration end to end
- Tested SQL MI login migration end to end
This change also bumps the sql-migration version to 1.3.0
* Add validation for new file names for sql projects
* Addres comments and add validation for new project dialog
* Address comments
* Address comments on test
* Fix tests
* Remove extra error messages and rename file
* Address comments
* Fix tests
* Add test file back
* use pathname vs nodeValue
* add test
* add comment
* only when editing in rich text
* refactor
* fix build errors
* fix hygiene errors
* remove fs check
* compare decodedUri to get correct relative paths
* Add Azure Resource 'Sql' to MSSQL extension. (#21600)
* [Loc] added sql.xlf schema (#21687)
* vbump profiler extension (#21685)
* Fix connect icon for Arc extension (#21659)
* Juno: check in to lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20230121171613142. (#21690)
* Juno: check in to lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20230122164538349. (#21693)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* Juno: check in to lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20230123164122334. (#21697)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* use normalize to get the path correctly
* add comment
* refactor
* more tests
* typo fix
---------
Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>
Co-authored-by: Alex Ma <alma1@microsoft.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Alex Hsu <csigs@users.noreply.github.com>
This PR bumps sql-migration version to 1.2.2 in order to release to insider's gallery. This also disables the LoginMigration button as we do not want to release it to public yet.
* Adding prompt for disconnect
* changing to Idialog service
* Code cleanup and fixing comments
* Adding comments and making a test async
* removing then and awaiting for function
This PR adds various login migration improvements:
- Enabled windows login by prompting user for AAD domain name if a windows login is selected
image
- Adds new login details dialog which gives granular status on each step of the login migration for each login
image
- Checks if windows login migration is supported for selected target type, and only collections source windows logins accordingly
- Perf optimization by source and target login in background of step 1 in order to significantly speed up loading of page 2
* Disable IR scenario and add info box for source < 2014
* Update text and link
* Clean up
* Fix issue where switching to another target platform wouldn't clear restriction
* Remove locale from documentation URL
* Refactor
* Clean up
* Autoselect blob scenario
* Refactor
* Add page blog check
* Clean up
* Update UI logic
* Add allow list of valid notebook command uris (#163322)
This restricts notebooks to run three command uris. These 3 commands should all be safe to run, even with untrusted inputs
* Fix incorrectly resolved merge conflict
Co-authored-by: Matt Bierner <matb@microsoft.com>
* update to langpack xlfs
* update to langpack source files
* added updated source files and dates
* Update for 12-19-2022
* Update for 12-21-2022
* update for 1/3/2023
* update to azurecore 1-9-2023
* last update to langpack source file before release
Adding collation validation in target database selection page.
collecting source database info including state, size, collation etc in the step 1 (select databases to assess and migrate)
comparing source database collation and target database collation in target selection page.
image
* change how data workspace activates project extensions
* cleanup
* undo whitespace change
* Update extensions/data-workspace/src/services/workspaceService.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* activate extensions on data workspace new and open commands
* Update extensions/data-workspace/src/services/workspaceService.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Add dropdown populated with projects in current workspace in Update Project from database dialog for target project location
* Select first from the list if no project is preselected
* Address comments
* Added initial password connection dialog box
* made small changes
* more preliminary work
* more WIP changes
* more cleanup done
* added dialog instantiation
* added placeholder dialog window
* added changePasswordController
* made some changes to changePasswordController
* some changes made
* added more changes
* more changes made to dialogue
* added password confirm box
* added WIP change password function
* small changes made to API
* small changes for test
* added uri
* added valid password
* added TODO comments
* added small change to connectionManagementService
* added connectionManagementService password change
* added comment on what to do next
* made some simplification of change password
* added response callback
* added fixes to protocol
* added throw error for passwordChangeResult
* WIP added call to self after password change
* WIP changes to implementing new password change dialog
* added changes to passwordChangeDialog
* added launchChangePasswordDialog
* remove erroneous css
* added working dialog
* removed old password change dialog
* fixed space
* added checkbox option to passwordChangeDialog
* added test signatures
* added error handling
* added some changes
* added changes to HTML for passwordChangeDialog
* added CSS to passwordChangeDialog
* added display none for matching passwords
* added documentation changes
* small cleanup
* added working error catch and retry
* added await
* added recovery instructions
* Added ok button hide for button click.
* added loading spinner
* fixed for semicolon
* added updated message
* Added message change
* added minor fixes
* added small fixes
* made more changes
* renamed messages to errorDetails
* added styling to passwordChangeDialog
* simplified error message
* changed comment
* modified azdata to be consistent
* small changes
* change to azdata for consistency
* added clarification for provider
* removed additional instructions
* Added new dialog title
* addressed feedback
* added comments
* added changes
* Adding wizard and dialog loading
* Moving apis to proposed
* fixing namespace
* Only firing event when the value changes
* Only firing when value is changed
* Adding loading complete message to dialog and wizard
* Registering listeners and making a new base interface for loading components
* Fixing api comment
* Renaming prop to loadingCompleted
* old loading icon
* hide publish to new Azure server under preview setting
* try adding additional properties instead of replacing everything in configuration
* cleanup and change to adding configuration properties instead of replacing the whole thing
* add more info in comment
* remove extra line
* Vbump and update dependent ADS version (#21179)
* [SQL Migration] Add new Azure Core API changes back in to support USGov + other non-public clouds (#20476)
* WIP - show error message for failed SKU recommendation
* WIP - run query to get correct instance name
* WIP - integrate elastic model recommendation
* Remove private endpoint restriction text
* Add feature switch for elastic recommendation
* Clean up
* Clean up
* Misc UI fixes
* Update package.json with updated azdata dependency
* Remove unused lines
* Fix broken next button
* Vbump extension to 1.0.6
* Revert "[SQL Migration] Revert dependency on new Azure Core API changes (#20469)"
This reverts commit b7a633be25.
* [SQL Migration] Add additional condition for cutover (#21178)
* Add new cutover condition
* Implement helper hasRestoreBlockingReason()
* update the default Microsoft.Build.Sql version used by sql projects
* update Microsoft.Build.Sql SDK version
* update baselines and template to also use 0.1.7-preview
* Extension unit tests continue on error
* Fix script syntax issue.
* Block syntax issue
* Remove condition expression
* Brings back condition for sql product build linux yml
* Comment out condition in ci.yml
* Adds continue on error clause to ci.yml extension unit tests
* Adds condition to extension unit tests step in ci.yml
* Adds run extension unit test case for fail on error
* Adds fail on error case to Run Extension Unit Tests script
* Explicitly states continue on error false.
* Format adjustment to yml file
* Changes default state to fail on error
* Update .github/workflows/ci.yml
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Update build/azure-pipelines/linux/sql-product-build-linux.yml
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Update build/azure-pipelines/linux/sql-product-build-linux.yml
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Brings back original comment.
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Adding column resize keyboard shortcuts in slickgrid
* Switching to standard keyboard evt
* Adding comment for the functionality
* Cleaning up code and adding more comments
* Using quick input to get column resize width
* Adding check for negative sizes
* Fixing some stuff
* added loading status to tree elements during refresh
* added message
* added lambda function
* added async
* moved addtraits to below null check
* Added debug lines for now
* added wip stack
* moved loading icon logic to inside tree item code
* added dispose logic
* Added comment explaining actions
* removed reference to NodeJs Timeout
* added showLoading status to Tree creation utils
* fixed spaces
* removed unnecessary space
* removed unnecessary timer for more responsive results
* removed call in connectionTreeActions test
* added fix to test
* stick to refresh only
* added 100 ms timeout
* added request comment
* Add TrustServerCertificate to request body
* Preselect all dbs for migration
* Make disabled checkbox not auto selected
* Clarify assessment results in card
* Fix incorrect number of dbs ready for migration without issues to MI
* Fix SQL DB assessment results incorrectly greying out dbs with MI blocking issues
* Revert "Clarify assessment results in card"
This reverts commit e8b83f3c19a20ba29133aaa68c4644b04d4154fe.
* Revert "Fix incorrect number of dbs ready for migration without issues to MI"
This reverts commit d4e10875d132dd218d95be91ae7d46672e247706.
* Revert "Fix SQL DB assessment results incorrectly greying out dbs with MI blocking issues"
This reverts commit e2a7dcd7352d1c215052a2f6f3f6130fc710eff8.
* Add new fields
* Fix null reference exception in SKU rec with save and close
* Remove unused files
* Warnings for in progress migrations in list view
* Fix unscrollable assessment results
* Fix updating SKU parameters before recommendations are ready
* Remove checksum info box
* Address PR feedback
* Update test naming convention from Electron to Core to avoid confusions
* Added comments
* Fix comment placement
* Remove CARBON EDIT from sql-* files
* Give saveAsExcel its own config options
* Wired up correctly
* Merge conflicts
* PR comments 1
Co-authored-by: Ben Russell <russellben@microsoft.com>
* add import permissions option to create project from db dialog
* change 'import' to 'include'
* update azdata dependency version
* update STS to 4.3.0.37
* fix test
* Adds context menu option placeholder plan container
* Adds context menu and button to add execution plan to placeholder
* Minor clean up
* Replaces taskbar with button to add execution plans
* Removes unneeded CSS styling.
* Adjusts button type to secondary
* Clarify assessment results in card
* Fix incorrect number of dbs ready for migration without issues to MI
* Fix SQL DB assessment results incorrectly greying out dbs with MI blocking issues
* Update error banner for blocked databases
* Reword error message
* Boilerplate for new context menu options
* Enables checkmarks for expensive operator context menu actions
* Updates azdataGraph version to 0.0.44
* Adds clearing logic to actions and retrieves additional info from nodes
* Removes unnecessary actions that aren't supported by other providers
* Finishes setting up the rest of the context menu actions
* Corrects context menu action label
* Defines new widget type for finding expensive operations
* Adds TODO for class icon name
* Creates action to open the expensive operation widget
* Adds escape and enter key shortcuts to findExpensiveOperation widget
* Styles find expensive operation widget
* Corrects class name for finding expensive operator action
* Corrects import statement.
* Code clean up
* Bumps azdataGraph version to 0.0.45
* Adds an info box for when a metric doesn't find any nodes
* Adds label to find expensive operator widget
* Invokes dispose when widget controller removes widget
* Implements disposable in all execution plan widgets.
* Adds off action to clear highlighting
* Adds a default setting and default prompt for highlighting metric
* Fixes not all code paths return error
* Removes shortcut key from text for widget actions
* Adds enum description
* Removes added dictionary type, and renames class name
* Removes unnecessary null checks
* Removes cost metric dictionary and adds corresponding properties
* Code review changes
* Removes incorrectly implemented key down event for widget.
* Renames widget and action class names for highlighting expensive ops
* File rename
* Cleans up labels to better reflect highlight action
* Removes hardcoded button width style and sets it to auto
* More clean up
* Clean up import statement
* Code review changes
* Drop down list only shows available metrics
* Updates highlight expensive operation icon
* Update STS version
* initial
* Fix and revert secret storage changes
* persist to file
* Add debounce and write on dispose
* Fix run
* No ext dependencies and show warning message
* Remove test stuff
* comments
* Fix tests and console logs
* allow mark tests as unstable
* fix
* fix invert
* stable and whole test suite
* docs and mark test cases as unstable
* a couple more unstable test cases
* Fixes incorrect label when plans are vertical
* Code review changes.
* Adds helper methods to get localized strings
* Helper functions moved to module level
* Renames fields from top and bottom to primary and secondary
* Set target platform for mssql vscode extension- create project from db feature
* Addressed comments
* Address comment to add EngineEdition information in vscode-mssql.d.ts
* add logging for data workspace extension
* Addressing comments
* adding back getProjectsInWorkspace() in constructor
* Add more logging in activate()
* Added username field to PG and removed defaultvalue for port
* Disabled system username for miaa. Added username to pg create notebook.
* Block system for pg username
* Remove sql username from pg create
* Add service type
* bump version for preview
* Add dev use label
* Changed postgres icon
* Fixed PG create page not displaying. Wrong type
* Fixed service type
* changed naming for admin usernames sql and pg
* sql and pg dev use fix
* Move port under service type and make storage class not required
* Fixed regex to include things like sa1 system1
* Made storage class params optional
* Added placeholder text and changed PG admin username label
* Remove backups
* Removed postgres hardcoded username in connectionstring
* Remove more postgres username hardcoded
Co-authored-by: Candice Ye <canye@microsoft.com>
* fixing icons for new ledger object SubTypes
* removing irrelevant context menu options from ledger objects in OE
* aligning LedgerDropped subtype context key specifically with the Table NodeType context key
* download Microsoft.Build.Sql sdk and extract
* cleanup extracted folder and nuget
* add constants
* cleanup
* remove package-lock.json
* making outputChannel required and some cleanup
* only download if the files aren't already there
* Add todo
* add try catches
* addressing comments
* WIP - show error message for failed SKU recommendation
* WIP - run query to get correct instance name
* WIP - integrate elastic model recommendation
* Remove private endpoint restriction text
* Add feature switch for elastic recommendation
* Clean up
* Clean up
* Misc UI fixes
* Update package.json with updated azdata dependency
* Remove unused lines
* Fix broken next button
* Vbump extension to 1.0.6
* Update SQL DB card to show number of recommendations for correct model
* Hard code enginer ver to 14 and remove extension from wizard field and notebook
* Removed hyperscale text from everywhere but links
* Made PostgreSQL into PostgreSQL server and other text changes. Removed worker nodes
* Removed coordinator node text
* Removed worker nodes from compute + storage. Changed az arc-server to server-arc. postgresParameters.ts may need
* Removed tabs for extensions, coord nodes, worker nodes, resource health, diagnose and solve
* Removed node configuation and pg version from overview and properties. Edited arialabels
* Change server group nodes to server
* Removed type from overview table and aded Preview tags
* Removed info bubble and added padding to top of title
* Removed checkbox from PG create wizard. Added link and text
* Remove engine version
* Changed naming conventions
* Removed coord and server group from variables
* Removed properties
* Removed Server table, admin username, reset password
* Removed function from notebook
* Change wording
* bump version
Co-authored-by: Candice Ye <canye@microsoft.com>
* Revert "Revert "Fix sql projects not using OutputPath in sqlproj for publishing (#19987)" (#20127)"
This reverts commit dc7522c661.
* read configuration from sqlproj
* Add more tests
* use last OutputPath in sqlproj
* Remove references to getProviderMetadataForAccount
* Fix broken next button
* Clean up
* Adding to other PR instead - Revert "Clean up"
This reverts commit 410e136c0d1dcc24b38697791801fe3b90b1ecd4.
* Adding to other PR instead - Revert "Fix broken next button"
This reverts commit 748f75daf1594694e618f946c8026cb3256c58a9.
* sql db wizard with target selection
* add database table selection
* add sqldb to service and IR page
* Code complete
* navigation bug fixes
* fix target db selection
* improve sqldb error and status reporting
* fix error count bug
* remove table status inference
* address review feedback
* update resource strings and content
* fix migraton status string, use localized value
* fix ux navigation issues
* fix back/fwd w/o changes from changing data
* Add correct host to ARM REST API calls
* Clean up
* Missed a spot
* One more comment
* Expose new function getProviderMetadataForAccount in azurecore API
* Adding a loader spinner before the options load
* removing the local var and using const
* Reducing delay between button click and loader visibility,
* Max for syncsecondary. Fix syncsecondary update.
* Update the value not the placeholder for SQL MIAA
* Disable save toolbar icon after save/update complete
Co-authored-by: Candice Ye <canye@microsoft.com>
* Re-enabled config for direct mode
* Changed name and placement
* Shortened description
* Remove pg and sql as categories for DC
Co-authored-by: Candice Ye <canye@microsoft.com>
* Include Object Types logic refactored and options fetching from DacFx
* Removed localized object types constants
* Prop name updated and references and tests updated
* updated comments
* STS vBump
* updating the test file to pass the PR Validations
* Include Objects Coming from DacFx and tests all working as expected
* Exclude Object types functionality is working as expected and Unit tests
* more refactor updates
* Updated comments and prop name
* Addressing the coments and code updates accordingly
* Updating according to the comments
* STS vbump
* These changes should be deleted with SC changes, not here
* format fixed
* options loading from profile if has profile loaded
* Removing profile file unwanted changes
* updating profiles options comment
* STS vBump
* revert STS version from this PR
* Made SQL MIAA a new tile from New Deployment
* Remove MIAA from SQL tile. Fix helptext for MIAA tile.
* Switched positions of sql miaa and pg tiles. Made New Instance have miaa instead of sql tile.
Co-authored-by: Candice Ye <canye@microsoft.com>
* refresh does not differentiate direct vs indirect
* For direct mode MIAA commands, always use --use-k8s
* Changed comment language to use ARM instead of direct and K8S API instead of indirect
Co-authored-by: Candice Ye <canye@microsoft.com>
* Adds find node button to comparison plans.
* Can search multiple nodes (improve widget UI and initialization)
* Adjusts how second plan is added to the node search widget
* Adds styling to the find node action bar
* Removes unused code
* Minor clean up
* Cleans up CSS redundancy
* Adjusts property names according to access specifiers
* Corrects find node behavior to match SSMS
* Dependency injects instantiation service
* Adds additional property to telemetry event.
* Adds undefined to getter return signatures for plans
* Adds checks around active execution plan properties
* Code review change
* Code review changes
* dropdown not supporting dynamic enablement
* paused for weekend
* Make connection mode display with capitalization but value lowercase
* Undo changes in modelviewutils
Co-authored-by: Candice Ye <canye@microsoft.com>
* If no agreements item, then do not generate an Accept Terms of Use title. Remove sql miaa agreement.
* Added back the arc-specific change
* Added back nls
Co-authored-by: Candice Ye <canye@microsoft.com>
* Update azdataGraph version to 0.0.31
* Adds icons
* Bumps azdataGraph version to 0.0.32
* Removes whitespace
* Uses icon that better adapts to color theme changes.
* Disables collapse for execution plans in plan comparison editor view
* Made kube config and context dependent on direct mode
* Make config profile a dropdown
* Re enabled config profile
Co-authored-by: Candice Ye <canye@microsoft.com>
* OptionsDialog and buttons CSS styling updates
* final css changes for sql db options tab
* modified options button into itmes list
* updated tab name
* Added removed line git blame
* OptionsMapTable logic to replace the deployment hardcoded values final
* Test modifiaction
* OptionsMApTable updates with STS and review commetns
* comments added and option string moved to constants file
* Reverting the options button css related change and will put in other PR
* converted optionsMapTable to custom type and references.
* Options prop changes and model updates
* Reset btn event method name fixed
* removed local booleanOptionDict var and using the existing one
* updated code with removed local vars
* Update to booleanOptionsDictionary name
* merged two variable to one
* Refactoring code and updating variables
* separated lookup and data array and refactor
* missing visibility
* reset logic revised and no other edgecases found
* variable names updated to meaningful
* vbump here to test the checks, sending new vbump PR separately
* Updates properties view title when the orientation changes
* Property orientation labels change when the plan orientation changes.
* Renames top and bottom containers to secondary and primary
* Minor clean up
* Removes unnecessary class members
* Promotes constants to module level
* Moves function to module level
* Renames value1 and value2 to primary and secondary
* Replaces orientation string literal type with enum
* Resolves undefined orientation bug
* Removes unused orientation getter
* Updates property table columns only
* Uses orientation enum in editor view and properties view
* Clean up
* Adding top operations to execution plans
* Adding title to links
* Fixing pr comments
* Hiding top operations icon in execution plan editor
* Reducing outline width, adding separator and removing placeholder text
* Registering TopOperationsTabView
* Added label description for RWX storage class
* Added link and description above backups
* Made field have no default value by making it plain textfield
* Made label width wider to accomodate long labels
* Better spacing for RWX. Fixed info bubble overlap
Co-authored-by: Candice Ye <canye@microsoft.com>
* Switch query events to just send ranges instead of full query text
* undo azdata changes
* fix type
* comment + remove unneeded ?
* range -> batchRanges
* undo
* Changed namespace to have empty default value. Added cluster name as a field for direct mode. Updated summary page and notebook as necessary.
* Made storage class = default if storage class is undefined
* Moved cluster name before custom location
Co-authored-by: Candice Ye <canye@microsoft.com>
* Ctrl/Cmd + m, no longer executes queries.
* Adjusts command label
* Code review changes
* Uses category parameter to categorize actual plan command
* Actual execution plan command label matches estimated plan command label
* Revert "Actual execution plan command label matches estimated plan command label"
This reverts commit 15f301dfc64341d631ca5e9b1314d8cf739b2088.
* Centralizes localized category string (#19857)
* Actual Plan action uses centralized category
Didn't notice that this had already been bumped from what was listed in the gallery (0.1.0 currently). So reverting back to 0.2.0 until after the next version is released.
* Commenting out for now, but will delete in next commit
* Adds SQL carbon edit markers
* Uses multiline comments
* Formats file
* Code review changes
* Edit comment moved to same line
* Add ts-ignore directive to unused method
* Fixing tabbing logic for tab headers
* Renaming stuff
Making null checks concise
Adding comments
* Renaming css class and interfaces from active to selected
* Renaming styling classes and objects
* Changing tabbing logic to match w3 behavior
* Fixing focus logic in tab
* Adding helper comment
* Code cleanup
* Adding arialive to flex and div container
* Fixing compilation issues
* Moving ariaLive to container properties
* fixes
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Added syncSecondaryToCommit to SQL update and create, as well as notebook, wizard, and compute+storage interfaces
* Added readable secondaries and syncSecondaryToCommit to cost and SQL MI create
* Added readable secondaries to notebook
* removed resource-deployment changes
Co-authored-by: Candice Ye <canye@microsoft.com>
* Fixed dynamic enablement
* Set to false or original logic in constructor
* Changed boolean to also undefined
* Moved comment to constructor
Co-authored-by: Candice Ye <canye@microsoft.com>
* Creates toggle button to switch between estimate and actual query plans
* Renames ID for the toggleActualExecutionPlanModeAction class
* Renames button back to explain
* Creating actual execution plans resembles SSMS
* Adds CTRL/CMD + L shortcut to display estimated execution plans
* Alphabetically organizes telemetry actions
* Adds telemetry when the setting for actual execution plan toggle is used
* Resolves build errors
* Fixes broken unit tests.
* Code review changes
* Removes unnecessary null-coalescing operator.
* Creates placeholder icons for actual execution plans enabled
* Code review changes
* Shortens label names
* Telemetry moved to toggle button
* Telemetry review changes
* Clarifies misleading label
* added filter for AsyncDataProvider Filter crash
* fixed cell switch back for editdata
* Added new setData check
* disable selecting of all columns when new row is being added
* Changed comment
* removed try catch check due to Aasim's PR
* added previous dataset to handlechange
* added feedback changes
* added fix for infinite loop
* changes made as suggested by Alan
* following Charles' feedback
* removed onGridRendered as its pointless jumping
* initilaizing the sqlproj display options work
* added more code to the options dialog, need default option values
* Except REset Button, all works and need to refactor and test
* DisplayOptions for SQL DB Proj completed, refactor needed
* Tests for display options
* refactor code and removed unnecessary await calls
* Description values getting from STS API and code refactor
* DacpacExtesnion test model error fix
* updates related to STS model updates
* Dac Deployement options model updates according to STS changes
* Undoing file updates and moving as separate PR
* Undoing vscode whitespace changes which were added accidentally
* Options display name coming from API
* Updated model with dac deploy options display names coming from the STS API
* errors fixed after merge to main
* separating model related changes after merge, separate PR exists
* wrong Comment for the test case removed
* code refactor updates
* Hyperlink changes to secondary button and style updates
* refactoring code and comments
* importing type only instead of whole azdata and comment updates
* projectcontroller test fix
* removed duplicate file updates from other PR
* code refactor according to comments
* Added dispose to the onclick handler
* Added test case
* parameter change results error and fixed
* Addressing all comments with updates
* Unused variable removed and missed with previous commit
* Updated the ppublish button and width
* Adjusted the database dropdown and options margins to make all input align in same line
* Updated the database width and moved stylings to uiconstants file
* Introduce tabs for notebook views
Cards have been restructured to contain tabs instead of cells directly.
Tabs then contain the cards that are displayed. Cards may contain one or
more cards.
The panel component has been reused to implement the cells. There is
still some cleanup left to do of unused functions, but I want to reduce
the size of the PR as much as possible.
* Adds telemetry when plan comparison is invoked
* Small formatting change.
* Adds telemetry to add execution plan button
* Removes unused ExecutionPlanComparisonEditorView constructor parameters
* Small formatting adjustment
* Adds telemetry to ExecutionPlanComparisonEditorView properties
* Code review changes
* add 'open in designer' to context menu of tables in sql projects
* fix tests
* Address comments
* enable table designer for sql database proj
* update label and issues on init
* vbump sts
* use promisified fs
* pr comments
Co-authored-by: Alan Ren <alanren@microsoft.com>
* fix page being reset twice and add back smoke test
* add missing await
* check pyarrow info loaded
* install latest package version
* fix version select box selector
* split out into two PRs
* Dac Deployement options model updates according to STS changes
* Undoing vscode whitespace changes which were added accidentally
* Updated model with dac deploy options display names coming from the STS API
* Combining all exisitng code updates into single branch/pr. it includes mssql model updates and SC/dacpac model, code and testupdates
* sql db proj test failure fix
* STS version bump to 4.0.0.4
* Adding code for execution plan comparison editor
* Handling floating promises and fixing a loc string
* Fixing some polygon stuff
* Fixing azdatagraph null check bug
* Adding progress notification for similar areas
* Removing some floating promises
* Fixing button enabled state
* Bump version of arc and azcli to 1.3.0
* Fixed refresh to do dc config show and endpoint list first, then check the connectionmode
* Await calls to refresh indirect and direct
* Made sql mi-arc delete also handle direct mode. Made customlocation for sql mi create work again, regex problem.
Co-authored-by: Candice Ye <canye@microsoft.com>
* Display cdb nodes to browse azure tree
* Update icons
* Update node label
* Remove console logs
* Fix i18n in cosmosDbMongoTreeDataProvider
* Disable Mongo provider in azure tree for now
* Revert "Disable Mongo provider in azure tree for now"
This reverts commit 8b2d2079f43624596a41b82a71a5e40eef1ad4b1.
* Fix build issues related to merge
* Add COSMOSDB_MONGO in provider extension map
* Define providerId string as constant. Rename constants to follow azurecore/ naming conventions (all caps)
* remove password enter manually - since we prompt user to include it prior
* go back to connection profile prompt
* add manual entry if connection info password is not saved
* add tests that verify all password prompt scenarios
* nit
* first wip for table menu prompt
* fix up some table prompts
* use simpleExecuteRequest
* fix table prompt scenario for sql binding also
* fix/add more testing and address comments
* add brackets to selected database
* add manually entered option
* added clickable more info links to designer validation issues
* fix selection issue
* remove more info if none
* change quote style
* clear the dom node
* format
* added buttons and initial drag plugin
* initial drag and drop working
* add actions and taskbar
* drag and drop bugfix and other changes
* fix few issues
* more changes
* fix all move and insertion issues
* PRcomments
* fit and finish comments
* remove dead code
* bump sts
* add style for object being dragged
* add plugin to copyright filter
* Add to eslintrc
* fix drag contrast ratio
* generalize logic for cell focus
* demo feedback
* feedback
* add action state
* feedback
* remove unncecessary check
* add move actions to context menu
* change to const
* fix bug with tables and fix drop color
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* Rebase from main branch
* Made mssql a module
* remove rpc specific stuff
* Added create sas RPC call
* Backup to url works now
* Moved createSas RPC to the BlobService
* Relocated createSas RPC from sql-dataprotocolclient to the mssql
* After rebase
* Removed duplicate symbol
* Renamed Blob to AzureBlob and relocated CreateSasResponse to mssql extension
* Removed AzureBlobProvider, removed AzureBlobService feature
* renamed blob to azureblob, converted thenable to promise
* Simplify API
* fixes
* docs update, blob to azureblob update
* UI design first commit
* Detected Managed Instance, trying to script backup to url
* azure subscription api added, but ADS crashes
* Created url dialog component and added link account
* Changed backup component UI logic
* Changed b/r UI, added restore from URL, detected MI from restore component
* Removed mocked and added real Azure API, changed RestoreDialog UI
* Added file fetching API
* added create sas RPC call
* Backup to url works now
* Fixed some bugs
* Moved createSas RPC to the BlobService
* Relocated createSas RPC from sql-dataprotocolclient to the mssql
* Rebase createSas changed to the backupRestoreManagedInstance
* PR comments fix
* Enabled backup to url for gov clouds
* Replaced anchor element with Link class
* Fixed pick azure account logic
* Removed duplicates from eslintrc
* Fixed url browser dialog
* Fixed restore UI, disabled url empty url browser dropdowns, fixed backup OK button
* bumped sts version
* bumped sts version
* Fix config
* Fixed URL browser dialog UX
* Backup and restore dialog fix
* Referencing azure resource types directly
* Scoped url browser dialog css classes
* Made the url browser dialog field a local variable
* moved url browser files from fileBrowser to the urlBrowser folder
* Changed deviceType from number to enum
* Added all device type options
* Moved mssql
* Added MI backup button comment
* Removed unhelpful comment
* Revert differential copy only backup mistake
* Renamed azurebrowser to urlBrowserDialog
* Localize create sas button label
* Removed unnecessary spinner
* Use UTC date instead of locale date
* Removed * and added required flag
* Use async instead of nested thens
* Added target database tooltip
* Using deferred promise instead of event emitter
* Added error handling to the url browser dialog
* Registered backup component elements
* Register backup component listeners
* Removed redundant setDefaultBackupPaths call
* Added setBackupPathList docs
* Add return types
* Remove code from comment
* Register restore dialog elements
* Register restore dialog listeners
* Pass engine edition enum instead of boolean
* Capitalize enum values
* DatabaseEngineEdition fix
* Use DeviceType instead of number
* Use deferred pointer
* Add new ModalDialogName
* Use constructor fields
* Register URL browser dialog components
* Remove unnecessary helper function
* nextYear function doc and move
* split registerListeners method
* showDialog returns promise
* Backup device type comment
* Pass aria label through constructor
* Fix backup button
* Remove comment
* Comment unsupported MI backup options
* Remove one liner helper function
* Restore dialog methods return types
* Remove comment
* JS doc format
* Renamed UrlBrowserDialog to BackupRestoreUrlBrowserDialog
* Moved MediaDeviceType, added PhisicalDeviceType
* Reorder and rename physical device type
* remove extra spaces
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* Adding ability to expand and columns tables
* Bolding icons
Fixing variable names
* Adding helper function
Making css more target
* Adding keyboard navigation and parsing treegrid data
* Adding attributes, data transformations and key events to the treegrid
* Expanded
* changing var name
* FIxing formatter name
* Adding back cell styling
* Removing comments
* Making a new TreeGrid component.
Separating treegrid logic from tableDataView
* Fixing comments
* changing method name
* Modifying only visible row dom attributes
* Removing white space, moving role attribute setter to constructor.
* Fixing some more PR comments
* Adding comments and renaming functions
* Fixing comments
* Fixing comments
* Fixing comments
* Fixing some logic and removing unused attributes from element
* Adding expandable formatter to the first column
* Making the formatter generic
* Reverting formatter code
* Adding doc comments
* Fixing comments
* Removing duplicated code
* Adding comments
* Setting columns only when the table is initialized
* Letting users set expanded state instead of forcing it to false
* Added sql upgrade management page and fixed icon for dc and sql upgrade
* Added logic for figuring out MIAA version, loading proper entries for table.
* Added PR comment changes
Co-authored-by: Candice Ye <canye@microsoft.com>
* Adds hot key combination for finding nodes in execution plans.
* Captures cmd + f key combinations for other platforms
* Stops event propagation when targeted hot key sequence is pressed
* add tab index to cell output
* add sr-only element to announce cell exe complete
* use onExecutionComplete event
* remove extra change
* simplify alert message
* add alert for cell execution start
* make sure cell is ran
* make sure dialog is gone before runing cell again
* ensure package is done installing
* show task panel
* remove comment
* pr comments
* pr comments
* add 7.0.0 package version
* Resolves cannot read property 'accessToken' of undefined.
* Checks for and specifies undefined as refreshToken return type
* Adds documentation and checks for undefined results from refreshToken
* WIP
* WIP
* WIP
* Fix location dropdown not working properly
* Clean up comments
* Switch button order in selectMigrationServiceDialog
* Vbump to 1.0.1
* Refactor to avoid duplicate API calls
* Add null checks
* Fix migration status dialog not sorting migrations properly
* Address comments, remove unnecessary code
* Address comments - separate util methods by resource type, use logError instead of console.log
* Remove unused methods
* Fix DMS creation on newly created resource group
* Fix stale account behavior
* Address comments - remove telemetry context from util method calls
* Clean up imports
* Fix dashboard service monitoring not working
* Fix null reference on database backup page, and resources not updating properly when location is changed
* Fix dashboard not auto selecting DMS after migration started
* Add null checks
* Added sqlmiaa upgrade command and params to azcli api
* Put params under args
* Removed an extra comma
Co-authored-by: Candice Ye <canye@microsoft.com>
* initial refactor
* fix projectFolder cases
* update create azure function with sql binding when no folder is opened
* corner case exit browse file
* add version since targetFramework is set to specific core tools version
* update telemetry and address comments
* use project folder instead
* fix create project from database when launched from disconnected node
* don't open dashboard
* fix tests
* update order so connection dialog opens first if can't connect
* Rebase from main branch
* Made mssql a module
* remove rpc specific stuff
* Added create sas RPC call
* Backup to url works now
* Moved createSas RPC to the BlobService
* Relocated createSas RPC from sql-dataprotocolclient to the mssql
* After rebase
* Removed duplicate symbol
* Renamed Blob to AzureBlob and relocated CreateSasResponse to mssql extension
* Removed AzureBlobProvider, removed AzureBlobService feature
* renamed blob to azureblob, converted thenable to promise
* Simplify API
* fixes
* docs update, blob to azureblob update
* bumped sts version
* Fix config
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* Removed configure retention policy link. Log errors for upgrade instead of blocking the upgrade. Changed text of version log link.
* Addressing comments on PR
Co-authored-by: Candice Ye <canye@microsoft.com>
* Fixed a connect to Server typo
* Added upgrade tab with description and title. Table is still stuck loading.
* Renamed backups to upgrades.
* Removed loading icon
* Table appearing and not stuck loading
* Saving for now to upgrade arc and azcli versions
* Added upgrade confirmation dialog, populated dummy data and added upgrade apis.
* Added parsing of versions and current version from listupgrades
* Upgrade itself not working, but added upgrade as a part of azure cli api.
* Table now populating with release dates and version numbers. Upgrade button only shows for appropriate cells. Upgrade done but no release version column.
* Changed text using PM advice
* Removed comments from controllerUpgrades.ts
* Replaced code in upgradecontroller.ts and made refresh work
* Removed one call to handleTablesUpdated
* Removed some code in upgradeControllers.ts and it still works
* removing more code for pitr refresh from upgradeController.ts
* Created and used UpgradeModel even though it is empty
* Added upgrademodel
* PR comments addressed
Co-authored-by: Candice Ye <canye@microsoft.com>
* Add sqlproj property to trace the origin of the project.
As part of the database migration process (schema conversion, in particular) we want to be able to tell when converted schemas are being built/deployed to the actual database server. Given that we rely on the SQL Database Projects ADS extension for the compilation/deployment, we don't have too many options other than updating the said extension.
The suggested approach is to make the following changes:
1) Add new property to the sqlproj file (called `DatabaseSource`), which will maintain the origin(s) of the project. The property can contain multiple values (separated by semicolon), in case same project contains objects produced by multiple sources (extract schema, convert from another database, etc.).
2) During build and deploy actions, send the well-known values from the newly added property to the telemetry. We don't want to send any random value of the property, as it may raise some privacy concerns. Instead we define a list of the well-known values that we know do not carry any personal information and send those, if they are specified.
This change adds all necessary APIs to the SQl Database projects extension which will be consumed by our migration extensions to populate new `DatabaseSource` property.
* Use `undefined` instead of `null`
Co-authored-by: Kim Santiago <kisantia@microsoft.com>
* Fix SQL Binding when creating new project
* Use sql binding templates
* fix openDialog to use select
Co-authored-by: Vasu Bhog <vabhog@microsoft.com>
* Adds telemetry around how the properties window is opened
* Adds telemetry around accessing execution plan top operations
* Adds key for viewing top operations
* Adds telemetry around using the open query button and context menu item
* Adds telemetry around execution plan zoom in, out, to fit, and custom
* Adds telemetry around searching for nodes in execution plans
* Reduces telemetry additional properties to 1.
* Code review changes
* Removes unnecessary export
* fix connectionSettingName for create azure function with sql binding
* add sql binding user enters connection string manually
* address comments + fix test
* final comments
* Adding badge icons to executionplan
* Fixing doc comment
* Fixing doc comments
* Making enum value more readable
* Changing default to undefined.
* Fixing some icon names
* Add unified col for data type deit
* remove seperate type setting cols and rename unified col to 'type'
* remove advanced type from properties window
* add description to col, idx, constraints
* nit
* bump STS to .227
* listen on focus_in of toolbar
* update styles on focus_in
* listen for active cell change on notebook componen
* add tabbing order to textcells
* remove duplicate listener
* clean up
* undo
* remove visible check from cellToolbar
* remove duplicate detectChanges on updateActiveCell
* only update active cell if it's already not
* add aria-label for accessibility
* localize the aria label
* refactor
* add cellLabel property to CellModel
* remove updateActiveCell from code component
* regression from merge fix
* set edit mode as true when focusing on cell
* moce check to model
* merge changes correctly
* update edit mode if code cell
* fixes
Co-authored-by: barbaravaldez <bavaldez@microsoft.com>
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* fix for user using command palette command
* rework if a user uses the create azure function via the command
* for now only show in vs code
* move logic to azureFunctionService + address comments
* fix command location
* address comments
* fix validateFunction
* WIP - implemented logic to show resource groups as derived from list of resources, instead of directly listing all resource groups
* Remove comments
* Remove getResourceGroupByName and craft resource group object manually instead
* Update subscription and location list when tenant is changed
* Define Azure resource types locally instead of modifying azurecore
* Add SQL VM scenario
* Split getAzureResourceGroupDropdownValues into four separate functions
* Refresh only subscription list when tenant is changed
* Create new DMS dialog should show all resource groups
* Remove unnecessary async code
* add graph icons to OE and TD
* PR comments
* change enum type
* change sub type to icon and make basic as default
* changed icontype to icon
* change default logic location
* change icon name to be more generic
* use right icons
* added graph node types from edit and publish results
* make generic property bag
* review comments
* add comment for function
* edit comment
* change name to telemetry info
* add wizard page and selected operation for dacfx wizard cancel telemetry
* update name
* send version for extract
* pass version directly into function call
* Added monitor log-analytics workspace list to az api
* Made resource group and subscription optional for logs analytics workspace list
* Added dynamic fields for workspace names, id, primary key, based on value of auto-logs checkbox
* Hooked up the newly created source provider for log analytics workspaces. Dropdown now populates all workspace names.
* Added workspaceUtils.ts for a valueprovider. Now workspace name maps to id automatically.
* Replaced promise.all with promise.resolve
* Added workspace id and primary key as env variables in the notebook
* Removed extra space in package.json
* Made getOptions more concise and put azApi definition in function.
* Changed notebook to handle new Azure CLI command with param --clustername
* add more telemetry for sql database projects
* add publishToContainer events
* send target platform when publishing
* add duration for createProjectFromDb and updateProjectFromDb
* Pushing Execution Plan Editor
* Renaming class
Handling error
* Awaiting for handlers to be registered
* Addressing some PR comments
* Fixing return type for provider
* Fixing editor id and removing unnecessary overrides
* Adding a namespace
* adding execution plan namespace
* Adding protocol comment
* Fixing if logic
* Fixing error message
* Cleaning up code
* cleanup code
* Adding help comments
* Fixing method call
* Using path.ts to get the base file name
* converting to lambda functions
* Adding comment for run action
* Fixing pr comments
* Fixing editor label
* Fixing doc comments
* Adding some more comments
* Fixign branding in comments
* add step to choose target platform in new project quickpick
* add comment
* only splice if the default target platform index isn't -1
* change 3 to 5 in comment
* Add MI ready state check and error message
* Fix a typo
* Update error message logic
* Update '(Unavailable)' prefix to be localized string
* Show error messsage when non-Ready MI is initially selected (not just on Next button)
* Update error message with appropriate casing and actionable step
* wip for refactor of mssql to sql-bindings
* remove STS dependency
* work to bring function over and setup with vscodeMsql APIs
* copy typings from vscode-mssql
* WIP
* Change instance name from machine name to full instance name returned by assessment
* Get full instance name from source connection profile instead of relying on assessment result
* Combine correct machine name with correct instance name
* Making infobox clickable
* Making it accessible
* Moving API to proposed
* Matching styling from portal
* Fixing some styling
* Moving to proposed
* Removing extra spacing
* Registering and Unregistering listeners
* Fixing listeners
* Registering emitter only once.
* Changing emitter type from undefined to void
* Adding arialabel to clickable link
* Changing property name to suit its purpose
* add ability for md + text reports
* change report type
* re add types for ads
* match fields and add enum for mimetype
* rename preview report
* update type
* rename generate report type
* fix comment
* add loadSavedInfo function in stateMachine; only open wizard if didLoadSavedInfo
* * add loadSavedInfo function in stateMachine; only open wizard if didLoadSavedInfo
* replaced savedInfo.miggrationServiceId string with sqlMigrationServer object
* selectDatbasesFromList helper function to check previously selected dbs in dbSelectorPage and sqlDatabaseTree
* * remove savedInfo references from targetSelectionPage, migrationModePage
* add selectDefaultDropdownValue helper to stateMachine to handle unify savedInfo selection logic
* add updateDropdownLoadingStatus to targetSelectionPage
* check if values exist before making api calls in statemachine
* removed savedInfo references from databaseBackupPage, integrationRuntimePage
* databaseBackupPage - targetDatabaseNames, networkShares, blobs need to rely on savedInfo as user may update the list of migrationdbs during the retry/saveAndClose
* re-add serverAssessments to savedInfo; only getAssessments if it does not exist or needs to be updated; fix networkShare type savedInfo
* rename _assessmentDbs to _databasesForAssessment; _migrationDbs to _databasesForMigration
* load blobs/networkshares savedinfo; move selectDefaultDropdownValue to utils
* fix selectDefaultDropdownValue; refreshDatabaseBackupPage when user changes target subscription or location
* protocol handler - normalize paths
* use `extUri` for normalizing paths
* :lipstick;
* Add content security policy to top level webview
This change hardens our webviews by adding a fairly restrictive csp to them. This CSP should only apply to the outer webview iframe, not to the inner iframe which is controlled by extensions
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Matt Bierner <matb@microsoft.com>
* Fixed color contrast for error message in connect a dc window.
* Remove color check for error message
* Remove more unneeded checks
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Adding telemetry for errors happening during data collection/ telemetry for sku recommendation
* log and error happended during get sku recommendation
* Resolving comments from PR https://github.com/microsoft/azuredatastudio/pull/18252. 1) Adding click and close events to dispoable collection to avoid leaks. 2) Adding readable constant for number representing minutes.
* Changes - 1) updating migration workflow strings, 2) adding more onclick events to disposable collection.
* Remove PaaS, IaaS terms from string
* Changes -
1) Renamed 'Saved assessment result' to 'saved session'.
2) Removed Title from 'saved session' page.
3) Added stop data collection on migration start.
This repository includes configuration for a development container for working with Code - OSS in a local containeror using [GitHub Codespaces](https://github.com/features/codespaces).
This dev container includes configuration for a development container for working with Code - OSS in a local container. For using [GitHub Codespaces](https://github.com/features/codespaces) follow the [prebuilt setup](prebuilt/README.md) which installs VNC for displaying the application window.
> **Tip:** The default VNC password is `vscode`. The VNC server runs on port `5901` and a web client is available on port `6080`.
> **Note:** You will need X11's `DISPLAY` or Wayland's `WAYLAND_DISPLAY` environment variable set locally to allow for the Code - OSS window to display. See [Running GUI app on WSL](https://learn.microsoft.com/en-us/windows/wsl/tutorials/gui-apps) for Windows and [Quartz](https://www.xquartz.org) for Mac.
## Quick start - local
## Quick start
1. Install Docker Desktop or Docker for Linux on your local machine. (See [docs](https://aka.ms/vscode-remote/containers/getting-started) for additional details.)
2.**Important**: Docker needs at least **4 Cores and 6 GB of RAM (8 GB recommended)** to run a full build. If you are on macOS, or are using the old Hyper-V engine for Windows, update these values for Docker Desktop by right-clicking on the Docker status bar item and going to **Preferences/Settings > Resources > Advanced**.
2.**Important**: Docker needs at least **4 Cores and 8 GB of RAM** to run a full build with **9 GB of RAM** being recommended. If you are on macOS, or are using the old Hyper-V engine for Windows, update these values for Docker Desktop by right-clicking on the Docker status bar item and going to **Preferences/Settings > Resources > Advanced**.
> **Note:** The [Resource Monitor](https://marketplace.visualstudio.com/items?itemName=mutantdino.resourcemonitor) extension is included in the container so you can keep an eye on CPU/Memory in the status bar.
3. Install [Visual Studio Code Stable](https://code.visualstudio.com/) or [Insiders](https://code.visualstudio.com/insiders/) and the [Remote - Containers](https://aka.ms/vscode-remote/download/containers) extension.
3. Install [Visual Studio Code Stable](https://code.visualstudio.com/) or [Insiders](https://code.visualstudio.com/insiders/) and the [Dev Containers](https://aka.ms/vscode-remote/download/containers) extension.


> **Note:** The Remote - Containers extension requires the Visual Studio Code distribution of Code - OSS. See the [FAQ](https://aka.ms/vscode-remote/faq/license) for details.
> **Note:** The Dev Containers extension requires the Visual Studio Code distribution of Code - OSS. See the [FAQ](https://aka.ms/vscode-remote/faq/license) for details.
4.Press <kbd>Ctrl/Cmd</kbd> + <kbd>Shift</kbd> + <kbd>P</kbd> or <kbd>F1</kbd> and select **Remote-Containers: Clone Repository in Container Volume...**.
> **Tip:** While you can use your local source tree instead, operations like `yarn install` can be slow on macOS or when using the Hyper-V engine on Windows. We recommend the "clone repository in container" approach instead since it uses "named volume" rather than the local filesystem.
5. Type `https://github.com/microsoft/vscode` (or a branch or PR URL) in the input box and press <kbd>Enter</kbd>.
6. After the container is running, open a web browser and go to [http://localhost:6080](http://localhost:6080), or use a [VNC Viewer](https://www.realvnc.com/en/connect/download/viewer/) to connect to `localhost:5901` and enter `vscode` as the password.
Anything you start in VS Code, or the integrated terminal, will appear here.
Next: **[Try it out!](#try-it)**
## Quick start - GitHub Codespaces
1. From the [microsoft/vscode GitHub repository](https://github.com/microsoft/vscode), click on the **Code** dropdown, select **Open with Codespaces**, and then click on **New codespace**. If prompted, select the **Standard** machine size (which is also the default).
> **Note:** You will not see these options within GitHub if you are not in the Codespaces beta.
2. After the codespace is up and running in your browser, press <kbd>Ctrl/Cmd</kbd> + <kbd>Shift</kbd> + <kbd>P</kbd> or <kbd>F1</kbd> and select **Ports: Focus on Ports View**.
3. You should see **VNC web client (6080)** under in the list of ports. Select the line and click on the globe icon to open it in a browser tab.
> **Tip:** If you do not see the port, <kbd>Ctrl/Cmd</kbd> + <kbd>Shift</kbd> + <kbd>P</kbd> or <kbd>F1</kbd>, select **Forward a Port** and enter port `6080`.
4. In the new tab, you should see noVNC. Click **Connect** and enter `vscode` as the password.
Anything you start in VS Code, or the integrated terminal, will appear here.
Next: **[Try it out!](#try-it)**
### Using VS Code with GitHub Codespaces
You may see improved VNC responsiveness when accessing a codespace from VS Code client since you can use a [VNC Viewer](https://www.realvnc.com/en/connect/download/viewer/). Here's how to do it.
1. Install [Visual Studio Code Stable](https://code.visualstudio.com/) or [Insiders](https://code.visualstudio.com/insiders/) and the the [GitHub Codespaces extension](https://marketplace.visualstudio.com/items?itemName=GitHub.codespaces).
> **Note:** The GitHub Codespaces extension requires the Visual Studio Code distribution of Code - OSS.
2. After the VS Code is up and running, press <kbd>Ctrl/Cmd</kbd> + <kbd>Shift</kbd> + <kbd>P</kbd> or <kbd>F1</kbd>, choose **Codespaces: Create New Codespace**, and use the following settings:
-`microsoft/vscode` for the repository.
- Select any branch (e.g. **main**) - you select a different one later.
- Choose **Standard** (4-core, 8GB) as the size.
4. After you have connected to the codespace, you can use a [VNC Viewer](https://www.realvnc.com/en/connect/download/viewer/) to connect to `localhost:5901` and enter `vscode` as the password.
> **Tip:** You may also need change your VNC client's **Picture Quaility** setting to **High** to get a full color desktop.
5. Anything you start in VS Code, or the integrated terminal, will appear here.
4.Due to the size of the repository we strongly recommend cloning it on a Linux filesystem for better bind mount performance. On macOS we recommend using a Docker volume (press <kbd>F1</kbd> and select **Dev Containers: Clone Repository in Container Volume...**) and on Windows we recommend using a WSL folder:
- Make sure you are running a recent WSL version to get X11 and Wayland support.
- Use the WSL extension for VS Code to open the cloned folder in WSL.
- Press <kbd>F1</kbd> and select **Dev Containers: Reopen in Container**.
Next: **[Try it out!](#try-it)**
## Try it!
This container uses the [Fluxbox](http://fluxbox.org/) window manager to keep things lean. **Right-click on the desktop** to see menu options. It works with GNOME and GTK applications, so other tools can be installed if needed.
> **Note:** You can also set the resolution from the command line by typing `set-resolution`.
To start working with Code - OSS, follow these steps:
1. In your local VS Code client, open a terminal (<kbd>Ctrl/Cmd</kbd> + <kbd>Shift</kbd> + <kbd>\`</kbd>) and type the following commands:
@@ -84,18 +36,20 @@ To start working with Code - OSS, follow these steps:
bash scripts/code.sh
```
2. After the build is complete, open a web browser or a [VNC Viewer](https://www.realvnc.com/en/connect/download/viewer/) to connect to the desktop environment as described in the quick start and enter `vscode` as the password.
3. You should now see Code - OSS!
2. You should now see Code - OSS!
Next, let's try debugging.
1. Shut down Code - OSS by clicking the box in the upper right corner of the Code - OSS window through your browser or VNC viewer.
1. Shut down Code - OSS by clicking the box in the upper right corner of the Code - OSS window.
2. Go to your local VS Code client, and use the **Run / Debug** view to launch the **VS Code** configuration. (Typically the default, so you can likely just press <kbd>F5</kbd>).
> **Note:** If launching times out, you can increase the value of `timeout` in the "VS Code", "Attach Main Process", "Attach Extension Host", and "Attach to Shared Process" configurations in [launch.json](../.vscode/launch.json). However, running `scripts/code.sh` first will set up Electron which will usually solve timeout issues.
> **Note:** If launching times out, you can increase the value of `timeout` in the "VS Code", "Attach Main Process", "Attach Extension Host", and "Attach to Shared Process" configurations in [launch.json](../../.vscode/launch.json). However, running `scripts/code.sh` first will set up Electron which will usually solve timeout issues.
3. After a bit, Code - OSS will appear with the debugger attached!
Enjoy!
# Notes
The container comes with VS Code Insiders installed. To run it from an Integrated Terminal use `VSCODE_IPC_HOOK_CLI= /usr/bin/code-insiders .`.
# This dockerfile is used to build up from a base image to create an image with cached results of running "prepare.sh".
# Other image contents: https://github.com/microsoft/vscode-dev-containers/blob/master/repository-containers/images/github.com/microsoft/vscode/.devcontainer/base.Dockerfile
[](https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/microsoft/vscode)
This repository includes configuration for a development container for working with Code - OSS in a local container or using [GitHub Codespaces](https://github.com/features/codespaces).
> **Tip:** The default VNC password is `vscode`. The VNC server runs on port `5901` and a web client is available on port `6080`.
## Quick start - local
If you already have VS Code and Docker installed, you can click the badge above or [here](https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/microsoft/vscode) to get started. Clicking these links will cause VS Code to automatically install the Dev Containers extension if needed, clone the source code into a container volume, and spin up a dev container for use.
1. Install Docker Desktop or Docker for Linux on your local machine. (See [docs](https://aka.ms/vscode-remote/containers/getting-started) for additional details.)
2.**Important**: Docker needs at least **4 Cores and 8 GB of RAM** to run a full build with **9 GB of RAM** being recommended. If you are on macOS, or are using the old Hyper-V engine for Windows, update these values for Docker Desktop by right-clicking on the Docker status bar item and going to **Preferences/Settings > Resources > Advanced**.
> **Note:** The [Resource Monitor](https://marketplace.visualstudio.com/items?itemName=mutantdino.resourcemonitor) extension is included in the container so you can keep an eye on CPU/Memory in the status bar.
3. Install [Visual Studio Code Stable](https://code.visualstudio.com/) or [Insiders](https://code.visualstudio.com/insiders/) and the [Dev Containers](https://aka.ms/vscode-remote/download/containers) extension.

> **Note:** The Dev Containers extension requires the Visual Studio Code distribution of Code - OSS. See the [FAQ](https://aka.ms/vscode-remote/faq/license) for details.
4. Press <kbd>Ctrl/Cmd</kbd> + <kbd>Shift</kbd> + <kbd>P</kbd> or <kbd>F1</kbd> and select **Dev Containers: Clone Repository in Container Volume...**.
> **Tip:** While you can use your local source tree instead, operations like `yarn install` can be slow on macOS or when using the Hyper-V engine on Windows. We recommend the "clone repository in container" approach instead since it uses "named volume" rather than the local filesystem.
5. Type `https://github.com/microsoft/vscode` (or a branch or PR URL) in the input box and press <kbd>Enter</kbd>.
6. After the container is running, open a web browser and go to [http://localhost:6080](http://localhost:6080), or use a [VNC Viewer](https://www.realvnc.com/en/connect/download/viewer/) to connect to `localhost:5901` and enter `vscode` as the password.
Anything you start in VS Code, or the integrated terminal, will appear here.
Next: **[Try it out!](#try-it)**
## Quick start - GitHub Codespaces
1. From the [microsoft/vscode GitHub repository](https://github.com/microsoft/vscode), click on the **Code** dropdown, select **Open with Codespaces**, and then click on **New codespace**. If prompted, select the **Standard** machine size (which is also the default).
> **Note:** You will not see these options within GitHub if you are not in the Codespaces beta.
2. After the codespace is up and running in your browser, press <kbd>Ctrl/Cmd</kbd> + <kbd>Shift</kbd> + <kbd>P</kbd> or <kbd>F1</kbd> and select **Ports: Focus on Ports View**.
3. You should see **VNC web client (6080)** under in the list of ports. Select the line and click on the globe icon to open it in a browser tab.
> **Tip:** If you do not see the port, <kbd>Ctrl/Cmd</kbd> + <kbd>Shift</kbd> + <kbd>P</kbd> or <kbd>F1</kbd>, select **Forward a Port** and enter port `6080`.
4. In the new tab, you should see noVNC. Click **Connect** and enter `vscode` as the password.
Anything you start in VS Code, or the integrated terminal, will appear here.
Next: **[Try it out!](#try-it)**
### Using VS Code with GitHub Codespaces
You may see improved VNC responsiveness when accessing a codespace from VS Code client since you can use a [VNC Viewer](https://www.realvnc.com/en/connect/download/viewer/). Here's how to do it.
1. Install [Visual Studio Code Stable](https://code.visualstudio.com/) or [Insiders](https://code.visualstudio.com/insiders/) and the the [GitHub Codespaces extension](https://marketplace.visualstudio.com/items?itemName=GitHub.codespaces).
> **Note:** The GitHub Codespaces extension requires the Visual Studio Code distribution of Code - OSS.
2. After the VS Code is up and running, press <kbd>Ctrl/Cmd</kbd> + <kbd>Shift</kbd> + <kbd>P</kbd> or <kbd>F1</kbd>, choose **Codespaces: Create New Codespace**, and use the following settings:
-`microsoft/vscode` for the repository.
- Select any branch (e.g. **main**) - you can select a different one later.
- Choose **Standard** (4-core, 8GB) as the size.
4. After you have connected to the codespace, you can use a [VNC Viewer](https://www.realvnc.com/en/connect/download/viewer/) to connect to `localhost:5901` and enter `vscode` as the password.
> **Tip:** You may also need change your VNC client's **Picture Quality** setting to **High** to get a full color desktop.
5. Anything you start in VS Code, or the integrated terminal, will appear here.
Next: **[Try it out!](#try-it)**
## Try it!
This container uses the [Fluxbox](http://fluxbox.org/) window manager to keep things lean. **Right-click on the desktop** to see menu options. It works with GNOME and GTK applications, so other tools can be installed if needed.
> **Note:** You can also set the resolution from the command line by typing `set-resolution`.
To start working with Code - OSS, follow these steps:
1. In your local VS Code client, open a terminal (<kbd>Ctrl/Cmd</kbd> + <kbd>Shift</kbd> + <kbd>\`</kbd>) and type the following commands:
```bash
yarn install
bash scripts/code.sh
```
2. After the build is complete, open a web browser or a [VNC Viewer](https://www.realvnc.com/en/connect/download/viewer/) to connect to the desktop environment as described in the quick start and enter `vscode` as the password.
3. You should now see Code - OSS!
Next, let's try debugging.
1. Shut down Code - OSS by clicking the box in the upper right corner of the Code - OSS window through your browser or VNC viewer.
2. Go to your local VS Code client, and use the **Run / Debug** view to launch the **VS Code** configuration. (Typically the default, so you can likely just press <kbd>F5</kbd>).
> **Note:** If launching times out, you can increase the value of `timeout` in the "VS Code", "Attach Main Process", "Attach Extension Host", and "Attach to Shared Process" configurations in [launch.json](../../.vscode/launch.json). However, running `scripts/code.sh` first will set up Electron which will usually solve timeout issues.
3. After a bit, Code - OSS will appear with the debugger attached!
# This dockerfile is used to build up from a base image to create an image a cache.tar file containing the results of running "prepare.sh".
# Other image contents: https://github.com/microsoft/vscode-dev-containers/blob/master/repository-containers/images/github.com/microsoft/vscode/.devcontainer/base.Dockerfile
// FORKED FROM https://github.com/eslint/eslint/blob/b23ad0d789a909baf8d7c41a35bc53df932eaf30/lib/rules/no-unused-expressions.js
// and added support for `OptionalCallExpression`, see https://github.com/facebook/create-react-app/issues/8107 and https://github.com/eslint/eslint/issues/12642
/**
* @fileoverview Flag expressions in statement position that do not side effect
comment:'region comments should start with a camel case identifier, `:`, then either a GH issue link or owner, e.g #region myProposalName: https://github.com/microsoft/vscode/issues/<number>',
comment:"We need more info to debug your particular issue. If you could attach your logs to the issue (ensure no private data is in them), it would help us fix the issue much faster.
There are two types of logs to collect:
**Console Logs**
- Open Developer Tools (Help -> Toggle Developer Tools)
- Click the **Console** tab
- Click in the log area and select all text (CTRL+A)
- Save this text into a file named console.log and attach it to this issue.
**Application Logs**
- Open command palette (Click **View** -> **Command Palette**)
- Run the command: **`Developer: Open Logs Folder`**
- This will open the log folder locally. Please zip up this folder and attach it to the issue."
# actions for Out of Scope label
Out of Scope:
comment:"Thank you for opening this suggestion! This enhancement is not planned in our
medium-term roadmap. The issue is being closed to reduce active issues to focus on
enhancements that are being considered for an upcoming release. We will review closed issues
with the 'Out of Scope' label when doing long-term planning."
We need more info to debug your particular issue. If you could attach your logs to the issue (ensure no private data is in them), it would help us fix the issue much faster.
1. First open the Settings page, find the `Mssql: Tracing Level` setting and change that to `All` then restart Azure Data Studio.
2. Open command palette (Click **View** -> **Command Palette**) and run the command `Developer: Set Log Level...` and set the level to `Trace`.
3. Run the repro scenarios.
4. Collect the following logs:
**Console Logs**
- Open Developer Tools (Help -> Toggle Developer Tools)
- Click the **Console** tab
- Click in the log area and select all text (CTRL+A)
- Save this text into a file named console.log and attach it to this issue.
- Developer Tools can be closed via Help -> Toggle Developer Tools
**Application Logs**
- Open command palette (Click **View** -> **Command Palette**)
- Run the command: **`Developer: Open Logs Folder`**
- This will open the log folder locally. Please zip up this folder and attach it to the issue.
5. Now you can revert the Log/Tracing levels changes made in step 1 and step 2.
# actions for Needs Logs - Azure label
Needs Logs - Azure:
comment:|
We need more info to debug your Microsoft Entra ID issue. If you could attach your logs to the issue (ensure no private data is in them), it would help us fix the issue much faster.
- In the settings menu, find the setting titled `Azure: Logging Level` and select the `Verbose` option
- Restart Azure Data Studio
- Run the process that produces your error
- Open command palette (Click **View** -> **Command Palette**)
- Run the command: **`Developer: Open Logs Folder`**
- Follow this path to find the Azure Accounts log file: `[default log folder]/window1/exthost/output_logging_[earliest timestamp]/#-Azure Accounts.log`
- Please attach the Azure-Accounts.log file to the issue.
# actions for Out of Scope label
Out of Scope:
comment:"Thank you for your feedback! This feature is currently out of scope and we do not plan to work on it in a currently planned release. We will close this issue to keep our backlog focused on requests that we are planning to work on. Please note that users can continue to vote and comment on closed issues, which we encourage as it helps us understand user interest and can provide more details about why a feature is requested."
- name:Run Core Unit Tests# {{SQL CARBON EDIT}} Rename to core for clarity
id:electron-unit-tests
run:DISPLAY=:10 ./scripts/test.sh --runGlob "**/sql/**/*.test.js"# {{SQL CARBON EDIT}} Run only our tests with coverage. Disable for now since it's currently broken --coverage
"value": "### Categorizing Issues\n\nEach issue must have a type label. Most type labels are grey, some are yellow. Bugs are grey with a touch of red.",
"value": "## tl;dr: Triage Inbox\n\nAll inbox issues but not those that need more information. These issues need to be triaged, e.g assigned to a user or ask for more information",
"editable": true
"value": "## tl;dr: Triage Inbox\n\nAll inbox issues but not those that need more information. These issues need to be triaged, e.g assigned to a user or ask for more information"
},
{
"kind": 2,
"language": "github-issues",
"value": "$inbox -label:\"needs more info\"",
"editable": true
},
{
"kind": 1,
"language": "markdown",
"value": "##### `Config`: defines the inbox query",
"value": "New issues or pull requests submitted by the community are initially triaged by an [automatic classification bot](https://github.com/microsoft/vscode-github-triage-actions/tree/master/classifier-deep). Issues that the bot does not correctly triage are then triaged by a team member. The team rotates the inbox tracker on a weekly basis.\n\nA [mirror](https://github.com/JacksonKearl/testissues/issues) of the VS Code issue stream is available with details about how the bot classifies issues, including feature-area classifications and confidence ratings. Per-category confidence thresholds and feature-area ownership data is maintained in [.github/classifier.json](https://github.com/microsoft/vscode/blob/main/.github/classifier.json). \n\n💡 The bot is being run through a GitHub action that runs every 30 minutes. Give the bot the opportunity to classify an issue before doing it manually.\n\n### Inbox Tracking\n\nThe inbox tracker is responsible for the [global inbox](https://github.com/microsoft/vscode/issues?utf8=%E2%9C%93&q=is%3Aopen+no%3Aassignee+-label%3Afeature-request+-label%3Atestplan-item+-label%3Aplan-item) containing all **open issues and pull requests** that\n- are neither **feature requests** nor **test plan items** nor **plan items** and\n- have **no owner assignment**.\n\nThe **inbox tracker** may perform any step described in our [issue triaging documentation](https://github.com/microsoft/vscode/wiki/Issues-Triaging) but its main responsibility is to route issues to the actual feature area owner.\n\nFeature area owners track the **feature area inbox** containing all **open issues and pull requests** that\n- are personally assigned to them and are not assigned to any milestone\n- are labeled with their feature area label and are not assigned to any milestone.\nThis secondary triage may involve any of the steps described in our [issue triaging documentation](https://github.com/microsoft/vscode/wiki/Issues-Triaging) and results in a fully triaged or closed issue.\n\nThe [github triage extension](https://github.com/microsoft/vscode-github-triage-extension) can be used to assist with triaging — it provides a \"Command Palette\"-style list of triaging actions like assignment, labeling, and triggers for various bot actions.",
"editable": true
},
{
"kind": 1,
"language": "markdown",
"value": "## All Inbox Items\n\nAll issues that have no assignee and that have neither **feature requests** nor **test plan items** nor **plan items**.",
"editable": true
"value": "##### `Config`: defines the inbox query"
"value": "New issues or pull requests submitted by the community are initially triaged by an [automatic classification bot](https://github.com/microsoft/vscode-github-triage-actions/tree/master/classifier-deep). Issues that the bot does not correctly triage are then triaged by a team member. The team rotates the inbox tracker on a weekly basis.\n\nA [mirror](https://github.com/JacksonKearl/testissues/issues) of the VS Code issue stream is available with details about how the bot classifies issues, including feature-area classifications and confidence ratings. Per-category confidence thresholds and feature-area ownership data is maintained in [.github/classifier.json](https://github.com/microsoft/vscode/blob/main/.github/classifier.json). \n\n💡 The bot is being run through a GitHub action that runs every 30 minutes. Give the bot the opportunity to classify an issue before doing it manually.\n\n### Inbox Tracking\n\nThe inbox tracker is responsible for the [global inbox](https://github.com/microsoft/vscode/issues?utf8=%E2%9C%93&q=is%3Aopen+no%3Aassignee+-label%3Afeature-request+-label%3Atestplan-item+-label%3Aplan-item) containing all **open issues and pull requests** that\n- are neither **feature requests** nor **test plan items** nor **plan items** and\n- have **no owner assignment**.\n\nThe **inbox tracker** may perform any step described in our [issue triaging documentation](https://github.com/microsoft/vscode/wiki/Issues-Triaging) but its main responsibility is to route issues to the actual feature area owner.\n\nFeature area owners track the **feature area inbox** containing all **open issues and pull requests** that\n- are personally assigned to them and are not assigned to any milestone\n- are labeled with their feature area label and are not assigned to any milestone.\nThis secondary triage may involve any of the steps described in our [issue triaging documentation](https://github.com/microsoft/vscode/wiki/Issues-Triaging) and results in a fully triaged or closed issue.\n\nThe [github triage extension](https://github.com/microsoft/vscode-github-triage-extension) can be used to assist with triaging — it provides a \"Command Palette\"-style list of triaging actions like assignment, labeling, and triggers for various bot actions."
},
{
"kind": 1,
"language": "markdown",
"value": "## All Inbox Items\n\nAll issues that have no assignee and that have neither **feature requests** nor **test plan items** nor **plan items**."
"value": "### Bug Verification Queries\n\nBefore shipping we want to verify _all_ bugs. That means when a bug is fixed we check that the fix actually works. It's always best to start with bugs that you have filed and the proceed with bugs that have been filed from users outside the development team. "
"value": "### Bug Verification Queries\r\n\r\nBefore shipping we want to verify _all_ bugs. That means when a bug is fixed we check that the fix actually works. It's always best to start with bugs that you have filed and the proceed with bugs that have been filed from users outside the development team. "
The software may collect information about you and your use of the software and send it to Microsoft. Microsoft may use this information to provide services and improve our products and services. You may turn off the telemetry as described in the repository. There are also some features in the software that may enable you and Microsoft to collect data from users of your applications. If you use these features, you must comply with applicable law, including providing appropriate notices to users of your applications together with a copy of Microsoft's privacy statement. Our privacy statement is located at <https://go.microsoft.com/fwlink/?LinkID=824704>. You can learn more about data collection and use in the help documentation and our privacy statement. Your use of the software operates as your consent to these practices.
[](https://gitter.im/Microsoft/sqlopsstudio?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
Azure Data Studio is a data management tool that enables you to work with SQL Server, Azure SQL DB and SQL DW from Windows, macOS and Linux.
Azure Data Studio is a data management and development tool with connectivity to popular cloud and on-premises databases. Azure Data Studio supports Windows, macOS, and Linux, with immediate capability to connect to Azure SQL and SQL Server. Browse the [extension library](https://github.com/microsoft/azuredatastudio/wiki/List-of-Extensions) for additional database support options including MySQL, PostgreSQL, and MongoDB.
## **Download the latest Azure Data Studio release**
Please visit our [download page](https://aka.ms/getazuredatastudio) for more specific installation instructions.
Check out the [change log](https://github.com/Microsoft/azuredatastudio/blob/main/CHANGELOG.md) or [release notes](https://learn.microsoft.com/sql/azure-data-studio/release-notes-azure-data-studio) for additional details of what's in the each release.
The [Azure Data Studio documentation](https://learn.microsoft.com/sql/azure-data-studio) includes complete details on getting started, connection quickstarts, and feature tutorials.
## **Feature Highlights**
@@ -64,8 +94,12 @@ This project has adopted the [Microsoft Open Source Code of Conduct](https://ope
## Localization
Azure Data Studio is localized into 10 languages: French, Italian, German, Spanish, Simplified Chinese, Traditional Chinese, Japanese, Korean, Russian, and Portuguese (Brazil). The language packs are available in the Extension Manager marketplace. Simply, search for the specific language using the extension marketplace and install. Once you install the selected language, Azure Data Studio will prompt you to restart with the new language.
## Telemetry
Azure Data Studio collects telemetry data, which is used to help understand how to improve the product. For example, this usage data helps to debug issues, such as slow start-up times, and to prioritize new features. While we appreciate the insights this data provides, we also know that not everyone wants to send usage data and you can disable telemetry as described in the [disable telemetry reporting](https://aka.ms/ads-disable-telemetry) documentation.
## Privacy Statement
The [Microsoft Enterprise and Developer Privacy Statement](https://privacy.microsoft.com/privacystatement) describes the privacy statement of this software.
The [Microsoft Privacy Statement](https://go.microsoft.com/fwlink/?LinkID=824704) describes the privacy statement of this software.
## Contributions and "Thank You"
We would like to thank all our users who raised issues, and in particular the following users who helped contribute fixes:
@@ -130,11 +164,3 @@ And of course, we'd like to thank the authors of all upstream dependencies. Ple
Copyright (c) Microsoft Corporation. All rights reserved.
Some files were not shown because too many files have changed in this diff
Show More
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.