* Port request of title generation removal
* added fix to CMS
* added updated mainthread
* Revert "added updated mainthread"
This reverts commit a5806555a17bb7495c5a3573a98bd36a0f361785.
* Revert "added fix to CMS"
This reverts commit 2b8c24f09e4d7eadfcd047bbc554285ebd9811bc.
* Revert "Port request of title generation removal"
This reverts commit e6a2302778c9fd580f1f3d6de72c5037c14d815b.
* Remove/comment out connection title generation from all areas. (#23873)
---------
Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>
* Add limit on the file size that can be opened with Open XEL feature
* Add limit on the file size that can be opened and post a notification for large files
* Update wording
* Use FileService interface instead of fs to fix layering rules
* Fix error when opening create project from db dialog without connection
* Update extensions/sql-database-projects/src/dialogs/createProjectFromDatabaseDialog.ts
---------
Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com>
* Makes use of xvfb to run unit tests
* Restore test script as before, but with xvfb
* Use same command that worked in CLI
* Add --build CLI arg
* Add coverage arg
* Revert change to core unit test script
* Reset core unit tests script in linux pipeline
* Revert "Skip flaky vscode test suites (#23535)"
This reverts commit 882bdb3aab.
* Revert "Disable failing vscode test suite (#23539)"
This reverts commit 562a0ce595.
* Revert "Disable vscode remote configuration suite (#23545)"
This reverts commit 40fa1cebd8.
* Revert "Disable editor resolver service test suite (#23550)"
This reverts commit cd68dca844.
* Revert "Disable upstream extension enablement suite (#23557)"
This reverts commit faf3c6976e.
* Revert "Skip a few more suites impacted by xterm issue (#23589)"
This reverts commit 1662cedf17.
# Conflicts:
# src/vs/workbench/contrib/experiments/test/electron-sandbox/experimentService.test.ts
* Use DOM Renderer for tests
* Remove extra whitespace
* Update comment
* Initial set of changes for opening XEL files in ADS
* Code cleanup and update STS version
* Fix runtime errors
* Address comments
* Address comments and update Start button to be disabled for file session
* Code cleanup
* Initial commit for adding a basic general tab for the database properties
* Refactoring for dialog inputs
* removed properties nodeType and using database node and additional cleanup, diabling the functionality.
* Changes according to STS data fetch
* Reuse database Dialog
* Undo contract file change
* more refactoring
* fetched scrollbar fix into this PR
* Tabbed panel is being used for horizontal tabs
* stying fix for general tab button
* final commit for today :)
* Updates according to STS changes
* missed updates
* Refactored updates
* moved options as discussed and added collapsible sections... need to fix scroll bar
* Fixing the horizontal scroll bar of tabbedpanel
* initial updates
* need to fix the error!
* rror fixed and options are loading with sample values
* need to load real values for all felds and map values to dropdown options
* Dd loading correctly, need to add validation to recovery field and save options back
* refactor
* removing nullable property
* All changes done except recoveryTime validation
* Refactoring
* all values are saving as expected, isDirty flag is fixed. Todo: recovery validation and tests
* added general section for the options tab
* modifying pageVerify and userAccess to string array
* updates to general section of options tb
* disabling couple of general properties for MI
* Adding server edition conditions and toggling the UI options
* adding numeric validation to the recovey time
* Removing serveInfo logic and using the unsupported options approach from STS
* addressing comments and little code refactor
* changes with nullOrUndefined helper method
* replacing dropdowns with checkboxes
* adding unit test for helper method
* removed commented sample code and added comments
* initial changes for making a QDS report with placeholders
* Add icon for configure button
* Add another example report to show layout
* move files
* add placeholder names to components and cleanup toolbar
* cleanup
* switch to createViews() instead of createTop and BottomSections()
* add QueryStoreView class for the different components in a report
* cleanup
* add more comments
* fix yarn not running for query store extension folder
* add missing break
* change one more view to container
* Reenable extension unit tests
* Turn off Notebook Trust test cases
* Skip another failing notebook trust test
* Limit scope of disabled tests to only folder scenarios
* log when an editor action doesn't run because of enablement
* notebooks create/dispose editors. this means controllers must be created eagerly (😢) and that notebooks need a custom way of plugging comparision keys for session. works unless creating another session for the same cell of a duplicated editor
* Set offSide to sql lang configuration to true (#183461)
* Fixes#181764 (#183550)
* fix typo
* Always scroll down and focus the input (#183557)
* Fixes#180386 (#183561)
* cli: ensure ordering of rpc server messages (#183558)
* cli: ensure ordering of rpc server messages
Sending lots of messages to a stream would block them around the async
tokio mutex, which is "fair" so doesn't preserve ordering. Instead, use
the write_loop approach I introduced to the server_multiplexer for the
same reason some time ago.
* fix clippy
* update for May endgame
* testing: allow invalidateTestResults to take an array (#183569)
* Document `ShareProvider` API proposal (#183568)
* Document `ShareProvider` API proposal
* Remove mention of VS Code from JSDoc
* Add support for rendering svg and md in welcome message (#183580)
* Remove toggle setting more eagerly (#183584)
* rm message abt macOS
* Change text (#183589)
* Change text
* Accidentally changed the wrong file
* cli: improve output for code tunnel status (#183571)
* testing: allow invalidateTestResults to take an array
* cli: improve output for code tunnel status
Fixes#183570
* [json/css/html] update services (#183595)
* Add experimental setting to enable this dialog
* Fix exporting chat model to JSON before it is initialized (#183597)
* minimum scrolling to reveal the next cell on shift+enter (#183600)
do minimum scrolling to reveal the next cell on Execute cell and select next
* Fixing Jupyter notebook issue 13263 (#183527)
fix for the issue, still need to understand why there is strange focusing
* Tweak proposed API JSDoc (#183590)
* Tweak proposed API JSDoc
* workbench -> workspace
* fix ? operator
* Use active editor and show progress when sharing (#183603)
Use active editor and show progress
* use scroll setting variable correctly
* Schedule welcome widget to show once between typing. (#183606)
* Schedule dialog to show once between typing
* Don't re-render if already displayed once
* Add F10 keybinding for debugger step, even on Web. (#183510)
Fixes#181792.
Previously, for Web the keyboard shortcut was Alt-F10, because it was
believed that F10 could not be bound on browsers. This turned out to be
incorrect, so we make the shortcut consistent (F10) with desktop VSCode
which is also what many other debuggers use.
We keep Alt-F10 on web as a secondary keybinding to keep the experience
some web users may have gotten used to by now.
* Also pass process.env
* Restore missing chat clear commands (#183651)
* chore: update electron@22.5.4 (#183716)
* Show remote indicator in web when remoteAuthority is set (#183728)
* feat: .vuerc as json file (#153017)
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
* Delete --compatibility=1.63 code from the server (#183738)
* Copy vscode.dev link to tunnel generates an invalid link when an untitled workspace is open (#183739)
* Recent devcontainer display string corrupted on Get Started page (#183740)
* Improve "next codeblock" navigation (#183744)
* Improve "next codeblock" navigation
Operate on the current focused response, or the last one, and scroll to the selected item
* Normalize command title
* Git - run git status if similarityThreshold changes (#183762)
* fix aria-label issue in kb editor
fixes A11y_GradeB_VSCode_Keyboard shortcut reads words together - Blind: Arrow key navigation to row Find the binding keys and "when" cell data are read together resulting in a word " CTRL + FeditorFocus instead of CTRL + F editorFocus" #182490
* Status - fix compact padding (#183768)
* Remove angle brackets from VB brackets (#183782)
Fixes#183359
* Update language config schema with more details about brackets. (#183779)
* fix comment (#183812)
* Support for `Notebook` CodeAction Kind (#183457)
* nb kind support -- wip
* allow notebook codeactions around single cell edit check
* move notebook code action type out of editor
---------
Co-authored-by: rebornix <penn.lv@gmail.com>
* cli: fix connection default being applied (#183827)
* cli: bump to openssl 1.1.1u (#183828)
* Implement "delete" action for chat history (#183609)
* Use desired file name when generating new md pasted file paths (#183861)
Fixes#183851
* Default to filename for markdown new file if empty (#183864)
Fixes#183848
* Fix small typo (#183865)
Fixes#183819
* Noop when moving a symbol into the file it is already in (#183866)
Fixes#183793
* Adjust codeAction validation to account for notebook kind (#183859)
* Make JS/TS `go to configuration` commands work on non-`file:` file systems (#183688)
Make `go to project` commands work on non-`file:` file systems
Fixes#183685
* Can't do regex search after opening notebook (#183884)
Fixes#183858
* Default to current dir for `move to file` select (#183875)
Fixes#183870
`showOpenDialog` seems to ignore `defaultUri` if the file doesn't exist
* Use `<...>` style markdown links when needed (#183876)
Fixes#183849
* Remove check for context keys
* Update xterm package
* Enable updating a chat model without triggering incremental typing (#183894)
* Enable chat "move" commands on empty sessions (#183895)
* Enable chat "move" commands on empty sessions
and also imported sessions
* Fix command name
* Fix some chat keybindings on windows (#183896)
* "Revert File" on inactive editors are ignored (fix#177557) (#183903)
* Empty reason while switching profile (fix#183775) (#183904)
* fix https://github.com/microsoft/vscode-internalbacklog/issues/4278 (#183910)
* fix https://github.com/microsoft/vscode/issues/183770 (#183914)
* code --status displays a lot of errors before actual status output (fix#183787) (#183915)
* joh/icy manatee (#183917)
* Use idle value for widget of interactive editor controller
https://github.com/microsoft/vscode/issues/183820
* also make preview editors idle values
https://github.com/microsoft/vscode/issues/183820
* Fix#183777 (#183929)
* Fix#182309 (#183925)
* Tree checkbox item -> items (#183931)
Fixes#183826
* Fixes#183909 (#183940)
* Fix#183837 (#183943)
fix#183837
* Git - fix#183941 (#183944)
* Update xterm.css
Fixes#181242
* chore: add @ulugbekna and @aiday-mar to my-endgame notebook (#183946)
* Revert "When snippet mode is active, make `Tab` not accept suggestion but advance placeholder"
This reverts commit 50a80cdb61511343996ff1d41d0b676c3d329f48.
* revert not focusing completion list when quick suggest happens during snippet
* change `snippetsPreventQuickSuggestions` default to false
* Fix#181446 (#183956)
* fix https://github.com/microsoft/vscode-internalbacklog/issues/4298 (#183957)
* fix: remove extraneous incorrect context keys (#183959)
These were actually getting added in getTestItemContextOverlay, and the test ID was using the extended ID which extensions do not know about.
Fixes#183612
* Fixes https://github.com/microsoft/monaco-editor/issues/3920 (#183960)
* fix https://github.com/microsoft/vscode-internalbacklog/issues/4324 (#183961)
* fix#183030
* fix#180826 (#183962)
* make message more generic for interactive editor help
* .
* fix#183968
* Keep codeblock toolbar visible when focused
* Fix when clause on "Run in terminal" command
* add important info to help menu
* fix#183970
* Set `isRefactoring` for all TS refactoring edits (#183982)
* consolidate
* Disable move to file in TS versions < 5.2 (#183992)
There are still a few key bugs with refactoring. We will ship this as a preview for TS 5.2+ instead of for 5.1
* Polish query accepting (#183995)
We shouldn't send the same request to Copilot if the query hasn't changed. So if the query is the same, we short circut.
Fixes https://github.com/microsoft/vscode-internalbacklog/issues/4286
Also, when we open in chat, we should use the last accepted query, not what's in the input box.
Fixes https://github.com/microsoft/vscode-internalbacklog/issues/4280
* Allow widget to have focus (#184000)
So that selecting non-code text works.
Fixes https://github.com/microsoft/vscode-internalbacklog/issues/4294
* Fix microsoft/vscode-internalbacklog#4257. Mitigate zindex for zone widgets. (#184001)
* Change welcome dialog contribution to Eventually
* Misc fixes
* Workspace folder picker entry descriptions are suboptimal for some filesystems (fix#183418) (#184018)
* cli - ignore std error unless verbose (#183787) (#184031)
* joh/inquisitive meerkat (#184034)
* only stash sessions that are none empty
https://github.com/microsoft/vscode-internalbacklog/issues/4281
* only unstash a session once - unless new exchanges are made,
https://github.com/microsoft/vscode-internalbacklog/issues/4281
* account for all exchange types
* Improve declared components (#184039)
* make sure to read setting (#184040)
d'oh, related to https://github.com/microsoft/vscode/issues/173387#issuecomment-1571696644
* [html] update service (#184049)
[html] update service. FIxes#181176
* reset context keys on reset/hide (#184042)
fixes https://github.com/microsoft/vscode-internalbacklog/issues/4330
* use `Lazy`, not `IdleValue` for the IE widget held by the eager controller (#184048)
https://github.com/microsoft/vscode/issues/183820
* fix https://github.com/microsoft/vscode-internalbacklog/issues/4333 (#184067)
* use undo-loop instead of undo-edit when discarding chat session (#184063)
* use undo-loop instead of undo-edit when discarding chat session
fixes https://github.com/microsoft/vscode-internalbacklog/issues/4118
* fix tests, wait for correct state
* Add logging to node download (#184070)
Add logging to node download. For #182951
* re-enable default zone widget revealing when showing (#184072)
fixes https://github.com/microsoft/vscode-internalbacklog/issues/4332, also fixes https://github.com/microsoft/vscode-internalbacklog/issues/3784
* fix#178202
* Allow APIs in stable (#184062)
* Fixmicrosoft/vscode-internalbacklog#4206. Override List view whitespace css for monaco editor (#184087)
* Fix JSDoc grammatical error (#184090)
* Pick up TS 5.1.3 (#184091)
Fixes#182931
* Misc fixes
* update distro (#184097)
* chore: update electron@22.5.5 (#184116)
* Extension host veto is registered multiple times on restart (fix#183778) (#184127)
Extension host veto is registered multiple times on restart (#183778)
* Do not auto start the local web worker extension host (#184137)
* Allow embedders to intercept trustedTypes.createPolicy calls (#184136)
Allow embedders to intercept trustedTypes.createPolicy calls (#184100)
* fix: reading from console output for --status on windows and linux (#184138)
fix: reading from console output for --status on windows and linux (#184118)
* Misc fixes
* code --status displays a lot of errors before actual status output (fix#183787) (#184200)
fix 183787
* (cherry-pick to 1.79 from main) Handle galleryExtension failure in featuredExtensionService (#184205)
Handle galleryExtension failure in featuredExtensionService (#184198)
Handle galleryExtension failure
* Fix#184183. Multiple output height updates are skipped. (#184188)
* Post merge init fixes
* Misc build issues
* disable toggle inline diff of `alt` down
https://github.com/microsoft/vscode-internalbacklog/issues/4342
* Take into account already activated extensions when computing running locations (#184303)
Take into account already activated extensions when computing running locations (fixes#184180)
* Avoid `extensionService.getExtension` and use `ActivationKind.Immediate` to allow that URI handling works while resolving (#184310)
Avoid `extensionService.getExtension` and use `ActivationKind.Immediate` to allow that URI handling works while resolving (fixes#182217)
* WIP
* rm fish auto injection
* More breaks
* Fix Port Attributes constructor (#184412)
* WIP
* WIP
* Allow extensions to get at the exports of other extensions during resolving (#184487)
Allow extensions to get at the exports of other extensions during resolving (fixes#184472)
* do not auto finish session when inline chat widgets have focus
re https://github.com/microsoft/vscode-internalbacklog/issues/4354
* fix compile errors caused by new base method
* WIP
* WIP
* WIP
* WIP
* Build errors
* unc - fix path traversal bypass
* Bump version
* cherry-pick prod changes from main
* Disable sandbox
* Build break from merge
* bump version
* Merge pull request #184739 from max06/max06/issue184659
Restore ShellIntegration for fish (#184659)
* Git - only add --find-renames if the value is not the default one (#185053)
Git - only add --find-renames if the value is not the default one (#184992)
* Cherry-pick: Revert changes to render featured extensions when available (#184747)
Revert changes to render featured extensions when available. (#184573)
* Lower timeouts for experimentation and gallery service
* Revert changes to render extensions when available
* Add audio cues
* fix: disable app sandbox when --no-sandbox is present (#184913)
* fix: disable app sandbox when --no-sandbox is present (#184897)
* fix: loading minimist in packaged builds
* Runtime errors
* UNC allow list checks cannot be disabled in extension host (fix#184989) (#185085)
* UNC allow list checks cannot be disabled in extension host (#184989)
* Update src/vs/base/node/unc.js
Co-authored-by: Robo <hop2deep@gmail.com>
---------
Co-authored-by: Robo <hop2deep@gmail.com>
* Add notebook extension
* Fix mangling issues
* Fix mangling issues
* npm install
* npm install
* Issues blocking bundle
* Fix build folder compile errors
* Fix windows bundle build
* Linting fixes
* Fix sqllint issues
* Update yarn.lock files
* Fix unit tests
* Fix a couple breaks from test fixes
* Bump distro
* redo the checkbox style
* Update linux build container dockerfile
* Bump build image tag
* Bump native watch dog package
* Bump node-pty
* Bump distro
* Fix documnetation error
* Update distro
* redo the button styles
* Update datasource TS
* Add missing yarn.lock files
* Windows setup fix
* Turn off extension unit tests while investigating
* color box style
* Remove appx
* Turn off test log upload
* update dropdownlist style
* fix universal app build error (#23488)
* Skip flaky bufferContext vscode test
---------
Co-authored-by: Johannes <johannes.rieken@gmail.com>
Co-authored-by: Henning Dieterichs <hdieterichs@microsoft.com>
Co-authored-by: Julien Richard <jairbubbles@hotmail.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Megan Rogge <merogge@microsoft.com>
Co-authored-by: meganrogge <megan.rogge@microsoft.com>
Co-authored-by: Rob Lourens <roblourens@gmail.com>
Co-authored-by: Connor Peet <connor@peet.io>
Co-authored-by: Joyce Er <joyce.er@microsoft.com>
Co-authored-by: Bhavya U <bhavyau@microsoft.com>
Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
Co-authored-by: Aaron Munger <aamunger@microsoft.com>
Co-authored-by: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Co-authored-by: rebornix <penn.lv@gmail.com>
Co-authored-by: Ole <oler@google.com>
Co-authored-by: Jean Pierre <jeanp413@hotmail.com>
Co-authored-by: Robo <hop2deep@gmail.com>
Co-authored-by: Yash Singh <saiansh2525@gmail.com>
Co-authored-by: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com>
Co-authored-by: Ulugbek Abdullaev <ulugbekna@gmail.com>
Co-authored-by: Alex Ross <alros@microsoft.com>
Co-authored-by: Michael Lively <milively@microsoft.com>
Co-authored-by: Matt Bierner <matb@microsoft.com>
Co-authored-by: Andrea Mah <31675041+andreamah@users.noreply.github.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Sandeep Somavarapu <sasomava@microsoft.com>
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com>
Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
Co-authored-by: Joao Moreno <Joao.Moreno@microsoft.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
* Properly close dialog with escape
* Revert "Properly close dialog with escape"
This reverts commit 9ea5ec4beebcbbd4f0623ed0b5da0f1026fcd5be.
* Remove focus on ok button in filter dialog
* Sets the focus on the filterTable
* Initial commit for adding a basic general tab for the database properties
* Refactoring for dialog inputs
* removed properties nodeType and using database node and additional cleanup, diabling the functionality.
* Changes according to STS data fetch
* Reuse database Dialog
* Undo contract file change
* more refactoring
* fetched scrollbar fix into this PR
* Tabbed panel is being used for horizontal tabs
* stying fix for general tab button
* final commit for today :)
* Updates according to STS changes
* missed updates
* Refactored updates
* moved options as discussed and added collapsible sections... need to fix scroll bar
* Fixing the horizontal scroll bar of tabbedpanel
* remove advanced options for table designer and notebook Actions title (unnecessary in usage context)
* Revert "remove advanced options for table designer and notebook Actions title (unnecessary in usage context)"
This reverts commit e30aee5151319863aebbb4738fb30354c179c2c5.
* added changes based on feedback
* added null check and updated tests
* WIP change to connection title generation
* WIP connection management service update
* fix to connectionManagementService test
* fix editorConnectionTitles
* renamed nondefault to distinguishing options
* use stored connections for options
* removed erroneous connection name set to null
* added title by ID search for title generation
* Add recent connection title
* added fix for stub bug
* added child title options appended
* WIP rework of getEditorTitle
* more work done
* WIP changes for 5-2-2023
* moved server info to generate titles.
* added reworked title generation
* added working active connection title generation and cleanup
* added comments to argument
* remove unnecessary spaces
* added id fix assign
* added fromEditor save
* Revert "Revert new connection string format (#22997)"
This reverts commit 898bb73a34.
* added small fix to tests and exclude empty properties
* made small fixes for tests
* update expected ID
* added support for old password key and removed empty options
* added in authenticationType core property
* fix for whitespace indentation
* added connection save profile to thing
* made some small fixes to connection options
* added small change to connectionDialogService
* added nullcheck for saveProfile
* added negation for connection saveProfile
* remove duplicate editor title generation
* added edit profile handling for titles
* Cleanup serverCapabilities property
* fixed dependency issues
* removed connectionproviderproperties
* added fix for treeupdateutils
* made update to title generation
* added recent connections change
* Revert "Cleanup serverCapabilities property"
This reverts commit 2c7b94f98cabddb34116dcdd83177614a484c026.
* added dashboard text and fix for connection store test
* added group name to end also temporary added dashboard changes based on feedback
* added in new SQL version
* added fix to edit connections
* added clarifying information to title generation
---------
Co-authored-by: Cheena Malhotra <cmalhotra@microsoft.com>
* Upgrading chartjs
* Upgrading charjs in exthost and removing ng2-charts
* Updating lock file
* Fixing paths in workbench for new chartjs
* Removing more any
* Removing more any
* Fixing colors
* Fixing more stuff
* Updating distro hash
* add package reference type for system db references
* Add radio buttons
* hookup
* add test
* handle changing reference type radio buttons
* cleanup
* update strings
* change style to type
* change more places with style to type
* blank lines
* add copy results to query provider
* mark as optional
* fix test stub
* Update src/sql/azdata.proposed.d.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* address comments
* update return type
---------
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Initial support for MongoDB clusters / vCore
* Get cluster connection string from arm
* Preserve Azure account for any auth type
When a service has been selected through the Azure
browser, we want to preserve the Azure account
information even if a different authentication has
been selected. This allows doing ARM operations
using the signed in Azure account for any resources
including those with a different login types such
as clusters.
* Update product pipelines to add back core integration tests to Darwin and extension unit tests to Linux
* Update whitespace
* Update indentation
* Skip failing tests for now
* Fixing server group styling
* Hiding border when the tree item are selected focused or hovered
* Fixing styles and re-enabling guides
* removing unused import
* Fixing indicator width
* wip
* Update typings
* nullable
* update test service
* support securables
* updata test data
* fix issues
* fix build failure
* update test mocks
* fix typo
* fix reference
* fix findobjectdialog issue
* update SearchResultItem type
* fix table component perf issue
* hide effective permission for server role
* hide effective permission for app role and db role
* vbump sts and fix a couple issues
* STS update and UI update
* fix user login display issue
* vbump sts
* Adding init change
* Adding filter cache in OE
* Adding more filtering changes
* Fixed stuff with dialog
* Fixing filter
* Adding support for connecitons
* Fixed stuff
* filtering
* Fixing date
* Filters
* Removing is filtering supported
* Removing contracts
* Fixing filters
* Fixing cache
* Adding some accessibility changes
* Reverting some more changes to pull in changes from the main
* Adding comments
* Fixing boolean operators
* Fixing stuff
* Fixing stuff
* Fixing error handling and making dialog generic
* Fixing more stuff
* Making filter a generic dialog
* adding erase icon
* removing floating promises
* Fixing compile issue
* Adding support for choice filter with different and actual value.
* Adding null checks
* Adding durability type fix
* Fixing filtering for providers that do not play well with empty filter properties
- Bucketized errors to track top errors
- Created separate login migration specific error to improve monitoring
---------
Co-authored-by: Akshay Mata <akma@microsoft.com>
* Compile build folder
* Fix build compile issues (#22813)
* Revert changes
* Update gulp-shell
* Test
* Update
* Update modifiers
* Try reverting minimist
* Generates linux deb artifact (#22922)
* Remove deb files that were brought in with the latest merge.
* Add debian back to linux gulp file
* Remove async from anonymous function.
* Remove run core integration tests build step in pipeline
* Revert "Remove async from anonymous function."
This reverts commit 7ad1ce2942954fce58939b9965343b46b9311a7e.
* Revert "Add debian back to linux gulp file"
This reverts commit 96b7c0f0995c8024ef67ed886da34255a5caa325.
* Revert "Remove deb files that were brought in with the latest merge."
This reverts commit bf3aae233b8da1f9111a149a96d77cc78d376094.
* Removes dependency checks
* Fix dependency gen errors
* Reenable "Build Deb" step
* Reenable publish deb
* Run core integration tests
* Revert "Run core integration tests"
This reverts commit 7cafbada194feebe771862af796fb3416b5dd686.
* Revert "Try reverting minimist"
This reverts commit 38fd843c1d5c33318a92f4bbc7057e951c5a9f71.
* Disable code coverage step intermin
---------
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com>
* Template
* Refactor
* Update strings
* Clean up
* Add clear button
* Clean up
* Fix typo and use aka.ms link
* Refactor to use GroupContainer
* Remove dialog and clean up common strings
* Fix previous/forward behavior
* Make group container default to collapsed
* Clean up
* Slightly reword string
* Add https to aka.ms link
Add troubleshooting links to error message when SQL-Migration fails to download the MigrationService as seen in this issue: #22558
---------
Co-authored-by: Akshay Mata <akma@microsoft.com>
* Adding exclude folder and base for move folder
* checkpoint
* rename
* Fixing up tests
* Adding exclude test to projController
* Adding tests
* fixing order of service.moveX() calls
* Updating move() order in sqlproj service
* PR feedback
* unskipping
* reskipping test
* Fixing folder move conditional
* updating comments
* server role dialogs
* dialogs for other types
* refactor
* find object dialog
* script button
* refactoring
* fix issues
* fix title
* vbump sts
* remove language from links
* x subscription migration support
* refresh after cutover
* fix service irregular status load behavior
* queue service status requests, fix typo
* add migationTargetServerName helper method
* save context before api call
* update vscode-mssql.d.ts
* update extensions that need updates because of the vscode-mssql.d.ts changes
* remove skip
* fix sql projects tests failing because vscode-mssql couldn't be found
* Connection URI made to include every option available instead of basic details (#22045)
* Revert "Merge remote-tracking branch 'origin' into feat/connectionUri"
This reverts commit 11b2d31bf99e216daee823f732254f69a017fee1, reversing
changes made to 36e4db8c0744f81565efdfd2f56a3ae3c0026896.
* Revert "Revert "Merge remote-tracking branch 'origin' into feat/connectionUri""
This reverts commit f439673c2693e1144c52e04c14e82cd8566c13a6.
* Added changes and fixes for feat connectionuri (#22706)
* add title generation at start
* added await to refreshConnectionTreeTitles
* Converting remaining services to use `runWithErrorHandling()`
* Updating sqlops-dataprotocolclient to 1.3.3
* upgrading dataprotocol and swapping to that baseService
* Adding async to make thenable -> promise conversion happy
---------
Co-authored-by: Alan Ren <alanren@microsoft.com>
* Add profile section in Publish project UI
* Move publish profile row below Publish Target
* Add contract for savePublishProfie and SaveProfileAs button functionality
* Make the DacFx contract functional
* Send values from UI to DacFx service call
* Fix build error
* Address comment, remove print statements
* Address comments
* Set correct connection string
* Fix functionality for rename, exclude, delete publish profiles. Add new profile to the tree and sqlproj.
* Address comment to update alignement of button
* Address comments
* Update button to use title casing
* fix http request format
* encode to utf 8 and add body for put requests
* encode proxy request body
* change ?.data to ?.body
* add note for textencoder
* change content-type to application/json
* Hide more info for assessment issues without help links
* Add info box about blob container folders
* WIP - reuse create DMS dialog for IR registration
* Revert "Add info box about blob container folders"
This reverts commit 30b8892ea7918841a6466b59058181062d367ba5.
* Add help link to target platform selection page explaining Azure SQL offerings
* Revert "WIP - reuse create DMS dialog for IR registration"
This reverts commit 5fac6b5c7148b2520cc42ce9fad549cde28baba2.
* Don't show storage account warning banner for DB scenario
* Vbump extension and migration service
* Test - fix http request format from chsuh/fixFormat
* Add instructions for table mapping and schema migration
* Revert "Test - fix http request format from chsuh/fixFormat"
This reverts commit 4992603532e98dff3b7ba6f04ba9304d173fc5ad.
* disabling revert SQLCMD var value button when no changes to values; changing string
* Updating docstring
* Updating behavior to account for SQLCMD vars defined in publish profiles
* Changing look of new OE
* Fixing styling
* Fixing moving of connected profile
* Fixing drag and drop where treenodes delete connection nodes
* Fixing Deleting and disconnecting in AsyncServerTree
* Adding constant for OE timeout
* Updated interfaces
* Removing test compilation errors
* Fixing most events in async server tree
* Fixing connection pane styling
* Fixing find node function
* Fixing some more operations
* Fixing some ops
* All operations done
* Fixed active connections
* Fixed data source
* Adding support for setting parents
* code cleanup
* Fixing icon styling issues
* Fix errors
* Fixing comment
* Fixing spacing
* Adding explanation to OE service.
* Reverting server delegate changes
* Reverting styling
* reverting more styling change
* reverting more styling
* Fixing has children
* Fixing drag and drop to tree nodes
* fixing drag and drop
* reverting timing
* fixing drag and drop
* cleaning some code
* Fixed server and group moving
* spell check
* consolidating some logic
* Fixed whitespace
* fixing moving to root group
* add new migration details
* move migraiton target type enum to utils
* address review feedback, refectore, text update
* fix variable name
* limit and filter migrations list to mi/vm/db
* Move call to STS move api into project.ts (#22071)
* move call to STS move api into project.ts
* remove undefined
* Remove convert to sdk style code (#22081)
* remove convert to sdk style code
* remove from package.json
* Merging latest from main (#22097)
* [SQL-Migration] Login migrations telemetry (#22038)
This PR enhances telemetry for login migrations (and in the following ways:
Add details for starting migration (number of logins migrating, type of logins)
Log Migration result (number of errors per step, duration of each step, type of logins, if system error occurred)
Add sql-migration extension to our telemetry
Adds details when trying to connect to target
Tracks clicking "done" from the wizard
Fixes bucketizing for navigating telemetry in the login migration wizard
Sample usage of kusto query for new telemetry:
RawEventsADS
| where EventName contains 'sql-migration'
| extend view = tostring(Properties['view'])
| extend action = tostring(Properties['action'])
| extend buttonPressed = tostring(Properties['buttonpressed'])
| extend pageTitle = tostring(Properties['pagetitle'])
| extend adsVersion = tostring(Properties['common.adsversion'])
| extend targetType = tostring(Properties['targettype'])
| extend tenantId = tostring(Properties['tenantid'])
| extend subscriptionId = tostring(Properties['subscriptionid'])
| where view contains "login"
//| where adsVersion contains "1.42.0-insider"
| where ClientTimestamp >= ago(18h)
| project EventName, ClientTimestamp, SessionId, view, pageTitle, action, buttonPressed, targetType
, tenantId, subscriptionId
, adsVersion, OSVersion, Properties
* Add Secure Enclaves dropdown with customizable Advanced options (#22019)
* Update extension READMEs (#22079)
* Fix query-history README images (#22084)
* [Loc] update to mssql and sql-migration xlf files (#22087)
* [Loc] small fix to Portuguese lcl file (#22088)
* [Loc] small fix to Portuguese lcl file
* remove newline
* Adding None bindings to the sqlProjects service (#22085)
* Adding None bindings
* updating names of None bindings
---------
Co-authored-by: AkshayMata <akam520@gmail.com>
Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Alex Ma <alma1@microsoft.com>
* Swap add and update sqlcmd variables in sql projects to use STS apis (#22086)
* delete sqlcmd variable working
* undo add
* remove variable from add and update sqlcmd variable apis
* hookup add and edit sqlcmd variable
* update vscode-mssql.d.ts
* move add and edit to project.ts
* update STS and tests
* move delete sqlcmd variable to project.ts (#22104)
* add test for add and edit sqlcmd variable (#22107)
* Swapping property access to STS (#22115)
* checkpoint
* Adding sqlproj property bindings
* Swapping out property loading and setting
* consolidating to this.sqlProjService
* Update dacpac reference to use STS api (#22116)
* Update add dacpac reference to use STS api
* remove changes for project ref
* validate unset settings from add database reference dialog
* update one more place getting sqlprojservice
* addressing comments
* fix path for dacpac reference (#22143)
* Swap add project reference to call STS (#22148)
* initial changes for swapping add project reference
* fix include path
* move common logic to helper function
* read sqlcmd variables from STS (#22147)
* Swapping .sqlproj- and crossplat compatibility-related functions to use STS (#22146)
* Supporting roundtrip
* Updating sqlproj style checks and cross-platform compatibility to use STS
* removing unnecessary awaits
* Fixing assertions
* Adding roundtrip update confirmations
* test cleanup
* cleaning up comment; localizing error
* Swap add system db reference (#22171)
* swap adding system database references
* fix tests
* remove only in test
* Read database references from STS (#22179)
* Read database references from STS
* fix system dacpac names
* fix project reference name
* Swap changeTargetPlatform to call STS (#22172)
* swap changeTargetPlatform to call STS
* Address comments
* De-duplicating enum for SystemDatabase (#22196)
* Deudping SystemDatabase enum
* simplifying enum refs
* Removing the now-unused imports code from SqlProjects (#22199)
* Removing unused importTargets entries
* whitespace; also to retrigger github checks on correct branch
* Hooking in Move() for Nones and PublishProfiles (#22200)
* Swap delete database reference to call STS (#22215)
* initial changes
* update contracts
* remove unnecessary info from SystemDatabaseReferenceProjectEntry
* uppercase master and msdb
* cleanup
* update test
* update comment
* undo change in projectController.ts
* remove unused system dacpac helper functions (#22204)
* more cleanup of project.ts (#22242)
* fix a couple database reference tests (#22248)
* Organizing sqlcmd variable and db reference code (#22284)
* organize database references and sqlcmd variable functions
* separate database reference tests
* Script and folder get + add support (#22166)
* Initial sqlobjectscripts
* adding mock filter
* test fixing
* another test passing
* swapping pre/post/none checkpoint
* awaiters
* convert addExistingItem
* swapping folders
* removing print
* stripping out project folder and file readers
* adding some regions
* Updating sqlproj style checks and cross-platform compatibility to use STS
* Updating sqlproj style checks and cross-platform compatibility to use STS
* added type property to tree items
* projectController swapovers
* removing imported targets
* Deleting the last of the TS XML parsing!
* Removing old functions
* renamed readNoneScripts to readNoneItems
* fixing path passed to STS calls
* remove system dacpac tests that were moved to DacFx (#22299)
* fix error when opening file after adding a file to sql project (#22309)
* fix error when opening file after adding a file to sql project
* remove unused import
* fix exclude for table and externalStreamingJob (#22310)
* add reload project (#22313)
* set DSP from STS (#22320)
* fix adding post-deployment script and existing item (#22317)
* Test cleanup for .sqlproj content operations (#22330)
* Fixing up tests
* sqlproj content operations tests
* remove only
* Cleanup
* Correcting collation
* cleanup constants.ts (#22336)
* fix folders not showing in project tree (#22319)
* Fix project controller tests (#22327)
* fixing ProjectController tests after swap
* remove only from database reference tests
* change system dbs back to lowercase in sql projects (#22353)
* Bump tools service
* Updated yarn.lock file
* pass SystemDacpacsLocation when building legacy style sql projects (#22329)
* Benjin/fix types (#22365)
* Updated yarn.lock file
* Fixing types
* fix projectController tests (#22375)
* Fixing the deletion flow for files and folders (#22366)
* checkpoint
* PR feedback
* Fixing up SDK-style operations project test group (#22377)
* Fixing up SDK-style project test group
* Removing .only
* Fixing up database reference tests (#22380)
* Fixing DB reference test group
* Extra cleanup
* removing only
* Consolidating None and PublishProfile; lighting up test (#22382)
* Lighting up project property tests (#22395)
* Checkpoint
* Lighting up project property tests
* removing timeout
* Fixing buildHelper test (#22400)
* Unskipping up roundtrip test (#22397)
* Refactoring database references to split literalVariable from databaseName (#22412)
* refactoring database references to split databaseVariableLiteralValue out from databaseName
* renaming more properties
* Removing branch in entry population
* removing only
* Fixing baselines for delete test
* PR feedback
* Fixing up ProjectTree tests (#22419)
* Fixing up projectTree tests
* remove only
* Updating projectController exclude test (#22413)
* Updating test
* moving filtering for external folders to readFolders() method
* Removing EntryType import
* fix ups (#22435)
* adding extra info for test failure
* hide exclude folder from context menu until it's supported (#22454)
* Adding current test name to generated folder to avoid conflicts (#22478)
* Adding current test name to generated folder to avoid conflicts
* passing correct test parameter in
* Adding trimming and entropy
* Deleting unused baselines (#22497)
* Replacing addToProject() with addSqlObjectScripts() (#22489)
* checkpoint
* Fixing test
* Updating file scraper function to filter only to .sql files (no folders, no txt)
* changing var names to reflect that the lists only contain .sql scripts
---------
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: AkshayMata <akam520@gmail.com>
Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Alex Ma <alma1@microsoft.com>
* Fixing new connection node not expanding in OE
* Fixing new connections not expanding and fixing expand request not resolving because of some provider error.
* Fixing test
* Adding a setting for node expansion timeout
* Not saving when loading tree based connections
* Adding some logs
* Removing special casing for mssql provider
* Missing providers
* Adding user toast for node expansion timeout
* Adding notification service to test
* Fixing node type for mssql
* remove polling
* Fixing onNodeStatus
* Fixing stuff
* consolidating functions
* Consolidating resolve logic
* removing extra try catch
* code cleanup
* adding size checks
* Removing commented code
* Ignoring errors from other sessions and nodepaths.
* Fix for newline replacement
* added proper null regex and null character check
* removed cell class
* removed unnecessary function
* revert back to old check
* change onbeforeeditcell
* small fix to typo in onBeforeEditCell
* made changes based on feedback
* added comments clarifying isDBCellValue
* update the rendered text onCellSourceChange
* fix test
* fix highlight in split mode
* update corresponding test
* update hasEditor with getEditor
* update event
* add comment
* Moves New Deployment to file menu bar.
* Add deployment back to breadcrumb menu
* Update extensions/resource-deployment/DEVELOPER_GUIDE.md
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Adjust new deployment mnemonic
* Remove unused localized string
---------
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
This PR enhances telemetry for login migrations (and in the following ways:
Add details for starting migration (number of logins migrating, type of logins)
Log Migration result (number of errors per step, duration of each step, type of logins, if system error occurred)
Add sql-migration extension to our telemetry
Adds details when trying to connect to target
Tracks clicking "done" from the wizard
Fixes bucketizing for navigating telemetry in the login migration wizard
Sample usage of kusto query for new telemetry:
RawEventsADS
| where EventName contains 'sql-migration'
| extend view = tostring(Properties['view'])
| extend action = tostring(Properties['action'])
| extend buttonPressed = tostring(Properties['buttonpressed'])
| extend pageTitle = tostring(Properties['pagetitle'])
| extend adsVersion = tostring(Properties['common.adsversion'])
| extend targetType = tostring(Properties['targettype'])
| extend tenantId = tostring(Properties['tenantid'])
| extend subscriptionId = tostring(Properties['subscriptionid'])
| where view contains "login"
//| where adsVersion contains "1.42.0-insider"
| where ClientTimestamp >= ago(18h)
| project EventName, ClientTimestamp, SessionId, view, pageTitle, action, buttonPressed, targetType
, tenantId, subscriptionId
, adsVersion, OSVersion, Properties
* swap rename to use DacFx project apis
* add support for rename pre/post deploy scripts and add tests
* update the enum names too
* check instanceof instead of getting and iterating through all the collections
This PR fixes an issue where the JSON-RPC Migration Service crashes when ADS is reloaded.
This situation applies when user tried to reload ADS where SQL-migration extension was running:
when connecting to DB, SQL-migration extension loads and migration service launches
if a previous MigrationService zombie process is stil running (if extension was used before), then that zombie process will have a lock on the log file
new launches of MigrationService on reloaded ADS fails b/c it can't obtain log file handle due to lock in step 2
The fix stops the MigrationService on extension deactivate and will ensure that a zombie MigrationService process isn't hanging around on reloads.
No hotfix needed as 1.4.0 was baking in insiders and has not been released to stable yet. Additionally, this mainly affects developers as they are most likely to reload ADS this way. Caveat: users do need to reload after installing latest version, however they will not hit this code path (since the migration service process is only in new versions of the extension)
* show error if trying to create or open project when no project extensions are found
* only check if project providers are available on startup and when extensions change
* addressing comments
* Update extensions/data-workspace/src/services/workspaceService.ts
use some instead of find
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
---------
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
This PR updates the JSON-RPC Migration service to the latest version. Critically, it also changes the dotnet version to 7.0. The STS dotnet version was recently changed, which changed the names of the release packages and broke our existing links.
* Read publish profiles stored in sqlproj file and present it in the projects tree
* Save publish profile and add it to sqlproj file, and present it in the tree
* Fix context menu operations
* Add tests
* Address comments
* starts of sqlprojectsservice
* copy to mssql
* adding all the boilerplate
* updating service call structures
* Fixing up test mocks
* Adding comments to all the bindings
* blank space
* swapping for Promise; adding vscode-mssql type bindings
* patching
* Fix empty name in delete connection prompt
* Update src/sql/workbench/services/objectExplorer/browser/connectionTreeAction.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
---------
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* initial commit
* leave only march release objects
* clean up
* login dialog
* localize and use background operation
* code cleanup
* remove tab
* support server role in login
* remove canEditName
* add user support
* comments and bug fixes
* remove hasDBAccess for now
* refactoring
* fix error
* user dialog UI
* telemetry, error handling and refactoring
* Fix references to dialogInfo (#21914)
* update telemetry
* Bump STS and use actual object management service
* add preview and handle no-change scenario
* fix merge issue
---------
Co-authored-by: Karl Burtram <karlb@microsoft.com>
* Read encrypt and trust server certificate
* Set hostname in certificate setting
* Address comment- open connection dialog if the connection string in publish profile doesn't load a connection, instead of throwing an error.
* Adding migration service to sql migrations
* enabling auto flush log
* Adding support for env variable
* Adding TDE Migration service
* code cleanup
* updating service downloader
* Removing custom output channel
* remove unnecessary await
* Updated service version to get latest code
* Consolidate TDE into migration service
* Sync to latest main
* Update sql-migration package version
* Fix merge conflict error
* Fixing all merge conflicts
* Fixing stuff
* removing extra whitespace
* Cleaning up
---------
Co-authored-by: Akshay Mata <akma@microsoft.com>
* WIP
* Always get latest current connection
* Update more references
* Clean up
* Clean up
* vbump
* Update comments
* Address PR feedback
* Separate into helper methods
* fix uncaught error in showSplitView
* fixed bugs around account dialog with multiple providers
* cleanup
* fix index out of bounds error
* Fire account list update after removing provider, other pr fixes
This PR fixes a regression for migration login for MI instances that was introduced in https://github.com/microsoft/azuredatastudio/pull/21776/files#diff-93c1a62583fa32d99f775b71ad27922cf31f660d10717ecc6966784306de1b6f.
After that change, support for MI would fail as MI server types were going into the Sql VM path in sqlutils because the underlying logic for isSqlServerVM() was returning wrong results.
The new approach uses the targetType set in StateMachine to extract the correct serverName for connection string based on the targetType.
Testing:
- Tested SQL VM login migration end to end
- Tested SQL MI login migration end to end
This change also bumps the sql-migration version to 1.3.0
* Add validation for new file names for sql projects
* Addres comments and add validation for new project dialog
* Address comments
* Address comments on test
* Fix tests
* Remove extra error messages and rename file
* Address comments
* Fix tests
* Add test file back
* use pathname vs nodeValue
* add test
* add comment
* only when editing in rich text
* refactor
* fix build errors
* fix hygiene errors
* remove fs check
* compare decodedUri to get correct relative paths
* Add Azure Resource 'Sql' to MSSQL extension. (#21600)
* [Loc] added sql.xlf schema (#21687)
* vbump profiler extension (#21685)
* Fix connect icon for Arc extension (#21659)
* Juno: check in to lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20230121171613142. (#21690)
* Juno: check in to lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20230122164538349. (#21693)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* Juno: check in to lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20230123164122334. (#21697)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* use normalize to get the path correctly
* add comment
* refactor
* more tests
* typo fix
---------
Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>
Co-authored-by: Alex Ma <alma1@microsoft.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Alex Hsu <csigs@users.noreply.github.com>
This PR bumps sql-migration version to 1.2.2 in order to release to insider's gallery. This also disables the LoginMigration button as we do not want to release it to public yet.
* Adding prompt for disconnect
* changing to Idialog service
* Code cleanup and fixing comments
* Adding comments and making a test async
* removing then and awaiting for function
This PR adds various login migration improvements:
- Enabled windows login by prompting user for AAD domain name if a windows login is selected
image
- Adds new login details dialog which gives granular status on each step of the login migration for each login
image
- Checks if windows login migration is supported for selected target type, and only collections source windows logins accordingly
- Perf optimization by source and target login in background of step 1 in order to significantly speed up loading of page 2
* Disable IR scenario and add info box for source < 2014
* Update text and link
* Clean up
* Fix issue where switching to another target platform wouldn't clear restriction
* Remove locale from documentation URL
* Refactor
* Clean up
* Autoselect blob scenario
* Refactor
* Add page blog check
* Clean up
* Update UI logic
* Add allow list of valid notebook command uris (#163322)
This restricts notebooks to run three command uris. These 3 commands should all be safe to run, even with untrusted inputs
* Fix incorrectly resolved merge conflict
Co-authored-by: Matt Bierner <matb@microsoft.com>
* update to langpack xlfs
* update to langpack source files
* added updated source files and dates
* Update for 12-19-2022
* Update for 12-21-2022
* update for 1/3/2023
* update to azurecore 1-9-2023
* last update to langpack source file before release
Adding collation validation in target database selection page.
collecting source database info including state, size, collation etc in the step 1 (select databases to assess and migrate)
comparing source database collation and target database collation in target selection page.
image
* change how data workspace activates project extensions
* cleanup
* undo whitespace change
* Update extensions/data-workspace/src/services/workspaceService.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* activate extensions on data workspace new and open commands
* Update extensions/data-workspace/src/services/workspaceService.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Add dropdown populated with projects in current workspace in Update Project from database dialog for target project location
* Select first from the list if no project is preselected
* Address comments
* Added initial password connection dialog box
* made small changes
* more preliminary work
* more WIP changes
* more cleanup done
* added dialog instantiation
* added placeholder dialog window
* added changePasswordController
* made some changes to changePasswordController
* some changes made
* added more changes
* more changes made to dialogue
* added password confirm box
* added WIP change password function
* small changes made to API
* small changes for test
* added uri
* added valid password
* added TODO comments
* added small change to connectionManagementService
* added connectionManagementService password change
* added comment on what to do next
* made some simplification of change password
* added response callback
* added fixes to protocol
* added throw error for passwordChangeResult
* WIP added call to self after password change
* WIP changes to implementing new password change dialog
* added changes to passwordChangeDialog
* added launchChangePasswordDialog
* remove erroneous css
* added working dialog
* removed old password change dialog
* fixed space
* added checkbox option to passwordChangeDialog
* added test signatures
* added error handling
* added some changes
* added changes to HTML for passwordChangeDialog
* added CSS to passwordChangeDialog
* added display none for matching passwords
* added documentation changes
* small cleanup
* added working error catch and retry
* added await
* added recovery instructions
* Added ok button hide for button click.
* added loading spinner
* fixed for semicolon
* added updated message
* Added message change
* added minor fixes
* added small fixes
* made more changes
* renamed messages to errorDetails
* added styling to passwordChangeDialog
* simplified error message
* changed comment
* modified azdata to be consistent
* small changes
* change to azdata for consistency
* added clarification for provider
* removed additional instructions
* Added new dialog title
* addressed feedback
* added comments
* added changes
* Adding wizard and dialog loading
* Moving apis to proposed
* fixing namespace
* Only firing event when the value changes
* Only firing when value is changed
* Adding loading complete message to dialog and wizard
* Registering listeners and making a new base interface for loading components
* Fixing api comment
* Renaming prop to loadingCompleted
* old loading icon
* hide publish to new Azure server under preview setting
* try adding additional properties instead of replacing everything in configuration
* cleanup and change to adding configuration properties instead of replacing the whole thing
* add more info in comment
* remove extra line
* Vbump and update dependent ADS version (#21179)
* [SQL Migration] Add new Azure Core API changes back in to support USGov + other non-public clouds (#20476)
* WIP - show error message for failed SKU recommendation
* WIP - run query to get correct instance name
* WIP - integrate elastic model recommendation
* Remove private endpoint restriction text
* Add feature switch for elastic recommendation
* Clean up
* Clean up
* Misc UI fixes
* Update package.json with updated azdata dependency
* Remove unused lines
* Fix broken next button
* Vbump extension to 1.0.6
* Revert "[SQL Migration] Revert dependency on new Azure Core API changes (#20469)"
This reverts commit b7a633be25.
* [SQL Migration] Add additional condition for cutover (#21178)
* Add new cutover condition
* Implement helper hasRestoreBlockingReason()
* update the default Microsoft.Build.Sql version used by sql projects
* update Microsoft.Build.Sql SDK version
* update baselines and template to also use 0.1.7-preview
* Extension unit tests continue on error
* Fix script syntax issue.
* Block syntax issue
* Remove condition expression
* Brings back condition for sql product build linux yml
* Comment out condition in ci.yml
* Adds continue on error clause to ci.yml extension unit tests
* Adds condition to extension unit tests step in ci.yml
* Adds run extension unit test case for fail on error
* Adds fail on error case to Run Extension Unit Tests script
* Explicitly states continue on error false.
* Format adjustment to yml file
* Changes default state to fail on error
* Update .github/workflows/ci.yml
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Update build/azure-pipelines/linux/sql-product-build-linux.yml
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Update build/azure-pipelines/linux/sql-product-build-linux.yml
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Brings back original comment.
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Adding column resize keyboard shortcuts in slickgrid
* Switching to standard keyboard evt
* Adding comment for the functionality
* Cleaning up code and adding more comments
* Using quick input to get column resize width
* Adding check for negative sizes
* Fixing some stuff
* added loading status to tree elements during refresh
* added message
* added lambda function
* added async
* moved addtraits to below null check
* Added debug lines for now
* added wip stack
* moved loading icon logic to inside tree item code
* added dispose logic
* Added comment explaining actions
* removed reference to NodeJs Timeout
* added showLoading status to Tree creation utils
* fixed spaces
* removed unnecessary space
* removed unnecessary timer for more responsive results
* removed call in connectionTreeActions test
* added fix to test
* stick to refresh only
* added 100 ms timeout
* added request comment
* Add TrustServerCertificate to request body
* Preselect all dbs for migration
* Make disabled checkbox not auto selected
* Clarify assessment results in card
* Fix incorrect number of dbs ready for migration without issues to MI
* Fix SQL DB assessment results incorrectly greying out dbs with MI blocking issues
* Revert "Clarify assessment results in card"
This reverts commit e8b83f3c19a20ba29133aaa68c4644b04d4154fe.
* Revert "Fix incorrect number of dbs ready for migration without issues to MI"
This reverts commit d4e10875d132dd218d95be91ae7d46672e247706.
* Revert "Fix SQL DB assessment results incorrectly greying out dbs with MI blocking issues"
This reverts commit e2a7dcd7352d1c215052a2f6f3f6130fc710eff8.
* Add new fields
* Fix null reference exception in SKU rec with save and close
* Remove unused files
* Warnings for in progress migrations in list view
* Fix unscrollable assessment results
* Fix updating SKU parameters before recommendations are ready
* Remove checksum info box
* Address PR feedback
* Update test naming convention from Electron to Core to avoid confusions
* Added comments
* Fix comment placement
* Remove CARBON EDIT from sql-* files
* Give saveAsExcel its own config options
* Wired up correctly
* Merge conflicts
* PR comments 1
Co-authored-by: Ben Russell <russellben@microsoft.com>
* add import permissions option to create project from db dialog
* change 'import' to 'include'
* update azdata dependency version
* update STS to 4.3.0.37
* fix test
* Adds context menu option placeholder plan container
* Adds context menu and button to add execution plan to placeholder
* Minor clean up
* Replaces taskbar with button to add execution plans
* Removes unneeded CSS styling.
* Adjusts button type to secondary
* Clarify assessment results in card
* Fix incorrect number of dbs ready for migration without issues to MI
* Fix SQL DB assessment results incorrectly greying out dbs with MI blocking issues
* Update error banner for blocked databases
* Reword error message
* Boilerplate for new context menu options
* Enables checkmarks for expensive operator context menu actions
* Updates azdataGraph version to 0.0.44
* Adds clearing logic to actions and retrieves additional info from nodes
* Removes unnecessary actions that aren't supported by other providers
* Finishes setting up the rest of the context menu actions
* Corrects context menu action label
* Defines new widget type for finding expensive operations
* Adds TODO for class icon name
* Creates action to open the expensive operation widget
* Adds escape and enter key shortcuts to findExpensiveOperation widget
* Styles find expensive operation widget
* Corrects class name for finding expensive operator action
* Corrects import statement.
* Code clean up
* Bumps azdataGraph version to 0.0.45
* Adds an info box for when a metric doesn't find any nodes
* Adds label to find expensive operator widget
* Invokes dispose when widget controller removes widget
* Implements disposable in all execution plan widgets.
* Adds off action to clear highlighting
* Adds a default setting and default prompt for highlighting metric
* Fixes not all code paths return error
* Removes shortcut key from text for widget actions
* Adds enum description
* Removes added dictionary type, and renames class name
* Removes unnecessary null checks
* Removes cost metric dictionary and adds corresponding properties
* Code review changes
* Removes incorrectly implemented key down event for widget.
* Renames widget and action class names for highlighting expensive ops
* File rename
* Cleans up labels to better reflect highlight action
* Removes hardcoded button width style and sets it to auto
* More clean up
* Clean up import statement
* Code review changes
* Drop down list only shows available metrics
* Updates highlight expensive operation icon
* Update STS version
* initial
* Fix and revert secret storage changes
* persist to file
* Add debounce and write on dispose
* Fix run
* No ext dependencies and show warning message
* Remove test stuff
* comments
* Fix tests and console logs
* allow mark tests as unstable
* fix
* fix invert
* stable and whole test suite
* docs and mark test cases as unstable
* a couple more unstable test cases
* Fixes incorrect label when plans are vertical
* Code review changes.
* Adds helper methods to get localized strings
* Helper functions moved to module level
* Renames fields from top and bottom to primary and secondary
* Set target platform for mssql vscode extension- create project from db feature
* Addressed comments
* Address comment to add EngineEdition information in vscode-mssql.d.ts
* add logging for data workspace extension
* Addressing comments
* adding back getProjectsInWorkspace() in constructor
* Add more logging in activate()
* Added username field to PG and removed defaultvalue for port
* Disabled system username for miaa. Added username to pg create notebook.
* Block system for pg username
* Remove sql username from pg create
* Add service type
* bump version for preview
* Add dev use label
* Changed postgres icon
* Fixed PG create page not displaying. Wrong type
* Fixed service type
* changed naming for admin usernames sql and pg
* sql and pg dev use fix
* Move port under service type and make storage class not required
* Fixed regex to include things like sa1 system1
* Made storage class params optional
* Added placeholder text and changed PG admin username label
* Remove backups
* Removed postgres hardcoded username in connectionstring
* Remove more postgres username hardcoded
Co-authored-by: Candice Ye <canye@microsoft.com>
* fixing icons for new ledger object SubTypes
* removing irrelevant context menu options from ledger objects in OE
* aligning LedgerDropped subtype context key specifically with the Table NodeType context key
* download Microsoft.Build.Sql sdk and extract
* cleanup extracted folder and nuget
* add constants
* cleanup
* remove package-lock.json
* making outputChannel required and some cleanup
* only download if the files aren't already there
* Add todo
* add try catches
* addressing comments
* WIP - show error message for failed SKU recommendation
* WIP - run query to get correct instance name
* WIP - integrate elastic model recommendation
* Remove private endpoint restriction text
* Add feature switch for elastic recommendation
* Clean up
* Clean up
* Misc UI fixes
* Update package.json with updated azdata dependency
* Remove unused lines
* Fix broken next button
* Vbump extension to 1.0.6
* Update SQL DB card to show number of recommendations for correct model
* Hard code enginer ver to 14 and remove extension from wizard field and notebook
* Removed hyperscale text from everywhere but links
* Made PostgreSQL into PostgreSQL server and other text changes. Removed worker nodes
* Removed coordinator node text
* Removed worker nodes from compute + storage. Changed az arc-server to server-arc. postgresParameters.ts may need
* Removed tabs for extensions, coord nodes, worker nodes, resource health, diagnose and solve
* Removed node configuation and pg version from overview and properties. Edited arialabels
* Change server group nodes to server
* Removed type from overview table and aded Preview tags
* Removed info bubble and added padding to top of title
* Removed checkbox from PG create wizard. Added link and text
* Remove engine version
* Changed naming conventions
* Removed coord and server group from variables
* Removed properties
* Removed Server table, admin username, reset password
* Removed function from notebook
* Change wording
* bump version
Co-authored-by: Candice Ye <canye@microsoft.com>
* Revert "Revert "Fix sql projects not using OutputPath in sqlproj for publishing (#19987)" (#20127)"
This reverts commit dc7522c661.
* read configuration from sqlproj
* Add more tests
* use last OutputPath in sqlproj
* Remove references to getProviderMetadataForAccount
* Fix broken next button
* Clean up
* Adding to other PR instead - Revert "Clean up"
This reverts commit 410e136c0d1dcc24b38697791801fe3b90b1ecd4.
* Adding to other PR instead - Revert "Fix broken next button"
This reverts commit 748f75daf1594694e618f946c8026cb3256c58a9.
* sql db wizard with target selection
* add database table selection
* add sqldb to service and IR page
* Code complete
* navigation bug fixes
* fix target db selection
* improve sqldb error and status reporting
* fix error count bug
* remove table status inference
* address review feedback
* update resource strings and content
* fix migraton status string, use localized value
* fix ux navigation issues
* fix back/fwd w/o changes from changing data
* Add correct host to ARM REST API calls
* Clean up
* Missed a spot
* One more comment
* Expose new function getProviderMetadataForAccount in azurecore API
* Adding a loader spinner before the options load
* removing the local var and using const
* Reducing delay between button click and loader visibility,
* Max for syncsecondary. Fix syncsecondary update.
* Update the value not the placeholder for SQL MIAA
* Disable save toolbar icon after save/update complete
Co-authored-by: Candice Ye <canye@microsoft.com>
* Re-enabled config for direct mode
* Changed name and placement
* Shortened description
* Remove pg and sql as categories for DC
Co-authored-by: Candice Ye <canye@microsoft.com>
* Include Object Types logic refactored and options fetching from DacFx
* Removed localized object types constants
* Prop name updated and references and tests updated
* updated comments
* STS vBump
* updating the test file to pass the PR Validations
* Include Objects Coming from DacFx and tests all working as expected
* Exclude Object types functionality is working as expected and Unit tests
* more refactor updates
* Updated comments and prop name
* Addressing the coments and code updates accordingly
* Updating according to the comments
* STS vbump
* These changes should be deleted with SC changes, not here
* format fixed
* options loading from profile if has profile loaded
* Removing profile file unwanted changes
* updating profiles options comment
* STS vBump
* revert STS version from this PR
* Made SQL MIAA a new tile from New Deployment
* Remove MIAA from SQL tile. Fix helptext for MIAA tile.
* Switched positions of sql miaa and pg tiles. Made New Instance have miaa instead of sql tile.
Co-authored-by: Candice Ye <canye@microsoft.com>
* refresh does not differentiate direct vs indirect
* For direct mode MIAA commands, always use --use-k8s
* Changed comment language to use ARM instead of direct and K8S API instead of indirect
Co-authored-by: Candice Ye <canye@microsoft.com>
* Adds find node button to comparison plans.
* Can search multiple nodes (improve widget UI and initialization)
* Adjusts how second plan is added to the node search widget
* Adds styling to the find node action bar
* Removes unused code
* Minor clean up
* Cleans up CSS redundancy
* Adjusts property names according to access specifiers
* Corrects find node behavior to match SSMS
* Dependency injects instantiation service
* Adds additional property to telemetry event.
* Adds undefined to getter return signatures for plans
* Adds checks around active execution plan properties
* Code review change
* Code review changes
* dropdown not supporting dynamic enablement
* paused for weekend
* Make connection mode display with capitalization but value lowercase
* Undo changes in modelviewutils
Co-authored-by: Candice Ye <canye@microsoft.com>
* If no agreements item, then do not generate an Accept Terms of Use title. Remove sql miaa agreement.
* Added back the arc-specific change
* Added back nls
Co-authored-by: Candice Ye <canye@microsoft.com>
* Update azdataGraph version to 0.0.31
* Adds icons
* Bumps azdataGraph version to 0.0.32
* Removes whitespace
* Uses icon that better adapts to color theme changes.
* Disables collapse for execution plans in plan comparison editor view
* Made kube config and context dependent on direct mode
* Make config profile a dropdown
* Re enabled config profile
Co-authored-by: Candice Ye <canye@microsoft.com>
* OptionsDialog and buttons CSS styling updates
* final css changes for sql db options tab
* modified options button into itmes list
* updated tab name
* Added removed line git blame
* OptionsMapTable logic to replace the deployment hardcoded values final
* Test modifiaction
* OptionsMApTable updates with STS and review commetns
* comments added and option string moved to constants file
* Reverting the options button css related change and will put in other PR
* converted optionsMapTable to custom type and references.
* Options prop changes and model updates
* Reset btn event method name fixed
* removed local booleanOptionDict var and using the existing one
* updated code with removed local vars
* Update to booleanOptionsDictionary name
* merged two variable to one
* Refactoring code and updating variables
* separated lookup and data array and refactor
* missing visibility
* reset logic revised and no other edgecases found
* variable names updated to meaningful
* vbump here to test the checks, sending new vbump PR separately
* Updates properties view title when the orientation changes
* Property orientation labels change when the plan orientation changes.
* Renames top and bottom containers to secondary and primary
* Minor clean up
* Removes unnecessary class members
* Promotes constants to module level
* Moves function to module level
* Renames value1 and value2 to primary and secondary
* Replaces orientation string literal type with enum
* Resolves undefined orientation bug
* Removes unused orientation getter
* Updates property table columns only
* Uses orientation enum in editor view and properties view
* Clean up
* Adding top operations to execution plans
* Adding title to links
* Fixing pr comments
* Hiding top operations icon in execution plan editor
* Reducing outline width, adding separator and removing placeholder text
* Registering TopOperationsTabView
* Added label description for RWX storage class
* Added link and description above backups
* Made field have no default value by making it plain textfield
* Made label width wider to accomodate long labels
* Better spacing for RWX. Fixed info bubble overlap
Co-authored-by: Candice Ye <canye@microsoft.com>
* Switch query events to just send ranges instead of full query text
* undo azdata changes
* fix type
* comment + remove unneeded ?
* range -> batchRanges
* undo
* Changed namespace to have empty default value. Added cluster name as a field for direct mode. Updated summary page and notebook as necessary.
* Made storage class = default if storage class is undefined
* Moved cluster name before custom location
Co-authored-by: Candice Ye <canye@microsoft.com>
* Ctrl/Cmd + m, no longer executes queries.
* Adjusts command label
* Code review changes
* Uses category parameter to categorize actual plan command
* Actual execution plan command label matches estimated plan command label
* Revert "Actual execution plan command label matches estimated plan command label"
This reverts commit 15f301dfc64341d631ca5e9b1314d8cf739b2088.
* Centralizes localized category string (#19857)
* Actual Plan action uses centralized category
Didn't notice that this had already been bumped from what was listed in the gallery (0.1.0 currently). So reverting back to 0.2.0 until after the next version is released.
* Commenting out for now, but will delete in next commit
* Adds SQL carbon edit markers
* Uses multiline comments
* Formats file
* Code review changes
* Edit comment moved to same line
* Add ts-ignore directive to unused method
* Fixing tabbing logic for tab headers
* Renaming stuff
Making null checks concise
Adding comments
* Renaming css class and interfaces from active to selected
* Renaming styling classes and objects
* Changing tabbing logic to match w3 behavior
* Fixing focus logic in tab
* Adding helper comment
* Code cleanup
* Adding arialive to flex and div container
* Fixing compilation issues
* Moving ariaLive to container properties
* fixes
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Added syncSecondaryToCommit to SQL update and create, as well as notebook, wizard, and compute+storage interfaces
* Added readable secondaries and syncSecondaryToCommit to cost and SQL MI create
* Added readable secondaries to notebook
* removed resource-deployment changes
Co-authored-by: Candice Ye <canye@microsoft.com>
* Fixed dynamic enablement
* Set to false or original logic in constructor
* Changed boolean to also undefined
* Moved comment to constructor
Co-authored-by: Candice Ye <canye@microsoft.com>
* Creates toggle button to switch between estimate and actual query plans
* Renames ID for the toggleActualExecutionPlanModeAction class
* Renames button back to explain
* Creating actual execution plans resembles SSMS
* Adds CTRL/CMD + L shortcut to display estimated execution plans
* Alphabetically organizes telemetry actions
* Adds telemetry when the setting for actual execution plan toggle is used
* Resolves build errors
* Fixes broken unit tests.
* Code review changes
* Removes unnecessary null-coalescing operator.
* Creates placeholder icons for actual execution plans enabled
* Code review changes
* Shortens label names
* Telemetry moved to toggle button
* Telemetry review changes
* Clarifies misleading label
* added filter for AsyncDataProvider Filter crash
* fixed cell switch back for editdata
* Added new setData check
* disable selecting of all columns when new row is being added
* Changed comment
* removed try catch check due to Aasim's PR
* added previous dataset to handlechange
* added feedback changes
* added fix for infinite loop
* changes made as suggested by Alan
* following Charles' feedback
* removed onGridRendered as its pointless jumping
* initilaizing the sqlproj display options work
* added more code to the options dialog, need default option values
* Except REset Button, all works and need to refactor and test
* DisplayOptions for SQL DB Proj completed, refactor needed
* Tests for display options
* refactor code and removed unnecessary await calls
* Description values getting from STS API and code refactor
* DacpacExtesnion test model error fix
* updates related to STS model updates
* Dac Deployement options model updates according to STS changes
* Undoing file updates and moving as separate PR
* Undoing vscode whitespace changes which were added accidentally
* Options display name coming from API
* Updated model with dac deploy options display names coming from the STS API
* errors fixed after merge to main
* separating model related changes after merge, separate PR exists
* wrong Comment for the test case removed
* code refactor updates
* Hyperlink changes to secondary button and style updates
* refactoring code and comments
* importing type only instead of whole azdata and comment updates
* projectcontroller test fix
* removed duplicate file updates from other PR
* code refactor according to comments
* Added dispose to the onclick handler
* Added test case
* parameter change results error and fixed
* Addressing all comments with updates
* Unused variable removed and missed with previous commit
* Updated the ppublish button and width
* Adjusted the database dropdown and options margins to make all input align in same line
* Updated the database width and moved stylings to uiconstants file
* Introduce tabs for notebook views
Cards have been restructured to contain tabs instead of cells directly.
Tabs then contain the cards that are displayed. Cards may contain one or
more cards.
The panel component has been reused to implement the cells. There is
still some cleanup left to do of unused functions, but I want to reduce
the size of the PR as much as possible.
* Adds telemetry when plan comparison is invoked
* Small formatting change.
* Adds telemetry to add execution plan button
* Removes unused ExecutionPlanComparisonEditorView constructor parameters
* Small formatting adjustment
* Adds telemetry to ExecutionPlanComparisonEditorView properties
* Code review changes
* add 'open in designer' to context menu of tables in sql projects
* fix tests
* Address comments
* enable table designer for sql database proj
* update label and issues on init
* vbump sts
* use promisified fs
* pr comments
Co-authored-by: Alan Ren <alanren@microsoft.com>
* fix page being reset twice and add back smoke test
* add missing await
* check pyarrow info loaded
* install latest package version
* fix version select box selector
* split out into two PRs
* Dac Deployement options model updates according to STS changes
* Undoing vscode whitespace changes which were added accidentally
* Updated model with dac deploy options display names coming from the STS API
* Combining all exisitng code updates into single branch/pr. it includes mssql model updates and SC/dacpac model, code and testupdates
* sql db proj test failure fix
* STS version bump to 4.0.0.4
* Adding code for execution plan comparison editor
* Handling floating promises and fixing a loc string
* Fixing some polygon stuff
* Fixing azdatagraph null check bug
* Adding progress notification for similar areas
* Removing some floating promises
* Fixing button enabled state
* Bump version of arc and azcli to 1.3.0
* Fixed refresh to do dc config show and endpoint list first, then check the connectionmode
* Await calls to refresh indirect and direct
* Made sql mi-arc delete also handle direct mode. Made customlocation for sql mi create work again, regex problem.
Co-authored-by: Candice Ye <canye@microsoft.com>
* Display cdb nodes to browse azure tree
* Update icons
* Update node label
* Remove console logs
* Fix i18n in cosmosDbMongoTreeDataProvider
* Disable Mongo provider in azure tree for now
* Revert "Disable Mongo provider in azure tree for now"
This reverts commit 8b2d2079f43624596a41b82a71a5e40eef1ad4b1.
* Fix build issues related to merge
* Add COSMOSDB_MONGO in provider extension map
* Define providerId string as constant. Rename constants to follow azurecore/ naming conventions (all caps)
* remove password enter manually - since we prompt user to include it prior
* go back to connection profile prompt
* add manual entry if connection info password is not saved
* add tests that verify all password prompt scenarios
* nit
* first wip for table menu prompt
* fix up some table prompts
* use simpleExecuteRequest
* fix table prompt scenario for sql binding also
* fix/add more testing and address comments
* add brackets to selected database
* add manually entered option
* added clickable more info links to designer validation issues
* fix selection issue
* remove more info if none
* change quote style
* clear the dom node
* format
* added buttons and initial drag plugin
* initial drag and drop working
* add actions and taskbar
* drag and drop bugfix and other changes
* fix few issues
* more changes
* fix all move and insertion issues
* PRcomments
* fit and finish comments
* remove dead code
* bump sts
* add style for object being dragged
* add plugin to copyright filter
* Add to eslintrc
* fix drag contrast ratio
* generalize logic for cell focus
* demo feedback
* feedback
* add action state
* feedback
* remove unncecessary check
* add move actions to context menu
* change to const
* fix bug with tables and fix drop color
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* Rebase from main branch
* Made mssql a module
* remove rpc specific stuff
* Added create sas RPC call
* Backup to url works now
* Moved createSas RPC to the BlobService
* Relocated createSas RPC from sql-dataprotocolclient to the mssql
* After rebase
* Removed duplicate symbol
* Renamed Blob to AzureBlob and relocated CreateSasResponse to mssql extension
* Removed AzureBlobProvider, removed AzureBlobService feature
* renamed blob to azureblob, converted thenable to promise
* Simplify API
* fixes
* docs update, blob to azureblob update
* UI design first commit
* Detected Managed Instance, trying to script backup to url
* azure subscription api added, but ADS crashes
* Created url dialog component and added link account
* Changed backup component UI logic
* Changed b/r UI, added restore from URL, detected MI from restore component
* Removed mocked and added real Azure API, changed RestoreDialog UI
* Added file fetching API
* added create sas RPC call
* Backup to url works now
* Fixed some bugs
* Moved createSas RPC to the BlobService
* Relocated createSas RPC from sql-dataprotocolclient to the mssql
* Rebase createSas changed to the backupRestoreManagedInstance
* PR comments fix
* Enabled backup to url for gov clouds
* Replaced anchor element with Link class
* Fixed pick azure account logic
* Removed duplicates from eslintrc
* Fixed url browser dialog
* Fixed restore UI, disabled url empty url browser dropdowns, fixed backup OK button
* bumped sts version
* bumped sts version
* Fix config
* Fixed URL browser dialog UX
* Backup and restore dialog fix
* Referencing azure resource types directly
* Scoped url browser dialog css classes
* Made the url browser dialog field a local variable
* moved url browser files from fileBrowser to the urlBrowser folder
* Changed deviceType from number to enum
* Added all device type options
* Moved mssql
* Added MI backup button comment
* Removed unhelpful comment
* Revert differential copy only backup mistake
* Renamed azurebrowser to urlBrowserDialog
* Localize create sas button label
* Removed unnecessary spinner
* Use UTC date instead of locale date
* Removed * and added required flag
* Use async instead of nested thens
* Added target database tooltip
* Using deferred promise instead of event emitter
* Added error handling to the url browser dialog
* Registered backup component elements
* Register backup component listeners
* Removed redundant setDefaultBackupPaths call
* Added setBackupPathList docs
* Add return types
* Remove code from comment
* Register restore dialog elements
* Register restore dialog listeners
* Pass engine edition enum instead of boolean
* Capitalize enum values
* DatabaseEngineEdition fix
* Use DeviceType instead of number
* Use deferred pointer
* Add new ModalDialogName
* Use constructor fields
* Register URL browser dialog components
* Remove unnecessary helper function
* nextYear function doc and move
* split registerListeners method
* showDialog returns promise
* Backup device type comment
* Pass aria label through constructor
* Fix backup button
* Remove comment
* Comment unsupported MI backup options
* Remove one liner helper function
* Restore dialog methods return types
* Remove comment
* JS doc format
* Renamed UrlBrowserDialog to BackupRestoreUrlBrowserDialog
* Moved MediaDeviceType, added PhisicalDeviceType
* Reorder and rename physical device type
* remove extra spaces
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* Adding ability to expand and columns tables
* Bolding icons
Fixing variable names
* Adding helper function
Making css more target
* Adding keyboard navigation and parsing treegrid data
* Adding attributes, data transformations and key events to the treegrid
* Expanded
* changing var name
* FIxing formatter name
* Adding back cell styling
* Removing comments
* Making a new TreeGrid component.
Separating treegrid logic from tableDataView
* Fixing comments
* changing method name
* Modifying only visible row dom attributes
* Removing white space, moving role attribute setter to constructor.
* Fixing some more PR comments
* Adding comments and renaming functions
* Fixing comments
* Fixing comments
* Fixing comments
* Fixing some logic and removing unused attributes from element
* Adding expandable formatter to the first column
* Making the formatter generic
* Reverting formatter code
* Adding doc comments
* Fixing comments
* Removing duplicated code
* Adding comments
* Setting columns only when the table is initialized
* Letting users set expanded state instead of forcing it to false
* Added sql upgrade management page and fixed icon for dc and sql upgrade
* Added logic for figuring out MIAA version, loading proper entries for table.
* Added PR comment changes
Co-authored-by: Candice Ye <canye@microsoft.com>
* Adds hot key combination for finding nodes in execution plans.
* Captures cmd + f key combinations for other platforms
* Stops event propagation when targeted hot key sequence is pressed
* add tab index to cell output
* add sr-only element to announce cell exe complete
* use onExecutionComplete event
* remove extra change
* simplify alert message
* add alert for cell execution start
* make sure cell is ran
* make sure dialog is gone before runing cell again
* ensure package is done installing
* show task panel
* remove comment
* pr comments
* pr comments
* add 7.0.0 package version
* Resolves cannot read property 'accessToken' of undefined.
* Checks for and specifies undefined as refreshToken return type
* Adds documentation and checks for undefined results from refreshToken
* WIP
* WIP
* WIP
* Fix location dropdown not working properly
* Clean up comments
* Switch button order in selectMigrationServiceDialog
* Vbump to 1.0.1
* Refactor to avoid duplicate API calls
* Add null checks
* Fix migration status dialog not sorting migrations properly
* Address comments, remove unnecessary code
* Address comments - separate util methods by resource type, use logError instead of console.log
* Remove unused methods
* Fix DMS creation on newly created resource group
* Fix stale account behavior
* Address comments - remove telemetry context from util method calls
* Clean up imports
* Fix dashboard service monitoring not working
* Fix null reference on database backup page, and resources not updating properly when location is changed
* Fix dashboard not auto selecting DMS after migration started
* Add null checks
* Added sqlmiaa upgrade command and params to azcli api
* Put params under args
* Removed an extra comma
Co-authored-by: Candice Ye <canye@microsoft.com>
* initial refactor
* fix projectFolder cases
* update create azure function with sql binding when no folder is opened
* corner case exit browse file
* add version since targetFramework is set to specific core tools version
* update telemetry and address comments
* use project folder instead
* fix create project from database when launched from disconnected node
* don't open dashboard
* fix tests
* update order so connection dialog opens first if can't connect
* Rebase from main branch
* Made mssql a module
* remove rpc specific stuff
* Added create sas RPC call
* Backup to url works now
* Moved createSas RPC to the BlobService
* Relocated createSas RPC from sql-dataprotocolclient to the mssql
* After rebase
* Removed duplicate symbol
* Renamed Blob to AzureBlob and relocated CreateSasResponse to mssql extension
* Removed AzureBlobProvider, removed AzureBlobService feature
* renamed blob to azureblob, converted thenable to promise
* Simplify API
* fixes
* docs update, blob to azureblob update
* bumped sts version
* Fix config
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* Removed configure retention policy link. Log errors for upgrade instead of blocking the upgrade. Changed text of version log link.
* Addressing comments on PR
Co-authored-by: Candice Ye <canye@microsoft.com>
* Fixed a connect to Server typo
* Added upgrade tab with description and title. Table is still stuck loading.
* Renamed backups to upgrades.
* Removed loading icon
* Table appearing and not stuck loading
* Saving for now to upgrade arc and azcli versions
* Added upgrade confirmation dialog, populated dummy data and added upgrade apis.
* Added parsing of versions and current version from listupgrades
* Upgrade itself not working, but added upgrade as a part of azure cli api.
* Table now populating with release dates and version numbers. Upgrade button only shows for appropriate cells. Upgrade done but no release version column.
* Changed text using PM advice
* Removed comments from controllerUpgrades.ts
* Replaced code in upgradecontroller.ts and made refresh work
* Removed one call to handleTablesUpdated
* Removed some code in upgradeControllers.ts and it still works
* removing more code for pitr refresh from upgradeController.ts
* Created and used UpgradeModel even though it is empty
* Added upgrademodel
* PR comments addressed
Co-authored-by: Candice Ye <canye@microsoft.com>
* Add sqlproj property to trace the origin of the project.
As part of the database migration process (schema conversion, in particular) we want to be able to tell when converted schemas are being built/deployed to the actual database server. Given that we rely on the SQL Database Projects ADS extension for the compilation/deployment, we don't have too many options other than updating the said extension.
The suggested approach is to make the following changes:
1) Add new property to the sqlproj file (called `DatabaseSource`), which will maintain the origin(s) of the project. The property can contain multiple values (separated by semicolon), in case same project contains objects produced by multiple sources (extract schema, convert from another database, etc.).
2) During build and deploy actions, send the well-known values from the newly added property to the telemetry. We don't want to send any random value of the property, as it may raise some privacy concerns. Instead we define a list of the well-known values that we know do not carry any personal information and send those, if they are specified.
This change adds all necessary APIs to the SQl Database projects extension which will be consumed by our migration extensions to populate new `DatabaseSource` property.
* Use `undefined` instead of `null`
Co-authored-by: Kim Santiago <kisantia@microsoft.com>
* Fix SQL Binding when creating new project
* Use sql binding templates
* fix openDialog to use select
Co-authored-by: Vasu Bhog <vabhog@microsoft.com>
* Adds telemetry around how the properties window is opened
* Adds telemetry around accessing execution plan top operations
* Adds key for viewing top operations
* Adds telemetry around using the open query button and context menu item
* Adds telemetry around execution plan zoom in, out, to fit, and custom
* Adds telemetry around searching for nodes in execution plans
* Reduces telemetry additional properties to 1.
* Code review changes
* Removes unnecessary export
* fix connectionSettingName for create azure function with sql binding
* add sql binding user enters connection string manually
* address comments + fix test
* final comments
* Adding badge icons to executionplan
* Fixing doc comment
* Fixing doc comments
* Making enum value more readable
* Changing default to undefined.
* Fixing some icon names
* Add unified col for data type deit
* remove seperate type setting cols and rename unified col to 'type'
* remove advanced type from properties window
* add description to col, idx, constraints
* nit
* bump STS to .227
* listen on focus_in of toolbar
* update styles on focus_in
* listen for active cell change on notebook componen
* add tabbing order to textcells
* remove duplicate listener
* clean up
* undo
* remove visible check from cellToolbar
* remove duplicate detectChanges on updateActiveCell
* only update active cell if it's already not
* add aria-label for accessibility
* localize the aria label
* refactor
* add cellLabel property to CellModel
* remove updateActiveCell from code component
* regression from merge fix
* set edit mode as true when focusing on cell
* moce check to model
* merge changes correctly
* update edit mode if code cell
* fixes
Co-authored-by: barbaravaldez <bavaldez@microsoft.com>
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* fix for user using command palette command
* rework if a user uses the create azure function via the command
* for now only show in vs code
* move logic to azureFunctionService + address comments
* fix command location
* address comments
* fix validateFunction
* WIP - implemented logic to show resource groups as derived from list of resources, instead of directly listing all resource groups
* Remove comments
* Remove getResourceGroupByName and craft resource group object manually instead
* Update subscription and location list when tenant is changed
* Define Azure resource types locally instead of modifying azurecore
* Add SQL VM scenario
* Split getAzureResourceGroupDropdownValues into four separate functions
* Refresh only subscription list when tenant is changed
* Create new DMS dialog should show all resource groups
* Remove unnecessary async code
* add graph icons to OE and TD
* PR comments
* change enum type
* change sub type to icon and make basic as default
* changed icontype to icon
* change default logic location
* change icon name to be more generic
* use right icons
* added graph node types from edit and publish results
* make generic property bag
* review comments
* add comment for function
* edit comment
* change name to telemetry info
* add wizard page and selected operation for dacfx wizard cancel telemetry
* update name
* send version for extract
* pass version directly into function call
* Added monitor log-analytics workspace list to az api
* Made resource group and subscription optional for logs analytics workspace list
* Added dynamic fields for workspace names, id, primary key, based on value of auto-logs checkbox
* Hooked up the newly created source provider for log analytics workspaces. Dropdown now populates all workspace names.
* Added workspaceUtils.ts for a valueprovider. Now workspace name maps to id automatically.
* Replaced promise.all with promise.resolve
* Added workspace id and primary key as env variables in the notebook
* Removed extra space in package.json
* Made getOptions more concise and put azApi definition in function.
* Changed notebook to handle new Azure CLI command with param --clustername
* add more telemetry for sql database projects
* add publishToContainer events
* send target platform when publishing
* add duration for createProjectFromDb and updateProjectFromDb
* Pushing Execution Plan Editor
* Renaming class
Handling error
* Awaiting for handlers to be registered
* Addressing some PR comments
* Fixing return type for provider
* Fixing editor id and removing unnecessary overrides
* Adding a namespace
* adding execution plan namespace
* Adding protocol comment
* Fixing if logic
* Fixing error message
* Cleaning up code
* cleanup code
* Adding help comments
* Fixing method call
* Using path.ts to get the base file name
* converting to lambda functions
* Adding comment for run action
* Fixing pr comments
* Fixing editor label
* Fixing doc comments
* Adding some more comments
* Fixign branding in comments
* add step to choose target platform in new project quickpick
* add comment
* only splice if the default target platform index isn't -1
* change 3 to 5 in comment
* Add MI ready state check and error message
* Fix a typo
* Update error message logic
* Update '(Unavailable)' prefix to be localized string
* Show error messsage when non-Ready MI is initially selected (not just on Next button)
* Update error message with appropriate casing and actionable step
* wip for refactor of mssql to sql-bindings
* remove STS dependency
* work to bring function over and setup with vscodeMsql APIs
* copy typings from vscode-mssql
* WIP
* Change instance name from machine name to full instance name returned by assessment
* Get full instance name from source connection profile instead of relying on assessment result
* Combine correct machine name with correct instance name
* Making infobox clickable
* Making it accessible
* Moving API to proposed
* Matching styling from portal
* Fixing some styling
* Moving to proposed
* Removing extra spacing
* Registering and Unregistering listeners
* Fixing listeners
* Registering emitter only once.
* Changing emitter type from undefined to void
* Adding arialabel to clickable link
* Changing property name to suit its purpose
* add ability for md + text reports
* change report type
* re add types for ads
* match fields and add enum for mimetype
* rename preview report
* update type
* rename generate report type
* fix comment
* add loadSavedInfo function in stateMachine; only open wizard if didLoadSavedInfo
* * add loadSavedInfo function in stateMachine; only open wizard if didLoadSavedInfo
* replaced savedInfo.miggrationServiceId string with sqlMigrationServer object
* selectDatbasesFromList helper function to check previously selected dbs in dbSelectorPage and sqlDatabaseTree
* * remove savedInfo references from targetSelectionPage, migrationModePage
* add selectDefaultDropdownValue helper to stateMachine to handle unify savedInfo selection logic
* add updateDropdownLoadingStatus to targetSelectionPage
* check if values exist before making api calls in statemachine
* removed savedInfo references from databaseBackupPage, integrationRuntimePage
* databaseBackupPage - targetDatabaseNames, networkShares, blobs need to rely on savedInfo as user may update the list of migrationdbs during the retry/saveAndClose
* re-add serverAssessments to savedInfo; only getAssessments if it does not exist or needs to be updated; fix networkShare type savedInfo
* rename _assessmentDbs to _databasesForAssessment; _migrationDbs to _databasesForMigration
* load blobs/networkshares savedinfo; move selectDefaultDropdownValue to utils
* fix selectDefaultDropdownValue; refreshDatabaseBackupPage when user changes target subscription or location
* protocol handler - normalize paths
* use `extUri` for normalizing paths
* :lipstick;
* Add content security policy to top level webview
This change hardens our webviews by adding a fairly restrictive csp to them. This CSP should only apply to the outer webview iframe, not to the inner iframe which is controlled by extensions
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Matt Bierner <matb@microsoft.com>
* Fixed color contrast for error message in connect a dc window.
* Remove color check for error message
* Remove more unneeded checks
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Adding telemetry for errors happening during data collection/ telemetry for sku recommendation
* log and error happended during get sku recommendation
* Resolving comments from PR https://github.com/microsoft/azuredatastudio/pull/18252. 1) Adding click and close events to dispoable collection to avoid leaks. 2) Adding readable constant for number representing minutes.
* Changes - 1) updating migration workflow strings, 2) adding more onclick events to disposable collection.
* Remove PaaS, IaaS terms from string
* Changes -
1) Renamed 'Saved assessment result' to 'saved session'.
2) Removed Title from 'saved session' page.
3) Added stop data collection on migration start.
* Initial check in for SQL migration SKU recommendation feature (#18116)
Co-authored-by: Raymond Truong <ratruong@microsoft.com>
* add TargetSelectionPage, remove AccountSelectionPage, fix saveAndClose bugs (#18092)
* update sku interfaces (#18150)
* create the skuRecommendationResultsDialog (#18151)
* add TargetSelectionPage, remove AccountSelectionPage, fix saveAndClose bugs
* create skuRecommendationResultsDialog
* Replace placeholder SKU recommendation results with actual results (#18153)
* Replace placeholder SKU recommendation results with actual backend call results
* Remove skuRecommendationExample
* Replace number fields in interfaces with correct enums, and update UI text
* add getAzureRecommendationDialog for performance collection (#18159)
* add getAzureRecommendationDialog when there are no recommendations available
* update 'get azure rec' / 'view details' link values
* add condition to check if recommendations are available
* Implement start/stop perf data collection + import perf data into new UI (#18149)
* Implement start/stop perf data collection
* add getAzureRecommendationDialog when there are no recommendations available
* update 'get azure rec' / 'view details' link values
* add condition to check if recommendations are available
* Implement import existing data + start/stop perf collection with new UI
Co-authored-by: Rachel Kim <rackim@microsoft.com>
* Expose SqlInstanceRequirements in SKU recommendation results (#18207)
* Expose SqlInstanceRequirements
* Move string literals to constants file
* Fix formatting in mssql.d.ts
* create storage properties table (#18215)
* Edit sku recommendation parameters (#18244)
* Edit sku recommendation parameters
* make _targetPercentileDropdown not editable; styling updates
* Azure recommendation section exposes data collection status and stop option (#18246)
* Edit sku recommendation parameters
* create azure recommendation details section on sku page
* Improve error handling + add auto refresh + other small changes (#18228)
* Update source properties table
* WIP - refresh perf data collection
* Add auto refresh logic
* Address comments
Co-authored-by: Rachel Kim <rackim@microsoft.com>
* Show/hide azure recommendation components based on data collection source and status (#18254)
* add refresh recommendation button; show/hide content based on perf collection status
* show/hide azure rec content based on perf data source scenarios
* add popups for start/stop; allow user to restart data collection; add perf collection to save close; add info tooltips (#18278)
* Update SKU recommendation timer logic (#18281)
* Update timer logic
* Fix misc UI bugs
* update sql migration extension readme (#18295)
* Remove empty constant, as this may have broken the build
* Fix 'save and close' behavior for SKU recommendation (#18301)
* Update timer logic
* Fix misc UI bugs
* 'WIP'
* Add logic to restore correct SKU recommendation state when reloading
* SKU UX enhancements - status info, button validations, savedInfo logic (#18320)
* add stop/inprogress status icons to perf collection status text, update restart icon
* refactor savedInfo as an interface, edit parameter recommednations are saved, add open folder inputbox validation, handle no recommendations available scenario
* fix getazureredialog bug, cleanup cold
* nit card styling
* Update recommendations whenever user changes list of databases to assess + misc clean up (#18323)
* Consolidate constants, clean up redundant functions, misc clean up
* Remove old SKU recommendation interfaces
* Update some more strings
* Telemetry events for SKU Recommendation (#18282)
* Telemetry events for SKU Recommendation
* Addressing comments -
1) fixed camel casing
2) removed extra logging to console
3) added telemetry for subid, rg, tenantid on targetselectionpage
* Resolving conflicts
* Addressing comments - 1) removing filename 2) moving all numbers to measurements.
* Resolving comment - Fixing telemetry value for tenant id.
* removing warning 'logError' is declared but its value is never read (#18333)
* Stop existing data collection when leaving and starting a new migration + update timers (#18339)
* Refresh recommendations when pressing stop data collection button
* Fix orphaned data collection when save and closing and starting a new
migration
* Revert "Refresh recommendations when pressing stop data collection button"
This reverts commit e6fb2ade8f8a41952adb81cb0ee852414dfa4ef2.
* Update timers to use production values
* Remove unused import
* address bug bash issues: add learn more link, add last refreshed time, fix vm card view detail open issue, remember last selected folder, remove strings, refactor refresh logic on sku page (#18340)
* Address comments
* Update to sqltoolsservice 3.0.0-release.204
Co-authored-by: Rachel Kim <rackim@microsoft.com>
Co-authored-by: Neetu Singh <23.neetu@gmail.com>
* Removed extra backup policy field in MIAA deploy. Re-ordered fields in MIAA deploy for parity.
* Enabled dynamic options to work with categoryvalue type objects.
* Removed defaultValue CategoryValue typing, fixed some type checks.
* Added a clarifying comment to setModelValues and removed unnecessary type from defaultValue
* Removed CategoryValue from selection
* Undo parenthesis for single type
* add new articles to help section
* Update extensions/sql-migration/src/dashboard/sqlServerDashboard.ts
* fix typo, remove link
* remove locale in links
Co-authored-by: Mohamed Kabiruddin <39162740+mokabiru@users.noreply.github.com>
* Vbumping sts to get latest qp code
* Updating azdataGraph in remote package.json
* Revert "Updating azdataGraph in remote package.json"
This reverts commit 704aa6b653b20c6bc439ba2ac46f4dcdead0128d.
* add sdk style project template
* update description and order
* add SDK style project option to create project from db dialog
* fix test
* switch to checkbox
* remove not used string
* fix test
* Changed instances of sql edit to sql update
* Updated az sql mi-arc edit to be update. Changed the params for indirect and direct mode.
* Removed preview from everywhere in arc and azcli extensions.
* Bumped version numbers for both extensions and removed preview bool in package.jsons
* rough changes for adsweb-lite
* commit id of latest quality
* fix for aria label
* distro commit id changes
* merged latest changes distro id
* python path changes + quality name change
* Hide container views/settings/panel for ADSWeb
* undo unintentional change
* No python prompt changes for tsgops-image
* distro id changed for tsgops quality name
* changed quality name to tsgops
* changed name to tsgops-image
* python address change
* unintended changes undo
* correct python installation path for tsgops
* enable preview features tsgops
* no prompt for tsgops-lite image
* revert preview feature change
* Fixes for few comments
* removed extra line
* add deleted line
* Addressed comments
* Addressed final comments
* eslint error fix
* fix
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
* added server infor and metrics for table designer
* update generate script
* pr comments
* format more files
* pr comments
* make changes to core
* remove unused imports
* add server info
* revert enum change and add publish event
* format doc
* nitpicks
* remove os version
* remove modifier from telemetry info
* remove error message
* Also reduced the number of timeouts for waiting on notebook provider descriptors, and fixed an issue with undefined cancellation tokens in vscode notebook conversion code.
* set mode explicitly to notebook
* move setMode to untitledNotebookInput
* wait until input is resolved for setMode
* invoke only when textInput is undefined
* pass the untitledTextInput in test
* add sdk style project template
* update description and order
* update template
* update template and add link
* remove ToolsVersion and xmlns from project node
* update template name to SQL Database (SDK)
* Adding initial boilerplate for qp2
* Adding feature flag in query plan 2
* Clearing show plan 2 after every run
* Adding sub tree cost
* removing unused method.
* WIP 2
* Adding properties view and relative cost to query plan
* WIP
* Add icons to ads
* Assing relative costs and prop windows
* Enabling older query plan again
* Making some PR fixes
* Some more PR related fixes
* Use MS org azdataGraph module
* Moving new properties to azdata proposed.
* Moving new class properties to proposed
* added missing doc component.
* Changing how azdatagraph package is referenced
* Removing empty lines, fixing localization keys
* Removing empty line, localizing some string
* making css classes more specific
* making some logic concise
* localizing some more strings
* Making more css classes specific
* Removing important tag from css props
* Checking if sum is greater than 0 to prevent divide by zero exceptions
* Fixed loader error in bootstrap
* Fixing query index
* -fixing image paths
-making css class more class specific by using nested selectors
Co-authored-by: kburtram <karlb@microsoft.com>
* load name and options from publihs profile for vscode publish quickpick
* fix when a publish profile doesn't have the target db name
* update condition
* simplify
* save changes
* refactoring
* update height
* Register undo redo command (#17948)
* register undo redo command
* sql-migration vbump 0.1.12 (#17955)
* fix pre/post deploy scripts getting double counted in the files for sdk style projects (#17954)
* fix pre/post deploy scripts getting double counted in the files for sdk style projects
* add test
* update comment
* vbump sql database projects to 0.15.0 (#17956)
* LEGO: check in for main to temporary branch. (#17957)
* null check before calling isDisposable (#17959)
* Updated credentials system (#17888)
* linting
* added flags
* remove testing values
* format
* format doc
* tested in linux
* remove unused interface
* comments
* review comments
* clean imports
* pr comments
* format doc
* changed promise location
* insiders december
* pr comments
* test ado change
* fix test
* comment out code for hygiene
* remove unused imports
* test creds from client only
* remove unused import
* trying enabling keytar
* trying enabling keytar
* disable in correct script
* print statements
* remove print statements
* check mock output
* add linux check
* remove print statements
* Consolidate INotebookEditOperation interfaces (#17944)
* Add redo action for split cells (#17947)
* add redo action for split cells
* Handle delete folder for SDK style sql projects (#17961)
* handle delete folder for sdk style projects
* cleanup
* compare original sqlproj contents
* remove redundant checks
* enable find in cell output when output is a data stream (#17759)
* initial changes
* add isCodeOutput and apply decorations on output
* Add extension gallery update reminder action (#17644)
* Fix extensionsGallery.json name (#17646)
* Remove galleries list action (#17648)
* multi-level table support (#17638)
* multi-level table support
* comments
* address comments
* add period to end of sentence.
* Show connection string example for add sql binding quickpick (#17650)
* add connection string example
* reorder
* Resolves same-origin-policy violation when ADS web is running in a container (#17555)
* Stops appending port to authority for web mode
* Clarifies comment
* Adds missing sql carbon edit tag
* vbump STS (#17653)
* use latest STS (#17658)
* Refactoring readProjFile() (#17637)
* move reading project parts to different helper functions
* cleanup
* remove comment
* addressing comments
* Corrects Web Build Pipeline ENOENT Error (#17656)
* Checks for successful directory creation
* Revert "Checks for successful directory creation"
This reverts commit 372409ef323f0d82e11992bc7bc33d607a7d5581.
* Checks for the existence of the logs directory before accessing.
* Adds SQL carbon edit comment
* Removing call to copy from non-existing directory.
* Removes unneeded import
* Checks for file existence before copying.
* Provides explanation for modification
* Replaces file existence check with exception handling.
* Bump tools service (#17671)
* Apply changes from Remote Database to sqlproj - mssql changes (#17655)
* update project from database
* update project from database
* update project from database
* Re-adding schemaComparePublishChanges for temporary backcompat
* Adding comment for keeping enum values in sync
* Correcting enum value
Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>
* update add file/folder for msbuild sdk style projects (#17660)
* update add file for msbuild sdk style projects
* also handle add folder
* fix comment
* fix issue reported by component governance (#17678)
* update json-schema version
* remove unused packages
* update package.json
* SQL Binding: Give default connection setting name (#17659)
* show sqlconnectionstring in quickpick
* fix duplicate sqlconnectionstring setting
* add (new)
* add sqlconnectionstring as default setting name
* check if sqlconnectionstring already exists
* Provide aria-labels for node checkboxes in the tree view. (#17676)
During accessibility testing, it was discovered that screen reader does not announce what checkboxes in the tree view represent. It was merely announcing "checkbox unchecked", so it was not clear without visuals which checkbox the focus is on.
This change sets an `aria-label` of the checkbox elements to match the label of the owning tree node. This way the announcement becomes "My Node; checkbox; unchecked". This is fine as a quick solution to the problem, but in the future we may want to consider adding additional checkbox label property to the nodes exposed by the tree provider, so that each checkbox can announce additional information, if needed.
* Respect ARIA label specified int he tree component options. (#17674)
During accessibility testing it was discovered that tree view in our wizard reads "Tree Node tree view" instead of the proper label that is specified. It turned out to be the problem with the tree component, where `ariaLabel` was hardcoded to "Tree Node", instead of the one provided in the options.
This change addresses the problem by passing through `ariaLabel` from the options object to the underlying tree control. I also removed the default `Tree Node` hardcoded label, as it didn't make much sense. This does mean that all tree-views that do not explicitly specify their aria-label will now get an empty label. I think this is better than having unrelated, unlocalized `Tree Node`.
I'm also worried about changes to the `ariaLabel` property after the component was initialized. I updated the code to propagate the value to the underlying tree view in the `setProperties` override of the tree component and hope that it will take care of it.
* Fix sql projects net6 warnings (#17673)
* fix .net 6 error showing on startup
* fix double warning
* addressing comments
* update key string
* undo adding space in net core sdk location setting (#17684)
* update names for msbuild sdk style projects (#17677)
* update names for msbuild sdk style projects
* remove msbuild from names
* update comments
* Designer: property descriptions (#17668)
* format
* added strings
* format doc
* use codicon instead
* show descriptions in property pane only
* fix ssdt string bug
* fix overflow option
* review comments
* review comments
* changes
* sts 156 vbump (#17683)
* Sql Binding: Add "Check out pane for more details" when nuget package download fails (#17680)
* check output for more details
* detail error
* wait for result from showerrormessage
* [Loc] Update to sql-database-projects and sql.xlf (#17687)
* update the vmImage for build jobs (#17689)
* update vmImage for windows build
* update tar command
* use specific macos version
* support building msbuild sdk style projects (#17675)
* support building msbuild sdk style projects
* fixes after merge
* add foreign keys and constraints (#17697)
* foreign keys and constraints
* refactoring
* fix issues
* properties pane improvements (#17700)
* [Loc] update to tabledesignercomponentinput (#17704)
* Add instructions for developing VS Code version of sql-database-projects (#17705)
* Adding UI for deploying a db proj to docker (#17495)
* code refactoring (#17706)
* Improve accessibility for wizard steps navigation (#17669)
Our extension is relying on the wizard dialog. During accessibility testing it was discovered that wizard step buttons are being reported as links by the screen reader (NVDA, JAWS). Claimed expected behavior by the tester is that they should be announced as buttons.
I discussed this issue with accessibility SMEs and they said it is perfectly fine to keep them as links. They did mention that they would probably design the UX differently from the start, but given that we already have it this way, links are fine. They did suggest to add few additional ARIA attributes to the link elements:
- `aria-current="step"` if the link is for the currently active step. This literally just announces "current step" at the end, when you focus on a link
- `aria-disabled="true"` makes it say "**unavailable**; link; *<step number>*" when in NVDA "browse" mode and move to the grayed-out link.
So this change implements the said improvements.
* bump sts version to 159 (#17709)
* LEGO: check in for main to temporary branch. (#17699)
* LEGO: check in for main to temporary branch. (#17702)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* [Loc] update to sql-database-projects (#17713)
* LEGO: check in for main to temporary branch. (#17715)
* Register additional editor overrides when adding new notebook file types (#17708)
* Also standardized file extension contributions to always start with a period, and to always do lower case string comparisons for file extensions.
* input width in designer (#17714)
* Add additional properties to wizard page navigation events (#17716)
* Fix open external not working (#17717)
* save password checkbox fix (#17718)
* save password checkbox fix
* remove code to reset the checkbox value
* allow build to continue when cache task fails (#17720)
* cache task should not fail the build
* update cachesalt
* Fix language flavor change on connection when in sqlcmd mode (#17719)
* Fix language flavor change on connection when in sqlcmd mode
* comment + fix
* LEGO: check in for main to temporary branch. (#17722)
* LEGO: check in for main to temporary branch. (#17724)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* Update one more variable name for sdk style projects (#17710)
* LEGO: check in for main to temporary branch. (#17725)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* LEGO: check in for main to temporary branch. (#17726)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* LEGO: check in for main to temporary branch. (#17730)
* Fix "unsupported version" error when adding sql binding package (#17721)
* Apply changes from remote database to sqlproj - schema-compare changes (#17679)
* update project from database
* update project from database
* Merge from main
* Removing dupe test stub
* PR feedback
* cleanup
* PR feedback
* Fixing tests, adding stubs to update sqlproj as schema compare target
* updating code comment
Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>
* [Loc] Update to schema-compare XLF (#17733)
* Enabled deployment of Azure Arc data controllers in directly connected mode (#17707)
* Added fields for connectivity mode, custom loc, auto-metrics, auto-logs, and the dynamic enablement of such fields.
* Changed the description of the data controller details page.
* Change notebook params to work for direct mode
* Added login to dc deployment notebooks
* Fixed auto upload metrics and logs true/false, separated login into another cell.
* Removed localization of indirect and direct connectivity labels.
* Fix ordering of reading sqlproj Build Includes and Removes (#17712)
* evaluate includes and removes in order in sqlproj
* fix after merge
* fix comment
* update comment
* Add resource deployment samples for (#17734)
* Update remove file for sdk style sql projects (#17688)
* add support for removing file in new style project
* fix test
* only load files, not whole project when checking if a <Build Remove> needs to be added
* merge changes
* fixes after merge
* [Loc] update to Arc XLF (#17737)
* Bump to latest version of azdata (#17735)
* Remove .net 6 version cutoff for building sql projects (#17736)
* remove .net 6 version cutoff for building sql projects
* Revert "Warning when .NET 6 SDK is detected (#17422)"
This reverts commit 2ed8aeb565.
* add back skipVersionSupportedCheck
* add back return false
* addressing comments
* [Loc] update to sql-database-projects xlf (#17743)
* Add additional notebook tests for handling relative links. (#17739)
* [Loc] Fix for duplicate strings in LCL files (#17756)
* WIP spanish lcl duplicate removal
* Revert "WIP spanish lcl duplicate removal"
This reverts commit 5f943153ec8980849a045c8bf7256d852571a778.
* fix for duplicate strings
* removed spaces
* Fixes ADS Web bug around copying user codes and opening a browser tab when adding an Azure Account. (#17760)
* Fixes bug around copying user codes and opening a browser tab.
* Code review changes
* Additional review changes.
* Unnecessary import removed
* Editing pipeline ACR service connection endpoint to the latest one created (#17767)
* using the new registry endpoint
* updating the service connection
* Changing the name of acr service endpoint to SqlToolsContainer
* Updating web build acr endpoint as well.
* Notebooks: Add Tooltips for Link/Image Buttons on Markdown Toolbar (#17763)
* Add title for tooltips
* Tweak tooltips
* Added UI for user to accept EULA when deploying sql proj to docker container (#17762)
* fix sorting bug (#17769)
* fix sorting bug
* comments
* Set default radio button selection, evaluate default component popula… (#17764)
* Set default radio button selection, evaluate default component population off of selection instead of unprocessed input
* rename var
* if -> switches
* Remove project radio buttons because they require commands that aren't yet checked in (and fail as a result)
* Added fix for Publish Target Label Position (#17771)
* Added fix for Publish Target Label Position
* renamed checkbox
* LEGO: check in for main to temporary branch. (#17775)
* LEGO: check in for main to temporary branch. (#17778)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* update dashboard taskbar separator (#17779)
* remove comments
* fix applying decorations
* add test
* enable find in sql result set
* add tests and update sql results highlight logic
* calculate the outputComponent index
* fix editor issues later
* remove newline replace on search
* address comments
* fix highlight issue
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
Co-authored-by: Lucy Zhang <luczhan@microsoft.com>
Co-authored-by: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com>
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com>
Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>
Co-authored-by: Alexander Ivanov <nahk-ivanov@users.noreply.github.com>
Co-authored-by: Aditya Bist <adbist@microsoft.com>
Co-authored-by: Sai Avishkar Sreerama <74571829+ssreerama@users.noreply.github.com>
Co-authored-by: Alex Ma <alma1@microsoft.com>
Co-authored-by: Leila Lali <llali@microsoft.com>
Co-authored-by: csigs <csigs@users.noreply.github.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: Candice Ye <candiceye@berkeley.edu>
Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>
* Remove undo/redo listeners from notebook component (#17966)
* remove undo/redo hostlisteners
* fix table focus issue (#17970)
* fix table focus issue
* fix hygiene error
* web
* new sts
* add await
* pr comments
* comments
Co-authored-by: Barbara Valdez <34872381+barbaravaldez@users.noreply.github.com>
Co-authored-by: brian-harris <61598682+brian-harris@users.noreply.github.com>
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: csigs <csigs@users.noreply.github.com>
Co-authored-by: Aditya Bist <adbist@microsoft.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Maddy <12754347+MaddyDev@users.noreply.github.com>
Co-authored-by: Lucy Zhang <luczhan@microsoft.com>
Co-authored-by: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com>
Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com>
Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>
Co-authored-by: Alexander Ivanov <nahk-ivanov@users.noreply.github.com>
Co-authored-by: Sai Avishkar Sreerama <74571829+ssreerama@users.noreply.github.com>
Co-authored-by: Alex Ma <alma1@microsoft.com>
Co-authored-by: Leila Lali <llali@microsoft.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: Candice Ye <candiceye@berkeley.edu>
Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>
* Start rerouting VSCode cell execution APIs.
* Add more conversion code.
* Convert VSCode notebook registrations into ADS equivalents.
* Update vscode notebook provider kernels when notebook controller's supportedLanguages are set.
* Update an error message.
* Add another session argument.
* Add base classes for converting notebook serializers.
* Disable some vscode notebook methods.
* Disable more vscode APIs.
* Disable more stuff.
* Start implementing serializer notebook data conversions.
* Use direct references to extension host notebook methods, rather than azdata ones.
* Add a comment.
* Remove a space.
* Use import type to fix module loading errors.
* Use internal cancellation token class.
* Start adding cell output conversion.
* Convert data from byte array to a string.
* More output work.
* Use a Set for proxy filtering.
* Start adding tests.
* Include metadata in cell conversion. Fix other test failures.
* Fix serialize tests.
* Add more tests.
* Remove wildcard characters from vscode filenames.
* Start implementing session details.
* Add more kernel info.
* Add kernel spec.
* Add Future callback wrapper class.
* Start implementing execute conversion.
* Pass notebook URI to requestExecute.
* Start working on CellExecution methods.
* Move some code around to fix layering issues.
* Use proxy to access browser code, rather than direct imports.
* Move files around to fix layering issues.
* Remove unused imports.
* Start implementing some notebook cell execution behaviors.
* Revert some unnecessary extHost API changes.
* Check for nbformat.
* Also handle nbformat in serialize case.
* Active notebook extensions when resolving NotebookInput.
* Fix nbformat handling.
* Disable VSCode notebooks code.
* Filter out notebook services from registration assertion.
* Wait for providers to load before calling canResolve.
* Use controller's viewType for notebook provider ID, instead of controller ID.
* Start adding extHostNotebook tests for new APIs.
* Re-order proxy calls.
* Remove commented code.
* Move vscode provider files to browser folder. Fix RPC serialization issues by using readonly field instead of getter for providerId.
* Add a comment.
* Remove unnecessary dispose call.
* Handle disposable from registerExecuteProvider.
* Remove a comment.
* Remove unnecessary provider fields.
* Remove reference to notebook service to fix circular reference issue in stringify.
* Add object types for methods in ADSNotebookController.
* Wait for controller languages to be ready before marking session manager as ready.
* Add correct promise.
* Add undefined return type for optional supportedLanguages property.
* Refine promise logic.
* Move vscode functionality back to ExtHostNotebook, since the NotebookService can't be passed back over RPC (some kind of circular reference error).
* Fix remaining issues from last commit.
* Replace "not implemented" methods with placeholder return types in order to enable testing.
* Also wait for execution handler to be set before marking session manager as ready.
* Fix usage of NotebookRegistry when updating provider description languages.
* Refine file extension conversion.
* Fix file extension conversion to match ADS extension behavior.
* Emit new provider registration event when adding supported languages.
* Remove checks for duplicate file providers and kernels.
* Fix a test failure.
* Fix file extension parsing.
* Use default executeManager if one isn't defined for provider in notebookModel.
* Add descriptors for waiting on standardKernels registration.
* Increase timeout
* Add an error message.
* Start working on retrieving default kernel from registered providers, rather than always falling back to SQL.
* Revert "Start working on retrieving default kernel from registered providers, rather than always falling back to SQL."
This reverts commit 1916ea1ce3a0072f51bec683116dc7bb6c7aefdc.
* Emit activation events after provider registration.
* Wait on standard kernels availability when getting an execute provider.
* Throw an error if session manager isn't ready yet.
* Actually resolve language promise correctly.
* Add some checks for undefined notebook data objects.
* Create kernel spec data correctly.
* Add extension changes for local testing only.
* Clean up test class.
* Add a reminder comment.
* Undo commented out notebook stuff
* Temporarily hard code default kernel.
* Retrieve default kernel in notebookModel if it's not already provided.
* Revert an import change.
* Remove unnecessary method from extHostNotebook.
* Move an interface around.
* wip
* Check for proposed API for some VSCode extHost methods.
* Remove a comment.
* Fix notebookUtils tests.
* Fix notebookModel tests.
* Fix notebookFindModel tests.
* Fix notebookViewsExtension tests.
* Fix remaining notebookView tests.
* Refactor output conversion functionality into separate methods.
* Update some unit tests for output conversion.
* Move a method.
* Rename conversion methods to fit acronym styling.
* Add another conversion test case.
* Revert local testing changes.
* Remove old method.
* cleanup
* Remove some comments.
* Move localized string to locConstants.
* Add a space to loc string.
* Add comments to new SQL Carbon Edit tags.
* Create constants for nbformat and nbformat_minor.
* Move some vscode-only fields to proposed APIs.
* Check for valid state
* Properly null check
* Adding logging for provider wait timeouts.
* wip update
* Fix compile
* Switch to cell edits
* Update docs
* Remove custom output type
* cleanup
* fix
* cleanup
* more cleanup
* Fixes
* Fix tests and lint errors
Co-authored-by: Cory Rivera <corivera@microsoft.com>
* initial changes
* add isCodeOutput and apply decorations on output
* Add extension gallery update reminder action (#17644)
* Fix extensionsGallery.json name (#17646)
* Remove galleries list action (#17648)
* multi-level table support (#17638)
* multi-level table support
* comments
* address comments
* add period to end of sentence.
* Show connection string example for add sql binding quickpick (#17650)
* add connection string example
* reorder
* Resolves same-origin-policy violation when ADS web is running in a container (#17555)
* Stops appending port to authority for web mode
* Clarifies comment
* Adds missing sql carbon edit tag
* vbump STS (#17653)
* use latest STS (#17658)
* Refactoring readProjFile() (#17637)
* move reading project parts to different helper functions
* cleanup
* remove comment
* addressing comments
* Corrects Web Build Pipeline ENOENT Error (#17656)
* Checks for successful directory creation
* Revert "Checks for successful directory creation"
This reverts commit 372409ef323f0d82e11992bc7bc33d607a7d5581.
* Checks for the existence of the logs directory before accessing.
* Adds SQL carbon edit comment
* Removing call to copy from non-existing directory.
* Removes unneeded import
* Checks for file existence before copying.
* Provides explanation for modification
* Replaces file existence check with exception handling.
* Bump tools service (#17671)
* Apply changes from Remote Database to sqlproj - mssql changes (#17655)
* update project from database
* update project from database
* update project from database
* Re-adding schemaComparePublishChanges for temporary backcompat
* Adding comment for keeping enum values in sync
* Correcting enum value
Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>
* update add file/folder for msbuild sdk style projects (#17660)
* update add file for msbuild sdk style projects
* also handle add folder
* fix comment
* fix issue reported by component governance (#17678)
* update json-schema version
* remove unused packages
* update package.json
* SQL Binding: Give default connection setting name (#17659)
* show sqlconnectionstring in quickpick
* fix duplicate sqlconnectionstring setting
* add (new)
* add sqlconnectionstring as default setting name
* check if sqlconnectionstring already exists
* Provide aria-labels for node checkboxes in the tree view. (#17676)
During accessibility testing, it was discovered that screen reader does not announce what checkboxes in the tree view represent. It was merely announcing "checkbox unchecked", so it was not clear without visuals which checkbox the focus is on.
This change sets an `aria-label` of the checkbox elements to match the label of the owning tree node. This way the announcement becomes "My Node; checkbox; unchecked". This is fine as a quick solution to the problem, but in the future we may want to consider adding additional checkbox label property to the nodes exposed by the tree provider, so that each checkbox can announce additional information, if needed.
* Respect ARIA label specified int he tree component options. (#17674)
During accessibility testing it was discovered that tree view in our wizard reads "Tree Node tree view" instead of the proper label that is specified. It turned out to be the problem with the tree component, where `ariaLabel` was hardcoded to "Tree Node", instead of the one provided in the options.
This change addresses the problem by passing through `ariaLabel` from the options object to the underlying tree control. I also removed the default `Tree Node` hardcoded label, as it didn't make much sense. This does mean that all tree-views that do not explicitly specify their aria-label will now get an empty label. I think this is better than having unrelated, unlocalized `Tree Node`.
I'm also worried about changes to the `ariaLabel` property after the component was initialized. I updated the code to propagate the value to the underlying tree view in the `setProperties` override of the tree component and hope that it will take care of it.
* Fix sql projects net6 warnings (#17673)
* fix .net 6 error showing on startup
* fix double warning
* addressing comments
* update key string
* undo adding space in net core sdk location setting (#17684)
* update names for msbuild sdk style projects (#17677)
* update names for msbuild sdk style projects
* remove msbuild from names
* update comments
* Designer: property descriptions (#17668)
* format
* added strings
* format doc
* use codicon instead
* show descriptions in property pane only
* fix ssdt string bug
* fix overflow option
* review comments
* review comments
* changes
* sts 156 vbump (#17683)
* Sql Binding: Add "Check out pane for more details" when nuget package download fails (#17680)
* check output for more details
* detail error
* wait for result from showerrormessage
* [Loc] Update to sql-database-projects and sql.xlf (#17687)
* update the vmImage for build jobs (#17689)
* update vmImage for windows build
* update tar command
* use specific macos version
* support building msbuild sdk style projects (#17675)
* support building msbuild sdk style projects
* fixes after merge
* add foreign keys and constraints (#17697)
* foreign keys and constraints
* refactoring
* fix issues
* properties pane improvements (#17700)
* [Loc] update to tabledesignercomponentinput (#17704)
* Add instructions for developing VS Code version of sql-database-projects (#17705)
* Adding UI for deploying a db proj to docker (#17495)
* code refactoring (#17706)
* Improve accessibility for wizard steps navigation (#17669)
Our extension is relying on the wizard dialog. During accessibility testing it was discovered that wizard step buttons are being reported as links by the screen reader (NVDA, JAWS). Claimed expected behavior by the tester is that they should be announced as buttons.
I discussed this issue with accessibility SMEs and they said it is perfectly fine to keep them as links. They did mention that they would probably design the UX differently from the start, but given that we already have it this way, links are fine. They did suggest to add few additional ARIA attributes to the link elements:
- `aria-current="step"` if the link is for the currently active step. This literally just announces "current step" at the end, when you focus on a link
- `aria-disabled="true"` makes it say "**unavailable**; link; *<step number>*" when in NVDA "browse" mode and move to the grayed-out link.
So this change implements the said improvements.
* bump sts version to 159 (#17709)
* LEGO: check in for main to temporary branch. (#17699)
* LEGO: check in for main to temporary branch. (#17702)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* [Loc] update to sql-database-projects (#17713)
* LEGO: check in for main to temporary branch. (#17715)
* Register additional editor overrides when adding new notebook file types (#17708)
* Also standardized file extension contributions to always start with a period, and to always do lower case string comparisons for file extensions.
* input width in designer (#17714)
* Add additional properties to wizard page navigation events (#17716)
* Fix open external not working (#17717)
* save password checkbox fix (#17718)
* save password checkbox fix
* remove code to reset the checkbox value
* allow build to continue when cache task fails (#17720)
* cache task should not fail the build
* update cachesalt
* Fix language flavor change on connection when in sqlcmd mode (#17719)
* Fix language flavor change on connection when in sqlcmd mode
* comment + fix
* LEGO: check in for main to temporary branch. (#17722)
* LEGO: check in for main to temporary branch. (#17724)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* Update one more variable name for sdk style projects (#17710)
* LEGO: check in for main to temporary branch. (#17725)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* LEGO: check in for main to temporary branch. (#17726)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* LEGO: check in for main to temporary branch. (#17730)
* Fix "unsupported version" error when adding sql binding package (#17721)
* Apply changes from remote database to sqlproj - schema-compare changes (#17679)
* update project from database
* update project from database
* Merge from main
* Removing dupe test stub
* PR feedback
* cleanup
* PR feedback
* Fixing tests, adding stubs to update sqlproj as schema compare target
* updating code comment
Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>
* [Loc] Update to schema-compare XLF (#17733)
* Enabled deployment of Azure Arc data controllers in directly connected mode (#17707)
* Added fields for connectivity mode, custom loc, auto-metrics, auto-logs, and the dynamic enablement of such fields.
* Changed the description of the data controller details page.
* Change notebook params to work for direct mode
* Added login to dc deployment notebooks
* Fixed auto upload metrics and logs true/false, separated login into another cell.
* Removed localization of indirect and direct connectivity labels.
* Fix ordering of reading sqlproj Build Includes and Removes (#17712)
* evaluate includes and removes in order in sqlproj
* fix after merge
* fix comment
* update comment
* Add resource deployment samples for (#17734)
* Update remove file for sdk style sql projects (#17688)
* add support for removing file in new style project
* fix test
* only load files, not whole project when checking if a <Build Remove> needs to be added
* merge changes
* fixes after merge
* [Loc] update to Arc XLF (#17737)
* Bump to latest version of azdata (#17735)
* Remove .net 6 version cutoff for building sql projects (#17736)
* remove .net 6 version cutoff for building sql projects
* Revert "Warning when .NET 6 SDK is detected (#17422)"
This reverts commit 2ed8aeb565.
* add back skipVersionSupportedCheck
* add back return false
* addressing comments
* [Loc] update to sql-database-projects xlf (#17743)
* Add additional notebook tests for handling relative links. (#17739)
* [Loc] Fix for duplicate strings in LCL files (#17756)
* WIP spanish lcl duplicate removal
* Revert "WIP spanish lcl duplicate removal"
This reverts commit 5f943153ec8980849a045c8bf7256d852571a778.
* fix for duplicate strings
* removed spaces
* Fixes ADS Web bug around copying user codes and opening a browser tab when adding an Azure Account. (#17760)
* Fixes bug around copying user codes and opening a browser tab.
* Code review changes
* Additional review changes.
* Unnecessary import removed
* Editing pipeline ACR service connection endpoint to the latest one created (#17767)
* using the new registry endpoint
* updating the service connection
* Changing the name of acr service endpoint to SqlToolsContainer
* Updating web build acr endpoint as well.
* Notebooks: Add Tooltips for Link/Image Buttons on Markdown Toolbar (#17763)
* Add title for tooltips
* Tweak tooltips
* Added UI for user to accept EULA when deploying sql proj to docker container (#17762)
* fix sorting bug (#17769)
* fix sorting bug
* comments
* Set default radio button selection, evaluate default component popula… (#17764)
* Set default radio button selection, evaluate default component population off of selection instead of unprocessed input
* rename var
* if -> switches
* Remove project radio buttons because they require commands that aren't yet checked in (and fail as a result)
* Added fix for Publish Target Label Position (#17771)
* Added fix for Publish Target Label Position
* renamed checkbox
* LEGO: check in for main to temporary branch. (#17775)
* LEGO: check in for main to temporary branch. (#17778)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* update dashboard taskbar separator (#17779)
* remove comments
* fix applying decorations
* add test
* enable find in sql result set
* add tests and update sql results highlight logic
* calculate the outputComponent index
* fix editor issues later
* remove newline replace on search
* address comments
* fix highlight issue
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
Co-authored-by: Lucy Zhang <luczhan@microsoft.com>
Co-authored-by: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com>
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com>
Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>
Co-authored-by: Alexander Ivanov <nahk-ivanov@users.noreply.github.com>
Co-authored-by: Aditya Bist <adbist@microsoft.com>
Co-authored-by: Sai Avishkar Sreerama <74571829+ssreerama@users.noreply.github.com>
Co-authored-by: Alex Ma <alma1@microsoft.com>
Co-authored-by: Leila Lali <llali@microsoft.com>
Co-authored-by: csigs <csigs@users.noreply.github.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: Candice Ye <candiceye@berkeley.edu>
Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>
* Added customlocation, location, resource group, and connection mode to controllerinfo. Updated SQL MIAA create notebook with direct mode params.
* Removed annotations from metadata in postgres test file.
* Only parse the customlocation if the connection mode is direct.
Co-authored-by: Candice Ye <canye@microsoft.com>
* enable add sql binding command
* add preview to command
* use resourceScheme instead of resourceExtname
* bump version to 0.15.0
* revert version bump
* Set default radio button selection, evaluate default component population off of selection instead of unprocessed input
* rename var
* if -> switches
* Remove project radio buttons because they require commands that aren't yet checked in (and fail as a result)
* using the new registry endpoint
* updating the service connection
* Changing the name of acr service endpoint to SqlToolsContainer
* Updating web build acr endpoint as well.
* remove .net 6 version cutoff for building sql projects
* Revert "Warning when .NET 6 SDK is detected (#17422)"
This reverts commit 2ed8aeb565.
* add back skipVersionSupportedCheck
* add back return false
* addressing comments
* add support for removing file in new style project
* fix test
* only load files, not whole project when checking if a <Build Remove> needs to be added
* merge changes
* fixes after merge
* Added fields for connectivity mode, custom loc, auto-metrics, auto-logs, and the dynamic enablement of such fields.
* Changed the description of the data controller details page.
* Change notebook params to work for direct mode
* Added login to dc deployment notebooks
* Fixed auto upload metrics and logs true/false, separated login into another cell.
* Removed localization of indirect and direct connectivity labels.
Our extension is relying on the wizard dialog. During accessibility testing it was discovered that wizard step buttons are being reported as links by the screen reader (NVDA, JAWS). Claimed expected behavior by the tester is that they should be announced as buttons.
I discussed this issue with accessibility SMEs and they said it is perfectly fine to keep them as links. They did mention that they would probably design the UX differently from the start, but given that we already have it this way, links are fine. They did suggest to add few additional ARIA attributes to the link elements:
- `aria-current="step"` if the link is for the currently active step. This literally just announces "current step" at the end, when you focus on a link
- `aria-disabled="true"` makes it say "**unavailable**; link; *<step number>*" when in NVDA "browse" mode and move to the grayed-out link.
So this change implements the said improvements.
During accessibility testing it was discovered that tree view in our wizard reads "Tree Node tree view" instead of the proper label that is specified. It turned out to be the problem with the tree component, where `ariaLabel` was hardcoded to "Tree Node", instead of the one provided in the options.
This change addresses the problem by passing through `ariaLabel` from the options object to the underlying tree control. I also removed the default `Tree Node` hardcoded label, as it didn't make much sense. This does mean that all tree-views that do not explicitly specify their aria-label will now get an empty label. I think this is better than having unrelated, unlocalized `Tree Node`.
I'm also worried about changes to the `ariaLabel` property after the component was initialized. I updated the code to propagate the value to the underlying tree view in the `setProperties` override of the tree component and hope that it will take care of it.
During accessibility testing, it was discovered that screen reader does not announce what checkboxes in the tree view represent. It was merely announcing "checkbox unchecked", so it was not clear without visuals which checkbox the focus is on.
This change sets an `aria-label` of the checkbox elements to match the label of the owning tree node. This way the announcement becomes "My Node; checkbox; unchecked". This is fine as a quick solution to the problem, but in the future we may want to consider adding additional checkbox label property to the nodes exposed by the tree provider, so that each checkbox can announce additional information, if needed.
* Checks for successful directory creation
* Revert "Checks for successful directory creation"
This reverts commit 372409ef323f0d82e11992bc7bc33d607a7d5581.
* Checks for the existence of the logs directory before accessing.
* Adds SQL carbon edit comment
* Removing call to copy from non-existing directory.
* Removes unneeded import
* Checks for file existence before copying.
* Provides explanation for modification
* Replaces file existence check with exception handling.
* Use built-in SQL ExecuteProvider by default if no other provider exists.
* Gracefully handle case where standardKernels are not defined for a provider.
* Standardize on just using arrays for various provider registration details.
* use glob to get files for new style msbuild sdk sqlproj
* add tests
* cleanup
* fix test
* don't show bin and obj files and folders
* handle other glob patterns
* fix duplicate entries getting added for glob patterns in project's folder
* format doc
* correct class name
* set content
* remove mssql commands
* merge classes
* code refactoring and bug fixing
* remove unnecessary class
* handle promise
Co-authored-by: Alan Ren <alanren@microsoft.com>
* respect include header option
* use correct option for copying
* check for setting when copying
* add dependency injection
* use instantiation service
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* Clean up extension descriptions
* More cleanup
* learning to spell
* Remove unused loc strings
* Add bundling information & rename view container
* Update data workspace readme
* don't show SSDT update warning for new style projects
* update strings
* add checks for the 2 other ways to specify msbuild sdk
* add link to docs on how to use project sdk
Co-authored-by: Kim Santiago <kisantia@Kims-MacBook-Pro.local>
* Changed the placement of the getValue comment in IValueProvider interface.
* Simplified some params values to feed into deployment notebook better. Added logic to add flags to the sql miaa create calls in notebook. Removed variablename from estimated cost.
* Changed High Availability to Replicas
Co-authored-by: Candice Ye <canye@microsoft.com>
Separate the Views load from the initialization. This way we can load previously created views, and only add the new views data to the document when needed. For now, this happens only when a view is created.
* Added valueprovider for pricing. Pushing this for troubleshooting help.
* Committing changes for troubleshooting help. Moved InputValueType to typings file.
* Add readonly inputs to list
* Fixed ordering of package.json merge items
* Estimated cost moved to input page, ValueProvider only takes in a triggerfields[] and not a single string, fixed pricing logic.
* Removed pricingModel.ts
* Reverted some comments and code changes that were used in debugging.
* Changed some values from localizedConstants to single-quote constants'
* Changed some values from localizedConstants to single-quote constants'
* Added copyright header to pricingUtils.ts
* Removed try catch in extension.ts valueproviders, made some values in PricingUtils.ts top-level instead of exporting.
* Minor changes, added some comments and localized USD.
* Changes pricingutils classes to be constants, and added disposable to Hookupvalueprovider
Co-authored-by: Candice Ye <canye@microsoft.com>
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* Adds loggings to ADS pipeline
* Skips notebook smoke tests for ADS web.
* Skips failing create book dialog tests in web build
* Ignores import tests ADS web
* Groups related tests together for ADS Web and non-web
* Updates distro commit hash
* Adding prompt for project name
* Updating test
* PR feedback
* Fixing rename logic so that folder is also named according to project
* Updating autorest test to confirm rename
* Giving user option to install autorest globally or run via npx
* Adds message for when no files are generated (no models in spec)
* Adding test
* Reinstating the rest of the test suite
* PR feedback
* Fixing tests to stub new prompt when test runner doesn't have autorest installed
* PR feedback
* fix typo
* fix typo
* backup page
* config rpo first
* rpo az cli
* working 1
* working 2
* working -3
* working -3
* working 4
* working with button component
* remove Date usage, use string instead
* cleanup
* cleanup 2
* Update localizedConstants.ts
rectify the wording until, figure out a way to fetch earliest backup
* pitr dialog, remove rpo
* pr feedback
* pr feedback
* pr feedback
* pr feedback
* feedback
* remove iso time conversion and show time as-is
* save lastEditMode
* change style to active
* addActiveClassFromEditMode
* add undefined to declaration
* remove from public interface
* private
* lastEditMode to last selected mode
* comments
* set active in one place
* rename method
* table designer add/remove row support
* save changes and editor support
* address comments
* fix build error
* including missing change
* lower case request name
* Corrects keyboard shortcuts for linux
* Changed python to match the one listed in docker/Dockerfile
* Revert "Changed python to match the one listed in docker/Dockerfile"
This reverts commit 683c226eb600bc89b449f258d463d2a6b14aebe6.
* Adjusts retry count for dialog elements to close.
* Code clean up
* Revert "Adjusts retry count for dialog elements to close."
This reverts commit 64a8bf48fa72eb26830aeaa55721c7ff846d131e.
* Code cleanup
* Adjusts key binding
* wip
* wire up e2e
* hook up styler and add as dataprotocal feature
* designer child component rendering
* table component updates
* styler and selectbox column editor
* fix editor size and dupe component creation issue
* fix checkbox column and add more testing data
* properties pane
* only rerender when needed
* properties pane update
* update commands
* cleanup for PR
* revert unwanted changes
* Adding a few tests for Add SQL binding (#17079)
* initial changes
* add a couple more tests
* LEGO: check in for main to temporary branch. (#17089)
* LEGO: check in for main to temporary branch. (#17091)
Co-authored-by: kburtram <karlb@microsoft.com>
* Adds autorest-based SQL Project generation to SQL Database Projects extension (#17078)
* Initial changes
* checkpoint
* Constructing project with post deployment script
* Correcting to intentionally read from cached list of projects
* Adding activation event, fixing fresh workspace bug
* Convert netcoreTool and autorestHelper to share a helper class for streamed command
* Include npm package version to force update
* test checkpoint
* Unit tests
* Added contextual quickpicks for autorest dialogs
* Adding projectController test
* Added projectController test, some refactoring for testability
* Merge branch 'main' into benjin/autorest
* Fixing 'which' import
* PR feedback
* Fixing tests
* Adding additional information for when project provider tests fail
* Hopefully fixing failing tests (unable to repro locally)
* Adding Generate Project item to workspace menu
* PR feedback
* LEGO: check in for main to temporary branch. (#17097)
* added sql database projects strings (#17100)
* Set kernelAlias in startSession when isValidConnection is truthy (#17102)
* PR follow-up comments (#17113)
* Change recompare message after changing options to modal (#17103)
* Change recompare message to modal
* change options to yes and no
* Remove commented code block in git extension (#17116)
* Remove commented code block in git extension
* Add SQL CARBON EDIT tag
* [Loc] Small change to generatingProjectFailed (#17118)
* Add Null Shortcut and added NULL text for default NULL value. (#17085)
* added test key event
* added null function to tryHandleKeyEvent
* added null formatting
* added working null insert.
* added editDataGridPanel string null support
* Bump nth-check from 2.0.0 to 2.0.1 in /build (#17115)
Bumps [nth-check](https://github.com/fb55/nth-check) from 2.0.0 to 2.0.1.
- [Release notes](https://github.com/fb55/nth-check/releases)
- [Commits](https://github.com/fb55/nth-check/compare/v2.0.0...v2.0.1)
---
updated-dependencies:
- dependency-name: nth-check
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add excludeFlags to extenson marketplace query (#17121)
* Add excludeFlags to extenson marketplace query
* Remove dead code
* Remove extraneous blank line
* Address code review feedback
* Adding Derived Columns to ADS Flatfile Import (#16795)
* Adding derived column boilerplate
* brandan preliminary frontend changes
* empty commit
* added new param
* updating contracts, dialogue changes
* utils changes, saving timeout attempt
* pushing for aasim
* Cleaning up code and fixing the issue in theory
* changing button, did not solve independent scroll
* Fixing the scroll bar issue
* updating flat file service
* adding override keyword to overrriden method
* improving UI
* pushing changes associated with resolved comments
* localizing strings, editing comments
* all comments resolved
* Fixing a test
* updating import package
Updating azure MFA bug
* Clearing navigation validator
Fixing broken table name change
* fixed prose test
* removing unused code from tests
* Fixed PR comments
* Fixing some PR comments
* WIP
* Fixing transformation code and create derived column dialog styling
* removing unused code
* Adding comment for console log
* fixed table styling
* Adding some aria labels
* Fixed some code cleanup issues
* update import service
Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
Co-authored-by: bnhoule <t-bhoule@microsoft.com>
* Change keybindings for copying query with Results (#17127)
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
* sql proj - publish to docker improvements (#17124)
* Add AAD token expiration handling for query runner (#17117)
* Add AAD token refresh for notebook
* move token refresh to query management and remove previous refresh calls
* Add guids to RunAll and RunCell events (#17123)
Add guids to RunAll and RunCell events
* add error banner for failed migration cutover and cancel migration (#17106)
* [Loc] update to sql migration, database projects and import extension strings (#17130)
* Apply optional storage class settings in sql mi create command (#17129)
* Make storage classes optional
* Fix notebook to use storage class options
Co-authored-by: Charmaine Chan <chachan@microsoft.com>
* Add support for adding new setting in local.settings.json in add SQL binding quickpick (#17093)
* be able to add new setting in local.settings.json
* cleanup
* addressing comments
* remove todo comment
* addressing comments
* update some strings to uris
* bump version of sqltoolsservice (#17133)
* mark schema compare tests as unstable (#17140)
* [Loc] Update for arc and sql-database-projects (#17148)
* ML extension vbump (#17143)
* Configure docker image and web smoke tests for ADSWeb. (#17136)
* Adjusts timeout period
* Revert "Adjusts timeout period"
This reverts commit 0f372eae2a4611554093b6c09f1ff6c451132e19.
* Adds firefox as browser option
* Corrects yaml smoke test script
* Resets args array to original values
* Corrects build path
* Resolves ignoring browser option error
* continue even after writing to stderr
* Adjusts smoke test (browser) script
* More adjustments to smoke test script
* Corrects server path
* Uses build variable directly in build path
* Specifies browser type since cannot be ignored error
* Adds browser option
* Updates web build image and corrects smoke test exe command
* Removes commented out task
* Updates dockerfile to support web smoketests
* Removes failOnStderr flag
* Use curl instead of wget in Dockerfile
* Fixed a bug with cancling publish (#17160)
* Save And Close Functionality (#17000)
* save and close
* wip
* working save and close
* cleanup
* pr changes
* pr changes
* fix capitalization
* fix build
* pr fix
* Added dynamic options for SQL MIAA Deployment Wizard and updated checkbox field (#17119)
* Dynamic enablement
* Added new package.json field for dynamic options and corresponding functions and classes.
* Enabled dynamic options non-generalized and changed formatting of checkbox to have label on the left.
* Added setOptions under InputComponentInfo for generalization, comments under checkbox component, and changed Replicas to High Availability to reflect parity in portal.
* fix unit test
Co-authored-by: Candice Ye <canye@microsoft.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
* LEGO: check in for main to temporary branch. (#17168)
* [Loc] added new arc strings and fix for sql-database-projects lcl file for Japanese (#17171)
* [Loc] added new arc strings and fix for sql-database-projects xlf
* removed newline
* Port of Vscode fix for colors too close (#17146)
* default light colors list.focusHighlightForeground too close to list.activeSelectionBackground. Fixes#127597
* remove activeSelectionBackground from theme-carbon as it conflicts with vscode.
* remove dark carbon background
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
* Markdown Horizontal Scrollbar Fix (#17083)
* dynamically change horizontal scrollbar
* working horizontal scrollbar
* created new event to handle both scrollbar and mouse wheel
* only show scrollbar when needed
* LEGO: check in for main to temporary branch. (#17181)
* Bump axios to 0.21.4 (#17161)
* Kusto version bump to 0.5.6 (#17114)
* Bumped Kusto toolsservice version to 125 and bumped version to 0.5.6
* Changed netcoreapp3.1 to net5.0 in Kusto config.json
* AzureMonitor bump ToolService version and extension version. (#17174)
* Bump concat-with-sourcemaps from 1.0.4 to 1.1.0 (#17158)
Bumps [concat-with-sourcemaps](https://github.com/floridoo/concat-with-sourcemaps) from 1.0.4 to 1.1.0.
- [Release notes](https://github.com/floridoo/concat-with-sourcemaps/releases)
- [Commits](https://github.com/floridoo/concat-with-sourcemaps/commits)
---
updated-dependencies:
- dependency-name: concat-with-sourcemaps
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update service downloader to 0.2.3 (#17186)
* Notebook Views grid fixes (#17170)
* update data workspace restart ADS to open workspace message (#17188)
* update message
* update string
* Add back "Remove Project" (#17178)
* remove project working with full paths
* use relative paths
* const
* addressing comments
* Bump github-auth axios to 0.21.4 (#17189)
* LEGO: check in for main to temporary branch. (#17192)
* LEGO: check in for main to temporary branch. (#17190)
Co-authored-by: kburtram <karlb@microsoft.com>
* [Loc] Add a small change to dataworkspace (#17194)
* added bump to sqltoolsservice version (#17195)
* Check if file is dirty before adding sql binding (#17175)
* check if file is dirty before adding sql binding
* Addressing comments
* Add vertical scroll bar to Preview in Split View (#17164)
* reset max height
* add editor height
* set md editor height
* Split up NotebookProvider into separate providers for handling file serialization and cell execution. (#17176)
* fix floating promises
* pr comments
* reuse component definition
* comments
* fix error
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: csigs <csigs@users.noreply.github.com>
Co-authored-by: kburtram <karlb@microsoft.com>
Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com>
Co-authored-by: Alex Ma <alma1@microsoft.com>
Co-authored-by: Justin M <63619224+JustinMDotNet@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: bnhoule <52506119+bnhoule@users.noreply.github.com>
Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
Co-authored-by: bnhoule <t-bhoule@microsoft.com>
Co-authored-by: Monica Gupta <scorpio90m@gmail.com>
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
Co-authored-by: Leila Lali <llali@microsoft.com>
Co-authored-by: Hai Cao <hacao@microsoft.com>
Co-authored-by: Daniel Grajeda <dagrajed@microsoft.com>
Co-authored-by: brian-harris <61598682+brian-harris@users.noreply.github.com>
Co-authored-by: Charmaine Chan <69230572+charmainewkchan@users.noreply.github.com>
Co-authored-by: Charmaine Chan <chachan@microsoft.com>
Co-authored-by: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com>
Co-authored-by: Christopher Suh <chsuh@microsoft.com>
Co-authored-by: Candice Ye <candiceye@berkeley.edu>
Co-authored-by: Candice Ye <canye@microsoft.com>
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
Co-authored-by: Vasu Bhog <vabhog@microsoft.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Barbara Valdez <34872381+barbaravaldez@users.noreply.github.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
* Stops flagging untitled editors with pre-loaded content as dirty
* Code changes address broken unit tests.
* Completes original comment
* Defines new non dirty text editor model
* Revert "Completes original comment"
This reverts commit 6d0e90bb9f0650eead5a0ec1ca8524dfe96c56cd.
* Revert "Code changes address broken unit tests."
This reverts commit 5b8cdd9f0bb43638bdd427a454ea177f6fbc024d.
* Revert "Stops flagging untitled editors with pre-loaded content as dirty"
This reverts commit 7a39226b7961af3aba8dc2f08113ed09eb2a1d61.
* Stops marking untitled editors with JSON as dirty
* Code clean up.
* check if database connection
* Change name of isMaster and remove import
* Set to false
* take out connecttodatabase
* remove connecttodatabase
* Original database
* remove empty string check
* clean
* set original database for when saving connection
* pass unit test
* map -> find
* PR changes
* Comments for original database
* Initial Split code
* minor change
* minor changes
* Added split cell button to initActionBar, created split cell class to pss cell context.
* added changes
* fixed index
* Split Cell Working in markdown mode
* Fixed highlighting
* Preserve the edit state
* Added new icon and updated styles and cellToolbar component with new icon name.
* Addressed PR
* Addressed PR
* Added back isEditMode flag
* Moved split action to after edit toggle.
* Fixed typo
* Addressed PR
* Addressed PR
* Removed deletion of the cell
* fixed the comments
Co-authored-by: Hale Rankin <harankin@microsoft.com>
* updated border styling of tables
* reducing border thickness
* fixing styling for dark mode
* fixing for dark mode
* removing box shadow from checkbox
* dynamically change horizontal scrollbar
* working horizontal scrollbar
* created new event to handle both scrollbar and mouse wheel
* only show scrollbar when needed
* default light colors list.focusHighlightForeground too close to list.activeSelectionBackground. Fixes#127597
* remove activeSelectionBackground from theme-carbon as it conflicts with vscode.
* remove dark carbon background
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
* Dynamic enablement
* Added new package.json field for dynamic options and corresponding functions and classes.
* Enabled dynamic options non-generalized and changed formatting of checkbox to have label on the left.
* Added setOptions under InputComponentInfo for generalization, comments under checkbox component, and changed Replicas to High Availability to reflect parity in portal.
* fix unit test
Co-authored-by: Candice Ye <canye@microsoft.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
* Adjusts timeout period
* Revert "Adjusts timeout period"
This reverts commit 0f372eae2a4611554093b6c09f1ff6c451132e19.
* Adds firefox as browser option
* Corrects yaml smoke test script
* Resets args array to original values
* Corrects build path
* Resolves ignoring browser option error
* continue even after writing to stderr
* Adjusts smoke test (browser) script
* More adjustments to smoke test script
* Corrects server path
* Uses build variable directly in build path
* Specifies browser type since cannot be ignored error
* Adds browser option
* Updates web build image and corrects smoke test exe command
* Removes commented out task
* Updates dockerfile to support web smoketests
* Removes failOnStderr flag
* Use curl instead of wget in Dockerfile
* be able to add new setting in local.settings.json
* cleanup
* addressing comments
* remove todo comment
* addressing comments
* update some strings to uris
* Initial changes
* checkpoint
* Constructing project with post deployment script
* Correcting to intentionally read from cached list of projects
* Adding activation event, fixing fresh workspace bug
* Convert netcoreTool and autorestHelper to share a helper class for streamed command
* Include npm package version to force update
* test checkpoint
* Unit tests
* Added contextual quickpicks for autorest dialogs
* Adding projectController test
* Added projectController test, some refactoring for testability
* Merge branch 'main' into benjin/autorest
* Fixing 'which' import
* PR feedback
* Fixing tests
* Adding additional information for when project provider tests fail
* Hopefully fixing failing tests (unable to repro locally)
* Adding Generate Project item to workspace menu
* PR feedback
* Adds smoketests for ADS web.
* Refines element selector for editor suggestion list
* Revert "Refines element selector for editor suggestion list"
This reverts commit 61b34cd07ab9fa16546d7aab5bce24c73559c6b0.
* Skip tests that timeout for not finding targeted DOM element
* Missed undoing a modification
* Reinstates skipped tests
* Removes unnecssary TODO
* Disables smoke tests for darwin
* Fixed indenting to resolve azure DevOps yaml error
* Updates server path based on setup doc
* Moves smoketests after extensions are built
* Corrects indentation
* Fixes indentation with bottom half of smoketests script
* Updates sqlite URL to latest release
* Yields correct ADS sqlite release version for web and non web
* removes accidental whitespace from previous commit
* Code review changes
* Additional review change
* update distro
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Adding error message and placeholder for dropdown
* Fixing default error message for empty required dropdown
* Fixing a small input value updating bug
* Fixed a commend
* Fixed a comment
* PR fixes
* Using codicon
* Fixed screen reader not reading error message
* Adding support for multiple dropdowns error message
* Adding error border
* Fixing error border styling.
* Added more specific classes for styling
* Making styling more specific
* debug messages to figure out what is calling this
* added existing connection handling.
* added timeout for isConnected
* restored connectionStatusManager
* added timeout for updating the connection state
* added existing profile check in queryInputFactory
* moved existing profile check to outer
* added to nonSync
* added mock getConnectionProfile
* added push instead of assign
* added additional tests
* removed getConnectionProfile
* added test message for getConnectionProfile
* fixed tests, need to add more
* added working tests
* moved connect to helper method
* rearranged test order and added sync
* changed wording
* small capitalization change
* Adding user config for default auth type
* adding feature
* removing the SqlLogin default from the model
* fixing bug, removing dead code
* removing unneeded instance of configurationService
* fixing line break
* removing extra parameter
* removing comments
* Fix test breaks
* Fix build break
* More breaks
* Address code review feedback
Co-authored-by: Troy Witthoeft <troy.witthoeft@gmail.com>
* removed clear results and results visible.
* revert changes, still work in progress
* added small debug message
* added flag for state
* removed clear in queryResultsView
* moved carbon edit message
* simplifcation
* fixed spacing
* added clarifying message
* added clarifying comment
* added original tab clear line for future things
* added support for regular saves
* removed vscode changes
* added queryEditorTextInput to other versions
* added stuff
* reverted changes to queryTextEditorInput
* deleted duplicates
* moved untitledQueryEditorInput
* added FileQueryEditorInput constructor
* added instantiation
* added queryEditorTest
* added temporary state for save editor input
* added back in FileQueryEditorInput
* added example of both to test
* restored input.
* Added current results processing
* removed queryeditor import
* added disable dispose, WIP
* added small change to dispose
* added oldUri
* added small changes for adding renameQuery
* added first parts of renameQuery, need to add more in other parts. (Place next to disposeQuery).
* moved rename around in queryModel
* added rename to testQueryManagementServices, now need to add to queryrunner.
* added to queryRunner, need to test
* added renameQuery calls
* added renameQuery to extensions
* moved untitledQueryEditorInput to its old location
* removed duplicate untitledQueryEditorInput
* test import
* test blah
* moved fileQueryEditorInput to services
* deleted original fileQueryEditorInput
* Moved fileQueryEditorInput to new location
* added workbenchinstantiationservice
* added titledQueryEditorInput
* restored untitledQueryEditorInput.ts
* removed instantiation service
* made changes to titledQueryEditorInput
* Revert "deleted original fileQueryEditorInput"
This reverts commit dd5eb19ea1489d9c0dda159e6a798975240dab65.
* reverted back to pre move
* added altered untitledQueryEditorInput
* temporarily using old version of save until determining point where new URI is assigned.
* renamed oldUri to newUri to better reflect its actual use.
* added some debug messages for examining how uris work
* made small changes to untitledQueryEditorInput
* restored save to have actual code.
* moved renameQuery to proposed.
* added partially working save as for results (Pressing run breaks query)
* removed instantiationservice
* added newUri for dataservice
* added queryRunner.uri for queryModelService
* moved untitledQueryEditorInput to old location
* changed todomessage
* added explanation messages
* fixed spaces and added description
* moved untitledQueryEditorInput to new location
* added rename for connectionmanagementservice
* added carbon edit message
* removed carbon edit to editorservice
* removed another space
* added get and set for isSaving value
* removed accessor
* Update azdata.proposed.d.ts
added space
* fixed azdata.proposed
* added changeConnectionUriForQuery
* restored request
* replaced changeconnectionuri to changeuri
* Revert "replaced changeconnectionuri to changeuri"
This reverts commit eed8e518dee69cf2922ff86dc1763e6fb7715a71.
* made required changes
* fixed exclamation mark
* removed error on queryRunner changeconnection
* added save connect button status
* added additional state properties to save
* added wip setstate
* added changes for better naming
* added changes in preparation for vscode merge
* take screenshot of failed test before close editor (#16876)
* Add setting for enabling using new markdown renderer (#16864)
* Add setting for enabling using new markdown renderer
* Use const
* Fix circular dependency
* Default setting to false
* fix refresh node and add sample (#16888)
* Merge from vscode e3c4990c67c40213af168300d1cfeb71d680f877 (#16569)
* Bump VS Code version to latest sync point (#16891)
* Fix duplicate editor windows on reload (#16893)
* reset the icon before use (#16896)
* Undo merge icon change (#16894)
* disable cancel button after clicked once (#16783)
* disable cancel button after clicked once
* remove enabling of cancel button when cancelling
* Update sqlite version for smoke tests (#16903)
* update sqlite
* bump distro
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* add autoCutoverConfiguration to getMigrationStatus (#16803)
* Enable scripting for triggers and other objects (#16885)
* WIP 1
* Add parentName to azdata
* Add some additional types for scripting
* Add parent type name to support view subobjects
* bump dependencies and address review comments
* Modify treeDataChange event (#125214) (#16907)
Modify treeDataChange event to support firing arrays.
* Move create new option for publish to top and filter out system dbs (#16908)
* Move create new option for publish to top
* Move New tag to description
* fix
* Open project to default location (#16910)
* Have create proj from database show default save location as option (#16909)
* Default create proj location to setting
* update icons
* undo
* Put search/ status/refresh in single line (#16898)
* add horizontal scroll bar to output (#16918)
* Fix extension linting warnings and enable extension linting in pipelines (#16922)
* Fix extension linting errors
* fix test
* Update public preview readme for sql migration extension (#16920)
* Add sql bindings package reference to project (#16912)
* list packages and add packages working
* cleanup and remove list packages
* cleanup
* change to pull in latest package version
* Add STS root folder override (#16927)
* Add STS root folder override
* Display message to user
* Show once for any service
* Fix some unhandled promise lint errors (#16924)
* Moved items around to handle new untitledQueryEditorInput location (#16914)
* moved items around to handle new untitledQueryEditorInput location
* added editor inputs to constants.
* added interface for untitledQueryEditorInput
* added IUntitledQueryEditorInput
* Revert "added IUntitledQueryEditorInput"
This reverts commit 67955eb289458e7ac4e7e5ce0ee077f38ed82a2c.
* Revert "added interface for untitledQueryEditorInput"
This reverts commit 88552dbd811b643fd51d5d21f4571b677d7bfc73.
* Revert "Revert "added interface for untitledQueryEditorInput""
This reverts commit 13a89c40e4cb0a3fa495f5b150c066892387e509.
* Revert "Revert "added IUntitledQueryEditorInput""
This reverts commit 8b2258ab49275a271a39036ea1734feca98ee753.
* added extends for IUntitledQueryEditorInput
* added casting in editorGroupView
* Revert "added casting in editorGroupView"
This reverts commit 61500ea43690b08ba2393808a8d118abc60da4ac.
* Revert "Moved items around to handle new untitledQueryEditorInput location (#16914)"
This reverts commit 87a663ee6b7cc3330c0528b20fb74f557451f911.
* Revert "Fix some unhandled promise lint errors (#16924)"
This reverts commit 73218a840df188f1ae26ff1c2e1aa5b85b9cfcb0.
* Revert "Add STS root folder override (#16927)"
This reverts commit 35936d464f2e452cd29659fffef20018ac6ffdd4.
* Revert "Add sql bindings package reference to project (#16912)"
This reverts commit 72d29ed7a7d298716ba159548af1f08adc82db25.
* Revert "Update public preview readme for sql migration extension (#16920)"
This reverts commit 3b3c3921557aabe86c927e6a833c0c41b48f7e23.
* Revert "Fix extension linting warnings and enable extension linting in pipelines (#16922)"
This reverts commit f5ea3e69ae5132c09eba699e8c25d1a1a66e0914.
* Revert "add horizontal scroll bar to output (#16918)"
This reverts commit 76bf86a2536edfe84b0f323571e489d69fe9fe00.
* Revert "Put search/ status/refresh in single line (#16898)"
This reverts commit d9553d09141c159e8b1cc27f6422e51b68800c7c.
* Revert "Have create proj from database show default save location as option (#16909)"
This reverts commit 88b9b7734b467a2552dfeea9c844b90361a660de.
* Revert "Open project to default location (#16910)"
This reverts commit a46170b347a28ff77f40883b055153823a86308e.
* Revert "Move create new option for publish to top and filter out system dbs (#16908)"
This reverts commit 4be47daf63771b6c3b12b786ba687dfc6ca0e3c6.
* Revert "Modify treeDataChange event (#125214) (#16907)"
This reverts commit 4161c21abcc78a9b5a65e52ae7d7f960ea71219b.
* Revert "Enable scripting for triggers and other objects (#16885)"
This reverts commit 2ece3ffb12478faf0f49df1e66bcc7acc0631500.
* Revert "add autoCutoverConfiguration to getMigrationStatus (#16803)"
This reverts commit 366633e7247d508138b45e902d7e034c79763dec.
* Revert "Update sqlite version for smoke tests (#16903)"
This reverts commit 64f66d7b18418b028cfa56b984d6f9979f65cc50.
* Revert "disable cancel button after clicked once (#16783)"
This reverts commit 12044e30746f44188d46a781f582781bf3638762.
* Revert "Undo merge icon change (#16894)"
This reverts commit 0801d14267a9980a2c29374666ad7fee14dfcafb.
* Revert "reset the icon before use (#16896)"
This reverts commit 971c39e8bc5c774fb49d81c5c36617ec45b4078c.
* Revert "Fix duplicate editor windows on reload (#16893)"
This reverts commit 4df3085b09b645a3ef2728c3ab3778fb7a63f2ba.
* Revert "Bump VS Code version to latest sync point (#16891)"
This reverts commit c1bc6639efcdf69d9b9c57cc44af3a1d19514f83.
* Revert "Merge from vscode e3c4990c67c40213af168300d1cfeb71d680f877 (#16569)"
This reverts commit c92da9c02ee221ca69813af69b039d3f3846aa42.
* Revert "fix refresh node and add sample (#16888)"
This reverts commit df820f6c03d167d933d089bfadf5296a7dcaf834.
* Revert "Add setting for enabling using new markdown renderer (#16864)"
This reverts commit e3c036dfbaa0a1e1588f348eb9eb4a7edb4f9bda.
* Revert "take screenshot of failed test before close editor (#16876)"
This reverts commit d466b19a6e56a43654c779c1dab60724b1f0c3db.
* fix spaces
* changed uri to public
* fixed formatting on azdata.proposed
* added queryprovider at the end
* changed already in connections list message.
* added notifyconnectionurichanged
* added changes to fix
* fixed testQueryModelService
* fixed leftover stuff
* more renames
* Added small changes
* added messages to untitledQueryEditorInput
* added work in progress fileQueryEditorInput save as
* fixed space
* removed changeUri
* remove saveAs from queryEditorInput
* removed undefined from createFileQueryEditorInput in untitled.
* changed saveAs for fileQueryEditorInput
* changed saveAs to use createInstance
* bumped version of STS in config.json
* bump version of dataprotocol-client
* update to yarn.lock
* more changes
* removed space for untitledQueryEditorInput
* some refactoring done
* removed already has provider check due to existing provider still existing
* added a comment
* fixed typo
* change results order around
* added already existing connection message
* restored untitledQueryEditorInput
* removed message
* added existing connection
* Revert "added existing connection"
This reverts commit 3cc34f6b1e670bb7b257e046f53560471badfd34.
* add try catch to restore older overwrite file behavior
* added types and error handling
* added error comments.
* changed message of both files
* fixed formatting for azdata.proposed.d.ts
Co-authored-by: Lucy Zhang <luczhan@microsoft.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: stuti149 <87131830+stuti149@users.noreply.github.com>
Co-authored-by: Rachel Kim <rackim@microsoft.com>
Co-authored-by: Karl Burtram <karlb@microsoft.com>
Co-authored-by: Barbara Valdez <34872381+barbaravaldez@users.noreply.github.com>
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
- Use the onDrop method for moving notebooks/sections in the Notebooks Tree View.
- Allow multi selection in tree view
- Modify notebook commands to only show when a single tree item is selected.
* added azuremonitor, need to work on cms
* finished CMS, need to do Kusto and MSSQL
* Added kusto, need to finish mssql
* added some strings need to finish mssql
* finished MSSQL
* WIP 1
* Add parentName to azdata
* Add some additional types for scripting
* Add parent type name to support view subobjects
* bump dependencies and address review comments
* Enable Azure Data Studio's database selector to behave like the one in SSMS
* Revert "Enable Azure Data Studio's database selector to behave like the one in SSMS"
This reverts commit d146eef998a3192f76df80794a31a45c8be7f786.
* Database selector auto commits selection
* Adds comment explaining change
* Auto commits selected database on blur
* Confirms db name changed before committing db selection
* Moves changed db check to selected database method
* Makes use of dbName instead of having to get value from dropdown
* Code review change
* Adding support for aad connections in import extension
* Adding support for AAD by passing azure account token
* Adding a test for aad connections and fixing broken tests
* removing extra await
* formatting
* update comment
* format doc
* fix connection test
* remove unused imports
* test server info mock
* try with mocks
* add server info check for tests
* added logic for corner case
* Added back Don't Ask Again logic
* If no Azure CLI found, throw error instead of returning undefined.
* Deleted 'restart ADS' text for arcdata extension prompts
* Added error catch for parse version and parsed out the * in az --version
* Added back findAz()
* Added arcdata version to AzTool. Parse --version using regex.
* Return undefined if no az found.
* Added userRequested param for findAz
* No longer await on extension activate. Re-added some functions for az install.
* Install works for windows
* Changed auto install for az on Linux and MacOS.
* Added comment for findSpecificAzAndArc and uncommented some localizedConstants
* Added comment for getSemVersionArc and took out the path for some tests.
* Made findSpecificAzAndArc return an object instead of a list
* Removed azToolService test
* Removed azToolService tests and renamed suite to azcli Extension Tests
* Got rid of new Regexp for regex in parseVersions
* Added back azToolService.ts
* Added logic to enable prompt user to install arcdata extension and auto-install capability. No update capability yet.
Co-authored-by: Candice Ye <canye@microsoft.com>
* empty table shows no backup file image
* string displayed modified and empty table text will only be displayed after checking function _shouldDisplayBackupFileTable
* format fix
* format changes
* format fix
* Merge conflict resolution
* Throw error for unsupported versions of Dotnet
* Fix for darwin
* Fix for all platforms
* Address comments
* Fix extensionsGaller.json
* Address comments
* Update default installation path for linux
* Fix test
* Revert default installation location change for Linux
* Address comments
* Removed extra try-catch block
* Fix query database drop-down rendering location after resize
* Revert "Fix query database drop-down rendering location after resize"
This reverts commit 62481a93e696d4fa79ce40ecef3a2567a65dd20c.
* Fixes drop down list rendering issues by closing the list on window
resize
* comment providing the explanation for new listener and checks if list is visible before hiding
* initial quick pick
* move constants
* remove commented code for now
* addressing comments
* update name
* update name in other places
* remove azure functions from name and rename file
* Automatically add intermediate folders for SQL project items.
While using the SQL database projects through the API, I noticed that project may end up in somewhat inconsistent state, where files will be added to the project, but their parent folders will not. This in turn resulted in failure to remove these folders from project - they will show up in the UI tree, but deleting them will cause an error. In order to align with how Visual Studio manages the projects, this change will ensure that all intermediate folders are present in the project, when new files or folders are added.
While this change improves project "correctness" when accessing it through SQL projects extension APIs, there is still a possibility that someone will open an "incorrect" previously created project. This change does not address it and folder removal may still fail.
* Update the code to never throw on duplicate items when adding files and folders to project.
After a conversation with the sqlproj owners, we agreed that there are no scenarios that would prompt us to throw an error, if duplicate item is being added to the project. Ultimately, the goal of such a request would be to have an item in the project file, which is already present, therefore the call becomes a no-op.
This allowed me to simplify the new code that was ensuring all intermediate folders are present in the project when adding files and folders.
* Add CodeQL Analysis workflow (#10195)
* Add CodeQL Analysis workflow
* Fix path
* Fixed UI regression in main
* removed the file which should not been included
* Addressed PR comments
* Addressed PR
Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
* Initial implementation of drag and drop api (#122239)
* Add drag and drop controller (#123542)
* Tree data transfer dnd (#128666)
* add drop method to sql files
Co-authored-by: Alex Ross <alros@microsoft.com>
* Changed azdata to az in azcli extension and resource-deployment, and some arc. Removed user, pass, url from controller connect blade. Commented out tests. Ported over work from old branch.
* Changed unit tests, all unit tests passing. Changed parameters to new ones, fixed some Controller Connect issues.
* Connect data controller and create dc working.
* Changed az back to azdata in necessary places in resource-deployment.
* Changed notebook values and added namespace to some params.
* Added some changes from PR to this branch
* Changed azdata.ts to az.ts and changed subscription parameter
* Brought over changes from azcli PR into this branch.
* added endpoint, username, password to getIsPassword
* Changed notebooks to use proper az params, hard coded in some values to verify it is working, removed some variableNames from package.json.
* Changed -sc to --storage-class in notebook
* Added namespace to SQL deploy, deleted dc create in api
* Deleted more dc create code and uncommented findAz() with unfinished work on Do Not Ask Again.
* Removed (preview) from extensions/arc and extensions/azcli excluding preview:true in package.json
* Commented out install/update prompts until DoNotAskAgain is implemented
* Fixed bugs: JSON Output errors are now being caught, --infrastructure now has a required UI component with dropdown options, config page loads properly, SQL create flags use full names instead of shortnames.
* Adds validation to pg extensions and bug fixes (#16486)
* Extensions
* Server parameters
* Change locaiton of postgres extensions, pr fixes
* Change location of list
* List spacing
* Commented out Don't Ask Again prompt implementation.
* Uncommented header of a test file.
* Added Azure CLI arcdata extension to Prerequisites
* Reverted package.json and yarn.lock
* Took away casting of stderr and stdout in executeCommand.
* Deleted override function for initializeFields in connectControllerDialog.ts
* Removed fakeAzApi for testing and added back in (Preview)
* Removed en-us from python notebook links.
* Deleted azdata tool from tool tests in resource-deployment
* Deleted another instance of azdata in tool test
* Add back in azdata tooltype
* Remove en-us
* Replaced AzdataTool in typings
* Reverting adding azdata tool back in
* Changed Azdata to AzdataToolOld
* Added back azdata tool type
* Added AzdataToolOld to tool types
* fix test
Co-authored-by: Candice Ye <canye@microsoft.com>
Co-authored-by: nasc17 <nasc@microsoft.com>
Co-authored-by: nasc17 <69922333+nasc17@users.noreply.github.com>
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* Adding support for sending additional headers in azure http requests
* Added session ids in all azure rest calls
* Fixed param name
* Adding default parameter value for request headers
* Changed azdata to az in azcli extension and resource-deployment, and some arc. Removed user, pass, url from controller connect blade. Commented out tests. Ported over work from old branch.
* Changed unit tests, all unit tests passing. Changed parameters to new ones, fixed some Controller Connect issues.
* Connect data controller and create dc working.
* Changed az back to azdata in necessary places in resource-deployment.
* Changed notebook values and added namespace to some params.
* Reverted all changes that are not in azcli. Also deleted some unused variables in azcli constants.ts and some tests.
* Fixed package.json
* Deleted en-us from links, changed az. to azcli.arc in package.json
* Addressed PR comments.
Co-authored-by: Candice Ye <canye@microsoft.com>
* Added missing resources to chinaAzureSettings and germanyAzureSettings in providerSettings
* Update providerSettings.ts
* Fixed typo in mooncake armResource
* Fixed host for China Cloud in ProviderSettings
* Adding telemetry for assessment
* Removing dms loading fix
* Fixing PR
* removing collection of account id
* moving database warning count to the server assessment event
* Removing individual warning and issue events
* Adding aggregates for database issues and warnings
* removing extra line
* Adding other telemetry events in sql migration
* Fixed changes made in the PR
* Fixing attribute names
* Consolidating issues and errors in 1 event
* Converting dependencies to dev depenedencies
* Adding a catch for the telemetry function
* moving the non type uuid to non dev
* Made hashmap code cleaner
* Fixing cutover start time
* Fixing object creation
* Reverting back to old method.
* Modifying the date time to js objects
* Converting issues and warnings to json object
* LEGO: check in for main to temporary branch.
* Update sql-migration.xlf.lcl
* Update sql-migration.xlf.lcl
Co-authored-by: Alex Ma <alma1@microsoft.com>
* Add aria labels to pod drop down on resource health and tables on overview
* Added roles
* Fix strings
* Added role to table headers
* Added heading levels
Allow plotly to resize based on the size of the output itself, not only when the window is resized. This allows cells in Notebook Views to adjust based on resize.
The autodash feature in notebook views creates an initial grid layout for users when a view is created. It is intended to reduce the effort required by the user to start editing their view. Instead of displaying every cell and stacking them vertically like the default notebook layout, we use guidelines to determine which cells are worth displaying and how to arrange them.
* Transition to withProps in arc
* Transition to withProps inputbox
* Transition to withProps in checkbox
* Transition to withProps text
* Transition to withProps in declarative table
* Transition to withProps hyperlink
* Transition to withProps in button
* Transition to withProps radiobutton
* Transition to withProps in input
* Transition to withProps button
* Transition to withProps in text
* Transition to withProps image
* Transition to withProps declare table
* Transition to withProps in table
* Transition to withProps radio button
* Transition to withProps in image
* Transition to withProps radio button
* Transition to withProps in commit
* Transition to withProps div cont
* Transition to withProps in comp
* Transition to withProps radio card
* Transition to withProps in comp icon
* Transition to withProps card
* Transition to withProps list
* Adding option to treat hyperlinks as buttons
* Adding ext host endpoints for is button property in hyperlinks
* Removing isButton flag and plugging in aria role in the hyperlink component
* Removing attribute null check
* Update for German Resources
* added strings for Spanish XLFs
* added french resource xlfs
* massive commit on 7/18/21
* another update to extensions and sql
* add migrations status context menu and commands
* add migration status images
* remove test code, add account validation
* fix command registration to occure once
* fix typo
* add target platform as an option in create project api
* move constant
* WIP
* show versions in dialog and create project with selected version
* validate version
* add error messages
* add test
* change version to target platform
* cleanup
* more cleanup
* use withProps
* add aria-label / name to image only buttons
* add correct aria label to image buttons
* add key number to button aria-label, title and action messages to differentient keys
* update to existing german extensions
* Update for existing Spanish Resources
* Added updates to existing French Resources
* update for Italian Resources
* Update for existing Japanese resources
* update for Korean resources
* update for Portuguese resources
* russian resources updated
* update for chinese resources
* Fixing some assessment styling
* Adding styling capabilities to loading component.
* Changing assessment loader height from px to %
* using margin-top instead of height to align loader
* Added Azure Log Analytics resource for generating AAD Token.
* Fixed AzureResource
* Removed debug code from connectionManagementService
* Moved AzureLogAnalytics from AzureResource enum in azdata.d.ts to azdata.proposed.d.ts. Added azureLogAnalyticsResource to all azureSettings in providerSettings.ts
* Updated endpoint for generating AAD Token for LogAnalytics for UsGov, UsNat, and China
* Initial Commit of Azure Monitor Extension
* Added extension name to azuremonitor package strings
* Removed azureMonitor resource from germanyCloud in providerSettings
* Added logic to exclude menuItems in object explorer for LogAnalytics
* Changed exe from AzureMonitor to Kusto
* Added if clause for queryName for new queries
* Changed queryWindow name from KustoQuery to KQLQuery for Kusto and LogAnalytics.
* Added LogAnalytics for setTaskBarContent
* Added serialization and telemetry feature classes to AzureMonitor. Added references for azdata and vscode.
* Added azure monitor light and dark icons
* Added config for Dashboard in package.json
* Added workspace information to dashboard
* Added language support for LogAnalytics
* Added Notebook support
* Added Hide flag to package.json for databaseName
* Changed providerId from LogAnalytics to LOGANALYTICS
* Changed Workspace to Workspace ID in package.nls.json
* Added support for Azure Widget browser
* Changed fullName to use workspaceId when connecting
* Changed providerId from alertsManagement to azureMonitor
* Added .gitignore and *.vsix to vscodeignore.
* Removed unused devDependencies
* Code Review Feedback
* Changed tsconfig.json to match Kusto and Sql
* Changed package.json to match kusto package.
* Changed tsconfig to validate unused params and implictAny. Changed existing code to satisfy build.
* Fixed tsconfig to use the correct base class.
* Added objectExplorerNodeProvider and all related classes.
* Removed unused tmLanguage file
* Added logic to to download extension from toolservice
* Fixed launchArgs. Removed commented code from extension.ts. Changed config.json to use net5.0
* Added displayName to package.nls.json. Removed hide flag from databaseName. Other code review feedback.
* Added readme info to AzureMonitor
* Removed unused client-error-handler and ui-references files. Combined outputChannel in azuremonitorServer. Removed TODO from contextProvider. Renamed function in extension.ts. Removed unneeded 'use strict' from cancelableStream.ts. Removed second outputChannel from objectExplorerNodeProvider.
* Removed unused files
* fix filter enter and focus
* debounce and fix search
* refactor null check and undo change/remove await
* using control types to improve and remove 'any'
* Pushing all changes
* Fixing more stuff
* Added new to the newly created resource group
* removing error message when user starts typing
* removing unused import
* Localizing some string
adding aria lables and loading text
* Adding focus to resource group input box
* switching to name instead of display name as it contains (new) param
* changing focus to resource group dropdown after creation of a new resource group
* fixing typo
* - Adding mouse in and out styling to clickbale divs
-Moving dashboard card styling to outer div container from inner form container
* removing detect changes
* Localizing aria label
* moving css from template to styles
* adding themeing participant to change hover styling
* removing unused event handlers
* separating styling
* Bump Sql Db Projects extension
* Bump azdata version for Sql Db projects
* Update package.json
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Works
* Clean up
* Aria labels added
* Pr fixes, only allow one drop at a time, check for citus
* Cleaning up refresh
* Created separate function for creating drop button
* Added with props, add comment about not able to drop citus extension
* Update url link of postgres extensions to match engine version after config is availible
* fix#123040
* Switch priority of shell/shellArgs and defaultProfile setting
Fixes#123159
We were too aggressive introducing the new default profile system as many
users (as well as dev containers, microsoft/vscode-dev-containers#838) depend
on these settings for their workflow. This also includes a change in behavior
where if shellArgs are specified, they are applied to the fallback shell
(even when shell.platform isn't specified), which aligns with past behavior.
* fixes#123036 (#123263)
* fixes#123041 (#123287)
* 1.56 fix for #123044
* Do not invoke `resolveWithInteraction` over terminal settings (#123590)
* Change grunt, gulp and jake task auto detection to be off by default (#123588)
Co-authored-by: meganrogge <megrogge@gmail.com>
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
Co-authored-by: João Moreno <joao.moreno@microsoft.com>
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
Co-authored-by: Alex Dima <alexdima@microsoft.com>
* remove awaits that were blocking data workspace extension from loading
* add comment
* remove await and use then
* use return instead of await
* add notification when there's an error
* added first strings
* added more localized files
* translated all strings in vscode
* added exported strings to editStrings
* updated files
* more changes
* moved to base
* wip commit
* added function to generate XLFs for ADS
* code cleanup
* removed unnecessary locfunc
* updated extensions and locfunc
* changed wording to be more clear
* added working single extension compile
* added export all extensions
* added more comments and closing sql carbon edit braces.
* consolidated gulpfile.extensions changes
* changed name to remove ADS part.
* changed gulpfile name use
* remove images from metadata on update
* update comment
* reset only on html update
* add comment
* fixes
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* changing the cutover icon on migration cutover page.
* Fixing monitoring table and pending log backups
* converting file upload times in utc to local time zones
* adding autorefresh to dashboard, migration status and cutover dialogs.
* Supporting blob container e2e
* vbump extension
* Fixing some PR comments
* Fixed broken blob container dropdown onChange event
* Localizing display string in refresh dialog
Fixing some localized strings
* Fixing var declaration
* making a class readonly for 250px width
* removing refresh interval dialog and replacing it with hardcoded values.
* Fixing summary page IR information.
* surfacing test connection error
* Clearing intervals on view closed to remove auto refresh.
* added environment language need to test
* added environment language, need to test if it works
* added locale change to code
* added Kusto localization for its ServiceLayer
* removed extra space
* removed console log and moved onto one line
* removed quotes
* make dropdown controls editable, searchable
* updte method name and return type
* update error message, and dropdown index selection logic
* address review feedback
* iterate over every cell and highlight ranges.
* fix yellow for all matches and orange for current
* fix
* avoid duplicate deltaDecorations call
* initialize on declare
* Postgres reduce worker node count (#15534)
* Allow scale in
* Fix word
* Removed changing of min
* Set min for worker count box
* Update server tree action contributions (#15525)
* Update server tree action contributions
* Fix test
* Updated langpacks to be pushed in (#15519)
* updated langpacks to be pushed in
* bumped version number to 1.29.0
* patched german lang pack
* patched spanish langpack
* patched french langpack
* italian langpack patched
* Japanese langpack patched
* Korean langpack patched
* portuguese langpack patched
* russian langpack patched
* patched chinese simplified langpack and fixed changelog for ru and pt
* patched chinese traditional langpack
* Init assets in dialog model (#15533)
* check that there are assets before filtering
* init assets as empty array
* change book icon (#15539)
* add sorting indicator (#15542)
* Vsix build task for langpacks (#15489)
* added refreshlangpack command
* added beginning update-localization yml file, also changed langpack location in RLE
* added regex tester
* moved xlf files into new folder structure
* small change to update-localization
* added yaml script for gulp refresh
* added missing dash.
* added better update-localization yml file
* remove update-localization as its not necessary
* added small changes to langpack-compile
* remove upload sourcemaps and write version information
* added more languages
* added vsce packaging
* added automatic langpack handling
* added built locFunc
* fixed refresh-langpack-extension
* working langpack vsix generator made
* added langpacks to files in copyArtifacts and product-build-linux
* changed command to package-langpacks
* removed unnecessary language flags.
* invalid ADS extensions filter explained
* Fix for regex
* removed unnecessary fields to change, and removed langpack-compile
* added doc comments.
* moved xlf files back to old place.
* WIP translation redirect
* isolated vsix build task
* fixed spaces in locFunc.ts
* use svg for sorting state icons (#15546)
* Add Markdown as a default editing option for text cells (#15540)
* Disable npm recompile step (#15548)
* Revert "Disable npm recompile step (#15548)" (#15554)
This reverts commit db5b68e04a.
* fix file compare issue (#15551)
* Fix notebook file URI test by adding a required forward slash to Windows file paths. (#15550)
* SqlToolService release version updated to 105 from 104 (#15558)
* Schema Compare failing test condition set to uncomment state. (#15512)
* fix changing kernels from kusto to other kernels (#15545)
* adding feedback dialog and support request buttons
* hide support request, widen feedback dialog
* Fix extension publishing during CI build (#15561)
* Disable native module recompile
* Bump distro
* Move web build step earlier
* Dev/brih/revert feedbackdialog commits (#15567)
* Revert "hide support request, widen feedback dialog"
This reverts commit 1d75fcfed5.
* Revert "adding feedback dialog and support request buttons"
This reverts commit 866ced5c08.
* Fixing a couple database reference dialog bugs (#15523)
* fixing a couple database reference dialog bugs
* update comment
* Update action run return type (#15568)
* Update action run return type
* fix tests
* Update rest
* Add back null checks
* Run with Parameters learn more link to use correct format and kernels (#15547)
* indicate to users correct format and kernels
* add test for unsupported kernel
* replace with enum
* Migraiton enhancements v: 0.1.1 (#15570)
* adding filters and cards for failed migrations
* Added card and filter for completing cutover
* Fixing blob container support and some ux enhancements
* Enabling eastus2 and canada central regions
* Increasing height of container to accomodate newer cards and cleaning up database backup page
* vbump migration
* Removing unused code
* fix css to contain image (#15574)
* Bump browserslist from 4.16.3 to 4.16.6 (#15565)
Bumps [browserslist](https://github.com/browserslist/browserslist) from 4.16.3 to 4.16.6.
- [Release notes](https://github.com/browserslist/browserslist/releases)
- [Changelog](https://github.com/browserslist/browserslist/blob/main/CHANGELOG.md)
- [Commits](https://github.com/browserslist/browserslist/compare/4.16.3...4.16.6)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Added build changes to add TSGOps extensions into the build (#15584)
* Add TSGOps specific extensions to SAW build
* Added the KeyVault uri
* Fix edit command to take in worker count of 0 (#15603)
* Allow for worker count to be 0
* Clean up
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Alex Ma <alma1@microsoft.com>
Co-authored-by: Barbara Valdez <34872381+barbaravaldez@users.noreply.github.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: Karl Burtram <karlb@microsoft.com>
Co-authored-by: Sai Avishkar Sreerama <74571829+ssreerama@users.noreply.github.com>
Co-authored-by: Vasu Bhog <vabhog@microsoft.com>
Co-authored-by: Brian Harris <brih@microsoft.com>
Co-authored-by: brian-harris <61598682+brian-harris@users.noreply.github.com>
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
Co-authored-by: Maddy <12754347+MaddyDev@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: rajeshka <rkselfhost@outlook.com>
* Expose default database collation through 'sql-database-projects' extension API.
For the purpose of schema conversion we would need to know whether target database is configured as CI or CS. This will be used to produce a warning, if we detect a case-sensitive identifier, but database is configured as CI. In order to support this scenario we need to access `<DefaultCollation/>` property of the project.
This change adds new method to the `ISqlProject` interface that allows to read the value of the project property. There already was similar method for the SQL version/platform (`<DSP/>` property) and while working on the change, I took an opportunity to refactor the way project properties are extracted from the XML. Original code was hardcoded in the `getProjectTargetVersion` and I extracted it into separate `evaluateProjectPropertyValue` helper, that can be used in the future by any getter or access method that is supposed to return a value of the single property. This also allows us to improve the way properties are retrieved from the XML. Today the logic is very rudimentary - we read the first matching XML element with the required name. This is not correct as it does not verify the parent to be `<PropertyGroup/>`, neither it evaluates the `Condition` attributes nor property value itself. I did not invest in this, but added a TODO there explaining that the method may not perform as expected.
After the helper method was added, I updated the existing `getProjectTargetVersion` method to leverage it. The only complication here was the error throwing logic, as it was using custom error message. I preserved that, as there were tests verifying it already. For the new accessor method I did not introduce a special error message and rely on generic one I defined for use within the helper method. Additionally, for the collation we return default value of `SQL_Latin1_General_CP1_CI_AS`, if project does not have the property defined. This is what SSDT for Visual Studio shows in the UI when property is missing and I decided to align with that.
Finally, I added tests for both - original `getProjectTargetVersion` and new collation extraction method to make sure they work as expected. While working on the tests, I've noticed complaints that some rejected promises were not awaited. I added missing `await`s.
* adding filters and cards for failed migrations
* Added card and filter for completing cutover
* Fixing blob container support and some ux enhancements
* Enabling eastus2 and canada central regions
* Increasing height of container to accomodate newer cards and cleaning up database backup page
* vbump migration
* Removing unused code
* Revert "hide support request, widen feedback dialog"
This reverts commit 1d75fcfed5.
* Revert "adding feedback dialog and support request buttons"
This reverts commit 866ced5c08.
* added refreshlangpack command
* added beginning update-localization yml file, also changed langpack location in RLE
* added regex tester
* moved xlf files into new folder structure
* small change to update-localization
* added yaml script for gulp refresh
* added missing dash.
* added better update-localization yml file
* remove update-localization as its not necessary
* added small changes to langpack-compile
* remove upload sourcemaps and write version information
* added more languages
* added vsce packaging
* added automatic langpack handling
* added built locFunc
* fixed refresh-langpack-extension
* working langpack vsix generator made
* added langpacks to files in copyArtifacts and product-build-linux
* changed command to package-langpacks
* removed unnecessary language flags.
* invalid ADS extensions filter explained
* Fix for regex
* removed unnecessary fields to change, and removed langpack-compile
* added doc comments.
* moved xlf files back to old place.
* WIP translation redirect
* isolated vsix build task
* fixed spaces in locFunc.ts
* updated langpacks to be pushed in
* bumped version number to 1.29.0
* patched german lang pack
* patched spanish langpack
* patched french langpack
* italian langpack patched
* Japanese langpack patched
* Korean langpack patched
* portuguese langpack patched
* russian langpack patched
* patched chinese simplified langpack and fixed changelog for ru and pt
* patched chinese traditional langpack
* Adding support for blob containers and infoboxes
* vbumping migration for May month release.
* setting resotered count to 0 when the active backupsets is empty.
* Removing unnecessary !
* Excluding readme gif from the vsix package
* Removing info box as it not needed now.
* Removing all the changes to migration mode page for the infobox
* update python fwlinks and remove bundle ver
* start fixing path for users with python 36
* prompt user for python version upgrade
* update python path after removing 3.6
* prompt users to upgrade and show pkg warning
* make prompt async
* remove python bundle ver from ML extension
* shutdown python 3.6 before deleting
* check useExistingPython before update prompt
* add dont ask again option
* remove 3.6 after installing 3.8
fix merge conflict
* give option to remove python36
* list user installed pip packages in warning
* create notebook to install pip packages
* update getPythonExePath method and add comments
* clean up code
* add comments
* pr comments
* add comment
* remove option to keep python36
* shutdown active servers before removing python36
* fix error removing old python w/ path change
* update to 3.8.10
* restart sessions for mac/linux
* Enables being able to view and edit Coordinator node scheduling params (#15114)
* Trying to save per role settings
* Updated spec
* Cleaning up
* Removed unneccessary code and comments
* Added separate type for { w?: string, c?: string}, PR fixes
* Added methods to refresh mr,ml,cr,cl versus per role
* Fixed spec
* Put back optional properties, removed passing empty string to reset scheduling params
* Spacing
* vBump arc
* Included roles in fake show output for testing (#15196)
* Update arc specs (#15225)
* Update azdata Arc specs to match April azdata
* vcores -> cpu
* fix spacing
* Consolidate types and update storage volumes
* Fix compile
* Fix spec
* include coordinator
* Adding args
* Query call success
* Check for success in query
* List full coordinator params
* Change name
* Update unit test for engine settings
* Pr changes
* Fix query
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* additions to sqlLocalizedExtensions
* remove azdata from sqlLocalizedExtensions
* fix extension files to work with nls.metadata.json function (required)
* Add notebook editor
Introduce notebook editor component to allow for separate notebook displays in order to accomodate notebook views
* Localize notebook views configuration title
* Refactor view mode and remove the views configuration while it is unused
* Only fire view mode changed event when the value has been changed
* Remove notebook views contribution
* Add metadata capabilities
* Notebook views definitions
* Add notebook views models
* Views test
* Rename type arguments
* Additional tests
* Fix unused import
* Notebook views changes
* Add notebookviews.css
* Update notebookViewModel.ts
* Add cell toolbar styles
* Upgrade gridstack
* Add gridstack styles
* Remove ununsed references
These are part of the next PR and not available yet
* Remove gridstack static file
* Add gridstack as a module in the electron unit tests
* Spacing fixes
* Add copyright notice
* Remove commented code
* Spacing fixes in notebook styles
* Move handle svg to image
* Add typing for gridstack
* Move notebook styles to file
* Rename selector constant
* Rename grid css file
* Add nb-grid-stack class to views grid
* Cell toolbar style adjustments
* Remove unused imports
* Update .eslintrc.json
* Fix outdated instantiation of LabeledMenuItemActionItem
* Address feedback
* Fix from update to main
* Added updated German strings and added hybrid toolkit to locproject.json
* updates to XLF files
* more resources added to locproject
* restored out localizations
* fixes to dacpac and admin-tool
* fixes to dacpac and import
* updates to english XLFs (more up to date)
* Adding a null check to prevent infinite next button loading on account selection page.
* Remove a useless validation in migration cutover page
* Fixed some component formatting in source selection page
* Completely updated target selection page UX according to latest figma mockup
* Adding confirmation for migration cutover and cancel
* migration vbump
* azdata vbump in migration extension
* letting users do a cutover with unrestored files
* Fixing some localized strings
* Adding readme file for migration extension.
* Adding a static link for readme gif
* added sql mi typing, localized strings, some null checks
* casting target instance as sql mi
* Added Azure Log Analytics resource for generating AAD Token.
* Fixed AzureResource
* Removed debug code from connectionManagementService
* Moved AzureLogAnalytics from AzureResource enum in azdata.d.ts to azdata.proposed.d.ts. Added azureLogAnalyticsResource to all azureSettings in providerSettings.ts
* Updated endpoint for generating AAD Token for LogAnalytics for UsGov, UsNat, and China
* Removed azureMonitor resource from germanyCloud in providerSettings
* Added missing resources to AzureResource in account interfaces.
* Added comment linking enums for AzureResource
This change introduces new boolean flag for `addToProject`, `addScriptItem` and `addFolderItem` APIs that allows to skip files/folders if they are already included in the project file. Original behavior was to throw an error if duplicate entry is encountered, so I kept that as a default (new flag is not set).
I started by fixing the original behavior, as it was not always working as expected. In our extension that relies on `addToProject` API we've hit an issue where duplicate items were added and no errors were thrown. There was a test for this scenario, but unfortunately the test had few bugs in it as well, so I addressed that first. First issue with the test code was missing `await` on the `testUtils.shouldThrowSpecificError` calls, so test was not actually testing anything. After adding missing keywords, I hit an issue where exception was not thrown, but this turned out to be different issue, compared to what we were hitting. In the test code, it was using the very first folder from the generate list of test entires. This folder wass actually the root of the project (where sqlproj file is located), and `addToProject` API had a special case to ignore the root. This means neither first call nor second call was actually adding anything to the project and no errors were produced. I fixed this problem by using next available folder in the generated files list.
After addressing the test code I could not reproduce the issue that we were seeing with duplicate entires being added, everything was working as expected and errors were thrown. I started adding more tests that better resemble our production scenario - add files in subfolders, add files to existing project, rather than a new one. Finally I was able to reproduce the problem in tests when adding a file in a subfolder to an existing project. After investigation this turned out to be an issue with mismatch in how `relativePath` is maintained within the `FileProjectEntry`. When loading an existing project, `relativePath` is populated based on the value of the `Include` attribute of the `Build` item. This attribute is normalized to Windows-style path, using `\`, so for nested file you will have `folder\file.sql`. When adding new item to the project, one could pass either Windows or Unix-style path (`folder/file.sql`), so the path comparison between loaded Windows-style path and newly added Unix-style path was failing, resulting in them being treated as different items. In fact, `addToProject` API that we were using was relying on `Uri` helpers to extract relative path, thus the path was forced to be Unix-style and path was never the same as the loaded one. After this discovery I added a dedicated test to validate the round-trip of the `relativePath` for serialized and desirialized project file.
In order to address this problem, I updated the factory method `createFileProjectEntry` to always run `utils.convertSlashesForSqlProj` on the relative path to ensure we have Windows-style path stored in there. I also optimized the helper code slightly to not do split/join, if there are no split points in the input string, which should eliminate unnecessary array instantiation. It is worth mentioning that I had to normalize the input relative paths in the `addScriptItem` and `addFolderItem` APIs, because there is no guarantee that they will be Windows-style when we try to compare them to `relativePath` of the existing project items.
Finally I was able to add a simply flag and update the condition to return existing record, if duplicates were allowed. I also updated typings file for the extension and added tests to cover this scenario.
* Working on table bug
* Removed unit test checking for onEngineSettingsUpdated event to fire since removed from model
* Moved instanceofcheckbox function to utils, pr fixes
* Fix comment
* changes from Chris's branch and cell model updates
* get base64 value
* handle spaces in image names
* add comments
* add tests for imageCallOut dialog
* format document for hygiene errors
* address comments
* check base64 validity using regex
* replace space with regex
* add parameter and return type
* split into two functions
* move functions to fileUtilities
* correct import
* fix for layering issue
* revert file function changes
* Update SC dialog to start a new connection
* Functionally complete
* Fix target db to pick correct database
* Address comments
* Added test+fixed one missing scenario
* Address comments + add one more test
* make sure dialog buttons are not disabled
* use 'enter' to close connect dialog
* retry clikcing the Connect button
* wait for dialog gone after reclicking
* pr comments + add logging
* use debug to log
* close toasts before clicking dialog buttons
* await close notification toast call
* click python wizard buttons instead of enter
* Enables being able to view and edit Coordinator node scheduling params (#15114)
* Trying to save per role settings
* Updated spec
* Cleaning up
* Removed unneccessary code and comments
* Added separate type for { w?: string, c?: string}, PR fixes
* Added methods to refresh mr,ml,cr,cl versus per role
* Fixed spec
* Put back optional properties, removed passing empty string to reset scheduling params
* Spacing
* vBump arc
* Included roles in fake show output for testing (#15196)
* Update arc specs (#15225)
* Update azdata Arc specs to match April azdata
* vcores -> cpu
* fix spacing
* Consolidate types and update storage volumes
* Fix compile
* Update min azdata version
Co-authored-by: nasc17 <69922333+nasc17@users.noreply.github.com>
Co-authored-by: nasc17 <nasc@microsoft.com>
* ISSUE10685 - Edits schemaCompareDialog to show connectionName if provided
* ISSUE10685 - Edits to not show user if connectionName
* ISSUE10685 - Shows connection name is schema compare launched from db
* ISSUE10685 - Shows connection name in schema compare window
* ISSUE10685 - Edits utils tests
* ISSUE10685 - Edits schemaCompare test
* ISSUE10685 - Adds/Edits specs
* ISSUE10685 - Changes let to const
* Add smoke test
* Add wait for service
* Also revert liveshare
* fixes
* Use custom extensions dir
* fix
* compile extensions
* Use build extensions dir
* test break
* revert
* revert yarn.lock
* Add comment
* Add comments
* Adding onChange events in editable dropdowns for values changed through code.
* moved event generation from angular wrapper to core component
* Moving event firing to value setter
* converting back updateSelection to private method
* Removing extra check
* Fixing broken tests by mocking used stuff
* Fixing onTextChange event
* Adding some tests
* Adding necessary tests
* small test name edit
* Fix an assert message
* don't allow adding the same file or folder to the sqlproj if it has already been added
* add a couple more checks in test
* toLowerCase when comparing
* switiching product compile node cache task to newer version
* moving new changes from product-compile to sql-product-compile
* changing to yarn.lock as cache key
* Adding compilation cache
* changing keypath to key
* letting find command do the heavy lifting
* removing old save cache task
* reverting compilation cache to old task
* Creating a js to list compiled files
switching to cache 2 for compiled files
Creating a js file to compute yarn cache
* removed unused input targetFolder from pipeline cache task
* removed save cache
* Fixing compute node modules file
* Adding compiled computenodemodules
* Fixing checked variables on product compile
Updating all pipeline jobs to cache 2
Using tar for windows pipeline. Hoping it works
* Fixing indentation in web job
* Fixing different indentation in web job
* Generating sha keys for compilation cache to be cross plat
* trying deterministic key for compilation cache
* Fixing md5 command
* Trying another method of generating compilation cache
* testing with a hardcoded string
* Changing to a better hardcoded string
* Remove redundant make dir
* Fixing mkdir command in windows and trying new string key
* fixing $$ in sql product compile
* Removin redundant mkdir
* Trying source version var
* Fixing compilation key
* chaning script to powershell
* Adding artifacts to store compiled files
switching to 7zip for windows node cache
* Adding missing step key in web build
* Building not found directories
* Making correct directory
* Switching to vscode's computeNodeModuleCache
* Fixing formatting and making it look more like vscode's pipeline
* Adding back compiled comput cache key
* Fixing cache file
* Fixing copyright message
Adding sql header to custom node cache generator
Updating cache salt to force a cache miss
* Using glob instead of custom method to find all yarn.lock files
Fixing some other pipeline errors.
* Removing unnecessary variable checks.
* Added back VSCODE_STEP_ON_IT check
Moving drop artifacts before compiled files to keep it drop folder free from compiled files
* Changing task name from cache flags to cache key
* Removing glob from compute node module cache
Fixing copyright message
* checking in updated js
* Add message when no history exists on projects dashboard
* Bump version for sql db projects
* Update text, add refresh button
* Remove commented code
* Updated Postgres Spec for where to find engine version, removed calling calling -ev in edit commands (#14735)
* Added spec.engine.version, took out calling engine version with edit calls
* Added text wrong place
* missed updates
* PR fix
* Update Arc Postgres troubleshooting notebook
Co-authored-by: Brian Bergeron <brberger@microsoft.com>
* Remove AzdataSession from azdata commands (#14856)
* remove session
* Add in controller-context support
* Revert "Add in controller-context support"
This reverts commit 3b39b968efbf6054041cb01cb2d8443532643a82.
* Add azdataContext to login
* Undo book change
* Undo change correctly
* Add controller context support (#14862)
* remove session
* Add in controller-context support
* Add params to fake
* Fix tests
* Add info and placeholder for controller URL/name (#14887)
* Add info and placeholder for controller URL
* add period + update name
* update memento and allow editing of namespace/URL
* vBump
* vBump
* Fix tests
Co-authored-by: nasc17 <69922333+nasc17@users.noreply.github.com>
Co-authored-by: Brian Bergeron <brian.e.bergeron@gmail.com>
Co-authored-by: Brian Bergeron <brberger@microsoft.com>
* vbumping migration
* Adding 2 new icons cancel and warning
* Fixed help link display text in assessments
* Adding summary page redesign and resource name validations
* Made headings bold
* Fixed sku recommendation page styling
Added check item for assessment
* Validating account dropdown after token refresh
* Renamed cutover to mode
* cutover to mode renaming changes.
* Converting to details api for more warnings
* Added target database name and fixed cancel icon
* Surfacing warning info in dashboard.
* Consolidated fetch migrations logic
Localilzed some strings
Surface migration errors in dashboard and status page
Table redesign in status dialog
Fixed a major bug that happens when multiple dashboards are opened due to class variable sharing
* removing console count
* Fixing regex for SQL MI database names
* Allowing spaces in regex
* update DE lang pack extension strings from previous refresh
* bump lang pack versions for DE
* update for spanish langpack
* update for french langpack
* update for italian pack
* update for japanese pack
* update for korean pack
* update for Brazilian Portuguese pack
* update for Russian pack
* Update for Simplified Chinese pack
* update for Traditional Chinese pack
* added updated language packs for german and spanish
* changed vscode version
* added french and italian packs
* changes made to main
* japanese language pack added
* added korean pack
* Added Portuguese pack
* added russian pack, also small change to pt pack
* simplified chinese pack
* added traditional chinese pack
* deleted old language packs
* restore sql.i18n.json files
* Main.i18n.json reverted
* Revert sql json files
* main.i18n.json file for German updated
* updates to language packs 1
* main json for italian updated.
* update to japanese main
* finished translations for vs and sql in main.
* added ADS exclusive extensions to package.json
* fixed markdown and seti translation ids
* German language pack fixed
* Removed make from ads-language-pack-de and fixed es language pack
* french language pack fixed
* fixed italian language pack and restored typescript-basics
* removed unnecessary readme strings and nsions.
* fixed japanese pack
* Korean language pack fixed
* Portuguese language pack fixed
* fixed russian language pack
* Simplified Chinese pack fixed
* traditional chinese fixed
* restored sqlservernotebook
* Adding server name to wizard and dialog title
Surfacing async errors
Fixing a bunch of strings to match the mockup
* Adding auto refresh for migration status
* Removing errors for sql vm migration
* using new logic to get sql server username
* Fixing help links
* Removing unncessary await
* Add selection parameter to query shortcuts
* Add description for selected text as parameter
* Modify feature description since it supports proceedures and queries
* Replace every {arg} inside query shortcut
* wip assessment in progress page
* wip
* working assessment loader
* wip, radio cards not showing up
* working assessments in progress page
* cleanup
* bumped sqlmigration extension version
* cleanup
* First set of changes for workspace dashboard implementing the toolbar
* Workspace dashboard container implementation (#14813)
* First set of changes for workspace dashboard implementing the toolbar (#14160)
* First set of changes for workspace dashboard implementing the toolbar
* Addressed comments
* Addressed one remaining comment
* Removed an extra comma in interfaces file
* Addressed comments
* Addressed comments
* Refactored a bit of code
* Remove unnecessary await
* Addressed comments
* First set of changes for workspace dashboard container
* Update targetPlatform icon+add Time column to deploy table
* Addressed comments
* Removed redundant class definition
* Addressed comments
* Addressed comments
* Change enum to union type in dataworkspace typings
* Fix tests
* Addressed comments
* relative paths written to sqlproj, but can't delete yet
* only keep track of relative path
* remove leading slash
* add test
* use path.relative
* Add error message if dacpac reference is located on a different drive
* Removing canary host
* Rebranding extension name to Azure SQL Migration
* stopping instance table overflow in assessment dialog
* Added info message for details copied
* Limiting storage account and DMS to the same subscription as target
* making accounts page look like figma mockups
* converting error messages to warnings in cutover dialog
* making source config page look like figma mockups
* adding more filters for storage account and dms
* Adding validations for target database names.
* Fixing branding in other strings
* Adding types for SQL Managed Instance
* fix maximum call stack size reached issue
* Revert "fix maximum call stack size reached issue"
This reverts commit 178675633032a508ddb5585d1adc4f83bb243f55.
* add a few array operations
* use new push
* Clear updates in discard
* Update discarding values
* Changed where the info bubble is created , added function for collecting all changed components.
* Remove parameters if the same as original value reset individually
* Moved refreshParametersTable to be private function, try catch for postgresmodel.refresh
* Discard enable if fail
* Made changedCompoenentValues a set, removed unnessaery ! throughout file, cleaned up connec and load
* Fixing Database backup page target layout
* Filtering out Azure sql db issues from assessment results
Correcting the database count for issued databases in sku rec page.
* Adding copy migration details button to migration status
* Adding start migration button to toolbar
* Fixing a syntax error in package.json
* Adding rg and location to target selection page
Filtering storage account by target location.
* Fixing dashboard title to azure sql migration
* Not making assessment targets selected by default.
* Adding tooltip for database and instance table items.
* Fixing duplicate task widget
* Some fixes mentioned in the PR
Localizing button text
renaming a var
changing null to undefined.
* Adding enum for Migration target types
* Fixing a critical multi db migration bug because of unhandled race condition
* Adding Azure location api to azure core
* Adding source database info in status
* start new jupyter server
* restart session working (removed extra code)
* only restart server once
* shutdown session first then stop server
* add comments remove extra lines
* add comment
* fix test
* only restart jupyter sessions
* Dispose jupytersessionmanager and create new one
* move restart server logic out of notebookmodel
* move methods to azdata proposed
* pr comment
* - Added coming soon message for learn more.
- Potential fix for learn more message
* Renaming of controller to sqlMigrationService
* Surfacing some errors
-Azure account is stale error
-Migration Service creation error.
* Adding refresh azure token validation.
* Fixing some errors pointed during PR
-Fixing property names
-Fixing count
* Fixing migration status
- Adding special error handling for resource not found error
- Deleting unfound migrations from local cache
- Using prefetched migration status for view all
Misc fixes:
- Using SQL server version name instead of number
- Fixing Icons on sku recommendation page
- Fixing table column width in cutover dialog
- Adding spinner button to refresh.
* Fixing all strings in migration service page and dialog
* fixed a string error in create service dialog
* Adding source config page to migration to support windows auth
Some refactorings for sqlDatabaseTree (still WIP)
* refactoring assessments code 1
introducing new interface for server assessments
* Filtering out non windows sql vms
Retaining selections made by user on assessments dialog
* Fix compile errors on sqlDatabaseTree
* Exposing migration status errors in cutover dialog
* Updating extension verion
* Correcting typos
Fixing compilation erros
Removing en-us from url
Fixing function names
Make UI calls unblocking
* Unblocking dialog in case of failed assessments
Localizing string
removing blocking code from UI
Fixing comments
* Fixed broken assessment page logic
* tests for deleting postgres from overview page
* upgrade to azdata-test 1.5.0
* Fix api stubbing
Co-authored-by: Brian Bergeron <brberger@microsoft.com>
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* fix project tree tests failing on windows
* add back test
* Addressing comments
* change to doc comment
* remove unnecessary change
* undo other change
* - Added coming soon message for learn more.
- Potential fix for learn more message
* Renaming of controller to sqlMigrationService
* Surfacing some errors
-Azure account is stale error
-Migration Service creation error.
* Adding refresh azure token validation.
* Fixing some errors pointed during PR
-Fixing property names
-Fixing count
* Fixing migration status
- Adding special error handling for resource not found error
- Deleting unfound migrations from local cache
- Using prefetched migration status for view all
Misc fixes:
- Using SQL server version name instead of number
- Fixing Icons on sku recommendation page
- Fixing table column width in cutover dialog
- Adding spinner button to refresh.
* Fixing all strings in migration service page and dialog
* fixed a string error in create service dialog
* Added integration tests for schema compare
* Addressed comments
* Revert beforeEach change
* Addressed comments and reverted table creation change
* Removed cancelCompare test and addressed a comment
* Increase test timeout from 5 to 10mins
* Figure out initial test
* First trys at refresh unit test
* refresh unit test completed
* Connection profile unit test, need to pass in false
* Engine settings start
* All passing
* Clean up
* Removed class, updated showdialog stubs, using sinon spy
* Removed comment
* Resetting subscriptions after AD tenant is changed
* removing migration in progress info message at the end
* printing migration started errors in console.
* Fixing the icon names
* Fixing settings card position
* getting icon selectors from their source
* Changing var name from dataExplorer to dataExplorerId
* Made dashboard dark ui compat
* foundations for sql vm
* WIP
* Added cancel migration
Added refresh migraiton table
Added multi db config
* disabling cancel migration button if the migration is not in progress.
* Addressing some PR based coments
- Removing (s) from loc strings
- Adding return type to cancel migration
- removing _ from public vars
- localizing strings
- Adding name to dialogs for telemetry
* Adding todo comment for offline mode
* Initial work for handling concurrent operations when calling initialized books
* fixes to init contents
* create a queue of deferred promises for initializing books
* resolve active promise and set to undefined
* remove duplicated variable
* address pr comments
* Added CSS to treat manage packages icon position.
* Wired up a rough concept showing how I propose to pass a masked-icon class, along with the icon name - derived from the action icon path - to the injected action prior to rendering. The end result is an injected action with an icon which behaves like the others in the notebook toolbar.
* Revert "Added CSS to treat manage packages icon position."
This reverts commit 215a67244a78224fe8fd2e6480b7e50d37a15dc0.
* Revert "Wired up a rough concept showing how I propose to pass a masked-icon class, along with the icon name - derived from the action icon path - to the injected action prior to rendering. The end result is an injected action with an icon which behaves like the others in the notebook toolbar."
This reverts commit 1e0cf116602192aa554334d564e855167b0e8bb6.
* Modified LabeledMenuItemActionItem to add masked-icon class to injected label element.
* Modified LabeledMenuItemActionItem to add masked-icon class and styles for injected label element.
* To prevent conflict with Dashboard, I duplicated the existing LabelMenuItemActionItem and odified it.
* Added comment to new method. Added non-prefixed mask-image style.
* Renamed method and modified comments.
* Add podstatus to spec
* Added image to table and fixed spacing.
* Added pod status to spec
* PR fixes
* Added resource health page, created overiew box
* Pod condtion table is up
* Tryingt to fix how table refreshes
* Fixed how drop down changes table
* Overview box shows number of running and pending pods
* overview box refresh fix
* Updated summary section
* PR fixes
* Condensed create pod list function
* Added enum
* fixed refresh
* Fixed refresh, fixed if all availble section add
* Modified modal styles, limiting height of basic modal to 480px.
* wip - added new attachCalloutDialogStyler. Moved callout-specific styler code out of modal.ts
* Moved attach styler code to workbench/common. Added custom styles to imageCalloutDialog
* Moved styler code into calloutDialog. Added callout-specific theme colors to colorRegistry. Removed color styles from modal and callout stylesheets.
* Added CalloutDialogModal that extends CalloutDialog so that the callout can be instantiated from core. Revised calloutDialog so the position cn be passed in from where it is instantiated.
* Revised refactor of modal and image/link callouts so that callout dialog invoked by core can also use the styler. Removed unused properties from dialog code.
* Added conditional to dialogModal to use correct styler for callouts.
* Cleaned up styles. Modified custom colors.
* Wrapped call to positionCalloutDialog in conditional.
* Style, colors, styler and modal updates to align callout with latest OPAC toolkit styles.
* Moved calloutDialog stylesheet
* Consolidated styler code and added a flexible custom styler to provide values for dialogModal
* Added image callout code.
* Remove image callout dialog until wired fully
* Test fixes
Co-authored-by: chlafreniere <hichise@gmail.com>
While working on the tree control for our extension, I noticed that the sample implementation was not optimal. For instance, `vscode.TreeDataProvider.onDidChangeTreeData` should only be called once for the top-most node that has changed, as all children will be refreshed as well.
This change updates the code of the sample to track state changes during propagation and only raise the event for the top-most parent node that has its state changing.
There also was an issue with root node `1` not rendering, which impacted the new algorithm, as it was not refreshing the tree, when invisible root was changing. In order to address this, I updated `getChildren` to actually return the `1` node, when root was requested. This in turn changed the presentation (`1` is now rendered in the tree) and addressed the problem with tree not refreshing when `1` is the node that raises the event.
Lastly, there is one more optimization that I didn't make due to the bug that is in the works: `getTreeItem` can actually return the `element` directly, without the copy, as it already implements `TreeComponentItem`. The problem currently is that `TreeNode` also defines an `id`, which causes an error during refresh. Once that is addressed - this part can be optimized as well.
* upgrade pip after python installation
* add comment
* only upgrade pip for new python installations
* reinstall pip version instead of upgrade to latest
* update comment
* get pip version through packages list
* add improvements TODO on creating book experience
* fix create book to support a more complex folder structure
* replace \\ to a forward slash on windows
* address pr comments
* fix tests
* use the posix version of path.sep
* reset scheduling parameters
* Added right quotation marks
* Fixed comment
* Worker text box needs to have value, can't pass in emptry string
* Fixed ConfigurationSpecModel and added doc comment to handleOnTextChanged
* Add to information bubbles that user can reset scheduling parameters by passing in empty value
* Changed name of handleOnTextChanged
* Modal - added code to stop the keyboard event after it is handled. textCell and codeCell - onKey now fired on keydown.
* Moved stop method into the conditional with Escape key.
* Creating separate pages for worker and coordinator parameters
* Added new gear, hid coordinator server parameters page
* Commented out azdataApi
* Added white gear, created abstract class for server parameters page
* Chaged gear name, condensed base class more, changed file name
* Added colored gears for parameter pages
* Edited to describe configuring both coordinator and worker
* Start adding coordinator section
* Coordinator section shown on CS page
* Updated information bubbles, edited discard button
* Cleaned up code, hid coordinator section
* Add return types to functions, fixed configuration string name
* Configuration section does not need to be edited when model is refreshed since it is not seen
* Changed back information bubble to inform that both worker and coordinator nodes will be configured
* calloutDialog refactor - split code specific to image and link into their own super classes. Moved callout styles into a new stylesheet.
* Image and Link inserts working.
* Stylesheets cleanup. Refactor cleanup.
* Removed CSS comment. Added missing image callout style. Revised generic open and cancel classes. Moved all remaining localized strings into shared constants file.
* pass function to debounce
* remove debounce decorator and move watch methods to bookmodel
* Move the vscode tree change data event to book model
* address pr comments
* fix book tests
* expose addToProject in dataworkspace.d.ts
* remove changes in data workspace extension
* add sqldbproj.d.ts
* change list to be Uris instead of strings
* don't add files/folders if any don't exist
* fix test on windows
* WIP changes
* toc.yml edit
* added first cell to AG page
* Changed to SSMS instructions, will need to change steps.
* switched back to SQL
* added clarification of primary server database requirement.
* fixed spaces
* split adding nodes to its own page.
* more changes
* added message for prerequisites step
* test with invoke command added
* added run direct command to failover cluster notebook
* test-cluster temp file added
* added module change and changed readme
* fixed domain name
* fixed escape
* Test Cluster changed to comment again due to permissions issue
* moved additional failover cluster to first notebook
* more cleanup
* more changes added
* added endpoint url
* fixed commas
* failover cluster wording changed
* added select for sqlvm name
* added a check for service account
* fixed secure password string
* first availability group command added
* Current Availability Group Page
* small change
* configure-ag change
* more changes
* changes made to notebooks
* . Added fetch logic for controllers (no need to create a new one everytime)
. Fixed retention logic
* Fix field reloading logic.
Fixed localized string
Removing hardcoded colors
* Add dialog for creating books
* create empty book
* add localized constants
* add validation to dialog
* reset the create book command to original
* address pr comments
* change error message
* Init book toc manager in bookTreeView
* Adding Dashboard
Fixing auth keys api
create status Dialog
* making some changes requested in the PR
* switched to text component from dom component
* Adding TODO comment
* Fixing image url to work on windows
* Fixing stuff pointed out in PR comments
* adding return type to dasboard register function
* Adding more todos
* Two options
* remove commented line and add the null check
* fix tests: pass isDirty explicitly
* remove commented line
Co-authored-by: chlafreniere <hichise@gmail.com>
* New feature for Notebooks - callout. This utilizes a modifed modal.ts that renders a small modal set to appear at the trigger event and disappear when user clicks off of it. This is intended only for micro-interactions such as inserting links, tables and images into Notebooks. Error dialogs dependent on modal have been updated to implement the modified width property correctlty.
* Modified dialogStyle names in interface. Applied updates to files dependent on this. Wired up disposable listener for browsing local files in image select callout. Renamed callout to calloutDialog.
* Converted double quotes in CSS to single quotes. Revised run method, removing the promise wrapping from the conditional.
* Passing click target to modal for positioning. Created custom buttons and click event handlers for Insert image and Insert link. Set feature behind preview flag.
* Revised structure and styles.
* Updated component for use with ML extension. Updated ML extension code with changes for custom dialog creation.
* Fixed async context for handleBrowse. Passing the new modal properties into Dialog implementation for ML.
* Added option to suppress callout dialog header and footer from the machine learning view file. Added a compact variant of callout. Corrected Dialog tab initialization.
* Maddy/callout modifications (#13586)
* initial changes
* canSelectFolders false
* change label, placeholder text on radiobtn click
* Added support for custom XY offset to account for modal size and to provide for fine-tuning of unique modal instances.
* Updated Image icon with latest from Design.
* Replaced node process with IPathService for retreiving image file.
* Added theme color lookups to provide default colors when none are provided.
* Added async/await to tests calling transformText.
* textCell, modal - swapped out HostListener for a member method which listens for the Esc keyup. Updated templates with method call on keyup. This cleaned up the double event call whenever the Esc key was pressed. Added property to modal Cancel button call to make it a secondary button.
* Cleaned up callout styles.
* Removed color use for input fields because component code delivers theme-specific values.
* Added check for CSS class `mac` on the body tag. Added conditionals to supply alternate dialogXYOffset in the case of non-Mac environment.
* Cleanup: Simplified DialogPosition. Renamed telemtry references and dialog related methods. Corrected spelling. Added missing signatures and types. Updated warning callout link URLs.
* Removed async and await as there are no promise dependencies. Added a signature.
* Revert "Fix windows insiders icons (#13579)" (#13630)
This reverts commit a0ef594792.
* Changed cores validation message (#13617)
* Changed cores validation message
* Missed validation
* Remove cores validation message
* Applied verification for cores change to miaa c+s page
* WYSIWYG Improvements to highlight (#13032)
* Improvements to highlight
* wip
* Tests pass
* Leverage escaping mechanism
* Tweak highlight logic
* PR comments
* add await to thenable method (#13635)
* Delete ConnectionDialogue.ipynb (#13634)
this nb was an attempt at creating a connection dialog. removing
not found in toc
* Added engine version argument to edit command. (#13610)
* Added engine version argument to edit command. Neccessary for not using pg12
* Included for changing password in overview page
* Updated fakeazdataapi test
* Fix empty column issue (#13641)
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
* add right padding to notebook toolbar action item (#13640)
* add right padding to action item
* remove extra line and add space
* Adding SQL Edge project template (#13558)
* Checkpoint
* removing flag for not creating subfolder
* Adding Edge template
* Removing janky map function
* Adding templates for additional objects
* Updating tests, fixing bug
* Added Edge project icon
* Updating strings to Drew-approved text
* Cleaning up template scripts and Edge project template names
* Update package.json (#13626)
* Update Import UI to match other UIs (#13637)
* Update Import UI to match other UIs
* Fixed another bug
* Fix notebook unordered grid values after papermill execution (#13614)
* Fix unordered table
* check entire first row schema:
* SQL Notebooks should not get affected
* delete unused variable and edit comments
* refactor for efficient table ordering
* nit naming
* Normalize path to change (#13660)
* vbump asde deployment extension (#13662)
do a patch version update, will adjust if the next change is a major one.
* Add test for dynamic enablement (#13602)
* Add test for dynamic enablement
* update names
* Remove debug console log (#13669)
* Remove placeholder on deployment wizards when field is disabled dynamically (#13658)
* Bump highlight.js in /extensions/markdown-language-features (#13675)
Bumps [highlight.js](https://github.com/highlightjs/highlight.js) from 9.15.10 to 10.4.1.
- [Release notes](https://github.com/highlightjs/highlight.js/releases)
- [Changelog](https://github.com/highlightjs/highlight.js/blob/master/CHANGES.md)
- [Commits](https://github.com/highlightjs/highlight.js/compare/9.15.10...10.4.1)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* add ability to control the enabled state of checkbox cells (#13644)
* control enabled state of checkbox cells
* add more check
* Prevent Table from Disappearing due to exception when looking for tHead (#13680)
* Prevent exception when tHead doesn't exist at node
* Add test for no thead
* Fix issue with pasting results in Teams (#13673)
* Fix issue with pasting results in Teams
* Addressed comment to change header tag to th
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
* Add descriptions and validation to connected mode (#13676)
* Add dependent field provider to resource deployment (#13664)
* Add dependent field provider to resource deployment
* Change name to value provider service
* Add error handling
* providerId -> id
* Set dropdown value correctly
* missed id
* back to providerId
* fix updating missed id
* remove placeholder
* Have resource deployment providers return disposables (#13690)
* Add dependent field provider to resource deployment
* Change name to value provider service
* Add error handling
* providerId -> id
* Set dropdown value correctly
* missed id
* back to providerId
* fix updating missed id
* Make resource deployment providers disposable
* Retry publish and always try adding asset (#13700)
* Retry publish and always try adding asset
* Undo asset upload change
* Add logging
* Notebooks: Remove result set summary from saved metadata (#13616)
* remove result set summary from metadata
* remove batchId and id from celloutputmetadata
* remove extra line
* Add scan suppressions (#13705)
* Add action for responding to Needs Logs label (#13707)
* Fix action name (#13708)
* Add action for responding to Needs Logs label
* Fix action name
* Rename action config file (#13709)
* Add action for responding to Needs Logs label
* Fix action name
* Rename config file
* remove quotes
* Adding unit tests for schema compare service (#13642)
* Retry getConfig (#13712)
* Retry getConfig
* Add logging
* vBump Arc and Azdata (#13717)
* switch schema compare to use inputbox instead of table headers (#13715)
* Added Accounts and Database Backup Page to Migration wizard (#13548)
* Added localized strings
Created a db backup page
added radio buttons
* created components for database backup page
* Added account selection page
* Added accounts page
* Some more work done
- Added page validations
- Almost done with db backup except for a few api calls.
* Some more progress
added graph api for storage account
* Finished hooking up all the endpoints on db page.
* Some code fixed and refactoring
* Fixed a ton of validation bugs
* Added common localized strings to the constants file
* some code cleanup
* changed method name to makeHttpGetRequest
* change http result class name
* Added return types and return values to the functions
* removed void returns
* Added more return types and values
* Storing accounts in the map with ids as key
Fixed a bug in case of no subscriptions found
* cleaning up the code
* Fixed localized strings
* Added comments to get request api
Added validation logic to database backup page
removed unnecessary page validations.
* Added some get resource functions in azure core
* Changed thenable to promise
* Added arm calls for file shares and blob storage
* Added field specific validation error message
* Added examples in validation error message.
* Fixed some typings and localized string
* Added live validations to dropdowns
* Fixed method name to getSQLVMservers
* Use console.log for retry logging (#13722)
* Fixed Schema compare integration tests by adding retry (#13649)
* Add workspace information in Import UI (#13648)
* Add workspace information in Import UI
* Addressed comments
* Reduced space between Workspace heading and the label
* Lint azdata.d.ts (#13728)
* Added developer name to the list of developers. (#13725)
onboarding commit: Added developer name to the list.
* Fix environment variables for controller create (#13732)
* vbump schema compare and sql database projects (#13730)
* December release readme (#13733)
* Change server group look (#13608)
* change server group look
* remove dead code
* add top padding
* add bot padding as well
* fix heights to account for padding
* fix arrow alignment
* fix ellipses and node length parity
* fix alignment
* Make loading components not valid and improve RD radio group (#13738)
* Revert "Added Accounts and Database Backup Page to Migration wizard (#13548)" (#13742)
This reverts commit e169005571.
* Add loading text properties for option sources (#13743)
* Add loading text to deployment radio options
* Fix loading race condition
* Update text
* Add kube config and kube cluster to arc data controller screens (#13551)
* Un-skip and fix a few of the db projects tests (#13726)
* Un-skip and fix a few of the db projects tests
* Addressed comments
* Fix one test failure on Linux/Mac
* Update STS to revert SqlClient update (#13758)
* Update required azdata versions (#13762)
* fix the recent list (#13770)
* Adding base classes for data dev extension telemetry (#13763)
* adding telemetry dependencies for data-workspaces and sql-database-projects
* Adding telemetry dependencies for dacpac extension
* Adding telemetry base to data workspaces and projects
* Adding telemetry base code to the dacpac extension
Co-authored-by: Benjin Dubishar <benjin@Largo.local>
Co-authored-by: Sai Avishkar Sreerama <ssreerama@microsoft.com>
* Update changelog (#13773)
* Notebook Extension: First logging improvements (#13729)
* First logging improvements
* PR feedback for err output
* Add BEGIN/END to snippet (#13784)
* Adding database backup and accounts page to migration wizard (#13764)
* Added localized strings
Created a db backup page
added radio buttons
* created components for database backup page
* Added account selection page
* Added accounts page
* Some more work done
- Added page validations
- Almost done with db backup except for a few api calls.
* Some more progress
added graph api for storage account
* Finished hooking up all the endpoints on db page.
* Some code fixed and refactoring
* Fixed a ton of validation bugs
* Added common localized strings to the constants file
* some code cleanup
* changed method name to makeHttpGetRequest
* change http result class name
* Added return types and return values to the functions
* removed void returns
* Added more return types and values
* Storing accounts in the map with ids as key
Fixed a bug in case of no subscriptions found
* cleaning up the code
* Fixed localized strings
* Added comments to get request api
Added validation logic to database backup page
removed unnecessary page validations.
* Added some get resource functions in azure core
* Changed thenable to promise
* Added arm calls for file shares and blob storage
* Added field specific validation error message
* Added examples in validation error message.
* Fixed some typings and localized string
* Added live validations to dropdowns
* Fixed method name to getSQLVMservers
* Using older storage package
* Update typings/namings (#13767)
* Update typings
* more typings fixes
* switched fileshares and blobcontainers api to http requests
* removed the extra line
* Adding resource graph documentation link as a comment
* remove makeHttpRequest api from azurecore
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* change afterClean to beforeBuild for removing the generated assests.json (#13736)
* change afterClean to beforeBuild for removing the generated assests.json
* fix merge conflict
* rename files
* Clean up Loading Component typings (#13785)
* Clean up Loading Component typings
* add properties to impl
* Log active element when notebook smoke test fails (#13724)
* add error log for active element
* fix active element selector
* await isActiveElement call
* call waitforactiveleement
* Bump ini from 1.3.5 to 1.3.7 in /samples/sqlservices (#13776)
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.7.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](https://github.com/isaacs/ini/compare/v1.3.5...v1.3.7)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump ini from 1.3.5 to 1.3.7 in /build (#13765)
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.7.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](https://github.com/isaacs/ini/compare/v1.3.5...v1.3.7)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump ini from 1.3.4 to 1.3.8 (#13792)
Bumps [ini](https://github.com/isaacs/ini) from 1.3.4 to 1.3.8.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](https://github.com/isaacs/ini/compare/v1.3.4...v1.3.8)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump ini from 1.3.5 to 1.3.8 in /extensions/markdown-language-features (#13791)
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](https://github.com/isaacs/ini/compare/v1.3.5...v1.3.8)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* renable kernels dropdown test (#13727)
Verify no skipped core tests
* Remove redundant parameter in test scripts (#13755)
* Fire onDidSelect event when selecting event from code (#13691)
* Fire onDidSelect event when selecting event from code
* Fix import tests
* fix typo
* Use correct Azure graph endpoint & cleanup (#13786)
* Use correct Azure graph endpoint
* Add enum
* Update CODEOWNERS (#13798)
* Make project workspace selectable if no workspace is open yet (#13508)
* allow new workspace location to be editable
* fix workspace inputbox not showing up after toggling open workspace radio buttons
* add a few tests
* cleanup
* fix errors
* addressing comments
* fix filter for windows
* add error message if existing workspace file is selected and change picker to be folder only
* address comments
* fix typos and update tests
* vbump 2018 -> 2019 (#13800)
* Fix "not externalized correctly" warnings (#13806)
* Notebook Deep Link to Section (#13795)
* Notebook deep link to section
* fragment wip
* table component improvement (#13801)
* hyperlink column
* fixed width for image only button - old behavior
* Server Reports extension: fix for start and stop xevent sessions (#13565)
* fix for start and stop xevent sessions
* vscode.open for help URL
* setup info messages for localization
@kburtram - I could use an assist on updating the v# and publishing the vsix, but there's no rush this can wait until after the holidays
* Arc - Update Postgres name length limit (#13807)
Arc - Update Postgres name length limit. It was recently reduced from 12 to 11.
* Fix whitespace differences in sqlproj (#13805)
* add whiteSpaceAtEndOfSelfclosingTag
* update test baselines
* Fix paths for tests (#13816)
* Fixed the stray validation error message in Resource Deployment wizard (#13747)
* Fixed the stray validation error message
* Removed not working ' with validation
Adding back cancel button disabling
* mark a couple data workspace tests as unstable (#13822)
* cosmetic changes (#13820)
* cosmetic changes
* moved limitLongName function to the utils
* add . as trigger character (#13811)
* Remove hardcoded search box height (#13823)
* Use azdata-test modelview stubs (#13818)
* Filter vscode delegate command events (#13832)
* Fix duplicate SVG rendering (#13828)
* Fix select box event ordering (#13831)
* Fix select box event ordering
* more fixes
* Fix page
* Revert typing change
* Undo param
* Fix compile error
* Completely remove typings
* Dacpac - Showing error message to user if operation fails (#13830)
* Showing error message to user if operation fails.
* Added more tests
* Fix unstable data-workspace tests (#13824)
* stub file existing validation
* add error message
* change back to calling dialog.validate()
* move tests to separate dialogbase file and add more error message validation
* comment out the unstable unit test step (#13834)
* remove --build flag
* comment out unstable test
* add build tag back
* Removed padding-top / bottom declarations for text cell notebook-preview. This compacts the text cell by 14px on top and bottom. (#13815)
* Stop forcing left text align on tables (#13840)
* Have same connection logic for all nb int tests (#13844)
* Added fix for the infinite page refresh in resource Deployment tools page (#13813)
* Added fixed for the infinite loop in resource Deployment tools page
Generating events for select boxes only when the select box value is changed.
* Fixed the check logic in select method
* Reverted to old code and fixed some bugs
* Fixed event generation check logic
* Make new workspace inputbox editable in Create project from database dialog (#13842)
* update create project from database dialog to have editable new workspace
* add validation
* add test
* add error message
* Remove test for now
* cleanup
* add periods
* throw errors
* change return type to void
* Removal of Components folder, moving ADP notebook to its own notebook. (#13848)
* adp folder removed, notebook moved.
* moved ADP notebook to own folder.
* Passing click target to modal for positioning. Created custom buttons and click event handlers for Insert image and Insert link. Set feature behind preview flag.
* Revert "Revert "Fix windows insiders icons (#13579)" (#13630)"
This reverts commit 111dcb4c6885d9ab1a24398b13f103835789e6e0.
* Corrected button style and declared dialogStyle for ManageModelsDialog. This fixes broken layout see when user clicks: Import or view models.
* Revised suppressHeader/Footer to renderHeader/Footer and fixed logic. Code cleanup. Changed how calloutType: IMAGE and LINK are implemented. Added comments where neeed.
* Fixed callout separator: Swapped out transparent for notebookToolbarLines
* Removed promise context from image callout logic.
* Moved calloutDialog into modal folder.
* Code and style adjustments per feedback. Removed dependency on mac body class. Cleaned up dialog theme. Revsied modal callout logic.
* Corrected CSS for notebook toolbar. Removed unused code. Added code to ensure that renderFooter would occur whether true or undefined.
* Code cleanup. Clarified more details in my code comments. Added comments to values that needed identification. Escaping user-supplied text before it is rendered.
* Renamed TriggerProperties interface and implementations to DialogProperties. Added default value for DialogStyle to sqlExtHost.api.impl so existing dialogs take flyout by default.
* Replaced null value with undefined. Revised theme logic to account for undefined color value.
* Fixed top 30px offset rule so callout dialogs do not get this added.
* Revised undefined check for modal theme color. Removed calloutCompact. Moved callout dialog widths into DialogWidth property when calling methods to create callout or dialog. Added comments. Revised CSS.
* Providing fallback value in the case of null. Hex: FFFFFF00 is white with no transparency.
* Removed fallback hex color for foreground. Added check for foregroundRgb before attempting to grab rgba values. Added footer top border color.
* Added formatting after resolving conflicts.
* Corrected implementation after taking changes from main.
Co-authored-by: Maddy <12754347+MaddyDev@users.noreply.github.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: nasc17 <69922333+nasc17@users.noreply.github.com>
Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>
Co-authored-by: Barbara Valdez <34872381+barbaravaldez@users.noreply.github.com>
Co-authored-by: Christopher C <37060219+cavonac@users.noreply.github.com>
Co-authored-by: Monica Gupta <scorpio90m@gmail.com>
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com>
Co-authored-by: Karl Burtram <karlb@microsoft.com>
Co-authored-by: Sakshi Sharma <57200045+SakshiS-harma@users.noreply.github.com>
Co-authored-by: Vasu Bhog <vabhog@microsoft.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Lucy Zhang <luczhan@microsoft.com>
Co-authored-by: Leila Lali <llali@microsoft.com>
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
Co-authored-by: Sai Avishkar Sreerama <74571829+ssreerama@users.noreply.github.com>
Co-authored-by: Aditya Bist <adbist@microsoft.com>
Co-authored-by: Arvind Ranasaria <ranasaria@outlook.com>
Co-authored-by: Benjin Dubishar <benjin@Largo.local>
Co-authored-by: Sai Avishkar Sreerama <ssreerama@microsoft.com>
Co-authored-by: Drew Skwiers-Koballa <dzsquared@users.noreply.github.com>
Co-authored-by: Brian Bergeron <brian.e.bergeron@gmail.com>
Co-authored-by: Vladimir Chernov <v-chvlad@microsoft.com>
Co-authored-by: Alex Ma <alma1@microsoft.com>
* fix not numbered field
* fix for adding extra field and removing it from sections
* use const for variable
* use spread operator to create new object
* address pr comments
* change function name and simplify
* Add comment and put the initializeContents in the finally block
* Add podstatus to spec
* Added image to table and fixed spacing.
* Added pod status to spec
* PR fixes
* Edited so that when page is closed and reopened, does not have empty server group node table
* Adding summary page,
Storing ongoing migrations,
localizing some string,
made changes to how dropdowns work
updated database backup page
* Moved classes into different files
Fixed a lot of typos
Fixed some UI margins
* Turn on Linux CI test validation
* Add checks around a code block raising exceptions in unit tests
* Bump node version to 12
* Add check around classList add
* Adding migration notebooks to extension
* Adding toast notification instead of printing error in the console
* removed localization info from the links in the notebook
* Removed localization info from the links 2
* Fixed comments, placeholder and letter cases.
* highlight current range in the marked html
* find ranges on textContent not innerHtml
* add comment
* highlight all and mark the specific in orange
* register highlights in color themes
* fix the closure on the last style
* undo delete locproj file
* add comment
* undo format on locProj file
* Exposing azure HTTP request in azurecore
Moving migration specific request from azurecore to migration
Created a migrations typing file
* Deleting the typings file in sql migration
* Fixed typos in comments
* Adding default host for azure https requests
* Fixed operator in service url modification
* Changed path and host logic
* Made chagned requested in the PR
* Fixed variable names
* Adding / check for path.
* Changing error code check
* Fixed status logic in azure rest request
Fixed comment logic
Converting error array to string while throwing
* Fixed status check
* Fixed typos and cleaning up
* start work on ui
* Move notebooks complete
* Simplify version handling
* fix issues with add section method
* fix issues with the edit experience and add the quick pick for editing
* add version handler for re-writing tocs
* fix book toc manager tests
* add notebook test
* fix localize constant
* normalize paths on windows
* check that a section has sections before attempting to mve files
* Implement method for renaming duplicated files
* moving last notebook from section converts the section into notebook
* Add recovery method restore original state of file system
* Add clean up, for files that are copied instead of renamed
* remove dir complexity
* divide edit book in methods for easier testing and remove promise chain
* Keep structure of toc
* normalize paths on windows
* fix external link
* Add other fields for versions
* fix paths in uri of findSection
* add section to section test
* Add error messages
* address pr comments and add tests
* check that the new path of a notebook is different from the original path before deleting
* Initial commit for dSTS Auth
* Removed getDstsToken from accountManagementService. Renamed azureAccount to token.
* Renamed dstsToken to _token in connectionWidget
* Code Review Feedback. Renamed token to authToken in onFetchDatabases.
* Removed dsts options from Kusto package.json
* Added publish and schema compare telemetry
* Adding telemetry points for add/exclude/delete
* telemetry for validation
* Adding telemetry from project roundtrip updates, editing sqlproj, and db refs
* Changed method for obtaining extension ID during registration
* Fixing test failures, updating ads telemetry package dependency
* replacing action strings with enums
* change database project string actions to enums
* Changed action name to better match dialog
* PR feedback
* Addition: properties page with link to dashboard
* Include new page
* Initial Parameter page start
* Include new changes from merged PRs
* Including new constants
* Git errors
* Add parameter commands and help
* Reset command
* Added chart
* git fix
* Fixed string issues
* connectSqlDialog is an abstract class. Separated out Miaa and Postgress connection
* Initial start to adding connect to sql for postgres instance
* Simplified classes extending ConnectToSqlDialog, added get providerName, and function to create error message
* Miaa models provides dialog title
* Updated failed message parameters
* completionPromise.reject
* Fixed connect to MSSql
* Messy dialog showing from button
* removed this._completionPromise.reject
* Cleaning up code
* Set connectSqlDialog to be an abstract class. Separated out Miaa and Postgres. (#13532)
* connectSqlDialog is an abstract class. Separated out Miaa and Postgress connection
* Simplified classes extending ConnectToSqlDialog, added get providerName, and function to create error message
* Miaa models provides dialog title
* Updated failed message parameters
* completionPromise.reject
* Fixed connect to MSSql
* removed this._completionPromise.reject
* Connect button clean up
* Format
* Format doc
* Fixed compile errors
* Cleaning up page
* Clean up
* clean up refresh
* Format doc
* Removed ellipse
* Cleaning up problems
* Updating localized constants
* Missing username update
* Get connection profile added to Resource model, abstract method created for calling connection dialog
* Added createConnectionProfile
* took out import
* Pulled in new changes, fixed usercancellederror
* Getting engine settings
* Git errors
* Git errors
* Git errors fix
* Fixing Css
* Freezes, Search function working, 20 parameters
* Fixed re
* Git errors
* Save and reset commands working
* Discard works, updated how engine settings refresh with model
* Updated search, add back loading for when trying to connect
* Cleaning up comments left in code
* Git error
* Corrected names of icons and constants, Fixed Miaa dialog title
* Removed using any on page, added void return types, took out commented code
* Changed gear svg, made postgres extension a loc constant, fixed formatting
* Fixed controller model name
* Put connection profile and id in resource model, changed back controller model in base class
* Fixed a comment
* Added loading component for waiting for postgres extension to be installed
* Fix parameters page to show parameters if engine settings are already loaded (#13996)
* Added progress message for installing postgres extension
* Minor styling updates
* Making sure search box and rest buttons are enabled when opening page with loaded data. Update refresh
* Git errors
* change name
* Code review updates: Combined create parameters and refresh table.
* Update sql-assessment to use latest ads-extension-telemetry npm package (#14003)
* Change configure Jupyter server steps from async to sync (#13937)
* change config steps to sync
* fix tests
* use pathexistsSync
* remove pathExistsSync call
* address PR comments
* Use a minimum cell height to prevent whitespace markdown cells from becoming invisible. (#14008)
* Fix validation errors (#14009)
* Fix validation errors
* fix compile
* update return type
* Cleanup model component wrapper event handlers (#14012)
* Clean up button component disposables (#14011)
* Clean up button component disposables
* consolidate logic
* Adding Dacpac extension telemetry and core wizard/page telemetry updates(#13859)
* Dacpac telmetry code changes
* Removed added spaces
* Generate deployScript accessibility changed back to public
* code review suggessions updates
* dacpac extension tests fixes
* Updated time and filesize methods allowing general return values
* Telemetry code updates
* Dacpac Telemetry potential data loss capture and PII error excluded
* Dacpac telemetry code updates for comments
* Wizard pages navigation telemetry event capture moved to the core
* DacpacTelemetry code updates
* Extension wizard cancel telemetry for data loss
* Dacpac telemetry pagename and small code updates
* final Dacpac telemetry code updates...
* migrated loc files (#14015)
* Took out some info bubbles and addingitems
* Update search function
* Handle special value occasions
* Undo change
* Undo change
Co-authored-by: chgagnon <chgagnon@microsoft.com>
Co-authored-by: Lucy Zhang <luczhan@microsoft.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: Sai Avishkar Sreerama <74571829+ssreerama@users.noreply.github.com>
Co-authored-by: khoiph1 <khoiph@microsoft.com>
* Adding minimum height to text cell element so whether empty or occupied with a single line of content, the container is the same height.
* Added styles to remove top padding/margin from first child element and set top-padding of container.
* Switch top padding to px value
* Removed line-height and min-height as these are no longer necessary to maintain text-cell height.
* Made azure arc as resourcesubtype
Added new azure arc resource type
Added support for different eula statement for different subtypes
Consolidated getSelectedOption
* Fixed some PR based comments
* Fixed more pr comments
* Fixed the error in unit test by deep copying extension resourceTypes (to keep the original one intact)
* Fixed property name 'agreement' to 'agreements'
* Cloning subresourceTypes
* add check for if there are projects that haven't been added to the workspace
* add check when workspace folders change
* add comment
* update wording
* filter for multiple file extensions at the same time
* add test
* addressing comments
* updates to variablesand subscription
previous notebook was not taking Subscription into account. Here, I'm setting to use the az context explicitly with the $Subscription variable
* Converted appendix to nb, wording
* remove whitespace, add clarity
* - Fixed GetMigrationController
- Added createMigrationController and getControllerAuthKeys API in azure core.
- Added typings for Migration Controller
- Fixed database backup page validation logic
- Added IR page with create controller
* Fixing all the comments from the PR
* Fixed typings
* - Adding null checks for onValueChanged
- Adding new event for radiobuttons onDIdChangeCheckedState
* Adding get MigrationController API to azure core.
* string templating
fixed typings
* Fixed typing and sorting logic
* Made the undefined check logic concise.
* Fixing radioButton checked status
* Fixed all kinds of event bugs in radio buttons
* removing uneeded checks
* Fixing the logic for radiobutton onChange event generation for all possible scenarios.
* Made small changes in radioButton logic.
* add md preview line height settings
* remove if condition
* listen for configuration change
* change setting description
* only change line height outside of edit mode
* set minimum line height to 1
* combine ondidchangeconfiguration callbacks
* Enable Parameterization via Notebook URI
* Add Parameterization and Move notebookModel tests
* minor typos
* parameter typo
* Multiple parameters through uri fix
* Address PR comments and tests fix
* add new injected parameters after original injected parameters
* Add new test to verify notebookURi parameter is injected after both parameter and injected cell
* fix tests
* Fixing the checked variable in radio buttons
* Emitting the checked state of radio button.
* Adding onChanged event to radioButtons (exposing it)
Deprecating onClick event for radioButtons
Fixing radio button stubs
* Made some type fixes
* Firing event in checked event setter
* updating azdata-test to 1.1 in arc extension
* Some logic fixes in checked setter
* added proper typings and updated package version for azdata-data
* Renamed the event to onDidChangeCheckedState
* Fixed deprecation message
* Fixed broken Schema compare stubs
* Addition: properties page with link to dashboard
* Include new page
* Initial Parameter page start
* Include new changes from merged PRs
* Including new constants
* Git errors
* Add parameter commands and help
* Reset command
* Added chart
* git fix
* Fixed string issues
* connectSqlDialog is an abstract class. Separated out Miaa and Postgress connection
* Initial start to adding connect to sql for postgres instance
* Simplified classes extending ConnectToSqlDialog, added get providerName, and function to create error message
* Miaa models provides dialog title
* Updated failed message parameters
* completionPromise.reject
* Fixed connect to MSSql
* Messy dialog showing from button
* removed this._completionPromise.reject
* Cleaning up code
* Set connectSqlDialog to be an abstract class. Separated out Miaa and Postgres. (#13532)
* connectSqlDialog is an abstract class. Separated out Miaa and Postgress connection
* Simplified classes extending ConnectToSqlDialog, added get providerName, and function to create error message
* Miaa models provides dialog title
* Updated failed message parameters
* completionPromise.reject
* Fixed connect to MSSql
* removed this._completionPromise.reject
* Connect button clean up
* Format
* Format doc
* Fixed compile errors
* Cleaning up page
* Clean up
* clean up refresh
* Format doc
* Removed ellipse
* Cleaning up problems
* Updating localized constants
* Missing username update
* Get connection profile added to Resource model, abstract method created for calling connection dialog
* Added createConnectionProfile
* took out import
* Pulled in new changes, fixed usercancellederror
* Getting engine settings
* Git errors
* Corrected names of icons and constants, Fixed Miaa dialog title
* Changed gear svg, made postgres extension a loc constant, fixed formatting
* Fixed controller model name
* Put connection profile and id in resource model, changed back controller model in base class
* Fixed a few await issues
* Introduced ModelView as a class member in schemaCompareMainWindow
* Added a few button tests
* Fixed tests
* Add a missing await
* check untrusted notebook behavior
* remove skips
* check for elements after trusted nb is reopened
* move trusted element checks to notebook method
* make selector more specific
* Add notebook editor
Introduce notebook editor component to allow for separate notebook displays in order to accomodate notebook views
* Localize notebook views configuration title
* Refactor view mode and remove the views configuration while it is unused
* Only fire view mode changed event when the value has been changed
* Remove notebook views contribution
* Add metadata capabilities
* Notebook views definitions
* Add notebook views models
* Views test
* Rename type arguments
* Additional tests
* Fix unused import
* Update resize cell test
* Add notebook editor
Introduce notebook editor component to allow for separate notebook displays in order to accomodate notebook views
* Localize notebook views configuration title
* Refactor view mode and remove the views configuration while it is unused
* Only fire view mode changed event when the value has been changed
* Remove notebook views contribution
* update create project from database dialog to have editable new workspace
* add validation
* add test
* add error message
* Remove test for now
* cleanup
* add periods
* throw errors
* change return type to void
* Added fixed for the infinite loop in resource Deployment tools page
Generating events for select boxes only when the select box value is changed.
* Fixed the check logic in select method
* Reverted to old code and fixed some bugs
* Fixed event generation check logic
* stub file existing validation
* add error message
* change back to calling dialog.validate()
* move tests to separate dialogbase file and add more error message validation
* fix for start and stop xevent sessions
* vscode.open for help URL
* setup info messages for localization
@kburtram - I could use an assist on updating the v# and publishing the vsix, but there's no rush this can wait until after the holidays
* allow new workspace location to be editable
* fix workspace inputbox not showing up after toggling open workspace radio buttons
* add a few tests
* cleanup
* fix errors
* addressing comments
* fix filter for windows
* add error message if existing workspace file is selected and change picker to be folder only
* address comments
* fix typos and update tests
* Added localized strings
Created a db backup page
added radio buttons
* created components for database backup page
* Added account selection page
* Added accounts page
* Some more work done
- Added page validations
- Almost done with db backup except for a few api calls.
* Some more progress
added graph api for storage account
* Finished hooking up all the endpoints on db page.
* Some code fixed and refactoring
* Fixed a ton of validation bugs
* Added common localized strings to the constants file
* some code cleanup
* changed method name to makeHttpGetRequest
* change http result class name
* Added return types and return values to the functions
* removed void returns
* Added more return types and values
* Storing accounts in the map with ids as key
Fixed a bug in case of no subscriptions found
* cleaning up the code
* Fixed localized strings
* Added comments to get request api
Added validation logic to database backup page
removed unnecessary page validations.
* Added some get resource functions in azure core
* Changed thenable to promise
* Added arm calls for file shares and blob storage
* Added field specific validation error message
* Added examples in validation error message.
* Fixed some typings and localized string
* Added live validations to dropdowns
* Fixed method name to getSQLVMservers
* Using older storage package
* Update typings/namings (#13767)
* Update typings
* more typings fixes
* switched fileshares and blobcontainers api to http requests
* removed the extra line
* Adding resource graph documentation link as a comment
* remove makeHttpRequest api from azurecore
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* adding telemetry dependencies for data-workspaces and sql-database-projects
* Adding telemetry dependencies for dacpac extension
* Adding telemetry base to data workspaces and projects
* Adding telemetry base code to the dacpac extension
Co-authored-by: Benjin Dubishar <benjin@Largo.local>
Co-authored-by: Sai Avishkar Sreerama <ssreerama@microsoft.com>
* change server group look
* remove dead code
* add top padding
* add bot padding as well
* fix heights to account for padding
* fix arrow alignment
* fix ellipses and node length parity
* fix alignment
* Added localized strings
Created a db backup page
added radio buttons
* created components for database backup page
* Added account selection page
* Added accounts page
* Some more work done
- Added page validations
- Almost done with db backup except for a few api calls.
* Some more progress
added graph api for storage account
* Finished hooking up all the endpoints on db page.
* Some code fixed and refactoring
* Fixed a ton of validation bugs
* Added common localized strings to the constants file
* some code cleanup
* changed method name to makeHttpGetRequest
* change http result class name
* Added return types and return values to the functions
* removed void returns
* Added more return types and values
* Storing accounts in the map with ids as key
Fixed a bug in case of no subscriptions found
* cleaning up the code
* Fixed localized strings
* Added comments to get request api
Added validation logic to database backup page
removed unnecessary page validations.
* Added some get resource functions in azure core
* Changed thenable to promise
* Added arm calls for file shares and blob storage
* Added field specific validation error message
* Added examples in validation error message.
* Fixed some typings and localized string
* Added live validations to dropdowns
* Fixed method name to getSQLVMservers
* Add dependent field provider to resource deployment
* Change name to value provider service
* Add error handling
* providerId -> id
* Set dropdown value correctly
* missed id
* back to providerId
* fix updating missed id
* Make resource deployment providers disposable
* Add dependent field provider to resource deployment
* Change name to value provider service
* Add error handling
* providerId -> id
* Set dropdown value correctly
* missed id
* back to providerId
* fix updating missed id
* remove placeholder
* Added engine version argument to edit command. Neccessary for not using pg12
* Included for changing password in overview page
* Updated fakeazdataapi test
* draft commit
* few changes
* Changes to copy query with results in plain and html formatting
* undo changes
* undo unintended change
* remove comments
* Addressed comments
* Some clean up
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
* UI hook up
* Add tests
* Add back the missing statement for opening project
* Fix failures
* Add a few more tests
* Fix test failure
* Addressed comments
* Update UI to match the mocks
* Update UI to match updated mockups
* Addressed comments to match UI with mockup
* Updated all import strings to be called as Create Project From Database strings
* Fix a couple of test failures and one comment addressed
* Update one missed import string
* Skipping a failing test for now
* Fix failures. Fix alignment of icons
* Addressed PR comments
* Addressed couple more PR comments
* saving wip to merge main
* temp fixes for textValidation* removal
* save wip to switch tasks
* save wip to switch tasks
* save wip to switch tasks
* code complete - with known bugs
* missed test file
* fix extHostModelView changes
* validation module
* missed test changes
* missed change
* pr feedback
* pr feedback
* revert inadvertent change
* remove unneeded change
* merge from bug/12082-2
* pr feedback
* pr feedback
* bdd -> tdd for validation tests
* bdd -> tdd for validation tests
* pr feedback
* remove unneeded file
* pr feedback
* EOL instead of '\n'
* pr feedback
* pr feedback
* minor fixes.
* pr feedback
* fix comment
* comments and var renames
* test fixes
* working version after validation simplification
* working version after validation simplification
* remove inadvertent change
* simplified validations
* undo uneeded change
* cleanup
* working version after latest merge
* comments and whitespace fixes
* remove is_integer checks
* sentence case field validation messages
* Use generic strings in sample fields
* minor fixes to sample extension strings
* spaces to tabs for indentation
* request fields before limit fields
* reaarange request/limit fields
* is_integer checks for PG Server Group number fields
* Thenable to Promise
* InputBoxInfo
* pr feedback
* pr feedback
* isUndefinedOrEmpty to utils
* include asde package.json
* use ValidationValueType
* ValidationValueType -> InputValueType
* Add support for dynamic enablement of resource deployment components
* use instanceof function
* getValue returns InputValueType
Co-authored-by: Arvind Ranasaria <ranasaria@outlook.com>
* Fix project context menu actions (#12541)
* delete works again
* make fewer changes
* update all sql db project commands
* cleanup
* Remove old projects view (#12563)
* remove old projects view from file explorer view
* fix tests failing
* remove projects in open folder opening up in old view
* Update db reference dialog to show projects in the workspace (#12580)
* update database reference dialog to show projects in the workspace in the project dropdown
* remove workspace stuff from sql projects extension
* undo change
* add class that implements IExtension
* undo a change
* update DataWorkspaceExtension to take workspaceService as a parameter
* add type
* Update sql database project commands (#12595)
* remove sql proj's open and create new project from comman palette
* hook up create project from database to data workspace
* rename the remaining import databases to create project from database
* remove open, new, and close commands
* expose addProjectsToWorkspace() in IExtension instead of calling command
* Addressing comments
* fix failing sql project tests (#12651)
* update SSDT projects opened in projects viewlet (#12669)
* fix action not refreshing the tree issue (#12692)
* fix adding project references in new projects viewlet (#12688)
* Remove old projects tree provider (#12702)
* Remove old projects tree provider and fix tests
* formatting
* update refreshProjectsTree() to accept workspaceTreeItem()
* Cleanup ProjectsController (#12718)
* remove openProject from ProjectController and some cleanup
* rename
* add project and open project dialogs (#12729)
* empty dialogs
* wip
* new project dialog implementation
* revert gitattributes
* open project dialog
* implement add project
* remove icon helper
* refactor
* revert script change
* adjust views
* more updates
* make data-workspace a builtin extension
* show the view only when project provider is detected (#12819)
* only show the view when proj provider is available
* update
* fix sql project tests after merge (#12793)
* Update dialogs to be closer to mockups (#12879)
* small UI changes to dialogs
* center radio card group text
* Create workspace if needed when opening/new project (#12930)
* empty dialogs
* wip
* new project dialog implementation
* revert gitattributes
* open project dialog
* implement add project
* remove icon helper
* refactor
* revert script change
* create workspace
* initial changes
* create new workspace working
* fix tests
* cleanup
* remove showWorkspaceRequiredNotification()
* Add test for no workspace open
* update blue buttons
* move loading temp project to activate() instead of workspaceService constructor
* move workspace creation warning message to before project is created
* pass uri to createWorkspace
* add tests
Co-authored-by: Alan Ren <alanren@microsoft.com>
* Additional create workspace changes (#13004)
* Dialogs workspace updates (#13010)
* adding workspace text boxes
* match new project dialog to mockups
* Add validation error message for workspace file
* add enterWorkspace api
* add warning message for opening workspace
* cleanup
* update commands to remove project so they're more generic
* remove 'empty' from string
* Move default project location setting to data workspace extension (#13022)
* remove project location setting and notification from sql database projects extension
* add default project location setting to data workspace extension
* fix typo
* Add back project name incrementing
* other merge fixes
* fix strings from other PR
* default to last opened directory instead of home directory if no specified default location
* A few small updates (#13092)
* fix build error
* update title for inputboxes
* add missing file
* Add tests for data workspace dialogs (#13324)
* add tests for dialogs
* create helper functions
* New project dialog workspace inputbox fixes (#13407)
* workspace inputbox fixes
* fix folder icons
* Update package.jsons and readme (#13451)
* update package.jsons
* update readme
* add workspace information to open existing dialog (#13455)
Co-authored-by: Alan Ren <alanren@microsoft.com>
* Fixed the generate script logic for notebook wizards.
* -reverted previous changes
-added last page check to the page validation change logic.
* checking if the page is valid when entering it.
* removing unnecessary index variable in forEach loop
* added comments for generate script button enabling on notebookwizard page.
* Added azurehybridtoolkit to list of external extensions
* Added updated book
* added to recommended extensions
* extensions.js updated for build
* added small changes to extension
* small changes to extension
* tsconfig change
* gitignore and vscode changes
* changed package display name
* save connection info in notebook metadata
* update attachTo dropdown based on saved alias
* add setting for saving connection (default=false)
* save/read cell connection name to/from metadata
* get started on toggling multi connection mode
* add activeConnection property to cell model
* add changeContext method for cell
* add comments
* add unit test for reading connection name
* save connection mode in metadata
* clean up code
* address PR comments
* Add archive logs step to linux build
* right file
* try
* try this
* correct order
* build artifact
* export
* log
* use tmp
* zip up all
* Remove extra publish
* other scripts
* add test name to dir
* Push the latest update for WYSIWYG bug
* Improvements to nested lists
* OL tests and PR feedback
* Fixed all toolbar options for tags
* Address PR comments
* Ensure style is kept and not escaped
* Add all markdown toolbar action tests
* Style text edge case fix
* Address repeat function and type comment
* add more clarifying test
* SQL VM wizard migration to ResourceType Wizard
* Revert "SQL VM wizard migration to ResourceType Wizard"
This reverts commit e58cd47707a7e2812be20d915f1fe638b96b035f.
* migrated notebook wizard
* SQL VM wizard migration to ResourceType Wizard
* Fixed some imports on SQL VM wizard
* migrated sqldb wizard to generic ResourceTypeWizard
* Added missing import
Solving errors from the merge
* Moved some common functionality into ResourceTypeWizard
* Changed logic of start deployment
* fixed some import after changing files.
* added pagelss model and tools and Eula Page
* Hacky solution to fix wizard update bugs
* Removed tools and Eula components from resourceTypePickerDialog
* Removing changes in ext host
* reverting every change in ext host dialog
* Fixed setting the first provider for resourceTypeWizard.
* Some PR related changes
-Fixed typo in localized constants
-made some code logic concise
-Removed unnecessary check in tools&Eula
* Added some fixes for compilation error
* some refactoring for PRs
* moved comment
* cleaning up some code to make it more readable
* fixed comment typo
* Some additional cleaning up of code.
* Adding a public getter for model
* -Adding error message for failed EULA validation
-Removed unnecessary check for selected resource.
* Added comment to explain model variable behavior
* Added additional comments
* Fixed a comment to make it accurate
* Better phrasing for a comment
* added arialable for check all checkboxes and added some missing roles for the table elements
* removed duplicate attribute
* Moved column header aria label logic to a function.
* fixed typos in declarative table
* Changed the aria label text to something that is more intuiive.
* fixed typo in localized string identifier
* adding focus outline styling for checkboxes
* Merge pull request #110038 from aasimkhan30/aasim/fix/checkboxOutline
Added outline offset to checkbox to make focus visible.
* Revert "adding focus outline styling for checkboxes"
This reverts commit 1f9de7a00f7e947725e9e935d0be5bca2d662600.
Co-authored-by: Miguel Solorio <miguel.solorio@microsoft.com>
* Added new warning icon for model input mapping view. Adjusted padding between it and the input field beside it.
* Added new warning icon for model input mapping view. Adjusted padding between it and the input field beside it.
* Modified icon fill colors for better presentation in dark/HC themes. Modified font sizes and padding in various places. Increased input field widths. Removed unnecessary width properties.
* Revised styles and added elements to view models stage of the View and import models.
* Implemented Leilas DataInfoComponent, replacing my use of icon and title, description fields. Corrected some styles.
* Fixed the issue with icon title and description
* Fixed severla issues
* Added method to output localized text for number of models shown. Added component to display models shown text.
* Fixed the issues with order of components
* Fixed showing number of models
Co-authored-by: llali <llali@microsoft.com>
* Added Tools Service call for ValidateStreamingJob
* Partial addition of ESJ
* adding test mocks
* Validation working
* Modifying command visibility logic to submatch ESJs in addition to files
* Changed string literal to constant, corrected attribute order
* Added tests
* correcting casing that's causing test failures on linux
* Swapping Thenable for Promise
* excluded validate from command palette
* Add interface for modifying the table of contents of books
* Add logic for creating toc
* Fix issue with toc
* Add test for creating toc
* Delete bookTocManager.test.ts
* update allowed extensions
* Fix failing tests and add test
* Add tests for creating books
* Remove unused methods
* add section to section
* Created a function to disable the upgrade existing databases radio button if no databases exist.
* Created helper functions for the upgrade database radio button and new database radio button and abstracted the code accordingly.
* Made changes to helper function names and signatures, and added the enableUpgradeRadioButton() helper function.
* Made some changes to the enableUpgradeRadioButton helper function.
* Made changes to helper functions to ensure the radio buttons enable accordingly when a server is changed from the server dropdown.
* Made changes to helper functions and checks.
* Made additional checks to the populateDatabaseDropdown function.
* Added the logic to select the new radio button when upgrade radio button is disabled.
* Hiding dacpac from search for SQLOD
* Removing Schema compare from search bar for SQL OD
* Updating STS version for removing ServerRoles folder change for SQL OD
* save connection info in notebook metadata
* update attachTo dropdown based on saved alias
* add setting for saving connection (default=false)
* dont show saved conn if seting off + added test
* show conn dialog if save conn name setting off
* address PR comments and fix unit test
* change connectionName to connection_name
* SQL VM wizard migration to ResourceType Wizard
* Revert "SQL VM wizard migration to ResourceType Wizard"
This reverts commit e58cd47707a7e2812be20d915f1fe638b96b035f.
* migrated notebook wizard
* SQL VM wizard migration to ResourceType Wizard
* Fixed some imports on SQL VM wizard
* migrated sqldb wizard to generic ResourceTypeWizard
* Added missing import
Solving errors from the merge
* Moved some common functionality into ResourceTypeWizard
* Changed logic of start deployment
* fixed some import after changing files.
* fixed some easy typos on sql db wizard.
* Fixed some instructions in the notebook
* - Added option to enable or disable firewall rules
* converted toggle firewall dropdown to checkbox
* Add support for "More Actions" column in resource viewer
* update provider
* remove import
* Use menu contribution and make actions column always show
* cleanup
* move context menu anchor
* Comments
* Vores and memory had needed request/limit commands switched
* If saving returns an error, leave discard button enable
* Check if workers is undefined
* refactor grid streaming (convert to data first)
* change convertRowsToHtml method to return value
* remove griddataconversioncomplete checks
* send row data from STS to gridoutput component
* clean up code
* send data updates to cell model
* serialize cell output at the end of cell execution
* remove unused parameters
* update output contents instead of output reference
* remove unnecessary promise
* move azdata changes to proposed
* update comment
* add search box
* switch back to the traditional azure tree
* Revert "switch back to the traditional azure tree"
This reverts commit 7904b9cd599591e94412ec79da23590068de46b6.
* flat account tree node and filtering
* add comment
* context menu
* fix test
* handle disposable
* add logging
* Backend work for Parameterization + Tests
* address comments
* Add Parameters Tag upon state change
* Edit CSS Styling for accessibility
* more generic tag names
* Set python path in kernel specs when running on SAW devices.
* Use tab spacer for kernel json.
* Update path to jupyter kernelspec.
* removing the kernelspec write
* Changed powershell kernel.json to use appdata folder
* Addressed PR and added try catches around the code.
* removed redundant try catch
* removed redundant try catch
* removed another try catch
* removed space
* Fix for multiple powershell notebook failing issue
Co-authored-by: Cory Rivera <corivera@microsoft.com>
* Set python path in kernel specs when running on SAW devices.
* Use tab spacer for kernel json.
* Update path to jupyter kernelspec.
* removing the kernelspec write
* Changed powershell kernel.json to use appdata folder
* Addressed PR and added try catches around the code.
* removed redundant try catch
* removed redundant try catch
* removed another try catch
* removed space
Co-authored-by: Cory Rivera <corivera@microsoft.com>
* fix for removed links in untrusted notebooks
* replace whitespaces on link for %20
* remove dot from hyperlinks
* Address PR comments
* Change name of variable
* processwhenclause added
* processWhenClause explanation added
* changed comment to be more generic.
* changed expected comparison
* test and space fix added
* fixed tests
* resourceTypeService now uses forloop
* promote api to official
* add comments
* disposable
* move getConnection out
* comment for connection namespace
* remove extra line
* also fix registerQueryInfoHandler
* added filtering to the resource type along with a new component.
* -Added caching of cards
-Removed unused component props
-localized tags
-limited the scope of list items
* Made some changes in the PR
* - Added Iot Category to SQL edge
- Moved category names to constants
- Moved localization strings to localized constants
- Made filtering logic more concise
- Changed how category list is generated
--Category list can now be ordered
-Added back event generation for selectedCard
* Fixed bugs, and some additional changes
-Fixed radiogroup height to avoid the movement of options below it
-Restoring the focus back to the search and listview components
- Added focus behaviour for listview
- Fixed a typo in comment
* Made categories an Enum
* Added localized string
* localized category string
converted categories to enum.
* made the filtering logic more concise.
* returning string if no localized string formed
removed unnecessary returns
* fixed the filtering tag logic
resetting search when category is changed
* removing the iot tag from sql edge deployment
* made filtering logic more concise
made enum const
* added vscode list
* some cleanup
* Some PR changes
- Made PR camelcase
- added comments to SQL
- removed unnecessary export
* -Some PR related changes
-Removing unsupported style property
-scoping down css and removing unused ones.
* Fixed a comment text
* Fixed typings for listview event
* fix search for pinned notebooks
* fix filtering when verifying that a search folder is not a subdirectory from the current folder queries path
* Show book node on pinned notebooks search results
* fix parent node on pinned notebooks search results
* fix search for pinned notebook and modify how pinned notebooks are stored in workspace
* update format of pinned notebooks for users that used the september release version
* removed unused functions
* Address PR comments
* fix parent node for legacy version of jupyter books
* remove cast from book path
* Getting the proper attribute during column modification
Exposing errors of change column settings and stopping import if they occur
* removing extra space
* Added a comment for error handling
* Fixed a test error that was caused due to insufficient null checks.
* removing unnecessary return
* Add quick pick to select target platform for a project
* add test
* show current target platform and info message for new target platform
* fix test failing
* 3644 Added RequestSecurityTokenParams, RequestSecurityTokenResponse, and SecurityTokenRequest to Kusto/contracts.ts. Added AccountFeature to features.ts. Registered feature in kustoServer.ts
* 3644 Removed TryCatch in kusto features > getToken
* 3644 Added AccountId to Kusto > RequestSecurityTokenParams. Refactored kusto features getToken to use the accountId for the query window.
* 3644 Removed unused AccountQuickPickItem
* 3707 Changed getIconpath in serverTreeRenderer to always set iconPath if iconId is undefined. Changed renderConnection to always renderServerIcon
* 3707 Added default flag to KustoIcon in package.json
* fix caching issue
* 3707 Changed default to optional variable. Updated asyncServerTreeRenderer > getIconPath to check for default
* 3707 Changed logic for setting iconPath in getIconPath
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* dashboardWidget to use updated button component - added an enum for buttonType.
* Code fixes.
* Casting ButtonType to string
* Leaving default description value as empty string. Testing logic for buttonType.
* Moved ifFile check into buttonType getter. Hard coded button type returns to test on the front end.
* revised buttonType getter to return Normal by default if not specified in properties.
* Extended sql Button as InfoButton for use in dashboardWidget.
* Added InfoButton to ngAfterViewInit
* Upadted how infoButton element is built. Exposed properties for use in button.component.
* Experiment: Added interface and imported iconUtils for getting iconClass.
* infoButton updates
* Some modifications
* Defined HTMLElements and populated each with properties from dashboardWidget.
* Rewrote elements and passed in properties from dashboardWidget to define button contents and layout.
* Added missing delineator.
* Correctd width getter.
* Code cleanup
* Styled header and button copy. Corrected button and header dimensions.
* Button and welcome page background style adjustments.
* infoButton: Added element reference for container coming in via super so I could apply styles to it. Corrected how button renders.
* Addressed PR feedback - removed async functionality where not needed. Modified syntax that is being deprecated. Made extended IButtonOptions all optional.
* Formatted azdata.proposed. Hygiene check flagged it.
* Removing ? and undefined from button properties as all are being passed from dashboard Widget
* Initialized private vars representing options from custom interface IInfoButtonOptions.
* Addressed PR feedback - added stylesheet for infoButton. Removed iconPath from infoButton context. Cleaned up overall implementation.
* Simplified linear-gradient behind main image so it works across all three themes.
* Style cleanup.
* Removed block notation from element creation in constructor.
* Fixed type signature of IInfoButtonOptions.
* Removed comments. Shifted infoButton style properties into stylesheet.
* Set background color for infoButton when active. This fixes issue where is becomes invisible while selected.
* Corrected styles. Removed hard-coded font-colors. Removed unnecessary styles.
* CSS - added hover styles to side panel items per Figma comps. Cleaned up CSS and removed code comments.
* remove unused splash screen and fix issue reporter path (#12218)
* data workspace extension batch 2 (#12208)
* work in progress
* load projects in view and test cases
* update scope
* make the sql proj menu available in workspace view
* add extension unit test
* address comments
* fix errors
* Add reference to another sql project (#12186)
* add projects to add database reference dialog
* able to add project references
* check for circular dependency
* only allow adding reference to project in the same workspace
* fix location dropdown when project reference is enabled
* add tests
* more tests
* cleanup
* fix flakey test
* addressing comments
* fix focus order (#12233)
* Notebook Text Cell Highlight Improvements (#12197)
* 1st iteration
* works but multiple highlights
* remove comment
* Works but multiple selects
* wip
* cleanup
* cleanup
* Update TPN
* Add mark.js to remote + web
* PR feedback
* Tweak workbench html files
* Add vcore limit support (#12212)
* Quick tweaks to resource viewer (v1) (#12210)
* Hackathon - Better Markdown Editor (#11540)
* Hackathon - better markdown editor - modified Bold to wrap selection in HTML. Split Image button into two new options: embed and link. Made preview container contentEditable.
* Removed the new dropdown from Image button -- it is not necessary since we are adding a context panel instead.
* Modified preview icons
* Set code-component dimensions so it is not visible. It is still being used to pass markdown changes to however.
* add turndown and save markdown
* update model on UI when source changes
* Added conditional that sets element attribute contentEditable when it is in edit mode.
* Added textView component that can be used for editing.
* update source on MD view not on every keystroke
* Added markdown editor buttons that allow user to swap editor, preview views.
* Cleaning up implementation
* Setting base value of _showPreview to false.
* don't allow html edit on split view
* Update editor automagically
* Add an image picking dialog to notebook toolbar.
* Await transformText()
* revert pushEditOperations to fix cursor issue
* Implemented radio buttons for three view toggles.
* Added new, optional properties to radioButton: name, icon class and tooltip. This allows for display as toggleable icon. Updated styles and theme accordingly.
* Style tweaks.
* Added new ViewAction file where the RadioButton action will reside.
* Removed radio button implementation in exchange for native button instantiation. Adjusted CSS and theme accordingly.
* Styles, component and template changes to handle view toggle between text, markdownn an splitview. Includes reverting of radioButton as this is no longer used.
* WYSIWYG 3 Modes
* Ensure one action active at a time
* Setting Text View button active by default. Cleaned up styles. Moved toolbar element to prevent code cell layout overflow.
* Ensure we respect editMode, add showMarkdown
* hiding overflow on code-cell
* Empty text container needs 100% width. Eliminates weird selection border too.
* Initialize _previewMode
* Actions Compatibility
* Further toolbar enhancements
* Update yarn lock after merge
* Slim down changes
* Remove commented out code
* Added margins around notebook-preview container for more visual space for text
* Add turndown to workbench html
* Tweak import
* Add types/turndown
* Remove workbench.html fix
* Import cjs modules directly for turndown
* Leverage solution from github
* browser umd
* non browser umd
* welp dependency
* Modified updatePreview to insert a p tag only when text cell is empty.
* add listener for undo
* add turndown to remote and web
* Fix workbench, check in plugin
* PR comment
Co-authored-by: maddydev <makoripa@microsoft.com>
Co-authored-by: chlafreniere <hichise@gmail.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: Lucy Zhang <luczhan@microsoft.com>
* Update external repo links (#12226)
* Update external repo links
* Update yarn files
* make schema compare test unstable (#12234)
* make schema compare test unstable
* also make Standalone database context menu test unstable
* Fix missing package update (#12235)
* Resource Deployment UX Refresh (#12173)
* adding new card to styles
* renamed property, removed unnecessary css
* Fixed to match new props
* added horizontal class
* merged from master
* Make SandDance work generically for Kusto (#12229)
* Make SandDance work generically for Kusto and Postgres
* Addressed comments
* removed param
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
* Set items in cell model (#12237)
* Change tables to make them work for our scenario (#12193)
* Change tables to make them work for our scenario
* Comments & deprecate API
* Disable selections by default
* Have default values in add database dialog input boxes (#12155)
* show default values in text boxes
* add sqlcmd formatting
* add tests
* Add some sqlcmd variable name validation
* Addressing comments
* fixes after merge
* fix test
* don't localize OtherServer
* fix for windows
* one more fix
* fix test
* fix bug that doesn't register double click enabled on new notebook contexts (#12239)
* Notebooks: Hide link and image buttons in text cell toolbar in WYSIWYG mode (#12240)
* hide link and image buttons in WYSIWYG mode
* defined taskbar actions
* rename arrays
* Notebooks: Add setting for default text cell edit behavior (#12245)
* Add setting for default text cell edit behavior
* string updates
* Fix pinned notebooks navigator (#12246)
* Added loading to dropdowns (#12214)
* Added loading prop to dropdowns
* Added property for setting loading text message
* removed unnecessary sets
* changed code to match new changes
* Changed the dropdown loader to use select component instead of edit.
Added missing props in dropdown loader
* Address comments jupyter create book notebook (#12250)
* Remove toc file link and add warning for windows users
* Bump node-fetch from 2.6.0 to 2.6.1 in /build/actions (#12219)
Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.6.0 to 2.6.1.
- [Release notes](https://github.com/bitinn/node-fetch/releases)
- [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md)
- [Commits](https://github.com/bitinn/node-fetch/compare/v2.6.0...v2.6.1)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump node-fetch from 2.6.0 to 2.6.1 in /build (#12220)
Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.6.0 to 2.6.1.
- [Release notes](https://github.com/bitinn/node-fetch/releases)
- [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md)
- [Commits](https://github.com/bitinn/node-fetch/compare/v2.6.0...v2.6.1)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fix Notebook Kusto Kernel Consistency (#12256)
* fix kusto notebook consistency
* Address undefined
* add existing project to workspace feature (#12249)
* add existing project to workspace feature
* update file name
* new test and use URI
* handle workspace with no folder
* add more validation
* and more tests
* use forward slash
* Use correct resource name (#12288)
* Add heasdingStyle atx option (#12286)
* Disable resource viewer (#12291)
* Disable resource viewer
* comment
* Remove unused
* adding icon for add new and open project (#12265)
* remove project feature (#12297)
* remove project feature
* update test
* Fix notebook cancel query bug (#12300)
* fix undefined query runner error
* store connection id
* revert sqlSessionManager change
* Update PG Deployment with new fields (#12187)
* Added 5 missing field options
* Missing apostrophe
* Change extensions label
* Update volume size descriptions
* Change volume size labels
* Reorder required tools
* Reorder required tools
* Argument fixes
* Removed tabs
* Rearrange option order
* Rearrange option order
* Rearrange option order VS
* Added validation to fields. VS accepts only integer and appends Gi
* Changed Dusky deployment title
* Removed text validation for VS and Mem. Changed to Number field type
* Min set to 1 for VS and Mem
* Min set to 1 for Cores
* Memory limit must be at least 256Mi
* the casing of 'preview' should remain consistent
* Removed empty line
* Portal links for main branch (#12319)
* first commit
* json field added
* message genericized
* order changed
* removed summary page text
* fixed url
* controller dropdown field to SQL MIAA and Postgres deployment. (#12217)
* saving first draft
* throw if no controllers
* cleanup
* bug fixes
* bug fixes and caching controller access
* pr comments and bug fixes.
* fixes
* fixes
* comment fix
* remove debug prints
* comment fixes
* remove debug logs
* inputValueTransformer returns string|Promise
* PR feedback
* pr fixes
* remove _ from protected fields
* anonymous to full methods
* small fixes
* new postgres model (#12305)
Co-authored-by: Brian Bergeron <brberger@microsoft.com>
* Nasc/delete instance code removal (#12307)
* Formatted page
* Removed ResourceHealthPage from the dashboard
* Deleted files that no longer applies to the public preview backend
* shouldn't be able to open the postgres dashboard
* Add new deployment options for MIAA (#12325)
* Use custom dialog for prompting MIAA connection info (#12316)
* Use custom dialog for prompting MIAA connection info
* disable inputs
* Update strings
* remove data-workspace dependency (#12321)
* Arc public preview updates (#12329)
* Arc public preview updates
* disable PG dashboards again
* Stop watching for sqlproj updates after the file is closed (#12311)
* stop watching for sqlproj updates after the file is closed
* remove watcher if project is closed
* Fix component items in declarative table not showing (#12330)
* fix maximize bug (#12334)
* 12284 Removed custom CSS that positioned editor text beneath overlapping layers. Text is now selectable. (#12312)
* Add newline after caption (#12276)
* Watch for on load event (#12309)
* Update deletion strings to refer to instances instead of resources (#12332)
* Update deletion strings to refer to instances instead of resources
* one more
* Remove unused
* More
* Fix DT linting issues (#12290)
* vbump sql-db-proj extension (#12336)
* update sqlproj dependency version (#12359)
* Fix highlight issue (#12278)
* Fix highlight issue
* Address PR comments
* remove a import unit test (#12358)
* SQL VM deployments (#12144)
* Added sql vm deployment option
* Added more fields for sql vm deployments
* created basic sqlvm deployment. Mostly hardcoded
* added string to package.nls
* added poc deployments for sql vm
* Made some changes in the notebook that was mentioned in PR
* Added scaffolding for azure sql vm wizard.
* code cleanups
* added some async logic
* added loading component
* fixed loader code
* completed page2 of wizard
* added some more required fields.
* added some more fields
* added network settings page
* added sql server settings page
* added azure signin support and sql server settings page
* added some helper methods in wizard code
* added some fixes
* fixed azure and vm setting page
added validation in azure setting page
* added changes for the notebook variable
* validations and other bug fixes
* commenting sql storage optimization dropdown
* cleanedup wizard base page
* reversing vm image list to display newer images first
* cleaning model code
* added validations for network setting
* Completed summary page
fixed the code poisition
some additional field validations
* fixed networking page
* - fixed an error with vm size model variable
- removed byol images because it was not working with az sql vm
- Fixed vm size display names in dropdown
* added double quotes to some localized strings
* added some space inside strings
* -Added live validations
-Restyled network component
-Added required to regions
-Some bug fixes
* -redesigned summary page
-localized some strings
* Fixed summary page section titles
* -Fixed validations on sql server settings page
-Fixed some fields on Summary Page
* corrected onleave validation
using array for error messages
using Promises.all
* Fixed bug on network settings dropdowns when user does not have existing resource to populate them
* Change resource deployment display name
Added Ninar's iteration of the notebook
Changed RDP check box label
Surfacing API errors to user
Filtering regions based on Azure VM regions and user's subscription region
Made form validation async
Displaying new checkbox on network page when dropdowns empty
Fixed a small bug in SQL auth form validation
Made summary single item per row and fixed the gaps in spacing
Fixed validations in vm page
Checking if vm name already exists on azure
* Fixed sql vm eula
Fixed sql vm description
Added hyperlink for more info on vm sizes
* Replaced loading component with dropdown loaders.
* localized string
Fixed a bug in network settings page
* Added additonal filtering
* added reverse to image images
* Fixing some merge related issues
* Update arc regions for public preview (#12366)
* Fix duplicate arc instance nodes (#12381)
* Add "No instances available" node for empty arc controllers (#12374)
* Remove MIAA Port Deploy Option (#12388)
* fix option sources (#12387)
* Fix manage action for arc view (#12389)
* 12360 Notebook UI - Mac/Win fix for Select all. (#12383)
* 12360 Notebook UI - Mac/Win fix for Select all.
* Fix for ctrl key selecting all in windows
* Fix undo as well
* preventDefault to prevent confusing behavior
Co-authored-by: chlafreniere <hichise@gmail.com>
* Fix notebook table rendering with multiple code cells (#12363)
* create unique query runner for each cell
* use cellUri instead of cellId to identify runner
* disconnect each query runner connection
* remove queryrunners size check
* Remove azdata eula acceptance from arc deployments (#12292)
* saving to switch tasks
* activate to exports in extApi
* working version - cleanup pending
* improve messages
* apply pr feedback from a different review
* remove unneeded strings
* redo apiService
* remove async from getVersionFromOutput
* remove _ prefix from protected fields
* error message fix
* throw specif errors from azdata extension
* arrow methods to regular methods
* pr feedback
* expand azdata extension api
* pr feedback
* remove unused var
* pr feedback
* Notebooks: Fast update WYSIWYG support for source update (#12289)
* Fast update WYSIWYG support for source update
* Do bracket matching over hardcoding line offsets
* Update Windows command and minor update to installation cell (#12361)
* Fix windows command and minor update to installation cell
* Add expand_section field on the first section of the book
* marking intermittent test failure as unstable (#12402)
* Fix connection dialog indentation (#12401)
* fix connection dialog indentation
* indent tab body
* Remove container registry from arc control deploy (#12392)
* Fix error when clicking on header for tables with no rows (#12408)
* Change default Select query label to "Take 10" for Kusto tables (#12396)
* Change default label to "Take 10" for Kusto tables
* Addressed comments
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
* Fix resource deployment text field validation (#12421)
* Fix arc deployment regions and remove docker summary (#12430)
* start with eulaCheckButton hidden (#12427)
* start with eulaCheckButton hidden
* reset buttons on card select
* remove testcode
* fix the legacy card style issue (#12428)
* fix the legacy card style issue
* replace the card class
* Fix Spark kernel connections and switch from Kusto to Spark kernels (#12436)
* Fix connection dialog for Spark and issue when switching from Kusto to Spark
* Address comments
* Add Arc MIAA username configuration (#12429)
* Add Arc MIAA username configuration
* username -> userName
* fix postgres product name (#12443)
Co-authored-by: Brian Bergeron <brberger@microsoft.com>
* vBump azdata extension (#12452)
* Arc - Enable Postgres dashboard (#12439)
* get overview, conn strings, properties pages working
* hook up password reset, azure link, scale configuration
* fix comments
* enable opening postgres dashboard from controller dashboard
* minor fixes
Co-authored-by: Brian Bergeron <brberger@microsoft.com>
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* Remove ItemGroup from sqlproj if node being removed is the last one (#12398)
* remove ItemGroup if node being removed is the only one
* fix for if ItemGroup has elements with different tag names
* fix for ItemGroups not at the end of the sqlproj
* fix the extension dependency issue (#12347)
* Bump arc/azdata extension versions (#12463)
* Add preview to Arc controller deployment (#12465)
* Update azdata extension icon (#12469)
* small optimization for select (#12419)
* Revert BDC deployment back to using old azdata check (#12470)
* remove/use unused strings (#12460)
* Activate arc extension with resource deployment command (#12472)
* change to allow refresh and delete correctly (#12477)
* update resultSet in data provider (#12478)
* Add SQL instance name validation (#12480)
* Add SQL instance name validation
* Move -
* Update PG validation
* Fix regex
* simplify
* add table name to models that are imported (#12445)
* add table name to models
* adding null check for safety
* As per PR comment
* Arc/Azdata string updates (#12485)
* Arc/Azdata string updates
* more updates
(cherry picked from commit 2c6f7ac4472e0197650be299ec899388bb495fd8)
* couple more fixes
* more
* update sql database projects readme (#12481)
* remove option to add reference to same database (#12495)
* Update default values and example text when dropdown value changes (#12493)
* Fix PySpark kernel connection change (#12494)
* Notebooks: Fix Grids Not Rendering when Unsaved Notebook Reloaded (#12483)
* Clear Output and fix output change
* Fix tests after forced clear + append output
* Add warning message for users using the new version of jupyter book (#12496)
* Add warning message for users
* Address pr comments
* Arc Postgres - Add Azure params to overview page, update notebook (#12482)
* add azure params to pg overview page, update troubelshooting notebook, string changes
* no default pg version for notebook
Co-authored-by: Brian Bergeron <brberger@microsoft.com>
* Arc good ARC bad (#12499)
* default to 0 workers (#12506)
Co-authored-by: Brian Bergeron <brberger@microsoft.com>
* Add progress indicator for arc instance deletion (#12510)
* Fix core and memory request MIAA deploy (#12505)
* Fix core and memory request MIAA deploy
* Memory request/limit as 2Gi for MIAA
* In-Viewlet Notebooks Search (#12455)
* fix search
* Add sql carbon tags to vs files
Co-authored-by: chlafreniere <hichise@gmail.com>
Co-authored-by: abist <adbist@microsoft.com>
* Replace vCores property with state for arc controller dashboard (#12512)
* Bump extensions (#12516)
* fix the reference error due to extra $ in default variable (#12523)
* use GB instead of MB for postgres memory (#12528)
Co-authored-by: Brian Bergeron <brberger@microsoft.com>
* data workspace review feedback implementation (#12489)
* add a view to handle no workspace scenario
* text update
* project type filter improvement
* fix the project level context menu issue
* update strings
* Add timestamps to azdata output channel output (#12530)
* Fix arc controller ns/name validation (#12525)
* Fix arc controller ns/name validation
* Rename control plane references
* Fix validation
* new download location of azdata.msi (#12466)
* new download location of azdata.msi
* refactor
* Disable tests
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* move eula prompt post azdata discovery (#12532)
* new download location of azdata.msi
* move eula prompt post azdata discovery
* unacceptEula - test change
* Revert "unacceptEula - test change"
This reverts commit f84a3f5e41797de25b38f87143d66f7041b5c4ec.
* Remove Direct connectivity mode option (#12533)
* Remove Direct connectivity mode option
* remove option completely
* fix string
* Arc - Update Postgres deployment field labels and descriptions (#12537)
* update help text strings
* update field descriptions to match help text
* update cpu/memory field descriptions
Co-authored-by: Brian Bergeron <brberger@microsoft.com>
* Add troubleshoot button to arc controller/MIAA dashboard (#12534)
* Add troubleshoot button to arc controller dashboard
* Add MIAA button
* Fix links
* Change azdata output channel to Azure Data CLI (#12545)
(cherry picked from commit cdd80c66764bddb2f5ed79045fbd8a0606d1d084)
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* Fix windows azdata install (#12542)
* Fix windows azdata install
* skip failing tests
* Update/release docs (#12544)
* update changelog for 1.22
* update fwlinks
* fix format
* escape the value for display (#12547)
* Add new profile (#12556)
* Add new profile
* version
* move
* fix readonly summary page field widths (#12558)
* Arc - Enable Postgres support request link (#12560)
Co-authored-by: Brian Bergeron <brberger@microsoft.com>
* Add test for notebook result grid streaming (#12539)
* start testing convertAllData
* add test for convertAllData method
* clean up code
* bump ads and extensions (#12550)
* bump ads and extensions
* bump azdata
* bump asde deploy
* Remove command link from deployment error (#12573)
* [Kusto extension] Updated links (#12569)
* Add CodeQL Analysis workflow (#10195)
* Add CodeQL Analysis workflow
* Fix path
* updated links
* edit line 31
* edit lines 11 and 31
* edit line 11 again
Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
* Don't use deprecated param (#12574)
* add event.preventDefault() (#12564)
* strict compile for sql/workbench/contrib/queryHistory (#12579)
* clone the object to be modified (#12583)
* Strict compile for sql/workbench/services/dialog (#12578)
* Strict compile for sql/workbench/services/dialog
* fix errors
* strict compile for queryResultsView (#12581)
* Add telemetry for ModelView wizards (#12596)
* Add telemetry for ModelView wizards
* Remove unnecessary params
* Fix compile error
* Improved behavior for accepting EULA. (#12453)
* working version of overloading "select" button
* promptForEula to use showErrorMessage
* make parameter optional in promptForEula
* remove test code
* PR feedback
* eula to EULA
* minor fix
* Remove arc deployment extension check (#12598)
* add role for history tab (#12608)
* add title and tab-index for X button (#12605)
* set aria-hidden for a non-visible control (#12607)
* Convert MIAA and Postgres deploy from Dialog to NotebookWizard (#12609)
* dialog to NotebookWizard
* move fields
* fix 12599
* pr feedback
* add missing page titles
* Fix undefined error in server tree data source (#12616)
* Fix undefined error in server tree data source
* Add comment
* Add ModelViewEditorOpened event (#12597)
* Add ModelViewEditorOpened event
* fix
* Fix compile
* Update sqltoolservice release for kusto extension (#12622)
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
* Delete database reference (#12531)
* remove ItemGroup if node being removed is the only one
* fix for if ItemGroup has elements with different tag names
* fix for ItemGroups not at the end of the sqlproj
* add delete for db references
* fix failing tests
* add test
* cleanup
* Addressing comments and fixing a string
* simplify the preview information feature (#12606)
* dashboardWidget to use updated button component - added an enum for buttonType.
* Code fixes.
* Leaving default description value as empty string. Testing logic for buttonType.
* revised buttonType getter to return Normal by default if not specified in properties.
* Extended sql Button as InfoButton for use in dashboardWidget.
* Some modifications
* Rewrote elements and passed in properties from dashboardWidget to define button contents and layout.
* Styled header and button copy. Corrected button and header dimensions.
* Merged latest from main. Resolve conflicts.
Co-authored-by: Amir Omidi <amomidi@microsoft.com>
Co-authored-by: Aditya Bist <adbist@microsoft.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>
Co-authored-by: maddydev <makoripa@microsoft.com>
Co-authored-by: chlafreniere <hichise@gmail.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: Lucy Zhang <luczhan@microsoft.com>
Co-authored-by: Karl Burtram <karlb@microsoft.com>
Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
Co-authored-by: Monica Gupta <scorpio90m@gmail.com>
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
Co-authored-by: Kartik Arora <33497301+ktech99@users.noreply.github.com>
Co-authored-by: Barbara Valdez <34872381+barbaravaldez@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Vasu Bhog <vabhog@microsoft.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Udeesha Gautam <46980425+udeeshagautam@users.noreply.github.com>
Co-authored-by: nasc17 <69922333+nasc17@users.noreply.github.com>
Co-authored-by: Alex Ma <alma1@microsoft.com>
Co-authored-by: Arvind Ranasaria <ranasaria@outlook.com>
Co-authored-by: Brian Bergeron <brian.e.bergeron@gmail.com>
Co-authored-by: Brian Bergeron <brberger@microsoft.com>
Co-authored-by: Mark Ghanayem <22989000+markingmyname@users.noreply.github.com>
Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
* remove ItemGroup if node being removed is the only one
* fix for if ItemGroup has elements with different tag names
* fix for ItemGroups not at the end of the sqlproj
* add delete for db references
* fix failing tests
* add test
* cleanup
* Addressing comments and fixing a string
* working version of overloading "select" button
* promptForEula to use showErrorMessage
* make parameter optional in promptForEula
* remove test code
* PR feedback
* eula to EULA
* minor fix
* update help text strings
* update field descriptions to match help text
* update cpu/memory field descriptions
Co-authored-by: Brian Bergeron <brberger@microsoft.com>
* new download location of azdata.msi
* move eula prompt post azdata discovery
* unacceptEula - test change
* Revert "unacceptEula - test change"
This reverts commit f84a3f5e41797de25b38f87143d66f7041b5c4ec.
* add a view to handle no workspace scenario
* text update
* project type filter improvement
* fix the project level context menu issue
* update strings
* add azure params to pg overview page, update troubelshooting notebook, string changes
* no default pg version for notebook
Co-authored-by: Brian Bergeron <brberger@microsoft.com>
* remove ItemGroup if node being removed is the only one
* fix for if ItemGroup has elements with different tag names
* fix for ItemGroups not at the end of the sqlproj
* create unique query runner for each cell
* use cellUri instead of cellId to identify runner
* disconnect each query runner connection
* remove queryrunners size check
* 12360 Notebook UI - Mac/Win fix for Select all.
* Fix for ctrl key selecting all in windows
* Fix undo as well
* preventDefault to prevent confusing behavior
Co-authored-by: chlafreniere <hichise@gmail.com>
* Added sql vm deployment option
* Added more fields for sql vm deployments
* created basic sqlvm deployment. Mostly hardcoded
* added string to package.nls
* added poc deployments for sql vm
* Made some changes in the notebook that was mentioned in PR
* Added scaffolding for azure sql vm wizard.
* code cleanups
* added some async logic
* added loading component
* fixed loader code
* completed page2 of wizard
* added some more required fields.
* added some more fields
* added network settings page
* added sql server settings page
* added azure signin support and sql server settings page
* added some helper methods in wizard code
* added some fixes
* fixed azure and vm setting page
added validation in azure setting page
* added changes for the notebook variable
* validations and other bug fixes
* commenting sql storage optimization dropdown
* cleanedup wizard base page
* reversing vm image list to display newer images first
* cleaning model code
* added validations for network setting
* Completed summary page
fixed the code poisition
some additional field validations
* fixed networking page
* - fixed an error with vm size model variable
- removed byol images because it was not working with az sql vm
- Fixed vm size display names in dropdown
* added double quotes to some localized strings
* added some space inside strings
* -Added live validations
-Restyled network component
-Added required to regions
-Some bug fixes
* -redesigned summary page
-localized some strings
* Fixed summary page section titles
* -Fixed validations on sql server settings page
-Fixed some fields on Summary Page
* corrected onleave validation
using array for error messages
using Promises.all
* Fixed bug on network settings dropdowns when user does not have existing resource to populate them
* Change resource deployment display name
Added Ninar's iteration of the notebook
Changed RDP check box label
Surfacing API errors to user
Filtering regions based on Azure VM regions and user's subscription region
Made form validation async
Displaying new checkbox on network page when dropdowns empty
Fixed a small bug in SQL auth form validation
Made summary single item per row and fixed the gaps in spacing
Fixed validations in vm page
Checking if vm name already exists on azure
* Fixed sql vm eula
Fixed sql vm description
Added hyperlink for more info on vm sizes
* Replaced loading component with dropdown loaders.
* localized string
Fixed a bug in network settings page
* Added additonal filtering
* added reverse to image images
* Fixing some merge related issues
* Formatted page
* Removed ResourceHealthPage from the dashboard
* Deleted files that no longer applies to the public preview backend
* shouldn't be able to open the postgres dashboard
* Added 5 missing field options
* Missing apostrophe
* Change extensions label
* Update volume size descriptions
* Change volume size labels
* Reorder required tools
* Reorder required tools
* Argument fixes
* Removed tabs
* Rearrange option order
* Rearrange option order
* Rearrange option order VS
* Added validation to fields. VS accepts only integer and appends Gi
* Changed Dusky deployment title
* Removed text validation for VS and Mem. Changed to Number field type
* Min set to 1 for VS and Mem
* Min set to 1 for Cores
* Memory limit must be at least 256Mi
* the casing of 'preview' should remain consistent
* Removed empty line
* add existing project to workspace feature
* update file name
* new test and use URI
* handle workspace with no folder
* add more validation
* and more tests
* use forward slash
* Added loading prop to dropdowns
* Added property for setting loading text message
* removed unnecessary sets
* changed code to match new changes
* Changed the dropdown loader to use select component instead of edit.
Added missing props in dropdown loader
* show default values in text boxes
* add sqlcmd formatting
* add tests
* Add some sqlcmd variable name validation
* Addressing comments
* fixes after merge
* fix test
* don't localize OtherServer
* fix for windows
* one more fix
* fix test
* Hackathon - better markdown editor - modified Bold to wrap selection in HTML. Split Image button into two new options: embed and link. Made preview container contentEditable.
* Removed the new dropdown from Image button -- it is not necessary since we are adding a context panel instead.
* Modified preview icons
* Set code-component dimensions so it is not visible. It is still being used to pass markdown changes to however.
* add turndown and save markdown
* update model on UI when source changes
* Added conditional that sets element attribute contentEditable when it is in edit mode.
* Added textView component that can be used for editing.
* update source on MD view not on every keystroke
* Added markdown editor buttons that allow user to swap editor, preview views.
* Cleaning up implementation
* Setting base value of _showPreview to false.
* don't allow html edit on split view
* Update editor automagically
* Add an image picking dialog to notebook toolbar.
* Await transformText()
* revert pushEditOperations to fix cursor issue
* Implemented radio buttons for three view toggles.
* Added new, optional properties to radioButton: name, icon class and tooltip. This allows for display as toggleable icon. Updated styles and theme accordingly.
* Style tweaks.
* Added new ViewAction file where the RadioButton action will reside.
* Removed radio button implementation in exchange for native button instantiation. Adjusted CSS and theme accordingly.
* Styles, component and template changes to handle view toggle between text, markdownn an splitview. Includes reverting of radioButton as this is no longer used.
* WYSIWYG 3 Modes
* Ensure one action active at a time
* Setting Text View button active by default. Cleaned up styles. Moved toolbar element to prevent code cell layout overflow.
* Ensure we respect editMode, add showMarkdown
* hiding overflow on code-cell
* Empty text container needs 100% width. Eliminates weird selection border too.
* Initialize _previewMode
* Actions Compatibility
* Further toolbar enhancements
* Update yarn lock after merge
* Slim down changes
* Remove commented out code
* Added margins around notebook-preview container for more visual space for text
* Add turndown to workbench html
* Tweak import
* Add types/turndown
* Remove workbench.html fix
* Import cjs modules directly for turndown
* Leverage solution from github
* browser umd
* non browser umd
* welp dependency
* Modified updatePreview to insert a p tag only when text cell is empty.
* add listener for undo
* add turndown to remote and web
* Fix workbench, check in plugin
* PR comment
Co-authored-by: maddydev <makoripa@microsoft.com>
Co-authored-by: chlafreniere <hichise@gmail.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: Lucy Zhang <luczhan@microsoft.com>
* add projects to add database reference dialog
* able to add project references
* check for circular dependency
* only allow adding reference to project in the same workspace
* fix location dropdown when project reference is enabled
* add tests
* more tests
* cleanup
* fix flakey test
* addressing comments
* work in progress
* load projects in view and test cases
* update scope
* make the sql proj menu available in workspace view
* add extension unit test
* address comments
* fix errors
* add onResultUpdate handler in gridoutput
* convert rows to mimetype and html
* wait for data conversion to finish before saving
* detach changeRef after output is created
* fix save grid action
* move data conversion check to each cell
* move conversion logic to dataprovider
* notify data converting when user saves
* add comments and remove unused methods
* fix method return type
* fix tests
* fix convertData method header
* move azdata changes to azdata proposed
* address PR comments
* display top rows message
* fix messages/table ordering and query 100 rows
* add missing escape import
* set default max rows to 5000
* add undefined check to updateResultSet
* change gridDataConversionComplete return type
* Add support for new jupyter book version
* Add changes to the jupyter notebook to create books
* Create config file
* Add support of new version of jupyter book on ADS
* Fix paths for opening folder with v1 and v2 books
* Add tests for jupyter book v2
* Update tests
* Fix tests
* Fix get parent issue
* Address PR comments
* Fix bookVersion condition in getSections and fix issue on create book notebook
* Fix search
* update python notebook
* Remove commented lines
* For testing azdata Ext
* add back skipped test
* all tests fixed on linux
* For testing azdata Ext
* fix for mac
* brew upgrade test fix
* remove temp changes
* remove Logger.log calls from test
* _ for unused parameters
* Genericify components
* Fix compile issue
* Fix feedback
* Genericify azdata components (#12164)
* azdata generics
* Add the withProps method to azdata proposed as there may be mistakes with the interfaces in the generics
* Fix build issues because of other extensions
* Remove extra spaces
* Add CodeQL Analysis workflow (#10195)
* Add CodeQL Analysis workflow
* Fix path
* [Kusto] Update readme
* changed click to select
* Add Animated gifs and some text updtes
* add link
* change in media format syntax
* Removed peek definitions
* removed all machine learning refs
* removed en-us
* rename media to images
* removed gifs
* added back peek definitions
* changed media to images
* rename folder again and remove azuredatastudio repo link
* help whitespace identions
* renamed media files
* change image format text
* removed gifs
* add gifs back
* edit gulpfile.hygiene.js file to add gifs
* fixed image
Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
* add role on toggelMore action element
* add aria-haspopup
* Fix localization and more descriptive
* single localized constant
Co-authored-by: Vasu Bhog <vabhog@microsoft.com>
remove sqllint for now
fix hygiene
Revert "remove sqllint for now"
This reverts commit 981ff90b9a5bbf3710d0f0ce58a8b67a92fe64eb.
distro
update smoke version
fix default theme
* add suppress missing dependencies checkbox
* add example usage
* set font-styles
* Fix typo
* allow example usage to be selectable
* don't localize example usage
* move example usage strings to a new section
* WIP
* first version with working tests
* fixes needed after merge from main
* Linux untest changes and merge from other changes from mac
* after testing getTextContent
* rename 2 methods
* linux discovery
* tested code on linux
* using release.json for update discovery on linux
* comment added
* dead code removed
* coomments
* revert unrelated change
* revert testing changes
* code complete, testing pending
* test complete
* PR feedback
* remove SendOutputChannelToConsole
* cleanup
* pr feedback
* PR Feedback
* pr feedback
* pr feedback
* pr feedback
* fix loc function
* install/upgrade command - context sensitive
* add awaits as pr feedback
* cleanup
* merge from main
* merge from main
* cleanup and pr feedback
* PR feedback and cleanup
* cleanup
* pr feedback
* pr feedback.
* revert accidental changes
* cleanup
* test fixes
* test fixes and pr feedback
* pr fixes and eula similar to install/upgrade
* revert extraneous change
* log and prompt fixes
* string fixes
* string updates
* string updates based on PR feedback
* loc const rename
* pr feedback
* string fixes
* make setContext settings uniform
* add commandPallete
* eulaAccepted setContext from memento
* misc fixes
* bug fixes
* test fix
* skip failinf test for fix later
* pr feedback
* upgrading -> updating
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* add tests for Jupyter Session
* remove comment and fix description
* throw error if spark kernel provider is not mssql
* use localize strings and add pythonEnvVarPath test
* Fixed a bug with validating inputs when generating predict script
* Fixed the bug with verifying R packages
* Fixed the tests
* Added warning for when output column data type doesn't match with model output data type
* Fix the issue with selecting db
* Fix for query editor toolbar actions to show correctly based on file type when not connected
* Addressed comments
* Fix when it is .sql file but connection is kust
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
* NotebookUriHandler Test
* set test to previous, return promise for handleUri
* Added tests for file uri scheme https/http
* Updated NotebookUri to await handleUri calls and add more tests
* WIP
* first version with working tests
* fixes needed after merge from main
* Linux untest changes and merge from other changes from mac
* after testing getTextContent
* rename 2 methods
* linux discovery
* tested code on linux
* using release.json for update discovery on linux
* comment added
* dead code removed
* coomments
* revert unrelated change
* revert testing changes
* PR feedback
* remove SendOutputChannelToConsole
* cleanup
* pr feedback
* PR Feedback
* pr feedback
* pr feedback
* merge from main
* merge from main
* cleanup and pr feedback
* pr feedback
* pr feedback.
* pr feedback
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* Initial changes for adding pre/post deploy script in project
* Right click > Add pre/post deploy script
* Print script files in tree
* Add new pre-post deploy items with their own tags and additional ones with None
* Add tests
* Fix error due to merge conflicts
* Addressed comments and fixed tests.
* Fix code scan error
* Addressed comments
* auto increment db proj name
* auto increment on import project from db
* adding separate message if workspace setting is invalid
* updating based on feedback
* adding do not ask again functionality
* moving constants
* making newprojecttool only top level functions
* adding tests
* updating to address merge conflicts
* fixing tests
* fixing tests
* initial changes
* got everything lined up
* get rid of bottom scrollbar
* change database textbox to dropdown and cleanup
* more cleanup and fix profile text box
* fix label
* add fireOnTextChange to editable dropdown
* change edit icon and enable input boxes
* tests for getRow method
* use suiteSetup
* added more tests
* revert changes to gridOutput.component.ts
* mocked out services for DataResourceDataProvider
* add test for serializeResults
* change path to fsPath
* fix param type and use fs promises
* use async in startSerialization
* mock ContextService
* wip
* Fixes
* More fixes
* more fixes
* Disable when preview features disabled
* remove unused imports
* Handle promises
* PR feedback
* Single default ServerGroup color value
* ADS Core changes
* Generic fix to get language mode based on providerId
* Addressed comments
* Fix failing tests
* Fix for "New Notebook" from file menu option
* Remove line
* Fix for merge conflict
* Add removed comment back
* Addressed comments
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
* Update Open Project to display pre-post deployment scripts in the project tree
* Address comments
* Fixed tests
* Update nonDeployScripts to noneDeployScripts and throw a warning message instead of informational message for prePostDeployCount
* Able to get Kernel Alias using extension registery
* Get Kernel Alias through Capability Services
* Notebook Action feature to add kusto to dropdown based on extension - complete
* Fixed indexing issue when Kusto is in kernels Dropdown
* Kusto Kernel listed properly and selected when kernel changes
* Added kernel change when user Attaches To Kusto connection
* Deleted unnecessary code/refactored
* Fix Merge Issues
* Resolving Compile issues - test file error
* Capabilities Provider Changes
* Fixed Notebook Tests
* Rearchitect kernel changes to Notebook Model
* Address minor changes
* wip
* wip
* weird splitview scrolling stuff
* working table
* remove spliceable table
* handling resizing columns
* get perf table integrated into grid
* make more improvments to table view
* testing
* wip
* wip
* fix async data window; add more optimization to scrolling
* work on scrolling
* fix column resizing
* start working on table widget
* inital work to get table widget working with styles and mouse controls
* fix unrendering selection; fix sizes of cells
* support high perf table option; remove unused files; add cell borders to high perf
* add accessibility tags
* handle borders and row count
* more styling changfes
* fix strict null checks
* adding inital keyboard navigation
* center row count; add padding left to rows
* inital drag selection
* remove drag implementation; it can be done better utilizing the global mouse monitor object
* range logic
* create custom grid range
* work with new range
* remove unused code
* fix how plus range works
* add drag selection; change focus to set selection; fix problem with creating a range with inverse start and end
* code cleanup
* fix strict-null-checks
* fix up perf table
* fix layering
* inital table service
* finish table service
* fix some compile errors
* fix compile
* fix compile
* fix up for use
* fix layering
* remove console use
* fix strict nulls
* make table editable
* add button to load values from sqlproj
* use form component group
* match mockups
* move UI constants to a separate file
* fix error
* add support for AAD interactive for project data sources
* fix whitespace
* remove warning message
* choose azureMFA if a connection string has both integrated security=true and authentication=active directory interactive
* azure pane in connection dialog
* fix layering
* fix issues
* fix test
* more test fixes
* add back double click to connect for non-contributed views
* first changes for showing project references
* add tests
* fix interface and formatting
* add try so that project still gets loaded even if dependency project loading fails
* use instanceof
* add circular reference error
* hook in grid panel to edit data input through the editDataResultsInput
* added then at end of refreshGrid to ensure cell reset happens after refresh.
* abstraction
* Timeout removed as its causing issues with refreshing
* added await for dataRows
* Added working timeout for refresh
* removed spaces
* added comment explaining isRefresh
* Timeout set to 500 for better coverage.
Co-authored-by: Amir Omidi <amomidi@microsoft.com>
Co-authored-by: Anthony Dresser <andresse@microsoft.com>
* test changes
* maintain uri if it's not a file
* check file and path is string
* missed this
* Add SQL CARBON EDIT
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* Use vscode.URI for local paths
* Use vscode.uri file method to set the name for remotebookfull path compressed file
* Add await on extract tar function
* Replace remote paths too
* Use vscode.uri.file instead of parse for local paths
* fixes duplicate list items on welcome
* fixes duplicate list, and comments on PR
* updates to use clearNode, and removes unnecessary formatter
* awaits maplistentries, calls functions directly
* Add a test for SchemaCompareDialog and update the product code with deferred promise
* Update test to verify that button clicked worked
* Addressed comments
* Updated verifyButtonsState to use should instead of console.log
* Notebook cell toolbar additions - move up and move down added. Stubbed out related actions. Cleaned up component code.
* Added new more actions menu item: Convert cell.
* add move cell support in model
* Schema Compare cleanup (#11418)
* cleanup async and await stuff
* remove awaits
* remove more awaits
* fix (#11437)
* Add some unit tests for PyPiClient. (#11442)
* handle invalid character in kubectl version output (#11460)
* Add tests for azdata extension (#11423)
* Add tests for azdata extension
* Fail on stderr
* Skip test for not implemented logic
* Move executeCommand stub
* Add missing packages
* let semver to parse the version (#11463)
* let semver to parse the version
* check
* Stop hardcoding python3 (#11464)
* Add ConnectControllerDialog tests (#11443)
* Automatically fix up arc controller URL
* wip
* Force tests to pass
* Refactor
* comment
* adds role of button to all links that are buttons (#11465)
* Merge from vscode 0a7364f00514c46c9caceece15e1f82f82e3712f
* bump smoke extensions
* bump node version in builds
* bump smoke extensions
* Add query-history and sql-assessment to recommended extensions (#11477)
* First draft of outputProcessor tests (#11368)
* First draft of outputProcessor tests
* add return type for a function
* pr feedback
* comments and Spellings, getRandom ==> getRandomElement
* pr feedback
* pr feedback
* Adds support for installing azdata on Linux (#11469)
* Large cleanup of AzureCore - Introduction of getAccountSecurityToken and deprecation of getSecurityToken (#11446)
* do a large cleanup of azurecore
* Fix tests
* Rework Device Code
* Fix tests
* Fix AE scenario
* Fix firewall rule - clenaup logging
* Shorthand syntax
* Fix firewall tests
* Start on tests for azureAuth
* Add more tests
* Address comments
* Add a few more important tests
* Don't throw error on old code
* Fill in todo
* Adding button plugin to table component (#10918)
* Added delete plugin to table component
* Arc - Remove Azure params from Postgres deployment (#11478)
Co-authored-by: Brian Bergeron <brberger@microsoft.com>
* tests for KernelsDropdown class (#11476)
* add return type for a function
* tests for KernelsDropdown class
* remove inadvertent change
* remove inadvertent change
* formatting changes
* pr feedback
* pr feedback
* implement review feedback (#11470)
* fix sql proj sqlcmd table showing after loading profile when it shouldn't (#11479)
* Feature/outer paths for project (#11445)
* allow relative paths in project file outside of project folder
* Adding some tests
* Adding error string to loc strings
* Fixed test
* fix error message
* PR comments and some more fixes
* change userName to match what the azure account display name is (#11484)
* change userName to match what the azure account display name is
* Handle undefined value
* Merge from vscode 8c426f9f3b6b18935cc6c2ec8aa6d45ccd88021e
* recomment out integration tests
* Fix/open book error (#11379)
* add isNotebook param and showPreview option
* showPreview changes
* update OpenNotebookFolder to open a specific path
* added test for showPreviewFile
* test name typo
* remove isNotebook from openBook
* Add test coverage for dacpac wizard import flow (#11483)
* Adding importConfig onPageEnter() test
* Removing redundancy from dacpac wizard pages
* promisifying file selection so it can be awaited in the test
* removing debug prints
* PR feedback
* Remove all accounts regardless of failure in one account (#11431)
* distro (#11487)
* distro
* distro
* distro
* distro
* Adding icons to Database Projects' tree view (#11488)
* Add images
* Splitting to light and dark mode icons
* Hooks up icons to treeItems
* updating package.json with new icon and vbump
* move icon loader before tree view created
* Update Arc extension version and fix Controller connectivity status names (#11498)
* Update connectivity mode names
(cherry picked from commit f0aabcfa86d178cdf74470f9fdeded19718bcea2)
* Bump package version
(cherry picked from commit e08370539006c638d6e25c2f4f23fa2754a3377d)
* deploy to single existing device (#11494)
* deploy to single existing device
* comments
* Add versioning for accounts (#11497)
* Add versioning for accounts
* deletion value
* Changes to getAccountSecurityToken (#11502)
* Hook up convert cell
* Fix tests
* Add convert cell tests
Co-authored-by: chlafreniere <hichise@gmail.com>
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: Maddy <12754347+MaddyDev@users.noreply.github.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>
Co-authored-by: v-bbrady <60623315+v-bbrady@users.noreply.github.com>
Co-authored-by: ADS Merger <andresse@microsoft.com>
Co-authored-by: Arvind Ranasaria <ranasaria@outlook.com>
Co-authored-by: Amir Omidi <amomidi@microsoft.com>
Co-authored-by: Leila Lali <llali@microsoft.com>
Co-authored-by: Brian Bergeron <brian.e.bergeron@gmail.com>
Co-authored-by: Brian Bergeron <brberger@microsoft.com>
Co-authored-by: Udeesha Gautam <46980425+udeeshagautam@users.noreply.github.com>
Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com>
* Add setting for max number of expanded books
* Remove extra commas
* Add setting for expanding/collapsing books at root level
* Change typo in name of setting
* Change default value to false
* Add open book option in UI
* Add dropdowns option on dialog
* Add flow logic
* Fetch releases and validate URL
* Add class for github books and shared file books
* Change code structure
* Unblock local copy + stack overflows
* Download books from github
* Remove unused files
* Clean code and use the openNotebookFolder command to open remote book
* Checkpoint
* Refactor remote book dialog model to only hold data
* Remove ApiWrapper and refactor createlocalcopy method
* Use sinon js framework instead of typemoq for testing remotebookController
* Remove api wrapper
* Add some tests
* Add more tests and address pr comments
* Address PR comments
* Fix remotebook broken tests
* Add download location in output channel and use openBook command
* Address PR comments
* Fix typos, print error message and remove failing test
* Print error message
* Separate tests in different files
* Declare controller variable inside extension.tst
Co-authored-by: chlafreniere <hichise@gmail.com>
* Add images
* Splitting to light and dark mode icons
* Hooks up icons to treeItems
* updating package.json with new icon and vbump
* move icon loader before tree view created
* Adding importConfig onPageEnter() test
* Removing redundancy from dacpac wizard pages
* promisifying file selection so it can be awaited in the test
* removing debug prints
* PR feedback
* add isNotebook param and showPreview option
* showPreview changes
* update OpenNotebookFolder to open a specific path
* added test for showPreviewFile
* test name typo
* remove isNotebook from openBook
* allow relative paths in project file outside of project folder
* Adding some tests
* Adding error string to loc strings
* Fixed test
* fix error message
* PR comments and some more fixes
* add return type for a function
* tests for KernelsDropdown class
* remove inadvertent change
* remove inadvertent change
* formatting changes
* pr feedback
* pr feedback
* do a large cleanup of azurecore
* Fix tests
* Rework Device Code
* Fix tests
* Fix AE scenario
* Fix firewall rule - clenaup logging
* Shorthand syntax
* Fix firewall tests
* Start on tests for azureAuth
* Add more tests
* Address comments
* Add a few more important tests
* Don't throw error on old code
* Fill in todo
* First draft of outputProcessor tests
* add return type for a function
* pr feedback
* comments and Spellings, getRandom ==> getRandomElement
* pr feedback
* pr feedback
* Add support for installing azdata on Windows
* Don't run startup code when in test context since it blocks on UI input
* restart checks
* Disable calls for now
* unit test of the method
* stash changes
* revealActiveDocumentInViewlet test
* separate tests
* test on activate
* added tests
* feedback changes
* naming change
* initial changes for reading connection from profile
* connection string can now be read from publish.xml
* fix build errors and update test
* move publish profile tests to their own file
* cleanup
* update message
* fix string
* remove apiWrapper
* Slight import refactor
* Test updates
* Adds test, sets script name for File extractType to projectName
* generating correct folder list
* Correctly setting serverId for Imports started from Object Explorer
* Adding regression test
* uncommented test check
* Handle don't ask again button
* Change to ignore
* Change language
* Pass in tenant name and ID
* Fix message
* Don't allow common tenant to get interaction required prompt
* Move things around
* distro
* renable web smoke
* add missing script
* update node version
* update node version everywhere
* ensure playwright drivers are installed
* fix screenshot capture
* try this
* rewrite connection dialog code
* fix permissions
* more wip
* replace more $ with ^
* revert changes
* refactor and revert more changes
* add screen shot functionality to playwright
* fix compile
* fix profiler compile
* don't run new files for web
* continue on error for web
* continue on error for web not normal
* revert some changes
* Setting up tests on import extension
* -Added API wrappers for all the azdata and vscode APIs to make them easily mockable
-Added some unit tests for the import extension
-Some code logic separations
* -added code report for the import extension in ci
* Did some more code refractoring
* -Added json report generation
* updated vscodetestcoverage to latest version in import extension.
* -remove duplicate codecoverageConfig.json
* -Added some modifyColumnPage tests
* pushing temp changes
* -Added some more testcases
* -Added tests using available vscode and azdata apis
* some minor comment change
* removed unnecessary test
* added accidently removed test
* Added some comments
* fixed some broken tests and added comments in fileConfigPage
* code clean up and some more comments
* fixed the prosePreviewPage test and the download test
* added getter and setters
* Increasing timeout and fixing a comment
* removed unnecessary comments and some other code cleanup
* Deleting dotnet files before redownloading them
* - made changes in the PR
- Moved extensioncode to utils.test for better reusability
* added some 'should' messages
* add import database project to database and server dashboard home toolbar
* connection profile is getting passed to the extension
* use MenuItemAction instead of creating a new one
* move database picking
* add comment
* add helper function
* Azure IoT deployment type
* more updates
* organize fields
* a few more improvements
* resolve merge issues
* new rg improvement
* fix tests
* comments 1
* comments 2
* Move the tests out to their own tasks
* Revert change
* Lets try this
* Actually reference to the tests
* Lets try this
* lets try this too?
* this one?
* Manually define them :(
* Formatting
* Add the node command
* Fix machine learning and address comments
* Adds heading dropdown to markdown toolbar.
* Added a method specific to headings that places markdown at beginning of line selected.
* Rewrote comment for my new method.
* Revised code to support multi select for headers, similar to how unordered list is applied. Multi-line headings can be undone if the multi lines are selected.
* Modified transformText to make single-line undo operation possible with just the cursor position.
* Added utility methods to help determine if the selection is a line-only or multi-line.
* Building isReplaceOperation to determine when preceeding characters need to be replaced with a new MarkdownButtonType.
* Updated comments.
* Applied changes written by Chris.
* Reverted changes to earlier stage where heading addition works just like list item additions.
* getExtendedSelectedText now returns an actual value in range for MarkdownLineType.EVERY_LINE.
* Added conditional so that Preview element is updated only when Preview is enabled.
* Updated tests for heading toolbar: heading 1, 2 and 3.
* Removed code that could not be reached.
* Corrected tests for headings.
* wip
(cherry picked from commit 43deb9635cc0eeebaffef22d4373f1f6ad713ace)
* cleanup
* fix error
* Fix tests
* Add more testing
* delete
* re-add
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* Schema compare tests for updateSourceAndTarget method
* Merge conflict resolution
* Move resetbutton call before adding them to toolbar
* PR comments- added a buttons interface for readability and created a test class to add test functionality to the orginal class
* Moved interface ButtonState to test code
* show error when trying to create file or folder that already exists
* add test for file that already exists
* add folder tests
* fix error messages
* hide Properties folder
* update comment
* Add CodeQL Analysis workflow (#10195)
* Add CodeQL Analysis workflow
* Fix path
* fix word wrap support in the message panel
* fix width on message treee
* fix import
* fix settings editor to reflect the changes in the settings ids
* fix tests
* add configuration upgrader
* make sure to maintian execution order
* make the compiler happy
* add tests for upgrader
Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
* udpate import to have friendly names for the extract file organization options
* update tests
* update message
* remove camelcase stuff
* use localized constants instead of enum
* Change Azure region dropdown to use azurecore API for getting display name
* Fix compile errors
* Adding a few things to the vscodeignore
* and another
* -Added check all null checkbox
* Modified declarative table to add check all columns in the column header
* -changed to using existing methods for firing events.
* -changed table height to auto
-center aligned data in table cell
-Check all generates event for only changed values
* -changes column header from text to column header (#10787)
* This fixes the weird angular stuff - we need to do this in every other component
* -added changes made by amir for dom object tracking
-added automatic checkall detection.
-made text-align center in table cells
* -fixed styling issues and issue with checkboxes
* -Removed unsued function
Co-authored-by: Amir Omidi <amomidi@microsoft.com>
* Added toggle preview button to Markdown toolbar. Revised components, theme and styles to present the preview as a second column beside the markdown.
* Added showPreview to model and began working on togglePreview.
* Uncommented use of cellModel.showPreview
* add cell model event for onPreviewChange
* Renamed my showPreview boolean to prevent confusion with local boolean used in toogglePreview.
* Added CSS class when preview is enabled. Adjusted styles accordingly.
* Swapped icon show/hide references for correct sequence. Modified updatePreview to include state of doShowPreview.
* Added check for isEditMode so we can run togglePreview and show it once editor closes.
* Added listener to code.component that triggers layoutEmitter on changes to peview.
* Renamed local boolean doShowPreview. Removed unneeded code. Fixed ambiguity in my use of booleans, adding a getter and setter to textCell.
* Cleaned up implementation of new get/set for toggling preview.
Co-authored-by: chlafreniere <hichise@gmail.com>
* Added code to remove multiple separators from more actions menu.
* Moved check for separators after list is deduped.
* Logic cleanup
* Added unit test for cell toolbar ellipses menu.
* Fix tests
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* Setting up tests on import extension
* -Added API wrappers for all the azdata and vscode APIs to make them easily mockable
-Added some unit tests for the import extension
-Some code logic separations
* -added code report for the import extension in ci
* changes code coverage to 36%
* adding some comments
* Removing unnecessary exports
* -refactored test code to replicate src structure
-some changes mentioned in the pr
* removed unnecessary prefixes from test case name
* get children of unexpanded books
* highlight item inside collapsed parent in treeView
* fix path issue on windows
* refactor common code into separate func
* refactor
* don't allow adding duplicate database references
* add test
* addressing comments
* remove XML checking from databaseReferenceExists()
* change to get
* fix for windows path to show in project tree across platforms correctly
* allow retrying on project that failed to load
* test for project failed to load case
* Adding platform safe uri for database ref in tree
* Added providerRegistered test
* test for EditConnectionDialog
* changed wording
* added test for connectionInfo
* utils.ts tests added
* hasRegisteredServers test
* commented out editconnection tests, addl. tests
* added onConnectionChangedNotification test
* added changeGroupId tests
* Added connection profile changes
* added connectIfNotConnected test
* added delete connection test
* isRecent and disconnect editor tests
* added registerIconProvider test
* Fix for ensureDefaultLanguageFlavor test
* added a few tests
* utils prefix test updated
* added utils tests
* load database name from profile.xml
* load sqlcmd variables from profile
* Add warning text
* add tests
* fix file filter for windows
* add comments
* show SQLCMD variables in a table
* reset dialog before testing readPublishProfile callback
* Fixed scroll to top
* removed brackets
* Don't trigger the cellSelectionModel when className is the resizable handler
* Added message for header listener
Co-authored-by: Amir Omidi <amomidi@microsoft.com>
* Fix leak
* We don't need the full connection profiles for drag drop control
* Remove unused code
* Change test definition
* Change test definition
* Change equality check
* Setting up tests on import extension
* -Added API wrappers for all the azdata and vscode APIs to make them easily mockable
-Added some unit tests for the import extension
-Some code logic separations
* -added code report for the import extension in ci
* Did some more code refractoring
* -Added json report generation
* updated vscodetestcoverage to latest version in import extension.
* -remove duplicate codecoverageConfig.json
* able to drag objects from left pane
* changed scheme from file
* base functionality working
* extended functionality to tables
* added string literals and formatting
* cleanup
* cleanup
* added table/column parsing
* removed bad logic
* updated to use metadata
* cleanup and added sql carbon edit tags
* moved changes from vs into sql code base
* refactoring drag and drop
* cleanup
* cleanup
* cleanup
* added unit tests
* pr changes
* moved treeMock file
* fixed small bug
* add system database reference for VS
* a few fixes
* update tests
* update tests
* fix tests after merge
* addressing comment to make logic a little more clear
* fix replacing SSDT reference name in tree
* Added some logging and disabled half of the tests for sql database projects
* Comment out data souces tests, a probable test failure
* Used skip instead of actual commenting out of code
* Adding reading SqlCmdVars from project file
* organized apiWrapper, added calls
* Adding test to confirm deployment/script gen profiles with sqlcmd vars
* convert system database references from SSDT
* remove empty ItemGroup if no other database references
* fix baseline files
* also update sqlproj if system database references were added in SSDT since the sqlproj got updated with ADS imports
* undo change
* move updating system db references out of updateProjectForRoundTrip()
* update test to have an already updated system db ref
* add clean target after merge from master
* add await
* addressing comments
* add database references to same itemgroup
* show database references in tree
* update tests
* refresh project tree after a reference is added
* addressing comments
* add validation
* Add test
* sort imports
* highlight correct notebook on navigation.
* add back behavior of highight on viewlet visible
* optimize bookViewer create
* createTreeView for every book
* -"Run current" command runs the entire selection instead of only first statement in the selection
* -brought some logic back from the old code to correct the behavior
* -Added unit tests for runCurrent command
* -Fixed a comment
* - Added checks for run input parameters
* -Added some extra checks
* -Fixed some spacing issue
* Changed to using verify instead of a counter variable
* add dacpacs
* able to add reference to appropriate master dacpac
* able to add reference to a dacpac
* Add a few tests
* fix tests
* fix wording
* fix adding reference to same database
* add project tests
* fix test for windows
* addressing comments
* Adding another test
* update tests
* fix build error
* Test code for round tripping feature
* Fixed tests. Edited updateImportedTargetsToProjFile method to push newly added import target to the list.
* Added couple more tests
* Addressed comment
Fixes bug where files located in a subfolder defined before the folders themselves in .sqlproj would result in those files not appearing in the ADS treeview
* wip
* Update to latest vscodetestcover and add tests back in
* Update to latest version of vscodetestcover
* updates
* another yarn.lock
* update version
* Revert import path change
* save not yet tested work
* Merge from master.
* Screeens Shared for Feeedback
* Code complete
* remove unneeded changes
* remove unnecessary comma
* remov wss
* remove dead code
* PR feedback
* checkpoint fixes
* PR & minor fixes
* minor fix for feature of resourceType options being optional.
* reverting experimental change
* separating out changes for future featurework.
* revert unneeded change
* review feedback fixes
* review feedback
* rename InputFieldComponent to InputComponent
* working version of custom summary page
* add option to align items in a flex- container.
* changes to support labelColor
* save work , still pending issue with labelCSSStyles
* Summary page and setting variabless in notebook.
* minor fixes.
* pr feedbck
* fix formatting issues
* pr feedback
* pr feedback
* pr feedback
* fixing docs
* summary page value setting fix
* rename children of RowInfo to items
* rename a method
* rename summary_text to evaluated_text
* rename properties of fieldInfo
* revert inadvertent change
* rename linked_texttext to hyperlinked_text and removing linking facility from readonly_text
* pr feedback
* fix setting tools variables in env and notebook
* removing saving of originalValues for EvaluatedText
* await on launchNotebookWithEdits
* await on launchNotebookWithContent
* merge RadioOptions & Options into 1
* merge ReadOnlyText, links & evaluatedText
* Samples for new generic wizard features
* fix comment
* fix assertions
* return type and comment for getClusterContext
* fix inadvertent change
* increase minimum required azdata version
* remove unneeded environment variable settings
* not leaking passwords in notebooks
* initial commit to get it working
* Change configuration to use package.nls.json
* Make the necessary plumbing
* Support multi cloud
* Move the menu item to the bottom
* Fix failing tests
* Fix the tests
* 10551 - Notebook UI: Added cell toolbar component, actions scaffolding, styles and theme colors. Removed markup for legacy, hidden hover buttons. Updated instaces of icon class: mask to masked-icon.
* Uncommented lines for CellToggleMoreActions so we can see how the ellipses currently work.
* Added EditCellAction which toggles between two icons.
* Cleaned up comments and removed some unused code.
* Copied DeleteCellAction into celltoolbarActions
* Connecting model and cell model to toolbar component for necessary context.
* Pass in cell + nb model from notebook component
* Adding context for EditCellAction so we can activate a cell via icon.
* Removed my copy of AddCellAction and simply referred to the existing one.
* Fixes to propogate cell model edit mode changes
* Added onCellModeChanged event registration to code.component.
* Moved cellToggleMoreActions into cellToolbarActions. Suppressing ellipses in code and textCell components.
* Fix adding cells
* Copied and modified ToggleMoreWidgetAction for use in cellToolbarActions. Instantiating cellToggleMoreActions and adding to toolbar.
* Removed unused markup, code and styles. Moved cell toolbar template into compoent.
* Removed double-click from textCell. Changed message to indicate where content goes - without it the cell does not have dimension and cannot be found by the user.
* Removed unused code file.
* Fixing my boo boo
* Updated AddCellAction with null coalescer. Set Promise to type: void.
Co-authored-by: chlafreniere <hichise@gmail.com>
* Add and fix Notebook tests
* Fix name
* Fix compile
* Acutally fix error
* Add Notebook title test and fix command
* Add extra check and add comments
* Remove extra show error message
* Initial changes for Import database as new project
* Functionally complete code
* Initial changes for Import database as new project
* Functionally complete code
* Resolved conflicts with latest changes. Also did some code refactoring.
* Addressed comments. Added unit tests.
* Addressed comments
* Moved ExtractTarget enum from azdata to mssql
* Addressed comments
* Fixed indentation in project templates
* Reprompt for consent
* Remove unused imports
* Fix typos
* Change the tenant we re-auth too
* Handle the prompt properly
* prompt for consent dialog
* Information message modal
* product name
* Change message per PM feedback
* Fixed the issue with wrong title in predict page
* Fixed the type of ml settings
* Increased timeout
* Fixed the bug with R package management and Windows auth
* fixed the tests
* fixed a typo
* run tests in every pipeline and include integration tests
* fix test env
* fix integration test scripts
* remove windows unit tests
* remove unused tests in integrations
* add comments
* Reworking notebook action bar functionality and appearance.
* added separator
* Revised notebookActions for collapse, clear and trusted such that they can be implemented with a boolean set to T of F and show labels or shift them into tooltip for accessibility. Updated styles for select boxes. Added toolbar icons to common icon location. Split icon definition for use as masked or background-image.
* Completed styles for action icons: collapse, clear and trusted. Added theme colors. Simplified icon behavior styles.
* Made maskedIconClass optional. Added theme colors for toolbar icons, select box border and dropdown arrow. Experimenting with adding masked icon to pseudo element so I can pull out label text from icons.
* Added icons styles to handle masked SVG elements as pseudo element beside button text. Added icons using this method to respect the color theming system.
* Adjusted styles for the cell and run all icons in notebook toolbar.
* Prepped notebook toolbar with placeholder icon for Underline action. Implemented Underline action. Added custom --wip-- ButtonMenu control, a modified copy of DropDown.
* Revised colorRegistry and corresponding notebook styles. Removed unused code from new custom control: buttonMneu. Revised icon styles to create a dropdown arrow for buttonMenu.
* Added new icon for Underline action.
* Removed comment from needed markup.
* Replaced actionItemProvider with optional undefined per DropdownMenuActionViewItem constructor.
* Cleaned up new control, removing unneeded code and referencing what the class needs. Corrected style declaration for overriding input box padding. Removed unused notebook color styles. Scoped element styles to the toolbar so others outside the toolbar are not affected.
* Removed unnecessary !important from style override.
* Removed reference to unused color entry.
* Syntax cleanup.
* Put notebook toolbar improvements behind the preview flag. This involves some conditionals and CSS classes.
* Updated icon used for Manage Packages. Created and updated styles for notebook toolbar icon spacing. Modified notebook.component contributed actions so that the label text is shifted into the title attribute. Added new icon for Not Trusted toggle.
* Replaced SVG code for not-trusted icon.
* Addressed PR feedback: changed masked classname. Revised component and CSS accordingly. Removed unnecessary instance of in-preview class. Fixed code logic that assigns label text to tooltip on incoming contributed action
* add support for schema compare to specify source dacpac
* add build and dacpac produced from build
* check if dacpac exists
* add tests
* move exists check code to utils
* fix test run failing
* WIP registerKeybind
* testing command
* Moved command to query.contribution
* Moved command to editData.contribution
* simplified command
* more simplification
* Working keybind for toggle query pane added.
* removed space
* added option to always show sql pane
* removed keybind default and changed option
* added some checks
* Added return undefined
* added handling for multiple loads
* added more error handling
* minor space change
* added explanation message
* simplification
* added changes from create new row
* added some checks
* Added return undefined
* added handling for multiple loads
* added more error handling
* minor space change
* added explanation message
* simplification
* editDataGridPanel corrected
* updated to most recent master version
* removed space at end
* added newline
* added another try catch
* changed message
* added check and message
* added clarifying message
* removed redundant try catch loop
* grid data is now backed up
* wording change
* initial build command execution
* adding tests
* Clean up test names
* update SqltoolsService release in ADS for Build
* Updating as per PR comments
* updating yarn lock
* Adding one more test for command run
* Test fixes
* remove request promise for request-light
* make sure data is a string not a json
* add configure call
* remove unused reference
* more fixes
* Move configure calls
* clean up
* fix name
* move test deps as dev
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* connection picking dialog for deploy
* add data source option
* fix errors
* merge fix
* show connection name instead of connection string if there is one
* remove unnecessary async
* async (#10292)
* Revert "async (#10292)"
This reverts commit c94139aa45d8f1d868ebd251f3016315718b56ae.
* add a few tests
* addressing comments
* remove cancel click handler
* remove text box for generate script file path because it will just open up a new editor with the script
* fix test
Co-authored-by: Amir Omidi <amomidi@microsoft.com>
* rework some code and write an inital test
* fix strict
* add more to standard test
* add to existing workflow test
* fix tests
* simplify the code
* add more tests
* remove bad import
* fix compile
* fix timestampiong
* Add Cell after current active cell
* fixed error
* more fixes
* Addressed PR
* merged with master
* Fixed the tests and code
* removed try catch and modified the test to check the method does not throw.
Co-authored-by: Rajesh Kamath <rajkashop@hotmail.com>
* - Removed PG connections in the new connection wizard
- If a PG database is active sending an error
- Removed refresh button #6611
* Added back the refresh
* -Using getConnection only once.
* -Fixed the error message
-Fixed the bugs mentioned in the PR
Co-authored-by: Aasim Khan <aaskhan@microsoft.com>
* Added Edit Connection Command
* Wip changes for new connection dialog
* Testing
* WIP commit
* added ID check to ensure connection
* wip commit
* model id check implemented
* addfooterbutton now accepts events
* wip commit
* message explaining check
* temporary change
* connectionManagementService restored
* Revert "connectionManagementService restored"
This reverts commit 9704a63184a06a33bee2648ef0a899229d117cc0.
* formatting test
* editConnection promise testing
* edit existing connection command added
* WIP Connection Edit
* disconnect added to editConnection promise
* WIP on editExistingConnection
* changed isEdit to true
* Amir/edit connection (#10112)
* Get edit connection working
* Delete unused code
* check for isEdit as well
* connection tree test added
* WIP connection management tests
* comment out test to find out what's wrong
* fix for one error
* added note about test skipped
* changed signature of saveprofile
* saveprofile fixed
* wrote working test
* added additional test
* changed message
* Fixes made
* fix for matcher
Co-authored-by: Amir Omidi <amomidi@microsoft.com>
Converted `test-extensions-unit.bat` to javascript to add a small QoL improvement that I think people will find useful: specifying which extension(s) you want to run tests for instead of commenting out lines of a script.
In addition to existing behavior being mostly preserved (node test-extensions-unit.js defaults to running all unit tests), you can specify one or more:
```
node test-extensions-unit.js sql-database-projects
node test-extensions-unit.js sql-database-projects schema-compare
```
* Add a pop up for dotnet install if not present
* Second option of default location for mac/linux
* correcting the pop up message
* remove extra dependency
* updating as per PR comments
* Put new welcome page behind preview features flag (#10099)
* import correct welcome page (#10117)
Co-authored-by: Anthony Dresser <andresse@microsoft.com>
* Using azure sql compatible query
* Included changes requested in PR for azure specific DBs and then fixed issue #9361 for contained databases.
* Made some changes mentioned in the PR
- Converted let to const
- Logging the error
* Fixes for attach to. Still need to update cache
* Don't have jupyter hardcoded
* Handle DOTNET_ROOT env var
* Fix on load
* Put behind feature flag
* Cleanup
* Error check
* PR feedback
* Changed the activation event from onCommand to startup "*"
* Refractored some code to fix the issue
* Made some PR related changes and fixed a condition where the same error was occurring when the flatFileImport has to download binaries from the internet.
* Reverted activation event back to previous state as it had no effect.
* Made changes mentioned in the PR
Co-authored-by: Aasim Shahnawaz Khan <aaskhan@microsoft.com>
* Fixing potential bad order of template loading and map construction
* Fixing bug where templates get mapped before loaded from file
* Parallelizing loading templates from file
* Addresses bug: 10062. Replaced scrollTop with getBoundingClientRect.top minus the combined height of the top tabs and action bar.
* Setting initial value of chrome offset, and checking for existence of both tool bars before getting their heights.
* fixes the video images not showing when a 2nd welcome page is opened, and replace the admin pack image
* deletes unused image
* hardcodes video image src into html
* removes dead code
* embeds require.toUrl in markup
* Adding enablePreviewFeatures check before showing the new toolbar.
* Removed unused code.
* Added hook to trigger onDidChangeConfiguration -- this makes the UI change after user has checked or unchecked, without having to restart the app.
* Initializing the component with the current config value of enablePreviewFeatures.
* layout properties in 2 columns
* fix height after collapsing
* update with reflow values
* set height better
* cleanup
* fix crashing when resizing while properties widget is loading
* Switch to grid layout
* Only two columns max
* Update comment
* Undo color change
* Cleanup
* Fix test
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* makes the preview button hover state stay active when hovering over tooltip
* fixes the duplicating list on the extension pack when a 2nd welcome page tab is opened
* Markdown editor toolbar - initial commit
* Moved icons. Refactored new toolbar component to include markup.
* Edited markdown toolbar component and referencing in textCell component markup.
* Completed UI updates for selected cell toolbar and markdown toolbar.
* Modified import path to Event class. Changed EventEmitter to Emitter.
* Cleaned up newly added toolbar components
* Works sometimes sometimes editor is null
* Removed commented out code and styles. CellToolbar and MarkdownToolbar: moved component markup into html file.
* Added icon for highlight. Removed more commented code. Re-scoped two styles to their parent components. Corrected templateUrl reference for the new toolbars.
* Adjusted paths to SVG icons from toolbar stylesheet.
* Add lists and links
* Refactor out of component, add actionbar
* Support for nothing selected, quick bug fix
* Updated split view icons. Added markdown tool backgrounds and cell border colors to color registry and parent components. Updated toolbar icons to use mask as this allows the SVG icon colors to be adjusted on theme change.
* Added colorRegistry entries for code cell. Removed colors from styles. Running registerThemingParticipant from code.component.
* Revised code component style rules and corrected syntax.
* Merged in Chris' working branch and removed unused markup.
* Corrected styles and moved another color into colorRegistry for use in new markdown toolbar.
* Corrected style error. Overrode left position of content inside textCell and codeCell. Added more entries to colorRegistry.
* Moved toolbar and editor icons to common-icons location. Updated related stylesheet. Revised color theming rules for markdown and code cells.
* Added themed border between markdown and preview. Moved all notebook themes into notebookStyles.ts
* Merged in latest from origin/master and included a small but significant style tweak to light theme code cell toolbar.
* Add Undo Support for Markdown Toolbar (#9915)
* Remove comment
* Renamed registered notebook colors and prefixed with notebook. Moved markdown component theme colors into notebookStyles.ts. Removed colors from cellToolbar styles. Revised icon class names to generic names for better re-use. Removed commented markup.
Co-authored-by: chlafreniere <hichise@gmail.com>
Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>
* Added Notebook telemetry for livesite
* added back the metadata retension code
* Unified Telemetry services
* fixed names
* Fixed texts to use new NullAdsTelemetryService
* Validate GUID before sending it
* made GUID check a bit more robust
Co-authored-by: Rajesh Kamath <rajkashop@hotmail.com>
* WIP sash fix
* stuff to fix
* working mostly
* added tabbedPanel fix
* added null checks
* removed additional space in editdata.css
* wip change for border-top
* Fix for query editor and editdata colors in modes
* removed junk additions for panel.css
* fixed div and classes for editDataGridPanel,
* small optimizations
* Small tweaks
* simplified color checks
* test commit
* Test changes
* no need for important
* updates made
* removed small space
* initial changes for actionbar collapsing
* fix more not always all showing after resizing
* collapse toolbar if window size is already small when dashboard is opened
* make wrapping default behavior and collapse opt in
* fix so keyboard navigation works in overflow
* more keyboard fixing so that the actions in overflow get triggered
* change overflow background with theme
* change margin
* udpate more button
* use icon for ...
* addressing comments
* overflow css changes to match portal
* arrow navigation working
* handle tab and shift tab in overflow
* keep arrow navigation within overflow
* move reused code to helper methods
* set roles for overflow
* use actionsList instead of document.getElementById all the time
* move collapsible action bar to its own class
* renamve to overflowActionBar
* fix focus rectangle around more element
* hide overflow after an action is executed
* hide overflow when clicking an action
* hide overflow when focus leaves and loop focus within overflow when using arrow keys
* fix double down arrow to move focus in overflow
* update comment
* fix clicking more not hiding overflow
* add box-shadow for themes
* fix hygiene error
* fix hygiene error
* widen focused outline for overflow actions
* move properties widget collapse to bottom
* fix double bottom border for high contrast
* show title when collapsed
* move css to classes
* vertical center collapse icon
* adds icons for welcome page
* updates markup and styles for welcome page
* updates color registry with welcome page colors
* updates styles for welcome page
* updates markup for welcome page
* updates theming styles for welcome page and adds date since last opened functionality on history items
* adds all icons and images for welcome page
* updates markup for welcome page
* updates styles for welcome page
* updates color registry with welcome page styles
* updates welcome page icons with microsoft flag and dark theme home banner
* updates welcome page markup
* updates dynamically generated extension list
* updates styles for welcome page
* updates markup for welcome page
* adds dynamic lists for extension pack individual extensions
* updates icons for welcome page
* updates styles for welcome page
* updates welcome page styles
* updates theme colors
* updates markup for welcome page
* updates color registry with welcomepage colors
* updates sql.de.xlf with copy for welcome page
* reverts generated file
* updates welcome page styles
* updates extension pack copy casing
* updates color registry with welcome page styles
* updates welcome page markup
* adds welcome page icons
* updates welcome page markup
* updates welcome page icons
* updates welcome page styles
* reverts color registry in vs folder to original state
* moves color registry to sql folder
* removes dead code, localizes dates
* updates welcome page styles
* moves all colors from css to color registry
* updates styles by removing all colors
* removes stat import because of laying issue, adds color registry colors to welcomePage
* updates welcome page font sizes to ems
* updates localized strings
* removes unnecessary comment
* removes double quotes around string key for single quotes
* updates welcome page styles
* updates color registry
* updates welcome page markup
* adds dropdown button functionality
* adds centering classes for installed button text
* updates welcome page styles
* updates markup and styles for welcome page
* removes icon attempt from color registry
* removes theme specific icon svgs for theme specific icon css
* removes unused import
* removes console.log
* adds back mac new file button
* removes unused rules
* updates markup
* updates markup
* updates extension links to link to extensions in ADS
* pulls in changes from welcome-page-reskin-anthonydresser
* adds back code-icon to vs folder
* reverts welcomePage.css
* removes duplicate color registry variables
* fixes icon overlap on text for mac
* removes null import
* updates welcome page styles for mac
* updates welcome page images to use sql folder
* updates welcome page markup
* updates welcome page styles
* updates styles
* updates files paths
* delete images from sql folder
* updates icons
* updates welcome page styles
* updates preview popup
* updates markup for accessibility
* adds hover state to tiles
* updates dropdown
* fixes line-height issue
* updates class names
* updates keyboard accessibility for tooltip
* format document
* updates accessibility for preview tooltip
* removes whitespace
* updates preview modal accessibility
* adds aria labels to popup and tooltip
* removes max-width for zoom
* removes escaped strings, adds keycodes to promises, marks function as async and has the return as the signature of the function
* moves keycoes to class, removes comment
* fixes promise
* testing promise
* testing promise
* promise test
* localizes copy
* uses keycode import
* removes unnecessary arguments
* formating
* refactor constructor into async function called by constructor
* attempts to fix floating promise
* removes floating promise
* moves icons and images to sql folder, removes unused icons
* uses icons already existing in ads
* updates styles
* updates color registry
* updates keycode events
* fixes issues per charles comments
* moves icons to media folder
* updates image file paths
* updates file path
* adds href to extension pack extensions
* fixes links
* fixes issues per alan's comments
* uses exisiting colors from color registry
* updates welcome page to use existing colors from color registry
* updates dark theme
* updates color registry
* updates dark theme
* formats css
* fixes dropdown arrow icon on mac
Co-authored-by: Anthony Dresser <andresse@microsoft.com>
* initial changes
* Enable cloud console
* Delete unnecessary code
* error handling
* error handling
* Deal with promises
* Fix externals
* Fix externals for ws
* Cleanup name of terminal
* Update yarn.lock
* Fix yarn.lock
* Fix externals
* Cleanup parts of the code
* Fix more issues
* Fix cloud terminal
* Go back to our client ID
* Fix message
* Respect preferred location
* Fix govt cloud
* Some more messaging
* Enable items on right click
* Some feedback
* Change to status message
Adds the ability for the user to select from two or more linked azure accounts, using an integrated UI dialog, when executing a query that requires a Always Encrypted column master key located in Azure Key Vault.
* Fix the select box issue
* map => forEach
* Fix tests and a product issue
* Maybe another potential fix
* Fix a few more issues
* Change backendValue to value
* localization
* Use Array.isArray
* dashboard improvement - WIP (#8836)
* wip
* wip
* tabgroup
* tab group
* agent views
* clean up
* formats
* feedback
* fix error
* contribute top level server/db dashboard tab (#8868)
* tabbedPanel component (#8861)
* tabbed panel
* tabbed panel
* fix errors
* revert main.ts changes
* use margin
* address comments
* remove orientation property
* content tab group (#8878)
* add databases tab
* use more extensible approach
* remove unnecessary code
* add when expression
* objects tab for database dashboard (#8892)
* fix build errors
* fix build error
* Dashboard toolbar (#9118)
* remove old toolbar with only edit and refresh
* remove tasks widgets from server and databases dashboards
* adding toolbar to dashboardpage and clicking new query works
* restore and new notebook now do something
* add backup to toolbar for database dashboards
* new notebook connects to db
* only show backup and restore for non-azure
* new backup and restore svgs
* clean up
* got toolbar actions to show up from contribution
* some cleanup and add database dashboard toolbar contributions
* don't show all tasks when there should be no tasks
* fix toolbar showing multiple times when switching opening another dashboard from OE
* only show toolbar for home page
* update to new icons - same icons for light and dark theme
* don't show separator if there aren't any actions
* read toolbar actions from tasks-widget
* remove tasks widget from home dashboard page
* show extension's actions in toolbar
* clean up
* more cleaning up
* fix extension actions not always loading the first time
* add configure dashboard
* remove old edit icon css
* change tasks back to original order
* make sure tasks widget is the one being removed
* collapsible tab panel (#9221)
* collapsible vertical tab panel
* fix lint error
* comments batch 1
* pr comments
* update new query icon (#9351)
* Update toolbar actions (#9313)
* remove edit and configure dashboard and add refresh to toolbar for other dashboard pages too
* Add refresh for tabs that have container type with refresh implemented
* change refresh to only refresh the current tab
* remove map for tab to actions
* add back configure dashboard to home toolbar
* check if index is -1 before trying to remove tasks widget from widgets
* Move objects widget back to database home tab (#9432)
* move objects widget back to database home tab and reorder toolbar
* change order of actions back to previous order
* Allow extensions to add actions to home toolbar (#9269)
* add support for extensions to add actions to home toolbar
* fix spacing
* use menu contribution point
* undo previous changes that added dashboardToolbarHomeAction contribution
* remove home from name
* add context key for tab name
* allow actions to also be added to the toolbar of other tabs
* add extension contributed actions even if no tasks-widget
* fix refresh being added twice after merging
* hide the tab list when collapsed (#9529)
* update the order of css selectors (#9606)
* Update dashboard style to be closer to mockups (#9570)
* update style to be closer to mockups
* tab panel styling
* change back tab styling for tabs in a tab contributed by an extension
* change color of borders when theme changes
* set dark theme active tab background to same as OE for now
* update border colors
* move colors to theme file
* fix a few issues (#9690)
* couple fixes
* comments
* small dashboard toolbar fixes (#9695)
* fix backup icon in toolbar
* fix database page toolbar border color
* add back center center in common-icons.css (#9703)
* change padding so bottom border shows again (#9710)
* tab panel fixes (#9724)
* tab panel fixes
* fix package.nls.json
* feedbacks (#9761)
* feedbacks
* remove comments
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
* Handle webmode
* Fix keytar
* Specify that it can be null too.
* Configuraiton option
* Fix callback URL
* Update message, only show if the user is on Linux
* Change message
* Connection management service work
* Fix tests
* Change how accounts are deleted
* Be consistent with names
* feedback
* Fix based on feedback
* Change sqltoolsservice version
* async-await install service; add check for the files after downloading
* remove del
* use the same function for installing service
* fix for unix
* fix ssmin on linux
* fix syntax
* fix script
* fix issue
* Work around coveralls parallel upload issue
* Make dir
* Fix extension paths
* Revert "Fix extension paths" (#9639)
This reverts commit 4598561f858a62b49de5f951de95c099889a85b2.
Co-authored-by: Amir Omidi <amomidi@microsoft.com>
* address untitled editor file name differences; remove feature for updating title for untitled to content
* add tests for new methods
* fix tests
* fix up tests
* remove unncessary await
* revert changes to title for content
* Prevent check in openerService for cmdregistry
* Revert "Prevent check in openerService for cmdregistry"
This reverts commit c40079e6f38dcd379941474accc1a1e3b42f6103.
* Add internal command that calls extension command
* Add comment
* initial commit
* Add Reveal in Books editor tab context option
* Select item in books viewlet automatically
* changes
* easier than i thought it'd be
* added file watcher on toc file v1
* Merge from Feat/create book
* Undo Merge from Feat/create book
* Use fsPath instead of path
* repen book on toc update
* update book in-place
* fix close book
* error handling for closeBook
* PR comments
* addressed comments
* moved the watch block to try ,watch vs watchFile
Co-authored-by: chlafreniere <hichise@gmail.com>
Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>
* add schema compare to database connection context menu
* don't show dacfx and schema compare in context menus for system dbs
* Remove checks for system db
* undo whitespace change
* Add Reveal in Books editor tab context option
* Select item in books viewlet automatically
* changes
* easier than i thought it'd be
* Merge from Feat/create book
* Undo Merge from Feat/create book
* Use fsPath instead of path
* PR comments
* Fix tests
Co-authored-by: Maddy <12754347+MaddyDev@users.noreply.github.com>
* added secondary action
* create book command
* open as untitled
* create toc.yml and update title
* added comments
* throw error if filenames have unsupported chars
* update prompt message
* remove the toLocaleLower
* added await
* moced createbookpath out of the command handler
* removed tolocalelower and added comments
* moved the formatting and file handling code from core to notebook
* fixes for contents with folders
* collapse the code cell
* remove output
* reused existing command to open book
* comment typu and added await
* some optimization
* check for table
* fix table resizing
* Fix for sash crash
* Removed space
* small optimization
* small change in message
* small change
* changed wording
* removed timeout for onResize
* Removed onGridRendered
* fix isCellOnScreen
* small spacing fixes
* removed timeout in gridParentComponent
* fix for indexing
* reduced instances of "self"
* minor fixes for self and this
* Checkpoint
* Adding mock contents for tree
* added open sqlproj dialog
* reading files from directory
* Added directory traversal
* Adding tree sorting by folder vs file and label
* Improved auto-unfolding of tree based on node type
* replacing fs with fs.promise alias
* PR feedback
* added activation event for when workspace contains sqlproj files
* Returning after displaying error
* Fixing linter errors
* Reworked tree
* Fixing missing grandchildren
* Correcting tree URI construction
* Refactoring to isolate tree item responsibilities from data model responsibilities
* project file parsing
* constructing tree from project files rather than filesystem
* Fixing double-initialization
* Changing projectEntry to take enum for file type
* Correct node type for project item
* Parsing datasources.json
* Child nodes for sql data source
* Localizing strings
* Checkpoint
* Adding mock contents for tree
* added open sqlproj dialog
* reading files from directory
* Added directory traversal
* Adding tree sorting by folder vs file and label
* Improved auto-unfolding of tree based on node type
* replacing fs with fs.promise alias
* PR feedback
* added activation event for when workspace contains sqlproj files
* Returning after displaying error
* Fixing linter errors
* Reworked tree
* Fixing missing grandchildren
* Correcting tree URI construction
* Refactoring to isolate tree item responsibilities from data model responsibilities
* project file parsing
* constructing tree from project files rather than filesystem
* Fixing double-initialization
* Changing projectEntry to take enum for file type
* Correct node type for project item
* Parsing datasources.json
* Child nodes for sql data source
* Localizing strings
* missed file in merge
* changed extension method to helper
* cleanup
* Adding docstrings
* remove required from dropdowns
* set required for dropdown
* also set required for editable dropdown
* add back required for db and server dropdowns
* add back to required to databaseLoader
* Even more robust handling of extension tree loading
* Fix initial loading and add new test for CMS
* Fix compile errors
* Fix logic
* Remove debug log statements
* Support for removing hardcode deployment options
* Add missing file
* Generalize errors and make name and id required. Sort dropdowns.
* Fix test
* Capitalize text
* set dirty for editdata to false (prevent backup)
* small wording change
* Temporary fix for issue
* using proper fix
* Used editInputData onDidChangeDirty
* Moved all code to editDataInput
* Implemented fix from notebooks into editdata.
* Fix for unregistering copy service
* Fix in QueryEditorService
* add handling in case of changes made while editing
* Small optimization, removed setdirty in sql check
* moved onDidChangeDirty to EditDataInput
* some text changes
* small fix for consistency in slickColorTheme
* another commmit
* Now shows blank grid, nullcheck in queryhistory
* renamed onAngularLoaded to onComponentLoaded
* removed whitespace
* removed unused dataservice import
* now displays data, need to fix contextmenu actions
* minor changes
* another small commit
* added timeout for context menu
* updated queryhistoryserviceimpl
* removed log
* added commented out contextmenuregistrations
* context menu now shows up need to test
* added plugin registration WIP
* another commit
* yet another commit
* added wip function
* Clean up commit
* more cleaning up
* removed accessor
* renamed instances of parts
* updated
* fixed merge conflicts
* refactored bootstrapparams
* fixed code
* small changes to format
* set editable to true for testing
* added more options
* moved options to separate variable
* added texteditorclass for later
* added rudimentary create editor support
* changed grid.resize.emit to fire
* added formatterfactory
* added tslint disable
* removed debug message
* added more functions from Slickgrid.ts
* added wip handlechanges function
* another change
* added columndefinitions
* Managed to display table using handlechange
* added ability to edit for now
* added changes to table creation
* added setupevents
* added onInit
* fixed sql.xlf
* minor changes
* tidying up
* more cleaning up
* changed console.log messages to debug ones.
* added this.enableEditing
* made changes to getoverridabletexteditor
* fixed opencontextmenu
* added timeout for detectChange
* need to find way to run oncontext asynchronously
* check stuff
* oncontextmenu now no longer constantly refreshes
* added oldDataRows for future use
* add check for datarows
* small changes made
* set enableediting to true
* more changes
* added additional information for handlechanges
* another change
* more changes
* set enableediting to true
* fixed rerender
* added small test mssage for jquery
* text editor is in getOverridableTextEditorClass()
* removed debug messages
* added transparency for input.editor for table.
* need to find out how to add editing for input
* Added grid div to make slickgrid style work
* reinstated selected.
* disabled selectedcellcssclass
* restored selected
* removed selectionmodel due to not being found in the original code
* Added externalSelectionModel for correct results
* removed selectionmodel as its not used.
* WIP work on refreshresultsets
* temporarily bringing back selection model for now
* added getSelectedRanges from slickgrid into Table
* added getselectedranges from slickgrid into table
* small cleanup changes
* removed detectchanges
* removed last of detectchanges
* return of toprownumber
* no need for toprownumber
* removed isColumnLoading
* some small formatting
* fixed null check
* added back todo comment
* Added fix for context menu
* small change
* added missing value to getFormatter in grid panel
* added fix for last row italics
* added fix for null inconsistencies
* Some consolidation
* added new check for null cells
* minor change
* add check for selections (usually undefined)
* removed null check in formatters
* Some changes made
* changed plugins array
* removed todo
* renamed some variables
* deleted html file
* Moved height and width to editData.css
* added box-sizing for slickgridcontainer
* fixed editdatagridpanel css
* added small changes
* More minor changes
* removed params
* renamed refreshResultsets to refreshDatasets
* removed the stylesheet.remove lines
* added fix for null
* removed tables
* removed spaces in refreshGrid
* More minor changes
* optimization and formatting
* removal of unnecessary lines
* replaced firstRender in some parts with firstLoad
* Added timeout fix
* minor changes
* Still testing
* cleanup
* restored 200 timeout
* added styling changes for editdata
* removed angular2-slickgrid and added styling
* Small formatting changes to editDataGridPanel
* consolidation
* Fixes for broken notebook experience
* add sql carbon edit
* sql carbon edit
* add another sql carbon edit for import
* Set untitledResource instead of no resource
* Implemented match case and whole wrd
* removed unused ref
* renamed test method
* escape \
* refactored search
* added more tests
* updated tests appying match case and whole word to spcl characters
* regex update
* spcl to special
* non-capturing group added to the regex
* test
* Fix new editor windows to open with global connection
* Fix test
* Fix tests
* Move logic to queryInputFactory
* Remove unused function
* Remove unneeded check
* Add tests
* Added fix for italics for last row
* Added null handling in formatters
* Fixed issue with null not italicizing on grid
* small formatting fix
* some consolidation
* removed null check
* minor change
* removed null check in formatters
* updates to existing book tests
* notebookFindModal tests
* remove commented code
* undo book test changes
* undo book test changes
* resolve the find array
* additional tests
* add test for schema compare include exclude
* combine a few checks
* small fixes
* add testData folder to whtiespace check exclusion list
* addressing comments
* fix testData path in gulpfile.hygiene.js
* move change up a couple lines
* Adds rule for .icon extensions
* revert
* Fixed issue and formatted for consistency
* reverted change for regular menuentryaction
* changed id back to old name
* Removed comment
* removed space
This change adds to handlers to unexpected promise rejection scenarios.
This PR fixes#8640
* add handlers for promise rejections
* Displaying all tools load errors
* Update toolBase.ts - setting errorMessage to be displayed in the additional information field
* disable the select button when tools not discovered
* PR fixes
* Adding mock contents for tree
* added open sqlproj dialog
* reading files from directory
* Added directory traversal
* Adding tree sorting by folder vs file and label
* Improved auto-unfolding of tree based on node type
* replacing fs with fs.promise alias
* added activation event for when workspace contains sqlproj files
* Returning after displaying error
* initial commit
* get notebook content
* skeleton for find in notebookModel
* add search function and keyboard shortcut
* add command for hiding find widget
* started on search logic
* continue search logic
* continue search logic
* add findcountchange listener
* notebook find position
* added css class
* hide find widget
* focus find input
* search for multiple occurrences in one line
* start notebook find decorations
* start adding decorations to notebook model
* added editor_model_defaults
* added cursor position
* merged master and resolved husky erros
* initial changes added to Lucyls base implementation
* pass NotebbokRange instead of Range to decorations
* changes after merging master
* temp changes for testing
* style updates from vscode merge
* implemented the empty methods and added supporting functionality from textModel
* just a little error checking
* It gets more and more yellow
* making highlight work between code cells
* highlight only word
* remove highlight on close and maintain the position
* cleanup of unused references
* clean up
* find between code cells refactored
* highlight markdown line and scroll to it
* find index fix
* find index fix
* code clean up
* remove commented code
* tslint fix for: Cannot use global 'NodeJS'
* linting rule fixes
* deltaDecoration base implementation on the base class
* moced class defnitions from interface fikle
* updated action names
* DOM.addClass instead of overwriting
* resooved conflicts
* moved 'find' code away from notebookmodel to sep class
* moved find realted code to seperate folder
* created notebookFindModel
* clean up
* highlight color changes
* spacing and typo fixes
* highlight correct element for nested elements
* do not iterate through paragraphs and li
* find accross notebooks
* keep track of index
* clear decorations on close
* floating promises
* maintain search context
Co-authored-by: Lucy Zhang <lucyzhang929@gmail.com>
Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>
We noticed that if displayName is undefined this method would return the first auth type it found as getAuthTypeDisplayName() would return undefined.
If the displayName is undefined, we would not have a matchingTYpe and it should be undefined.
This dev container includes configuration for a development container for working with Code - OSS in a local container. For using [GitHub Codespaces](https://github.com/features/codespaces) follow the [prebuilt setup](prebuilt/README.md) which installs VNC for displaying the application window.
> **Note:** You will need X11's `DISPLAY` or Wayland's `WAYLAND_DISPLAY` environment variable set locally to allow for the Code - OSS window to display. See [Running GUI app on WSL](https://learn.microsoft.com/en-us/windows/wsl/tutorials/gui-apps) for Windows and [Quartz](https://www.xquartz.org) for Mac.
## Quick start
1. Install Docker Desktop or Docker for Linux on your local machine. (See [docs](https://aka.ms/vscode-remote/containers/getting-started) for additional details.)
2.**Important**: Docker needs at least **4 Cores and 8 GB of RAM** to run a full build with **9 GB of RAM** being recommended. If you are on macOS, or are using the old Hyper-V engine for Windows, update these values for Docker Desktop by right-clicking on the Docker status bar item and going to **Preferences/Settings > Resources > Advanced**.
> **Note:** The [Resource Monitor](https://marketplace.visualstudio.com/items?itemName=mutantdino.resourcemonitor) extension is included in the container so you can keep an eye on CPU/Memory in the status bar.
3. Install [Visual Studio Code Stable](https://code.visualstudio.com/) or [Insiders](https://code.visualstudio.com/insiders/) and the [Dev Containers](https://aka.ms/vscode-remote/download/containers) extension.

> **Note:** The Dev Containers extension requires the Visual Studio Code distribution of Code - OSS. See the [FAQ](https://aka.ms/vscode-remote/faq/license) for details.
4. Due to the size of the repository we strongly recommend cloning it on a Linux filesystem for better bind mount performance. On macOS we recommend using a Docker volume (press <kbd>F1</kbd> and select **Dev Containers: Clone Repository in Container Volume...**) and on Windows we recommend using a WSL folder:
- Make sure you are running a recent WSL version to get X11 and Wayland support.
- Use the WSL extension for VS Code to open the cloned folder in WSL.
- Press <kbd>F1</kbd> and select **Dev Containers: Reopen in Container**.
Next: **[Try it out!](#try-it)**
## Try it!
To start working with Code - OSS, follow these steps:
1. In your local VS Code client, open a terminal (<kbd>Ctrl/Cmd</kbd> + <kbd>Shift</kbd> + <kbd>\`</kbd>) and type the following commands:
```bash
yarn install
bash scripts/code.sh
```
2. You should now see Code - OSS!
Next, let's try debugging.
1. Shut down Code - OSS by clicking the box in the upper right corner of the Code - OSS window.
2. Go to your local VS Code client, and use the **Run / Debug** view to launch the **VS Code** configuration. (Typically the default, so you can likely just press <kbd>F5</kbd>).
> **Note:** If launching times out, you can increase the value of `timeout` in the "VS Code", "Attach Main Process", "Attach Extension Host", and "Attach to Shared Process" configurations in [launch.json](../../.vscode/launch.json). However, running `scripts/code.sh` first will set up Electron which will usually solve timeout issues.
3. After a bit, Code - OSS will appear with the debugger attached!
Enjoy!
# Notes
The container comes with VS Code Insiders installed. To run it from an Integrated Terminal use `VSCODE_IPC_HOOK_CLI= /usr/bin/code-insiders .`.
[](https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/microsoft/vscode)
This repository includes configuration for a development container for working with Code - OSS in a local container or using [GitHub Codespaces](https://github.com/features/codespaces).
> **Tip:** The default VNC password is `vscode`. The VNC server runs on port `5901` and a web client is available on port `6080`.
## Quick start - local
If you already have VS Code and Docker installed, you can click the badge above or [here](https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/microsoft/vscode) to get started. Clicking these links will cause VS Code to automatically install the Dev Containers extension if needed, clone the source code into a container volume, and spin up a dev container for use.
1. Install Docker Desktop or Docker for Linux on your local machine. (See [docs](https://aka.ms/vscode-remote/containers/getting-started) for additional details.)
2.**Important**: Docker needs at least **4 Cores and 8 GB of RAM** to run a full build with **9 GB of RAM** being recommended. If you are on macOS, or are using the old Hyper-V engine for Windows, update these values for Docker Desktop by right-clicking on the Docker status bar item and going to **Preferences/Settings > Resources > Advanced**.
> **Note:** The [Resource Monitor](https://marketplace.visualstudio.com/items?itemName=mutantdino.resourcemonitor) extension is included in the container so you can keep an eye on CPU/Memory in the status bar.
3. Install [Visual Studio Code Stable](https://code.visualstudio.com/) or [Insiders](https://code.visualstudio.com/insiders/) and the [Dev Containers](https://aka.ms/vscode-remote/download/containers) extension.

> **Note:** The Dev Containers extension requires the Visual Studio Code distribution of Code - OSS. See the [FAQ](https://aka.ms/vscode-remote/faq/license) for details.
4. Press <kbd>Ctrl/Cmd</kbd> + <kbd>Shift</kbd> + <kbd>P</kbd> or <kbd>F1</kbd> and select **Dev Containers: Clone Repository in Container Volume...**.
> **Tip:** While you can use your local source tree instead, operations like `yarn install` can be slow on macOS or when using the Hyper-V engine on Windows. We recommend the "clone repository in container" approach instead since it uses "named volume" rather than the local filesystem.
5. Type `https://github.com/microsoft/vscode` (or a branch or PR URL) in the input box and press <kbd>Enter</kbd>.
6. After the container is running, open a web browser and go to [http://localhost:6080](http://localhost:6080), or use a [VNC Viewer](https://www.realvnc.com/en/connect/download/viewer/) to connect to `localhost:5901` and enter `vscode` as the password.
Anything you start in VS Code, or the integrated terminal, will appear here.
Next: **[Try it out!](#try-it)**
## Quick start - GitHub Codespaces
1. From the [microsoft/vscode GitHub repository](https://github.com/microsoft/vscode), click on the **Code** dropdown, select **Open with Codespaces**, and then click on **New codespace**. If prompted, select the **Standard** machine size (which is also the default).
> **Note:** You will not see these options within GitHub if you are not in the Codespaces beta.
2. After the codespace is up and running in your browser, press <kbd>Ctrl/Cmd</kbd> + <kbd>Shift</kbd> + <kbd>P</kbd> or <kbd>F1</kbd> and select **Ports: Focus on Ports View**.
3. You should see **VNC web client (6080)** under in the list of ports. Select the line and click on the globe icon to open it in a browser tab.
> **Tip:** If you do not see the port, <kbd>Ctrl/Cmd</kbd> + <kbd>Shift</kbd> + <kbd>P</kbd> or <kbd>F1</kbd>, select **Forward a Port** and enter port `6080`.
4. In the new tab, you should see noVNC. Click **Connect** and enter `vscode` as the password.
Anything you start in VS Code, or the integrated terminal, will appear here.
Next: **[Try it out!](#try-it)**
### Using VS Code with GitHub Codespaces
You may see improved VNC responsiveness when accessing a codespace from VS Code client since you can use a [VNC Viewer](https://www.realvnc.com/en/connect/download/viewer/). Here's how to do it.
1. Install [Visual Studio Code Stable](https://code.visualstudio.com/) or [Insiders](https://code.visualstudio.com/insiders/) and the the [GitHub Codespaces extension](https://marketplace.visualstudio.com/items?itemName=GitHub.codespaces).
> **Note:** The GitHub Codespaces extension requires the Visual Studio Code distribution of Code - OSS.
2. After the VS Code is up and running, press <kbd>Ctrl/Cmd</kbd> + <kbd>Shift</kbd> + <kbd>P</kbd> or <kbd>F1</kbd>, choose **Codespaces: Create New Codespace**, and use the following settings:
-`microsoft/vscode` for the repository.
- Select any branch (e.g. **main**) - you can select a different one later.
- Choose **Standard** (4-core, 8GB) as the size.
4. After you have connected to the codespace, you can use a [VNC Viewer](https://www.realvnc.com/en/connect/download/viewer/) to connect to `localhost:5901` and enter `vscode` as the password.
> **Tip:** You may also need change your VNC client's **Picture Quality** setting to **High** to get a full color desktop.
5. Anything you start in VS Code, or the integrated terminal, will appear here.
Next: **[Try it out!](#try-it)**
## Try it!
This container uses the [Fluxbox](http://fluxbox.org/) window manager to keep things lean. **Right-click on the desktop** to see menu options. It works with GNOME and GTK applications, so other tools can be installed if needed.
> **Note:** You can also set the resolution from the command line by typing `set-resolution`.
To start working with Code - OSS, follow these steps:
1. In your local VS Code client, open a terminal (<kbd>Ctrl/Cmd</kbd> + <kbd>Shift</kbd> + <kbd>\`</kbd>) and type the following commands:
```bash
yarn install
bash scripts/code.sh
```
2. After the build is complete, open a web browser or a [VNC Viewer](https://www.realvnc.com/en/connect/download/viewer/) to connect to the desktop environment as described in the quick start and enter `vscode` as the password.
3. You should now see Code - OSS!
Next, let's try debugging.
1. Shut down Code - OSS by clicking the box in the upper right corner of the Code - OSS window through your browser or VNC viewer.
2. Go to your local VS Code client, and use the **Run / Debug** view to launch the **VS Code** configuration. (Typically the default, so you can likely just press <kbd>F5</kbd>).
> **Note:** If launching times out, you can increase the value of `timeout` in the "VS Code", "Attach Main Process", "Attach Extension Host", and "Attach to Shared Process" configurations in [launch.json](../../.vscode/launch.json). However, running `scripts/code.sh` first will set up Electron which will usually solve timeout issues.
3. After a bit, Code - OSS will appear with the debugger attached!
# This dockerfile is used to build up from a base image to create an image a cache.tar file containing the results of running "prepare.sh".
# Other image contents: https://github.com/microsoft/vscode-dev-containers/blob/master/repository-containers/images/github.com/microsoft/vscode/.devcontainer/base.Dockerfile
// FORKED FROM https://github.com/eslint/eslint/blob/b23ad0d789a909baf8d7c41a35bc53df932eaf30/lib/rules/no-unused-expressions.js
// and added support for `OptionalCallExpression`, see https://github.com/facebook/create-react-app/issues/8107 and https://github.com/eslint/eslint/issues/12642
/**
* @fileoverview Flag expressions in statement position that do not side effect
console.error('[translation-remind rule]: File with resources to pull from Transifex was not found. Aborting translation resource check for newly defined workbench part/service.');
comment:'region comments should start with a camel case identifier, `:`, then either a GH issue link or owner, e.g #region myProposalName: https://github.com/microsoft/vscode/issues/<number>',
# Each line is a file pattern followed by one or more owners.
# Syntax can be found here: https://docs.github.com/free-pro-team@latest/github/creating-cloning-and-archiving-repositories/about-code-owners#codeowners-syntax
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed. -->
<!-- Use Help > Report Issue to prefill these. -->
<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🔎 Search existing issues to avoid creating duplicates. -->
<!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://github.com/Microsoft/azuredatastudio#try-out-the-latest-insiders-build-from-main -->
<!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in Azure Data Studio to pre-fill useful information. -->
- Azure Data Studio Version:
- OS Version:
Steps to Reproduce:
1.
2.
<!-- 🔧 Launch with `azuredatastudio --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes/No
<!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->
comment:"Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues [here](https://aka.ms/vscodeissuesearch). See also our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines.\n\nHappy Coding!"
}
]
perform:true,
commands:
[
{
type:"label",
name:"Needs Logs",
action:"comment",
comment:"We need more info to debug your particular issue. If you could attach your logs to the issue (ensure no private data is in them), it would help us fix the issue much faster.\n\nTo find your logs:\n\n- Open command palette (Click **View** -> **Command Palette**)\n- Run the command: **`Developer: Open Logs Folder`**\n\nThis will open the log file locally. Please include renderer.log",
We need more info to debug your particular issue. If you could attach your logs to the issue (ensure no private data is in them), it would help us fix the issue much faster.
1. First open the Settings page, find the `Mssql: Tracing Level` setting and change that to `All` then restart Azure Data Studio.
2. Open command palette (Click **View** -> **Command Palette**) and run the command `Developer: Set Log Level...` and set the level to `Trace`.
3. Run the repro scenarios.
4. Collect the following logs:
**Console Logs**
- Open Developer Tools (Help -> Toggle Developer Tools)
- Click the **Console** tab
- Click in the log area and select all text (CTRL+A)
- Save this text into a file named console.log and attach it to this issue.
- Developer Tools can be closed via Help -> Toggle Developer Tools
**Application Logs**
- Open command palette (Click **View** -> **Command Palette**)
- Run the command: **`Developer: Open Logs Folder`**
- This will open the log folder locally. Please zip up this folder and attach it to the issue.
5. Now you can revert the Log/Tracing levels changes made in step 1 and step 2.
# actions for Needs Logs - Azure label
Needs Logs - Azure:
comment:|
We need more info to debug your Azure Active Directory issue. If you could attach your logs to the issue (ensure no private data is in them), it would help us fix the issue much faster.
- In the settings menu, find the setting titled `Azure: Logging Level` and select the `Verbose` option
- Restart Azure Data Studio
- Run the process that produces your error
- Open command palette (Click **View** -> **Command Palette**)
- Run the command: **`Developer: Open Logs Folder`**
- Follow this path to find the Azure Accounts log file: `[default log folder]/exthost1/output_logging_[earliest timestamp]/#-Azure Acounts.log`
- Please attach the Azure-Accounts.log file to the issue.
# actions for Out of Scope label
Out of Scope:
comment:"Thank you for your feedback! This feature is currently out of scope and we do not plan to work on it in a currently planned release. We will close this issue to keep our backlog focused on requests that we are planning to work on. Please note that users can continue to vote and comment on closed issues, which we encourage as it helps us understand user interest and can provide more details about why a feature is requested."
"value": "## tl;dr: Triage Inbox\n\nAll inbox issues but not those that need more information. These issues need to be triaged, e.g assigned to a user or ask for more information"
"value": "New issues or pull requests submitted by the community are initially triaged by an [automatic classification bot](https://github.com/microsoft/vscode-github-triage-actions/tree/master/classifier-deep). Issues that the bot does not correctly triage are then triaged by a team member. The team rotates the inbox tracker on a weekly basis.\n\nA [mirror](https://github.com/JacksonKearl/testissues/issues) of the VS Code issue stream is available with details about how the bot classifies issues, including feature-area classifications and confidence ratings. Per-category confidence thresholds and feature-area ownership data is maintained in [.github/classifier.json](https://github.com/microsoft/vscode/blob/main/.github/classifier.json). \n\n💡 The bot is being run through a GitHub action that runs every 30 minutes. Give the bot the opportunity to classify an issue before doing it manually.\n\n### Inbox Tracking\n\nThe inbox tracker is responsible for the [global inbox](https://github.com/microsoft/vscode/issues?utf8=%E2%9C%93&q=is%3Aopen+no%3Aassignee+-label%3Afeature-request+-label%3Atestplan-item+-label%3Aplan-item) containing all **open issues and pull requests** that\n- are neither **feature requests** nor **test plan items** nor **plan items** and\n- have **no owner assignment**.\n\nThe **inbox tracker** may perform any step described in our [issue triaging documentation](https://github.com/microsoft/vscode/wiki/Issues-Triaging) but its main responsibility is to route issues to the actual feature area owner.\n\nFeature area owners track the **feature area inbox** containing all **open issues and pull requests** that\n- are personally assigned to them and are not assigned to any milestone\n- are labeled with their feature area label and are not assigned to any milestone.\nThis secondary triage may involve any of the steps described in our [issue triaging documentation](https://github.com/microsoft/vscode/wiki/Issues-Triaging) and results in a fully triaged or closed issue.\n\nThe [github triage extension](https://github.com/microsoft/vscode-github-triage-extension) can be used to assist with triaging — it provides a \"Command Palette\"-style list of triaging actions like assignment, labeling, and triggers for various bot actions."
},
{
"kind": 1,
"language": "markdown",
"value": "## All Inbox Items\n\nAll issues that have no assignee and that have neither **feature requests** nor **test plan items** nor **plan items**."
"value": "## Papercuts\n\nThis notebook serves as an ongoing collection of papercut issues that we encounter while dogfooding. With that in mind only promote issues that really turn you off, e.g. issues that make you want to stop using VS Code or its extensions. To mark an issue (bug, feature-request, etc.) as papercut add the labels: `papercut :drop_of_blood:`",
"editable": true
},
{
"kind": 1,
"language": "markdown",
"value": "## All Papercuts\n\nThese are all papercut issues that we encounter while dogfooding vscode or extensions that we author.",
"value": "### Bug Verification Queries\r\n\r\nBefore shipping we want to verify _all_ bugs. That means when a bug is fixed we check that the fix actually works. It's always best to start with bugs that you have filed and the proceed with bugs that have been filed from users outside the development team. "
},
{
"kind": 1,
"language": "markdown",
"value": "#### Config: update list of `repos` and the `milestone`"
The software may collect information about you and your use of the software and send it to Microsoft. Microsoft may use this information to provide services and improve our products and services. You may turn off the telemetry as described in the repository. There are also some features in the software that may enable you and Microsoft to collect data from users of your applications. If you use these features, you must comply with applicable law, including providing appropriate notices to users of your applications together with a copy of Microsoft's privacy statement. Our privacy statement is located at <https://go.microsoft.com/fwlink/?LinkID=824704>. You can learn more about data collection and use in the help documentation and our privacy statement. Your use of the software operates as your consent to these practices.
[](https://gitter.im/Microsoft/sqlopsstudio?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
Azure Data Studio is a data management tool that enables you to work with SQL Server, Azure SQL DB and SQL DW from Windows, macOS and Linux.
Azure Data Studio is a data management and development tool with connectivity to popular cloud and on-premises databases. Azure Data Studio supports Windows, macOS, and Linux, with immediate capability to connect to Azure SQL and SQL Server. Browse the [extension library](wiki/List-of-Extensions) for additional database support options including MySQL, PostreSQL, and MongoDB.
## **Download the latest Azure Data Studio release**
Platform | Link
-- | --
Windows User Installer | https://go.microsoft.com/fwlink/?linkid=2109256
Windows System Installer | https://go.microsoft.com/fwlink/?linkid=2109085
Windows ZIP | https://go.microsoft.com/fwlink/?linkid=2109255
macOS ZIP | https://go.microsoft.com/fwlink/?linkid=2109180
Linux TAR.GZ | https://go.microsoft.com/fwlink/?linkid=2109179
Linux RPM | https://go.microsoft.com/fwlink/?linkid=2109178
Linux DEB | https://go.microsoft.com/fwlink/?linkid=2109254
Please visit our [download page](https://aka.ms/getazuredatastudio) for more specific installation instructions.
Check out the [change log](https://github.com/Microsoft/azuredatastudio/blob/main/CHANGELOG.md) or [release notes](https://learn.microsoft.com/sql/azure-data-studio/release-notes-azure-data-studio) for additional details of what's in the each release.
The [Azure Data Studio documentation](https://learn.microsoft.com/sql/azure-data-studio) includes complete details on getting started, connection quickstarts, and feature tutorials.
## **Feature Highlights**
@@ -46,7 +79,7 @@ See the [change log](https://github.com/Microsoft/azuredatastudio/blob/master/CH
If you are interested in fixing issues and contributing directly to the code base,
@@ -59,12 +92,14 @@ please see the document [How to Contribute](https://github.com/Microsoft/azureda
This project has adopted the [Microsoft Open Source Code of Conduct](https://opensource.microsoft.com/codeofconduct/). For more information see the [Code of Conduct FAQ](https://opensource.microsoft.com/codeofconduct/faq/) or contact [opencode@microsoft.com](mailto:opencode@microsoft.com) with any additional questions or comments.
## Localization
Azure Data Studio localization is now open for community contributions. You can contribute to localization for both software and docs. https://aka.ms/SQLOpsStudioLoc
Azure Data Studio is localized into 10 languages: French, Italian, German, Spanish, Simplified Chinese, Traditional Chinese, Japanese, Korean, Russian, and Portuguese (Brazil). The language packs are available in the Extension Manager marketplace. Simply, search for the specific language using the extension marketplace and install. Once you install the selected language, Azure Data Studio will prompt you to restart with the new language.
Localization is now opened for 10 languages: French, Italian, German, Spanish, Simplified Chinese, Traditional Chinese, Japanese, Korean, Russian, and Portuguese (Brazil). Help us make Azure Data Studio available in your language!
## Telemetry
Azure Data Studio collects telemetry data, which is used to help understand how to improve the product. For example, this usage data helps to debug issues, such as slow start-up times, and to prioritize new features. While we appreciate the insights this data provides, we also know that not everyone wants to send usage data and you can disable telemetry as described in the [disable telemetry reporting](https://aka.ms/ads-disable-telemetry) documentation.
## Privacy Statement
The [Microsoft Enterprise and Developer Privacy Statement](https://privacy.microsoft.com/en-us/privacystatement) describes the privacy statement of this software.
The [Microsoft Privacy Statement](https://go.microsoft.com/fwlink/?LinkID=824704) describes the privacy statement of this software.
## Contributions and "Thank You"
We would like to thank all our users who raised issues, and in particular the following users who helped contribute fixes:
@@ -121,19 +156,8 @@ We would like to thank all our users who raised issues, and in particular the fo
* olljanat for `Implemented npm version check (#314)`
* Adam Machanic for helping with the `whoisactive` extension
* All community localization contributors:
* French: Adrien Clerbois, ANAS BELABBES, Antoine Griffard, Arian Papillon, Eric Macarez, Eric Van Thorre, Jérémy LANDON, Matthias GROSPERRIN, Maxime COQUEREL, Olivier Guinart, thierry DEMAN-BARCELÒ, Thomas Potier
* Italian: Aldo Donetti, Alessandro Alpi, Andrea Dottor, Bruni Luca, Gianluca Hotz, Luca Nardi, Luigi Bruno, Marco Dal Pino, Mirco Vanini, Pasquale Ceglie, Riccardo Cappello, Sergio Govoni, Stefano Demiliani
* German: Anna Henke-Gunvaldson, Ben Weissman, David Ullmer, J.M. ., Kai Modo, Konstantin Staschill, Kostja Klein, Lennart Trunk, Markus Ehrenmüller-Jensen, Mascha Kroenlein, Matthias Knoll, Mourad Louha, Thomas Hütter, Wolfgang Straßer
* Spanish: Alberto Poblacion, Andy Gonzalez, Carlos Mendible, Christian Araujo, Daniel D, Eickhel Mendoza, Ernesto Cardenas, Ivan Toledo Ivanovic, Fran Diaz, JESUS GIL, Jorge Serrano Pérez, José Saturnino Pimentel Juárez, Mauricio Hidalgo, Pablo Iglesias, Rikhardo Estrada Rdez, Thierry DEMAN, YOLANDA CUESTA ALTIERI
* Chinese (simplified): DAN YE, Joel Yang, Lynne Dong, Ryan(Yu) Zhang, Sheng Jiang, Wei Zhang, Zhiliang Xu
* Chinese (Traditional): Bruce Chen, Chiayi Yen, Kevin Yang, Winnie Lin, 保哥 Will, 謝政廷
* Korean: Do-Kyun Kim, Evelyn Kim, Helen Jung, Hong Jmee, jeongwoo choi, Jun Hyoung Lee, Jungsun Kim정선, Justin Yoo, Kavrith mucha, Kiwoong Youm, MinGyu Ju, MVP_JUNO BEA, Sejun Kim, SOONMAN KWON, sung man ko, Yeongrak Choi, younggun kim, Youngjae Kim, 소영 이
* Russian: Andrey Veselov, Anton Fontanov, Anton Savin, Elena Ostrovskaia, Igor Babichev, Maxim Zelensky, Rodion Fedechkin, Tasha T, Vladimir Zyryanov
* Portuguese Brazil: Daniel de Sousa, Diogo Duarte, Douglas Correa, Douglas Eccker, José Emanuel Mendes, Marcelo Fernandes, Marcondes Alexandre, Roberto Fonseca, Rodrigo Crespi
And of course, we'd like to thank the authors of all upstream dependencies. Please see a full list in the [ThirdPartyNotices.txt](https://raw.githubusercontent.com/Microsoft/azuredatastudio/master/ThirdPartyNotices.txt)
And of course, we'd like to thank the authors of all upstream dependencies. Please see a full list in the [ThirdPartyNotices.txt](https://raw.githubusercontent.com/Microsoft/azuredatastudio/main/ThirdPartyNotices.txt)
Microsoft takes the security of our software products and services seriously, which includes all source code repositories managed through our GitHub organizations, which include [Microsoft](https://github.com/Microsoft), [Azure](https://github.com/Azure), [DotNet](https://github.com/dotnet), [AspNet](https://github.com/aspnet), [Xamarin](https://github.com/xamarin), and [our GitHub organizations](https://opensource.microsoft.com/).
If you believe you have found a security vulnerability in any Microsoft-owned repository that meets [Microsoft's definition of a security vulnerability](https://docs.microsoft.com/en-us/previous-versions/tn-archive/cc751383(v=technet.10)), please report it to us as described below.
## Reporting Security Issues
**Please do not report security vulnerabilities through public GitHub issues.**
Instead, please report them to the Microsoft Security Response Center (MSRC) at [https://msrc.microsoft.com/create-report](https://msrc.microsoft.com/create-report).
If you prefer to submit without logging in, send email to [secure@microsoft.com](mailto:secure@microsoft.com). If possible, encrypt your message with our PGP key; please download it from the [Microsoft Security Response Center PGP Key page](https://www.microsoft.com/en-us/msrc/pgp-key-msrc).
You should receive a response within 24 hours. If for some reason you do not, please follow up via email to ensure we received your original message. Additional information can be found at [microsoft.com/msrc](https://www.microsoft.com/msrc).
Please include the requested information listed below (as much as you can provide) to help us better understand the nature and scope of the possible issue:
* Type of issue (e.g. buffer overflow, SQL injection, cross-site scripting, etc.)
* Full paths of source file(s) related to the manifestation of the issue
* The location of the affected source code (tag/branch/commit or direct URL)
* Any special configuration required to reproduce the issue
* Step-by-step instructions to reproduce the issue
* Proof-of-concept or exploit code (if possible)
* Impact of the issue, including how an attacker might exploit the issue
This information will help us triage your report more quickly.
If you are reporting for a bug bounty, more complete reports can contribute to a higher bounty award. Please visit our [Microsoft Bug Bounty Program](https://microsoft.com/msrc/bounty) page for more details about our active programs.
## Preferred Languages
We prefer all communications to be in English.
## Policy
Microsoft follows the principle of [Coordinated Vulnerability Disclosure](https://www.microsoft.com/en-us/msrc/cvd).
Some files were not shown because too many files have changed in this diff
Show More
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.